[pgAdmin4][RM4041] Graphical explain plan is not rendering for a query

[Aditya Toshniwal]

Hi Hackers,

This is a regression of json related commit. As json data is sent as text
now, explain plan data (which is json data type) is not displaying.
Attached patch will make the required changes in explain plan.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RM4041.patch
Description: Binary data

[pgAdmin4][Patch]: RM #3659 Query tool does not give warning when Auto Commit is turned on in an incomplete transaction

[Akshay Joshi]

Hi Hackers,

Attached is the patch to fix RM #3659 "Query tool does not give warning
when Auto Commit is turned on in an incomplete transaction".

Please review it.
-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


RM_3659.patch
Description: Binary data

Re: [RM#3998] Custom encode forward slashes in the grid title

[Aditya Toshniwal]

Hi Murtuza,

Will this work if server name contains - !PG! ?

On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hello,
>
> PFA patch for the issue RM#3998. If the URL contains the forward slash
> value in the query tool title and if pgAdmin4 is behind Apache server then
> it fails to open to query tool and the user gets an error 404 because by
> default Apache does not allow encoded slashes in the URL and return 404.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [RM#3998] Custom encode forward slashes in the grid title

[Murtuza Zabuawala]

On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Murtuza,
>
> Will this work if server name contains - !PG! ?
>

No, it won't and it's a custom signature we can finalize it whatever team
thinks will work if the functionality is working properly.


>
> On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hello,
>>
>> PFA patch for the issue RM#3998. If the URL contains the forward slash
>> value in the query tool title and if pgAdmin4 is behind Apache server then
>> it fails to open to query tool and the user gets an error 404 because by
>> default Apache does not allow encoded slashes in the URL and return 404.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

Re: [RM#3998] Custom encode forward slashes in the grid title

[Aditya Toshniwal]

Hi Murtuza,

I would suggest adding a new url param like "?fslash=12,15", which says
where to put the forward slashes.

So if server name is "PostgreSQL/11" - connecting to postgres database with
postgres username:
Old URL:
http://localhost:5005/datagrid/panel/3400871/true/postgres%2Fpostgres%40PostgreSQL%2F11?query_url=&server_type=pg

New URL:
http://localhost:5005/datagrid/panel/3400871/true/postgrespostgres%40PostgreSQL11?query_url=&server_

type=pg&fslash=8,27

Value extracted: postgrespostgres@PostgreSQL11
Using fslash param, put the forward slashes in the mentioned positions:
postgres/postgres@PostgreSQL/11



On Fri, Mar 1, 2019 at 4:07 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

>
> On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>> Will this work if server name contains - !PG! ?
>>
>
> No, it won't and it's a custom signature we can finalize it whatever team
> thinks will work if the functionality is working properly.
>
>
>>
>> On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hello,
>>>
>>> PFA patch for the issue RM#3998. If the URL contains the forward slash
>>> value in the query tool title and if pgAdmin4 is behind Apache server then
>>> it fails to open to query tool and the user gets an error 404 because by
>>> default Apache does not allow encoded slashes in the URL and return 404.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [RM#3998] Custom encode forward slashes in the grid title

[Dave Page]

That's a good idea. Seems much more robust.

On Fri, Mar 1, 2019 at 11:02 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Murtuza,
>
> I would suggest adding a new url param like "?fslash=12,15", which says
> where to put the forward slashes.
>
> So if server name is "PostgreSQL/11" - connecting to postgres database
> with postgres username:
> Old URL:
> http://localhost:5005/datagrid/panel/3400871/true/postgres%2Fpostgres%40PostgreSQL%2F11?query_url=&server_type=pg
>
> New URL:
> http://localhost:5005/datagrid/panel/3400871/true/postgrespostgres%40PostgreSQL11?query_url=&server_
> 
> type=pg&fslash=8,27
>
> Value extracted: postgrespostgres@PostgreSQL11
> Using fslash param, put the forward slashes in the mentioned positions:
> postgres/postgres@PostgreSQL/11
>
>
>
> On Fri, Mar 1, 2019 at 4:07 PM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>>
>> On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Murtuza,
>>>
>>> Will this work if server name contains - !PG! ?
>>>
>>
>> No, it won't and it's a custom signature we can finalize it whatever team
>> thinks will work if the functionality is working properly.
>>
>>
>>>
>>> On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hello,

 PFA patch for the issue RM#3998. If the URL contains the forward slash
 value in the query tool title and if pgAdmin4 is behind Apache server then
 it fails to open to query tool and the user gets an error 404 because by
 default Apache does not allow encoded slashes in the URL and return 404.


 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Set the Gunicorn worker timeout to match the configur

[Dave Page]

Set the Gunicorn worker timeout to match the configured session expiry. 
Partially fixes #3656

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f552519ed6c5b3d005a7fe849322f47010342127

Modified Files
--
pkg/docker/entrypoint.sh | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Optimise the Docker file to minimise the number of la

[Dave Page]

Optimise the Docker file to minimise the number of layers and maximise the 
chances that changes will be in the last layers built.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d8f9e3e87be988c83f58b370e9cb7e31a1163860

Modified Files
--
pkg/docker/Dockerfile | 64 +++
1 file changed, 29 insertions(+), 35 deletions(-)

pgAdmin 4 commit: Fix graphical explain now that JSON data is sent as t

[Dave Page]

Fix graphical explain now that JSON data is sent as text to stop JS futzing 
with it. Fixes #4041

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=74cfeabd02c8fd63d2604ac826dae7ed4308a91e
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 57 --
1 file changed, 31 insertions(+), 26 deletions(-)

Re: [pgAdmin4][RM4041] Graphical explain plan is not rendering for a query

[Dave Page]

Thanks, applied.

On Fri, Mar 1, 2019 at 8:57 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> This is a regression of json related commit. As json data is sent as text
> now, explain plan data (which is json data type) is not displaying.
> Attached patch will make the required changes in explain plan.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [RM#3998] Custom encode forward slashes in the grid title

[Murtuza Zabuawala]

Hello Aditya,

Yes, that is a better approach, PFA updated patch.

Thanks,
Murtuza


On Fri, Mar 1, 2019 at 4:35 PM Dave Page  wrote:

> That's a good idea. Seems much more robust.
>
> On Fri, Mar 1, 2019 at 11:02 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>> I would suggest adding a new url param like "?fslash=12,15", which says
>> where to put the forward slashes.
>>
>> So if server name is "PostgreSQL/11" - connecting to postgres database
>> with postgres username:
>> Old URL:
>> http://localhost:5005/datagrid/panel/3400871/true/postgres%2Fpostgres%40PostgreSQL%2F11?query_url=&server_type=pg
>>
>> New URL:
>> http://localhost:5005/datagrid/panel/3400871/true/postgrespostgres%40PostgreSQL11?query_url=&server_
>> 
>> type=pg&fslash=8,27
>>
>> Value extracted: postgrespostgres@PostgreSQL11
>> Using fslash param, put the forward slashes in the mentioned positions:
>> postgres/postgres@PostgreSQL/11
>>
>


>
>>
>>
>> On Fri, Mar 1, 2019 at 4:07 PM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>>
>>> On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Murtuza,

 Will this work if server name contains - !PG! ?

>>>
>>> No, it won't and it's a custom signature we can finalize it whatever
>>> team thinks will work if the functionality is working properly.
>>>
>>>

 On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hello,
>
> PFA patch for the issue RM#3998. If the URL contains the forward slash
> value in the query tool title and if pgAdmin4 is behind Apache server then
> it fails to open to query tool and the user gets an error 404 because by
> default Apache does not allow encoded slashes in the URL and return 404.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

 --
 Thanks and Regards,
 Aditya Toshniwal
 Software Engineer | EnterpriseDB Software Solutions | Pune
 "Don't Complain about Heat, Plant a tree"

>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_3998_v1.diff
Description: Binary data

pgAdmin 4 commit: Fix resizing of the results grid, when full of data.

[Dave Page]

Fix resizing of the results grid, when full of data.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6d295727c0277d841e170a38099182aa9102a3c
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 8 
1 file changed, 4 insertions(+), 4 deletions(-)

Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

[Dave Page]

On Fri, Mar 1, 2019 at 5:39 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find the attached fix.
>
> Thanks,
> Khushboo
>
>
> On Thu, Feb 28, 2019 at 6:58 PM Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Feb 28, 2019 at 3:46 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Wed, Feb 27, 2019 at 4:30 PM Dave Page  wrote:
>>>
 Hi

 Thanks - that fixed the double scrollbar, but not the other issue. Any
 ideas on that one?

>>> Can you please provide the exact steps to reproduce the second issue as
>>> after fixing the first one I can't reproduce it.
>>>
>>
>> Sure - movie seems easiest, so grab some popcorn and put the attached on
>> the big screen!
>>
> Unfortunately, I don't have a big screen, so I missed the opportunity to
> have popcorn. :)
>

Booo :-(

Well, anyway - the sizing issue seems OK now, but if I have a table (id
serial primary key, data text) with enough rows that I need to scroll, when
I scroll to the end I can edit the id field in place, but the text editor
popup doesn't show up. If I try to edit a row further up, it seems to
appear in a weird place, so I suspect it's just rendering off-screen.

I think we should render it directly against the cell - above if the cell
is >50% down in the overall screen, else above, and something similarly
sane for the left/right.

Not sure if this is a regression or not, but it's unusable as-is, so can
you fix that too? I'll commit your current patch.

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix download CSV for IE11 which doesn't support the d

[Dave Page]

Fix download CSV for IE11 which doesn't support the download attribute. Fixes 
#4040

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb747b803134cff6faa1115c1962100a2ce3bedb
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)

Re: [RM#4040] Fix Download CSV option on IE11

[Dave Page]

Thanks, applied.

On Fri, Mar 1, 2019 at 6:49 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> We have used download attribute to download CSV file from query tool but
> IE11 does not support download attribute, we will use msSaveBlob() instead
> for IE11.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add full support and testsfor all PG server side enco

[Dave Page]

Add full support and testsfor all PG server side encodings. Fixes #3992. Fixes 
#3982. Fixes #3911

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=849e34c2f763a9d084bd21840df6dde60c0a1b06
Author: Khushboo Vashi 

Modified Files
--
.../tools/sqleditor/tests/test_encoding_charset.py | 187 +++--
web/pgadmin/utils/driver/psycopg2/connection.py|  25 +--
web/pgadmin/utils/driver/psycopg2/encoding.py  |  64 +--
web/pgadmin/utils/driver/psycopg2/typecast.py  |  12 +-
web/pgadmin/utils/tests/test_encoding.py   | 154 +++--
5 files changed, 380 insertions(+), 62 deletions(-)

pgAdmin 4 commit: Update release notes.

[Dave Page]

Update release notes.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a

Modified Files
--
docs/en_US/release_notes_4_3.rst | 3 +++
1 file changed, 3 insertions(+)

Re: [pgAdmin4][Patch] - Encoding Fixes

[Dave Page]

Thanks, applied.

On Fri, Mar 1, 2019 at 7:06 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to support all the supported encodings by
> PostgreSQL.
>
> Thanks,
> Khushboo
>
> On Thu, Feb 28, 2019 at 10:53 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Wed, Feb 27, 2019 at 4:57 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Tue, Feb 26, 2019 at 9:01 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch to fix the encoding related issues.

 #3992 - View data causes errors with DB encoding EUC_JIS_2004
 #3982 - Encoding Problem with PGAdmin 4.2
 #3911 - Data output does not display Arabic in WIN1256 encoding
 database
 - The CSV download for the same encoding has also been fixed.

 I have tested the patch on Python 2.7, 3.5, 3.6 and 3.7.

>>>
>>> You've added a couple of new encodings, but it seems to me that we
>>> should just add everything that PostgreSQL supports. For example, we now
>>> have win1256, but what about 866, 874, 1250, 1251 etc?
>>>
>>> The full list is at https://www.postgresql.org/docs/11/multibyte.html
>>>
>>> Any reason not to do that?
>>>
>> I thought to fix the reported bugs first and after that, I was about to
>> add a new ticket to add the remaining supported encodings.
>> But as per you, I will add the remaining encodings along with these fixes.
>>
>>>
>>>
>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python34 #959

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Fix download CSV for IE11 which doesn't support the download 
attribute.

[Dave Page] Add full support and testsfor all PG server side encodings. Fixes 
#3992.

[Dave Page] Update release notes.

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a
Commit message: "Update release notes."
 > git rev-list --no-walk c6d295727c0277d841e170a38099182aa9102a3c # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.4

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python34] $ /bin/sh -xe /tmp/jenkins7013314295712083325.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.4 virtual environment...

Using base prefix '/usr/local/python-3.4'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.4/bin/python3
DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be the last 
one supporting it. Please upgrade your Python as Python 3.4 won't be maintained 
after March 2019 (cf PEP 429).
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting Flask==0.12.4 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 9))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 10))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 11))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 12))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 14))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 17))
Collecting six>=1.11.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting speaklater==1.3 (from -r requirements.txt (line 19))
Collecting sqlparse==0.2.4 (from -r requirements.txt (line 20))
  Using cached 
https://files

Build failed in Jenkins: pgadmin4-master-python36 #958

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Fix download CSV for IE11 which doesn't support the download 
attribute.

[Dave Page] Add full support and testsfor all PG server side encodings. Fixes 
#3992.

[Dave Page] Update release notes.

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a
Commit message: "Update release notes."
 > git rev-list --no-walk c6d295727c0277d841e170a38099182aa9102a3c # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python36] $ /bin/sh -xe /tmp/jenkins5699603715968128809.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.6 virtual environment...

Using base prefix '/usr/local/python-3.6'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.6/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting Flask==0.12.4 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 9))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 10))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 11))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 12))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 14))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 17))
Collecting six>=1.11.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting speaklater==1.3 (from -r requirements.txt (line 19))
Collecting sqlparse==0.2.4 (from -r requirements.txt (line 20))
  Using cached 
https://files.pythonhosted.org/packages/65/85/20bdd72f4537cf2c4d5d005368d502b2f464ede22982e724a82c86268eda/sqlparse-0.2.4-py2.py3-none-any.whl
Collecting WTForms==2.1 (from -r requirements.txt (line 21))
C

pgAdmin 4 commit: Fix PEP-8 issue.

[Dave Page]

Fix PEP-8 issue.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecbba79c2a11d5d367b9c1b3fb5b2bd1b7573ef4

Modified Files
--
web/pgadmin/utils/tests/test_encoding.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Build failed in Jenkins: pgadmin4-master-python27 #969

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Add full support and testsfor all PG server side encodings. Fixes 
#3992.

[Dave Page] Update release notes.

--
[...truncated 272 B...]
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a
Commit message: "Update release notes."
 > git rev-list --no-walk fb747b803134cff6faa1115c1962100a2ce3bedb # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=2.7

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python27] $ /bin/sh -xe /tmp/jenkins9091020792993114991.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.7 virtual environment...

New python executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-2.7/bin/python
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. 
Please upgrade your Python as Python 2.7 won't be maintained after that date. A 
future version of pip will drop support for Python 2.7.
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting Flask==0.12.4 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 9))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 10))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 11))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 12))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 14))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 17))
Collecting six>=1.11.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting speaklater==1.3 (from -r requirements.txt (line 19))
Collecting sqlparse==0.2.4 (from -r requirements.txt (line 20))
  Using cached 
https://files.pythonhosted.org/packages/65/85/20bdd72f4537cf2c4d5d005368d502b2f464ede22982e724a82c86268eda/sqlparse-0.2.4-py2.py3-none-any.whl
Collecting WTForms==2.1 (from -r requirements.txt (line 21))
Collecting Flask-Paranoid==0.2.0 (from -r requirements.txt (line 22))
  Using cached 
https://files.pythonhosted.org/packages/0e/14/359033a218c5403872e11ff7267e6c638c0279067fa932d93653188f4052/Flask_Paranoid-0.2.0-py2.py3-none-any.whl
Collecting psutil==5.4.7 (from -r requirements.txt (line 23))
Collecting psycopg2>=2.7.4 (from -r requirements.txt (line 24))
  Using cached 
https://files.pythonhosted.org/packages/b1/8c/128c4f933caa12bdb91b5cb2e1244825b8e2f6575640261e556bbf2921a7/psycopg2-2.7.7-cp27-cp27m-manylinux1_x86_64.whl
Collecting python-dateutil>=2.7.1 (f

Build failed in Jenkins: pgadmin4-master-python35 #950

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Add full support and testsfor all PG server side encodings. Fixes 
#3992.

[Dave Page] Update release notes.

--
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a
Commit message: "Update release notes."
 > git rev-list --no-walk fb747b803134cff6faa1115c1962100a2ce3bedb # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.5

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python35] $ /bin/sh -xe /tmp/jenkins5040306208282196189.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.5 virtual environment...

Using base prefix '/usr/local/python-3.5'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.5/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting Flask==0.12.4 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 9))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 10))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 11))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 12))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 14))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 17))
Collecting six>=1.11.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting speaklater==1.3 (from -r requirements.txt (line 19))
Collecting sqlparse==0.2.4 (from -r requirements.txt (line 20))
  Using cached 
https://files.pythonhosted.org/packages/65/85/20bdd72f4537cf2c4d5d005368d502b2f464ede22982e724a82c86268eda/sqlparse-0.2.4-py2.py3-none-any.whl
Collecting WTForms==2.1 (from -r requirements.txt (line 21))
Collecting Flask-Paranoid==0.2.0 (from -r requirements.txt (line 22))
  Using cached 
https://files.pythonhosted.org/packages/0e/14/359033a218c5403872e11ff7267e6c638c0279067fa932d93653188

Build failed in Jenkins: pgadmin4-master-python37 #197

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Fix download CSV for IE11 which doesn't support the download 
attribute.

[Dave Page] Add full support and testsfor all PG server side encodings. Fixes 
#3992.

[Dave Page] Update release notes.

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 13f52ad9ac927a1f21c18a4ece1f72cdb58c3c9a
Commit message: "Update release notes."
 > git rev-list --no-walk c6d295727c0277d841e170a38099182aa9102a3c # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.7

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python37] $ /bin/sh -xe /tmp/jenkins551338807162127536.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.7 virtual environment...

Using base prefix '/usr/local/python-3.7'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
/usr/lib/python2.7/site-packages/virtualenv.py:1039: DeprecationWarning: the 
imp module is deprecated in favour of importlib; see the module's documentation 
for alternative uses
  import imp
Running virtualenv with interpreter /usr/local/python-3.7/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting Flask==0.12.4 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 9))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 10))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 11))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 12))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 14))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 17))
Collecting six>=1.11.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting speaklater==1.3 (from -r requirements.txt (line 19))
Collecting sqlparse==0.2.4 (from -r requirements.txt (line 20))
  Using cached 
https://files

Jenkins build is back to normal : pgadmin4-master-python27 #970

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python35 #951

[pgAdmin 4 Jenkins]

See 

pgAdmin 4 commit: Custom-encode forward slashes in URL parameters as Ap

[Dave Page]

Custom-encode forward slashes in URL parameters as Apache HTTPD doesn't allow 
them in some cases. Fixes #3998

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36ffdb93e83e0f83abd760e004fa867795762bf8
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/release_notes_4_3.rst  |  1 +
web/pgadmin/static/js/sqleditor_utils.js  | 16 +++
web/pgadmin/tools/datagrid/__init__.py| 10 
web/pgadmin/tools/datagrid/static/js/datagrid.js  | 23 --
web/pgadmin/tools/datagrid/static/js/show_data.js |  4 +-
web/regression/javascript/sqleditor_utils_spec.js | 56 +++
6 files changed, 93 insertions(+), 17 deletions(-)

Re: [RM#3998] Custom encode forward slashes in the grid title

[Dave Page]

Thanks, applied.

On Fri, Mar 1, 2019 at 12:41 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hello Aditya,
>
> Yes, that is a better approach, PFA updated patch.
>
> Thanks,
> Murtuza
>
>
> On Fri, Mar 1, 2019 at 4:35 PM Dave Page  wrote:
>
>> That's a good idea. Seems much more robust.
>>
>> On Fri, Mar 1, 2019 at 11:02 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Murtuza,
>>>
>>> I would suggest adding a new url param like "?fslash=12,15", which says
>>> where to put the forward slashes.
>>>
>>> So if server name is "PostgreSQL/11" - connecting to postgres database
>>> with postgres username:
>>> Old URL:
>>> http://localhost:5005/datagrid/panel/3400871/true/postgres%2Fpostgres%40PostgreSQL%2F11?query_url=&server_type=pg
>>>
>>> New URL:
>>> http://localhost:5005/datagrid/panel/3400871/true/postgrespostgres%40PostgreSQL11?query_url=&server_
>>> 
>>> type=pg&fslash=8,27
>>>
>>> Value extracted: postgrespostgres@PostgreSQL11
>>> Using fslash param, put the forward slashes in the mentioned positions:
>>> postgres/postgres@PostgreSQL/11
>>>
>>
>
>
>>
>>>
>>>
>>> On Fri, Mar 1, 2019 at 4:07 PM Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>

 On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Murtuza,
>
> Will this work if server name contains - !PG! ?
>

 No, it won't and it's a custom signature we can finalize it whatever
 team thinks will work if the functionality is working properly.


>
> On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hello,
>>
>> PFA patch for the issue RM#3998. If the URL contains the forward
>> slash value in the query tool title and if pgAdmin4 is behind Apache 
>> server
>> then it fails to open to query tool and the user gets an error 404 
>> because
>> by default Apache does not allow encoded slashes in the URL and return 
>> 404.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Jenkins build is back to normal : pgadmin4-master-python37 #198

[pgAdmin 4 Jenkins]

See 

Re: [pgAdmin4][Patch]: RM #3659 Query tool does not give warning when Auto Commit is turned on in an incomplete transaction

[Dave Page]

Hi

On Fri, Mar 1, 2019 at 9:07 AM Akshay Joshi 
wrote:

> Hi Hackers,
>
> Attached is the patch to fix RM #3659 "Query tool does not give warning
> when Auto Commit is turned on in an incomplete transaction".
>
> Please review it.
>

The behaviour doesn't seem quite right here. I see two issues:

1) It complains that a transaction is in progress if I try to turn
auto-commit on in a freshly opened Query Tool. As I haven't done anything
yet, I shouldn't get the warning. I think the logic to determine whether or
not we're in a transaction isn't correct.

2) In the case above, the setting is changed anyway. I think this has the
potential to be confusing (and potentially dangerous); we should only allow
the setting to actually be toggled when there's no transaction in progress.

Given 2), I wonder if we should remove the warning entirely, and just
disable the menu options whenever a transaction is in progress.

I've attached an updated patch - I started tweaking the messages, so please
base additional work from that.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_3659_dave.patch
Description: Binary data

Jenkins build is back to normal : pgadmin4-master-python36 #959

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python34 #960

[pgAdmin 4 Jenkins]

See 

Re: [pgAdmin4][Patch] - Encoding Fixes

[Dave Page]

Hi

Unfortunately this has introduced a regression:

- Start pgAdmin from the command line or PyCharms.
- Connect to a server, open a query tool and run a query (SELECT 1 will do).
- Stop and restart the pgAdmin server.
- Execute the query again in the client.

The error "'Connection' object has no attribute 'python_encoding'" is
returned in the messages tab and the following exception is given on the
pgAdmin server:

2019-03-01 16:07:26,293: ERROR pgadmin: 'Connection' object has no
attribute 'python_encoding'
Traceback (most recent call last):
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/app.py",
line 1612, in full_dispatch_request
rv = self.dispatch_request()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/app.py",
line 1598, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask_login.py",
line 792, in decorated_view
return func(*args, **kwargs)
  File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/__init__.py",
line 321, in start_query_tool
sql, trans_id, session, connect
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/utils/start_running_query.py",
line 87, in execute
transaction_object
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/utils/start_running_query.py",
line 136, in __execute_query
status, result = conn.execute_async(sql)
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/connection.py",
line 939, in execute_async
encoding = self.python_encoding
AttributeError: 'Connection' object has no attribute 'python_encoding'

I'm guessing there's a codepath in which connection objects are created
without the python_encoding attribute.



On Fri, Mar 1, 2019 at 1:54 PM Dave Page  wrote:

> Thanks, applied.
>
> On Fri, Mar 1, 2019 at 7:06 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to support all the supported encodings by
>> PostgreSQL.
>>
>> Thanks,
>> Khushboo
>>
>> On Thu, Feb 28, 2019 at 10:53 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Wed, Feb 27, 2019 at 4:57 PM Dave Page  wrote:
>>>
 Hi

 On Tue, Feb 26, 2019 at 9:01 AM Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the encoding related issues.
>
> #3992 - View data causes errors with DB encoding EUC_JIS_2004
> #3982 - Encoding Problem with PGAdmin 4.2
> #3911 - Data output does not display Arabic in WIN1256 encoding
> database
> - The CSV download for the same encoding has also been fixed.
>
> I have tested the patch on Python 2.7, 3.5, 3.6 and 3.7.
>

 You've added a couple of new encodings, but it seems to me that we
 should just add everything that PostgreSQL supports. For example, we now
 have win1256, but what about 866, 874, 1250, 1251 etc?

 The full list is at https://www.postgresql.org/docs/11/multibyte.html

 Any reason not to do that?

>>> I thought to fix the reported bugs first and after that, I was about to
>>> add a new ticket to add the remaining supported encodings.
>>> But as per you, I will add the remaining encodings along with these
>>> fixes.
>>>


>>> --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Async queries pretending to be synchronous

[Dave Page]

In investigating #3656 I found the initial problem to be that when running
in a container, Gunicorn will kill the worker process if a thread doesn't
respond for 30 seconds by default. I fixed that by making the timeout match
the application session timeout, but it revealed another issue.

Given the function below (from the ticket), if you open the query tool and
run:

SELECT 1; SELECT fails_after(30);

the async query actually blocks for 30 seconds in the cur.execute() call in
execute_async() in connection.py (line 968). This causes the entire app to
hang (watch the dashboard requests pile up in pending state in the network
tab of the browser dev tools).

If you run just the second SELECT, it works as expected, as does running
something like:

SELECT 1; SELECT pg_sleep(30);

Anyone have any idea what's going on?

CREATE OR REPLACE FUNCTION fails_after(s integer)
RETURNS text AS $$
begin
raise notice 'Entered';
perform pg_sleep(s);
raise '!!!';
end;
$$ LANGUAGE plpgsql;

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Interested in GSoC projects on pgAdmin 4

[Haoran Yu]

Dear PostgreSQL community:

I am a MSc student in computer science working on data management research,
and I will likely graduate this summer. I also was a participant of GSoC in
2017 working with the NRNB organization on data standards conversion.

I have been a user of pgAdmin 4 briefly, and I am interested in learning
more about the project and contribute to it. The projects web page lists 3
potential projects, but I don't know which one I'm suitable for. Are there
any suggestions on how to get started on exploring more about the Query
Tool in pgAdmin? For example, use cases with some sample data would be
nice! I also checked out the pgadmin4 repository from git, and I'll start
exploring the code shortly.

Thank you for your responses!
Howard

Re: [pgAdmin4][Patch] - Encoding Fixes

[Khushboo Vashi]

Hi,

Please find the attached patch for the regression fix.

Thanks,
Khushboo

On Fri, Mar 1, 2019 at 9:41 PM Dave Page  wrote:

> Hi
>
> Unfortunately this has introduced a regression:
>
> - Start pgAdmin from the command line or PyCharms.
> - Connect to a server, open a query tool and run a query (SELECT 1 will
> do).
> - Stop and restart the pgAdmin server.
> - Execute the query again in the client.
>
> The error "'Connection' object has no attribute 'python_encoding'" is
> returned in the messages tab and the following exception is given on the
> pgAdmin server:
>
> 2019-03-01 16:07:26,293: ERROR pgadmin: 'Connection' object has no
> attribute 'python_encoding'
> Traceback (most recent call last):
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/app.py",
> line 1612, in full_dispatch_request
> rv = self.dispatch_request()
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask/app.py",
> line 1598, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
>   File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/flask_login.py",
> line 792, in decorated_view
> return func(*args, **kwargs)
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/__init__.py", line
> 321, in start_query_tool
> sql, trans_id, session, connect
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/utils/start_running_query.py",
> line 87, in execute
> transaction_object
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/utils/start_running_query.py",
> line 136, in __execute_query
> status, result = conn.execute_async(sql)
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/connection.py",
> line 939, in execute_async
> encoding = self.python_encoding
> AttributeError: 'Connection' object has no attribute 'python_encoding'
>
> I'm guessing there's a codepath in which connection objects are created
> without the python_encoding attribute.
>
>
>
> On Fri, Mar 1, 2019 at 1:54 PM Dave Page  wrote:
>
>> Thanks, applied.
>>
>> On Fri, Mar 1, 2019 at 7:06 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to support all the supported encodings by
>>> PostgreSQL.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Thu, Feb 28, 2019 at 10:53 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Wed, Feb 27, 2019 at 4:57 PM Dave Page  wrote:

> Hi
>
> On Tue, Feb 26, 2019 at 9:01 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the encoding related issues.
>>
>> #3992 - View data causes errors with DB encoding EUC_JIS_2004
>> #3982 - Encoding Problem with PGAdmin 4.2
>> #3911 - Data output does not display Arabic in WIN1256 encoding
>> database
>> - The CSV download for the same encoding has also been fixed.
>>
>> I have tested the patch on Python 2.7, 3.5, 3.6 and 3.7.
>>
>
> You've added a couple of new encodings, but it seems to me that we
> should just add everything that PostgreSQL supports. For example, we now
> have win1256, but what about 866, 874, 1250, 1251 etc?
>
> The full list is at https://www.postgresql.org/docs/11/multibyte.html
>
> Any reason not to do that?
>
 I thought to fix the reported bugs first and after that, I was about to
 add a new ticket to add the remaining supported encodings.
 But as per you, I will add the remaining encodings along with these
 fixes.

>
>
 --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


encoding_regression_fix.patch
Description: Binary data

Re: [pgAdmin4][Patch]: RM #3659 Query tool does not give warning when Auto Commit is turned on in an incomplete transaction

[Akshay Joshi]

Hi Dave

On Fri, Mar 1, 2019 at 8:47 PM Dave Page  wrote:

> Hi
>
> On Fri, Mar 1, 2019 at 9:07 AM Akshay Joshi 
> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix RM #3659 "Query tool does not give warning
>> when Auto Commit is turned on in an incomplete transaction".
>>
>> Please review it.
>>
>
> The behaviour doesn't seem quite right here. I see two issues:
>
> 1) It complains that a transaction is in progress if I try to turn
> auto-commit on in a freshly opened Query Tool. As I haven't done anything
> yet, I shouldn't get the warning. I think the logic to determine whether or
> not we're in a transaction isn't correct.
>
> 2) In the case above, the setting is changed anyway. I think this has the
> potential to be confusing (and potentially dangerous); we should only allow
> the setting to actually be toggled when there's no transaction in progress.
>

   The above behaviour I have followed from pgAdmin 3.

>
> Given 2), I wonder if we should remove the warning entirely, and just
> disable the menu options whenever a transaction is in progress.
>

Done. I have disabled the drop down button when transaction is in
progress. I have tried to disabled single menu option but that is an anchor
tag. I have tried with CSS by setting "*pointer-events: none*" and from
HTML adding "*disabled=’disabled*’" which is only supported in old browsers.

Attached is the updated patch, please review it.

>
> I've attached an updated patch - I started tweaking the messages, so
> please base additional work from that.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


RM_3659_v2.patch
Description: Binary data