Re: RM2233 - Scratch pad
Hi Dave, On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: > Here's a draft patch for adding a scratch pad to the Query Tool, > similar to what we had in pgAdmin 3. > > Aside from regular review, can one of our CSS gurus (I'm looking at > you Aditya and Khushboo :-) ) help with the following questions: > > 1) I'm currently sizing the text area height using "height: calc(100% > - 3px);" to avoid a vertical scrollbar in one of the parent divs > created by wcDocker. I'm sure there's a more elegant way of doing that > (and one that's not likely to be so fragile). > > Can't we just add height: 100% instead of calc? One more way to avoid vertical scroll-bar is *overflow-y: hidden * > 2) I've enabled the wcDocker context menu so users can show or hide > the scratch pad. The sub-menu is expanding as shown in the attached > screenshot though, however, it works fine on the main browser wcDocker > instance. > > Please add 'jquery.ui', 'jqueryui.position' dependencies in sqleditor.js . Any ideas on those please? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: RM2233 - Scratch pad
Hi On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi wrote: > > Hi Dave, > > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: >> >> Here's a draft patch for adding a scratch pad to the Query Tool, >> similar to what we had in pgAdmin 3. >> >> Aside from regular review, can one of our CSS gurus (I'm looking at >> you Aditya and Khushboo :-) ) help with the following questions: >> >> 1) I'm currently sizing the text area height using "height: calc(100% >> - 3px);" to avoid a vertical scrollbar in one of the parent divs >> created by wcDocker. I'm sure there's a more elegant way of doing that >> (and one that's not likely to be so fragile). >> > Can't we just add height: 100% instead of calc? No - that causes the scrollbar to appear. > One more way to avoid vertical scroll-bar is overflow-y: hidden wouldn't that need to go in the div that wcDocker is creating? >> 2) I've enabled the wcDocker context menu so users can show or hide >> the scratch pad. The sub-menu is expanding as shown in the attached >> screenshot though, however, it works fine on the main browser wcDocker >> instance. >> > Please add 'jquery.ui', 'jqueryui.position' dependencies in sqleditor.js . Thanks, I'll give it a try. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: RM2233 - Scratch pad
On Fri, Feb 15, 2019 at 6:35 PM Dave Page wrote: > Hi > > On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi > wrote: > > > > Hi Dave, > > > > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: > >> > >> Here's a draft patch for adding a scratch pad to the Query Tool, > >> similar to what we had in pgAdmin 3. > >> > >> Aside from regular review, can one of our CSS gurus (I'm looking at > >> you Aditya and Khushboo :-) ) help with the following questions: > >> > >> 1) I'm currently sizing the text area height using "height: calc(100% > >> - 3px);" to avoid a vertical scrollbar in one of the parent divs > >> created by wcDocker. I'm sure there's a more elegant way of doing that > >> (and one that's not likely to be so fragile). > >> > > Can't we just add height: 100% instead of calc? > > No - that causes the scrollbar to appear. > > > One more way to avoid vertical scroll-bar is overflow-y: hidden > > wouldn't that need to go in the div that wcDocker is creating? We can apply it on the parent-div which is div.sql-scratch > > >> 2) I've enabled the wcDocker context menu so users can show or hide > >> the scratch pad. The sub-menu is expanding as shown in the attached > >> screenshot though, however, it works fine on the main browser wcDocker > >> instance. > >> > > Please add 'jquery.ui', 'jqueryui.position' dependencies in > sqleditor.js . > > Thanks, I'll give it a try. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
pgAdmin 4 commit: Make the Query Tool tab titles more concise and usefu
Make the Query Tool tab titles more concise and useful. Fixes #3544 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c64373435b73ad0a37a15e677bbc4d8f69874155 Modified Files -- docs/en_US/release_notes_4_3.rst | 1 + web/pgadmin/tools/datagrid/static/js/datagrid.js | 41 ++ .../tools/datagrid/static/js/get_panel_title.js| 2 +- web/pgadmin/tools/datagrid/static/js/show_data.js | 2 +- .../javascript/datagrid/get_panel_title_spec.js| 4 +-- .../javascript/datagrid/show_data_spec.js | 6 ++-- 6 files changed, 34 insertions(+), 22 deletions(-)
Re: RM2233 - Scratch pad
On Fri, Feb 15, 2019 at 1:29 PM Khushboo Vashi wrote: > > > > On Fri, Feb 15, 2019 at 6:35 PM Dave Page wrote: >> >> Hi >> >> On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi >> wrote: >> > >> > Hi Dave, >> > >> > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: >> >> >> >> Here's a draft patch for adding a scratch pad to the Query Tool, >> >> similar to what we had in pgAdmin 3. >> >> >> >> Aside from regular review, can one of our CSS gurus (I'm looking at >> >> you Aditya and Khushboo :-) ) help with the following questions: >> >> >> >> 1) I'm currently sizing the text area height using "height: calc(100% >> >> - 3px);" to avoid a vertical scrollbar in one of the parent divs >> >> created by wcDocker. I'm sure there's a more elegant way of doing that >> >> (and one that's not likely to be so fragile). >> >> >> > Can't we just add height: 100% instead of calc? >> >> No - that causes the scrollbar to appear. >> >> > One more way to avoid vertical scroll-bar is overflow-y: hidden >> >> wouldn't that need to go in the div that wcDocker is creating? > > We can apply it on the parent-div which is div.sql-scratch >> >> >> >> 2) I've enabled the wcDocker context menu so users can show or hide >> >> the scratch pad. The sub-menu is expanding as shown in the attached >> >> screenshot though, however, it works fine on the main browser wcDocker >> >> instance. >> >> >> > Please add 'jquery.ui', 'jqueryui.position' dependencies in sqleditor.js . >> >> Thanks, I'll give it a try. Thanks - both fixes seem to work :-) Updated patch attached. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2233_v2.diff Description: Binary data
Re: RM2233 - Scratch pad
Hi On Fri, Feb 15, 2019 at 1:53 PM Akshay Joshi wrote: > Hi Dave > > Following are my review comments: > >- When query is running then user should be able to work on Scratch >pad. > > That's a whole other issue - 3920 to be precise. > >- Try to resize the Data Output panel or just click multiple times on >"Query Editor" Tab Scratch pad 's width will increased on every click. > > I don't see that when clicking, but I do when resizing the Data Output pane. That seems like some weird wcDocker behaviour . It actually happens with the current code as well, if you put the History and SQL Editor tabs side-by-side. > >- By default Scratch pad tab should be docked at right side. Currently >it depends on your mouse click. On mouse click it shows the area where it >will be docked. Refer attached Scratch_Pad_Area.png and >Scratch_Pad_Dock.png > > That's wcDocker behaviour. By default we create it on the right side, but if you close and re-open it, it'll go whereever your mouse puts the drop zone. > >- Got error in browser when hover on Add Panel menu. Refer attached >Hover_Error.png > > That's caused by the second issue I asked about. It's fixed now. > >- Do we need Scratch pad in View/Edit Data? > > No, I don't think so as you cannot edit the query then anyway. Thanks! > > On Fri, Feb 15, 2019 at 6:59 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Fri, Feb 15, 2019 at 6:35 PM Dave Page wrote: >> >>> Hi >>> >>> On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi >>> wrote: >>> > >>> > Hi Dave, >>> > >>> > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: >>> >> >>> >> Here's a draft patch for adding a scratch pad to the Query Tool, >>> >> similar to what we had in pgAdmin 3. >>> >> >>> >> Aside from regular review, can one of our CSS gurus (I'm looking at >>> >> you Aditya and Khushboo :-) ) help with the following questions: >>> >> >>> >> 1) I'm currently sizing the text area height using "height: calc(100% >>> >> - 3px);" to avoid a vertical scrollbar in one of the parent divs >>> >> created by wcDocker. I'm sure there's a more elegant way of doing that >>> >> (and one that's not likely to be so fragile). >>> >> >>> > Can't we just add height: 100% instead of calc? >>> >>> No - that causes the scrollbar to appear. >>> >>> > One more way to avoid vertical scroll-bar is overflow-y: hidden >>> >>> wouldn't that need to go in the div that wcDocker is creating? >> >> We can apply it on the parent-div which is div.sql-scratch >> >>> >>> >> 2) I've enabled the wcDocker context menu so users can show or hide >>> >> the scratch pad. The sub-menu is expanding as shown in the attached >>> >> screenshot though, however, it works fine on the main browser wcDocker >>> >> instance. >>> >> >>> > Please add 'jquery.ui', 'jqueryui.position' dependencies in >>> sqleditor.js . >>> >>> Thanks, I'll give it a try. >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add a "scratch pad" to the Query Tool to hold text sn
Add a "scratch pad" to the Query Tool to hold text snippets whilst editing. Fixes #2233 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=255afe673afbab9df45b7deb0a76481f5dc51d1d Modified Files -- docs/en_US/query_tool.rst | 105 - docs/en_US/release_notes_4_3.rst | 1 + .../tools/sqleditor/static/css/sqleditor.css | 15 +++ web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 24 +++-- 4 files changed, 113 insertions(+), 32 deletions(-)
