pgAdmin 4 commit: Automatically expand child nodes as well as the selec

2019-02-14 Thread Dave Page
Automatically expand child nodes as well as the selected node on the treeview 
if there is only one. Fixes #3559

This also ensure the browser state is cleared if the save interval is set to -1.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17694ab467cccf090e425cadb6238c31548869ca
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/images/preferences_browser_display.png  | Bin 83195 -> 248805 bytes
docs/en_US/preferences.rst |   6 ++
.../browser/register_browser_preferences.py|  10 ++
web/pgadmin/browser/static/js/node.js  |   9 +
web/pgadmin/settings/__init__.py   |  21 -
.../static/js/tree/pgadmin_tree_save_state.js  |  20 
6 files changed, 65 insertions(+), 1 deletion(-)



pgAdmin 4 commit: Update release notes.

2019-02-14 Thread Dave Page
Update release notes.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=122336eb639066fb8f89bef9417fbfac14b9f6d5

Modified Files
--
docs/en_US/release_notes_4_3.rst | 1 +
1 file changed, 1 insertion(+)



Build failed in Jenkins: pgadmin4-master-python27 #937

2019-02-14 Thread pgAdmin 4 Jenkins
See 


Changes:

[Dave Page] Automatically expand child nodes as well as the selected node on the

[Dave Page] Update release notes.

--
[...truncated 334 B...]
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 122336eb639066fb8f89bef9417fbfac14b9f6d5 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 122336eb639066fb8f89bef9417fbfac14b9f6d5
Commit message: "Update release notes."
 > git rev-list --no-walk 438116c57478f6523e7cb4da9a8c528fc538804c # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=2.7

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python27] $ /bin/sh -xe /tmp/jenkins8378844786177597499.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.7 virtual environment...

New python executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-2.7/bin/python
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. 
Please upgrade your Python as Python 2.7 won't be maintained after that date. A 
future version of pip will drop support for Python 2.7.
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting Flask==0.12.4 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 9))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 10))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 11))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 12))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 14))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 17))
Collecting six>=1.11.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting speaklater==1.3 (from -r requirements.txt (line 19))
Collecting sqlparse==0.2.4 (from -r requirements.txt (line 20))
  Using cached 
https://files.pythonhosted.org/packages/65/85/20bdd72f4537cf2c4d5d005368d502b2f464ede22982e724a82c86268eda/sqlparse-0.2.4-py2.py3-none-any.whl
Collecting WTForms==2.1 (from -r requirements.txt (line 21))
Collecting Flask-Paranoid==0.2.0 (from -r requirements.txt (line 22))
  Using cached 
https://files.pythonhosted.org/packages/0e/14/359033a218c5403872e11ff7267e6c638c0279067fa932d93653188f4052/Flask_Paranoid-0.2.0-py2.py3-none-any.whl
Collecting psutil==5.4.7 (from -r requirements.txt (line 23))
Collecting psycopg2>=2.7.4 (from -r requirements.txt (line 24))
  Using cached 
https://files.pythonhosted.org/packages/b1/8c/128c4f933caa12bdb91b5cb2e1244825b8e2f6575640261e556bbf2921a7/psycopg2-2.7.7-cp27-cp27m-manylinux1_x86_64.whl
Collecting python-dateutil>=2.7.1 (from -r requirements.txt 

Build failed in Jenkins: pgadmin4-master-python37 #168

2019-02-14 Thread pgAdmin 4 Jenkins
See 


Changes:

[Dave Page] Automatically expand child nodes as well as the selected node on the

[Dave Page] Update release notes.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 122336eb639066fb8f89bef9417fbfac14b9f6d5 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 122336eb639066fb8f89bef9417fbfac14b9f6d5
Commit message: "Update release notes."
 > git rev-list --no-walk 438116c57478f6523e7cb4da9a8c528fc538804c # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.7

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python37] $ /bin/sh -xe /tmp/jenkins6641322775836169587.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.7 virtual environment...

Using base prefix '/usr/local/python-3.7'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
/usr/lib/python2.7/site-packages/virtualenv.py:1039: DeprecationWarning: the 
imp module is deprecated in favour of importlib; see the module's documentation 
for alternative uses
  import imp
Running virtualenv with interpreter /usr/local/python-3.7/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting Flask==0.12.4 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 9))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 10))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 11))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 12))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 14))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 17))
Collecting six>=1.11.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting speaklater==1.3 (from -r requirements.txt (line 19))
Collecting sqlparse==0.2.4 (from -r requirements.txt (line 20))
  Using cached 
https://files.pythonhosted.org/packages/65/85/20bdd72f4537cf2c4d5d005368d502b2f464ede22982e724a82c86268eda/sqlparse-0.2.4-py2.py3-none-any.whl
Collecting WTForms==2.1 (from -r requirements.txt (line 21))
Collecting Flask-Paranoi

pgAdmin 4 commit: PEP-8 fix

2019-02-14 Thread Dave Page
PEP-8 fix

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5e154e26876df480cf03b554a6a7278d9652ec1

Modified Files
--
web/pgadmin/settings/__init__.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)



Build failed in Jenkins: pgadmin4-master-python35 #921

2019-02-14 Thread pgAdmin 4 Jenkins
See 


Changes:

[Dave Page] Automatically expand child nodes as well as the selected node on the

[Dave Page] Update release notes.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 122336eb639066fb8f89bef9417fbfac14b9f6d5 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 122336eb639066fb8f89bef9417fbfac14b9f6d5
Commit message: "Update release notes."
 > git rev-list --no-walk 438116c57478f6523e7cb4da9a8c528fc538804c # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.5

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python35] $ /bin/sh -xe /tmp/jenkins1692979749454393217.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.5 virtual environment...

Using base prefix '/usr/local/python-3.5'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.5/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting Flask==0.12.4 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 9))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 10))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 11))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 12))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 14))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 17))
Collecting six>=1.11.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting speaklater==1.3 (from -r requirements.txt (line 19))
Collecting sqlparse==0.2.4 (from -r requirements.txt (line 20))
  Using cached 
https://files.pythonhosted.org/packages/65/85/20bdd72f4537cf2c4d5d005368d502b2f464ede22982e724a82c86268eda/sqlparse-0.2.4-py2.py3-none-any.whl
Collecting WTForms==2.1 (from -r requirements.txt (line 21))
Collecting Flask-Paranoid==0.2.0 (from -r requirements.txt (line 22))
  Using cached 
https://files.pythonhosted.org/packages/0e/14/359033a218c5403872e11ff7267e6c638c0279067fa932d93653188f4052/Flask_Paranoid-0.2.0-py2

Re: [pgAdmin4][Patch] - RM 3959 - Properties and Dependents tabs rendering is slow with 1000+ records

2019-02-14 Thread Dave Page
Hi

On Thu, Feb 14, 2019 at 5:44 AM Khushboo Vashi
 wrote:
>
> Hi,
>
> Please find the attached patch to fix the RM #3959 - Properties and 
> Dependents tabs rendering is slow with 1000+ records.

There are a couple of PEP-8 issues (easy fixes), but more serious is
that the object icons are no longer being displayed on each row of the
tables.

Can you look into that please?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Re: [pgAdmin4][Patch] - RM 3959 - Properties and Dependents tabs rendering is slow with 1000+ records

2019-02-14 Thread Khushboo Vashi
Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Thu, Feb 14, 2019 at 3:05 PM Dave Page  wrote:

> Hi
>
> On Thu, Feb 14, 2019 at 5:44 AM Khushboo Vashi
>  wrote:
> >
> > Hi,
> >
> > Please find the attached patch to fix the RM #3959 - Properties and
> Dependents tabs rendering is slow with 1000+ records.
>
> There are a couple of PEP-8 issues (easy fixes),

Fixed

> but more serious is
> that the object icons are no longer being displayed on each row of the
> tables.
>
> Fixed

> Can you look into that please?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_3959_v1.patch
Description: Binary data


Jenkins build is back to normal : pgadmin4-master-python37 #169

2019-02-14 Thread pgAdmin 4 Jenkins
See 





Jenkins build is back to normal : pgadmin4-master-python35 #922

2019-02-14 Thread pgAdmin 4 Jenkins
See 





Jenkins build is back to normal : pgadmin4-master-python27 #938

2019-02-14 Thread pgAdmin 4 Jenkins
See 





Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-14 Thread Dave Page
Hi

On Thu, Feb 14, 2019 at 6:56 AM Khushboo Vashi
 wrote:
>
> Hi,
>
> Please find the attached patch to fix the RM #3673 - "Download as .csv" F8 
> does NOT work when one of joined files is a TEMPORARY file
>
> To fix this issue, used the existing query tool connection instead of a new 
> connection to download the CSV file.

That side of it seems to work well, however, I can still attempt to
execute queries in the tool whilst it's running. We need to display
the same gray screen with the spinner whilst a CSV download is
executing as we do when a normal query is executing. We also need to
ensure the button bar behaves appropriately - e.g. the execute options
should be disabled, the cancel button should be enabled etc.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgAdmin 4 commit: Optimise display of Dependencies and Dependents, and

2019-02-14 Thread Dave Page
Optimise display of Dependencies and Dependents, and use on-demand loading of 
rows in batches of 100. Fixes #3959

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=622b67684d7d44c5c78191be4dbfc26554135a12
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_4_3.rst   |   1 +
web/pgadmin/browser/static/js/browser.js   |   4 +-
web/pgadmin/browser/static/js/collection.js| 107 +++--
web/pgadmin/misc/dependencies/__init__.py  |  30 ++
.../misc/dependencies/static/js/dependencies.js| 246 
.../misc/{depends => dependents}/__init__.py   |  11 +-
.../misc/dependents/static/js/dependents.js| 252 
web/pgadmin/misc/depends/static/js/depends.js  | 432 -
web/webpack.config.js  |   3 +-
web/webpack.shim.js|   3 +-
10 files changed, 624 insertions(+), 465 deletions(-)



Re: [pgAdmin4][Patch] - RM 3959 - Properties and Dependents tabs rendering is slow with 1000+ records

2019-02-14 Thread Dave Page
Hi

Thanks - patch applied.

I did spot another minor issue whilst testing - it's clearly not
caused by this patch though so I've logged it as #3994.

On Thu, Feb 14, 2019 at 9:55 AM Khushboo Vashi
 wrote:
>
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Thu, Feb 14, 2019 at 3:05 PM Dave Page  wrote:
>>
>> Hi
>>
>> On Thu, Feb 14, 2019 at 5:44 AM Khushboo Vashi
>>  wrote:
>> >
>> > Hi,
>> >
>> > Please find the attached patch to fix the RM #3959 - Properties and 
>> > Dependents tabs rendering is slow with 1000+ records.
>>
>> There are a couple of PEP-8 issues (easy fixes),
>
> Fixed
>>
>> but more serious is
>> that the object icons are no longer being displayed on each row of the
>> tables.
>>
> Fixed
>>
>> Can you look into that please?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



RM2233 - Scratch pad

2019-02-14 Thread Dave Page
Here's a draft patch for adding a scratch pad to the Query Tool,
similar to what we had in pgAdmin 3.

Aside from regular review, can one of our CSS gurus (I'm looking at
you Aditya and Khushboo :-) ) help with the following questions:

1) I'm currently sizing the text area height using "height: calc(100%
- 3px);" to avoid a vertical scrollbar in one of the parent divs
created by wcDocker. I'm sure there's a more elegant way of doing that
(and one that's not likely to be so fragile).

2) I've enabled the wcDocker context menu so users can show or hide
the scratch pad. The sub-menu is expanding as shown in the attached
screenshot though, however, it works fine on the main browser wcDocker
instance.

Any ideas on those please?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_2233.diff
Description: Binary data