[pgAdmin4][Patch]: Backform Switch control clean-up
Hi, Please find the attached patch for cleaning up the unwanted extended versions of Backform Switch controls. The Bootstrap Switch Control was extended only for alignment at most of the places. In this patch, I have introduced a configurable option to set the necessary class on the main div and also removed the extra extended controls. Thanks, Khushboo bootstrap_toggle_cleanup.patch Description: Binary data
Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases
Hi Hackers, Attached is the updated patch to fix possible causes of failure. Kindly review (fingers crossed) On Tue, Feb 5, 2019 at 10:48 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> I tried to simulate, but no luck. It works on my system :( >>> >> >>I have tried and Feature test are failing randomly for each run. I >> have verified it on OSX and Ubuntu both. >> >>> >>> +1 > >> On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Aditya I have applied your patch but following test cases are failing consistently: - CopySelectedQueryResultsFeatureTest - QueryToolAutoCompleteFeatureTest I have verified your patch on Mac OSX and Ubuntu. Chrome Version 71.0.3578.98 On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > > > On Tue, 29 Jan 2019, 19:09 Dave Page >> Akshay, can you look at this please? >> > > Sure. > >> >> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal >> wrote: >> > >> > Hi Hackers, >> > >> > Attached is the updated patch. I have changed >> fill_input_by_field_name function to use javascript to set values of text >> boxes and the selector is changed from xpath to CSS with a >> :not(:disabled) >> clause. With this, test case will fail if tried to set the value of a >> disabled input. >> > >> > Kindly review. >> > >> > >> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >> >> >> >> >> >> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page >> wrote: >> >>> >> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal >> >>> wrote: >> >>> > >> >>> > Hi Dave, >> >>> > >> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page >> wrote: >> >>> >> >> >>> >> Hi >> >>> >> >> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal >> >>> >> wrote: >> >>> >> > >> >>> >> > Hi Hackers, >> >>> >> > >> >>> >> > Attached is the patch to fix failing SQL editor related >> feature tests. >> >>> >> > The failure is occurring mostly because of send_keys >> function of selenium which sometimes does not input the complete text. >> The >> change will use Codemirror javascript object to set the text. >> >>> >> > >> >>> >> > I have also added new args flag "--modules" which can be >> used after --pkg where you can test a specific module file under the pkg. >> This is not so useful for build but definitely helpful for the >> developers. >> >>> >> >> >>> >> One of the most common failures I see is failure to fill in the >> >>> >> details on the Add Server dialogue (it might type half of an >> entry, >> >>> >> then just hang). Should we get rid of all uses of send_keys? >> >>> > >> >>> > Setting the text using javascript executor can be done. >> send_keys simulate an actual person, so if you try to set a disabled >> text >> box using send_keys, it won't. Places where disabled fields doesn't >> matter, >> send_keys can be removed. >> >>> >> >>> Can't we just do something like: >> >>> >> >>> if input.disabled == false: >> >>> input.value = 'Foo'; >> >>> else: >> >>> raise exception >> >> >> >> I'll check if this can be done. Will get back. >> >>> >> >>> >> >>> -- >> >>> Dave Page >> >>> Blog: http://pgsnake.blogspot.com >> >>> Twitter: @pgsnake >> >>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company >> >> >> >> >> >> >> >> -- >> >> Thanks and Regards, >> >> Aditya Toshniwal >> >> Software Engineer | EnterpriseDB Software Solutions | Pune >> >> "Don't Complain about Heat, Plant a tree" >> > >> > >> > >> > -- >> > Thanks and Regards, >> > Aditya Toshniwal >> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree" >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> -- >> *Ak
Re: Packagers: Handling upgrade checks
Hi Dave, On Wed, Jan 2, 2019 at 6:44 PM Dave Page wrote: > Packagers, > > As you probably know, pgAdmin 4 checks for updates upon startup, and > if a newer version is available, directs the user to www.pgadmin.org > to download it. > > The is a problem if your pgAdmin came with a PostgreSQL installer (as > you can't download them from our website), and potentially mildly > annoying if you're a .deb or .rpm user. > > There are a couple of ways to optimise the experience for users here > (one of which I just committed). I'll leave it up to each of you to > choose what you want to do (Sandeep, I would suggest that the EDB > installers use method 2). > > Method 1: Simply disable the upgrade check, and leave that to the > operating systems update tools. To do this, create (or edit) a > config_distro.py file that is installed alongside the config.py file > from the pgAdmin source and include the line; > > UPGRADE_CHECK_ENABLED = False > > Method 2: For well known and trusted distributions we can support a > custom check for your distribution. This involves 2 parts: > > 1) Let me know that you want a custom check, and I'll setup access for > you to manage the version data on the pgAdmin website. We'll agree on > a custom key for that data within the JSON file the website hosts. > > We want that for PG and EPAS installers. Will you please share the custom key? > 2) Create (or edit) a config_distro.py file that is installed > alongside the config.py file from the pgAdmin source and include the > line; > > UPGRADE_CHECK_KEY = '' > > With this method, a different section of the JSON datafile will be > checked by your distribution of pgAdmin, thus allowing you to control > both when it tells users a new version is available, and the URL to > which they are directed. > > Makes sense. Will include this change in the upcoming PG and EPAS updates that bundle pgAdmin. > Thanks! > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Sandeep Thakkar
Re: Packagers: Handling upgrade checks
Hi On Tue, Feb 5, 2019 at 12:27 PM Sandeep Thakkar wrote: > > Hi Dave, > > > On Wed, Jan 2, 2019 at 6:44 PM Dave Page wrote: >> >> Packagers, >> >> As you probably know, pgAdmin 4 checks for updates upon startup, and >> if a newer version is available, directs the user to www.pgadmin.org >> to download it. >> >> The is a problem if your pgAdmin came with a PostgreSQL installer (as >> you can't download them from our website), and potentially mildly >> annoying if you're a .deb or .rpm user. >> >> There are a couple of ways to optimise the experience for users here >> (one of which I just committed). I'll leave it up to each of you to >> choose what you want to do (Sandeep, I would suggest that the EDB >> installers use method 2). >> >> Method 1: Simply disable the upgrade check, and leave that to the >> operating systems update tools. To do this, create (or edit) a >> config_distro.py file that is installed alongside the config.py file >> from the pgAdmin source and include the line; >> >> UPGRADE_CHECK_ENABLED = False >> >> Method 2: For well known and trusted distributions we can support a >> custom check for your distribution. This involves 2 parts: >> >> 1) Let me know that you want a custom check, and I'll setup access for >> you to manage the version data on the pgAdmin website. We'll agree on >> a custom key for that data within the JSON file the website hosts. >> > We want that for PG and EPAS installers. Will you please share the custom key? edb-pgadmin4 See: https://www.pgadmin.org/versions.json (let me know if I need to change anything for testing etc). >> >> 2) Create (or edit) a config_distro.py file that is installed >> alongside the config.py file from the pgAdmin source and include the >> line; >> >> UPGRADE_CHECK_KEY = '' >> >> With this method, a different section of the JSON datafile will be >> checked by your distribution of pgAdmin, thus allowing you to control >> both when it tells users a new version is available, and the URL to >> which they are directed. >> > Makes sense. Will include this change in the upcoming PG and EPAS updates > that bundle pgAdmin. :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Update Japanese translation.
Update Japanese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6ba8899d18eed1b6a66f674f5d66f9eab494e7e Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 162322 -> 162736 bytes .../translations/ja/LC_MESSAGES/messages.po| 54 ++--- 2 files changed, 27 insertions(+), 27 deletions(-)
Re: Japanese translation for v4.2
Thanks, patch applied. On Mon, Feb 4, 2019 at 2:46 PM fn ln wrote: > > Hello. > Updated Japanese translation for upcoming version 4.2 is in attachment. > Message catalog is based on git bb25d1a9. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Update French translation.
Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3fae181c27f45c457388159923cfd34b31b01da6 Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 155956 -> 156198 bytes .../translations/fr/LC_MESSAGES/messages.po| 1002 ++-- 2 files changed, 491 insertions(+), 511 deletions(-)
Re: french translation update
Thanks - patch applied. On Mon, Feb 4, 2019 at 4:34 PM wrote: > > hello > here is the french translation update for upcoming version > fred > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch]: Backform Switch control clean-up
Thanks, patch applied. On Tue, Feb 5, 2019 at 9:13 AM Khushboo Vashi wrote: > > Hi, > > Please find the attached patch for cleaning up the unwanted extended versions > of Backform Switch controls. > The Bootstrap Switch Control was extended only for alignment at most of the > places. In this patch, I have introduced a configurable option to set the > necessary class on the main div and also removed the extra extended controls. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Clean up the unwanted extended versions of Backform S
Clean up the unwanted extended versions of Backform Switch controls. The Bootstrap Switch Control was extended only for alignment in most places. IIntroduce a configurable option to set the necessary class on the main div and also remove the extra extended controls. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a75053514b90cc72385f4b33582fe5404a6d86e Author: Khushboo Vashi Modified Files -- .../schemas/tables/triggers/static/js/trigger.js | 35 +++--- .../servers/pgagent/steps/static/js/pga_jobstep.js | 3 +- .../server_groups/servers/roles/static/js/role.js | 88 --- web/pgadmin/static/js/backform.pgadmin.js | 7 +- web/pgadmin/tools/backup/static/js/backup.js | 118 - .../tools/maintenance/static/js/maintenance.js | 21 ++-- web/pgadmin/tools/restore/static/js/restore.js | 89 7 files changed, 234 insertions(+), 127 deletions(-)
Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases
Hi Aditya Some improvement, 1 test case is still failing but not consistent. I have run the test cases 3 times out of which one time all runs successfully. On Tue, Feb 5, 2019 at 5:28 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to fix possible causes of failure. > Kindly review (fingers crossed) > > > On Tue, Feb 5, 2019 at 10:48 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Akshay, I tried to simulate, but no luck. It works on my system :( >>> >>>I have tried and Feature test are failing randomly for each run. I >>> have verified it on OSX and Ubuntu both. >>> +1 >> >>> On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Aditya > > I have applied your patch but following test cases are failing > consistently: > >- CopySelectedQueryResultsFeatureTest >- QueryToolAutoCompleteFeatureTest > > I have verified your patch on Mac OSX and Ubuntu. Chrome Version > 71.0.3578.98 > > On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Tue, 29 Jan 2019, 19:09 Dave Page > >>> Akshay, can you look at this please? >>> >> >> Sure. >> >>> >>> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal >>> wrote: >>> > >>> > Hi Hackers, >>> > >>> > Attached is the updated patch. I have changed >>> fill_input_by_field_name function to use javascript to set values of >>> text >>> boxes and the selector is changed from xpath to CSS with a >>> :not(:disabled) >>> clause. With this, test case will fail if tried to set the value of a >>> disabled input. >>> > >>> > Kindly review. >>> > >>> > >>> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> >> >>> >> >>> >> >>> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page >>> wrote: >>> >>> >>> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal >>> >>> wrote: >>> >>> > >>> >>> > Hi Dave, >>> >>> > >>> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page >>> wrote: >>> >>> >> >>> >>> >> Hi >>> >>> >> >>> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal >>> >>> >> wrote: >>> >>> >> > >>> >>> >> > Hi Hackers, >>> >>> >> > >>> >>> >> > Attached is the patch to fix failing SQL editor related >>> feature tests. >>> >>> >> > The failure is occurring mostly because of send_keys >>> function of selenium which sometimes does not input the complete text. >>> The >>> change will use Codemirror javascript object to set the text. >>> >>> >> > >>> >>> >> > I have also added new args flag "--modules" which can be >>> used after --pkg where you can test a specific module file under the >>> pkg. >>> This is not so useful for build but definitely helpful for the >>> developers. >>> >>> >> >>> >>> >> One of the most common failures I see is failure to fill in >>> the >>> >>> >> details on the Add Server dialogue (it might type half of an >>> entry, >>> >>> >> then just hang). Should we get rid of all uses of send_keys? >>> >>> > >>> >>> > Setting the text using javascript executor can be done. >>> send_keys simulate an actual person, so if you try to set a disabled >>> text >>> box using send_keys, it won't. Places where disabled fields doesn't >>> matter, >>> send_keys can be removed. >>> >>> >>> >>> Can't we just do something like: >>> >>> >>> >>> if input.disabled == false: >>> >>> input.value = 'Foo'; >>> >>> else: >>> >>> raise exception >>> >> >>> >> I'll check if this can be done. Will get back. >>> >>> >>> >>> >>> >>> -- >>> >>> Dave Page >>> >>> Blog: http://pgsnake.blogspot.com >>> >>> Twitter: @pgsnake >>> >>> >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> >>> The Enterprise PostgreSQL Company >>> >> >>> >> >>> >> >>> >> -- >>> >> Thanks and Regards, >>> >> Aditya Toshniwal >>> >> Software Engineer | EnterpriseDB Software Solutions | Pune >>> >> "Don't Complain about Heat, Plant a tree" >>> > >>> > >>> > >>> > -- >>> > Thanks and Regards, >>> > Aditya Toshniwal >>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>> > "Don't Complain about Heat, Plant a tree" >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>>
[pgAdmin4][Patch]: RM #3942 Close all the connections gracefully when logout from pgAdmin4
Hi Hackers, Attached is the patch to fix RM #3942 "Close all the connections gracefully when logout from pgAdmin4". Initial patch sent by Harshal that contains the logic of registration/callback mechanism when user logout from pgAdmin4. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3942.patch Description: Binary data
