Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

[Aditya Toshniwal]

Hi Akshay,

I tried to simulate, but no luck. It works on my system :(

On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi 
wrote:

> Hi Aditya
>
> I have applied your patch but following test cases are failing
> consistently:
>
>- CopySelectedQueryResultsFeatureTest
>- QueryToolAutoCompleteFeatureTest
>
> I have verified your patch on Mac OSX and Ubuntu. Chrome Version
> 71.0.3578.98
>
> On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, 29 Jan 2019, 19:09 Dave Page >
>>> Akshay, can you look at this please?
>>>
>>
>> Sure.
>>
>>>
>>> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
>>>  wrote:
>>> >
>>> > Hi Hackers,
>>> >
>>> > Attached is the updated patch. I have changed fill_input_by_field_name
>>> function to use javascript to set values of text boxes and the selector is
>>> changed from xpath to CSS with a :not(:disabled) clause. With this, test
>>> case will fail if tried to set the value of a disabled input.
>>> >
>>> > Kindly review.
>>> >
>>> >
>>> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>> >>
>>> >>
>>> >>
>>> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page  wrote:
>>> >>>
>>> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
>>> >>>  wrote:
>>> >>> >
>>> >>> > Hi Dave,
>>> >>> >
>>> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page 
>>> wrote:
>>> >>> >>
>>> >>> >> Hi
>>> >>> >>
>>> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
>>> >>> >>  wrote:
>>> >>> >> >
>>> >>> >> > Hi Hackers,
>>> >>> >> >
>>> >>> >> > Attached is the patch to fix failing SQL editor related feature
>>> tests.
>>> >>> >> > The failure is occurring mostly because of send_keys function
>>> of selenium which sometimes does not input the complete text. The change
>>> will use Codemirror javascript object to set the text.
>>> >>> >> >
>>> >>> >> > I have also added new args flag "--modules" which can be used
>>> after --pkg where you can test a specific module file under the pkg. This
>>> is not so useful for build but definitely helpful for the developers.
>>> >>> >>
>>> >>> >> One of the most common failures I see is failure to fill in the
>>> >>> >> details on the Add Server dialogue (it might type half of an
>>> entry,
>>> >>> >> then just hang). Should we get rid of all uses of send_keys?
>>> >>> >
>>> >>> > Setting the text using javascript executor can be done. send_keys
>>> simulate an actual person,  so if you try to set a disabled text box using
>>> send_keys, it won't. Places where disabled fields doesn't matter, send_keys
>>> can be removed.
>>> >>>
>>> >>> Can't we just do something like:
>>> >>>
>>> >>> if input.disabled == false:
>>> >>>   input.value = 'Foo';
>>> >>> else:
>>> >>>   raise exception 
>>> >>
>>> >> I'll check if this can be done. Will get back.
>>> >>>
>>> >>>
>>> >>> --
>>> >>> Dave Page
>>> >>> Blog: http://pgsnake.blogspot.com
>>> >>> Twitter: @pgsnake
>>> >>>
>>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>>> >>> The Enterprise PostgreSQL Company
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Thanks and Regards,
>>> >> Aditya Toshniwal
>>> >> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> >> "Don't Complain about Heat, Plant a tree"
>>> >
>>> >
>>> >
>>> > --
>>> > Thanks and Regards,
>>> > Aditya Toshniwal
>>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>> > "Don't Complain about Heat, Plant a tree"
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Khushboo Vashi]

Hi Aditya,

I have reviewed the patch and it looks good to me except the logic to wait
until we get the response from the AJAX request.
So, in this case at a time only one request is being sent to the server.

@ Dave/Ashesh, if you think this is okay then we can commit the patch.

Thanks,
Khushboo

On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi 
wrote:

> Hi Khushboo
>
> Can you please review it.
>
> On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to optimise the dashboard. Changes include:
>> 1) One ajax request for the all the charts instead of separate for every
>> chart. The next request will not hit until the previous is completed.
>> 2) The code will check for intervals which is greatest common divisor of
>> all the refresh rates. Chart names which will be eligible for refresh will
>> be sent with the ajax. If none are eligible, no ajax will be fired.
>> 3) In the backend, query is generated in such a way that data for all the
>> requested chart names will be fetched in one hit to the database.
>> 4) Test cases for charts rest api and javascript added.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Dave Page]

I can't get to this right now, but Akshay, can we get it in before the
release?

I don't think the problem Khushboo notes is really a problem. Waiting for a
response before issuing another one seems sensible... as long as there's a
timeout so things don't get stuck if a response gets lost somehow. Maybe
the timeout should be something like 3x the normal interval?

On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Aditya,
>
> I have reviewed the patch and it looks good to me except the logic to wait
> until we get the response from the AJAX request.
> So, in this case at a time only one request is being sent to the server.
>
> @ Dave/Ashesh, if you think this is okay then we can commit the patch.
>
> Thanks,
> Khushboo
>
> On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Khushboo
>>
>> Can you please review it.
>>
>> On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to optimise the dashboard. Changes include:
>>> 1) One ajax request for the all the charts instead of separate for every
>>> chart. The next request will not hit until the previous is completed.
>>> 2) The code will check for intervals which is greatest common divisor of
>>> all the refresh rates. Chart names which will be eligible for refresh will
>>> be sent with the ajax. If none are eligible, no ajax will be fired.
>>> 3) In the backend, query is generated in such a way that data for all
>>> the requested chart names will be fetched in one hit to the database.
>>> 4) Test cases for charts rest api and javascript added.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Aditya Toshniwal]

Hi Hackers,

Attached is the updated patch. The poller will wait 3 times the normal
interval before sending new request if the previous request is pending.
After that, it will send the ajax.

Kindly review.

On Mon, Feb 4, 2019 at 3:12 PM Dave Page  wrote:

> I can't get to this right now, but Akshay, can we get it in before the
> release?
>
> I don't think the problem Khushboo notes is really a problem. Waiting for
> a response before issuing another one seems sensible... as long as there's
> a timeout so things don't get stuck if a response gets lost somehow. Maybe
> the timeout should be something like 3x the normal interval?
>
> On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Aditya,
>>
>> I have reviewed the patch and it looks good to me except the logic to
>> wait until we get the response from the AJAX request.
>> So, in this case at a time only one request is being sent to the server.
>>
>> @ Dave/Ashesh, if you think this is okay then we can commit the patch.
>>
>> Thanks,
>> Khushboo
>>
>> On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Khushboo
>>>
>>> Can you please review it.
>>>
>>> On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch to optimise the dashboard. Changes include:
 1) One ajax request for the all the charts instead of separate for
 every chart. The next request will not hit until the previous is completed.
 2) The code will check for intervals which is greatest common divisor
 of all the refresh rates. Chart names which will be eligible for refresh
 will be sent with the ajax. If none are eligible, no ajax will be fired.
 3) In the backend, query is generated in such a way that data for all
 the requested chart names will be fetched in one hit to the database.
 4) Test cases for charts rest api and javascript added.

 --
 Thanks and Regards,
 Aditya Toshniwal
 Software Engineer | EnterpriseDB Software Solutions | Pune
 "Don't Complain about Heat, Plant a tree"

>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RM3941_v2.patch
Description: Binary data

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Dave Page]

Hi

Do we also give up waiting for the original response?

On Mon, Feb 4, 2019 at 9:57 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the updated patch. The poller will wait 3 times the normal
> interval before sending new request if the previous request is pending.
> After that, it will send the ajax.
>
> Kindly review.
>
> On Mon, Feb 4, 2019 at 3:12 PM Dave Page  wrote:
>
>> I can't get to this right now, but Akshay, can we get it in before the
>> release?
>>
>> I don't think the problem Khushboo notes is really a problem. Waiting for
>> a response before issuing another one seems sensible... as long as there's
>> a timeout so things don't get stuck if a response gets lost somehow. Maybe
>> the timeout should be something like 3x the normal interval?
>>
>> On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Aditya,
>>>
>>> I have reviewed the patch and it looks good to me except the logic to
>>> wait until we get the response from the AJAX request.
>>> So, in this case at a time only one request is being sent to the server.
>>>
>>> @ Dave/Ashesh, if you think this is okay then we can commit the patch.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Khushboo

 Can you please review it.

 On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to optimise the dashboard. Changes include:
> 1) One ajax request for the all the charts instead of separate for
> every chart. The next request will not hit until the previous is 
> completed.
> 2) The code will check for intervals which is greatest common divisor
> of all the refresh rates. Chart names which will be eligible for refresh
> will be sent with the ajax. If none are eligible, no ajax will be fired.
> 3) In the backend, query is generated in such a way that data for all
> the requested chart names will be fetched in one hit to the database.
> 4) Test cases for charts rest api and javascript added.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


 --
 *Akshay Joshi*

 *Sr. Software Architect *



 *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Aditya Toshniwal]

Hi Dave,

On Mon, Feb 4, 2019 at 3:36 PM Dave Page  wrote:

> Hi
>
> Do we also give up waiting for the original response?
>
No, that will wait until AJAX request timeout. We do not cancel it
explicitly. If response is received, it will be reflected.

>
> On Mon, Feb 4, 2019 at 9:57 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch. The poller will wait 3 times the normal
>> interval before sending new request if the previous request is pending.
>> After that, it will send the ajax.
>>
>> Kindly review.
>>
>> On Mon, Feb 4, 2019 at 3:12 PM Dave Page  wrote:
>>
>>> I can't get to this right now, but Akshay, can we get it in before the
>>> release?
>>>
>>> I don't think the problem Khushboo notes is really a problem. Waiting
>>> for a response before issuing another one seems sensible... as long as
>>> there's a timeout so things don't get stuck if a response gets lost
>>> somehow. Maybe the timeout should be something like 3x the normal interval?
>>>
>>> On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Aditya,

 I have reviewed the patch and it looks good to me except the logic to
 wait until we get the response from the AJAX request.
 So, in this case at a time only one request is being sent to the server.

 @ Dave/Ashesh, if you think this is okay then we can commit the patch.

 Thanks,
 Khushboo

 On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Khushboo
>
> Can you please review it.
>
> On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to optimise the dashboard. Changes include:
>> 1) One ajax request for the all the charts instead of separate for
>> every chart. The next request will not hit until the previous is 
>> completed.
>> 2) The code will check for intervals which is greatest common divisor
>> of all the refresh rates. Chart names which will be eligible for refresh
>> will be sent with the ajax. If none are eligible, no ajax will be fired.
>> 3) In the backend, query is generated in such a way that data for all
>> the requested chart names will be fetched in one hit to the database.
>> 4) Test cases for charts rest api and javascript added.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

pgAdmin 4 commit: Dashboard graph optimization. Fixes #3941

[Akshay Joshi]

Dashboard graph optimization. Fixes #3941

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aad7830d370f9425a359b85d3269d5616622760d
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_2.rst   |   1 +
web/pgadmin/dashboard/__init__.py  | 117 ++-
web/pgadmin/dashboard/static/js/charting.js|   4 +-
web/pgadmin/dashboard/static/js/dashboard.js   | 376 -
.../templates/dashboard/sql/default/bio_stats.sql  |   4 -
.../dashboard/sql/default/dashboard_stats.sql  |  56 +++
.../dashboard/sql/default/session_stats.sql|   5 -
.../templates/dashboard/sql/default/ti_stats.sql   |   5 -
.../templates/dashboard/sql/default/to_stats.sql   |   4 -
.../templates/dashboard/sql/default/tps_stats.sql  |   5 -
.../sql/gpdb_5.0_plus/dashboard_stats.sql  |  56 +++
.../dashboard/sql/gpdb_5.0_plus/session_stats.sql  |   5 -
.../dashboard/tests/test_dashboard_graphs.py   | 119 +++
web/pgadmin/static/js/utils.js |  24 ++
.../javascript/dashboard/charting_spec.js  |   4 +
web/regression/javascript/pgadmin_utils_spec.js|  35 ++
16 files changed, 536 insertions(+), 284 deletions(-)

pgAdmin 4 commit: There are no new features in 4.1 or 4.2, just fixes a

[Dave Page]

There are no new features in 4.1 or 4.2, just fixes and optimisations.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9df89f9bd55ab170b86a362168ff125d958fa2d0

Modified Files
--
docs/en_US/release_notes_4_1.rst | 7 +--
docs/en_US/release_notes_4_2.rst | 7 +--
2 files changed, 2 insertions(+), 12 deletions(-)

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Dave Page]

On Mon, Feb 4, 2019 at 10:10 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Mon, Feb 4, 2019 at 3:36 PM Dave Page  wrote:
>
>> Hi
>>
>> Do we also give up waiting for the original response?
>>
> No, that will wait until AJAX request timeout. We do not cancel it
> explicitly. If response is received, it will be reflected.
>

OK, so it won't hang around forever. Thats fine.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Akshay Joshi]

Thanks patch applied.

On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the updated patch. The poller will wait 3 times the normal
> interval before sending new request if the previous request is pending.
> After that, it will send the ajax.
>
> Kindly review.
>
> On Mon, Feb 4, 2019 at 3:12 PM Dave Page  wrote:
>
>> I can't get to this right now, but Akshay, can we get it in before the
>> release?
>>
>> I don't think the problem Khushboo notes is really a problem. Waiting for
>> a response before issuing another one seems sensible... as long as there's
>> a timeout so things don't get stuck if a response gets lost somehow. Maybe
>> the timeout should be something like 3x the normal interval?
>>
>> On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Aditya,
>>>
>>> I have reviewed the patch and it looks good to me except the logic to
>>> wait until we get the response from the AJAX request.
>>> So, in this case at a time only one request is being sent to the server.
>>>
>>> @ Dave/Ashesh, if you think this is okay then we can commit the patch.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Khushboo

 Can you please review it.

 On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to optimise the dashboard. Changes include:
> 1) One ajax request for the all the charts instead of separate for
> every chart. The next request will not hit until the previous is 
> completed.
> 2) The code will check for intervals which is greatest common divisor
> of all the refresh rates. Chart names which will be eligible for refresh
> will be sent with the ajax. If none are eligible, no ajax will be fired.
> 3) In the backend, query is generated in such a way that data for all
> the requested chart names will be fetched in one hit to the database.
> 4) Test cases for charts rest api and javascript added.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


 --
 *Akshay Joshi*

 *Sr. Software Architect *



 *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgAdmin4][RM3961] - Exclude HTTPExceptions from all_exception_handler

[navnath gadakh]

Hi Hackers,
 Please find the attached patch for RM-3961.
This is improvement to commit 1f298590400cf5d2921a07e200086e16cc22f72c

Thanks!

-- 
Regards,
Navnath Gadakh


RM-3961_v1.patch
Description: Binary data

Build failed in Jenkins: pgadmin4-master-python36 #906

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Dashboard graph optimization. Fixes #3941

[Dave Page] There are no new features in 4.1 or 4.2, just fixes and 
optimisations.

--
[...truncated 1001.08 KB...]
PgAgentGetTestCase (Get pgAgent job)
PgAgentPutScheduleTestCase (Update schedule with start and end 
time,
Update schedule with repeat,
Update schedule add exception,
Update schedule change exception date 
and time,
Update schedule delete exception)
PgAgentPutStepTestCase (Update step with kind, description, 
code and error,
Update step with connection type and 
string)
PgAgentStatsTestCase (Check the stats of pgAgent job)
TestSSLConnection (Test for SSL connection)
BackupCreateJobTest (When backup object with default options,
When backup object with format 
directory,
When backup the object with option 
sections to all data,
When backup the object with option 
only_data,
When backup the object with option 
only_schema,
When backup the object with option - 
format plain and dns_owner,
When backup the object with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the object with option - Do 
not save comments,,
When backup the object with option - 
all queries,
When backup the object with option - 
load via partition root,
When backup the object with option - 
all queries and format custom,
When backup the object with option - 
miscellaneous,
When backup the object with format tar,
When backup the server,
When backup the server with option 
only_data,
When backup the server with option 
only_schema,
When backup the server with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the server with option - Do 
not save comments,,
When backup the server with option - 
all queries,
When backup the server with option - 
miscellaneous,
When backup the server with encoding,
When backup globals)
TestUtilityCheckRouteCase (Check utility path route for backup 
utility,
Check utility path route for import 
export utility,
Check utility path route for 
maintenance utility,
Check utility path route for restore 
utility)
BackupJobTest (When backup the object with the default options)
MaintenanceJobTest (When maintenance the object with the 
default options)
MaintenanceCreateJobTest (When maintenance object with default 
options,
When maintenance object with VACUUM 
FULL,
When maintenance object with the 
ANALYZE,
When maintenance the object with the 
REINDEX,
When maintenance the object with the 
CLUSTER)
RestoreJobTest (When restore the object with the default 
options)
RestoreCreateJobTest (When restore object with default options,
When restore object with format 
directory,
When restore object with the sections 
options,
When restore the object with Type of 
objects,
When restore object with option - Do 
not save,
When restore object with option - Do 
not save comments,
When restore object with option - 
Queries,
When restore object with option - 
Disbale,
When restore object with option - 
Miscellaneous)

EDB Postgres AS 9.5:

433 tests passed
 

pgAdmin 4 commit: Added 'pga4dash' comment for consistency

[Akshay Joshi]

Added 'pga4dash' comment for consistency

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da83c3d1b8d3d39dab7d6bc79a47928bcced3aab

Modified Files
--
.../dashboard/templates/dashboard/sql/default/dashboard_stats.sql| 1 +
.../dashboard/templates/dashboard/sql/gpdb_5.0_plus/dashboard_stats.sql  | 1 +
2 files changed, 2 insertions(+)

pgAdmin 4 commit: Correct error message.

[Dave Page]

Correct error message.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c21c07fc48d14692f1d102683bb9e0fd255ef2f

Modified Files
--
web/pgadmin/tools/datagrid/static/js/datagrid.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python34 #907

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Dashboard graph optimization. Fixes #3941

[Dave Page] There are no new features in 4.1 or 4.2, just fixes and 
optimisations.

--
[...truncated 1001.95 KB...]
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
TableAddTestCase (Create Hash partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
BackupJobTest (When backup the object with the default options)
MaintenanceCreateJobTest (When maintenance the object with the 
CLUSTER,
When maintenance the object with the 
REINDEX,
When maintenance object with the 
ANALYZE,
When maintenance object with default 
options,
When maintenance object with VACUUM 
FULL)
RestoreCreateJobTest (When restore object with option - 
Miscellaneous,
When restore object with format 
directory,
When restore object with option - 
Queries,
When restore the object with Type of 
objects,
When restore object with option - Do 
not save,
When restore object with the sections 
options,
When restore object with option - Do 
not save comments,
When restore object with default 
options,
When restore object with option - 
Disbale)
PgAgentPutStepTestCase (Update step with connection type and 
string,
Update step with kind, description, 
code and error)
ResourceGroupsAddTestCase (Add resource groups)

EDB Postgres AS 9.4:

433 tests passed
0 tests failed
21 tests skipped:
PgAgentDeleteStepTestCase (Delete pgAgent Step)
BackupCreateJobTest (When backup globals,
When backup object with default options,
When backup the object with option 
only_data,
When backup the object with option - 
miscellaneous,
When backup the server with encoding,
When backup the server,
When backup the server with option 
only_data,
When backup the server with option - Do 
not save comments,,
When backup object with format 
directory,
When backup the object with option - 
format plain and dns_owner,
When backup the object with option 
sections to all data,
When backup the object with option 
only_schema,
When backup the server with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the server with option 
only_schema,
When backup the object with option - 
load via partition root,
When backup the server with option - 
miscellaneous,
When backup the server with option - 
all queries,
When backup the object with option - 
all queries and format custom,
When backup the object with format tar,
When backup the object with option - Do 
not save comments,,
When backup the object with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the object with option - 
all queries)
PgAgentStatsTestCase (Check the stats of pgAgent job)
PgAgentAddTestCase (Add pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentAddStepTestCase (Create step for pgAgent job)
TestSSLConnection (Test for SSL connection)
PgAgentPutScheduleTestCase (Update schedule with start and end 
time,
Update schedule change exception date 
and time,
Update schedule delete exception,
   

pgAdmin 4 commit: Exclude HTTPExceptions from the all_exception_handler

[Dave Page]

Exclude HTTPExceptions from the all_exception_handler as they should be 
returned as-is. Fixes #3961

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fdc1ffb38131a660adaa9bf83d6a295479793bf
Author: Navnath Gadakh 

Modified Files
--
docs/en_US/release_notes_4_2.rst | 3 ++-
web/pgadmin/__init__.py  | 9 +
2 files changed, 11 insertions(+), 1 deletion(-)

Re: [pgAdmin4][RM3961] - Exclude HTTPExceptions from all_exception_handler

[Dave Page]

Thanks, applied with minor PEP-8 fixes. Please remember to run "make
check-pep8"!!

On Mon, Feb 4, 2019 at 10:17 AM navnath gadakh
 wrote:
>
> Hi Hackers,
>  Please find the attached patch for RM-3961.
> This is improvement to commit 1f298590400cf5d2921a07e200086e16cc22f72c
>
> Thanks!
>
> --
> Regards,
> Navnath Gadakh



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python35 #899

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Dashboard graph optimization. Fixes #3941

[Dave Page] There are no new features in 4.1 or 4.2, just fixes and 
optimisations.

[akshay.joshi] Added 'pga4dash' comment for consistency

[Dave Page] Correct error message.

--
[...truncated 1001.52 KB...]
When backup the server with option 
only_data,
When backup the server with option - 
miscellaneous,
When backup the server with option 
only_schema,
When backup object with format 
directory,
When backup the object with option - 
load via partition root,
When backup the server)
PackageDeleteTestCase (Fetch Package Node URL)

EDB Postgres AS 9.2:

419 tests passed
0 tests failed
35 tests skipped:
ResourceGroupsGetTestCase (Get resource groups)
PgAgentDeleteStepTestCase (Delete pgAgent Step)
MaintenanceJobTest (When maintenance the object with the 
default options)
TestUtilityCheckRouteCase (Check utility path route for 
maintenance utility,
Check utility path route for import 
export utility,
Check utility path route for backup 
utility,
Check utility path route for restore 
utility)
RestoreCreateJobTest (When restore object with format directory,
When restore object with option - Do 
not save comments,
When restore object with default 
options,
When restore object with the sections 
options,
When restore object with option - Do 
not save,
When restore object with option - 
Queries,
When restore object with option - 
Disbale,
When restore the object with Type of 
objects,
When restore object with option - 
Miscellaneous)
ResourceGroupsAddTestCase (Add resource groups)
PgAgentPutTestCase (Put pgAgent job)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
ViewsGetTestCase (Get materialized view under schema node)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
PgAgentPutScheduleTestCase (Update schedule with start and end 
time,
Update schedule change exception date 
and time,
Update schedule add exception,
Update schedule with repeat,
Update schedule delete exception)
ResourceGroupsPutTestCase (Put resource groups)
PgAgentAddStepTestCase (Create step for pgAgent job)
PgAgentPutStepTestCase (Update step with kind, description, 
code and error,
Update step with connection type and 
string)
RestoreJobTest (When restore the object with the default 
options)
ViewsAddTestCase (Add materialized view under schema node)
PgAgentGetTestCase (Get pgAgent job)
ResourceGroupsDeleteTestCase (Delete resource groups,
Delete multiple resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions,
Create Hash partitioned table with 2 
partitions)
PgAgentDeleteScheduleTestCase (Delete pgAgent Schedule)
BackupJobTest (When backup the object with the default options)
PgAgentStatsTestCase (Check the stats of pgAgent job)
PgAgentAddTestCase (Add pgAgent job)
EventTriggerAddTestCase 

Build failed in Jenkins: pgadmin4-master-python37 #146

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Dashboard graph optimization. Fixes #3941

[Dave Page] There are no new features in 4.1 or 4.2, just fixes and 
optimisations.

[akshay.joshi] Added 'pga4dash' comment for consistency

[Dave Page] Correct error message.

[Dave Page] Exclude HTTPExceptions from the all_exception_handler as they 
should be

--
[...truncated 1001.65 KB...]
PgAgentGetTestCase (Get pgAgent job)
PgAgentPutScheduleTestCase (Update schedule with start and end 
time,
Update schedule with repeat,
Update schedule add exception,
Update schedule change exception date 
and time,
Update schedule delete exception)
PgAgentPutStepTestCase (Update step with kind, description, 
code and error,
Update step with connection type and 
string)
PgAgentStatsTestCase (Check the stats of pgAgent job)
TestSSLConnection (Test for SSL connection)
BackupCreateJobTest (When backup object with default options,
When backup object with format 
directory,
When backup the object with option 
sections to all data,
When backup the object with option 
only_data,
When backup the object with option 
only_schema,
When backup the object with option - 
format plain and dns_owner,
When backup the object with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the object with option - Do 
not save comments,,
When backup the object with option - 
all queries,
When backup the object with option - 
load via partition root,
When backup the object with option - 
all queries and format custom,
When backup the object with option - 
miscellaneous,
When backup the object with format tar,
When backup the server,
When backup the server with option 
only_data,
When backup the server with option 
only_schema,
When backup the server with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the server with option - Do 
not save comments,,
When backup the server with option - 
all queries,
When backup the server with option - 
miscellaneous,
When backup the server with encoding,
When backup globals)
TestUtilityCheckRouteCase (Check utility path route for backup 
utility,
Check utility path route for import 
export utility,
Check utility path route for 
maintenance utility,
Check utility path route for restore 
utility)
BackupJobTest (When backup the object with the default options)
MaintenanceJobTest (When maintenance the object with the 
default options)
MaintenanceCreateJobTest (When maintenance object with default 
options,
When maintenance object with VACUUM 
FULL,
When maintenance object with the 
ANALYZE,
When maintenance the object with the 
REINDEX,
When maintenance the object with the 
CLUSTER)
RestoreJobTest (When restore the object with the default 
options)
RestoreCreateJobTest (When restore object with default options,
When restore object with format 
directory,
When restore object with the sections 
options,
When restore the object with Type of 
objects,
When restore object with option - Do 
not save,
When restore object with option - Do 
not save comments,
When restore object with option - 
Queries,
When

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Aditya Toshniwal]

Hi Hackers,

Attached is the patch to change the dashboard test cases to fetch server_id
similar to how it is done in other test cases.

Kindly review.

On Mon, Feb 4, 2019 at 3:43 PM Akshay Joshi 
wrote:

> Thanks patch applied.
>
> On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch. The poller will wait 3 times the normal
>> interval before sending new request if the previous request is pending.
>> After that, it will send the ajax.
>>
>> Kindly review.
>>
>> On Mon, Feb 4, 2019 at 3:12 PM Dave Page  wrote:
>>
>>> I can't get to this right now, but Akshay, can we get it in before the
>>> release?
>>>
>>> I don't think the problem Khushboo notes is really a problem. Waiting
>>> for a response before issuing another one seems sensible... as long as
>>> there's a timeout so things don't get stuck if a response gets lost
>>> somehow. Maybe the timeout should be something like 3x the normal interval?
>>>
>>> On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Aditya,

 I have reviewed the patch and it looks good to me except the logic to
 wait until we get the response from the AJAX request.
 So, in this case at a time only one request is being sent to the server.

 @ Dave/Ashesh, if you think this is okay then we can commit the patch.

 Thanks,
 Khushboo

 On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Khushboo
>
> Can you please review it.
>
> On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to optimise the dashboard. Changes include:
>> 1) One ajax request for the all the charts instead of separate for
>> every chart. The next request will not hit until the previous is 
>> completed.
>> 2) The code will check for intervals which is greatest common divisor
>> of all the refresh rates. Chart names which will be eligible for refresh
>> will be sent with the ajax. If none are eligible, no ajax will be fired.
>> 3) In the backend, query is generated in such a way that data for all
>> the requested chart names will be fetched in one hit to the database.
>> 4) Test cases for charts rest api and javascript added.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RM3941.apitest.patch
Description: Binary data

Build failed in Jenkins: pgadmin4-master-python27 #913

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Dashboard graph optimization. Fixes #3941

[Dave Page] There are no new features in 4.1 or 4.2, just fixes and 
optimisations.

[akshay.joshi] Added 'pga4dash' comment for consistency

[Dave Page] Correct error message.

[Dave Page] Exclude HTTPExceptions from the all_exception_handler as they 
should be

--
[...truncated 1003.80 KB...]
When backup the object with option - 
format plain and dns_owner,
When backup the server with option - 
miscellaneous,
When backup the object with option 
only_schema)
TableAddTestCase (Create Hash partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TestUtilityCheckRouteCase (Check utility path route for backup 
utility,
Check utility path route for 
maintenance utility,
Check utility path route for import 
export utility,
Check utility path route for restore 
utility)
RestoreCreateJobTest (When restore object with option - Disbale,
When restore the object with Type of 
objects,
When restore object with option - 
Miscellaneous,
When restore object with option - Do 
not save,
When restore object with option - 
Queries,
When restore object with default 
options,
When restore object with the sections 
options,
When restore object with option - Do 
not save comments,
When restore object with format 
directory)
PgAgentDeleteStepTestCase (Delete pgAgent Step)
PgAgentPutScheduleTestCase (Update schedule with repeat,
Update schedule change exception date 
and time,
Update schedule delete exception,
Update schedule add exception,
Update schedule with start and end time)
BackupJobTest (When backup the object with the default options)
TestSSLConnection (Test for SSL connection)
PgAgentGetTestCase (Get pgAgent job)
PgAgentPutStepTestCase (Update step with kind, description, 
code and error,
Update step with connection type and 
string)
PgAgentDeleteTestCase (Delete pgAgent job)
RestoreJobTest (When restore the object with the default 
options)
PgAgentDeleteScheduleTestCase (Delete pgAgent Schedule)

EDB Postgres AS 9.2:

419 tests passed
0 tests failed
35 tests skipped:
PgAgentAddStepTestCase (Create step for pgAgent job)
PgAgentAddScheduleTestCase (Create schedule with exception in 
pgAgent job)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ViewsDeleteTestCase (Delete materialized view under schema node)
ViewsGetTestCase (Get materialized view under schema node)
PgAgentPutTestCase (Put pgAgent job)
ResourceGroupsGetTestCase (Get resource groups)
TableAddTestCase (Create Hash partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ViewsDeleteMultipleTestCase (Delete multiple materialized view 
under schema node)
PgAgentDeleteScheduleTestCase (Delete pgAgent Schedule)
ResourceGroupsDeleteTestCase (Delete multiple resource groups,
Delete resource groups)
PgAgentPutScheduleTestCase (Update schedule with repeat,
  

Build failed in Jenkins: pgadmin4-master-python36 #907

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Added 'pga4dash' comment for consistency

[Dave Page] Correct error message.

[Dave Page] Exclude HTTPExceptions from the all_exception_handler as they 
should be

--
[...truncated 1001.22 KB...]
PgAgentGetTestCase (Get pgAgent job)
PgAgentPutScheduleTestCase (Update schedule with start and end 
time,
Update schedule with repeat,
Update schedule add exception,
Update schedule change exception date 
and time,
Update schedule delete exception)
PgAgentPutStepTestCase (Update step with kind, description, 
code and error,
Update step with connection type and 
string)
PgAgentStatsTestCase (Check the stats of pgAgent job)
TestSSLConnection (Test for SSL connection)
BackupCreateJobTest (When backup object with default options,
When backup object with format 
directory,
When backup the object with option 
sections to all data,
When backup the object with option 
only_data,
When backup the object with option 
only_schema,
When backup the object with option - 
format plain and dns_owner,
When backup the object with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the object with option - Do 
not save comments,,
When backup the object with option - 
all queries,
When backup the object with option - 
load via partition root,
When backup the object with option - 
all queries and format custom,
When backup the object with option - 
miscellaneous,
When backup the object with format tar,
When backup the server,
When backup the server with option 
only_data,
When backup the server with option 
only_schema,
When backup the server with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the server with option - Do 
not save comments,,
When backup the server with option - 
all queries,
When backup the server with option - 
miscellaneous,
When backup the server with encoding,
When backup globals)
TestUtilityCheckRouteCase (Check utility path route for backup 
utility,
Check utility path route for import 
export utility,
Check utility path route for 
maintenance utility,
Check utility path route for restore 
utility)
BackupJobTest (When backup the object with the default options)
MaintenanceJobTest (When maintenance the object with the 
default options)
MaintenanceCreateJobTest (When maintenance object with default 
options,
When maintenance object with VACUUM 
FULL,
When maintenance object with the 
ANALYZE,
When maintenance the object with the 
REINDEX,
When maintenance the object with the 
CLUSTER)
RestoreJobTest (When restore the object with the default 
options)
RestoreCreateJobTest (When restore object with default options,
When restore object with format 
directory,
When restore object with the sections 
options,
When restore the object with Type of 
objects,
When restore object with option - Do 
not save,
When restore object with option - Do 
not save comments,
When restore object with option - 
Queries,
When restore object with option - 
Disbale,
When restore object with option - 
Miscellaneous)

EDB Postgres

pgAdmin 4 commit: Fixed API test case for dashboard graphs.

[Akshay Joshi]

Fixed API test case for dashboard graphs.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=605b1f479925c98471fa8f6744f5b35a8856085d
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/dashboard/tests/test_dashboard_graphs.py | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)

Build failed in Jenkins: pgadmin4-master-python34 #908

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Added 'pga4dash' comment for consistency

[Dave Page] Correct error message.

[Dave Page] Exclude HTTPExceptions from the all_exception_handler as they 
should be

--
[...truncated 1001.85 KB...]
When backup the object with option - Do 
not save privilege, tablespace, unlogged table data,
When backup the object with option - 
all queries,
When backup the server with encoding,
When backup the object with option - 
miscellaneous,
When backup the object with option 
only_data,
When backup the server with option - Do 
not save privilege, tablespace, unlogged table data,
When backup globals,
When backup object with default options,
When backup the object with format tar,
When backup the object with option - Do 
not save comments,,
When backup the object with option - 
all queries and format custom,
When backup the server with option - 
miscellaneous,
When backup the server with option - Do 
not save comments,,
When backup the server with option 
only_schema,
When backup the object with option - 
load via partition root,
When backup the server,
When backup the object with option - 
format plain and dns_owner,
When backup object with format 
directory)
PgAgentAddTestCase (Add pgAgent job)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table)
RestoreJobTest (When restore the object with the default 
options)
PgAgentStatsTestCase (Check the stats of pgAgent job)
MaintenanceJobTest (When maintenance the object with the 
default options)
RestoreCreateJobTest (When restore object with option - Do not 
save,
When restore object with format 
directory,
When restore object with the sections 
options,
When restore object with option - 
Disbale,
When restore object with option - 
Queries,
When restore object with option - 
Miscellaneous,
When restore object with option - Do 
not save comments,
When restore object with default 
options,
When restore the object with Type of 
objects)
ResourceGroupsAddTestCase (Add resource groups)
PgAgentDeleteScheduleTestCase (Delete pgAgent Schedule)
PgAgentGetTestCase (Get pgAgent job)
MaintenanceCreateJobTest (When maintenance the object with the 
CLUSTER,
When maintenance object with default 
options,
When maintenance object with the 
ANALYZE,
When maintenance the object with the 
REINDEX,
When maintenance object with VACUUM 
FULL)
ProcedureAddTestCase (Fetch Procedure Node URL)
ResourceGroupsDeleteTestCase (Delete multiple resource groups,
Delete resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
PgAgentAddStepTestCase (Create step for pgAgent job)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
PackageDeleteMultipleTestCase (Fetch Package Node URL)
PgAgentAddScheduleTestCase (Create schedule with exception in 
pgAgent job)
ResourceGroupsGetTestCase (Get resource groups)
PgAgentPutTestCase (Put pgAgen

Build failed in Jenkins: pgadmin4-master-python35 #900

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Exclude HTTPExceptions from the all_exception_handler as they 
should be

--
[...truncated 1001.83 KB...]
Update schedule change exception date 
and time,
Update schedule delete exception,
Update schedule with start and end time,
Update schedule with repeat)
ProcedureGetTestCase (Fetch Procedure Node URL)
PgAgentGetTestCase (Get pgAgent job)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ProcedureExecSQLTestCase (Fetch Procedure with arguuments SQL 
to execute,
Fetch Procedure SQL to execute)
PackagePutTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)
PgAgentDeleteScheduleTestCase (Delete pgAgent Schedule)
RestoreJobTest (When restore the object with the default 
options)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsGetTestCase (Get resource groups)
PackageDeleteMultipleTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

411 tests passed
1 test failed:
DashboardGraphsTestCase (TestCase for session_stats graph,
TestCase for no graph,
TestCase for to_stats graph,
TestCase for two graphs,
TestCase for five graphs,
TestCase for tps_stats graph,
TestCase for ti_stats graph,
TestCase for bio_stats graph)
42 tests skipped:
PgAgentAddScheduleTestCase (Create schedule with exception in 
pgAgent job)
ResourceGroupsPutTestCase (Put resource groups)
PgAgentDeleteStepTestCase (Delete pgAgent Step)
TestUtilityCheckRouteCase (Check utility path route for backup 
utility,
Check utility path route for restore 
utility,
Check utility path route for import 
export utility,
Check utility path route for 
maintenance utility)
PackageEDBFuncsGetTestCase (Fetch Package Functions/Procedures 
URL)
RestoreCreateJobTest (When restore object with option - 
Miscellaneous,
When restore object with option - Do 
not save comments,
When restore object with default 
options,
When restore the object with Type of 
objects,
When restore object with option - 
Queries,
When restore object with option - Do 
not save,
When restore object with the sections 
options,
When restore object with format 
directory,
When restore object with option - 
Disbale)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
PgAgentPutTestCase (Put pgAgent job)
ResourceGroupsDeleteTestCase (Delete multiple resource groups,
Delete resource groups)
SynonymDeleteMultipleTestCase (Fetch synonym Node URL)
PgAgentStatsTestCase (Check the stats of pgAgent job)
procedureDeleteMultipleTestCase (Fetch Procedure Node URL)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table)
ProcedurePutTestCase (Fetch Procedure Node URL)
ProcedureAddTestCase (Fetch Procedure Node URL)
MaintenanceCreateJobTest (When maintenance object with VACUUM 
FULL,
When maintenance the object with the 
CLUSTER,
When maint

Build failed in Jenkins: pgadmin4-master-python36 #908

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Fixed API test case for dashboard graphs.

--
[...truncated 1.00 MB...]
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of 773 (1 FAILED) (0 
secs / 9.314 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 531 of 773 (1 FAILED) (0 
secs / 9.318 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 532 of 773 (1 FAILED) (0 
secs / 9.322 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 533 of 773 (1 FAILED) (0 
secs / 9.325 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 534 of 773 (1 FAILED) (0 
secs / 9.329 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 535 of 773 (1 FAILED) (0 
secs / 9.333 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 536 of 773 (1 FAILED) (0 
secs / 9.341 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 537 of 773 (1 FAILED) (0 
secs / 9.35 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 538 of 773 (1 FAILED) (0 
secs / 9.355 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 539 of 773 (1 FAILED) (0 
secs / 9.358 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 540 of 773 (1 FAILED) (0 
secs / 9.361 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 541 of 773 (1 FAILED) (0 
secs / 9.364 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 542 of 773 (1 FAILED) (0 
secs / 9.366 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 543 of 773 (1 FAILED) (0 
secs / 9.37 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 544 of 773 (1 FAILED) (0 
secs / 9.374 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 545 of 773 (1 FAILED) (0 
secs / 9.378 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 546 of 773 (1 FAILED) (0 
secs / 9.382 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 547 of 773 (1 FAILED) (0 
secs / 9.388 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 548 of 773 (1 FAILED) (0 
secs / 9.395 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 549 of 773 (1 FAILED) (0 
secs / 9.399 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 550 of 773 (1 FAILED) (0 
secs / 9.404 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 551 of 773 (1 FAILED) (0 
secs / 9.409 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 552 of 773 (1 FAILED) (0 
secs / 9.412 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 553 of 773 (1 FAILED) (0 
secs / 9.417 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 554 of 773 (1 FAILED) (0 
secs / 9.421 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 555 of 773 (1 FAILED) (0 
secs / 9.425 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 556 of 773 (1 FAILED) (0 
secs / 9.429 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 557 of 773 (1 FAILED) (0 
secs / 9.434 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 558 of 773 (1 FAILED) (0 
secs / 9.438 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 559 of 773 (1 FAILED) (0 
secs / 9.441 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 560 of 773 (1 FAILED) (0 
secs / 9.444 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 561 of 773 (1 FAILED) (0 
secs / 9.45 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 562 of 773 (1 FAILED) (0 
secs / 9.455 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 563 of 773 (1 FAILED) (0 
secs / 9.459 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 564 of 773 (1 FAILED) (0 
secs / 9.464 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 565 of 773 (1 FAILED) (0 
secs / 9.468 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 566 of 773 (1 FAILED) (0 
secs / 9.469 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 567 of 773 (1 FAILED) (0 
secs / 9.472 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 568 of 773 (1 FAILED) (0 
secs / 9.477 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 569 of 773 (1 FAILED) (0 
secs / 9.482 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 570 of 773 (1 FAILED) (0 
secs / 9.486 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 571 of 773 (1 FAILED) (0 
secs / 9.494 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 572 of 773 (1 FAILED) (0 
secs / 9.498 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 573 of 773 (1 FAILED) (0 
secs / 9.5 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 574 of 773 (1 FAILED) (0 
secs / 9.504 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 575 of 773 (1 FAILED) (0 
secs / 9.508 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 576 of 773 (1 FAILED) (0 
secs / 9.513 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 577 of 773 (1 FAILED) (0 
secs / 9.517 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 578 of 773 

Build failed in Jenkins: pgadmin4-master-python34 #909

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Fixed API test case for dashboard graphs.

--
[...truncated 1.00 MB...]
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of 773 (1 FAILED) (0 
secs / 9.247 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 531 of 773 (1 FAILED) (0 
secs / 9.251 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 532 of 773 (1 FAILED) (0 
secs / 9.254 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 533 of 773 (1 FAILED) (0 
secs / 9.257 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 534 of 773 (1 FAILED) (0 
secs / 9.265 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 535 of 773 (1 FAILED) (0 
secs / 9.269 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 536 of 773 (1 FAILED) (0 
secs / 9.273 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 537 of 773 (1 FAILED) (0 
secs / 9.279 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 538 of 773 (1 FAILED) (0 
secs / 9.283 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 539 of 773 (1 FAILED) (0 
secs / 9.285 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 540 of 773 (1 FAILED) (0 
secs / 9.287 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 541 of 773 (1 FAILED) (0 
secs / 9.289 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 542 of 773 (1 FAILED) (0 
secs / 9.293 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 543 of 773 (1 FAILED) (0 
secs / 9.296 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 544 of 773 (1 FAILED) (0 
secs / 9.301 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 545 of 773 (1 FAILED) (0 
secs / 9.304 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 546 of 773 (1 FAILED) (0 
secs / 9.309 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 547 of 773 (1 FAILED) (0 
secs / 9.313 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 548 of 773 (1 FAILED) (0 
secs / 9.32 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 549 of 773 (1 FAILED) (0 
secs / 9.325 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 550 of 773 (1 FAILED) (0 
secs / 9.328 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 551 of 773 (1 FAILED) (0 
secs / 9.331 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 552 of 773 (1 FAILED) (0 
secs / 9.335 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 553 of 773 (1 FAILED) (0 
secs / 9.345 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 554 of 773 (1 FAILED) (0 
secs / 9.349 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 555 of 773 (1 FAILED) (0 
secs / 9.353 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 556 of 773 (1 FAILED) (0 
secs / 9.357 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 557 of 773 (1 FAILED) (0 
secs / 9.361 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 558 of 773 (1 FAILED) (0 
secs / 9.365 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 559 of 773 (1 FAILED) (0 
secs / 9.369 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 560 of 773 (1 FAILED) (0 
secs / 9.374 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 561 of 773 (1 FAILED) (0 
secs / 9.378 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 562 of 773 (1 FAILED) (0 
secs / 9.381 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 563 of 773 (1 FAILED) (0 
secs / 9.387 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 564 of 773 (1 FAILED) (0 
secs / 9.392 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 565 of 773 (1 FAILED) (0 
secs / 9.395 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 566 of 773 (1 FAILED) (0 
secs / 9.398 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 567 of 773 (1 FAILED) (0 
secs / 9.402 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 568 of 773 (1 FAILED) (0 
secs / 9.406 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 569 of 773 (1 FAILED) (0 
secs / 9.41 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 570 of 773 (1 FAILED) (0 
secs / 9.414 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 571 of 773 (1 FAILED) (0 
secs / 9.422 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 572 of 773 (1 FAILED) (0 
secs / 9.425 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 573 of 773 (1 FAILED) (0 
secs / 9.427 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 574 of 773 (1 FAILED) (0 
secs / 9.434 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 575 of 773 (1 FAILED) (0 
secs / 9.438 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 576 of 773 (1 FAILED) (0 
secs / 9.442 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 577 of 773 (1 FAILED) (0 
secs / 9.446 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 578 of 7

Build failed in Jenkins: pgadmin4-master-python27 #914

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Fixed API test case for dashboard graphs.

--
[...truncated 1.00 MB...]
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of 773 (1 FAILED) (0 
secs / 7.226 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 531 of 773 (1 FAILED) (0 
secs / 7.229 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 532 of 773 (1 FAILED) (0 
secs / 7.232 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 533 of 773 (1 FAILED) (0 
secs / 7.238 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 534 of 773 (1 FAILED) (0 
secs / 7.242 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 535 of 773 (1 FAILED) (0 
secs / 7.245 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 536 of 773 (1 FAILED) (0 
secs / 7.254 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 537 of 773 (1 FAILED) (0 
secs / 7.256 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 538 of 773 (1 FAILED) (0 
secs / 7.259 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 539 of 773 (1 FAILED) (0 
secs / 7.26 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 540 of 773 (1 FAILED) (0 
secs / 7.263 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 541 of 773 (1 FAILED) (0 
secs / 7.267 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 542 of 773 (1 FAILED) (0 
secs / 7.269 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 543 of 773 (1 FAILED) (0 
secs / 7.271 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 544 of 773 (1 FAILED) (0 
secs / 7.275 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 545 of 773 (1 FAILED) (0 
secs / 7.278 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 546 of 773 (1 FAILED) (0 
secs / 7.283 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 547 of 773 (1 FAILED) (0 
secs / 7.288 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 548 of 773 (1 FAILED) (0 
secs / 7.294 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 549 of 773 (1 FAILED) (0 
secs / 7.298 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 550 of 773 (1 FAILED) (0 
secs / 7.302 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 551 of 773 (1 FAILED) (0 
secs / 7.305 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 552 of 773 (1 FAILED) (0 
secs / 7.308 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 553 of 773 (1 FAILED) (0 
secs / 7.31 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 554 of 773 (1 FAILED) (0 
secs / 7.314 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 555 of 773 (1 FAILED) (0 
secs / 7.317 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 556 of 773 (1 FAILED) (0 
secs / 7.32 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 557 of 773 (1 FAILED) (0 
secs / 7.323 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 558 of 773 (1 FAILED) (0 
secs / 7.328 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 559 of 773 (1 FAILED) (0 
secs / 7.331 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 560 of 773 (1 FAILED) (0 
secs / 7.334 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 561 of 773 (1 FAILED) (0 
secs / 7.338 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 562 of 773 (1 FAILED) (0 
secs / 7.343 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 563 of 773 (1 FAILED) (0 
secs / 7.347 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 564 of 773 (1 FAILED) (0 
secs / 7.35 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 565 of 773 (1 FAILED) (0 
secs / 7.353 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 566 of 773 (1 FAILED) (0 
secs / 7.355 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 567 of 773 (1 FAILED) (0 
secs / 7.359 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 568 of 773 (1 FAILED) (0 
secs / 7.362 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 569 of 773 (1 FAILED) (0 
secs / 7.366 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 570 of 773 (1 FAILED) (0 
secs / 7.37 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 571 of 773 (1 FAILED) (0 
secs / 7.376 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 572 of 773 (1 FAILED) (0 
secs / 7.378 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 573 of 773 (1 FAILED) (0 
secs / 7.381 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 574 of 773 (1 FAILED) (0 
secs / 7.384 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 575 of 773 (1 FAILED) (0 
secs / 7.387 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 576 of 773 (1 FAILED) (0 
secs / 7.391 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 577 of 773 (1 FAILED) (0 
secs / 7.394 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 578 of 773 

Build failed in Jenkins: pgadmin4-master-python37 #147

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Fixed API test case for dashboard graphs.

--
[...truncated 1.00 MB...]
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of 773 (1 FAILED) (0 
secs / 9.282 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 531 of 773 (1 FAILED) (0 
secs / 9.285 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 532 of 773 (1 FAILED) (0 
secs / 9.287 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 533 of 773 (1 FAILED) (0 
secs / 9.295 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 534 of 773 (1 FAILED) (0 
secs / 9.301 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 535 of 773 (1 FAILED) (0 
secs / 9.304 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 536 of 773 (1 FAILED) (0 
secs / 9.311 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 537 of 773 (1 FAILED) (0 
secs / 9.315 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 538 of 773 (1 FAILED) (0 
secs / 9.319 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 539 of 773 (1 FAILED) (0 
secs / 9.321 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 540 of 773 (1 FAILED) (0 
secs / 9.325 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 541 of 773 (1 FAILED) (0 
secs / 9.359 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 542 of 773 (1 FAILED) (0 
secs / 9.364 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 543 of 773 (1 FAILED) (0 
secs / 9.367 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 544 of 773 (1 FAILED) (0 
secs / 9.371 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 545 of 773 (1 FAILED) (0 
secs / 9.381 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 546 of 773 (1 FAILED) (0 
secs / 9.384 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 547 of 773 (1 FAILED) (0 
secs / 9.391 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 548 of 773 (1 FAILED) (0 
secs / 9.398 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 549 of 773 (1 FAILED) (0 
secs / 9.402 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 550 of 773 (1 FAILED) (0 
secs / 9.407 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 551 of 773 (1 FAILED) (0 
secs / 9.411 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 552 of 773 (1 FAILED) (0 
secs / 9.415 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 553 of 773 (1 FAILED) (0 
secs / 9.419 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 554 of 773 (1 FAILED) (0 
secs / 9.424 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 555 of 773 (1 FAILED) (0 
secs / 9.428 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 556 of 773 (1 FAILED) (0 
secs / 9.432 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 557 of 773 (1 FAILED) (0 
secs / 9.435 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 558 of 773 (1 FAILED) (0 
secs / 9.441 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 559 of 773 (1 FAILED) (0 
secs / 9.444 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 560 of 773 (1 FAILED) (0 
secs / 9.447 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 561 of 773 (1 FAILED) (0 
secs / 9.451 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 562 of 773 (1 FAILED) (0 
secs / 9.456 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 563 of 773 (1 FAILED) (0 
secs / 9.46 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 564 of 773 (1 FAILED) (0 
secs / 9.464 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 565 of 773 (1 FAILED) (0 
secs / 9.467 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 566 of 773 (1 FAILED) (0 
secs / 9.471 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 567 of 773 (1 FAILED) (0 
secs / 9.473 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 568 of 773 (1 FAILED) (0 
secs / 9.476 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 569 of 773 (1 FAILED) (0 
secs / 9.48 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 570 of 773 (1 FAILED) (0 
secs / 9.486 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 571 of 773 (1 FAILED) (0 
secs / 9.493 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 572 of 773 (1 FAILED) (0 
secs / 9.495 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 573 of 773 (1 FAILED) (0 
secs / 9.497 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 574 of 773 (1 FAILED) (0 
secs / 9.504 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 575 of 773 (1 FAILED) (0 
secs / 9.507 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 576 of 773 (1 FAILED) (0 
secs / 9.511 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 577 of 773 (1 FAILED) (0 
secs / 9.516 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 578 of 7

Build failed in Jenkins: pgadmin4-master-python35 #901

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] Fixed API test case for dashboard graphs.

--
[...truncated 1.00 MB...]
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of 773 (1 FAILED) (0 
secs / 7.219 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 531 of 773 (1 FAILED) (0 
secs / 7.222 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 532 of 773 (1 FAILED) (0 
secs / 7.225 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 533 of 773 (1 FAILED) (0 
secs / 7.23 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 534 of 773 (1 FAILED) (0 
secs / 7.233 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 535 of 773 (1 FAILED) (0 
secs / 7.236 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 536 of 773 (1 FAILED) (0 
secs / 7.242 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 537 of 773 (1 FAILED) (0 
secs / 7.245 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 538 of 773 (1 FAILED) (0 
secs / 7.248 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 539 of 773 (1 FAILED) (0 
secs / 7.249 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 540 of 773 (1 FAILED) (0 
secs / 7.252 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 541 of 773 (1 FAILED) (0 
secs / 7.254 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 542 of 773 (1 FAILED) (0 
secs / 7.257 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 543 of 773 (1 FAILED) (0 
secs / 7.259 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 544 of 773 (1 FAILED) (0 
secs / 7.263 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 545 of 773 (1 FAILED) (0 
secs / 7.266 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 546 of 773 (1 FAILED) (0 
secs / 7.27 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 547 of 773 (1 FAILED) (0 
secs / 7.275 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 548 of 773 (1 FAILED) (0 
secs / 7.281 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 549 of 773 (1 FAILED) (0 
secs / 7.285 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 550 of 773 (1 FAILED) (0 
secs / 7.29 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 551 of 773 (1 FAILED) (0 
secs / 7.293 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 552 of 773 (1 FAILED) (0 
secs / 7.296 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 553 of 773 (1 FAILED) (0 
secs / 7.3 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 554 of 773 (1 FAILED) (0 
secs / 7.305 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 555 of 773 (1 FAILED) (0 
secs / 7.309 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 556 of 773 (1 FAILED) (0 
secs / 7.312 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 557 of 773 (1 FAILED) (0 
secs / 7.318 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 558 of 773 (1 FAILED) (0 
secs / 7.321 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 559 of 773 (1 FAILED) (0 
secs / 7.323 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 560 of 773 (1 FAILED) (0 
secs / 7.327 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 561 of 773 (1 FAILED) (0 
secs / 7.331 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 562 of 773 (1 FAILED) (0 
secs / 7.334 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 563 of 773 (1 FAILED) (0 
secs / 7.338 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 564 of 773 (1 FAILED) (0 
secs / 7.341 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 565 of 773 (1 FAILED) (0 
secs / 7.346 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 566 of 773 (1 FAILED) (0 
secs / 7.349 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 567 of 773 (1 FAILED) (0 
secs / 7.35 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 568 of 773 (1 FAILED) (0 
secs / 7.354 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 569 of 773 (1 FAILED) (0 
secs / 7.357 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 570 of 773 (1 FAILED) (0 
secs / 7.364 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 571 of 773 (1 FAILED) (0 
secs / 7.369 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 572 of 773 (1 FAILED) (0 
secs / 7.372 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 573 of 773 (1 FAILED) (0 
secs / 7.373 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 574 of 773 (1 FAILED) (0 
secs / 7.379 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 575 of 773 (1 FAILED) (0 
secs / 7.382 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 576 of 773 (1 FAILED) (0 
secs / 7.386 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 577 of 773 (1 FAILED) (0 
secs / 7.389 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 578 of 773 (

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Aditya Toshniwal]

Hi Hackers,

Attached is the patch to fix jasmine test cases. Didn't realise the
timezones could create issues :(
Kindly review.

On Mon, Feb 4, 2019 at 4:17 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to change the dashboard test cases to fetch
> server_id similar to how it is done in other test cases.
>
> Kindly review.
>
> On Mon, Feb 4, 2019 at 3:43 PM Akshay Joshi 
> wrote:
>
>> Thanks patch applied.
>>
>> On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the updated patch. The poller will wait 3 times the normal
>>> interval before sending new request if the previous request is pending.
>>> After that, it will send the ajax.
>>>
>>> Kindly review.
>>>
>>> On Mon, Feb 4, 2019 at 3:12 PM Dave Page  wrote:
>>>
 I can't get to this right now, but Akshay, can we get it in before the
 release?

 I don't think the problem Khushboo notes is really a problem. Waiting
 for a response before issuing another one seems sensible... as long as
 there's a timeout so things don't get stuck if a response gets lost
 somehow. Maybe the timeout should be something like 3x the normal interval?

 On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi Aditya,
>
> I have reviewed the patch and it looks good to me except the logic to
> wait until we get the response from the AJAX request.
> So, in this case at a time only one request is being sent to the
> server.
>
> @ Dave/Ashesh, if you think this is okay then we can commit the patch.
>
> Thanks,
> Khushboo
>
> On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Khushboo
>>
>> Can you please review it.
>>
>> On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to optimise the dashboard. Changes include:
>>> 1) One ajax request for the all the charts instead of separate for
>>> every chart. The next request will not hit until the previous is 
>>> completed.
>>> 2) The code will check for intervals which is greatest common
>>> divisor of all the refresh rates. Chart names which will be eligible for
>>> refresh will be sent with the ajax. If none are eligible, no ajax will 
>>> be
>>> fired.
>>> 3) In the backend, query is generated in such a way that data for
>>> all the requested chart names will be fetched in one hit to the 
>>> database.
>>> 4) Test cases for charts rest api and javascript added.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RM3941.jasmine.patch
Description: Binary data

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

[Akshay Joshi]

Thanks patch applied.

On Mon, Feb 4, 2019 at 5:36 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix jasmine test cases. Didn't realise the
> timezones could create issues :(
> Kindly review.
>
> On Mon, Feb 4, 2019 at 4:17 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to change the dashboard test cases to fetch
>> server_id similar to how it is done in other test cases.
>>
>> Kindly review.
>>
>> On Mon, Feb 4, 2019 at 3:43 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks patch applied.
>>>
>>> On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the updated patch. The poller will wait 3 times the normal
 interval before sending new request if the previous request is pending.
 After that, it will send the ajax.

 Kindly review.

 On Mon, Feb 4, 2019 at 3:12 PM Dave Page  wrote:

> I can't get to this right now, but Akshay, can we get it in before the
> release?
>
> I don't think the problem Khushboo notes is really a problem. Waiting
> for a response before issuing another one seems sensible... as long as
> there's a timeout so things don't get stuck if a response gets lost
> somehow. Maybe the timeout should be something like 3x the normal 
> interval?
>
> On Mon, Feb 4, 2019 at 9:02 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Aditya,
>>
>> I have reviewed the patch and it looks good to me except the logic to
>> wait until we get the response from the AJAX request.
>> So, in this case at a time only one request is being sent to the
>> server.
>>
>> @ Dave/Ashesh, if you think this is okay then we can commit the patch.
>>
>> Thanks,
>> Khushboo
>>
>> On Mon, Feb 4, 2019 at 10:45 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Khushboo
>>>
>>> Can you please review it.
>>>
>>> On Fri, Feb 1, 2019 at 7:04 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch to optimise the dashboard. Changes include:
 1) One ajax request for the all the charts instead of separate for
 every chart. The next request will not hit until the previous is 
 completed.
 2) The code will check for intervals which is greatest common
 divisor of all the refresh rates. Chart names which will be eligible 
 for
 refresh will be sent with the ajax. If none are eligible, no ajax will 
 be
 fired.
 3) In the backend, query is generated in such a way that data for
 all the requested chart names will be fetched in one hit to the 
 database.
 4) Test cases for charts rest api and javascript added.

 --
 Thanks and Regards,
 Aditya Toshniwal
 Software Engineer | EnterpriseDB Software Solutions | Pune
 "Don't Complain about Heat, Plant a tree"

>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


 --
 Thanks and Regards,
 Aditya Toshniwal
 Software Engineer | EnterpriseDB Software Solutions | Pune
 "Don't Complain about Heat, Plant a tree"

>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: 1) Fixed jasmine test cases.

[Akshay Joshi]

1) Fixed jasmine test cases.
2) Bootstarp4 toggle size should be mini for triggers

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2ee5c4e8204b97da550c0f280370558f8ba2c8a
Author: Aditya Toshniwal 

Modified Files
--
.../servers/databases/schemas/tables/triggers/static/js/trigger.js| 1 +
web/regression/javascript/pgadmin_utils_spec.js   | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python37 #148

[pgAdmin 4 Jenkins]

See 

pgAdmin 4 commit: Update version for release.

[Akshay Joshi]

Update version for release.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a758f8fd3aaf71566bbe14495d5dbb013583770

Modified Files
--
runtime/Info.plist   | 4 ++--
runtime/pgAdmin4.pro | 2 +-
web/config.py| 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Update message catalogs

[Akshay Joshi]

Update message catalogs

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bb25d1a98667071e1da8470384118cea5adfd6c6

Modified Files
--
web/pgadmin/messages.pot   | 8472 --
.../translations/de/LC_MESSAGES/messages.mo|  Bin 146739 -> 147380 bytes
.../translations/de/LC_MESSAGES/messages.po| 8995 +--
.../translations/es/LC_MESSAGES/messages.mo|  Bin 151654 -> 152267 bytes
.../translations/es/LC_MESSAGES/messages.po| 9173 +--
.../translations/fr/LC_MESSAGES/messages.mo|  Bin 155446 -> 155956 bytes
.../translations/fr/LC_MESSAGES/messages.po| 9308 +---
.../translations/ja/LC_MESSAGES/messages.mo|  Bin 161817 -> 162322 bytes
.../translations/ja/LC_MESSAGES/messages.po| 9169 +--
.../translations/ko/LC_MESSAGES/messages.mo|  Bin 149224 -> 149862 bytes
.../translations/ko/LC_MESSAGES/messages.po| 9131 +--
.../translations/pl/LC_MESSAGES/messages.mo|  Bin 146995 -> 147635 bytes
.../translations/pl/LC_MESSAGES/messages.po| 9152 +--
.../translations/ru/LC_MESSAGES/messages.mo|  Bin 184964 -> 185459 bytes
.../translations/ru/LC_MESSAGES/messages.po| 9165 +--
.../translations/zh/LC_MESSAGES/messages.mo|  Bin 125593 -> 126587 bytes
.../translations/zh/LC_MESSAGES/messages.po| 8937 +--
17 files changed, 19733 insertions(+), 61769 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python35 #902

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python27 #915

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python34 #910

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python36 #909

[pgAdmin 4 Jenkins]

See 

pgAdmin4 v4.2 candidate builds

[Akshay Joshi]

Hi All,

pgAdmin4 v4.2 candidate builds and source can be found at
https://developer.pgadmin.org/builds/2019-02-04-1/

Fahar, can you please verify it for release on Thursday.

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Japanese translation for v4.2

[fn ln]

Hello.
Updated Japanese translation for upcoming version 4.2 is in attachment.
Message catalog is based on git bb25d1a9.


pgadmin4-4.2-ja.7z
Description: Binary data

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

[Akshay Joshi]

Hi Aditya

On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Akshay,
>
> I tried to simulate, but no luck. It works on my system :(
>

   I have tried and Feature test are failing randomly for each run. I have
verified it on OSX and Ubuntu both.

>
> On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Aditya
>>
>> I have applied your patch but following test cases are failing
>> consistently:
>>
>>- CopySelectedQueryResultsFeatureTest
>>- QueryToolAutoCompleteFeatureTest
>>
>> I have verified your patch on Mac OSX and Ubuntu. Chrome Version
>> 71.0.3578.98
>>
>> On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Tue, 29 Jan 2019, 19:09 Dave Page >>
 Akshay, can you look at this please?

>>>
>>> Sure.
>>>

 On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
  wrote:
 >
 > Hi Hackers,
 >
 > Attached is the updated patch. I have changed
 fill_input_by_field_name function to use javascript to set values of text
 boxes and the selector is changed from xpath to CSS with a :not(:disabled)
 clause. With this, test case will fail if tried to set the value of a
 disabled input.
 >
 > Kindly review.
 >
 >
 > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:
 >>
 >>
 >>
 >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page  wrote:
 >>>
 >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
 >>>  wrote:
 >>> >
 >>> > Hi Dave,
 >>> >
 >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page 
 wrote:
 >>> >>
 >>> >> Hi
 >>> >>
 >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
 >>> >>  wrote:
 >>> >> >
 >>> >> > Hi Hackers,
 >>> >> >
 >>> >> > Attached is the patch to fix failing SQL editor related
 feature tests.
 >>> >> > The failure is occurring mostly because of send_keys function
 of selenium which sometimes does not input the complete text. The change
 will use Codemirror javascript object to set the text.
 >>> >> >
 >>> >> > I have also added new args flag "--modules" which can be used
 after --pkg where you can test a specific module file under the pkg. This
 is not so useful for build but definitely helpful for the developers.
 >>> >>
 >>> >> One of the most common failures I see is failure to fill in the
 >>> >> details on the Add Server dialogue (it might type half of an
 entry,
 >>> >> then just hang). Should we get rid of all uses of send_keys?
 >>> >
 >>> > Setting the text using javascript executor can be done. send_keys
 simulate an actual person,  so if you try to set a disabled text box using
 send_keys, it won't. Places where disabled fields doesn't matter, send_keys
 can be removed.
 >>>
 >>> Can't we just do something like:
 >>>
 >>> if input.disabled == false:
 >>>   input.value = 'Foo';
 >>> else:
 >>>   raise exception 
 >>
 >> I'll check if this can be done. Will get back.
 >>>
 >>>
 >>> --
 >>> Dave Page
 >>> Blog: http://pgsnake.blogspot.com
 >>> Twitter: @pgsnake
 >>>
 >>> EnterpriseDB UK: http://www.enterprisedb.com
 >>> The Enterprise PostgreSQL Company
 >>
 >>
 >>
 >> --
 >> Thanks and Regards,
 >> Aditya Toshniwal
 >> Software Engineer | EnterpriseDB Software Solutions | Pune
 >> "Don't Complain about Heat, Plant a tree"
 >
 >
 >
 > --
 > Thanks and Regards,
 > Aditya Toshniwal
 > Software Engineer | EnterpriseDB Software Solutions | Pune
 > "Don't Complain about Heat, Plant a tree"



 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

[Aditya Toshniwal]

Urgh. Will try to reproduce and explore possible causes of failure.

On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi 
wrote:

> Hi Aditya
>
> On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> I tried to simulate, but no luck. It works on my system :(
>>
>
>I have tried and Feature test are failing randomly for each run. I have
> verified it on OSX and Ubuntu both.
>
>>
>> On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Aditya
>>>
>>> I have applied your patch but following test cases are failing
>>> consistently:
>>>
>>>- CopySelectedQueryResultsFeatureTest
>>>- QueryToolAutoCompleteFeatureTest
>>>
>>> I have verified your patch on Mac OSX and Ubuntu. Chrome Version
>>> 71.0.3578.98
>>>
>>> On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>


 On Tue, 29 Jan 2019, 19:09 Dave Page >>>
> Akshay, can you look at this please?
>

 Sure.

>
> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
>  wrote:
> >
> > Hi Hackers,
> >
> > Attached is the updated patch. I have changed
> fill_input_by_field_name function to use javascript to set values of text
> boxes and the selector is changed from xpath to CSS with a :not(:disabled)
> clause. With this, test case will fail if tried to set the value of a
> disabled input.
> >
> > Kindly review.
> >
> >
> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
> >>
> >>
> >>
> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page 
> wrote:
> >>>
> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
> >>>  wrote:
> >>> >
> >>> > Hi Dave,
> >>> >
> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page 
> wrote:
> >>> >>
> >>> >> Hi
> >>> >>
> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
> >>> >>  wrote:
> >>> >> >
> >>> >> > Hi Hackers,
> >>> >> >
> >>> >> > Attached is the patch to fix failing SQL editor related
> feature tests.
> >>> >> > The failure is occurring mostly because of send_keys function
> of selenium which sometimes does not input the complete text. The change
> will use Codemirror javascript object to set the text.
> >>> >> >
> >>> >> > I have also added new args flag "--modules" which can be used
> after --pkg where you can test a specific module file under the pkg. This
> is not so useful for build but definitely helpful for the developers.
> >>> >>
> >>> >> One of the most common failures I see is failure to fill in the
> >>> >> details on the Add Server dialogue (it might type half of an
> entry,
> >>> >> then just hang). Should we get rid of all uses of send_keys?
> >>> >
> >>> > Setting the text using javascript executor can be done.
> send_keys simulate an actual person,  so if you try to set a disabled text
> box using send_keys, it won't. Places where disabled fields doesn't 
> matter,
> send_keys can be removed.
> >>>
> >>> Can't we just do something like:
> >>>
> >>> if input.disabled == false:
> >>>   input.value = 'Foo';
> >>> else:
> >>>   raise exception 
> >>
> >> I'll check if this can be done. Will get back.
> >>>
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >>
> >> --
> >> Thanks and Regards,
> >> Aditya Toshniwal
> >> Software Engineer | EnterpriseDB Software Solutions | Pune
> >> "Don't Complain about Heat, Plant a tree"
> >
> >
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > Software Engineer | EnterpriseDB Software Solutions | Pune
> > "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

[Khushboo Vashi]

On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi 
wrote:

> Hi Aditya
>
> On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> I tried to simulate, but no luck. It works on my system :(
>>
>
>I have tried and Feature test are failing randomly for each run. I have
> verified it on OSX and Ubuntu both.
>
>>
>> +1

> On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Aditya
>>>
>>> I have applied your patch but following test cases are failing
>>> consistently:
>>>
>>>- CopySelectedQueryResultsFeatureTest
>>>- QueryToolAutoCompleteFeatureTest
>>>
>>> I have verified your patch on Mac OSX and Ubuntu. Chrome Version
>>> 71.0.3578.98
>>>
>>> On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>


 On Tue, 29 Jan 2019, 19:09 Dave Page >>>
> Akshay, can you look at this please?
>

 Sure.

>
> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
>  wrote:
> >
> > Hi Hackers,
> >
> > Attached is the updated patch. I have changed
> fill_input_by_field_name function to use javascript to set values of text
> boxes and the selector is changed from xpath to CSS with a :not(:disabled)
> clause. With this, test case will fail if tried to set the value of a
> disabled input.
> >
> > Kindly review.
> >
> >
> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
> >>
> >>
> >>
> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page 
> wrote:
> >>>
> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
> >>>  wrote:
> >>> >
> >>> > Hi Dave,
> >>> >
> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page 
> wrote:
> >>> >>
> >>> >> Hi
> >>> >>
> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
> >>> >>  wrote:
> >>> >> >
> >>> >> > Hi Hackers,
> >>> >> >
> >>> >> > Attached is the patch to fix failing SQL editor related
> feature tests.
> >>> >> > The failure is occurring mostly because of send_keys function
> of selenium which sometimes does not input the complete text. The change
> will use Codemirror javascript object to set the text.
> >>> >> >
> >>> >> > I have also added new args flag "--modules" which can be used
> after --pkg where you can test a specific module file under the pkg. This
> is not so useful for build but definitely helpful for the developers.
> >>> >>
> >>> >> One of the most common failures I see is failure to fill in the
> >>> >> details on the Add Server dialogue (it might type half of an
> entry,
> >>> >> then just hang). Should we get rid of all uses of send_keys?
> >>> >
> >>> > Setting the text using javascript executor can be done.
> send_keys simulate an actual person,  so if you try to set a disabled text
> box using send_keys, it won't. Places where disabled fields doesn't 
> matter,
> send_keys can be removed.
> >>>
> >>> Can't we just do something like:
> >>>
> >>> if input.disabled == false:
> >>>   input.value = 'Foo';
> >>> else:
> >>>   raise exception 
> >>
> >> I'll check if this can be done. Will get back.
> >>>
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >>
> >> --
> >> Thanks and Regards,
> >> Aditya Toshniwal
> >> Software Engineer | EnterpriseDB Software Solutions | Pune
> >> "Don't Complain about Heat, Plant a tree"
> >
> >
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > Software Engineer | EnterpriseDB Software Solutions | Pune
> > "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>