[pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-27 Thread Murtuza Zabuawala
Hi,

PFA patch to fix the issue where EPAS DB instance running with
*no-redwood-compat* mode fails to list down functions objects in grant
wizard due to 'char' -> 'int' type cast error.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_3935.diff
Description: Binary data


[pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

2019-01-27 Thread Aditya Toshniwal
Hi Hackers,

Attached is the patch to fix failing SQL editor related feature tests.
The failure is occurring mostly because of send_keys function of selenium
which sometimes does not input the complete text. The change will use
Codemirror javascript object to set the text.

I have also added new args flag "--modules" which can be used after --pkg
where you can test a specific module file under the pkg. This is not so
useful for build but definitely helpful for the developers.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RM3936.patch
Description: Binary data


pgAdmin 4 commit: Ensure that grant wizard should list down functions f

2019-01-27 Thread Akshay Joshi
Ensure that grant wizard should list down functions for EPAS server running 
with no-redwood-compat mode. Fixes #3935

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07f16f40cdb143172e9929ee2bcb753c3844cb2d
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/release_notes_4_2.rst   | 3 ++-
.../grant_wizard/templates/grant_wizard/ppas/11_plus/sql/function.sql  | 2 +-
.../grant_wizard/templates/grant_wizard/ppas/9.1_plus/sql/function.sql | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)



Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions

2019-01-27 Thread Akshay Joshi
Thanks patch applied.

On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue where EPAS DB instance running with
> *no-redwood-compat* mode fails to list down functions objects in grant
> wizard due to 'char' -> 'int' type cast error.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*