date:20190124

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

2019-01-24 Thread Harshal Dhumal

Hi,

Please find attached patch to fix dialog tab navigation in backup and
restore dialog.

Note: If first control in dialog is bootstrap switch then tab and dialog
tab navigation do not work.
This is because bootstrap switch captures all keyboard events and it does
not allow them to propagate /bubble up.
As Khushboo is working on new switch control (RM 3051
) I haven't fix this issue as a
part of this patch.

-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Jan 22, 2019 at 4:29 PM Akshay Joshi 
wrote:

> Thanks patch applied.
>
> On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> The patch looks good to me.
>>
>> On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Khushboo
>>>
>>> Can you please review it.
>>>
>>> On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find attached updated patch.
 In this patch I have fixed two issues:
 i. Dialog tab navigation should work even if focus is on footer buttons
 (Save, Cancel, etc..)
 ii. Focus should be set to first editable element of dialog when tab
 cycle goes through all editable footer buttons.


 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

> Hi,
> This patch fixes Dialog tabset keyboard navigation.
> This regression was caused due to bootstrap 4 changes.
> Also I have added jasmine test cases for the same
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
diff --git a/web/pgadmin/static/js/alertify/dialog_wrapper.js b/web/pgadmin/static/js/alertify/dialog_wrapper.js
index 75452f2..7766380 100644
--- a/web/pgadmin/static/js/alertify/dialog_wrapper.js
+++ b/web/pgadmin/static/js/alertify/dialog_wrapper.js
@@ -8,6 +8,7 @@
 //
 
 import * as commonUtils from '../utils';
+import $ from 'jquery';
 
 export class DialogWrapper {
   constructor(
@@ -53,11 +54,20 @@ export class DialogWrapper {
 return undefined;
   }
 
-  focusOnDialog(dialog) {
-dialog.$el.attr('tabindex', -1);
-this.pgBrowser.keyboardNavigation.getDialogTabNavigator(dialog);
-const container = dialog.$el.find('.tab-content:first > .tab-pane.active:first');
+  focusOnDialog(alertifyDialog) {
+let backform_tab = $(alertifyDialog.elements.body).find('.backform-tab');
+backform_tab.attr('tabindex', -1);
+this.pgBrowser.keyboardNavigation.getDialogTabNavigator($(alertifyDialog.elements.dialog));
+const container = backform_tab.find('.tab-content:first > .tab-pane.active:first');
 commonUtils.findAndSetFocus(container);
+
+$(alertifyDialog.elements.footer).on('keydown', 'button', function(event) {
+  if (event.keyCode == 9 && $(this).nextAll('button:not([disabled])').length == 0) {
+// set focus back to first editable input element of current active tab once we cycle through all enabled buttons.
+commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content div.active'));
+return false;
+  }
+});
   }
 
   isNodeSelected(selectedTreeNode) {
diff --git a/web/pgadmin/static/js/utils.js b/web/pgadmin/static/js/utils.js
index 86727a1..27b999f 100644
--- a/web/pgadmin/static/js/utils.js
+++ b/web/pgadmin/static/js/utils.js
@@ -28,7 +28,7 @@ export function findAndSetFocus(container) {
 
 if (first_el.length == 0) {
   first_el = container
-.find('.pgadmin-controls:first>input:enabled,.CodeMirror-scroll');
+.find('.pgadmin-controls:first input:enabled,.CodeMirror-scroll');
 }
 
 if(first_el.length > 0) {
diff --git a/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js b/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js
index 931d0a0..a9a01e5 100644
--- a/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js
+++ b/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js
@@ -99,7 +99,7 @@ export class BackupDialogWrapper extends DialogWrapper {
 
 this.elements.content.appendChild($container.get(0));
 
-this.focusOnDialog(dialog);
+this.focusOnDialog(this);
 this.setListenersForFilenameChanges();
   }
 
diff --git a/web/pgadmin/tools/restore/static/js/r

pgAdmin 4 commit: Fixed dialog tab navigation for Backup and Restore di

2019-01-24 Thread Akshay Joshi

Fixed dialog tab navigation for Backup and Restore dialog. Fixes regression of 
#3862

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=42c7ae372f7f4f26ba928926f22f1b9f872f15da
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/static/js/alertify/dialog_wrapper.js   | 18 ++
web/pgadmin/static/js/utils.js |  2 +-
.../tools/backup/static/js/backup_dialog_wrapper.js|  2 +-
.../tools/restore/static/js/restore_dialog_wrapper.js  |  2 +-
4 files changed, 17 insertions(+), 7 deletions(-)

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

2019-01-24 Thread Akshay Joshi

Thanks patch applied.

On Thu, Jan 24, 2019 at 4:19 PM Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch to fix dialog tab navigation in backup and
> restore dialog.
>
> Note: If first control in dialog is bootstrap switch then tab and dialog
> tab navigation do not work.
> This is because bootstrap switch captures all keyboard events and it does
> not allow them to propagate /bubble up.
> As Khushboo is working on new switch control (RM 3051
> ) I haven't fix this issue as
> a part of this patch.
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Jan 22, 2019 at 4:29 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks patch applied.
>>
>> On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> The patch looks good to me.
>>>
>>> On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Khushboo

 Can you please review it.

 On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached updated patch.
> In this patch I have fixed two issues:
> i. Dialog tab navigation should work even if focus is on footer
> buttons (Save, Cancel, etc..)
> ii. Focus should be set to first editable element of dialog when tab
> cycle goes through all editable footer buttons.
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>> This patch fixes Dialog tabset keyboard navigation.
>> This regression was caused due to bootstrap 4 changes.
>> Also I have added jasmine test cases for the same
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

 --
 *Akshay Joshi*

 *Sr. Software Architect *



 *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

>>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

2019-01-24 Thread Dave Page

Hi

Could you rebase this please?

Thanks.

On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal
 wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix controls alignment responsiveness to docker size 
> change.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

2019-01-24 Thread Dave Page

Could you rebase this please?

Thanks.

On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal
 wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix correct the buttons for json/jsonb type column 
> data editing.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

2019-01-24 Thread Dave Page

Akshay,

Are you look into this?

Thanks.

On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the revised patch. The previous patch may affect changes at
> unwanted places.
> The revised patch has limited scope and will affect only where required.
>
> Kindly review.
>
>
> On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks patch applied.
>>
>> On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is a tiny patch to fix long name display in dialogs.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

2019-01-24 Thread Aditya Toshniwal

Hi Dave,

This patch is applied.

On Thu, Jan 24, 2019 at 7:36 PM Dave Page  wrote:

> Akshay,
>
> Are you look into this?
>
> Thanks.
>
> On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the revised patch. The previous patch may affect changes at
>> unwanted places.
>> The revised patch has limited scope and will affect only where required.
>>
>> Kindly review.
>>
>>
>> On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks patch applied.
>>>
>>> On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is a tiny patch to fix long name display in dialogs.

 --
 Thanks and Regards,
 Aditya Toshniwal
 Software Engineer | EnterpriseDB Software Solutions | Pune
 "Don't Complain about Heat, Plant a tree"

>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

2019-01-24 Thread Dave Page

On Thu, Jan 24, 2019 at 2:09 PM Aditya Toshniwal
 wrote:
>
> Hi Dave,
>
> This patch is already committed and resolved. 
> https://redmine.postgresql.org/issues/3891

Oh, OK - I don't have a message in-thread saying that :-(

> On Thu, Jan 24, 2019 at 7:34 PM Dave Page  wrote:
>>
>> Could you rebase this please?
>>
>> Thanks.
>>
>> On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal
>>  wrote:
>> >
>> > Hi Hackers,
>> >
>> > Attached is the patch to fix correct the buttons for json/jsonb type 
>> > column data editing.
>> >
>> > Kindly review.
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

2019-01-24 Thread Aditya Toshniwal

Hi Dave,

This patch is already committed and resolved.
 https://redmine.postgresql.org/issues/3891


On Thu, Jan 24, 2019 at 7:34 PM Dave Page  wrote:

> Could you rebase this please?
>
> Thanks.
>
> On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal
>  wrote:
> >
> > Hi Hackers,
> >
> > Attached is the patch to fix correct the buttons for json/jsonb type
> column data editing.
> >
> > Kindly review.
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > Software Engineer | EnterpriseDB Software Solutions | Pune
> > "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

2019-01-24 Thread Dave Page

Oh, and what RM is it related to?

On Thu, Jan 24, 2019 at 2:01 PM Dave Page  wrote:
>
> Hi
>
> Could you rebase this please?
>
> Thanks.
>
> On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal
>  wrote:
> >
> > Hi Hackers,
> >
> > Attached is the patch to fix controls alignment responsiveness to docker 
> > size change.
> >
> > Kindly review.
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > Software Engineer | EnterpriseDB Software Solutions | Pune
> > "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

2019-01-24 Thread Aditya Toshniwal

Hi Dave,

This patch is applied and is a regression of new design changes.
 
https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c


On Thu, Jan 24, 2019 at 7:32 PM Dave Page  wrote:

> Oh, and what RM is it related to?
>
> On Thu, Jan 24, 2019 at 2:01 PM Dave Page  wrote:
> >
> > Hi
> >
> > Could you rebase this please?
> >
> > Thanks.
> >
> > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal
> >  wrote:
> > >
> > > Hi Hackers,
> > >
> > > Attached is the patch to fix controls alignment responsiveness to
> docker size change.
> > >
> > > Kindly review.
> > >
> > > --
> > > Thanks and Regards,
> > > Aditya Toshniwal
> > > Software Engineer | EnterpriseDB Software Solutions | Pune
> > > "Don't Complain about Heat, Plant a tree"
> >
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

2019-01-24 Thread Dave Page

On Thu, Jan 24, 2019 at 2:11 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Dave,
>
> This patch is applied.
>

OK. Akshay, can you please make sure you reply to the thread when you
commit a patch? Otherwise, others (like me) don't necessarily see to remove
it from our TODOs.

Thanks!


>
> On Thu, Jan 24, 2019 at 7:36 PM Dave Page  wrote:
>
>> Akshay,
>>
>> Are you look into this?
>>
>> Thanks.
>>
>> On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the revised patch. The previous patch may affect changes at
>>> unwanted places.
>>> The revised patch has limited scope and will affect only where required.
>>>
>>> Kindly review.
>>>
>>>
>>> On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks patch applied.

 On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is a tiny patch to fix long name display in dialogs.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


 --
 *Akshay Joshi*

 *Sr. Software Architect *



 *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Feature Request: Allow set a suffix/prefix in application_name

2019-01-24 Thread Raphaël Dehousse

Hello everyone,

It would be great to allow to customize the connection's application_name
"pgAdmin 4 - CONN:1175178" to be able to distinguish the different
connections by default.

We are several people connecting to the same db with the same user (in dev)
and it would be good to see for example "pgAdmin 4 - raphael -
CONN:1175178" to identify the connections of "raphael".

WDYT?

Cheers,

Raphaël Dehousse

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

2019-01-24 Thread Dave Page

Hi

On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal
 wrote:
>
> Hi Dave,
>
> This patch is applied and is a regression of new design changes. 
> https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c

Oh. Not sure it worked very well. See the attached screenshot which
shows the messed-up menu bar hiding tabs.

> On Thu, Jan 24, 2019 at 7:32 PM Dave Page  wrote:
>>
>> Oh, and what RM is it related to?
>>
>> On Thu, Jan 24, 2019 at 2:01 PM Dave Page  wrote:
>> >
>> > Hi
>> >
>> > Could you rebase this please?
>> >
>> > Thanks.
>> >
>> > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal
>> >  wrote:
>> > >
>> > > Hi Hackers,
>> > >
>> > > Attached is the patch to fix controls alignment responsiveness to docker 
>> > > size change.
>> > >
>> > > Kindly review.
>> > >
>> > > --
>> > > Thanks and Regards,
>> > > Aditya Toshniwal
>> > > Software Engineer | EnterpriseDB Software Solutions | Pune
>> > > "Don't Complain about Heat, Plant a tree"
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

2019-01-24 Thread Aditya Toshniwal

Oh it was not for mobile view screen. It was for the desktop view.

On Thu, Jan 24, 2019, 19:50 Dave Page  Hi
>
> On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal
>  wrote:
> >
> > Hi Dave,
> >
> > This patch is applied and is a regression of new design changes.
> https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c
>
> Oh. Not sure it worked very well. See the attached screenshot which
> shows the messed-up menu bar hiding tabs.
>
> > On Thu, Jan 24, 2019 at 7:32 PM Dave Page  wrote:
> >>
> >> Oh, and what RM is it related to?
> >>
> >> On Thu, Jan 24, 2019 at 2:01 PM Dave Page  wrote:
> >> >
> >> > Hi
> >> >
> >> > Could you rebase this please?
> >> >
> >> > Thanks.
> >> >
> >> > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal
> >> >  wrote:
> >> > >
> >> > > Hi Hackers,
> >> > >
> >> > > Attached is the patch to fix controls alignment responsiveness to
> docker size change.
> >> > >
> >> > > Kindly review.
> >> > >
> >> > > --
> >> > > Thanks and Regards,
> >> > > Aditya Toshniwal
> >> > > Software Engineer | EnterpriseDB Software Solutions | Pune
> >> > > "Don't Complain about Heat, Plant a tree"
> >> >
> >> >
> >> >
> >> > --
> >> > Dave Page
> >> > Blog: http://pgsnake.blogspot.com
> >> > Twitter: @pgsnake
> >> >
> >> > EnterpriseDB UK: http://www.enterprisedb.com
> >> > The Enterprise PostgreSQL Company
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > Software Engineer | EnterpriseDB Software Solutions | Pune
> > "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

2019-01-24 Thread Dave Page

Oh, OK - well please log a ticket and fix that too then :-)

On Thu, Jan 24, 2019 at 2:48 PM Aditya Toshniwal
 wrote:
>
> Oh it was not for mobile view screen. It was for the desktop view.
>
> On Thu, Jan 24, 2019, 19:50 Dave Page >
>> Hi
>>
>> On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal
>>  wrote:
>> >
>> > Hi Dave,
>> >
>> > This patch is applied and is a regression of new design changes. 
>> > https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c
>>
>> Oh. Not sure it worked very well. See the attached screenshot which
>> shows the messed-up menu bar hiding tabs.
>>
>> > On Thu, Jan 24, 2019 at 7:32 PM Dave Page  wrote:
>> >>
>> >> Oh, and what RM is it related to?
>> >>
>> >> On Thu, Jan 24, 2019 at 2:01 PM Dave Page  wrote:
>> >> >
>> >> > Hi
>> >> >
>> >> > Could you rebase this please?
>> >> >
>> >> > Thanks.
>> >> >
>> >> > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal
>> >> >  wrote:
>> >> > >
>> >> > > Hi Hackers,
>> >> > >
>> >> > > Attached is the patch to fix controls alignment responsiveness to 
>> >> > > docker size change.
>> >> > >
>> >> > > Kindly review.
>> >> > >
>> >> > > --
>> >> > > Thanks and Regards,
>> >> > > Aditya Toshniwal
>> >> > > Software Engineer | EnterpriseDB Software Solutions | Pune
>> >> > > "Don't Complain about Heat, Plant a tree"
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Dave Page
>> >> > Blog: http://pgsnake.blogspot.com
>> >> > Twitter: @pgsnake
>> >> >
>> >> > EnterpriseDB UK: http://www.enterprisedb.com
>> >> > The Enterprise PostgreSQL Company
>> >>
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Ensure object names in external process dialogues are

2019-01-24 Thread Dave Page

Ensure object names in external process dialogues are properly escaped. Fixes 
#3872

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9fc9fdc4db76edf75f360280c090d34ffb69f83
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/release_notes_4_2.rst   |  1 +
web/pgadmin/browser/static/js/error.js |  9 ++-
.../pg_utilities_backup_restore_test.py| 79 +++---
.../feature_tests/pg_utilities_maintenance_test.py | 27 +++-
web/pgadmin/misc/bgprocess/static/js/bgprocess.js  |  9 ++-
web/pgadmin/tools/backup/__init__.py   | 30 
web/pgadmin/tools/import_export/__init__.py|  7 +-
web/pgadmin/tools/restore/__init__.py  |  7 +-
web/pgadmin/utils/driver/psycopg2/connection.py|  8 +--
9 files changed, 121 insertions(+), 56 deletions(-)

pgAdmin 4 commit: Fix alignment of help messages in properties panels.

2019-01-24 Thread Dave Page

Fix alignment of help messages in properties panels. Fixes #3929

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d7eaa63c44e0f34d46a36a9029169964f36ae37
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/release_notes_4_2.rst  | 3 ++-
web/pgadmin/static/js/backform.pgadmin.js | 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

2019-01-24 Thread Akshay Joshi

On Thu, 24 Jan 2019, 19:44 Dave Page 
>
> On Thu, Jan 24, 2019 at 2:11 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> This patch is applied.
>>
>
> OK. Akshay, can you please make sure you reply to the thread when you
> commit a patch? Otherwise, others (like me) don't necessarily see to remove
> it from our TODOs.
>

Sure Dave. Generally i did that don't know how i forgot this.

>
> Thanks!
>
>
>>
>> On Thu, Jan 24, 2019 at 7:36 PM Dave Page  wrote:
>>
>>> Akshay,
>>>
>>> Are you look into this?
>>>
>>> Thanks.
>>>
>>> On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the revised patch. The previous patch may affect changes at
 unwanted places.
 The revised patch has limited scope and will affect only where required.

 Kindly review.


 On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks patch applied.
>
> On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is a tiny patch to fix long name display in dialogs.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


 --
 Thanks and Regards,
 Aditya Toshniwal
 Software Engineer | EnterpriseDB Software Solutions | Pune
 "Don't Complain about Heat, Plant a tree"

>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

pgAdmin 4 commit: Fixed dialog tab navigation for Backup and Restore di

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

Feature Request: Allow set a suffix/prefix in application_name

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

pgAdmin 4 commit: Ensure object names in external process dialogues are

pgAdmin 4 commit: Fix alignment of help messages in properties panels.

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

19 matches

Site Navigation

Mail list logo

Footer information