Re: [pgAdmin4][RM3837] Trigger when option syntax error
Thanks patch applied. On Wed, Jan 16, 2019 at 1:17 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Kindly ignore the previous patch, some typo mistake in filename. Apologies. > Attached is the updated patch. > > On Wed, Jan 16, 2019 at 11:19 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the updated patch. Kindly review. >> >> On Tue, Jan 15, 2019 at 6:05 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Facing issue when tested on EPAS 10, please verify it on EPAS. >>> >>> On Mon, Jan 14, 2019 at 6:26 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch to fix the syntax error if when clause is given. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed SQL for when clause while creating Trigger. Fix
Fixed SQL for when clause while creating Trigger. Fixes #3837 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6bbcaf6b27682f37e13d653c95a92f2ba7c646be Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_2.rst | 3 ++- .../schemas/tables/templates/trigger/sql/10_plus/create.sql | 2 +- .../tables/templates/trigger/sql/10_plus/properties.sql | 3 +-- .../tables/templates/trigger/sql/9.1_plus/properties.sql | 3 +-- .../schemas/tables/templates/trigger/sql/default/create.sql | 4 ++-- .../databases/schemas/tables/triggers/static/js/trigger.js| 11 +-- web/pgadmin/static/scss/_pgadmin.style.scss | 3 +++ 7 files changed, 15 insertions(+), 14 deletions(-)
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi wrote: > Thanks patch applied without Tree Changes. > > On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for further design improvements: >> - Process watcher made fixed width with header changes, time details >> rounded to 2 decimals >> - Query history will show "No query history" if no query fired. Query >> editor default size increased. >> - Tree improvements - right bold border removed completely. Now click >> anywhere on a tree item to perform actions. Please note, single click on >> the tiny tree arrow button will not work with this. Clicking anywhere is >> more useful than this. >> > @Dave Should we proceed with this behaviour, I haven't commit it. > I like the blue bit, so that should come back. I would say that a single-click on the arrow should open/close the node, whilst a double-click on the icon or label should open/close it. > - Fixed a bug where New folder create button not working when in List mode >> and No files/folder present. >> - Other minor improvements. >> >> Kindly review. >> >> On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for few more changes: >>> - New Folder button was not working in file dialogue. Fixed that. >>> - Color, icon changes in file dialogue >>> - Also replaced the splash screen image (which is used on main dashboard >>> also). It works fine on dashboard. However, I'm not sure of the splash >>> screen as the new image is SVG and older was PNG. I have made changes for >>> that in runtime code but I'm not able to test (evnvironment issue) runtime >>> code :(. It would be helpful if someone else can try it once. >>> >>> Kindly review. >>> >>> >>> On Mon, Jan 7, 2019 at 2:25 PM Dave Page wrote: >>> Thanks - applied! On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is the patch to incorporate the changes discussed in trailing mail(s). > > Kindly review. > > On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote: >> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal >> wrote: >> > >> > Hi, >> > >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: >> >> >> >> Hi >> >> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: >> >>> >> >>> Hi Dave, >> >>> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: >> >> >> A few other things that I noticed (or have been bugging me): >> >> - The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px and setting the font-weight to normal on the menu options (but not the product name) seems much better to me (and adjusting everything else as required of course). >> >>> >> >>> Giving too much space for the navbar will reduce the usable space for other things. It is good enough(32) to be used easily, and is equal to all the other headers in app (including tabs) giving a feel of native desktop application. You'll find even smaller menu heights in native desktop application. We can make font weight to normal and may be slightly increase horizontal spacing between the menu links. >> >> >> >> >> >> 8 pixels isn't going to make a noticeable difference to the workspace for users, and would leave the bar smaller than the 50px it's been for the last couple of years (iirc). I think it needs it to avoid looking cramped - please make the change. >> > >> > Will do. >> > One more doubt regarding bold headers, should I remove bold headers in dashboard graph header, subnode headers (eg.table->columns), properties tab accrordian headers ? >> >> No, please don't. I left them bold and the styling seemed like it >> worked. We can tweak again if others disagree later. >> >> Thanks! >> >> BTW - Chrome 71 shows the offset headers in the file dialogue as well. >> >> >> - In the file dialogue, the column headers don't line up with the columns in the rows. >> >>> >> >>> I could not see this on my machine (screenshot attached). Could you please share the screenshot. >> >> >> >> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. >> >> >> >> -- >> >> Dave Page >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> >> >> >> EnterpriseDB UK: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > >> > >> > >> > -- >> > Thanks and Regards, >> > Aditya Toshniwal >> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Compla
[pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables
Hi, Please find the attached patch to fix the RM 3664 - Statistic panel hangs when 1000+ tables The statistics tab hangs with more rows. So, now the rows will be pushed in the backgrid collection in bunches on scroll event to fix this issue. Thanks, Khushboo RM_3664.patch Description: Binary data
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Hi Hackers, Attached is the small patch (and probably the final for this mail chain) to accommodate the changes suggested in previous mail. Kindly review. On Wed, Jan 16, 2019 at 8:30 PM Dave Page wrote: > > > On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks patch applied without Tree Changes. >> >> On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal > enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for further design improvements: >>> - Process watcher made fixed width with header changes, time details >>> rounded to 2 decimals >>> - Query history will show "No query history" if no query fired. Query >>> editor default size increased. >>> - Tree improvements - right bold border removed completely. Now click >>> anywhere on a tree item to perform actions. Please note, single click on >>> the tiny tree arrow button will not work with this. Clicking anywhere is >>> more useful than this. >>> >> @Dave Should we proceed with this behaviour, I haven't commit it. >> > > I like the blue bit, so that should come back. > > I would say that a single-click on the arrow should open/close the node, > whilst a double-click on the icon or label should open/close it. > > >> - Fixed a bug where New folder create button not working when in List >>> mode and No files/folder present. >>> - Other minor improvements. >>> >>> Kindly review. >>> >>> On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch for few more changes: - New Folder button was not working in file dialogue. Fixed that. - Color, icon changes in file dialogue - Also replaced the splash screen image (which is used on main dashboard also). It works fine on dashboard. However, I'm not sure of the splash screen as the new image is SVG and older was PNG. I have made changes for that in runtime code but I'm not able to test (evnvironment issue) runtime code :(. It would be helpful if someone else can try it once. Kindly review. On Mon, Jan 7, 2019 at 2:25 PM Dave Page wrote: > Thanks - applied! > > On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal > wrote: > > > > Hi Hackers, > > > > Attached is the patch to incorporate the changes discussed in > trailing mail(s). > > > > Kindly review. > > > > On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote: > >> > >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal > >> wrote: > >> > > >> > Hi, > >> > > >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page > wrote: > >> >> > >> >> Hi > >> >> > >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >>> > >> >>> Hi Dave, > >> >>> > >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page > wrote: > >> > >> > >> A few other things that I noticed (or have been bugging me): > >> > >> - The menu bar seems a little cramped. Taking pg-navbar from > 32 to 40px and setting the font-weight to normal on the menu options (but > not the product name) seems much better to me (and adjusting everything > else as required of course). > >> >>> > >> >>> Giving too much space for the navbar will reduce the usable > space for other things. It is good enough(32) to be used easily, and is > equal to all the other headers in app (including tabs) giving a feel of > native desktop application. You'll find even smaller menu heights in > native > desktop application. We can make font weight to normal and may be slightly > increase horizontal spacing between the menu links. > >> >> > >> >> > >> >> 8 pixels isn't going to make a noticeable difference to the > workspace for users, and would leave the bar smaller than the 50px it's > been for the last couple of years (iirc). I think it needs it to avoid > looking cramped - please make the change. > >> > > >> > Will do. > >> > One more doubt regarding bold headers, should I remove bold > headers in dashboard graph header, subnode headers (eg.table->columns), > properties tab accrordian headers ? > >> > >> No, please don't. I left them bold and the styling seemed like it > >> worked. We can tweak again if others disagree later. > >> > >> Thanks! > >> > >> BTW - Chrome 71 shows the offset headers in the file dialogue as > well. > >> > >> > >> - In the file dialogue, the column headers don't line up with > the columns in the rows. > >> >>> > >> >>> I could not see this on my machine (screenshot attached). Could > you please share the screenshot. > >> >> > >> >> > >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. > >> >> > >> >> -- >
pgAdmin 4 commit: 1) Proper SQL should be generated when creating/chang
1) Proper SQL should be generated when creating/changing column with custom type argument. Fixes #3838 2) Proper SQL should be generated when create procedure with custom type arguments. Fixes #3846 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c1aba3e055a040031a413f04ff4b30fac6abd861 Modified Files -- docs/en_US/release_notes_4_2.rst | 4 +++- .../foreign_tables/templates/foreign_tables/sql/9.2_plus/create.sql | 2 +- .../foreign_tables/templates/foreign_tables/sql/9.2_plus/update.sql | 4 ++-- .../foreign_tables/templates/foreign_tables/sql/9.5_plus/create.sql | 2 +- .../foreign_tables/templates/foreign_tables/sql/9.5_plus/update.sql | 4 ++-- .../foreign_tables/templates/foreign_tables/sql/default/create.sql| 2 +- .../foreign_tables/templates/foreign_tables/sql/default/update.sql| 4 ++-- .../schemas/functions/templates/function/gpdb/sql/default/create.sql | 2 +- .../schemas/functions/templates/function/gpdb/sql/default/update.sql | 2 +- .../schemas/functions/templates/function/pg/sql/11_plus/create.sql| 2 +- .../schemas/functions/templates/function/pg/sql/11_plus/update.sql| 2 +- .../schemas/functions/templates/function/pg/sql/9.2_plus/create.sql | 2 +- .../schemas/functions/templates/function/pg/sql/9.2_plus/update.sql | 2 +- .../schemas/functions/templates/function/pg/sql/9.5_plus/create.sql | 2 +- .../schemas/functions/templates/function/pg/sql/9.5_plus/update.sql | 2 +- .../schemas/functions/templates/function/pg/sql/9.6_plus/create.sql | 2 +- .../schemas/functions/templates/function/pg/sql/9.6_plus/update.sql | 2 +- .../schemas/functions/templates/function/pg/sql/default/create.sql| 2 +- .../schemas/functions/templates/function/pg/sql/default/update.sql| 2 +- .../schemas/functions/templates/function/ppas/sql/9.2_plus/create.sql | 2 +- .../schemas/functions/templates/function/ppas/sql/9.2_plus/update.sql | 2 +- .../schemas/functions/templates/function/ppas/sql/9.5_plus/create.sql | 2 +- .../schemas/functions/templates/function/ppas/sql/9.5_plus/update.sql | 2 +- .../schemas/functions/templates/function/ppas/sql/9.6_plus/create.sql | 2 +- .../schemas/functions/templates/function/ppas/sql/9.6_plus/update.sql | 2 +- .../schemas/functions/templates/function/ppas/sql/default/create.sql | 2 +- .../schemas/functions/templates/procedure/pg/sql/11_plus/create.sql | 2 +- .../schemas/functions/templates/procedure/pg/sql/11_plus/update.sql | 2 +- .../schemas/functions/templates/procedure/ppas/sql/11_plus/create.sql | 2 +- .../schemas/functions/templates/procedure/ppas/sql/11_plus/update.sql | 2 +- .../functions/templates/procedure/ppas/sql/9.2_plus/create.sql| 2 +- .../functions/templates/procedure/ppas/sql/9.2_plus/update.sql| 2 +- .../functions/templates/procedure/ppas/sql/9.5_plus/create.sql| 2 +- .../functions/templates/procedure/ppas/sql/9.5_plus/update.sql| 2 +- .../functions/templates/procedure/ppas/sql/9.6_plus/create.sql| 2 +- .../functions/templates/procedure/ppas/sql/9.6_plus/update.sql| 2 +- .../schemas/functions/templates/procedure/ppas/sql/default/create.sql | 2 +- .../schemas/functions/templates/procedure/ppas/sql/default/update.sql | 2 +- .../types/templates/type/macros/get_full_type_sql_format.macros | 2 +- 39 files changed, 44 insertions(+), 42 deletions(-)
pgAdmin 4 commit: Add right border on selected tree item.
Add right border on selected tree item. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f779378e8a1089e33697fcf716c1c5f95d766139 Author: Aditya Toshniwal Modified Files -- .../databases/schemas/functions/static/js/procedure.js| 1 + web/pgadmin/preferences/static/js/preferences.js | 15 ++- web/pgadmin/static/scss/_aci_tree.overrides.scss | 6 ++ 3 files changed, 9 insertions(+), 13 deletions(-)
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Thanks patch applied. On Thu, Jan 17, 2019 at 11:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the small patch (and probably the final for this mail chain) > to accommodate the changes suggested in previous mail. > > Kindly review. > > On Wed, Jan 16, 2019 at 8:30 PM Dave Page > wrote: > >> >> >> On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks patch applied without Tree Changes. >>> >>> On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal >> enterprisedb.com> wrote: >>> Hi Hackers, Attached is the patch for further design improvements: - Process watcher made fixed width with header changes, time details rounded to 2 decimals - Query history will show "No query history" if no query fired. Query editor default size increased. - Tree improvements - right bold border removed completely. Now click anywhere on a tree item to perform actions. Please note, single click on the tiny tree arrow button will not work with this. Clicking anywhere is more useful than this. >>> @Dave Should we proceed with this behaviour, I haven't commit it. >>> >> >> I like the blue bit, so that should come back. >> >> I would say that a single-click on the arrow should open/close the node, >> whilst a double-click on the icon or label should open/close it. >> >> >>> - Fixed a bug where New folder create button not working when in List mode and No files/folder present. - Other minor improvements. Kindly review. On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for few more changes: > - New Folder button was not working in file dialogue. Fixed that. > - Color, icon changes in file dialogue > - Also replaced the splash screen image (which is used on main > dashboard also). It works fine on dashboard. However, I'm not sure of the > splash screen as the new image is SVG and older was PNG. I have made > changes for that in runtime code but I'm not able to test (evnvironment > issue) runtime code :(. It would be helpful if someone else can try it > once. > > Kindly review. > > > On Mon, Jan 7, 2019 at 2:25 PM Dave Page wrote: > >> Thanks - applied! >> >> On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal >> wrote: >> > >> > Hi Hackers, >> > >> > Attached is the patch to incorporate the changes discussed in >> trailing mail(s). >> > >> > Kindly review. >> > >> > On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote: >> >> >> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal >> >> wrote: >> >> > >> >> > Hi, >> >> > >> >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page >> wrote: >> >> >> >> >> >> Hi >> >> >> >> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >> >>> >> >> >>> Hi Dave, >> >> >>> >> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page >> wrote: >> >> >> >> >> >> A few other things that I noticed (or have been bugging me): >> >> >> >> - The menu bar seems a little cramped. Taking pg-navbar from >> 32 to 40px and setting the font-weight to normal on the menu options (but >> not the product name) seems much better to me (and adjusting everything >> else as required of course). >> >> >>> >> >> >>> Giving too much space for the navbar will reduce the usable >> space for other things. It is good enough(32) to be used easily, and is >> equal to all the other headers in app (including tabs) giving a feel of >> native desktop application. You'll find even smaller menu heights in >> native >> desktop application. We can make font weight to normal and may be >> slightly >> increase horizontal spacing between the menu links. >> >> >> >> >> >> >> >> >> 8 pixels isn't going to make a noticeable difference to the >> workspace for users, and would leave the bar smaller than the 50px it's >> been for the last couple of years (iirc). I think it needs it to avoid >> looking cramped - please make the change. >> >> > >> >> > Will do. >> >> > One more doubt regarding bold headers, should I remove bold >> headers in dashboard graph header, subnode headers (eg.table->columns), >> properties tab accrordian headers ? >> >> >> >> No, please don't. I left them bold and the styling seemed like it >> >> worked. We can tweak again if others disagree later. >> >> >> >> Thanks! >> >> >> >> BTW - Chrome 71 shows the offset headers in the file dialogue as >> well. >> >> >> >> >> >> - In the file dialogue, the column headers don't line up with >> the columns
