date:20190115

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-15 Thread Aditya Toshniwal

Hi Hackers,

Please find the updated, rebased patch.
Kindly review.

On Mon, Jan 14, 2019 at 10:54 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch for further design improvements:
> - Process watcher made fixed width with header changes, time details
> rounded to 2 decimals
> - Query history will show "No query history" if no query fired. Query
> editor default size increased.
> - Tree improvements - right bold border removed completely. Now click
> anywhere on a tree item to perform actions. Please note, single click on
> the tiny tree arrow button will not work with this. Clicking anywhere is
> more useful than this.
> - Fixed a bug where New folder create button not working when in List mode
> and No files/folder present.
> - Other minor improvements.
>
> Kindly review.
>
> On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for few more changes:
>> - New Folder button was not working in file dialogue. Fixed that.
>> - Color, icon changes in file dialogue
>> - Also replaced the splash screen image (which is used on main dashboard
>> also). It works fine on dashboard. However, I'm not sure of the splash
>> screen as the new image is SVG and older was PNG. I have made changes for
>> that in runtime code but I'm not able to test (evnvironment issue) runtime
>> code :(. It would be helpful if someone else can try it once.
>>
>> Kindly review.
>>
>>
>> On Mon, Jan 7, 2019 at 2:25 PM Dave Page  wrote:
>>
>>> Thanks - applied!
>>>
>>> On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal
>>>  wrote:
>>> >
>>> > Hi Hackers,
>>> >
>>> > Attached is the patch to incorporate the changes discussed in trailing
>>> mail(s).
>>> >
>>> > Kindly review.
>>> >
>>> > On Fri, Jan 4, 2019 at 3:31 PM Dave Page  wrote:
>>> >>
>>> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal
>>> >>  wrote:
>>> >> >
>>> >> > Hi,
>>> >> >
>>> >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page  wrote:
>>> >> >>
>>> >> >> Hi
>>> >> >>
>>> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>> >> >>>
>>> >> >>> Hi Dave,
>>> >> >>>
>>> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page 
>>> wrote:
>>> >> 
>>> >> 
>>> >>  A few other things that I noticed (or have been bugging me):
>>> >> 
>>> >>  - The menu bar seems a little cramped. Taking pg-navbar from 32
>>> to 40px and setting the font-weight to normal on the menu options (but not
>>> the product name) seems much better to me (and adjusting everything else as
>>> required of course).
>>> >> >>>
>>> >> >>> Giving too much space for the navbar will reduce the usable space
>>> for other things. It is good enough(32) to be used easily, and is equal to
>>> all the other headers in app (including tabs) giving a feel of native
>>> desktop application. You'll find even smaller menu heights in native
>>> desktop application. We can make font weight to normal and may be slightly
>>> increase horizontal spacing between the menu links.
>>> >> >>
>>> >> >>
>>> >> >> 8 pixels isn't going to make a noticeable difference to the
>>> workspace for users, and would leave the bar smaller than the 50px it's
>>> been for the last couple of years (iirc). I think it needs it to avoid
>>> looking cramped - please make the change.
>>> >> >
>>> >> > Will do.
>>> >> > One more doubt regarding bold headers, should I remove bold headers
>>> in dashboard graph header, subnode headers (eg.table->columns), properties
>>> tab accrordian headers ?
>>> >>
>>> >> No, please don't. I left them bold and the styling seemed like it
>>> >> worked. We can tweak again if others disagree later.
>>> >>
>>> >> Thanks!
>>> >>
>>> >> BTW - Chrome 71 shows the offset headers in the file dialogue as well.
>>> >>
>>> >> 
>>> >>  - In the file dialogue, the column headers don't line up with
>>> the columns in the rows.
>>> >> >>>
>>> >> >>> I could not see this on my machine (screenshot attached). Could
>>> you please share the screenshot.
>>> >> >>
>>> >> >>
>>> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS.
>>> >> >>
>>> >> >> --
>>> >> >> Dave Page
>>> >> >> Blog: http://pgsnake.blogspot.com
>>> >> >> Twitter: @pgsnake
>>> >> >>
>>> >> >> EnterpriseDB UK: http://www.enterprisedb.com
>>> >> >> The Enterprise PostgreSQL Company
>>> >> >
>>> >> >
>>> >> >
>>> >> > --
>>> >> > Thanks and Regards,
>>> >> > Aditya Toshniwal
>>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>> >> > "Don't Complain about Heat, Plant a tree"
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Dave Page
>>> >> Blog: http://pgsnake.blogspot.com
>>> >> Twitter: @pgsnake
>>> >>
>>> >> EnterpriseDB UK: http://www.enterprisedb.com
>>> >> The Enterprise PostgreSQL Company
>>> >
>>> >
>>> >
>>> > --
>>> > Thanks and Regards,
>>> > Aditya Toshniwal
>>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>> > "Don't Complain about Hea

pgAdmin 4 v4.1 released

2019-01-15 Thread Akshay Joshi

The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.1.
This release of pgAdmin 4 includes over 7 bug fixes. For
more details please see the release notes at:

https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_1.html.

pgAdmin is the leading Open Source graphical management tool for
PostgreSQL. For more information, please see:

https://www.pgadmin.org/

Notable changes in this release include:

* Ensure that last row of table data should be visible and user will be
able to add new row.
* Fix ordering of VACUUM options which changed in PG11.
* Ensure the context menu works after a server is renamed.
* Make the browser more robust in the face of multibyte characters in
SQL_ASCII databases.

Builds for Windows and macOS are available now, along with a Python Wheel,
Docker Container and source code tarball from:

https://www.pgadmin.org/download/

RPM and DEB packages are expected to be available on the postgresql.org
repositories within the next few days.

--
Akshay Joshi
pgAdmin Project

pgAdmin 4 commit: Tag REL-4_1 has been created.

2019-01-15 Thread Akshay Joshi

Tag REL-4_1 has been created.
View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_1

Log Message
---
Tag v4.1

Re: [pgAdmin4][RM3837] Trigger when option syntax error

2019-01-15 Thread Akshay Joshi

Hi Aditya

Facing issue when tested on EPAS 10, please verify it on EPAS.

On Mon, Jan 14, 2019 at 6:26 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the syntax error if when clause is given.
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Ensure long string should be wrap in alertify dialogs

2019-01-15 Thread Akshay Joshi

Ensure long string should be wrap in alertify dialogs. Fixes #3695

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b0c81126c3246f93a68c72eb6e29dd111548b33
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_2.rst | 17 +
web/pgadmin/static/scss/_alertify.overrides.scss |  4 +++-
2 files changed, 20 insertions(+), 1 deletion(-)

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

2019-01-15 Thread Akshay Joshi

Thanks patch applied.

On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is a tiny patch to fix long name display in dialogs.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Build failed in Jenkins: pgadmin4-master-python35 #856

2019-01-15 Thread pgAdmin 4 Jenkins

See 


Changes:

[akshay.joshi] Ensure long string should be wrap in alertify dialogs. Fixes 
#3695

--
[...truncated 1019.65 KB...]
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 688 of 763 SUCCESS (0 secs 
/ 9.697 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 689 of 763 SUCCESS (0 secs 
/ 9.7 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 690 of 763 SUCCESS (0 secs 
/ 9.722 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 691 of 763 SUCCESS (0 secs 
/ 9.724 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 692 of 763 SUCCESS (0 secs 
/ 9.728 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 693 of 763 SUCCESS (0 secs 
/ 9.73 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 694 of 763 SUCCESS (0 secs 
/ 9.732 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 695 of 763 SUCCESS (0 secs 
/ 9.734 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 696 of 763 SUCCESS (0 secs 
/ 9.736 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 697 of 763 SUCCESS (0 secs 
/ 9.739 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 698 of 763 SUCCESS (0 secs 
/ 9.742 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 699 of 763 SUCCESS (0 secs 
/ 9.751 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 700 of 763 SUCCESS (0 secs 
/ 9.752 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 701 of 763 SUCCESS (0 secs 
/ 9.753 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 702 of 763 SUCCESS (0 secs 
/ 9.756 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 703 of 763 SUCCESS (0 secs 
/ 9.758 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 704 of 763 SUCCESS (0 secs 
/ 9.76 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 705 of 763 SUCCESS (0 secs 
/ 9.763 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 706 of 763 SUCCESS (0 secs 
/ 9.765 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 707 of 763 SUCCESS (0 secs 
/ 9.766 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 708 of 763 SUCCESS (0 secs 
/ 9.767 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 709 of 763 SUCCESS (0 secs 
/ 9.769 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 710 of 763 SUCCESS (0 secs 
/ 9.77 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 711 of 763 SUCCESS (0 secs 
/ 9.771 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 712 of 763 SUCCESS (0 secs 
/ 9.773 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 713 of 763 SUCCESS (0 secs 
/ 9.774 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 714 of 763 SUCCESS (0 secs 
/ 9.797 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 715 of 763 SUCCESS (0 secs 
/ 9.8 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 716 of 763 SUCCESS (0 secs 
/ 9.822 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 717 of 763 SUCCESS (0 secs 
/ 9.824 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 718 of 763 SUCCESS (0 secs 
/ 9.826 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 719 of 763 SUCCESS (0 secs 
/ 9.827 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 720 of 763 SUCCESS (0 secs 
/ 9.832 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 721 of 763 SUCCESS (0 secs 
/ 9.834 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 722 of 763 SUCCESS (0 secs 
/ 9.836 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 723 of 763 SUCCESS (0 secs 
/ 9.837 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 724 of 763 SUCCESS (0 secs 
/ 9.838 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 725 of 763 SUCCESS (0 secs 
/ 9.839 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 726 of 763 SUCCESS (0 secs 
/ 9.84 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 727 of 763 SUCCESS (0 secs 
/ 9.842 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 728 of 763 SUCCESS (0 secs 
/ 9.843 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 729 of 763 SUCCESS (0 secs 
/ 9.846 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 730 of 763 SUCCESS (0 secs 
/ 9.848 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 731 of 763 SUCCESS (0 secs 
/ 9.849 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 732 of 763 SUCCESS (0 secs 
/ 9.852 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 733 of 763 SUCCESS (0 secs 
/ 9.854 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 734 of 763 SUCCESS (0 secs 
/ 9.855 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 735 of 763 SUCCESS (0 secs 
/ 9.857 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 736 of 763 SUCCESS (0 secs 
/ 9.86 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 737 of 763 SUCCESS (0 secs 
/ 9.861

pgAdmin 4 commit: Proper error should be thrown when server group is cr

2019-01-15 Thread Akshay Joshi

Proper error should be thrown when server group is created with existing name. 
Fixes #3693

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a359d9d774c8170d5e128fd05825e977409313f
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes.rst  | 1 +
docs/en_US/release_notes_4_2.rst  | 1 +
web/pgadmin/browser/server_groups/__init__.py | 5 +
3 files changed, 7 insertions(+)

Re: [pgAdmin4][RM3693] Message "Error saving properties Click on Detail" displayed if user create server group with same name

2019-01-15 Thread Akshay Joshi

Thanks patch applied.

On Tue, Jan 15, 2019 at 11:20 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix back end exception which is common and
> mentioned in SQLAlchemy FAQ -
> https://docs.sqlalchemy.org/en/latest/faq/sessions.html#this-session-s-transaction-has-been-rolled-back-due-to-a-previous-exception-during-flush-or-similar
> The fix is as per the FAQ answer.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Build failed in Jenkins: pgadmin4-master-python27 #869

2019-01-15 Thread pgAdmin 4 Jenkins

See 


Changes:

[akshay.joshi] Ensure long string should be wrap in alertify dialogs. Fixes 
#3695

--
[...truncated 1021.82 KB...]
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 690 of 763 SUCCESS (0 secs 
/ 9.691 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 691 of 763 SUCCESS (0 secs 
/ 9.694 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 692 of 763 SUCCESS (0 secs 
/ 9.699 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 693 of 763 SUCCESS (0 secs 
/ 9.7 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 694 of 763 SUCCESS (0 secs 
/ 9.702 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 695 of 763 SUCCESS (0 secs 
/ 9.704 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 696 of 763 SUCCESS (0 secs 
/ 9.705 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 697 of 763 SUCCESS (0 secs 
/ 9.707 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 698 of 763 SUCCESS (0 secs 
/ 9.712 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 699 of 763 SUCCESS (0 secs 
/ 9.713 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 700 of 763 SUCCESS (0 secs 
/ 9.714 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 701 of 763 SUCCESS (0 secs 
/ 9.716 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 702 of 763 SUCCESS (0 secs 
/ 9.717 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 703 of 763 SUCCESS (0 secs 
/ 9.719 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 704 of 763 SUCCESS (0 secs 
/ 9.721 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 705 of 763 SUCCESS (0 secs 
/ 9.725 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 706 of 763 SUCCESS (0 secs 
/ 9.726 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 707 of 763 SUCCESS (0 secs 
/ 9.729 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 708 of 763 SUCCESS (0 secs 
/ 9.731 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 709 of 763 SUCCESS (0 secs 
/ 9.732 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 710 of 763 SUCCESS (0 secs 
/ 9.733 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 711 of 763 SUCCESS (0 secs 
/ 9.737 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 712 of 763 SUCCESS (0 secs 
/ 9.74 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 713 of 763 SUCCESS (0 secs 
/ 9.742 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 714 of 763 SUCCESS (0 secs 
/ 9.764 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 715 of 763 SUCCESS (0 secs 
/ 9.767 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 716 of 763 SUCCESS (0 secs 
/ 9.79 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 717 of 763 SUCCESS (0 secs 
/ 9.792 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 718 of 763 SUCCESS (0 secs 
/ 9.793 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 719 of 763 SUCCESS (0 secs 
/ 9.795 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 720 of 763 SUCCESS (0 secs 
/ 9.797 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 721 of 763 SUCCESS (0 secs 
/ 9.801 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 722 of 763 SUCCESS (0 secs 
/ 9.802 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 723 of 763 SUCCESS (0 secs 
/ 9.804 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 724 of 763 SUCCESS (0 secs 
/ 9.806 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 725 of 763 SUCCESS (0 secs 
/ 9.807 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 726 of 763 SUCCESS (0 secs 
/ 9.808 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 727 of 763 SUCCESS (0 secs 
/ 9.808 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 728 of 763 SUCCESS (0 secs 
/ 9.812 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 729 of 763 SUCCESS (0 secs 
/ 9.82 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 730 of 763 SUCCESS (0 secs 
/ 9.822 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 731 of 763 SUCCESS (0 secs 
/ 9.823 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 732 of 763 SUCCESS (0 secs 
/ 9.824 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 733 of 763 SUCCESS (0 secs 
/ 9.829 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 734 of 763 SUCCESS (0 secs 
/ 9.83 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 735 of 763 SUCCESS (0 secs 
/ 9.833 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 736 of 763 SUCCESS (0 secs 
/ 9.834 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 737 of 763 SUCCESS (0 secs 
/ 9.835 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 738 of 763 SUCCESS (0 secs 
/ 9.837 secs)
[1A[2KHeadlessChrome 0.0.0 (Linux 0.0.0): Executed 739 of 763 SUCCESS (0 secs 
/ 9.

[pgAdmin4][RM3475] Execution time for a query or function shows only minutes part and not hour part

2019-01-15 Thread Aditya Toshniwal

Hi Hackers,

Attached is the patch to also display the hour part if the query execution
exceeds more than 1 hour, with some improvements is code. Test case added.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RM3475.patch
Description: Binary data

Jenkins build is back to normal : pgadmin4-master-python35 #857

2019-01-15 Thread pgAdmin 4 Jenkins

See

Jenkins build is back to normal : pgadmin4-master-python27 #870

2019-01-15 Thread pgAdmin 4 Jenkins

See

Re: [pgAdmin4][RM3837] Trigger when option syntax error

2019-01-15 Thread Aditya Toshniwal

Hi Hackers,

Please find the updated patch. Kindly review.

On Tue, Jan 15, 2019 at 6:05 PM Akshay Joshi 
wrote:

> Hi Aditya
>
> Facing issue when tested on EPAS 10, please verify it on EPAS.
>
> On Mon, Jan 14, 2019 at 6:26 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the syntax error if when clause is given.
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RN3837.patch
Description: Binary data

pgAdmin 4 commit: Fixed following issues:

2019-01-15 Thread Akshay Joshi

Fixed following issues:
 - Process watcher made fixed width with header changes, time details rounded 
to 2 decimals
 - Query history will show "No query history" if no query fired. Query editor 
default size increased.
 - Fixed a bug where New folder create button not working when in List mode and 
No files/folder present.
 - Other minor improvements.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7ac4e2a9d90159312636c95b9905655171705ee3
Author: Aditya Toshniwal 

Modified Files
--
.../schemas/functions/static/js/function.js|  1 +
.../databases/schemas/types/static/js/type.js  | 10 ++--
web/pgadmin/browser/static/css/wizard.css  |  3 ---
web/pgadmin/browser/templates/browser/index.html   |  2 +-
web/pgadmin/misc/bgprocess/processes.py| 10 +++-
web/pgadmin/misc/bgprocess/static/js/bgprocess.js  | 11 +---
.../misc/bgprocess/static/scss/_bgprocess.scss |  2 ++
web/pgadmin/misc/file_manager/static/js/utility.js | 15 ---
.../file_manager/static/scss/_file_manager.scss|  4 +++
web/pgadmin/preferences/static/js/preferences.js   | 11 
web/pgadmin/static/js/backform.pgadmin.js  |  5 
web/pgadmin/static/jsx/history/query_history.jsx   | 29 ++
web/pgadmin/static/scss/_aci_tree.overrides.scss   | 14 ---
web/pgadmin/static/scss/_alert.scss|  4 +--
web/pgadmin/static/scss/_alertify.overrides.scss   | 14 +--
web/pgadmin/static/scss/_bootstrap.overrides.scss  |  3 ++-
web/pgadmin/static/scss/_pgadmin.style.scss| 22 ++--
web/pgadmin/static/scss/_webcabin.pgadmin.scss |  4 +++
.../static/scss/resources/_default.variables.scss  |  6 -
web/pgadmin/tools/backup/__init__.py   | 18 +++---
.../tools/backup/tests/test_backup_message.py  |  6 ++---
.../tools/grant_wizard/static/js/grant_wizard.js   |  8 --
web/pgadmin/tools/import_export/__init__.py| 14 +++
web/pgadmin/tools/maintenance/__init__.py  |  4 +++
web/pgadmin/tools/restore/__init__.py  |  6 -
.../tools/restore/tests/test_restore_message.py|  2 +-
.../tools/sqleditor/static/css/sqleditor.css   | 10 
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  2 +-
.../tools/sqleditor/static/scss/_history.scss  | 11 +++-
.../tools/sqleditor/static/scss/_sqleditor.scss| 15 ++-
.../javascript/history/query_history_spec.jsx  |  2 +-
31 files changed, 168 insertions(+), 100 deletions(-)

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

2019-01-15 Thread Akshay Joshi

Thanks patch applied without Tree Changes.

On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal  wrote:

> Hi Hackers,
>
> Attached is the patch for further design improvements:
> - Process watcher made fixed width with header changes, time details
> rounded to 2 decimals
> - Query history will show "No query history" if no query fired. Query
> editor default size increased.
> - Tree improvements - right bold border removed completely. Now click
> anywhere on a tree item to perform actions. Please note, single click on
> the tiny tree arrow button will not work with this. Clicking anywhere is
> more useful than this.
>
 @Dave  Should we proceed with this behaviour, I haven't commit it.

> - Fixed a bug where New folder create button not working when in List mode
> and No files/folder present.
> - Other minor improvements.
>
> Kindly review.
>
> On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for few more changes:
>> - New Folder button was not working in file dialogue. Fixed that.
>> - Color, icon changes in file dialogue
>> - Also replaced the splash screen image (which is used on main dashboard
>> also). It works fine on dashboard. However, I'm not sure of the splash
>> screen as the new image is SVG and older was PNG. I have made changes for
>> that in runtime code but I'm not able to test (evnvironment issue) runtime
>> code :(. It would be helpful if someone else can try it once.
>>
>> Kindly review.
>>
>>
>> On Mon, Jan 7, 2019 at 2:25 PM Dave Page  wrote:
>>
>>> Thanks - applied!
>>>
>>> On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal
>>>  wrote:
>>> >
>>> > Hi Hackers,
>>> >
>>> > Attached is the patch to incorporate the changes discussed in trailing
>>> mail(s).
>>> >
>>> > Kindly review.
>>> >
>>> > On Fri, Jan 4, 2019 at 3:31 PM Dave Page  wrote:
>>> >>
>>> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal
>>> >>  wrote:
>>> >> >
>>> >> > Hi,
>>> >> >
>>> >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page  wrote:
>>> >> >>
>>> >> >> Hi
>>> >> >>
>>> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>> >> >>>
>>> >> >>> Hi Dave,
>>> >> >>>
>>> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page 
>>> wrote:
>>> >> 
>>> >> 
>>> >>  A few other things that I noticed (or have been bugging me):
>>> >> 
>>> >>  - The menu bar seems a little cramped. Taking pg-navbar from 32
>>> to 40px and setting the font-weight to normal on the menu options (but not
>>> the product name) seems much better to me (and adjusting everything else as
>>> required of course).
>>> >> >>>
>>> >> >>> Giving too much space for the navbar will reduce the usable space
>>> for other things. It is good enough(32) to be used easily, and is equal to
>>> all the other headers in app (including tabs) giving a feel of native
>>> desktop application. You'll find even smaller menu heights in native
>>> desktop application. We can make font weight to normal and may be slightly
>>> increase horizontal spacing between the menu links.
>>> >> >>
>>> >> >>
>>> >> >> 8 pixels isn't going to make a noticeable difference to the
>>> workspace for users, and would leave the bar smaller than the 50px it's
>>> been for the last couple of years (iirc). I think it needs it to avoid
>>> looking cramped - please make the change.
>>> >> >
>>> >> > Will do.
>>> >> > One more doubt regarding bold headers, should I remove bold headers
>>> in dashboard graph header, subnode headers (eg.table->columns), properties
>>> tab accrordian headers ?
>>> >>
>>> >> No, please don't. I left them bold and the styling seemed like it
>>> >> worked. We can tweak again if others disagree later.
>>> >>
>>> >> Thanks!
>>> >>
>>> >> BTW - Chrome 71 shows the offset headers in the file dialogue as well.
>>> >>
>>> >> 
>>> >>  - In the file dialogue, the column headers don't line up with
>>> the columns in the rows.
>>> >> >>>
>>> >> >>> I could not see this on my machine (screenshot attached). Could
>>> you please share the screenshot.
>>> >> >>
>>> >> >>
>>> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS.
>>> >> >>
>>> >> >> --
>>> >> >> Dave Page
>>> >> >> Blog: http://pgsnake.blogspot.com
>>> >> >> Twitter: @pgsnake
>>> >> >>
>>> >> >> EnterpriseDB UK: http://www.enterprisedb.com
>>> >> >> The Enterprise PostgreSQL Company
>>> >> >
>>> >> >
>>> >> >
>>> >> > --
>>> >> > Thanks and Regards,
>>> >> > Aditya Toshniwal
>>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>> >> > "Don't Complain about Heat, Plant a tree"
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Dave Page
>>> >> Blog: http://pgsnake.blogspot.com
>>> >> Twitter: @pgsnake
>>> >>
>>> >> EnterpriseDB UK: http://www.enterprisedb.com
>>> >> The Enterprise PostgreSQL Company
>>> >
>>> >
>>> >
>>> > --
>>> > Thanks and Regards,
>>> > Aditya Toshniwal
>>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>> > "Don't Complain

Re: Help to translate pt-br

2019-01-15 Thread Khushboo Vashi

On Tue, Nov 27, 2018 at 12:23 PM Bruno Silva  wrote:

> Ok, let me check this.
>
>
Please let us know if you need any help to do this.


> Bruno E. A. Silva.
> Analista de Sistemas.
> Bacharel em Sistemas de Informação
> MBA Gerência de Projetos
> Certified Scrum Master
> LPIC-1
> SCJP, SE 6
> Novell CLA / DCTS ECR
> DBA Postgres
> ---
> “A caixa dizia: Requer MS Windows ou superior. Então instalei Linux.” -
> Sábio Desconhecido
> "Alguns prestam serviço/consultoria de Qualidade, os outros vendem
> licença!"
>
>
> Em ter, 27 de nov de 2018 às 02:00, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> escreveu:
>
>> Hi,
>>
>> On Mon, Nov 26, 2018 at 8:38 PM Bruno Silva 
>> wrote:
>>
>>> Ok.
>>> The attached file attend the specified pattern?
>>>
>>> The patch contains compiled version of translation files of other
>> languages, which is not required.
>> Please send only Portuguese translation files.
>>
>> Thanks,
>> Khushboo
>>
>>>
>>> Em qui, 22 de nov de 2018 às 02:00, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> escreveu:
>>>
 On Wed, Nov 21, 2018 at 10:17 PM Bruno Silva 
 wrote:

> But is this ok? I send a patch to the email? Why don't use PR, Merge
> or something like this?
>
 You need to send the patch to this email group pgadmin-hackers.

> Bruno E. A. Silva.
> Analista de Sistemas.
> Bacharel em Sistemas de Informação
> MBA Gerência de Projetos
> Certified Scrum Master
> LPIC-1
> SCJP, SE 6
> Novell CLA / DCTS ECR
> DBA Postgres
> ---
> “A caixa dizia: Requer MS Windows ou superior. Então instalei Linux.”
> - Sábio Desconhecido
> "Alguns prestam serviço/consultoria de Qualidade, os outros vendem
> licença!"
>
>
> Em qua, 21 de nov de 2018 às 13:42, Bruno Silva 
> escreveu:
>
>> Thanks.
>> Bruno E. A. Silva.
>> Analista de Sistemas.
>> Bacharel em Sistemas de Informação
>> MBA Gerência de Projetos
>> Certified Scrum Master
>> LPIC-1
>> SCJP, SE 6
>> Novell CLA / DCTS ECR
>> DBA Postgres
>> ---
>> “A caixa dizia: Requer MS Windows ou superior. Então instalei Linux.”
>> - Sábio Desconhecido
>> "Alguns prestam serviço/consultoria de Qualidade, os outros vendem
>> licença!"
>>
>>
>> Em qua, 21 de nov de 2018 às 10:33, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> escreveu:
>>
>>> Hi,
>>>
>>> On Wed, Nov 21, 2018 at 6:29 PM Bruno Silva 
>>> wrote:
>>>
 I'm using pgAdmin4 and noted that has no translation to portuguese.
 I teach Database on college and my students learn to use pgAdmin4,
 so I thought about contributing the pt-br translation, how can I
 proceed?


>>> Please refer
>>> https://www.pgadmin.org/docs/pgadmin4/dev/translations.html which
>>> will help you to proceed further with the translation.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> Bruno E. A. Silva.
 Analista de Sistemas.
 Bacharel em Sistemas de Informação
 MBA Gerência de Projetos
 Certified Scrum Master
 LPIC-1
 SCJP, SE 6
 Novell CLA / DCTS ECR
 DBA Postgres
 ---
 “A caixa dizia: Requer MS Windows ou superior. Então instalei
 Linux.” - Sábio Desconhecido
 "Alguns prestam serviço/consultoria de Qualidade, os outros vendem
 licença!"

>>>

pgAdmin 4 commit: Fixed SQL for foreign table options. Fixes #3453

2019-01-15 Thread Akshay Joshi

Fixed SQL for foreign table options. Fixes #3453

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d7b050830553e50332a01122e097bcf98e5ed789
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_2.rst  | 1 +
.../servers/databases/schemas/foreign_tables/__init__.py  | 4 
2 files changed, 1 insertion(+), 4 deletions(-)

Re: [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab

2019-01-15 Thread Akshay Joshi

Thanks patch applied.

On Mon, Jan 14, 2019 at 2:28 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix incomplete SQL for Foreign tables in SQL tab.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

2019-01-15 Thread Harshal Dhumal

Hi,

Please find attached updated patch.
In this patch I have fixed two issues:
i. Dialog tab navigation should work even if focus is on footer buttons
(Save, Cancel, etc..)
ii. Focus should be set to first editable element of dialog when tab cycle
goes through all editable footer buttons.


-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
> This patch fixes Dialog tabset keyboard navigation.
> This regression was caused due to bootstrap 4 changes.
> Also I have added jasmine test cases for the same
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/browser/static/js/keyboard.js b/web/pgadmin/browser/static/js/keyboard.js
index 79266bf..4d9b6ae 100644
--- a/web/pgadmin/browser/static/js/keyboard.js
+++ b/web/pgadmin/browser/static/js/keyboard.js
@@ -349,11 +349,11 @@ _.extend(pgBrowser.keyboardNavigation, {
   d: selectedTreeNodeData,
 };
   },
-  getDialogTabNavigator: function(dialog) {
+  getDialogTabNavigator: function(dialogContainer) {
 const backward_shortcut = pgBrowser.get_preference('browser', 'dialog_tab_backward').value;
 const forward_shortcut = pgBrowser.get_preference('browser', 'dialog_tab_forward').value;
 
-return new dialogTabNavigator.dialogTabNavigator(dialog, backward_shortcut, forward_shortcut);
+return new dialogTabNavigator.dialogTabNavigator(dialogContainer, backward_shortcut, forward_shortcut);
   },
 });
 
diff --git a/web/pgadmin/browser/static/js/node.js b/web/pgadmin/browser/static/js/node.js
index f5cb8cd..30605dd 100644
--- a/web/pgadmin/browser/static/js/node.js
+++ b/web/pgadmin/browser/static/js/node.js
@@ -412,8 +412,6 @@ define('pgadmin.browser.node', [
 view.render();
 setFocusOnEl();
 newModel.startNewSession();
-// var dialogTabNavigator = pgBrowser.keyboardNavigation.getDialogTabNavigator(view);
-pgBrowser.keyboardNavigation.getDialogTabNavigator(view);
   },
   error: function(xhr, error, message) {
 var _label = that && item ?
@@ -450,8 +448,6 @@ define('pgadmin.browser.node', [
 view.render();
 setFocusOnEl();
 newModel.startNewSession();
-// var dialogTabNavigator = pgBrowser.keyboardNavigation.getDialogTabNavigator(view);
-pgBrowser.keyboardNavigation.getDialogTabNavigator(view);
   }
 }
 
@@ -1083,7 +1079,7 @@ define('pgadmin.browser.node', [
 // All buttons will be created within a single
 // div area.
 var btnGroup =
-  $('').addClass(
+  $('').addClass(
 'pg-prop-btn-group'
   ),
   // Template used for creating a button
@@ -1200,7 +1196,6 @@ define('pgadmin.browser.node', [
 });
   },
 });
-
 createButtons(buttons, 'header', 'pg-prop-btn-group-above');
   }
   j.append(content);
@@ -1392,7 +1387,7 @@ define('pgadmin.browser.node', [
 );
 
 // Create proper buttons
-createButtons([{
+let btn_grp = createButtons([{
   label: '',
   type: 'help',
   tooltip: gettext('SQL help for this object type.'),
@@ -1458,6 +1453,18 @@ define('pgadmin.browser.node', [
 });
   },
 }], 'footer', 'pg-prop-btn-group-below');
+
+btn_grp.on('keydown', 'button', function(event) {
+  if (event.keyCode == 9 && $(this).nextAll('button:not([disabled])').length == 0) {
+// set focus back to first editable input element of current active tab once we cycle through all enabled buttons.
+commonUtils.findAndSetFocus(view.$el.find('.tab-content div.active'));
+return false;
+  }
+});
+
+setTimeout(function() {
+  pgBrowser.keyboardNavigation.getDialogTabNavigator(panel.pgElContainer);
+}, 200);
   }
 
   // Create status bar.
diff --git a/web/pgadmin/static/js/dialog_tab_navigator.js b/web/pgadmin/static/js/dialog_tab_navigator.js
index 19b2045..4472172 100644
--- a/web/pgadmin/static/js/dialog_tab_navigator.js
+++ b/web/pgadmin/static/js/dialog_tab_navigator.js
@@ -13,13 +13,13 @@ import { findAndSetFocus } from './utils';
 import { parseShortcutValue } from './utils';
 
 class dialogTabNavigator {
-  constructor(dialog, backwardShortcut, forwardShortcut) {
+  constructor(dialogContainer, backwardShortcut, forwardShortcut) {
 
-this.dialog = dialog;
+this.dialogContainer = dialogContainer;
 
 this.tabSwitching = false;
 
-this.tabs = t

pgAdmin 4 commit: Fixed execution time to show Hours part for long runn

2019-01-15 Thread Akshay Joshi

Fixed execution time to show Hours part for long running queries in Query Tool. 
Fixes #3475

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dec43d98dc589010b91bb40512fe0f026d6f004f
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_2.rst   |  1 +
.../js/sqleditor/calculate_query_run_time.js   | 33 +++---
.../sqleditor/calculate_query_run_time_spec.js | 23 +++
3 files changed, 41 insertions(+), 16 deletions(-)

Re: [pgAdmin4][RM3475] Execution time for a query or function shows only minutes part and not hour part

2019-01-15 Thread Akshay Joshi

Thanks patch applied.

On Tue, Jan 15, 2019 at 7:18 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to also display the hour part if the query execution
> exceeds more than 1 hour, with some improvements is code. Test case added.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][RM3837] Trigger when option syntax error

2019-01-15 Thread Aditya Toshniwal

Hi Hackers,

Kindly ignore the previous patch, some typo mistake in filename. Apologies.
Attached is the updated patch.

On Wed, Jan 16, 2019 at 11:19 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the updated patch. Kindly review.
>
> On Tue, Jan 15, 2019 at 6:05 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Aditya
>>
>> Facing issue when tested on EPAS 10, please verify it on EPAS.
>>
>> On Mon, Jan 14, 2019 at 6:26 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix the syntax error if when clause is given.
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RM3837.patch
Description: Binary data

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

pgAdmin 4 v4.1 released

pgAdmin 4 commit: Tag REL-4_1 has been created.

Re: [pgAdmin4][RM3837] Trigger when option syntax error

pgAdmin 4 commit: Ensure long string should be wrap in alertify dialogs

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

Build failed in Jenkins: pgadmin4-master-python35 #856

pgAdmin 4 commit: Proper error should be thrown when server group is cr

Re: [pgAdmin4][RM3693] Message "Error saving properties Click on Detail" displayed if user create server group with same name

Build failed in Jenkins: pgadmin4-master-python27 #869

[pgAdmin4][RM3475] Execution time for a query or function shows only minutes part and not hour part

Jenkins build is back to normal : pgadmin4-master-python35 #857

Jenkins build is back to normal : pgadmin4-master-python27 #870

Re: [pgAdmin4][RM3837] Trigger when option syntax error

pgAdmin 4 commit: Fixed following issues:

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

Re: Help to translate pt-br

pgAdmin 4 commit: Fixed SQL for foreign table options. Fixes #3453

Re: [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

pgAdmin 4 commit: Fixed execution time to show Hours part for long runn

Re: [pgAdmin4][RM3475] Execution time for a query or function shows only minutes part and not hour part

Re: [pgAdmin4][RM3837] Trigger when option syntax error

23 matches

Site Navigation

Mail list logo

Footer information