Hi Hackers,
Attached is the patch to incorporate the changes discussed in trailing
mail(s).
Kindly review.
On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote:
> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal
> wrote:
> >
> > Hi,
> >
> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote:
> >>
> >> Hi
> >>
> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
> >>>
> >>> Hi Dave,
> >>>
> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote:
>
>
> A few other things that I noticed (or have been bugging me):
>
> - The menu bar seems a little cramped. Taking pg-navbar from 32 to
> 40px and setting the font-weight to normal on the menu options (but not the
> product name) seems much better to me (and adjusting everything else as
> required of course).
> >>>
> >>> Giving too much space for the navbar will reduce the usable space for
> other things. It is good enough(32) to be used easily, and is equal to all
> the other headers in app (including tabs) giving a feel of native desktop
> application. You'll find even smaller menu heights in native desktop
> application. We can make font weight to normal and may be slightly increase
> horizontal spacing between the menu links.
> >>
> >>
> >> 8 pixels isn't going to make a noticeable difference to the workspace
> for users, and would leave the bar smaller than the 50px it's been for the
> last couple of years (iirc). I think it needs it to avoid looking cramped -
> please make the change.
> >
> > Will do.
> > One more doubt regarding bold headers, should I remove bold headers in
> dashboard graph header, subnode headers (eg.table->columns), properties tab
> accrordian headers ?
>
> No, please don't. I left them bold and the styling seemed like it
> worked. We can tweak again if others disagree later.
>
> Thanks!
>
> BTW - Chrome 71 shows the offset headers in the file dialogue as well.
>
>
> - In the file dialogue, the column headers don't line up with the
> columns in the rows.
> >>>
> >>> I could not see this on my machine (screenshot attached). Could you
> please share the screenshot.
> >>
> >>
> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS.
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > Software Engineer | EnterpriseDB Software Solutions | Pune
> > "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
RM3692.part4.patch
Description: Binary data
