Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Hi On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: > >> >> A few other things that I noticed (or have been bugging me): >> >> - The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px >> and setting the font-weight to normal on the menu options (but not the >> product name) seems much better to me (and adjusting everything else as >> required of course). >> > Giving too much space for the navbar will reduce the usable space for > other things. It is good enough(32) to be used easily, and is equal to all > the other headers in app (including tabs) giving a feel of native desktop > application. You'll find even smaller menu heights in native desktop > application. We can make font weight to normal and may be slightly > increase horizontal spacing between the menu links. > 8 pixels isn't going to make a noticeable difference to the workspace for users, and would leave the bar smaller than the 50px it's been for the last couple of years (iirc). I think it needs it to avoid looking cramped - please make the change. > >> - In the file dialogue, the column headers don't line up with the columns >> in the rows. >> > I could not see this on my machine (screenshot attached). Could you please > share the screenshot. > Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
[pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server
Hi Hackers, Attached is the patch to fix RM #3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3549.patch Description: Binary data
pgAdmin 4 commit: Update WSGI instructions for Windows for Python 3. Fi
Update WSGI instructions for Windows for Python 3. Fixes #3847. Patch from Benjamin Hayes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f40444087bfe745fa1241e0cc50742ae643ad1c Modified Files -- docs/en_US/server_deployment.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Hi, On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: > Hi > > On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: >> >>> >>> A few other things that I noticed (or have been bugging me): >>> >>> - The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px >>> and setting the font-weight to normal on the menu options (but not the >>> product name) seems much better to me (and adjusting everything else as >>> required of course). >>> >> Giving too much space for the navbar will reduce the usable space for >> other things. It is good enough(32) to be used easily, and is equal to all >> the other headers in app (including tabs) giving a feel of native desktop >> application. You'll find even smaller menu heights in native desktop >> application. We can make font weight to normal and may be slightly >> increase horizontal spacing between the menu links. >> > > 8 pixels isn't going to make a noticeable difference to the workspace for > users, and would leave the bar smaller than the 50px it's been for the last > couple of years (iirc). I think it needs it to avoid looking cramped - > please make the change. > Will do. One more doubt regarding bold headers, should I remove bold headers in dashboard graph header, subnode headers (eg.table->columns), properties tab accrordian headers ? > > >> >>> - In the file dialogue, the column headers don't line up with the >>> columns in the rows. >>> >> I could not see this on my machine (screenshot attached). Could you >> please share the screenshot. >> > > Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal wrote: > > Hi, > > On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: >> >> Hi >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal >> wrote: >>> >>> Hi Dave, >>> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: A few other things that I noticed (or have been bugging me): - The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px and setting the font-weight to normal on the menu options (but not the product name) seems much better to me (and adjusting everything else as required of course). >>> >>> Giving too much space for the navbar will reduce the usable space for other >>> things. It is good enough(32) to be used easily, and is equal to all the >>> other headers in app (including tabs) giving a feel of native desktop >>> application. You'll find even smaller menu heights in native desktop >>> application. We can make font weight to normal and may be slightly increase >>> horizontal spacing between the menu links. >> >> >> 8 pixels isn't going to make a noticeable difference to the workspace for >> users, and would leave the bar smaller than the 50px it's been for the last >> couple of years (iirc). I think it needs it to avoid looking cramped - >> please make the change. > > Will do. > One more doubt regarding bold headers, should I remove bold headers in > dashboard graph header, subnode headers (eg.table->columns), properties tab > accrordian headers ? No, please don't. I left them bold and the styling seemed like it worked. We can tweak again if others disagree later. Thanks! BTW - Chrome 71 shows the offset headers in the file dialogue as well. - In the file dialogue, the column headers don't line up with the columns in the rows. >>> >>> I could not see this on my machine (screenshot attached). Could you please >>> share the screenshot. >> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix copyright notice.
Fix copyright notice. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7d2ab6a6854f9a6253b7aac6839fd76cb82a0d60 Modified Files -- tools/copyright_updater.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Bump version prior to 4.0
Bump version prior to 4.0 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6778aa915ac8d8ce8d3c2b93ed8515f0d0b798b Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 4 ++-- web/config.py| 10 +- 3 files changed, 9 insertions(+), 9 deletions(-)
pgAdmin 4 commit: Put the appname back how it should be!
Put the appname back how it should be! Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b5c7a108abbd8854ab00d7032f885069569f3ee9 Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Display event trigger functions correctly on EPAS. Fi
Display event trigger functions correctly on EPAS. Fixes #3549 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e27bf989fcd210d6c32d96a8a9f9f3590b96d9e Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_7.rst| 1 + .../templates/trigger_function/ppas/sql/11_plus/coll_stats.sql | 2 +- .../functions/templates/trigger_function/ppas/sql/11_plus/delete.sql| 2 +- .../functions/templates/trigger_function/ppas/sql/11_plus/node.sql | 2 +- .../templates/trigger_function/ppas/sql/11_plus/properties.sql | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-)
Re: [pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server
Thanks, applied. On Fri, Jan 4, 2019 at 9:49 AM Akshay Joshi wrote: > > Hi Hackers, > > Attached is the patch to fix RM #3549 Trigger function with return type > event_trigger is not displayed in tree view with EPAS server. > > Please review it. > > -- > Akshay Joshi > Sr. Software Architect > > > Phone: +91 20-3058-9517 > Mobile: +91 976-788-8246 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Update release notes.
Update release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb02f8b1be216616ef48d8ca47725db60923080c Modified Files -- docs/en_US/release_notes_3_7.rst | 1 + 1 file changed, 1 insertion(+)
Packagers: Version change
Packagers, Our release schedule had a long month due to the holidays, but as of next week we're back onto our 4 week cadence. By way of a heads-up, the next release will be version 4.0, not 3.7 as originally planned. This is to reflect the new UI design. I don't imagine it'll make a difference to all of you, but if you're allowing side-by-side installations of major versions of pgAdmin, you may need to tweak packaging. Thanks, Dave. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Ensure we display the relation name (and not the OID)
Ensure we display the relation name (and not the OID) in the locks table wherever possible. Fixes #3702 Note that at the server level we fetch the data from pg_locks in the maintenance database, so it can not fetch the pg_class relation for tables in other databasess (relation::regclass). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce1c06d7f1e525f7eba5245a3f62e54547f4134f Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_3_7.rst | 1 + web/pgadmin/dashboard/__init__.py | 34 +- 2 files changed, 18 insertions(+), 17 deletions(-)
Re: [pgAdmin4][Patch]: RM 3702 - pgAdmin dashboard showing the oid for the user-defined tables and table names for the catalog tables in locks monitoring window
Thanks, patch applied. On Fri, Jan 4, 2019 at 11:53 AM Khushboo Vashi wrote: > > Hi, > > Please find the attached patch to fix RM #3702 - pgAdmin dashboard showing > the oid for the user-defined tables and table names for the catalog tables in > locks monitoring window. > > Dashboard > Server Activity > Locks - shows the table oid in the 'Target > relation' column instead of table name. > > The attached patch fixes this issue for the database level but not for the > server level. The reason for this is, at the server level we fetch the data > from the pg_locks with the maintenance database, so it can not fetch the > pg_class relation for the other database tables (relation::regclass). > > Please find the attached screen-shots for the issue and the fix and let me > know if there is any other way to fix this. > > Thanks, > Khushboo > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Japanese translation for v3.7
Hi On Fri, Jan 4, 2019 at 11:53 AM fn ln wrote: > > Hello. > Updated message catalog is in attachment. > messages.pot is based on git ad56e7fb. Thanks - unfortunately I'm unable to extract the po file from the email; for some reason, GMail is only downloading about 50% of it (without giving any errors). Could you send me a zipped copy please? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Japanese translation for v3.7
Sure. the 7-zipped archive is in attachment. 2019年1月4日(金) 23:51 Dave Page : > Hi > > On Fri, Jan 4, 2019 at 11:53 AM fn ln wrote: > > > > Hello. > > Updated message catalog is in attachment. > > messages.pot is based on git ad56e7fb. > > Thanks - unfortunately I'm unable to extract the po file from the > email; for some reason, GMail is only downloading about 50% of it > (without giving any errors). > > Could you send me a zipped copy please? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > messages.7z Description: Binary data
pgAdmin 4 commit: Update Japanese translation.
Update Japanese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23b649fbd17e1b1a496252c991517d6344198f67 Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 160952 -> 161161 bytes .../translations/ja/LC_MESSAGES/messages.po| 88 ++--- 2 files changed, 43 insertions(+), 45 deletions(-)
Re: Japanese translation for v3.7
Thanks, update committed! On Fri, Jan 4, 2019 at 3:44 PM fn ln wrote: > > Sure. the 7-zipped archive is in attachment. > > 2019年1月4日(金) 23:51 Dave Page : >> >> Hi >> >> On Fri, Jan 4, 2019 at 11:53 AM fn ln wrote: >> > >> > Hello. >> > Updated message catalog is in attachment. >> > messages.pot is based on git ad56e7fb. >> >> Thanks - unfortunately I'm unable to extract the po file from the >> email; for some reason, GMail is only downloading about 50% of it >> (without giving any errors). >> >> Could you send me a zipped copy please? >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
