Re: Packagers: Handling upgrade checks
Re: Dave Page 2019-01-02 > As you probably know, pgAdmin 4 checks for updates upon startup, and > if a newer version is available, directs the user to www.pgadmin.org > to download it. > > UPGRADE_CHECK_ENABLED = False For Debian, I'll use this method. Programs "calling home" is actually considered to be a privacy breach. Christoph
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Hi Hackers, Further improvement patch. With this patch, following are fixed: - Fieldset control design changes - File dialog - files list header should not scroll with the body and stick to the top - Debugger input args dialog cancel button should always be enabled - Backup globals dialog controls aligmnent correction - In View Data query tool, explain related buttons should be disabled - Autocomplete design changes I have also fixed one issue which was created by the copyright changes in the file - pgadmin/misc/file_manager/templates/file_manager/js/languages/en.js. The en.js file contains json data and adding copyright comments to it caused JSON parsing failure in file dialog. As an improvement, I have renamed the file from en.js to en.json at all the places to avoid such changes in future. Kindly review. On Wed, Jan 2, 2019 at 3:09 PM Akshay Joshi wrote: > Thanks patch applied. > > On Wed, Jan 2, 2019 at 11:23 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Kindly ignore the previous patch. Attaching updated patch with few more >> corrections. >> The patch includes: >> - Base font size changed from 0.815rem to 0.875rem, for navbar from >> 0.875rem to 0.925rem. >> - Dialog sizes made consistent throughout the application. Now there are >> 3 size options for width and height each - sm, md, lg. Combination of any >> of these to be used hereafter >> - Alignment fix for controls of Node properties dialogs which includes >> showing text and label in one line without dialog size change, checkbox >> alignment, switch control alignment at places and other minor improvements >> in other dialogs >> - Error message design change in dialogs validation >> - SQL Editor data grid editor popup design changes which were missed >> - Design change for dashboard server activity grid >> - Login page language dropdown color fix >> - Properties accordion collapse design fix >> - Help, Info icon fixed across all dialogs which were not working if >> clicked exactly on the text >> - Added missing icon with buttons at few places >> - Shadow behind the dialogs is increased to make it look clearly >> separated and depth. >> - Control Alignment fix in maintenance dialog >> - Min height of alertify dialogs set for better UX >> - File dialog design fix when no files found >> - Grant wizard fixes - Scroll bar visibility on first page, use full >> space for SQL generated on the last page >> - Browser toolbar buttons changed to sync with SQL editor toolbar buttons >> - Rounded corners for docker floating dialog (no properties) >> - Renaming file in file dialog should show original file name >> - SQL data grid text edit popup buttons behaviour was swapped. This is >> fixed. >> - Import/Export dialog changes as per new design. >> - Other improvements wherever noticed. >> >> On Tue, Jan 1, 2019 at 11:09 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to improve the previously committed new design >>> changes. >>> The patch includes: >>> - Base font size changed from 0.815rem to 0.875rem, for navbar from >>> 0.875rem to 0.925rem. >>> - Dialog sizes made consistent throughout the application. Now there are >>> 3 size options for width and height each - sm, md, lg. Combination of any >>> of these to be used hereafter >>> - Alignment fix for controls of Node properties dialogs which includes >>> showing text and label in one line without dialog size change, checkbox >>> alignment, switch control alignment at places and other minor improvements >>> in other dialogs >>> - Error message design change in dialogs validation >>> - SQL Editor data grid editor popup design changes which were missed >>> - Design change for dashboard server activity grid >>> - Login page language dropdown color fix >>> - Properties accordion collapse design fix >>> - Help, Info icon fixed across all dialogs which were not working if >>> clicked exactly on the text >>> - Added missing icon with buttons at few places >>> - Shadow behind the dialogs is increased to make it look clearly >>> separated and depth. >>> - Control Alignment fix in maintenance dialog >>> - Min height of alertify dialogs set for better UX >>> - File dialog design fix when no files found >>> - Grant wizard fixes - Scroll bar visibility on first page, use full >>> space for SQL generated on the last page >>> - Browser toolbar buttons changed to sync with SQL editor toolbar buttons >>> - Rounded corners for docker floating dialog (no properties) >>> - Other improvements wherever noticed. >>> >>> I hope this covers majority of the issues. >>> Kindly review. >>> >>> >>> On Fri, Dec 21, 2018 at 7:48 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> On Fri, Dec 21, 2018 at 7:46 PM Dave Page wrote: > On Fri, Dec 21, 2018 at 2:14 PM Aditya Toshniwal > wrote: > > > > For the query tool results grid text pop-out, you mean the border
Re: Packagers: Handling upgrade checks
Hi, On Thu, 2019-01-03 at 10:59 +0100, Christoph Berg wrote: > > UPGRADE_CHECK_ENABLED = False > > For Debian, I'll use this method. Programs "calling home" is actually > considered to be a privacy breach. Same here for the RPMs. That would also help if the RPMs are not released on time :-) Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.com PostgreSQL Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR signature.asc Description: This is a digitally signed message part
pgAdmin 4 commit: Ensure auto complete should works when first identifi
Ensure auto complete should works when first identifier in the FROM clause needs quoting. Fixes #3809 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a130d68c5760e584d9d0fe7a6e9760aaf890639 Modified Files -- docs/en_US/release_notes_3_7.rst | 1 + web/pgadmin/utils/sqlautocomplete/autocomplete.py | 3 +++ 2 files changed, 4 insertions(+)
pgAdmin 4 commit: Ensure auto complete should works for columns from a
Ensure auto complete should works for columns from a schema-qualified table. Fixes #3810 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c455dda3ce2731fe0e603b96f640fb64623ff85c Modified Files -- docs/en_US/release_notes_3_7.rst | 1 + web/pgadmin/utils/sqlautocomplete/autocomplete.py | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-)
pgAdmin 4 commit: Convert batch file line endings in an attempt to end
Convert batch file line endings in an attempt to end the insanity of missing labels. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2817ec438a255cda73068258985a9d38994d310f Modified Files -- Make.bat | 788 +++ 1 file changed, 394 insertions(+), 394 deletions(-)
pgAdmin 4 commit: Fix a webpack issue that could cause the Query Tool t
Fix a webpack issue that could cause the Query Tool to fail to render. Fixes #3679 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1283c22bb94aeea701754adbafae13de9c0b4449 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_3_7.rst | 1 + web/webpack.config.js| 5 - 2 files changed, 5 insertions(+), 1 deletion(-)
Re: [pgAdmin4][RM3679] Query Tool not working
Thanks, applied. On Thu, Jan 3, 2019 at 7:37 AM Aditya Toshniwal wrote: > > Hi Hackers, > > This is related to a very difficult to reproduce issue where query tool opens > blank. Note the disconnected icon, not to be confused with another issue > where resizing the query tool works and icon is connected. > Somehow, this occurred on my system (screenshot attached). It turned out to > be a webpack issue and many users are facing this (in other projects). > A workaround suggested by > https://github.com/webpack/webpack/issues/6094#issuecomment-413178158 is > applied in the attached patch. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Further styling fixes.
Further styling fixes.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7d765fea04bd3d059a7a7dc7b1aee01bf0e18ae8
Author: Aditya Toshniwal
Modified Files
--
web/pgadmin/browser/static/js/node.js | 2 +-
web/pgadmin/misc/file_manager/__init__.py | 7 +-
web/pgadmin/misc/file_manager/static/js/utility.js | 8 +--
.../file_manager/static/scss/_file_manager.scss| 52 ++
.../file_manager/js/languages/{en.js => en.json} | 9 ---
web/pgadmin/static/js/backform.pgadmin.js | 84 +-
web/pgadmin/static/scss/_backform.overrides.scss | 15 ++--
web/pgadmin/static/scss/_backgrid.overrides.scss | 7 +-
web/pgadmin/static/scss/_codemirror.overrides.scss | 25 ---
web/pgadmin/static/scss/_pgadmin.style.scss| 12 +++-
.../static/scss/resources/_default.variables.scss | 3 +
.../templates/security/change_password.html| 2 +-
web/pgadmin/tools/backup/static/js/backup.js | 7 +-
.../tools/debugger/static/js/debugger_ui.js| 2 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 3 +
15 files changed, 193 insertions(+), 45 deletions(-)
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Hi On Thu, Jan 3, 2019 at 10:20 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Further improvement patch. With this patch, following are fixed: > - Fieldset control design changes > - File dialog - files list header should not scroll with the body and > stick to the top > - Debugger input args dialog cancel button should always be enabled > - Backup globals dialog controls aligmnent correction > - In View Data query tool, explain related buttons should be disabled > - Autocomplete design changes > > I have also fixed one issue which was created by the copyright changes in > the file - > pgadmin/misc/file_manager/templates/file_manager/js/languages/en.js. > The en.js file contains json data and adding copyright comments to it > caused JSON parsing failure in file dialog. As an improvement, I have > renamed the file from en.js to en.json at all the places to avoid such > changes in future. > > Kindly review. > Thanks - applied. A few other things that I noticed (or have been bugging me): - The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px and setting the font-weight to normal on the menu options (but not the product name) seems much better to me (and adjusting everything else as required of course). - In the file dialogue, the column headers don't line up with the columns in the rows. - In list mode of the file dialogue, can we use the same coloured icons as we do in icon mode? Obviously smaller... - "Show hidden files and folders ?" shouldn't have a space before the question mark. - The menu bar on the file dialogue doesn't match the styling of the menu bar on the query tool (in fact, even the left and right ends of it are styled differently from each other). - The line numbers in the gutter of CodeMirror are tiny. - I'm not convinced about the boldness of the tab titles - I think the are just a little too harsh - can you change the font-weight to normal for them please (both the wcDocker and Bootstrap tabs)? Also (for another day); we should move the file dialog messages out of the JSON file altogether and use our normal translation mechanisms. Thanks again :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Improve wording.
Improve wording. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=598f69b63db86389ca8659536fb12339a167f3c6 Modified Files -- web/pgadmin/static/js/sqleditor/execute_query.js | 4 ++-- web/pgadmin/tools/sqleditor/static/js/sqleditor.js| 4 ++-- web/regression/javascript/sqleditor/execute_query_spec.js | 8 3 files changed, 8 insertions(+), 8 deletions(-)
pgAdmin 4 commit: Update message catalogs
Update message catalogs Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ad56e7fb1290b679562425acc8bb98a827c17602 Modified Files -- web/pgadmin/messages.pot | 6116 ++- .../translations/de/LC_MESSAGES/messages.mo| Bin 146199 -> 146141 bytes .../translations/de/LC_MESSAGES/messages.po| 6188 +-- .../translations/es/LC_MESSAGES/messages.mo| Bin 151177 -> 151056 bytes .../translations/es/LC_MESSAGES/messages.po| 6186 +-- .../translations/fr/LC_MESSAGES/messages.mo| Bin 154747 -> 154557 bytes .../translations/fr/LC_MESSAGES/messages.po| 6189 ++-- .../translations/ja/LC_MESSAGES/messages.mo| Bin 161125 -> 160952 bytes .../translations/ja/LC_MESSAGES/messages.po| 6186 +-- .../translations/ko/LC_MESSAGES/messages.mo| Bin 148715 -> 148626 bytes .../translations/ko/LC_MESSAGES/messages.po| 6186 +-- .../translations/pl/LC_MESSAGES/messages.mo| Bin 146412 -> 146397 bytes .../translations/pl/LC_MESSAGES/messages.po| 6188 +-- .../translations/ru/LC_MESSAGES/messages.mo| Bin 184713 -> 184366 bytes .../translations/ru/LC_MESSAGES/messages.po| 6186 +-- .../translations/zh/LC_MESSAGES/messages.mo| Bin 124971 -> 124995 bytes .../translations/zh/LC_MESSAGES/messages.po| 6184 +-- 17 files changed, 27935 insertions(+), 27674 deletions(-)
Translators: Release next week
Translators; The next release of pgAdmin is expected next week. I've tweaked a couple of very visible strings, so updates to translations prior to release would be helpful. The template and catalogs have been updated in git. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
