pgAdmin 4 commit: Fixed following:
Fixed following: - Base font size changed from 0.815rem to 0.875rem, for navbar from 0.875rem to 0.925rem. - Dialog sizes made consistent throughout the application. Now there are 3 size options for width and height each - sm, md, lg. Combination of any of these to be used hereafter - Alignment fix for controls of Node properties dialogs which includes showing text and label in one line without dialog size change, checkbox alignment, switch control alignment at places and other minor improvements in other dialogs - Error message design change in dialogs validation - SQL Editor data grid editor popup design changes which were missed - Design change for dashboard server activity grid - Login page language dropdown color fix - Properties accordion collapse design fix - Help, Info icon fixed across all dialogs which were not working if clicked exactly on the text - Added missing icon with buttons at few places - Shadow behind the dialogs is increased to make it look clearly separated and depth. - Control Alignment fix in maintenance dialog - Min height of alertify dialogs set for better UX - File dialog design fix when no files found - Grant wizard fixes - Scroll bar visibility on first page, use full space for SQL generated on the last page - Browser toolbar buttons changed to sync with SQL editor toolbar buttons - Rounded corners for docker floating dialog (no properties) - Renaming file in file dialog should show original file name - SQL data grid text edit popup buttons behaviour was swapped. This is fixed. - Import/Export dialog changes as per new design. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86ecf9c84ec4c36e6802ccd99b011057fc3e5f82 Author: Aditya Toshniwal Modified Files -- web/pgadmin/about/static/js/about.js | 5 +- .../databases/languages/static/js/language.js | 4 +- .../servers/databases/schemas/static/js/schema.js | 6 +- .../schemas/tables/indexes/static/js/index.js | 1 - .../databases/schemas/tables/static/js/table.js| 2 +- .../pgagent/schedules/static/js/pga_schedule.js| 23 +-- .../server_groups/servers/roles/static/js/role.js | 13 ++-- .../server_groups/servers/static/css/servers.css | 2 +- .../servers/tablespaces/static/js/tablespace.js| 2 +- .../server_groups/static/js/server_group.js| 4 +- web/pgadmin/browser/static/css/wizard.css | 19 -- web/pgadmin/browser/static/js/browser.js | 13 web/pgadmin/browser/static/js/node.js | 70 ++-- web/pgadmin/browser/static/js/panel.js | 4 +- web/pgadmin/browser/static/js/toolbar.js | 3 + web/pgadmin/browser/static/js/wizard.js| 35 +- web/pgadmin/browser/static/scss/_browser.scss | 5 ++ .../misc/bgprocess/static/scss/_bgprocess.scss | 2 +- .../misc/file_manager/static/css/file_manager.css | 4 +- .../misc/file_manager/static/js/file_manager.js| 4 +- web/pgadmin/misc/file_manager/static/js/utility.js | 25 --- .../file_manager/static/scss/_file_manager.scss| 24 +++ .../file_manager/templates/file_manager/index.html | 12 ++-- web/pgadmin/misc/static/explain/css/explain.css| 11 +--- web/pgadmin/preferences/static/js/preferences.js | 8 +-- .../preferences/static/scss/_preferences.scss | 19 ++ web/pgadmin/static/js/alertify.pgadmin.defaults.js | 4 +- web/pgadmin/static/js/backform.pgadmin.js | 2 +- web/pgadmin/static/js/slickgrid/editors.js | 17 ++--- web/pgadmin/static/js/sqleditor/filter_dialog.js | 26 .../js/sqleditor/query_tool_notifications.js | 5 +- web/pgadmin/static/scss/_aci_tree.overrides.scss | 2 +- web/pgadmin/static/scss/_alert.scss| 14 +--- web/pgadmin/static/scss/_alertify.overrides.scss | 19 -- web/pgadmin/static/scss/_backform.overrides.scss | 16 +++-- web/pgadmin/static/scss/_backgrid.overrides.scss | 5 ++ web/pgadmin/static/scss/_bootstrap.overrides.scss | 27 +++- web/pgadmin/static/scss/_pgadmin.style.scss| 77 +- web/pgadmin/static/scss/_select2.overrides.scss| 18 ++--- web/pgadmin/static/scss/_webcabin.pgadmin.scss | 64 +- .../static/scss/resources/_default.style.scss | 8 +++ .../static/scss/resources/_default.variables.scss | 32 ++--- web/pgadmin/static/vendor/backform/backform.js | 3 +- web/pgadmin/static/vendor/backgrid/backgrid.css| 4 -- web/pgadmin/templates/security/fields.html | 2 +- web/pgadmin/templates/security/login_user.html | 4 +- web/pgadmin/tools/backup/static/js/backup.js | 8 +-- .../tools/backup/static/js/backup_dialog.js| 4 +- web/pgadmin/tools/datagrid/static/js/datagrid.js | 2 +- .../tools/debugger/static/js/debugger_ui.js| 2 +- .../tools/grant_wizard/static/js/grant_wizard.js | 3 +- .../grant_wizard/static/scss/_grant_wizard.scss| 9 +-- .../tools/
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Thanks patch applied. On Wed, Jan 2, 2019 at 11:23 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Kindly ignore the previous patch. Attaching updated patch with few more > corrections. > The patch includes: > - Base font size changed from 0.815rem to 0.875rem, for navbar from > 0.875rem to 0.925rem. > - Dialog sizes made consistent throughout the application. Now there are 3 > size options for width and height each - sm, md, lg. Combination of any of > these to be used hereafter > - Alignment fix for controls of Node properties dialogs which includes > showing text and label in one line without dialog size change, checkbox > alignment, switch control alignment at places and other minor improvements > in other dialogs > - Error message design change in dialogs validation > - SQL Editor data grid editor popup design changes which were missed > - Design change for dashboard server activity grid > - Login page language dropdown color fix > - Properties accordion collapse design fix > - Help, Info icon fixed across all dialogs which were not working if > clicked exactly on the text > - Added missing icon with buttons at few places > - Shadow behind the dialogs is increased to make it look clearly separated > and depth. > - Control Alignment fix in maintenance dialog > - Min height of alertify dialogs set for better UX > - File dialog design fix when no files found > - Grant wizard fixes - Scroll bar visibility on first page, use full space > for SQL generated on the last page > - Browser toolbar buttons changed to sync with SQL editor toolbar buttons > - Rounded corners for docker floating dialog (no properties) > - Renaming file in file dialog should show original file name > - SQL data grid text edit popup buttons behaviour was swapped. This is > fixed. > - Import/Export dialog changes as per new design. > - Other improvements wherever noticed. > > On Tue, Jan 1, 2019 at 11:09 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to improve the previously committed new design >> changes. >> The patch includes: >> - Base font size changed from 0.815rem to 0.875rem, for navbar from >> 0.875rem to 0.925rem. >> - Dialog sizes made consistent throughout the application. Now there are >> 3 size options for width and height each - sm, md, lg. Combination of any >> of these to be used hereafter >> - Alignment fix for controls of Node properties dialogs which includes >> showing text and label in one line without dialog size change, checkbox >> alignment, switch control alignment at places and other minor improvements >> in other dialogs >> - Error message design change in dialogs validation >> - SQL Editor data grid editor popup design changes which were missed >> - Design change for dashboard server activity grid >> - Login page language dropdown color fix >> - Properties accordion collapse design fix >> - Help, Info icon fixed across all dialogs which were not working if >> clicked exactly on the text >> - Added missing icon with buttons at few places >> - Shadow behind the dialogs is increased to make it look clearly >> separated and depth. >> - Control Alignment fix in maintenance dialog >> - Min height of alertify dialogs set for better UX >> - File dialog design fix when no files found >> - Grant wizard fixes - Scroll bar visibility on first page, use full >> space for SQL generated on the last page >> - Browser toolbar buttons changed to sync with SQL editor toolbar buttons >> - Rounded corners for docker floating dialog (no properties) >> - Other improvements wherever noticed. >> >> I hope this covers majority of the issues. >> Kindly review. >> >> >> On Fri, Dec 21, 2018 at 7:48 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> >>> >>> On Fri, Dec 21, 2018 at 7:46 PM Dave Page wrote: >>> On Fri, Dec 21, 2018 at 2:14 PM Aditya Toshniwal wrote: > > For the query tool results grid text pop-out, you mean the border size around it ? > We don't have any design discussed for it, so could you please propose what can be done. Border, button colours etc. I can't draw anything, but I'd suggest that the border should be squared not rounded, and the thickness/shadow etc adjusted to match the other styling. >>> Cool. >>> Button colors are already changed. Others things noted. Will work on it. >>> > > On Fri, Dec 21, 2018 at 7:35 PM Dave Page wrote: >> >> On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal >> wrote: >> > >> > >> > >> > On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote: >> >> >> >> One other issue: I'm seeing that standard sized dialogues (e.g. the >> >> Server or Database Properties dialogues) are wrapping their labels and >> >> controls at the default size. That should not be the case. >> > >> > Yep. Akshay has logged that in the sheet shared
pgAdmin 4 commit: Update copyright notices for 2019
Update copyright notices for 2019 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e23d307c56e92453dc5ea108214c52bdb2409705 Author: Murtuza Zabuawala Modified Files -- docs/en_US/code_review.rst | 2 +- docs/en_US/coding_standards.rst | 2 +- pkg/docker/build.sh | 2 +- pkg/pip/build.sh | 2 +- pkg/pip/setup_pip.py | 2 +- pkg/src/build.sh | 2 +- runtime/ConfigWindow.cpp | 2 +- runtime/ConfigWindow.h | 2 +- runtime/FloatingWindow.cpp | 2 +- runtime/FloatingWindow.h | 2 +- runtime/Info.plist | 2 +- runtime/LogWindow.cpp| 2 +- runtime/LogWindow.h | 2 +- runtime/Logger.cpp | 2 +- runtime/Logger.h | 2 +- runtime/MenuActions.cpp | 2 +- runtime/MenuActions.h| 2 +- runtime/Server.cpp | 2 +- runtime/Server.h | 2 +- runtime/TrayIcon.cpp | 2 +- runtime/TrayIcon.h | 2 +- runtime/pgAdmin4.cpp | 2 +- runtime/pgAdmin4.h | 2 +- tools/copyright_updater.py | 3 ++- web/.eslintrc.js | 9 + web/config.py| 4 ++-- web/karma.conf.js| 9 + web/migrations/alembic.ini | 2 +- web/migrations/env.py| 2 +- web/migrations/script.py.mako| 2 +- web/migrations/versions/02b9dccdcfcb_.py | 2 +- web/migrations/versions/09d53fca90c7_.py | 2 +- web/migrations/versions/aa86fb60b73d_.py | 2 +- web/migrations/versions/b5b87fdfcb30_.py | 2 +- web/migrations/versions/ca00ec32581b_.py | 2 +- web/migrations/versions/ece2e76bf60e_.py | 2 +- web/migrations/versions/fdc58d9bd449_.py | 2 +- web/pgAdmin4.py | 2 +- web/pgAdmin4.wsgi| 2 +- web/pgadmin/__init__.py | 2 +- web/pgadmin/about/__init__.py| 2 +- web/pgadmin/about/static/js/about.js | 9 + web/pgadmin/browser/__init__.py | 2 +- web/pgadmin/browser/collection.py| 2 +- web/pgadmin/browser/register_browser_preferences.py | 2 +- web/pgadmin/browser/server_groups/__init__.py| 2 +- web/pgadmin/browser/server_groups/servers/__init__.py| 2 +- web/pgadmin/browser/server_groups/servers/databases/__init__.py | 2 +- .../browser/server_groups/servers/databases/casts/__init__.py| 2 +- .../server_groups/servers/databases/casts/static/js/cast.js | 9 + .../server_groups/servers/databases/casts/tests/__init__.py | 2 +- .../server_groups/servers/databases/casts/tests/test_cast_add.py | 2 +- .../servers/databases/casts/tests/test_cast_delete.py| 2 +- .../servers/databases/casts/tests/test_cast_delete_multiple.py | 2 +- .../server_groups/servers/databases/casts/tests/test_cast_get.py | 2 +- .../server_groups/servers/databases/casts/tests/test_cast_put.py | 2 +- .../browser/server_groups/servers/databases/casts/tests/utils.py | 2 +- .../server_groups/servers/databases/event_triggers/__init__.py | 2 +- .../servers/databases/event_triggers/static/js/event_trigger.js | 9 + .../servers/databases/event_triggers/tests/__init__.py | 2 +- .../databases/event_triggers/tests/test_event_trigger_add.py | 2 +- .../databases/event_triggers/tests/test_event_trigger_delete.py | 2 +- .../event_triggers/tests/test_event_trigger_delete_multiple.py | 2 +- .../databases/event_triggers/tests/test_event_trigger_get.py | 2 +- .../databases/event_triggers/tests/test_event_trigger_put.py | 2 +- .../servers/databases/event_triggers/tests/ut
Re: [pgAdmin] [RM#3839] Update copyright notices for 2019
Thanks patch applied. On Mon, Dec 31, 2018 at 2:47 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to update copyright notices for 2019. > > - Added the *.rst, .sh, .in, .mako, .ini, .jsx* extensions in the > copyright update tool. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
On Mon, Dec 24, 2018 at 2:17 AM Akshay Joshi wrote: > > > On Fri, 21 Dec 2018, 19:45 Dave Page >> >> >> On Fri, Dec 21, 2018 at 2:08 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Fri, 21 Dec 2018, 18:52 Dave Page >> Hi Looks good - I just found one issue; please go ahead and commit (with a release notes update) when fixed. - If I set the NULL replacement value to an empty string, it defaults back to NULL. It's therefore not possible to replace null values with an empty value. >>> >>> If you remember this is the default behaviour of the Preferences >>> dialog. It sets the default value again if you set the blank value. Fahar >>> has raised the same issue before and we have rejected that. If you think we >>> can create the new RM for that behaviour and will commit the current patch. >>> >> >> Well, we rejected it for a specific case. In this specific case, it makes >> sense to be able to enter a blank value. >> >> Maybe we just need an "allow blank" flag on the preference object, that >> does nothing except allow you to remove the default (or any other) value >> without it being replaced again? Obviously the default still needs to work >> until a value is written to the config DB. >> > > Ok. If i understand correctly this new parameter works for all the > preference parameter if set to true. By default it's value is False and if > user wants to enter blank value they will ser the flag. > No - it would be an internal flag that the user won't see. If set to false, then attempts to change a field to would actually set it to it's default (e.g. for binary paths, it would set it back to the default from config.py). If set to true, then attempts to change a field to would be accepted. The default value would only be used until such time as its overridden by the user. > >> >>> Thanks! On Fri, Dec 21, 2018 at 12:57 PM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > I have modified the condition, it won't through any exception. > Attached is the updated patch, please review it. > > On Fri, Dec 21, 2018 at 4:22 AM Dave Page wrote: > >> Sorry! Here is is. >> >> On Fri, Dec 21, 2018 at 12:12 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> Can you please attached the updated patch with your changes. I'll >>> try to fix the exception. >>> >>> On Fri, Dec 21, 2018 at 3:57 AM Dave Page wrote: >>> Hi Here's an updated patch as I've tweaked some of the wording. The screenshot probably isn't the right resolution, but as we're replacing them anyway it doesn't seem overly important. Feel free to fix if you like :-) With quoting set to either All or Strings, everything looks good. With it set to None, I still get an exception (below). The query I'm using is this: SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text Field separator: , Quote character: " Replace null's with: NULL Steps: 1) Run pgAdmin in Desktop mode. I'm running from within PyuCharms, using the venv detailed below. 2) Open the Query Tool on a PostgreSQL 9.6.10 database, running on MacOS 10.14.1 3) Run the above query, wit quoting set to All and check the result in the grid. 4) Download the CSV file and check. 5) Open Preferences and set quoting to Strings. 6) Download the CSV file and check. 7) Open Preferences and set quoting to None. 8) Download the CSV file *exception occurs*. System info: (pgadmin4) dpage@hal:*~/git/pgadmin4*$ python --version Python 3.6.7 (pgadmin4) dpage@hal:*~/git/pgadmin4*$ pip freeze alabaster==0.7.11 alembic==1.0.0 asn1crypto==0.24.0 Babel==2.6.0 bcrypt==3.1.4 blinker==1.4 certifi==2018.8.24 cffi==1.11.5 chardet==3.0.4 chromedriver-installer==0.0.6 click==6.7 cryptography==2.3 docutils==0.14 extras==1.0.0 fixtures==3.0.0 Flask==0.12.4 Flask-BabelEx==0.9.3 Flask-Gravatar==0.5.0 Flask-HTMLmin==1.3.2 Flask-Login==0.3.2 Flask-Mail==0.9.1 Flask-Migrate==2.1.1 Flask-Paranoid==0.2.0 Flask-Principal==0.4.0 Flask-Security==3.0.0 Flask-SQLAlchemy==2.3.2 >
pgAdmin 4 commit: Increase default startup timeout and give progressive
Increase default startup timeout and give progressive messages when things are slow. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e5b54eb1a45a53c07e0f69995eb189f1aa4946b Author: Aditya Toshniwal Modified Files -- runtime/pgAdmin4.cpp | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-)
Re: [patch][pgAdmin4] Windows error - The application server could not be contacted occasionally
Thanks, applied. On Tue, Jan 1, 2019 at 10:24 AM Aditya Toshniwal wrote: > > Hi Hackers, > > Some of the windows users are facing the error as "The application server > could not be contacted" while starting pgAdmin4. The startup logs had > nothing. Just that the application timed out. > I was able to simulate the issue for sometime when I started my windows > machine, but later it did not throw any error and worked fine. > It turned out that due to the slowness of the Windows OS initially the > application took time to setup which was longer than the app start timeout - > 30secs and so, timed out. > In the attached patch, I have increased the timeout to 90secs (difficult to > figure out the standard timeout). Plus, I have changed the messages at > intervals when the app is starting so that it does not look stuck. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Make the upgrade check key configurable.
Make the upgrade check key configurable. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d7da8be4864429e33465a4fe382337b930c99649 Modified Files -- web/config.py | 3 +++ web/pgadmin/browser/__init__.py | 7 --- 2 files changed, 7 insertions(+), 3 deletions(-)
pgAdmin 4 commit: Update yarn lockfile.
Update yarn lockfile. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a9406237a0fb6d9d2babc5c37377df899180631 Modified Files -- web/yarn.lock | 1015 + 1 file changed, 14 insertions(+), 1001 deletions(-)
Packagers: Handling upgrade checks
Packagers, As you probably know, pgAdmin 4 checks for updates upon startup, and if a newer version is available, directs the user to www.pgadmin.org to download it. The is a problem if your pgAdmin came with a PostgreSQL installer (as you can't download them from our website), and potentially mildly annoying if you're a .deb or .rpm user. There are a couple of ways to optimise the experience for users here (one of which I just committed). I'll leave it up to each of you to choose what you want to do (Sandeep, I would suggest that the EDB installers use method 2). Method 1: Simply disable the upgrade check, and leave that to the operating systems update tools. To do this, create (or edit) a config_distro.py file that is installed alongside the config.py file from the pgAdmin source and include the line; UPGRADE_CHECK_ENABLED = False Method 2: For well known and trusted distributions we can support a custom check for your distribution. This involves 2 parts: 1) Let me know that you want a custom check, and I'll setup access for you to manage the version data on the pgAdmin website. We'll agree on a custom key for that data within the JSON file the website hosts. 2) Create (or edit) a config_distro.py file that is installed alongside the config.py file from the pgAdmin source and include the line; UPGRADE_CHECK_KEY = '' With this method, a different section of the JSON datafile will be checked by your distribution of pgAdmin, thus allowing you to control both when it tells users a new version is available, and the URL to which they are directed. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
