pgAdmin 4 commit: Make the setup process more robust against aborted ex
Make the setup process more robust against aborted executions. Fixes #3830 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=943fc25f60f2ab585ccc352455495045fe24e415 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_3_7.rst | 3 ++- web/migrations/versions/fdc58d9bd449_.py | 3 ++- web/pgadmin/__init__.py | 12 +++- web/pgadmin/setup/__init__.py| 2 +- web/pgadmin/setup/db_version.py | 5 + 5 files changed, 17 insertions(+), 8 deletions(-)
Re: [pgAdmin4][RM3830] AttributeError if pgadmin4-web-setup.sh stopped in between login setup and run again
Thanks, applied. On Thu, Dec 20, 2018 at 10:56 AM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is patch to fix the exception "AttributeError: 'NoneType' object has > no attribute 'value'", which occurs when you stop(Ctrl+Z or Ctrl+C) > pgadmin4-web-setup.sh script while entering details for login and then run > pgadmin4-web-setup.sh again. pgAdmin4 fails to start thereafter. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add flask-migrate to the container doc build as it's
Add flask-migrate to the container doc build as it's now required. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12b7e03085afef5ba7dc40c4114e69d122b55d94 Modified Files -- pkg/docker/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Further improvements to treeview restoration. Fixes #
Further improvements to treeview restoration. Fixes #3559 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a000dc6f60cc4bcf527ecab264ca9261e5c8172f Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_3_7.rst | 1 + .../static/js/tree/pgadmin_tree_save_state.js | 85 ++ 2 files changed, 55 insertions(+), 31 deletions(-)
Re: [pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser
Thanks, patch applied! On Thu, Dec 20, 2018 at 11:39 AM Khushboo Vashi wrote: > > > > On Thu, Dec 20, 2018 at 4:01 PM Dave Page wrote: >> >> Hi >> >> On Tue, Dec 18, 2018 at 9:46 AM Khushboo Vashi >> wrote: >> > >> > Hi, >> > >> > Please find the attached patch to fix the issue reported in RM #3559 (Far >> > too many mouse clicks to drill down in Browser) related to Tree Save State. >> > This RM was updated by the user with the issues in the browser tree state >> > save functionality with the reproduction steps. These issues have been >> > fixed in the attached patch. >> >> Thanks - whilst the patch seems to work (based on the description you >> sent me that I've pasted below for reference), I do see a problem. >> Basically, the first time I try to re-open a server that has a >> previously-saved state, the Databases node underneath it shows with an >> indefinite busy indicator. I can still use the tree under it - and if >> I then refresh the entire browser, the problem goes away and doesn't >> come back. Refreshing the node doesn't help though. >> > I have slightly changed the data structure, may be it is causing the issue. > Please find the attached updated patch with the fix. >> >> > The fixed issues: >> > >> > 1. Expand any database > Close the database node > Refresh the Server. >> > Issue - The closed database opens up even if we have closed before >> > Refreshing the server. >> > 2. Expand 3 to 4 databases till Table node with the same schema name (Ex; >> > Public) > Refresh the browser >> > Issue - Not all the Table nodes will expand, it will expand till >> > Schema only >> > 3. Expand any database till Table > Close the database node > Refresh the >> > Browser >> > Issue - When I open the database node, it does not open the tree till >> > Table node >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
Hi
Here's an updated patch as I've tweaked some of the wording. The screenshot
probably isn't the right resolution, but as we're replacing them anyway it
doesn't seem overly important. Feel free to fix if you like :-)
With quoting set to either All or Strings, everything looks good. With it
set to None, I still get an exception (below). The query I'm using is this:
SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text
Field separator: ,
Quote character: "
Replace null's with: NULL
Steps:
1) Run pgAdmin in Desktop mode. I'm running from within PyuCharms, using
the venv detailed below.
2) Open the Query Tool on a PostgreSQL 9.6.10 database, running on MacOS
10.14.1
3) Run the above query, wit quoting set to All and check the result in the
grid.
4) Download the CSV file and check.
5) Open Preferences and set quoting to Strings.
6) Download the CSV file and check.
7) Open Preferences and set quoting to None.
8) Download the CSV file *exception occurs*.
System info:
(pgadmin4) dpage@hal:*~/git/pgadmin4*$ python --version
Python 3.6.7
(pgadmin4) dpage@hal:*~/git/pgadmin4*$ pip freeze
alabaster==0.7.11
alembic==1.0.0
asn1crypto==0.24.0
Babel==2.6.0
bcrypt==3.1.4
blinker==1.4
certifi==2018.8.24
cffi==1.11.5
chardet==3.0.4
chromedriver-installer==0.0.6
click==6.7
cryptography==2.3
docutils==0.14
extras==1.0.0
fixtures==3.0.0
Flask==0.12.4
Flask-BabelEx==0.9.3
Flask-Gravatar==0.5.0
Flask-HTMLmin==1.3.2
Flask-Login==0.3.2
Flask-Mail==0.9.1
Flask-Migrate==2.1.1
Flask-Paranoid==0.2.0
Flask-Principal==0.4.0
Flask-Security==3.0.0
Flask-SQLAlchemy==2.3.2
Flask-WTF==0.14.2
html5lib==1.0.1
htmlmin==0.1.12
idna==2.7
imagesize==1.1.0
itsdangerous==0.24
Jinja2==2.10
linecache2==1.0.0
Mako==1.0.7
MarkupSafe==1.0
packaging==18.0
paramiko==2.4.1
passlib==1.7.1
pbr==3.1.1
psutil==5.4.8
psycopg2==2.7.5
pyasn1==0.4.4
pycodestyle==2.3.1
pycparser==2.18
pycrypto==2.6.1
Pygments==2.2.0
PyNaCl==1.2.1
pyparsing==2.2.2
pyperclip==1.6.4
pyrsistent==0.14.2
python-dateutil==2.7.3
python-editor==1.0.3
python-mimeparse==1.6.0
pytz==2018.3
requests==2.19.1
selenium==3.14.1
simplejson==3.13.2
six==1.11.0
snowballstemmer==1.2.1
speaklater==1.3
Sphinx==1.8.2
sphinxcontrib-websupport==1.1.0
SQLAlchemy==1.2.10
sqlparse==0.2.4
sshtunnel==0.1.4
testscenarios==0.5.0
testtools==2.3.0
traceback2==1.4.0
unittest2==1.1.0
urllib3==1.23
webencodings==0.5.1
Werkzeug==0.14.1
WTForms==2.1
Exception:
2018-12-21 11:47:28,995: SQL pgadmin: Execute (with server cursor) for
server #2 - CONN:8760231 (Query-id: 8649354):
SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text
2018-12-21 11:47:29,001: INFO werkzeug: 127.0.0.1 - - [21/Dec/2018
11:47:29] "GET
/sqleditor/query_tool/download/2133388?query=SELECT%20NULL%3A%3Atext%2C%201234%3A%3Aint%2C%20%27Foo%20bar%27%3A%3Atext%2C%20E%27Foo%5CnBar%27%3A%3Atext&filename=data-1545392848979.csv
HTTP/1.1" 500 -
2018-12-21 11:47:29,003: ERROR werkzeug: Error on request:
Traceback (most recent call last):
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py",
line 270, in run_wsgi
execute(self.server.app)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py",
line 260, in execute
for data in application_iter:
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wsgi.py",
line 870, in __next__
return self._next()
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wrappers.py",
line 82, in _iter_encoded
for item in iterable:
File
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/connection.py",
line 848, in gen
csv_writer.writerows(results)
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 761, in
writerows
return self.writer.writerows(map(self._dict_to_list, rowdicts))
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 268, in
writerows
self.writerow(row)
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 261, in
writerow
row = [self.strategy.prepare(field, only=only) for field in row]
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 261, in
row = [self.strategy.prepare(field, only=only) for field in row]
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 142, in
prepare
raise Error('No escapechar is set')
_csv.Error: No escapechar is set
On Thu, Dec 20, 2018 at 1:05 PM Akshay Joshi
wrote:
> Hi Dave
>
> On Thu, Dec 20, 2018 at 5:12 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Dec 20, 2018 at 4:48 PM Dave Page wrote:
>>
>>> Hi
>>>
>>> On Thu, Dec 20, 2018 at 10:09 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
Hi Dave
On Thu, Dec 20, 2018 at 3:08 PM Dave Page wrote:
> Hi
>
> When testing with quoting set to None, quote = " and delimiter = , I
> get the following exception when I
pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Improvement in the look and feel of the whole application
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74
Modified Files
--
web/package.json |2 +-
.../static/js/fts_configuration.js |2 +-
.../databases/schemas/functions/__init__.py|4 +-
.../function => static}/css/function.css |0
.../templates/trigger_function/css/function.css|3 -
.../{templates/edbfunc => static}/css/edbfunc.css |0
.../static/js/exclusion_constraint.js | 18 +-
.../foreign_key/static/js/foreign_key.js | 17 +-
.../schemas/tables/rules/static/css/rule.css |7 +
.../tables/rules/templates/rules/css/rule.css |8 -
.../databases/schemas/views/static/css/view.css|7 +
.../schemas/views/templates/mview/css/mview.css|4 -
.../schemas/views/templates/view/css/view.css |4 -
.../pgagent/schedules/static/js/pga_schedule.js|3 +-
.../servers/pgagent/static/css/pga_job.css |3 +
.../pgagent/templates/pga_job/css/pga_job.css | 13 -
.../server_groups/servers/static/css/servers.css |4 +
.../server_groups/servers/static/js/server.js | 22 +-
.../server_groups/servers/static/js/variable.js|4 +-
.../servers/tablespaces/static/js/tablespace.js| 13 +-
.../servers/templates/css/servers.css |4 -
web/pgadmin/browser/static/css/browser.css | 13 -
web/pgadmin/browser/static/css/wizard.css | 21 +-
web/pgadmin/browser/static/js/browser.js | 26 +-
web/pgadmin/browser/static/js/collection.js| 16 +-
web/pgadmin/browser/static/js/keyboard.js | 14 +-
web/pgadmin/browser/static/js/menu.js | 28 +-
web/pgadmin/browser/static/js/node.js | 53 +-
web/pgadmin/browser/static/js/node.ui.js |4 +-
web/pgadmin/browser/static/js/panel.js | 15 +-
web/pgadmin/browser/static/js/toolbar.js |3 -
web/pgadmin/browser/static/js/wizard.js| 58 +-
web/pgadmin/browser/static/scss/_browser.scss | 43 +-
web/pgadmin/browser/static/scss/_wizard.scss | 41 +-
web/pgadmin/browser/templates/browser/css/node.css |2 +-
web/pgadmin/browser/templates/browser/index.html |9 +-
web/pgadmin/dashboard/__init__.py |2 +-
web/pgadmin/dashboard/static/css/dashboard.css | 21 +-
web/pgadmin/dashboard/static/js/dashboard.js | 120 +-
web/pgadmin/dashboard/static/scss/_dashboard.scss | 44 +-
.../templates/dashboard/database_dashboard.html| 171 ++-
.../templates/dashboard/server_dashboard.html | 197 ++-
.../templates/dashboard/welcome_dashboard.html | 30 +-
web/pgadmin/feature_tests/browser_tool_bar_test.py | 23 +-
web/pgadmin/feature_tests/file_manager_test.py | 23 +-
.../feature_tests/keyboard_shortcut_test.py|5 +-
.../feature_tests/pg_datatype_validation_test.py |5 +-
.../pg_utilities_backup_restore_test.py| 28 +-
.../feature_tests/pg_utilities_maintenance_test.py | 16 +-
.../feature_tests/query_tool_journey_test.py |5 +-
web/pgadmin/feature_tests/query_tool_tests.py | 117 +-
web/pgadmin/feature_tests/view_data_dml_queries.py | 16 +-
.../misc/bgprocess/static/css/bgprocess.css| 11 -
web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 173 ++-
.../misc/bgprocess/static/scss/_bgprocess.scss | 81 +-
web/pgadmin/misc/depends/static/js/depends.js |3 +-
.../misc/file_manager/static/css/file_manager.css | 141 +-
.../misc/file_manager/static/js/create_dialogue.js |9 +-
.../misc/file_manager/static/js/select_dialogue.js | 19 +-
web/pgadmin/misc/file_manager/static/js/utility.js | 77 +-
.../file_manager/static/scss/_file_manager.scss| 157 +--
.../file_manager/templates/file_manager/index.html | 95 +-
.../misc/statistics/static/js/statistics.js|3 +-
web/pgadmin/preferences/static/css/preferences.css | 14 -
web/pgadmin/preferences/static/js/preferences.js | 31 +-
.../preferences/
Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
Hi Dave
Can you please attached the updated patch with your changes. I'll try to
fix the exception.
On Fri, Dec 21, 2018 at 3:57 AM Dave Page wrote:
> Hi
>
> Here's an updated patch as I've tweaked some of the wording. The
> screenshot probably isn't the right resolution, but as we're replacing them
> anyway it doesn't seem overly important. Feel free to fix if you like :-)
>
> With quoting set to either All or Strings, everything looks good. With it
> set to None, I still get an exception (below). The query I'm using is this:
>
> SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text
>
> Field separator: ,
> Quote character: "
> Replace null's with: NULL
>
> Steps:
>
> 1) Run pgAdmin in Desktop mode. I'm running from within PyuCharms, using
> the venv detailed below.
> 2) Open the Query Tool on a PostgreSQL 9.6.10 database, running on MacOS
> 10.14.1
> 3) Run the above query, wit quoting set to All and check the result in the
> grid.
> 4) Download the CSV file and check.
> 5) Open Preferences and set quoting to Strings.
> 6) Download the CSV file and check.
> 7) Open Preferences and set quoting to None.
> 8) Download the CSV file *exception occurs*.
>
>
> System info:
>
> (pgadmin4) dpage@hal:*~/git/pgadmin4*$ python --version
>
> Python 3.6.7
>
> (pgadmin4) dpage@hal:*~/git/pgadmin4*$ pip freeze
>
> alabaster==0.7.11
>
> alembic==1.0.0
>
> asn1crypto==0.24.0
>
> Babel==2.6.0
>
> bcrypt==3.1.4
>
> blinker==1.4
>
> certifi==2018.8.24
>
> cffi==1.11.5
>
> chardet==3.0.4
>
> chromedriver-installer==0.0.6
>
> click==6.7
>
> cryptography==2.3
>
> docutils==0.14
>
> extras==1.0.0
>
> fixtures==3.0.0
>
> Flask==0.12.4
>
> Flask-BabelEx==0.9.3
>
> Flask-Gravatar==0.5.0
>
> Flask-HTMLmin==1.3.2
>
> Flask-Login==0.3.2
>
> Flask-Mail==0.9.1
>
> Flask-Migrate==2.1.1
>
> Flask-Paranoid==0.2.0
>
> Flask-Principal==0.4.0
>
> Flask-Security==3.0.0
>
> Flask-SQLAlchemy==2.3.2
>
> Flask-WTF==0.14.2
>
> html5lib==1.0.1
>
> htmlmin==0.1.12
>
> idna==2.7
>
> imagesize==1.1.0
>
> itsdangerous==0.24
>
> Jinja2==2.10
>
> linecache2==1.0.0
>
> Mako==1.0.7
>
> MarkupSafe==1.0
>
> packaging==18.0
>
> paramiko==2.4.1
>
> passlib==1.7.1
>
> pbr==3.1.1
>
> psutil==5.4.8
>
> psycopg2==2.7.5
>
> pyasn1==0.4.4
>
> pycodestyle==2.3.1
>
> pycparser==2.18
>
> pycrypto==2.6.1
>
> Pygments==2.2.0
>
> PyNaCl==1.2.1
>
> pyparsing==2.2.2
>
> pyperclip==1.6.4
>
> pyrsistent==0.14.2
>
> python-dateutil==2.7.3
>
> python-editor==1.0.3
>
> python-mimeparse==1.6.0
>
> pytz==2018.3
>
> requests==2.19.1
>
> selenium==3.14.1
>
> simplejson==3.13.2
>
> six==1.11.0
>
> snowballstemmer==1.2.1
>
> speaklater==1.3
>
> Sphinx==1.8.2
>
> sphinxcontrib-websupport==1.1.0
>
> SQLAlchemy==1.2.10
>
> sqlparse==0.2.4
>
> sshtunnel==0.1.4
>
> testscenarios==0.5.0
>
> testtools==2.3.0
>
> traceback2==1.4.0
>
> unittest2==1.1.0
>
> urllib3==1.23
>
> webencodings==0.5.1
>
> Werkzeug==0.14.1
>
> WTForms==2.1
>
> Exception:
>
> 2018-12-21 11:47:28,995: SQL pgadmin: Execute (with server cursor) for
> server #2 - CONN:8760231 (Query-id: 8649354):
> SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text
> 2018-12-21 11:47:29,001: INFO werkzeug: 127.0.0.1 - - [21/Dec/2018
> 11:47:29] "GET
> /sqleditor/query_tool/download/2133388?query=SELECT%20NULL%3A%3Atext%2C%201234%3A%3Aint%2C%20%27Foo%20bar%27%3A%3Atext%2C%20E%27Foo%5CnBar%27%3A%3Atext&filename=data-1545392848979.csv
> HTTP/1.1" 500 -
> 2018-12-21 11:47:29,003: ERROR werkzeug: Error on request:
> Traceback (most recent call last):
> File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py",
> line 270, in run_wsgi
> execute(self.server.app)
> File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py",
> line 260, in execute
> for data in application_iter:
> File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wsgi.py",
> line 870, in __next__
> return self._next()
> File
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wrappers.py",
> line 82, in _iter_encoded
> for item in iterable:
> File
> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/connection.py",
> line 848, in gen
> csv_writer.writerows(results)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 761, in
> writerows
> return self.writer.writerows(map(self._dict_to_list, rowdicts))
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 268, in
> writerows
> self.writerow(row)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 261, in
> writerow
> row = [self.strategy.prepare(field, only=only) for field in row]
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 261, in
>
> row = [self.strategy.prepare(field, only=only) for field in row]
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 142, in
> prepare
> raise Error('No escapechar is set')
> _csv.Error: No escapechar is set
>
> O
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Nice! Thanks Ashesh.
Some small issues I spotted:
- The font looks somewhat small. How does it compare in size to, say,
Gmail? I think it needs to be increased to at least that size.
- Dialogues have 2 close buttons next to each other in the top-right.
Looks like an icon and a text version?
- Why do some Preferences panels use alternate line colouring, whilst
others don't? I suspect it's because some are actually tables under
the hood? I think we need consistency there.
- The Maintenance dialogue looks terrible - it needs to be made much
more compact. I also seem to be getting a failure to create
maintenance jobs (backups etc work fine).
- I think the buttons on the Browser need borders to match other buttons.
Thanks!
On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi
wrote:
>
> Improvement in the look and feel of the whole application
>
> Changed the SCSS/CSS for the below third party libraries to adopt the
> new look 'n' feel:
> - wcDocker
> - Alertify dialogs, and notifications
> - AciTree
> - Bootstrap Navbar
> - Bootstrap Tabs
> - Bootstrap Drop-Down menu
> - Backgrid
> - Select2
>
> Adopated the new the look 'n' feel for the dialogs, wizard, properties,
> tab panels, tabs, fieldset, subnode control, spinner control, HTML
> table, and other form controls.
>
> - Font is changed to Roboto
> - Using SCSS variables to define the look 'n' feel
> - Designer background images for the Login, and Forget password pages in
> 'web' mode
> - Improved the look 'n' feel for the key selection in the preferences
> dialog
> - Table classes consistency changes across the application
> - File Open and Save dialog list view changes
>
> Author(s): Aditya Toshniwal & Khushboo Vashi
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74
>
> Modified Files
> --
> web/package.json |2 +-
> .../static/js/fts_configuration.js |2 +-
> .../databases/schemas/functions/__init__.py|4 +-
> .../function => static}/css/function.css |0
> .../templates/trigger_function/css/function.css|3 -
> .../{templates/edbfunc => static}/css/edbfunc.css |0
> .../static/js/exclusion_constraint.js | 18 +-
> .../foreign_key/static/js/foreign_key.js | 17 +-
> .../schemas/tables/rules/static/css/rule.css |7 +
> .../tables/rules/templates/rules/css/rule.css |8 -
> .../databases/schemas/views/static/css/view.css|7 +
> .../schemas/views/templates/mview/css/mview.css|4 -
> .../schemas/views/templates/view/css/view.css |4 -
> .../pgagent/schedules/static/js/pga_schedule.js|3 +-
> .../servers/pgagent/static/css/pga_job.css |3 +
> .../pgagent/templates/pga_job/css/pga_job.css | 13 -
> .../server_groups/servers/static/css/servers.css |4 +
> .../server_groups/servers/static/js/server.js | 22 +-
> .../server_groups/servers/static/js/variable.js|4 +-
> .../servers/tablespaces/static/js/tablespace.js| 13 +-
> .../servers/templates/css/servers.css |4 -
> web/pgadmin/browser/static/css/browser.css | 13 -
> web/pgadmin/browser/static/css/wizard.css | 21 +-
> web/pgadmin/browser/static/js/browser.js | 26 +-
> web/pgadmin/browser/static/js/collection.js| 16 +-
> web/pgadmin/browser/static/js/keyboard.js | 14 +-
> web/pgadmin/browser/static/js/menu.js | 28 +-
> web/pgadmin/browser/static/js/node.js | 53 +-
> web/pgadmin/browser/static/js/node.ui.js |4 +-
> web/pgadmin/browser/static/js/panel.js | 15 +-
> web/pgadmin/browser/static/js/toolbar.js |3 -
> web/pgadmin/browser/static/js/wizard.js| 58 +-
> web/pgadmin/browser/static/scss/_browser.scss | 43 +-
> web/pgadmin/browser/static/scss/_wizard.scss | 41 +-
> web/pgadmin/browser/templates/browser/css/node.css |2 +-
> web/pgadmin/browser/templates/browser/index.html |9 +-
> web/pgadmin/dashboard/__init__.py |2 +-
> web/pgadmin/dashboard/static/css/dashboard.css | 21 +-
> web/pgadmin/dashboard/static/js/dashboard.js | 120 +-
> web/pgadmin/dashboard/static/scss/_dashboard.scss | 44 +-
> .../templates/dashboard/database_dashboard.html| 171 ++-
> .../templates/dashboard/server_dashboard.html | 197 ++-
> .../templates/dashboard/welcome_dashboard.html | 30 +-
> web/pgadmin/feature_tests/browser_tool_bar_test.py | 23 +-
> web/pgadmin/feature_tests/file_manager_test.py | 23 +-
> .../feature_tests/keyboard_shortcut_test.py|5 +-
> .../feature_tests/pg_datatype_validation_test.py |5 +-
> .../pg_utilities_backup_restore_test.py| 28 +-
> .../feature_tests/pg_utilities_maintenance_test.py | 16 +-
> .../feature_tests/query_tool_jo
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Hi Dave,
On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote:
> Nice! Thanks Ashesh.
>
> Some small issues I spotted:
>
> - The font looks somewhat small. How does it compare in size to, say,
> Gmail? I think it needs to be increased to at least that size.
>
Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We are
using 0.875rem
(14px) for main navbar links and 0.815rem(13.04px) for all other text.
>
> - Dialogues have 2 close buttons next to each other in the top-right.
> Looks like an icon and a text version?
>
You need to do a yarn install. wcDocker code is changed to fix that.
>
> - Why do some Preferences panels use alternate line colouring, whilst
> others don't? I suspect it's because some are actually tables under
> the hood? I think we need consistency there.
>
Noted.
>
> - The Maintenance dialogue looks terrible - it needs to be made much
> more compact. I also seem to be getting a failure to create
> maintenance jobs (backups etc work fine).
>
Noted.
>
> - I think the buttons on the Browser need borders to match other buttons.
>
It is made consistent with other wcDocker buttons like close, right arrow,
left arrow. However, we can make it look like other buttons.
>
> Thanks!
>
> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi
> wrote:
> >
> > Improvement in the look and feel of the whole application
> >
> > Changed the SCSS/CSS for the below third party libraries to adopt the
> > new look 'n' feel:
> > - wcDocker
> > - Alertify dialogs, and notifications
> > - AciTree
> > - Bootstrap Navbar
> > - Bootstrap Tabs
> > - Bootstrap Drop-Down menu
> > - Backgrid
> > - Select2
> >
> > Adopated the new the look 'n' feel for the dialogs, wizard, properties,
> > tab panels, tabs, fieldset, subnode control, spinner control, HTML
> > table, and other form controls.
> >
> > - Font is changed to Roboto
> > - Using SCSS variables to define the look 'n' feel
> > - Designer background images for the Login, and Forget password pages in
> > 'web' mode
> > - Improved the look 'n' feel for the key selection in the preferences
> > dialog
> > - Table classes consistency changes across the application
> > - File Open and Save dialog list view changes
> >
> > Author(s): Aditya Toshniwal & Khushboo Vashi
> >
> > Branch
> > --
> > master
> >
> > Details
> > ---
> >
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74
> >
> > Modified Files
> > --
> > web/package.json |2 +-
> > .../static/js/fts_configuration.js |2 +-
> > .../databases/schemas/functions/__init__.py|4 +-
> > .../function => static}/css/function.css |0
> > .../templates/trigger_function/css/function.css|3 -
> > .../{templates/edbfunc => static}/css/edbfunc.css |0
> > .../static/js/exclusion_constraint.js | 18 +-
> > .../foreign_key/static/js/foreign_key.js | 17 +-
> > .../schemas/tables/rules/static/css/rule.css |7 +
> > .../tables/rules/templates/rules/css/rule.css |8 -
> > .../databases/schemas/views/static/css/view.css|7 +
> > .../schemas/views/templates/mview/css/mview.css|4 -
> > .../schemas/views/templates/view/css/view.css |4 -
> > .../pgagent/schedules/static/js/pga_schedule.js|3 +-
> > .../servers/pgagent/static/css/pga_job.css |3 +
> > .../pgagent/templates/pga_job/css/pga_job.css | 13 -
> > .../server_groups/servers/static/css/servers.css |4 +
> > .../server_groups/servers/static/js/server.js | 22 +-
> > .../server_groups/servers/static/js/variable.js|4 +-
> > .../servers/tablespaces/static/js/tablespace.js| 13 +-
> > .../servers/templates/css/servers.css |4 -
> > web/pgadmin/browser/static/css/browser.css | 13 -
> > web/pgadmin/browser/static/css/wizard.css | 21 +-
> > web/pgadmin/browser/static/js/browser.js | 26 +-
> > web/pgadmin/browser/static/js/collection.js| 16 +-
> > web/pgadmin/browser/static/js/keyboard.js | 14 +-
> > web/pgadmin/browser/static/js/menu.js | 28 +-
> > web/pgadmin/browser/static/js/node.js | 53 +-
> > web/pgadmin/browser/static/js/node.ui.js |4 +-
> > web/pgadmin/browser/static/js/panel.js | 15 +-
> > web/pgadmin/browser/static/js/toolbar.js |3 -
> > web/pgadmin/browser/static/js/wizard.js| 58 +-
> > web/pgadmin/browser/static/scss/_browser.scss | 43 +-
> > web/pgadmin/browser/static/scss/_wizard.scss | 41 +-
> > web/pgadmin/browser/templates/browser/css/node.css |2 +-
> > web/pgadmin/browser/templates/browser/index.html |9 +-
> > web/pgadmin/dashboard/__init__.py |2 +-
> > web/pgadmin/dashboard/static/css/dashboard.css | 21 +-
> > web/pgadmin/dashboard/static/js/dashboard.js | 120 +-
> > web/pgadmin/d
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Hi
On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal
wrote:
>
> Hi Dave,
>
> On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote:
>>
>> Nice! Thanks Ashesh.
>>
>> Some small issues I spotted:
>>
>> - The font looks somewhat small. How does it compare in size to, say,
>> Gmail? I think it needs to be increased to at least that size.
>
> Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We are using
> 0.875rem (14px) for main navbar links and 0.815rem(13.04px) for all other
> text.
Let's increase the default to 0.875, and make the main links
proportionally bigger.
>> - Dialogues have 2 close buttons next to each other in the top-right.
>> Looks like an icon and a text version?
>
> You need to do a yarn install. wcDocker code is changed to fix that.
Yup, that fixed it.
>> - Why do some Preferences panels use alternate line colouring, whilst
>> others don't? I suspect it's because some are actually tables under
>> the hood? I think we need consistency there.
>
> Noted.
>>
>>
>> - The Maintenance dialogue looks terrible - it needs to be made much
>> more compact. I also seem to be getting a failure to create
>> maintenance jobs (backups etc work fine).
>
> Noted.
>>
>>
>> - I think the buttons on the Browser need borders to match other buttons.
>
> It is made consistent with other wcDocker buttons like close, right arrow,
> left arrow. However, we can make it look like other buttons.
I think they're a different class of buttons - control/navigation vs.
function. I think we should make this change as the browser buttons
really are a toolbar just like the larger on on the query tool.
Thanks!
>> Thanks!
>>
>> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi
>> wrote:
>> >
>> > Improvement in the look and feel of the whole application
>> >
>> > Changed the SCSS/CSS for the below third party libraries to adopt the
>> > new look 'n' feel:
>> > - wcDocker
>> > - Alertify dialogs, and notifications
>> > - AciTree
>> > - Bootstrap Navbar
>> > - Bootstrap Tabs
>> > - Bootstrap Drop-Down menu
>> > - Backgrid
>> > - Select2
>> >
>> > Adopated the new the look 'n' feel for the dialogs, wizard, properties,
>> > tab panels, tabs, fieldset, subnode control, spinner control, HTML
>> > table, and other form controls.
>> >
>> > - Font is changed to Roboto
>> > - Using SCSS variables to define the look 'n' feel
>> > - Designer background images for the Login, and Forget password pages in
>> > 'web' mode
>> > - Improved the look 'n' feel for the key selection in the preferences
>> > dialog
>> > - Table classes consistency changes across the application
>> > - File Open and Save dialog list view changes
>> >
>> > Author(s): Aditya Toshniwal & Khushboo Vashi
>> >
>> > Branch
>> > --
>> > master
>> >
>> > Details
>> > ---
>> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74
>> >
>> > Modified Files
>> > --
>> > web/package.json |2 +-
>> > .../static/js/fts_configuration.js |2 +-
>> > .../databases/schemas/functions/__init__.py|4 +-
>> > .../function => static}/css/function.css |0
>> > .../templates/trigger_function/css/function.css|3 -
>> > .../{templates/edbfunc => static}/css/edbfunc.css |0
>> > .../static/js/exclusion_constraint.js | 18 +-
>> > .../foreign_key/static/js/foreign_key.js | 17 +-
>> > .../schemas/tables/rules/static/css/rule.css |7 +
>> > .../tables/rules/templates/rules/css/rule.css |8 -
>> > .../databases/schemas/views/static/css/view.css|7 +
>> > .../schemas/views/templates/mview/css/mview.css|4 -
>> > .../schemas/views/templates/view/css/view.css |4 -
>> > .../pgagent/schedules/static/js/pga_schedule.js|3 +-
>> > .../servers/pgagent/static/css/pga_job.css |3 +
>> > .../pgagent/templates/pga_job/css/pga_job.css | 13 -
>> > .../server_groups/servers/static/css/servers.css |4 +
>> > .../server_groups/servers/static/js/server.js | 22 +-
>> > .../server_groups/servers/static/js/variable.js|4 +-
>> > .../servers/tablespaces/static/js/tablespace.js| 13 +-
>> > .../servers/templates/css/servers.css |4 -
>> > web/pgadmin/browser/static/css/browser.css | 13 -
>> > web/pgadmin/browser/static/css/wizard.css | 21 +-
>> > web/pgadmin/browser/static/js/browser.js | 26 +-
>> > web/pgadmin/browser/static/js/collection.js| 16 +-
>> > web/pgadmin/browser/static/js/keyboard.js | 14 +-
>> > web/pgadmin/browser/static/js/menu.js | 28 +-
>> > web/pgadmin/browser/static/js/node.js | 53 +-
>> > web/pgadmin/browser/static/js/node.ui.js |4 +-
>> > web/pgadmin/browser/static/js/panel.js | 15 +-
>> > web/pgadmin/browser/static/js/toolbar.js |3 -
>> > web/pgadmin/browser/static/js/wizard.
Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
Hi Looks good - I just found one issue; please go ahead and commit (with a release notes update) when fixed. - If I set the NULL replacement value to an empty string, it defaults back to NULL. It's therefore not possible to replace null values with an empty value. Thanks! On Fri, Dec 21, 2018 at 12:57 PM Akshay Joshi wrote: > Hi Dave > > I have modified the condition, it won't through any exception. Attached is > the updated patch, please review it. > > On Fri, Dec 21, 2018 at 4:22 AM Dave Page wrote: > >> Sorry! Here is is. >> >> On Fri, Dec 21, 2018 at 12:12 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> Can you please attached the updated patch with your changes. I'll try to >>> fix the exception. >>> >>> On Fri, Dec 21, 2018 at 3:57 AM Dave Page wrote: >>> Hi Here's an updated patch as I've tweaked some of the wording. The screenshot probably isn't the right resolution, but as we're replacing them anyway it doesn't seem overly important. Feel free to fix if you like :-) With quoting set to either All or Strings, everything looks good. With it set to None, I still get an exception (below). The query I'm using is this: SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text Field separator: , Quote character: " Replace null's with: NULL Steps: 1) Run pgAdmin in Desktop mode. I'm running from within PyuCharms, using the venv detailed below. 2) Open the Query Tool on a PostgreSQL 9.6.10 database, running on MacOS 10.14.1 3) Run the above query, wit quoting set to All and check the result in the grid. 4) Download the CSV file and check. 5) Open Preferences and set quoting to Strings. 6) Download the CSV file and check. 7) Open Preferences and set quoting to None. 8) Download the CSV file *exception occurs*. System info: (pgadmin4) dpage@hal:*~/git/pgadmin4*$ python --version Python 3.6.7 (pgadmin4) dpage@hal:*~/git/pgadmin4*$ pip freeze alabaster==0.7.11 alembic==1.0.0 asn1crypto==0.24.0 Babel==2.6.0 bcrypt==3.1.4 blinker==1.4 certifi==2018.8.24 cffi==1.11.5 chardet==3.0.4 chromedriver-installer==0.0.6 click==6.7 cryptography==2.3 docutils==0.14 extras==1.0.0 fixtures==3.0.0 Flask==0.12.4 Flask-BabelEx==0.9.3 Flask-Gravatar==0.5.0 Flask-HTMLmin==1.3.2 Flask-Login==0.3.2 Flask-Mail==0.9.1 Flask-Migrate==2.1.1 Flask-Paranoid==0.2.0 Flask-Principal==0.4.0 Flask-Security==3.0.0 Flask-SQLAlchemy==2.3.2 Flask-WTF==0.14.2 html5lib==1.0.1 htmlmin==0.1.12 idna==2.7 imagesize==1.1.0 itsdangerous==0.24 Jinja2==2.10 linecache2==1.0.0 Mako==1.0.7 MarkupSafe==1.0 packaging==18.0 paramiko==2.4.1 passlib==1.7.1 pbr==3.1.1 psutil==5.4.8 psycopg2==2.7.5 pyasn1==0.4.4 pycodestyle==2.3.1 pycparser==2.18 pycrypto==2.6.1 Pygments==2.2.0 PyNaCl==1.2.1 pyparsing==2.2.2 pyperclip==1.6.4 pyrsistent==0.14.2 python-dateutil==2.7.3 python-editor==1.0.3 python-mimeparse==1.6.0 pytz==2018.3 requests==2.19.1 selenium==3.14.1 simplejson==3.13.2 six==1.11.0 snowballstemmer==1.2.1 speaklater==1.3 Sphinx==1.8.2 sphinxcontrib-websupport==1.1.0 SQLAlchemy==1.2.10 sqlparse==0.2.4 sshtunnel==0.1.4 testscenarios==0.5.0 testtools==2.3.0 traceback2==1.4.0 unittest2==1.1.0 urllib3==1.23 webencodings==0.5.1 Werkzeug==0.14.1 WTForms==2.1 Exception: 2018-12-21 11:47:28,995: SQL pgadmin: Execute (with server cursor) for server #2 - CONN:8760231 (Query-id: 8649354): SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text 2018-12-21 11:47:29,001: INFO werkzeug: 127.0.0.1 - - [21/Dec/2018 11:47:29] "GET /sqleditor/query_tool/download/2133388?query=SELECT%20NULL%3A%3Atext%2C%201234%3A%3Aint%2C%20%27Foo%20bar%27%3A%3Atext%2C%20E%27Foo%5CnBar%27%3A%3Atext&filename=data-1545392848979.csv HTTP/1.1" 500 - 2018-12-21 11:47:29,003: ERROR werkzeug: Error on request: Traceback (most recent call last): File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", line 270, in run_wsgi execute(self.server.app) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-pac
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
One other issue: I'm seeing that standard sized dialogues (e.g. the
Server or Database Properties dialogues) are wrapping their labels and
controls at the default size. That should not be the case.
On Fri, Dec 21, 2018 at 12:46 PM Dave Page wrote:
>
> Hi
>
> On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal
> wrote:
> >
> > Hi Dave,
> >
> > On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote:
> >>
> >> Nice! Thanks Ashesh.
> >>
> >> Some small issues I spotted:
> >>
> >> - The font looks somewhat small. How does it compare in size to, say,
> >> Gmail? I think it needs to be increased to at least that size.
> >
> > Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We are using
> > 0.875rem (14px) for main navbar links and 0.815rem(13.04px) for all other
> > text.
>
> Let's increase the default to 0.875, and make the main links
> proportionally bigger.
>
> >> - Dialogues have 2 close buttons next to each other in the top-right.
> >> Looks like an icon and a text version?
> >
> > You need to do a yarn install. wcDocker code is changed to fix that.
>
> Yup, that fixed it.
>
> >> - Why do some Preferences panels use alternate line colouring, whilst
> >> others don't? I suspect it's because some are actually tables under
> >> the hood? I think we need consistency there.
> >
> > Noted.
> >>
> >>
> >> - The Maintenance dialogue looks terrible - it needs to be made much
> >> more compact. I also seem to be getting a failure to create
> >> maintenance jobs (backups etc work fine).
> >
> > Noted.
> >>
> >>
> >> - I think the buttons on the Browser need borders to match other buttons.
> >
> > It is made consistent with other wcDocker buttons like close, right arrow,
> > left arrow. However, we can make it look like other buttons.
>
> I think they're a different class of buttons - control/navigation vs.
> function. I think we should make this change as the browser buttons
> really are a toolbar just like the larger on on the query tool.
>
> Thanks!
>
> >> Thanks!
> >>
> >> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi
> >> wrote:
> >> >
> >> > Improvement in the look and feel of the whole application
> >> >
> >> > Changed the SCSS/CSS for the below third party libraries to adopt the
> >> > new look 'n' feel:
> >> > - wcDocker
> >> > - Alertify dialogs, and notifications
> >> > - AciTree
> >> > - Bootstrap Navbar
> >> > - Bootstrap Tabs
> >> > - Bootstrap Drop-Down menu
> >> > - Backgrid
> >> > - Select2
> >> >
> >> > Adopated the new the look 'n' feel for the dialogs, wizard, properties,
> >> > tab panels, tabs, fieldset, subnode control, spinner control, HTML
> >> > table, and other form controls.
> >> >
> >> > - Font is changed to Roboto
> >> > - Using SCSS variables to define the look 'n' feel
> >> > - Designer background images for the Login, and Forget password pages in
> >> > 'web' mode
> >> > - Improved the look 'n' feel for the key selection in the preferences
> >> > dialog
> >> > - Table classes consistency changes across the application
> >> > - File Open and Save dialog list view changes
> >> >
> >> > Author(s): Aditya Toshniwal & Khushboo Vashi
> >> >
> >> > Branch
> >> > --
> >> > master
> >> >
> >> > Details
> >> > ---
> >> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74
> >> >
> >> > Modified Files
> >> > --
> >> > web/package.json |2 +-
> >> > .../static/js/fts_configuration.js |2 +-
> >> > .../databases/schemas/functions/__init__.py|4 +-
> >> > .../function => static}/css/function.css |0
> >> > .../templates/trigger_function/css/function.css|3 -
> >> > .../{templates/edbfunc => static}/css/edbfunc.css |0
> >> > .../static/js/exclusion_constraint.js | 18 +-
> >> > .../foreign_key/static/js/foreign_key.js | 17 +-
> >> > .../schemas/tables/rules/static/css/rule.css |7 +
> >> > .../tables/rules/templates/rules/css/rule.css |8 -
> >> > .../databases/schemas/views/static/css/view.css|7 +
> >> > .../schemas/views/templates/mview/css/mview.css|4 -
> >> > .../schemas/views/templates/view/css/view.css |4 -
> >> > .../pgagent/schedules/static/js/pga_schedule.js|3 +-
> >> > .../servers/pgagent/static/css/pga_job.css |3 +
> >> > .../pgagent/templates/pga_job/css/pga_job.css | 13 -
> >> > .../server_groups/servers/static/css/servers.css |4 +
> >> > .../server_groups/servers/static/js/server.js | 22 +-
> >> > .../server_groups/servers/static/js/variable.js|4 +-
> >> > .../servers/tablespaces/static/js/tablespace.js| 13 +-
> >> > .../servers/templates/css/servers.css |4 -
> >> > web/pgadmin/browser/static/css/browser.css | 13 -
> >> > web/pgadmin/browser/static/css/wizard.css | 21 +-
> >> > web/pgadmin/browser/static/js/browser.js | 26 +-
> >> > web/pgad
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
And hopefully finally; it looks like the pop-out text editor on the
query tool results grid hasn't been updated.
On Fri, Dec 21, 2018 at 1:59 PM Dave Page wrote:
>
> One other issue: I'm seeing that standard sized dialogues (e.g. the
> Server or Database Properties dialogues) are wrapping their labels and
> controls at the default size. That should not be the case.
>
> On Fri, Dec 21, 2018 at 12:46 PM Dave Page wrote:
> >
> > Hi
> >
> > On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal
> > wrote:
> > >
> > > Hi Dave,
> > >
> > > On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote:
> > >>
> > >> Nice! Thanks Ashesh.
> > >>
> > >> Some small issues I spotted:
> > >>
> > >> - The font looks somewhat small. How does it compare in size to, say,
> > >> Gmail? I think it needs to be increased to at least that size.
> > >
> > > Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We are using
> > > 0.875rem (14px) for main navbar links and 0.815rem(13.04px) for all
> > > other text.
> >
> > Let's increase the default to 0.875, and make the main links
> > proportionally bigger.
> >
> > >> - Dialogues have 2 close buttons next to each other in the top-right.
> > >> Looks like an icon and a text version?
> > >
> > > You need to do a yarn install. wcDocker code is changed to fix that.
> >
> > Yup, that fixed it.
> >
> > >> - Why do some Preferences panels use alternate line colouring, whilst
> > >> others don't? I suspect it's because some are actually tables under
> > >> the hood? I think we need consistency there.
> > >
> > > Noted.
> > >>
> > >>
> > >> - The Maintenance dialogue looks terrible - it needs to be made much
> > >> more compact. I also seem to be getting a failure to create
> > >> maintenance jobs (backups etc work fine).
> > >
> > > Noted.
> > >>
> > >>
> > >> - I think the buttons on the Browser need borders to match other buttons.
> > >
> > > It is made consistent with other wcDocker buttons like close, right
> > > arrow, left arrow. However, we can make it look like other buttons.
> >
> > I think they're a different class of buttons - control/navigation vs.
> > function. I think we should make this change as the browser buttons
> > really are a toolbar just like the larger on on the query tool.
> >
> > Thanks!
> >
> > >> Thanks!
> > >>
> > >> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi
> > >> wrote:
> > >> >
> > >> > Improvement in the look and feel of the whole application
> > >> >
> > >> > Changed the SCSS/CSS for the below third party libraries to adopt the
> > >> > new look 'n' feel:
> > >> > - wcDocker
> > >> > - Alertify dialogs, and notifications
> > >> > - AciTree
> > >> > - Bootstrap Navbar
> > >> > - Bootstrap Tabs
> > >> > - Bootstrap Drop-Down menu
> > >> > - Backgrid
> > >> > - Select2
> > >> >
> > >> > Adopated the new the look 'n' feel for the dialogs, wizard, properties,
> > >> > tab panels, tabs, fieldset, subnode control, spinner control, HTML
> > >> > table, and other form controls.
> > >> >
> > >> > - Font is changed to Roboto
> > >> > - Using SCSS variables to define the look 'n' feel
> > >> > - Designer background images for the Login, and Forget password pages
> > >> > in
> > >> > 'web' mode
> > >> > - Improved the look 'n' feel for the key selection in the preferences
> > >> > dialog
> > >> > - Table classes consistency changes across the application
> > >> > - File Open and Save dialog list view changes
> > >> >
> > >> > Author(s): Aditya Toshniwal & Khushboo Vashi
> > >> >
> > >> > Branch
> > >> > --
> > >> > master
> > >> >
> > >> > Details
> > >> > ---
> > >> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74
> > >> >
> > >> > Modified Files
> > >> > --
> > >> > web/package.json |2 +-
> > >> > .../static/js/fts_configuration.js |2 +-
> > >> > .../databases/schemas/functions/__init__.py|4 +-
> > >> > .../function => static}/css/function.css |0
> > >> > .../templates/trigger_function/css/function.css|3 -
> > >> > .../{templates/edbfunc => static}/css/edbfunc.css |0
> > >> > .../static/js/exclusion_constraint.js | 18 +-
> > >> > .../foreign_key/static/js/foreign_key.js | 17 +-
> > >> > .../schemas/tables/rules/static/css/rule.css |7 +
> > >> > .../tables/rules/templates/rules/css/rule.css |8 -
> > >> > .../databases/schemas/views/static/css/view.css|7 +
> > >> > .../schemas/views/templates/mview/css/mview.css|4 -
> > >> > .../schemas/views/templates/view/css/view.css |4 -
> > >> > .../pgagent/schedules/static/js/pga_schedule.js|3 +-
> > >> > .../servers/pgagent/static/css/pga_job.css |3 +
> > >> > .../pgagent/templates/pga_job/css/pga_job.css | 13 -
> > >> > .../server_groups/servers/static/css/servers.css |4 +
> > >> > .../server_groups/servers/static/js/server.js | 22 +-
>
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote:
> One other issue: I'm seeing that standard sized dialogues (e.g. the
> Server or Database Properties dialogues) are wrapping their labels and
> controls at the default size. That should not be the case.
>
Yep. Akshay has logged that in the sheet shared (
https://drive.google.com/open?id=127BgrvdVUvWSEp-GnQvCDx1WaaemsycxSD0aUpWxb6k
).
>
> On Fri, Dec 21, 2018 at 12:46 PM Dave Page wrote:
> >
> > Hi
> >
> > On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal
> > wrote:
> > >
> > > Hi Dave,
> > >
> > > On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote:
> > >>
> > >> Nice! Thanks Ashesh.
> > >>
> > >> Some small issues I spotted:
> > >>
> > >> - The font looks somewhat small. How does it compare in size to, say,
> > >> Gmail? I think it needs to be increased to at least that size.
> > >
> > > Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We are
> using 0.875rem (14px) for main navbar links and 0.815rem(13.04px) for all
> other text.
> >
> > Let's increase the default to 0.875, and make the main links
> > proportionally bigger.
> >
> > >> - Dialogues have 2 close buttons next to each other in the top-right.
> > >> Looks like an icon and a text version?
> > >
> > > You need to do a yarn install. wcDocker code is changed to fix that.
> >
> > Yup, that fixed it.
> >
> > >> - Why do some Preferences panels use alternate line colouring, whilst
> > >> others don't? I suspect it's because some are actually tables under
> > >> the hood? I think we need consistency there.
> > >
> > > Noted.
> > >>
> > >>
> > >> - The Maintenance dialogue looks terrible - it needs to be made much
> > >> more compact. I also seem to be getting a failure to create
> > >> maintenance jobs (backups etc work fine).
> > >
> > > Noted.
> > >>
> > >>
> > >> - I think the buttons on the Browser need borders to match other
> buttons.
> > >
> > > It is made consistent with other wcDocker buttons like close, right
> arrow, left arrow. However, we can make it look like other buttons.
> >
> > I think they're a different class of buttons - control/navigation vs.
> > function. I think we should make this change as the browser buttons
> > really are a toolbar just like the larger on on the query tool.
> >
> > Thanks!
> >
> > >> Thanks!
> > >>
> > >> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi
> > >> wrote:
> > >> >
> > >> > Improvement in the look and feel of the whole application
> > >> >
> > >> > Changed the SCSS/CSS for the below third party libraries to adopt
> the
> > >> > new look 'n' feel:
> > >> > - wcDocker
> > >> > - Alertify dialogs, and notifications
> > >> > - AciTree
> > >> > - Bootstrap Navbar
> > >> > - Bootstrap Tabs
> > >> > - Bootstrap Drop-Down menu
> > >> > - Backgrid
> > >> > - Select2
> > >> >
> > >> > Adopated the new the look 'n' feel for the dialogs, wizard,
> properties,
> > >> > tab panels, tabs, fieldset, subnode control, spinner control, HTML
> > >> > table, and other form controls.
> > >> >
> > >> > - Font is changed to Roboto
> > >> > - Using SCSS variables to define the look 'n' feel
> > >> > - Designer background images for the Login, and Forget password
> pages in
> > >> > 'web' mode
> > >> > - Improved the look 'n' feel for the key selection in the
> preferences
> > >> > dialog
> > >> > - Table classes consistency changes across the application
> > >> > - File Open and Save dialog list view changes
> > >> >
> > >> > Author(s): Aditya Toshniwal & Khushboo Vashi
> > >> >
> > >> > Branch
> > >> > --
> > >> > master
> > >> >
> > >> > Details
> > >> > ---
> > >> >
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74
> > >> >
> > >> > Modified Files
> > >> > --
> > >> > web/package.json |2 +-
> > >> > .../static/js/fts_configuration.js |2 +-
> > >> > .../databases/schemas/functions/__init__.py|4 +-
> > >> > .../function => static}/css/function.css |0
> > >> > .../templates/trigger_function/css/function.css|3 -
> > >> > .../{templates/edbfunc => static}/css/edbfunc.css |0
> > >> > .../static/js/exclusion_constraint.js | 18 +-
> > >> > .../foreign_key/static/js/foreign_key.js | 17 +-
> > >> > .../schemas/tables/rules/static/css/rule.css |7 +
> > >> > .../tables/rules/templates/rules/css/rule.css |8 -
> > >> > .../databases/schemas/views/static/css/view.css|7 +
> > >> > .../schemas/views/templates/mview/css/mview.css|4 -
> > >> > .../schemas/views/templates/view/css/view.css |4 -
> > >> > .../pgagent/schedules/static/js/pga_schedule.js|3 +-
> > >> > .../servers/pgagent/static/css/pga_job.css |3 +
> > >> > .../pgagent/templates/pga_job/css/pga_job.css | 13 -
> > >> > .../server_groups/servers/static/css/servers.css |4 +
> > >> > .../server_groups/servers/static/js/server.js | 22
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal
wrote:
>
>
>
> On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote:
>>
>> One other issue: I'm seeing that standard sized dialogues (e.g. the
>> Server or Database Properties dialogues) are wrapping their labels and
>> controls at the default size. That should not be the case.
>
> Yep. Akshay has logged that in the sheet shared
> (https://drive.google.com/open?id=127BgrvdVUvWSEp-GnQvCDx1WaaemsycxSD0aUpWxb6k).
OK, but the answer isn't to increase the size of the dialogues as
suggested. The size is fine (though we should review for consistency,
and ensure we are using no more than 3 default standard sizes
throughout the app); we should make the controls display nicely on the
default dialogue size and wrap if the user makes it smaller than we
can display in.
>> On Fri, Dec 21, 2018 at 12:46 PM Dave Page wrote:
>> >
>> > Hi
>> >
>> > On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal
>> > wrote:
>> > >
>> > > Hi Dave,
>> > >
>> > > On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote:
>> > >>
>> > >> Nice! Thanks Ashesh.
>> > >>
>> > >> Some small issues I spotted:
>> > >>
>> > >> - The font looks somewhat small. How does it compare in size to, say,
>> > >> Gmail? I think it needs to be increased to at least that size.
>> > >
>> > > Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We are
>> > > using 0.875rem (14px) for main navbar links and 0.815rem(13.04px) for
>> > > all other text.
>> >
>> > Let's increase the default to 0.875, and make the main links
>> > proportionally bigger.
>> >
>> > >> - Dialogues have 2 close buttons next to each other in the top-right.
>> > >> Looks like an icon and a text version?
>> > >
>> > > You need to do a yarn install. wcDocker code is changed to fix that.
>> >
>> > Yup, that fixed it.
>> >
>> > >> - Why do some Preferences panels use alternate line colouring, whilst
>> > >> others don't? I suspect it's because some are actually tables under
>> > >> the hood? I think we need consistency there.
>> > >
>> > > Noted.
>> > >>
>> > >>
>> > >> - The Maintenance dialogue looks terrible - it needs to be made much
>> > >> more compact. I also seem to be getting a failure to create
>> > >> maintenance jobs (backups etc work fine).
>> > >
>> > > Noted.
>> > >>
>> > >>
>> > >> - I think the buttons on the Browser need borders to match other
>> > >> buttons.
>> > >
>> > > It is made consistent with other wcDocker buttons like close, right
>> > > arrow, left arrow. However, we can make it look like other buttons.
>> >
>> > I think they're a different class of buttons - control/navigation vs.
>> > function. I think we should make this change as the browser buttons
>> > really are a toolbar just like the larger on on the query tool.
>> >
>> > Thanks!
>> >
>> > >> Thanks!
>> > >>
>> > >> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi
>> > >> wrote:
>> > >> >
>> > >> > Improvement in the look and feel of the whole application
>> > >> >
>> > >> > Changed the SCSS/CSS for the below third party libraries to adopt the
>> > >> > new look 'n' feel:
>> > >> > - wcDocker
>> > >> > - Alertify dialogs, and notifications
>> > >> > - AciTree
>> > >> > - Bootstrap Navbar
>> > >> > - Bootstrap Tabs
>> > >> > - Bootstrap Drop-Down menu
>> > >> > - Backgrid
>> > >> > - Select2
>> > >> >
>> > >> > Adopated the new the look 'n' feel for the dialogs, wizard,
>> > >> > properties,
>> > >> > tab panels, tabs, fieldset, subnode control, spinner control, HTML
>> > >> > table, and other form controls.
>> > >> >
>> > >> > - Font is changed to Roboto
>> > >> > - Using SCSS variables to define the look 'n' feel
>> > >> > - Designer background images for the Login, and Forget password pages
>> > >> > in
>> > >> > 'web' mode
>> > >> > - Improved the look 'n' feel for the key selection in the preferences
>> > >> > dialog
>> > >> > - Table classes consistency changes across the application
>> > >> > - File Open and Save dialog list view changes
>> > >> >
>> > >> > Author(s): Aditya Toshniwal & Khushboo Vashi
>> > >> >
>> > >> > Branch
>> > >> > --
>> > >> > master
>> > >> >
>> > >> > Details
>> > >> > ---
>> > >> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74
>> > >> >
>> > >> > Modified Files
>> > >> > --
>> > >> > web/package.json |2 +-
>> > >> > .../static/js/fts_configuration.js |2 +-
>> > >> > .../databases/schemas/functions/__init__.py|4 +-
>> > >> > .../function => static}/css/function.css |0
>> > >> > .../templates/trigger_function/css/function.css|3 -
>> > >> > .../{templates/edbfunc => static}/css/edbfunc.css |0
>> > >> > .../static/js/exclusion_constraint.js | 18 +-
>> > >> > .../foreign_key/static/js/foreign_key.js | 17 +-
>> > >> > .../schemas/tables/rules/static/css/rule.css |7 +
>> > >> > .../tables/rules/templates/rules/css/rule
Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
On Fri, 21 Dec 2018, 18:52 Dave Page Hi > > Looks good - I just found one issue; please go ahead and commit (with a > release notes update) when fixed. > > - If I set the NULL replacement value to an empty string, it defaults back > to NULL. It's therefore not possible to replace null values with an empty > value. > If you remember this is the default behaviour of the Preferences dialog. It sets the default value again if you set the blank value. Fahar has raised the same issue before and we have rejected that. If you think we can create the new RM for that behaviour and will commit the current patch. > > Thanks! > > On Fri, Dec 21, 2018 at 12:57 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> I have modified the condition, it won't through any exception. Attached >> is the updated patch, please review it. >> >> On Fri, Dec 21, 2018 at 4:22 AM Dave Page wrote: >> >>> Sorry! Here is is. >>> >>> On Fri, Dec 21, 2018 at 12:12 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Dave Can you please attached the updated patch with your changes. I'll try to fix the exception. On Fri, Dec 21, 2018 at 3:57 AM Dave Page wrote: > Hi > > Here's an updated patch as I've tweaked some of the wording. The > screenshot probably isn't the right resolution, but as we're replacing > them > anyway it doesn't seem overly important. Feel free to fix if you like :-) > > With quoting set to either All or Strings, everything looks good. With > it set to None, I still get an exception (below). The query I'm using is > this: > > SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text > > Field separator: , > Quote character: " > Replace null's with: NULL > > Steps: > > 1) Run pgAdmin in Desktop mode. I'm running from within PyuCharms, > using the venv detailed below. > 2) Open the Query Tool on a PostgreSQL 9.6.10 database, running on > MacOS 10.14.1 > 3) Run the above query, wit quoting set to All and check the result in > the grid. > 4) Download the CSV file and check. > 5) Open Preferences and set quoting to Strings. > 6) Download the CSV file and check. > 7) Open Preferences and set quoting to None. > 8) Download the CSV file *exception occurs*. > > > System info: > > (pgadmin4) dpage@hal:*~/git/pgadmin4*$ python --version > > Python 3.6.7 > > (pgadmin4) dpage@hal:*~/git/pgadmin4*$ pip freeze > > alabaster==0.7.11 > > alembic==1.0.0 > > asn1crypto==0.24.0 > > Babel==2.6.0 > > bcrypt==3.1.4 > > blinker==1.4 > > certifi==2018.8.24 > > cffi==1.11.5 > > chardet==3.0.4 > > chromedriver-installer==0.0.6 > > click==6.7 > > cryptography==2.3 > > docutils==0.14 > > extras==1.0.0 > > fixtures==3.0.0 > > Flask==0.12.4 > > Flask-BabelEx==0.9.3 > > Flask-Gravatar==0.5.0 > > Flask-HTMLmin==1.3.2 > > Flask-Login==0.3.2 > > Flask-Mail==0.9.1 > > Flask-Migrate==2.1.1 > > Flask-Paranoid==0.2.0 > > Flask-Principal==0.4.0 > > Flask-Security==3.0.0 > > Flask-SQLAlchemy==2.3.2 > > Flask-WTF==0.14.2 > > html5lib==1.0.1 > > htmlmin==0.1.12 > > idna==2.7 > > imagesize==1.1.0 > > itsdangerous==0.24 > > Jinja2==2.10 > > linecache2==1.0.0 > > Mako==1.0.7 > > MarkupSafe==1.0 > > packaging==18.0 > > paramiko==2.4.1 > > passlib==1.7.1 > > pbr==3.1.1 > > psutil==5.4.8 > > psycopg2==2.7.5 > > pyasn1==0.4.4 > > pycodestyle==2.3.1 > > pycparser==2.18 > > pycrypto==2.6.1 > > Pygments==2.2.0 > > PyNaCl==1.2.1 > > pyparsing==2.2.2 > > pyperclip==1.6.4 > > pyrsistent==0.14.2 > > python-dateutil==2.7.3 > > python-editor==1.0.3 > > python-mimeparse==1.6.0 > > pytz==2018.3 > > requests==2.19.1 > > selenium==3.14.1 > > simplejson==3.13.2 > > six==1.11.0 > > snowballstemmer==1.2.1 > > speaklater==1.3 > > Sphinx==1.8.2 > > sphinxcontrib-websupport==1.1.0 > > SQLAlchemy==1.2.10 > > sqlparse==0.2.4 > > sshtunnel==0.1.4 > > testscenarios==0.5.0 > > testtools==2.3.0 > > traceback2==1.4.0 > > unittest2==1.1.0 > > urllib3==1.23 > > webencodings==0.5.1 > > Werkzeug==0.14.1 > > WTForms==2.1 > > Exception: > > 2018-12-21 11:47:28,995: SQL pgadmin: Execute (with server cursor) > for server #2 - CONN:8760231 (Query-id: 8649354): > SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text > 2018-12-21 11:47:29,001: INFO w
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
For the query tool results grid text pop-out, you mean the border size around it ? We don't have any design discussed for it, so could you please propose what can be done. On Fri, Dec 21, 2018 at 7:35 PM Dave Page wrote: > On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal > wrote: > > > > > > > > On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote: > >> > >> One other issue: I'm seeing that standard sized dialogues (e.g. the > >> Server or Database Properties dialogues) are wrapping their labels and > >> controls at the default size. That should not be the case. > > > > Yep. Akshay has logged that in the sheet shared ( > https://drive.google.com/open?id=127BgrvdVUvWSEp-GnQvCDx1WaaemsycxSD0aUpWxb6k > ). > > OK, but the answer isn't to increase the size of the dialogues as > suggested. The size is fine (though we should review for consistency, > and ensure we are using no more than 3 default standard sizes > throughout the app); we should make the controls display nicely on the > default dialogue size and wrap if the user makes it smaller than we > can display in. > > >> On Fri, Dec 21, 2018 at 12:46 PM Dave Page wrote: > >> > > >> > Hi > >> > > >> > On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal > >> > wrote: > >> > > > >> > > Hi Dave, > >> > > > >> > > On Fri, Dec 21, 2018 at 5:51 PM Dave Page > wrote: > >> > >> > >> > >> Nice! Thanks Ashesh. > >> > >> > >> > >> Some small issues I spotted: > >> > >> > >> > >> - The font looks somewhat small. How does it compare in size to, > say, > >> > >> Gmail? I think it needs to be increased to at least that size. > >> > > > >> > > Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We are > using 0.875rem (14px) for main navbar links and 0.815rem(13.04px) for all > other text. > >> > > >> > Let's increase the default to 0.875, and make the main links > >> > proportionally bigger. > >> > > >> > >> - Dialogues have 2 close buttons next to each other in the > top-right. > >> > >> Looks like an icon and a text version? > >> > > > >> > > You need to do a yarn install. wcDocker code is changed to fix that. > >> > > >> > Yup, that fixed it. > >> > > >> > >> - Why do some Preferences panels use alternate line colouring, > whilst > >> > >> others don't? I suspect it's because some are actually tables under > >> > >> the hood? I think we need consistency there. > >> > > > >> > > Noted. > >> > >> > >> > >> > >> > >> - The Maintenance dialogue looks terrible - it needs to be made > much > >> > >> more compact. I also seem to be getting a failure to create > >> > >> maintenance jobs (backups etc work fine). > >> > > > >> > > Noted. > >> > >> > >> > >> > >> > >> - I think the buttons on the Browser need borders to match other > buttons. > >> > > > >> > > It is made consistent with other wcDocker buttons like close, right > arrow, left arrow. However, we can make it look like other buttons. > >> > > >> > I think they're a different class of buttons - control/navigation vs. > >> > function. I think we should make this change as the browser buttons > >> > really are a toolbar just like the larger on on the query tool. > >> > > >> > Thanks! > >> > > >> > >> Thanks! > >> > >> > >> > >> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi > >> > >> wrote: > >> > >> > > >> > >> > Improvement in the look and feel of the whole application > >> > >> > > >> > >> > Changed the SCSS/CSS for the below third party libraries to > adopt the > >> > >> > new look 'n' feel: > >> > >> > - wcDocker > >> > >> > - Alertify dialogs, and notifications > >> > >> > - AciTree > >> > >> > - Bootstrap Navbar > >> > >> > - Bootstrap Tabs > >> > >> > - Bootstrap Drop-Down menu > >> > >> > - Backgrid > >> > >> > - Select2 > >> > >> > > >> > >> > Adopated the new the look 'n' feel for the dialogs, wizard, > properties, > >> > >> > tab panels, tabs, fieldset, subnode control, spinner control, > HTML > >> > >> > table, and other form controls. > >> > >> > > >> > >> > - Font is changed to Roboto > >> > >> > - Using SCSS variables to define the look 'n' feel > >> > >> > - Designer background images for the Login, and Forget password > pages in > >> > >> > 'web' mode > >> > >> > - Improved the look 'n' feel for the key selection in the > preferences > >> > >> > dialog > >> > >> > - Table classes consistency changes across the application > >> > >> > - File Open and Save dialog list view changes > >> > >> > > >> > >> > Author(s): Aditya Toshniwal & Khushboo Vashi > >> > >> > > >> > >> > Branch > >> > >> > -- > >> > >> > master > >> > >> > > >> > >> > Details > >> > >> > --- > >> > >> > > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5799ac14ba17dc25fbec184b3b2c6afbe37f1f74 > >> > >> > > >> > >> > Modified Files > >> > >> > -- > >> > >> > web/package.json |2 +- > >> > >> > .../static/js/fts_configuration.js |2 +- > >> > >> > .../databases/schemas/functions/__init__.py|4 +- > >> > >> > .../function => s
Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
On Fri, Dec 21, 2018 at 2:08 PM Akshay Joshi wrote: > > > On Fri, 21 Dec 2018, 18:52 Dave Page >> Hi >> >> Looks good - I just found one issue; please go ahead and commit (with a >> release notes update) when fixed. >> >> - If I set the NULL replacement value to an empty string, it defaults >> back to NULL. It's therefore not possible to replace null values with an >> empty value. >> > > If you remember this is the default behaviour of the Preferences > dialog. It sets the default value again if you set the blank value. Fahar > has raised the same issue before and we have rejected that. If you think we > can create the new RM for that behaviour and will commit the current patch. > Well, we rejected it for a specific case. In this specific case, it makes sense to be able to enter a blank value. Maybe we just need an "allow blank" flag on the preference object, that does nothing except allow you to remove the default (or any other) value without it being replaced again? Obviously the default still needs to work until a value is written to the config DB. > >> Thanks! >> >> On Fri, Dec 21, 2018 at 12:57 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> I have modified the condition, it won't through any exception. Attached >>> is the updated patch, please review it. >>> >>> On Fri, Dec 21, 2018 at 4:22 AM Dave Page wrote: >>> Sorry! Here is is. On Fri, Dec 21, 2018 at 12:12 PM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > Can you please attached the updated patch with your changes. I'll try > to fix the exception. > > On Fri, Dec 21, 2018 at 3:57 AM Dave Page wrote: > >> Hi >> >> Here's an updated patch as I've tweaked some of the wording. The >> screenshot probably isn't the right resolution, but as we're replacing >> them >> anyway it doesn't seem overly important. Feel free to fix if you like :-) >> >> With quoting set to either All or Strings, everything looks good. >> With it set to None, I still get an exception (below). The query I'm >> using >> is this: >> >> SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text >> >> Field separator: , >> Quote character: " >> Replace null's with: NULL >> >> Steps: >> >> 1) Run pgAdmin in Desktop mode. I'm running from within PyuCharms, >> using the venv detailed below. >> 2) Open the Query Tool on a PostgreSQL 9.6.10 database, running on >> MacOS 10.14.1 >> 3) Run the above query, wit quoting set to All and check the result >> in the grid. >> 4) Download the CSV file and check. >> 5) Open Preferences and set quoting to Strings. >> 6) Download the CSV file and check. >> 7) Open Preferences and set quoting to None. >> 8) Download the CSV file *exception occurs*. >> >> >> System info: >> >> (pgadmin4) dpage@hal:*~/git/pgadmin4*$ python --version >> >> Python 3.6.7 >> >> (pgadmin4) dpage@hal:*~/git/pgadmin4*$ pip freeze >> >> alabaster==0.7.11 >> >> alembic==1.0.0 >> >> asn1crypto==0.24.0 >> >> Babel==2.6.0 >> >> bcrypt==3.1.4 >> >> blinker==1.4 >> >> certifi==2018.8.24 >> >> cffi==1.11.5 >> >> chardet==3.0.4 >> >> chromedriver-installer==0.0.6 >> >> click==6.7 >> >> cryptography==2.3 >> >> docutils==0.14 >> >> extras==1.0.0 >> >> fixtures==3.0.0 >> >> Flask==0.12.4 >> >> Flask-BabelEx==0.9.3 >> >> Flask-Gravatar==0.5.0 >> >> Flask-HTMLmin==1.3.2 >> >> Flask-Login==0.3.2 >> >> Flask-Mail==0.9.1 >> >> Flask-Migrate==2.1.1 >> >> Flask-Paranoid==0.2.0 >> >> Flask-Principal==0.4.0 >> >> Flask-Security==3.0.0 >> >> Flask-SQLAlchemy==2.3.2 >> >> Flask-WTF==0.14.2 >> >> html5lib==1.0.1 >> >> htmlmin==0.1.12 >> >> idna==2.7 >> >> imagesize==1.1.0 >> >> itsdangerous==0.24 >> >> Jinja2==2.10 >> >> linecache2==1.0.0 >> >> Mako==1.0.7 >> >> MarkupSafe==1.0 >> >> packaging==18.0 >> >> paramiko==2.4.1 >> >> passlib==1.7.1 >> >> pbr==3.1.1 >> >> psutil==5.4.8 >> >> psycopg2==2.7.5 >> >> pyasn1==0.4.4 >> >> pycodestyle==2.3.1 >> >> pycparser==2.18 >> >> pycrypto==2.6.1 >> >> Pygments==2.2.0 >> >> PyNaCl==1.2.1 >> >> pyparsing==2.2.2 >> >> pyperclip==1.6.4 >> >> pyrsistent==0.14.2 >> >> python-dateutil==2.7.3 >> >> python-editor==1.0.3 >> >> python-mimeparse==1.6.0 >> >> pytz==2018.3 >> >> requests==2.19.1 >> >> selenium==3.14.1 >> >> simplejson==3.13.2 >> >> six==1.11.0 >> >> snowballstemmer==1.2.1 >> >> speaklater==1.3 >
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
On Fri, Dec 21, 2018 at 2:14 PM Aditya Toshniwal wrote: > > For the query tool results grid text pop-out, you mean the border size around > it ? > We don't have any design discussed for it, so could you please propose what > can be done. Border, button colours etc. I can't draw anything, but I'd suggest that the border should be squared not rounded, and the thickness/shadow etc adjusted to match the other styling. > > On Fri, Dec 21, 2018 at 7:35 PM Dave Page wrote: >> >> On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal >> wrote: >> > >> > >> > >> > On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote: >> >> >> >> One other issue: I'm seeing that standard sized dialogues (e.g. the >> >> Server or Database Properties dialogues) are wrapping their labels and >> >> controls at the default size. That should not be the case. >> > >> > Yep. Akshay has logged that in the sheet shared >> > (https://drive.google.com/open?id=127BgrvdVUvWSEp-GnQvCDx1WaaemsycxSD0aUpWxb6k). >> >> OK, but the answer isn't to increase the size of the dialogues as >> suggested. The size is fine (though we should review for consistency, >> and ensure we are using no more than 3 default standard sizes >> throughout the app); we should make the controls display nicely on the >> default dialogue size and wrap if the user makes it smaller than we >> can display in. >> >> >> On Fri, Dec 21, 2018 at 12:46 PM Dave Page wrote: >> >> > >> >> > Hi >> >> > >> >> > On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal >> >> > wrote: >> >> > > >> >> > > Hi Dave, >> >> > > >> >> > > On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote: >> >> > >> >> >> > >> Nice! Thanks Ashesh. >> >> > >> >> >> > >> Some small issues I spotted: >> >> > >> >> >> > >> - The font looks somewhat small. How does it compare in size to, say, >> >> > >> Gmail? I think it needs to be increased to at least that size. >> >> > > >> >> > > Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We are >> >> > > using 0.875rem (14px) for main navbar links and 0.815rem(13.04px) >> >> > > for all other text. >> >> > >> >> > Let's increase the default to 0.875, and make the main links >> >> > proportionally bigger. >> >> > >> >> > >> - Dialogues have 2 close buttons next to each other in the top-right. >> >> > >> Looks like an icon and a text version? >> >> > > >> >> > > You need to do a yarn install. wcDocker code is changed to fix that. >> >> > >> >> > Yup, that fixed it. >> >> > >> >> > >> - Why do some Preferences panels use alternate line colouring, whilst >> >> > >> others don't? I suspect it's because some are actually tables under >> >> > >> the hood? I think we need consistency there. >> >> > > >> >> > > Noted. >> >> > >> >> >> > >> >> >> > >> - The Maintenance dialogue looks terrible - it needs to be made much >> >> > >> more compact. I also seem to be getting a failure to create >> >> > >> maintenance jobs (backups etc work fine). >> >> > > >> >> > > Noted. >> >> > >> >> >> > >> >> >> > >> - I think the buttons on the Browser need borders to match other >> >> > >> buttons. >> >> > > >> >> > > It is made consistent with other wcDocker buttons like close, right >> >> > > arrow, left arrow. However, we can make it look like other buttons. >> >> > >> >> > I think they're a different class of buttons - control/navigation vs. >> >> > function. I think we should make this change as the browser buttons >> >> > really are a toolbar just like the larger on on the query tool. >> >> > >> >> > Thanks! >> >> > >> >> > >> Thanks! >> >> > >> >> >> > >> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi >> >> > >> wrote: >> >> > >> > >> >> > >> > Improvement in the look and feel of the whole application >> >> > >> > >> >> > >> > Changed the SCSS/CSS for the below third party libraries to adopt >> >> > >> > the >> >> > >> > new look 'n' feel: >> >> > >> > - wcDocker >> >> > >> > - Alertify dialogs, and notifications >> >> > >> > - AciTree >> >> > >> > - Bootstrap Navbar >> >> > >> > - Bootstrap Tabs >> >> > >> > - Bootstrap Drop-Down menu >> >> > >> > - Backgrid >> >> > >> > - Select2 >> >> > >> > >> >> > >> > Adopated the new the look 'n' feel for the dialogs, wizard, >> >> > >> > properties, >> >> > >> > tab panels, tabs, fieldset, subnode control, spinner control, HTML >> >> > >> > table, and other form controls. >> >> > >> > >> >> > >> > - Font is changed to Roboto >> >> > >> > - Using SCSS variables to define the look 'n' feel >> >> > >> > - Designer background images for the Login, and Forget password >> >> > >> > pages in >> >> > >> > 'web' mode >> >> > >> > - Improved the look 'n' feel for the key selection in the >> >> > >> > preferences >> >> > >> > dialog >> >> > >> > - Table classes consistency changes across the application >> >> > >> > - File Open and Save dialog list view changes >> >> > >> > >> >> > >> > Author(s): Aditya Toshniwal & Khushboo Vashi >> >> > >> > >> >> > >> > Branch >> >> > >> > -- >> >> > >> > master >> >> > >> > >> >> > >> > Details >> >> > >> >
Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
On Fri, Dec 21, 2018 at 7:46 PM Dave Page wrote: > On Fri, Dec 21, 2018 at 2:14 PM Aditya Toshniwal > wrote: > > > > For the query tool results grid text pop-out, you mean the border size > around it ? > > We don't have any design discussed for it, so could you please propose > what can be done. > > Border, button colours etc. I can't draw anything, but I'd suggest > that the border should be squared not rounded, and the > thickness/shadow etc adjusted to match the other styling. > Cool. Button colors are already changed. Others things noted. Will work on it. > > > > On Fri, Dec 21, 2018 at 7:35 PM Dave Page wrote: > >> > >> On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal > >> wrote: > >> > > >> > > >> > > >> > On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote: > >> >> > >> >> One other issue: I'm seeing that standard sized dialogues (e.g. the > >> >> Server or Database Properties dialogues) are wrapping their labels > and > >> >> controls at the default size. That should not be the case. > >> > > >> > Yep. Akshay has logged that in the sheet shared ( > https://drive.google.com/open?id=127BgrvdVUvWSEp-GnQvCDx1WaaemsycxSD0aUpWxb6k > ). > >> > >> OK, but the answer isn't to increase the size of the dialogues as > >> suggested. The size is fine (though we should review for consistency, > >> and ensure we are using no more than 3 default standard sizes > >> throughout the app); we should make the controls display nicely on the > >> default dialogue size and wrap if the user makes it smaller than we > >> can display in. > >> > >> >> On Fri, Dec 21, 2018 at 12:46 PM Dave Page > wrote: > >> >> > > >> >> > Hi > >> >> > > >> >> > On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal > >> >> > wrote: > >> >> > > > >> >> > > Hi Dave, > >> >> > > > >> >> > > On Fri, Dec 21, 2018 at 5:51 PM Dave Page > wrote: > >> >> > >> > >> >> > >> Nice! Thanks Ashesh. > >> >> > >> > >> >> > >> Some small issues I spotted: > >> >> > >> > >> >> > >> - The font looks somewhat small. How does it compare in size > to, say, > >> >> > >> Gmail? I think it needs to be increased to at least that size. > >> >> > > > >> >> > > Gmail uses 0.875rem (14px) for the left panel (Inbox, Sent). We > are using 0.875rem (14px) for main navbar links and 0.815rem(13.04px) for > all other text. > >> >> > > >> >> > Let's increase the default to 0.875, and make the main links > >> >> > proportionally bigger. > >> >> > > >> >> > >> - Dialogues have 2 close buttons next to each other in the > top-right. > >> >> > >> Looks like an icon and a text version? > >> >> > > > >> >> > > You need to do a yarn install. wcDocker code is changed to fix > that. > >> >> > > >> >> > Yup, that fixed it. > >> >> > > >> >> > >> - Why do some Preferences panels use alternate line colouring, > whilst > >> >> > >> others don't? I suspect it's because some are actually tables > under > >> >> > >> the hood? I think we need consistency there. > >> >> > > > >> >> > > Noted. > >> >> > >> > >> >> > >> > >> >> > >> - The Maintenance dialogue looks terrible - it needs to be made > much > >> >> > >> more compact. I also seem to be getting a failure to create > >> >> > >> maintenance jobs (backups etc work fine). > >> >> > > > >> >> > > Noted. > >> >> > >> > >> >> > >> > >> >> > >> - I think the buttons on the Browser need borders to match > other buttons. > >> >> > > > >> >> > > It is made consistent with other wcDocker buttons like close, > right arrow, left arrow. However, we can make it look like other buttons. > >> >> > > >> >> > I think they're a different class of buttons - control/navigation > vs. > >> >> > function. I think we should make this change as the browser buttons > >> >> > really are a toolbar just like the larger on on the query tool. > >> >> > > >> >> > Thanks! > >> >> > > >> >> > >> Thanks! > >> >> > >> > >> >> > >> On Fri, Dec 21, 2018 at 12:01 PM Ashesh Vashi > >> >> > >> wrote: > >> >> > >> > > >> >> > >> > Improvement in the look and feel of the whole application > >> >> > >> > > >> >> > >> > Changed the SCSS/CSS for the below third party libraries to > adopt the > >> >> > >> > new look 'n' feel: > >> >> > >> > - wcDocker > >> >> > >> > - Alertify dialogs, and notifications > >> >> > >> > - AciTree > >> >> > >> > - Bootstrap Navbar > >> >> > >> > - Bootstrap Tabs > >> >> > >> > - Bootstrap Drop-Down menu > >> >> > >> > - Backgrid > >> >> > >> > - Select2 > >> >> > >> > > >> >> > >> > Adopated the new the look 'n' feel for the dialogs, wizard, > properties, > >> >> > >> > tab panels, tabs, fieldset, subnode control, spinner control, > HTML > >> >> > >> > table, and other form controls. > >> >> > >> > > >> >> > >> > - Font is changed to Roboto > >> >> > >> > - Using SCSS variables to define the look 'n' feel > >> >> > >> > - Designer background images for the Login, and Forget > password pages in > >> >> > >> > 'web' mode > >> >> > >> > - Improved the look 'n' feel for the key selection in the > preferences > >> >> > >> > dialog > >> >> > >> > - Table clas
