[pgAdmin4][Patch]: RM #3734 "Error Message displayed once user use debugger and execute procedure list_emp 5 times with fast speed"
Hi Hackers, Attached is the patch to fix RM #3734 "Error Message displayed once user use debugger and execute procedure list_emp 5 times with fast speed". *Solution*: I have wrapped the logic to enable "*Continue*" button in setTimeout() function with the sleep of 500ms. This is not the exact solution, but it works for me. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3734.patch Description: Binary data
Re: Import/export servers
Done - thanks! On Tue, Nov 20, 2018 at 5:34 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > ignore previous, use self.assertEqual(a,b) instead of self.assertTrue(a == > b) > > On Tue, Nov 20, 2018 at 10:46 AM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> small feedback, >> In the tests, instead of self.assertTrue(a == b) use self.assertEqual(a >> == b) which will give more info if test case fails. >> >> On Mon, Nov 19, 2018 at 8:09 PM Dave Page wrote: >> >>> A number of people have asked for the ability to import and export >>> server definitions. It's also convenient to have such a feature in the >>> container world, where new instances of pgAdmin containers may be created >>> on the fly. >>> >>> Here's a draft patch to allow that, including docs and a basic test. >>> >>> Review feedback please? >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Regards, >> Navnath Gadakh >> > > > -- > Regards, > Navnath Gadakh > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Import/export servers
Hi On Tue, Nov 20, 2018 at 6:01 AM Akshay Joshi wrote: > Hi Dave > On Mon, Nov 19, 2018 at 8:09 PM Dave Page wrote: > >> A number of people have asked for the ability to import and export server >> definitions. It's also convenient to have such a feature in the container >> world, where new instances of pgAdmin containers may be created on the fly. >> >> Here's a draft patch to allow that, including docs and a basic test. >> >> Review feedback please? >> > > Patch looks good to me. Can we have option to provide the servers to > be exported? It may possible that user don't want to export the local > servers as it is automatically detected. Can we have GUI(may be dialog) > for this? > This is intentionally not a GUI feature. I've added a --server flag to allow the user to specify specific servers (without it, all are dumped), and changed the JSON structure per the discussion we had earlier to ensure that servers with duplicate names can be dumped. Please re-review. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company import_export_servers_v2.diff Description: Binary data
Re: [pgAdmin4][Patch]: RM #3354 Debugger does not start if function has input vars of type array
Hi On Fri, Nov 16, 2018 at 6:53 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3354 "Debugger does not start if > function has input vars of type array". Apart from that patch contains fix > for the following: > >- Parameter values showing twice in case of array. >- Allow null values in "InputIntegerArrayCell". > > Please review it. > Testing with a function which takes a oid[] as an argument, if I use an array of numbers it works, but if I enter NULL and a number I get: ERROR: invalid input syntax for type oid: "NULL" LINE 3: 'NULL', '456']::oid[] ^ SQL state: 22P02 Character: 47 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix toggle breakpoints buttons in the debugger. Fixes
Fix toggle breakpoints buttons in the debugger. Fixes #3736 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=782b7419f68f5da4a25aa3a06f02c07f782d1cb0 Modified Files -- docs/en_US/release_notes_3_6.rst | 1 + web/pgadmin/tools/debugger/static/js/direct.js | 1 + 2 files changed, 2 insertions(+)
Re: [pgAdmin4][Patch]: RM #3736 In case of Debugger, if click on breakpoints then other buttons should not disabled
Thanks, applied. On Fri, Nov 16, 2018 at 7:26 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3736 "In case of Debugger, if click > on breakpoints then other buttons should not disabled". Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix changes to the NOT NULL and default value options
Fix changes to the NOT NULL and default value options in the Table Dialogue. Fixes #3742 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b5abdfa8f996773fd5819ccaf92941503089a2d Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_6.rst| 1 + .../databases/schemas/tables/templates/column/sql/9.2_plus/update.sql | 2 +- .../databases/schemas/tables/templates/column/sql/default/update.sql| 2 +- 3 files changed, 3 insertions(+), 2 deletions(-)
Re: [pgAdmin4][Patch]: RM #3742 ALTER COLUMN bug
Thanks, patch applied. On Mon, Nov 19, 2018 at 11:44 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3742 "ALTER COLUMN bug". Please > review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Prevent the debugger controls being pressed again bef
Prevent the debugger controls being pressed again before previous processing is complete. Fixes #3734 Note that this needs to be re-visited in the future, as the current fix is somewhat hacky. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05e067035f1f8b4b3f80371930cb183ada392af6 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_6.rst | 1 + web/pgadmin/tools/debugger/static/js/direct.js | 44 +++--- 2 files changed, 27 insertions(+), 18 deletions(-)
Re: [pgAdmin4][Patch]: RM #3734 "Error Message displayed once user use debugger and execute procedure list_emp 5 times with fast speed"
Thanks, committed. I included a note in the commit message and the code to look for a more appropriate solution in the future. On Tue, Nov 20, 2018 at 8:59 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #3734 "Error Message displayed once user > use debugger and execute procedure list_emp 5 times with fast speed". > > *Solution*: I have wrapped the logic to enable "*Continue*" button in > setTimeout() function with the sleep of 500ms. This is not the exact > solution, but it works for me. > > Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
