[pgAdmin4][Patch]: RM #3742 ALTER COLUMN bug
Hi Hackers, Attached is the patch to fix the RM #3742 "ALTER COLUMN bug". Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3742.patch Description: Binary data
pgAdmin 4 commit: Don't double-list the connecting page in the index.
Don't double-list the connecting page in the index. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bbb8433af3c292f199bad9cbbd84abae57985b10 Modified Files -- docs/en_US/getting_started.rst | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)
Import/export servers
A number of people have asked for the ability to import and export server definitions. It's also convenient to have such a feature in the container world, where new instances of pgAdmin containers may be created on the fly. Here's a draft patch to allow that, including docs and a basic test. Review feedback please? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company import_export_servers.diff Description: Binary data
Re: Import/export servers
small feedback, In the tests, instead of self.assertTrue(a == b) use self.assertEqual(a == b) which will give more info if test case fails. On Mon, Nov 19, 2018 at 8:09 PM Dave Page wrote: > A number of people have asked for the ability to import and export server > definitions. It's also convenient to have such a feature in the container > world, where new instances of pgAdmin containers may be created on the fly. > > Here's a draft patch to allow that, including docs and a basic test. > > Review feedback please? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Regards, Navnath Gadakh
Re: Import/export servers
ignore previous, use self.assertEqual(a,b) instead of self.assertTrue(a == b) On Tue, Nov 20, 2018 at 10:46 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > small feedback, > In the tests, instead of self.assertTrue(a == b) use self.assertEqual(a == > b) which will give more info if test case fails. > > On Mon, Nov 19, 2018 at 8:09 PM Dave Page wrote: > >> A number of people have asked for the ability to import and export server >> definitions. It's also convenient to have such a feature in the container >> world, where new instances of pgAdmin containers may be created on the fly. >> >> Here's a draft patch to allow that, including docs and a basic test. >> >> Review feedback please? >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Regards, > Navnath Gadakh > -- Regards, Navnath Gadakh
Re: Import/export servers
Hi Dave On Mon, Nov 19, 2018 at 8:09 PM Dave Page wrote: > A number of people have asked for the ability to import and export server > definitions. It's also convenient to have such a feature in the container > world, where new instances of pgAdmin containers may be created on the fly. > > Here's a draft patch to allow that, including docs and a basic test. > > Review feedback please? > Patch looks good to me. Can we have option to provide the servers to be exported? It may possible that user don't want to export the local servers as it is automatically detected. Can we have GUI(may be dialog) for this? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
