pgAdmin 4 commit: Doc updates after renaming SQL Editor section of the
Doc updates after renaming SQL Editor section of the Preference panel. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a6426d3e770fca5e2db148822219ed2d0b2b8b3 Author: Aditya Toshniwal Modified Files -- .../images/preferences_sql_auto_completion.png | Bin 131793 -> 143835 bytes docs/en_US/images/preferences_sql_csv_output.png | Bin 56281 -> 140688 bytes docs/en_US/images/preferences_sql_display.png | Bin 144736 -> 231452 bytes docs/en_US/images/preferences_sql_explain.png | Bin 56722 -> 144017 bytes .../images/preferences_sql_explain_options.png | Bin 63710 -> 0 bytes .../images/preferences_sql_keyboard_shortcuts.png | Bin 138163 -> 183981 bytes docs/en_US/images/preferences_sql_options.png | Bin 106776 -> 238875 bytes docs/en_US/images/preferences_sql_result_grid.png | Bin 100020 -> 0 bytes docs/en_US/images/preferences_sql_results_grid.png | Bin 58781 -> 146622 bytes docs/en_US/preferences.rst | 12 ++-- 10 files changed, 6 insertions(+), 6 deletions(-)
Re: [pgAdmin4][RM3660] Rename 'SQL Editor' into 'Query Tool' in Preferences
Thanks - applied. Of course, this makes me think - we'll need to replace all the screenshots soon :-( On Thu, Oct 11, 2018 at 6:33 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the patch for docs update. > > On Mon, Oct 8, 2018 at 4:13 PM Dave Page wrote: > >> Thanks, applied. >> >> On Mon, Oct 8, 2018 at 8:07 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the tiny patch for renaming 'SQL Editor' into 'Query Tool' >>> in Preferences. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4
Hi Hackers, Team found few more issues. Calendar control totally messed up. The bootstrap-datetimepicker package does not work with Bootstrap 4. Fortunately, there exists one package which is advanced version of the same - https://tempusdominus.github.io/bootstrap-4/. With minimum changes I am able bring back the calendar control. (Create Role -> Account expiry) Also fixed sort filter dropdown in query tool. Kindly review. On Wed, Oct 10, 2018 at 5:16 PM Dave Page wrote: > Thanks, patch applied. > > On Wed, Oct 10, 2018 at 11:41 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Ohh :/ >> Attached is the rebased patch - v4. >> >> On Wed, Oct 10, 2018 at 3:55 PM Dave Page wrote: >> >>> Hi >>> >>> Did you rebase this? It doesn't apply for me: >>> >>> (pgadmin4) dpage@hal:*~/git/pgadmin4*$ git apply >>> ~/Downloads/RM3562_v3.patch >>> >>> error: patch failed: web/pgadmin/static/scss/_select2.overrides.scss:2 >>> >>> error: web/pgadmin/static/scss/_select2.overrides.scss: patch does not >>> apply >>> >>> /Users/dpage/Downloads/RM3562_v3.patch:6137: new blank line at EOF. >>> >>> + >>> >>> On Wed, Oct 10, 2018 at 11:23 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi, Attached is the updated patch - v3. I missed the user login related stuffs. The patch includes changes for those. I have also changed the colour style of login page. Kindly review. On Tue, Oct 9, 2018 at 4:18 PM Dave Page wrote: > Hi > > Almost there - unfortunately I found another couple of issues in > server mode (placement of the username, and formatting of the menu). > Please > see the attached screenshot. > > Regards, Dave. > > On Tue, Oct 9, 2018 at 10:13 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached it the updated patch v2. >> Kindly review. >> >> >> On Mon, Oct 8, 2018 at 5:55 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Mon, Oct 8, 2018 at 4:06 PM Dave Page wrote: >>> Hi On Fri, Oct 5, 2018 at 1:51 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to migrate pgAdmin4 currently based on > Bootstrap 3, to be Bootstrap 4 compatible. The idea is to move to > Bootstrap > 4 with minimum possible changes in pgAdmin4. I have also used > bootstrap > scss (and not the dist file of bootstrap) to customize bootstrap as > per the > need of pgAdmin4. > I have done a basic testing. It may not look alike to that with > Bootstrap 3, but it is possible that you may find some discrepancy > (which > was proper before :P ). Kindly let me know. > Looks good. I spotted a couple of issues though: - The menu bar is a different colour now (dark grey rather than black). Not the end of the world, but I thought I'd mention it. >>> I thought of keeping the bootstrap default dark color. Will customize >>> it to black. >>> >> - The subnode control has lost some of it's styling. This does need to be fixed I think. See the attached screenshot ( boostrap 3 is on the left). >>> Yes. Will send the fix with updated patch. >>> >> Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com
process_executor.py error
Hi Hackers,
While running API test cases, i encountered following error in
process_executor.py file
==
fp.write('EXCEPTION::\n{0}'.format(res))
TypeError: a bytes-like object is required, not 'str'
==
so changed the file opening mode to 'a'. The API test cases are again run
without this error with following versions
i) Python 2.7
ii) Python 3.4
iii) Python 3.5
) Python 3.6
Please review the patch and commit.
--
Thanks,
Usman Muzaffar
QA Team
EnterpriseDB Corporation
process_executor_v1.patch
Description: Binary data
Re: process_executor.py error
+++ a little more information for the issue
i - The file(log_file) mode was 'ab' due to which it was throwing
concatenation error.
ii- I have change the file opening mode to 'a' after which the issue is not
encountered.
The issue can be reproduced as following
i) Enable Python 3.6 virtual environment
ii) move to web/regression folder
iii) trigger following command
python runtests.py --exclude feature_tests
iv) The terminal will show the error while any test case throws exception
and that is caught.
On Thu, Oct 11, 2018 at 3:46 PM, Usman Muzaffar <
usman.muzaf...@enterprisedb.com> wrote:
> Hi Hackers,
>
> While running API test cases, i encountered following error in
> process_executor.py file
>
> ==
>
> fp.write('EXCEPTION::\n{0}'.format(res))
>
> TypeError: a bytes-like object is required, not 'str'
>
> ==
>
>
>
> so changed the file opening mode to 'a'. The API test cases are again run
> without this error with following versions
> i) Python 2.7
> ii) Python 3.4
> iii) Python 3.5
> ) Python 3.6
>
> Please review the patch and commit.
>
>
> --
>
>
> Thanks,
>
> Usman Muzaffar
> QA Team
> EnterpriseDB Corporation
>
--
Thanks,
Usman Muzaffar
QA Team
EnterpriseDB Corporation
Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4
Hi Hackers, Attached is part 3 of the patch, to be applied after part 2. Urgh, I know this is annoying, but I am trying to fix and send patches as and when I find them. This patch includes fix for hiding controls. Backform used "hidden" class for hiding elements, and hidden is replaced with d-none in Bootstrap 4. One more big miss - debugger button toolbar was not visible/or in position. Fixed that as well. Let me know if you find more. :/ On Thu, Oct 11, 2018 at 3:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Team found few more issues. Calendar control totally messed up. The > bootstrap-datetimepicker package does not work with Bootstrap 4. > Fortunately, there exists one package which is advanced version of the > same - https://tempusdominus.github.io/bootstrap-4/. With minimum changes > I am able bring back the calendar control. (Create Role -> Account expiry) > Also fixed sort filter dropdown in query tool. > > Kindly review. > > > On Wed, Oct 10, 2018 at 5:16 PM Dave Page wrote: > >> Thanks, patch applied. >> >> On Wed, Oct 10, 2018 at 11:41 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Ohh :/ >>> Attached is the rebased patch - v4. >>> >>> On Wed, Oct 10, 2018 at 3:55 PM Dave Page wrote: >>> Hi Did you rebase this? It doesn't apply for me: (pgadmin4) dpage@hal:*~/git/pgadmin4*$ git apply ~/Downloads/RM3562_v3.patch error: patch failed: web/pgadmin/static/scss/_select2.overrides.scss:2 error: web/pgadmin/static/scss/_select2.overrides.scss: patch does not apply /Users/dpage/Downloads/RM3562_v3.patch:6137: new blank line at EOF. + On Wed, Oct 10, 2018 at 11:23 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the updated patch - v3. I missed the user login related > stuffs. The patch includes changes for those. > I have also changed the colour style of login page. > > Kindly review. > > On Tue, Oct 9, 2018 at 4:18 PM Dave Page wrote: > >> Hi >> >> Almost there - unfortunately I found another couple of issues in >> server mode (placement of the username, and formatting of the menu). >> Please >> see the attached screenshot. >> >> Regards, Dave. >> >> On Tue, Oct 9, 2018 at 10:13 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached it the updated patch v2. >>> Kindly review. >>> >>> >>> On Mon, Oct 8, 2018 at 5:55 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi, On Mon, Oct 8, 2018 at 4:06 PM Dave Page wrote: > Hi > > On Fri, Oct 5, 2018 at 1:51 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to migrate pgAdmin4 currently based on >> Bootstrap 3, to be Bootstrap 4 compatible. The idea is to move to >> Bootstrap >> 4 with minimum possible changes in pgAdmin4. I have also used >> bootstrap >> scss (and not the dist file of bootstrap) to customize bootstrap as >> per the >> need of pgAdmin4. >> I have done a basic testing. It may not look alike to that with >> Bootstrap 3, but it is possible that you may find some discrepancy >> (which >> was proper before :P ). Kindly let me know. >> > > Looks good. I spotted a couple of issues though: > > - The menu bar is a different colour now (dark grey rather than > black). Not the end of the world, but I thought I'd mention it. > I thought of keeping the bootstrap default dark color. Will customize it to black. >>> > - The subnode control has lost some of it's styling. This does > need to be fixed I think. See the attached screenshot ( boostrap 3 is > on > the left). > Yes. Will send the fix with updated patch. >>> > Thanks. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com
pgAdmin 4 commit: Log process exceptions using ASCII mode to avoid issu
Log process exceptions using ASCII mode to avoid issues with string concatenation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f16a0c52cd473abd21fe626c1ee8b24165fcf6d Author: Usman Muzaffar Modified Files -- web/pgadmin/misc/bgprocess/process_executor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: process_executor.py error
Thanks, applied.
On Thu, Oct 11, 2018 at 12:51 PM Usman Muzaffar <
usman.muzaf...@enterprisedb.com> wrote:
> +++ a little more information for the issue
>
>
> i - The file(log_file) mode was 'ab' due to which it was throwing
> concatenation error.
> ii- I have change the file opening mode to 'a' after which the issue is
> not encountered.
>
> The issue can be reproduced as following
>
> i) Enable Python 3.6 virtual environment
> ii) move to web/regression folder
> iii) trigger following command
> python runtests.py --exclude feature_tests
> iv) The terminal will show the error while any test case throws exception
> and that is caught.
>
>
>
>
>
>
> On Thu, Oct 11, 2018 at 3:46 PM, Usman Muzaffar <
> usman.muzaf...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> While running API test cases, i encountered following error in
>> process_executor.py file
>>
>> ==
>>
>> fp.write('EXCEPTION::\n{0}'.format(res))
>>
>> TypeError: a bytes-like object is required, not 'str'
>>
>> ==
>>
>>
>>
>> so changed the file opening mode to 'a'. The API test cases are again run
>> without this error with following versions
>> i) Python 2.7
>> ii) Python 3.4
>> iii) Python 3.5
>> ) Python 3.6
>>
>> Please review the patch and commit.
>>
>>
>> --
>>
>>
>> Thanks,
>>
>> Usman Muzaffar
>> QA Team
>> EnterpriseDB Corporation
>>
>
>
>
> --
>
>
> Thanks,
>
> Usman Muzaffar
> QA Team
> EnterpriseDB Corporation
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgAdmin 4 commit: Additional Bootstrap 4 fixes:
Additional Bootstrap 4 fixes: - Calendar control - Query Tool's Sort/Filter drop down - Backform hidden controls - Debugger toolbar Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6991c06937e89ba668d9a41b49febbe4f4e78c6c Author: Aditya Toshniwal Modified Files -- web/package.json | 4 +- web/pgadmin/browser/static/js/browser.js | 2 +- web/pgadmin/browser/static/js/node.js | 4 +- web/pgadmin/static/css/style.css | 2 +- web/pgadmin/static/js/backform.pgadmin.js | 22 ++ web/pgadmin/static/js/backgrid.pgadmin.js | 10 - web/pgadmin/static/scss/_bootstrap.overrides.scss | 5 +++ web/pgadmin/static/scss/_pgadmin.style.scss| 2 + .../tools/datagrid/templates/datagrid/index.html | 16 --- .../tools/debugger/templates/debugger/direct.html | 4 +- web/webpack.config.js | 2 + web/webpack.shim.js| 3 +- web/webpack.test.config.js | 5 ++- web/yarn.lock | 49 ++ 14 files changed, 89 insertions(+), 41 deletions(-)
Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4
Thanks, applied. On Thu, Oct 11, 2018 at 11:08 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Team found few more issues. Calendar control totally messed up. The > bootstrap-datetimepicker package does not work with Bootstrap 4. > Fortunately, there exists one package which is advanced version of the > same - https://tempusdominus.github.io/bootstrap-4/. With minimum changes > I am able bring back the calendar control. (Create Role -> Account expiry) > Also fixed sort filter dropdown in query tool. > > Kindly review. > > > On Wed, Oct 10, 2018 at 5:16 PM Dave Page wrote: > >> Thanks, patch applied. >> >> On Wed, Oct 10, 2018 at 11:41 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Ohh :/ >>> Attached is the rebased patch - v4. >>> >>> On Wed, Oct 10, 2018 at 3:55 PM Dave Page wrote: >>> Hi Did you rebase this? It doesn't apply for me: (pgadmin4) dpage@hal:*~/git/pgadmin4*$ git apply ~/Downloads/RM3562_v3.patch error: patch failed: web/pgadmin/static/scss/_select2.overrides.scss:2 error: web/pgadmin/static/scss/_select2.overrides.scss: patch does not apply /Users/dpage/Downloads/RM3562_v3.patch:6137: new blank line at EOF. + On Wed, Oct 10, 2018 at 11:23 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the updated patch - v3. I missed the user login related > stuffs. The patch includes changes for those. > I have also changed the colour style of login page. > > Kindly review. > > On Tue, Oct 9, 2018 at 4:18 PM Dave Page wrote: > >> Hi >> >> Almost there - unfortunately I found another couple of issues in >> server mode (placement of the username, and formatting of the menu). >> Please >> see the attached screenshot. >> >> Regards, Dave. >> >> On Tue, Oct 9, 2018 at 10:13 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached it the updated patch v2. >>> Kindly review. >>> >>> >>> On Mon, Oct 8, 2018 at 5:55 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi, On Mon, Oct 8, 2018 at 4:06 PM Dave Page wrote: > Hi > > On Fri, Oct 5, 2018 at 1:51 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to migrate pgAdmin4 currently based on >> Bootstrap 3, to be Bootstrap 4 compatible. The idea is to move to >> Bootstrap >> 4 with minimum possible changes in pgAdmin4. I have also used >> bootstrap >> scss (and not the dist file of bootstrap) to customize bootstrap as >> per the >> need of pgAdmin4. >> I have done a basic testing. It may not look alike to that with >> Bootstrap 3, but it is possible that you may find some discrepancy >> (which >> was proper before :P ). Kindly let me know. >> > > Looks good. I spotted a couple of issues though: > > - The menu bar is a different colour now (dark grey rather than > black). Not the end of the world, but I thought I'd mention it. > I thought of keeping the bootstrap default dark color. Will customize it to black. >>> > - The subnode control has lost some of it's styling. This does > need to be fixed I think. See the attached screenshot ( boostrap 3 is > on > the left). > Yes. Will send the fix with updated patch. >>> > Thanks. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake Enterpr
Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4
Thanks, applied. On Thu, Oct 11, 2018 at 12:52 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is part 3 of the patch, to be applied after part 2. Urgh, I know > this is annoying, but I am trying to fix and send patches as and when I > find them. This patch includes fix for hiding controls. Backform used > "hidden" class for hiding elements, and hidden is replaced with d-none in > Bootstrap 4. > One more big miss - debugger button toolbar was not visible/or in > position. Fixed that as well. > > Let me know if you find more. :/ > > > On Thu, Oct 11, 2018 at 3:38 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Team found few more issues. Calendar control totally messed up. The >> bootstrap-datetimepicker package does not work with Bootstrap 4. >> Fortunately, there exists one package which is advanced version of the >> same - https://tempusdominus.github.io/bootstrap-4/. With minimum >> changes I am able bring back the calendar control. (Create Role -> Account >> expiry) >> Also fixed sort filter dropdown in query tool. >> >> Kindly review. >> >> >> On Wed, Oct 10, 2018 at 5:16 PM Dave Page wrote: >> >>> Thanks, patch applied. >>> >>> On Wed, Oct 10, 2018 at 11:41 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Ohh :/ Attached is the rebased patch - v4. On Wed, Oct 10, 2018 at 3:55 PM Dave Page wrote: > Hi > > Did you rebase this? It doesn't apply for me: > > (pgadmin4) dpage@hal:*~/git/pgadmin4*$ git apply > ~/Downloads/RM3562_v3.patch > > error: patch failed: web/pgadmin/static/scss/_select2.overrides.scss:2 > > error: web/pgadmin/static/scss/_select2.overrides.scss: patch does not > apply > > /Users/dpage/Downloads/RM3562_v3.patch:6137: new blank line at EOF. > > + > > On Wed, Oct 10, 2018 at 11:23 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> Attached is the updated patch - v3. I missed the user login related >> stuffs. The patch includes changes for those. >> I have also changed the colour style of login page. >> >> Kindly review. >> >> On Tue, Oct 9, 2018 at 4:18 PM Dave Page wrote: >> >>> Hi >>> >>> Almost there - unfortunately I found another couple of issues in >>> server mode (placement of the username, and formatting of the menu). >>> Please >>> see the attached screenshot. >>> >>> Regards, Dave. >>> >>> On Tue, Oct 9, 2018 at 10:13 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Hackers, Attached it the updated patch v2. Kindly review. On Mon, Oct 8, 2018 at 5:55 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Mon, Oct 8, 2018 at 4:06 PM Dave Page > wrote: > >> Hi >> >> On Fri, Oct 5, 2018 at 1:51 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to migrate pgAdmin4 currently based on >>> Bootstrap 3, to be Bootstrap 4 compatible. The idea is to move to >>> Bootstrap >>> 4 with minimum possible changes in pgAdmin4. I have also used >>> bootstrap >>> scss (and not the dist file of bootstrap) to customize bootstrap as >>> per the >>> need of pgAdmin4. >>> I have done a basic testing. It may not look alike to that with >>> Bootstrap 3, but it is possible that you may find some discrepancy >>> (which >>> was proper before :P ). Kindly let me know. >>> >> >> Looks good. I spotted a couple of issues though: >> >> - The menu bar is a different colour now (dark grey rather than >> black). Not the end of the world, but I thought I'd mention it. >> > I thought of keeping the bootstrap default dark color. Will customize > it to black. > >> - The subnode control has lost some of it's styling. This does >> need to be fixed I think. See the attached screenshot ( boostrap 3 >> is on >> the left). >> > Yes. Will send the fix with updated patch. > >> Thanks. >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > >>>
