Extra executive bits in the source code

[Devrim Gündüz]

Hi,

Fedora 28 included an extra feature while building packages, and now throwing
these warnings:

+ /usr/lib/rpm/redhat/brp-mangle-shebangs '' ''
*** WARNING: 
./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/static/css/bootstrap.overrides.css
 is executable but has empty or no shebang, removing executable bit
*** WARNING: 
./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/browser/server_groups/servers/tablespaces/templates/tablespaces/sql/default/alter.sql
 is executable but has empty or no shebang, removing executable bit
*** WARNING: 
./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/browser/server_groups/servers/tablespaces/templates/tablespaces/sql/9.2_plus/properties.sql
 is executable but has empty or no shebang, removing executable bit
*** WARNING: 
./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/templates/base.html is 
executable but has empty or no shebang, removing executable bit
*** WARNING: 
./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/misc/file_manager/static/js/utility.js
 is executable but has empty or no shebang, removing executable bit
*** WARNING: 
./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/misc/file_manager/static/css/file_manager.css
 is executable but has empty or no shebang, removing executable bit
*** WARNING: 
./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/misc/file_manager/templates/file_manager/index.html
 is executable but has empty or no shebang, removing executable bit

Should these be fixed?

Regards,

-- 
Devrim Gündüz
EnterpriseDB: https://www.enterprisedb.com
PostgreSQL Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

signature.asc
Description: This is a digitally signed message part

pgAdmin 4 commit: Fix file permissions per Devrim

[Dave Page]

Fix file permissions per Devrim

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9821e28da5db3028cbaf2a762cefd580bf336c31

Modified Files
--
.../servers/tablespaces/templates/tablespaces/sql/9.2_plus/properties.sql | 0
.../servers/tablespaces/templates/tablespaces/sql/default/alter.sql   | 0
web/pgadmin/misc/file_manager/static/css/file_manager.css | 0
web/pgadmin/misc/file_manager/static/js/utility.js| 0
web/pgadmin/misc/file_manager/templates/file_manager/index.html   | 0
web/pgadmin/static/css/bootstrap.overrides.css| 0
web/pgadmin/templates/base.html   | 0
7 files changed, 0 insertions(+), 0 deletions(-)

Re: Extra executive bits in the source code

[Dave Page]

Thanks - fixed!

On Tue, Jun 19, 2018 at 12:14 PM, Devrim Gündüz  wrote:

>
> Hi,
>
> Fedora 28 included an extra feature while building packages, and now
> throwing
> these warnings:
>
> + /usr/lib/rpm/redhat/brp-mangle-shebangs '' ''
> *** WARNING: ./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/
> static/css/bootstrap.overrides.css is executable but has empty or no
> shebang, removing executable bit
> *** WARNING: ./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/
> browser/server_groups/servers/tablespaces/templates/
> tablespaces/sql/default/alter.sql is executable but has empty or no
> shebang, removing executable bit
> *** WARNING: ./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/
> browser/server_groups/servers/tablespaces/templates/
> tablespaces/sql/9.2_plus/properties.sql is executable but has empty or no
> shebang, removing executable bit
> *** WARNING: 
> ./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/templates/base.html
> is executable but has empty or no shebang, removing executable bit
> *** WARNING: ./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/
> misc/file_manager/static/js/utility.js is executable but has empty or no
> shebang, removing executable bit
> *** WARNING: ./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/
> misc/file_manager/static/css/file_manager.css is executable but has empty
> or no shebang, removing executable bit
> *** WARNING: ./usr/lib/python3.6/site-packages/pgadmin4-web/pgadmin/
> misc/file_manager/templates/file_manager/index.html is executable but has
> empty or no shebang, removing executable bit
>
> Should these be fixed?
>
> Regards,
>
> --
> Devrim Gündüz
> EnterpriseDB: https://www.enterprisedb.com
> PostgreSQL Consultant, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR




-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin4][patch] Correct issue on external tables

[Joao De Almeida Pereira]

Hi Hackers,

You can find attached a patch that corrects the RM #3431.

When trying to retrieve the DDL of an external table and exceptions was
being raised.

Thanks
Joao
diff --git a/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql b/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql
index a7f64a5f..25ebf96c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql
@@ -48,7 +48,7 @@ OPTIONS (
 )
 {% endif %}
 ENCODING '{{ table.pgEncodingToChar }}'
-{% if table.rejectLimit and table.rejectLimit|length > 0 %}
+{% if table.rejectLimit and table.rejectLimit > 0 %}
 {%   if table.errorTableName and table.errorTableName|length > 0 %}
 LOG ERRORS {% endif %}SEGMENT REJECT LIMIT {{ table.rejectLimit }} {{ rejectionLimit }}
 {% endif %}

pgAdmin 4 commit: Allow the connection timeout to be configured on a pe

[Dave Page]

Allow the connection timeout to be configured on a per-server basis. Fixes #3388

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a06acb678af27d7d45c8cab2e9fcffae7af08e0
Author: Akshay Joshi 

Modified Files
--
docs/en_US/images/server_advanced.png  | Bin 46133 -> 71981 bytes
docs/en_US/release_notes_3_1.rst   |   1 +
docs/en_US/server_dialog.rst   |   1 +
web/migrations/versions/493cd3e39c0c_.py   |  28 
.../browser/server_groups/servers/__init__.py  |   4 ++
.../server_groups/servers/static/js/server.js  |   6 +++
.../tests/test_add_server_with_connect_timeout.py  |  47 +
web/pgadmin/browser/static/js/datamodel.js |  10 ++---
web/pgadmin/model/__init__.py  |   3 +-
web/pgadmin/tools/backup/__init__.py   |  20 -
web/pgadmin/tools/maintenance/__init__.py  |  10 -
web/pgadmin/tools/restore/__init__.py  |  10 -
web/pgadmin/utils/driver/psycopg2/connection.py|   9 ++--
.../utils/driver/psycopg2/server_manager.py|   2 +
14 files changed, 138 insertions(+), 13 deletions(-)

Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog

[Dave Page]

Thanks, applied.

On Tue, Jun 19, 2018 at 12:18 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:

> Hi
>
> On Tue, Jun 19, 2018 at 2:11 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi
>>
>> On Mon, Jun 18, 2018 at 10:39 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch for Feature #3388 Allow to set the connection
 timeout on the server properties dialog. Please review it.

>>>
>>> I took a quick look at this and had some questions/comments:
>>>
>>> - Doc updates seem to be missing.
>>>
>>
>> My bad, again I forgot to do that. Fixed in attached patch.
>>
>>>
>>> - The timeout should be passed through to external utilities like
>>> pg_dump/pg_restore.
>>>
>>
>>I am not able to see any option to set the timeout for
>> pg_dump/pg_restore.
>>
>
>   Fixed it by setting environment variable "PGCONNECT_TIMEOUT".
> Attached is the new updated patch.
>
>
>>
>>> - Can/should the timeout be extended to the SSH tunnels?
>>>
>>
>>  No option to set the timeout, I have check the sshtunnel's
>> documentation .
>>
>>>
>>> - Any refactoring opportunities in the code you're touching?
>>>
>>
>> Not seen any logic that can be refactored.
>>
>>>
>>> Thanks.
>>>
>>
>>Apart from above, I have found one issue in *datamodel.js* when
>> setting the min value to 0 for input control, it didn't work.
>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix the RE-SQL generation for GreenPlum external tabl

[Dave Page]

Fix the RE-SQL generation for GreenPlum external tables. Fixes #3431

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=155f82676d114203e31d22da9b2d1a27bae44d60
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
docs/en_US/release_notes_3_1.rst   | 3 ++-
.../databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql   | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Re: [pgadmin4][patch] Correct issue on external tables

[Dave Page]

Thanks, patch applied.

On Tue, Jun 19, 2018 at 9:16 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> You can find attached a patch that corrects the RM #3431.
>
> When trying to retrieve the DDL of an external table and exceptions was
> being raised.
>
> Thanks
> Joao
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company