Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node

2018-06-09 Thread Murtuza Zabuawala
Hi Dave,

Sorry, the previous patch had a typo, Here's an updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jun 7, 2018 at 2:32 PM, Dave Page  wrote:

> Hi
>
> On Wed, Jun 6, 2018 at 6:04 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the regression issue introduced with RM#3271
>> commit due to which label is not displaying under the graphical explain
>> node, I've attached the screenshot in RM for your reference.
>>
>
> I see the labels, but the popups are not displaying on mouseover/hover
> like they used to. Can you look into that please?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_3404_v1.diff
Description: Binary data


PGAgent 4.0 error feedback

2018-06-09 Thread Rob Emery
Hi Guys,

I've been testing out PGAgent 4 (build today from master at commit
86ca5c5ed1ad572075ba27e05e4680ebdf5b9feb) to check the connection
handling on error is still fixed with the boost reimplementation
(which it is!)
and noticed a few issues compared to PGAgent 3 around feedback to the
user if the connection string is incorrect.

I've tested with incorrect username and password, user not in the hba,
db doesn't exist, postgresql not running on the host (or incorrect
hostaddr) and 4 seems to always returns the error :
`
ERROR: Couldn't find the function 'pgagent_schema_version' - please
run pgagent_upgrade.sql.
`

whereas 3.4.1 tends to output from the pgconnection itself like:
`
Sat Jun  9 21:32:13 2018 : WARNING: Couldn't create the primary
connection (attempt 1): FATAL:  no pg_hba.conf entry for host
"172.30.0.16", user "pgagent_login_role", database
"pgagent_login_role", SSL on
FATAL:  no pg_hba.conf entry for host "172.30.0.16", user
"pgagent_login_role", database "pgagent_login_role", SSL off
`

which at least points the user towards the actual error!

Not sure if this is known already, but I thought I'd raise it prior to release.

Thanks,
Rob
--

-- 
 


Codeweavers May Newsletter 
  l  Codeweavers April 
Finance Trends 



April’s Dealer Highlights 
 


_
_



*Phone:* 0800 021 0888   Email: contac...@codeweavers.net 

Codeweavers Ltd | Barn 4 | Dunston 
Business Village | Dunston | ST18 9AB
Registered in England and Wales No. 
04092394 | VAT registration no. 974 9705 63