pgAdmin 4 commit: PEP8 fixes. Fixes #3175

[Dave Page]

PEP8 fixes. Fixes #3175

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06ff05762e9bba0dd298c540afaf352dad747b28
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/browser/__init__.py|  22 +--
.../server_groups/servers/databases/__init__.py| 130 --
.../servers/databases/tests/test_db_add.py |   1 -
.../server_groups/servers/databases/tests/utils.py | 149 ++---
.../server_groups/servers/databases/utils.py   |   5 +-
web/pgadmin/browser/tests/test_change_password.py  |  29 ++--
web/pgadmin/browser/tests/test_login.py|  12 +-
web/pgadmin/browser/tests/test_version_in_range.py |  80 ++-
web/pgadmin/browser/tests/utils.py |  24 ++--
9 files changed, 274 insertions(+), 178 deletions(-)

Re: [pgAdmin4][RM#3175] Fix PEP-8 issues

[Dave Page]

Thanks, applied!

On Mon, Mar 5, 2018 at 4:23 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Thanks Joao for reviewing.
>
>
> On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Murtuza,
>>
>> Looks good, and all tests are green. I run the commands provided and
>> nothing pops up.
>>
>> Only missing 374 :D
>>
> ​:-) ​
>
>
>>
>> Thanks
>> Joao
>>
>> On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix PEP8 issues in Browser & Database modules,
>>> pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py
>>> pycodestyle --config=.pycodestyle pgadmin/browser/tests/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/__init__.py
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/tests/
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin4][patch] GreenPlum function statistics through an exception

[Dave Page]

Thanks, applied.

On Mon, Mar 5, 2018 at 2:25 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
> You can find attached the resolution for issue 3176.
> When trying to retrieve the statistics from a function in a GreenPlum
> database an error is displayed, To fix this for version 5.X we decided to
> remove the ability to get statistics.
>
> Thanks
> Joao
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Disable function statistics on Greenplum. Fixes #3176

[Dave Page]

Disable function statistics on Greenplum. Fixes #3176

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1ab47c10c910f8cad1247f8520c47cb01bee072
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
.../schemas/functions/static/js/function.js|  4 ++-
.../misc/statistics/static/js/statistics.js|  6 ++--
.../static/js/misc/statistics/statistics.js| 16 ++
.../javascript/misc/statistics/statistics_spec.js  | 36 ++
4 files changed, 59 insertions(+), 3 deletions(-)

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

[Dave Page]

Hi

On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Murtuza,
>
> The code change works, and I passed the patches through our pipeline and
> everything is green.
> Personally I would love this bug fixes to have refactored the function
> into smaller chunk and made it more readable so that the next time someone
> need to check out a problem in the same area it is easier. I understand
> that without a good test coverage it is hard to have confidence while
> refactoring, but we need to start somewhere.
>

Are you planning to look into this Murtuza?


>
> @Hackers
> Here is a video that I saw some time ago about refactoring existing code
> and code complexity that is very interesting
> https://www.youtube.com/watch?v=8bZh5LMaSmE
> In this video Sandi Metz does the Gilded Rose Kata in a talk in RailsConf
> 2014, and with it tries to demonstrate that code can be refactored and with
> that it make the code much more simpler. But the journey is not always
> simple and the complexity will increase before it get simpler. It is a good
> example of something that we can try with our code.
>

Nice!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

[Murtuza Zabuawala]

On Wed, Mar 7, 2018 at 6:12 PM, Dave Page  wrote:

> Hi
>
> On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Murtuza,
>>
>> The code change works, and I passed the patches through our pipeline and
>> everything is green.
>> Personally I would love this bug fixes to have refactored the function
>> into smaller chunk and made it more readable so that the next time someone
>> need to check out a problem in the same area it is easier. I understand
>> that without a good test coverage it is hard to have confidence while
>> refactoring, but we need to start somewhere.
>>
>
> Are you planning to look into this Murtuza?
>
​Yes Dave, I am working on another issue, I'll pick up after that.​


>
>
>>
>> @Hackers
>> Here is a video that I saw some time ago about refactoring existing code
>> and code complexity that is very interesting
>> https://www.youtube.com/watch?v=8bZh5LMaSmE
>> In this video Sandi Metz does the Gilded Rose Kata in a talk in RailsConf
>> 2014, and with it tries to demonstrate that code can be refactored and with
>> that it make the code much more simpler. But the journey is not always
>> simple and the complexity will increase before it get simpler. It is a good
>> example of something that we can try with our code.
>>
>
> Nice!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

[Murtuza Zabuawala]

Hi Joao,

On Tue, Mar 6, 2018 at 10:56 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello,
>
> I just sent a video that talks exactly about this, in the journey to have
> a more maintainable code and easier to navigate, we sometimes increase
> complexity for a period of time in order to get to the state that we want
> to be.
>
> In particular in this example I tried the following:
> 1. Demonstrate that we do not need templates to get things done
>
That raised questions in mind,
​Why?
​
I
​f templates are bad then why every other framework provides them?
I've seen many projects using templates to serve HTML code, In pgAdmin4
also we are using templates just as starting point to load UI whether its
main page or query tool/debugger page.

2. How to get the information we need to the place where it is needed, like
> moving the information of the server mode to the front end where decisions
> should be made
>

​I agree and that's what we are doing in pgAdmin4.

> ​
>
>

> Sometimes just because we can do a simple change, doesn't mean we should
> do it because it might bit us in the future.
>
>
> The PoC looks like a huge amount of code that is not even related to
> Gravatar, when we could just change a template file or 2, I hear that. But
> what I am talking about is a change of paradigm and Architecture where the
> Frontend is responsible for displaying the application and the Backend is
> only responsible for giving information that the Frontend Requires. Instead
> of the current mixed architecture where some things are done in the
> Frontend some things are done in the Backend a more predictable
> architecture would benefit the application and specially the developers.
> ​
>
>

> That is why I always insist in refactor code as much as possible to ensure
> that the code is readable and helps people follow it. This doesn't mean
> abstracting classes of functions to make to code more generic, it means as
> an example to split 1 functions of 500 lines into 10 functions of 50 lines
> each or even 50 functions of 10 lines each but that are readable and not a
> "goat trails" of ifs and elses that are very hard to read and follow.
>

 ​I
​totally ​
agree that refacto
​ring​
code is good practice but in this
​particular ​
case I
​still ​
think
​that ​
using
​HTML ​
template is
​much ​
simpler and elegant solution
​.​

>
>
> Thanks
> Joao
>
> On Tue, Mar 6, 2018 at 4:49 AM Dave Page  wrote:
>
>> Hi
>>
>> On Tue, Mar 6, 2018 at 6:59 AM, Murtuza Zabuawala > enterprisedb.com> wrote:
>>
>>> Hi Joao,
>>>
>>> Your suggestion is good but in my own opinion it is overkill just to
>>> replace code {{ username| gravatar }} as rest of the syntax is pure
>>> HTML, This makes code much simpler and easy to understand.
>>> Apart from that we will be rendering 'index.html' template anyways and I
>>> don't see any extra overhead.
>>>
>>
>> For this particular issue, I'm inclined to agree.
>>
>> I do however, like the idea of caching preferences (no-brainer really,
>> assuming we ensure we update/invalidate the cache when needed), and using
>> promises for accessing them.
>>
>>
>>>
>>> I may be wrong, Let's wait for the input from other community members.
>>>
>>> Regards,
>>> Murtuza
>>>
>>> On Tue, Mar 6, 2018 at 1:17 AM, Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hello,
 I understand that, but what do we win by using it? As you have noticed
 by now I am not very fond of using templates for everything, and I believe
 this is one of the things that we can skip templates.
 We might even shift this to a frontend concern and if we want there are
 node libraries to get gravatars.

 I was able to create a PoC as a sample of what I was talking about:
  - Add gravatar library to package.json
  - Created a Preferences cache. (js/preferences.js)
- So this was the concept I was talking about in a previous email we
 talked about caching.
   the getConfiguration and the getAllConfiguration are not great
 names, but they return a Promise that is consumed in the load_gravatar. The
 idea here is that we are caching the pgAdmin settings and when need need to
 consume them, we wait for it to be available.
  - load_gravatar is using the pattern to retrieve the configuration
 from a possible cache and then apply the gravatar


 Things that need to be revisited in the PoC:
 - No tests, just some spiked code
 - Did not retrieve the username from the backend, we need to create an
 endpoint that give us this
 - The url is hardcoded to get the configuration
 - Maybe the Preferences is not the correct place to get server_mode
 configuration not sure, what do you think?


 Thanks
 Joao

 On Mon, Mar 5, 2018 at 11:21 AM Murtuza Zabuawala >>> enterprisedb.com> wrote:

> Hi Joao,
>
> We are using Flask-Gravatar 
>

pgAdmin 4 commit: Ensure all messages are retrieved from the server in

[Dave Page]

Ensure all messages are retrieved from the server in the Query Tool. Fixes #3094

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3c303e4559966de038263f7a2c5e0969947aae9
Author: Khushboo Vashi 

Modified Files
--
.../feature_tests/keyboard_shortcut_test.py|   4 +-
.../tools/sqleditor/tests/test_poll_query_tool.py  | 112 +
web/pgadmin/utils/driver/abstract.py   |   2 +
web/pgadmin/utils/driver/psycopg2/__init__.py  |  77 ++
4 files changed, 148 insertions(+), 47 deletions(-)

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

[Dave Page]

Thanks - patch applied.

On Tue, Mar 6, 2018 at 2:57 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Khushboo,
> Thanks for the changes here. Now everything looks good, and the tests all
> pass.
>
> Thanks
> Joao
>
> On Tue, Mar 6, 2018 at 5:09 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> On Mon, Mar 5, 2018 at 8:42 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello Khushboo,
>>>
>> Looks like we are almost doen, just missing one PEP-8 issue:
>>> → pycodestyle --config=.pycodestyle pgadmin/tools
>>> pgadmin/tools/sqleditor/tests/test_poll_query_tool.py:46: [E126]
>>> continuation line over-indented for hanging indent
>>> 1   E126 continuation line over-indented for hanging indent
>>> 1
>>>
>>>
>>> Thanks Joao.
>> Please find the attached updated patch.
>>
>>> The tests run successfully in our CI pipeline.
>>>
>>> Thanks
>>> Joao
>>>
>>> Thanks,
>> Khushboo
>>
>>> On Sun, Mar 4, 2018 at 11:51 PM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 On Fri, Mar 2, 2018 at 6:55 PM, Dave Page  wrote:

> Could you rebase this please? It no longer applies.
>
> Please find the attached updated patch.

> Thanks.
>
> On Thu, Mar 1, 2018 at 5:56 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Joao,
>>
>> Thanks for reviewing.
>>
>> On Wed, Feb 28, 2018 at 8:55 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello Khushboo,
>>> After reviewing the patch I have the gut feeling that we do not have
>>> enough test coverage on this issue, specially due to the intricate while
>>> loop and conditions around the polling.
>>> I think that this deserve Unit tests around it, When I say Unit Test
>>> I am not talking about executing queries against the database, but do 
>>> some
>>> stubbing of the database so that we can control the flow that we want.
>>>
>> You are right. It needs more unit testing. I have checked below
>> scenarios:
>> 1. Returns 2 notices with data output
>> 2. Returns 1000 notices with data output
>> 3. No notices with data output
>>
>> By running above, I have checked, each time returned notices are
>> accurate, no old notices are getting appended, it does not affect with 
>> the
>> amount of messages (few, none or more).  Also, with the updated patch, I
>> have made sure that all these queries run with the single transaction id
>> (same connection).
>>
>> So, please let me know if you think I can add more things to this.
>>
>>>
>>>
>> It is a temptation to try to always do a Feature Test to test what we
>>> want because it is "easier" to write and ultimately it is what users 
>>> see,
>>> but while 1 Feature Test runs we can run 200 Unit Tests that give us 
>>> much
>>> more confidence that the code is doing what we expect it to do.
>>>
>>> Right, so added regression tests instead of feature tests.
>>
>> This being said, I run the tests on the CI Pipeline and all tests
>>> pass. Running pycodestyle fails due to some line sizes on the
>>> psycopg2/__init__py. I believe that it is not what you changed, but 
>>> since
>>> you were changing the file it can be fixed it is just:
>>>
>>> pgadmin/utils/driver/psycopg2/__init__.py:1276: [E501] line too
>>> long (81 > 79 characters)
>>> pgadmin/utils/driver/psycopg2/__init__.py:1277: [E501] line too
>>> long (91 > 79 characters)
>>> pgadmin/utils/driver/psycopg2/__init__.py:1282: [E501] line too
>>> long (81 > 79 characters)
>>> pgadmin/utils/driver/psycopg2/__init__.py:1283: [E501] line too
>>> long (91 > 79 characters)
>>> 4   E501 line too long (81 > 79 characters)
>>>
>>> Fixed. Thanks for pointing out.
>>
>>>
>>> Thanks
>>> Joao
>>>
>>>
>>> On Wed, Feb 28, 2018 at 6:49 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 On Mon, Feb 26, 2018 at 10:02 PM, Dave Page 
 wrote:

> Argh, I ran some tests, but didn't spot any lost messages in the
> tests I ran. I'll revert the patch.
>
> Khushboo;
>
> Please look at the following:
>
> - Fix the patch so it doesn't drop messages.
>
 Fixed.
 By default, the notice attribute of the connection object of
 psycopg 2 only stores 50 notices. Once it reaches to 50 it starts from 
 1
 again.
 To fix this I have changed the notice attribute from list to deque
 to append more messages. Currently I have kept the maximum limit at a 
 time
 of the notice attribute is 10 (in a single poll).

> - Add regression tests to make sure it doesn't break in the
> future. 

Build failed in Jenkins: pgadmin4-master-python35 #511

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Ensure all messages are retrieved from the server in the Query Tool.

--
[...truncated 605.33 KB...]
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
PackageAddTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymAddTestCase (Default Node URL)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PackageGetTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsDeleteTestCase (Delete resource groups)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
PackageAddTestCase (Fetch Package Node URL)

EDB Postgres AS 9.6:

284 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
3 tests skipped:
TestSSLConnection (Test for SSL connection)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)

EDB Postgres AS 9.4:

284 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
3 tests skipped:
TestSSLConnection (Test for SSL connection)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)

EDB Postgres AS 9.3:

280 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
7 tests skipped:
ResourceGroupsDeleteTestCase (Delete resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)
TableU

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

[Dave Page]

Hi

On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to disable Gravatar image in Server mode.
>
> Requirments & Issues:
> - For security reasons.
> - For systems which do not have internet access.
> - Hangs pgAdmin4 while loading the page if connection has no internet
> access (as described in the ticket)
>

If I run with the Gravatar disabled, then I get the following regression
failure:

==
FAIL: runTest (pgadmin.browser.tests.test_login.LoginTestCase)
Valid_Credentials
--
Traceback (most recent call last):
  File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_login.py",
line 93, in runTest
self.assertTrue(self.respdata in response.data.decode('utf8'))
AssertionError: False is not true

--

It's fine when Gravatar is enabled (and the rest of the patch does too).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python27 #510

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Ensure all messages are retrieved from the server in the Query Tool.

--
[...truncated 605.98 KB...]
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.2:

Build failed in Jenkins: pgadmin4-master-python26 #637

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Ensure all messages are retrieved from the server in the Query Tool.

--
[...truncated 608.99 KB...]
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.2:

Build failed in Jenkins: pgadmin4-master-python33 #507

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Ensure all messages are retrieved from the server in the Query Tool.

--
[...truncated 605.81 KB...]
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
TestSSLConnection (Test for SSL connection)

EDB Postgres AS 9.3:

280 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
7 tests skipped:
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsGetTestCase (Get resource groups)
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table)

EDB Postgres AS 9.2:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
ResourceGroupsPutTestCase (Put resource groups)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
ViewsAddTestCase (Add materialized view under schema node)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
ResourceGroupsGetTestCase (Get resource groups)
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
ViewsUpdateTestCase (Update materialized view under schema node)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ViewsDeleteTestCase (Delete materialized view under schema node)
ViewsGetTestCase (Get materialized view under schema node)
ResourceGroupsDeleteTestCase (Delete resource groups)

PostgreSQL 9.2:

265 tests passed
0 tests failed
23 tests skipped:
PackageDeleteTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
ViewsGetTestCase (Get materialized view under schema node)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
ViewsAddTestCase (Add materialized view under schema node)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Dave Page]

Khushboo, can you look at this ASAP please? It passed tests on my machine,
but Jenkins isn't happy.

Thanks.

On Wed, Mar 7, 2018 at 2:01 PM, pgAdmin 4 Jenkins 
wrote:

> See  507/display/redirect?page=changes>
>
> Changes:
>
> [Dave Page] Ensure all messages are retrieved from the server in the Query
> Tool.
>
> --
> [...truncated 605.81 KB...]
> PackageDeleteTestCase (Fetch Package Node URL)
> ResourceGroupsPutTestCase (Put resource groups)
> SynonymPutTestCase (Fetch synonym Node URL)
> PackageAddTestCase (Fetch Package Node URL)
> PackageGetTestCase (Fetch Package Node URL)
> ResourceGroupsAddTestCase (Add resource groups)
> SynonymDeleteTestCase (Fetch synonym Node URL)
> ResourceGroupsGetTestCase (Get resource groups)
> SynonymGetTestCase (Fetch synonym Node URL)
> PackagePutTestCase (Fetch Package Node URL)
> SynonymAddTestCase (Default Node URL)
> ResourceGroupsDeleteTestCase (Delete resource groups)
> TestSSLConnection (Test for SSL connection)
>
> EDB Postgres AS 9.3:
>
> 280 tests passed
> 1 test failed:
> TestPollQueryTool (When query tool polling returns
> messages with result data-set)
> 7 tests skipped:
> ResourceGroupsDeleteTestCase (Delete resource groups)
> ResourceGroupsPutTestCase (Put resource groups)
> TableAddTestCase (Create Range partitioned table with 2
> partitions,
> Create List partitioned table with
> 2 partitions)
> ResourceGroupsAddTestCase (Add resource groups)
> TestSSLConnection (Test for SSL connection)
> ResourceGroupsGetTestCase (Get resource groups)
> TableUpdateTestCase (Create partitions of existing list
> partitioned table,
> Detach partition from existing
> list partitioned table,
> Attach partition to existing list
> partitioned table,
> Attach partition to existing range
> partitioned table,
> Detach partition from existing
> range partitioned table,
> Create partitions of existing
> range partitioned table)
>
> EDB Postgres AS 9.2:
>
> 272 tests passed
> 1 test failed:
> TestPollQueryTool (When query tool polling returns
> messages with result data-set)
> 15 tests skipped:
> ResourceGroupsPutTestCase (Put resource groups)
> EventTriggerGetTestCase (Fetch Event Trigger Node URL)
> ViewsAddTestCase (Add materialized view under schema node)
> ResourceGroupsAddTestCase (Add resource groups)
> TestSSLConnection (Test for SSL connection)
> EventTriggerAddTestCase (Fetch Event Trigger Node URL)
> ResourceGroupsGetTestCase (Get resource groups)
> TableUpdateTestCase (Create partitions of existing list
> partitioned table,
> Detach partition from existing
> list partitioned table,
> Attach partition to existing list
> partitioned table,
> Attach partition to existing range
> partitioned table,
> Detach partition from existing
> range partitioned table,
> Create partitions of existing
> range partitioned table)
> EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
> EventTriggerPutTestCase (Fetch Event Trigger Node URL)
> ViewsUpdateTestCase (Update materialized view under schema
> node)
> TableAddTestCase (Create Range partitioned table with 2
> partitions,
> Create List partitioned table with
> 2 partitions)
> ViewsDeleteTestCase (Delete materialized view under schema
> node)
> ViewsGetTestCase (Get materialized view under schema node)
> ResourceGroupsDeleteTestCase (Delete resource groups)
>
> PostgreSQL 9.2:
>
> 265 tests passed
> 0 tests failed
> 23 tests skipped:
> PackageDeleteTestCase (Fetch Package Node URL)
> SynonymPutTestCase (Fetch synonym Node URL)
> ViewsGetTestCase (Get materialized view under schema node)
> SynonymDeleteTestCase (Fetch synonym Node URL)
> ResourceGroupsAddTestCase (Add resource groups)
> ViewsAddTestCase (Add material

Build failed in Jenkins: pgadmin4-master-python34 #501

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Ensure all messages are retrieved from the server in the Query Tool.

--
[...truncated 605.26 KB...]
272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing list 
partitioned table)
ViewsGetTestCase (Get materialized view under schema node)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ViewsDeleteTestCase (Delete materialized view under schema node)
ViewsAddTestCase (Add materialized view under schema node)
ResourceGroupsPutTestCase (Put resource groups)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsAddTestCase (Add resource groups)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
TestSSLConnection (Test for SSL connection)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
ViewsUpdateTestCase (Update materialized view under schema node)

PostgreSQL 9.6:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing list 
partitioned table)
SynonymAddTestCase (Default Node URL)
PackageGetTestCase (Fetch Package Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)
PackageAddTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)

PostgreSQL 9.2:

265 tests passed
0 tests failed
23 tests skipped:
SynonymAddTestCase (Default Node URL)
PackageGetTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
ViewsUpdateTestCase (Update materialized view under schema node)
SynonymPutTestCase (Fetch synonym Node URL)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
   

Build failed in Jenkins: pgadmin4-master-python36 #501

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Ensure all messages are retrieved from the server in the Query Tool.

--
[...truncated 605.34 KB...]
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.4:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.5:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
p

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

[Murtuza Zabuawala]

Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Mar 7, 2018 at 6:14 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

>
> On Wed, Mar 7, 2018 at 6:12 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hi Murtuza,
>>>
>>> The code change works, and I passed the patches through our pipeline and
>>> everything is green.
>>> Personally I would love this bug fixes to have refactored the function
>>> into smaller chunk and made it more readable so that the next time someone
>>> need to check out a problem in the same area it is easier. I understand
>>> that without a good test coverage it is hard to have confidence while
>>> refactoring, but we need to start somewhere.
>>>
>>
>> Are you planning to look into this Murtuza?
>>
> ​Yes Dave, I am working on another issue, I'll pick up after that.​
>
>
>>
>>
>>>
>>> @Hackers
>>> Here is a video that I saw some time ago about refactoring existing code
>>> and code complexity that is very interesting
>>> https://www.youtube.com/watch?v=8bZh5LMaSmE
>>> In this video Sandi Metz does the Gilded Rose Kata in a talk in
>>> RailsConf 2014, and with it tries to demonstrate that code can be
>>> refactored and with that it make the code much more simpler. But the
>>> journey is not always simple and the complexity will increase before it get
>>> simpler. It is a good example of something that we can try with our code.
>>>
>>
>> Nice!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


RM_2989_v1.diff
Description: Binary data

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Khushboo Vashi]

Hi Dave,

On Wed, Mar 7, 2018 at 7:34 PM, Dave Page  wrote:

> Khushboo, can you look at this ASAP please? It passed tests on my machine,
> but Jenkins isn't happy.
>
> I have tried to reproduce the issue with many combination but couldn't
reproduce it.
With the help of logs, I have tried to fix it. Can you please check this
fix is helpful or not?

> Thanks.
>
> On Wed, Mar 7, 2018 at 2:01 PM, pgAdmin 4 Jenkins 
> wrote:
>
>> See > 7/display/redirect?page=changes>
>>
>> Changes:
>>
>> [Dave Page] Ensure all messages are retrieved from the server in the
>> Query Tool.
>>
>> --
>> [...truncated 605.81 KB...]
>> PackageDeleteTestCase (Fetch Package Node URL)
>> ResourceGroupsPutTestCase (Put resource groups)
>> SynonymPutTestCase (Fetch synonym Node URL)
>> PackageAddTestCase (Fetch Package Node URL)
>> PackageGetTestCase (Fetch Package Node URL)
>> ResourceGroupsAddTestCase (Add resource groups)
>> SynonymDeleteTestCase (Fetch synonym Node URL)
>> ResourceGroupsGetTestCase (Get resource groups)
>> SynonymGetTestCase (Fetch synonym Node URL)
>> PackagePutTestCase (Fetch Package Node URL)
>> SynonymAddTestCase (Default Node URL)
>> ResourceGroupsDeleteTestCase (Delete resource groups)
>> TestSSLConnection (Test for SSL connection)
>>
>> EDB Postgres AS 9.3:
>>
>> 280 tests passed
>> 1 test failed:
>> TestPollQueryTool (When query tool polling returns
>> messages with result data-set)
>> 7 tests skipped:
>> ResourceGroupsDeleteTestCase (Delete resource groups)
>> ResourceGroupsPutTestCase (Put resource groups)
>> TableAddTestCase (Create Range partitioned table with 2
>> partitions,
>> Create List partitioned table
>> with 2 partitions)
>> ResourceGroupsAddTestCase (Add resource groups)
>> TestSSLConnection (Test for SSL connection)
>> ResourceGroupsGetTestCase (Get resource groups)
>> TableUpdateTestCase (Create partitions of existing list
>> partitioned table,
>> Detach partition from existing
>> list partitioned table,
>> Attach partition to existing list
>> partitioned table,
>> Attach partition to existing
>> range partitioned table,
>> Detach partition from existing
>> range partitioned table,
>> Create partitions of existing
>> range partitioned table)
>>
>> EDB Postgres AS 9.2:
>>
>> 272 tests passed
>> 1 test failed:
>> TestPollQueryTool (When query tool polling returns
>> messages with result data-set)
>> 15 tests skipped:
>> ResourceGroupsPutTestCase (Put resource groups)
>> EventTriggerGetTestCase (Fetch Event Trigger Node URL)
>> ViewsAddTestCase (Add materialized view under schema node)
>> ResourceGroupsAddTestCase (Add resource groups)
>> TestSSLConnection (Test for SSL connection)
>> EventTriggerAddTestCase (Fetch Event Trigger Node URL)
>> ResourceGroupsGetTestCase (Get resource groups)
>> TableUpdateTestCase (Create partitions of existing list
>> partitioned table,
>> Detach partition from existing
>> list partitioned table,
>> Attach partition to existing list
>> partitioned table,
>> Attach partition to existing
>> range partitioned table,
>> Detach partition from existing
>> range partitioned table,
>> Create partitions of existing
>> range partitioned table)
>> EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
>> EventTriggerPutTestCase (Fetch Event Trigger Node URL)
>> ViewsUpdateTestCase (Update materialized view under
>> schema node)
>> TableAddTestCase (Create Range partitioned table with 2
>> partitions,
>> Create List partitioned table
>> with 2 partitions)
>> ViewsDeleteTestCase (Delete materialized view under
>> schema node)
>> ViewsGetTestCase (Get materialized view under schema node)
>> ResourceGroupsDeleteTestCase (Delete resource groups)
>>
>> PostgreSQL 9.2:
>>
>> 265 tests passed
>> 0 tests failed
>> 23 tests skipped:
>> PackageDe

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

[Murtuza Zabuawala]

Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Mar 7, 2018 at 7:20 PM, Dave Page  wrote:

> Hi
>
> On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to disable Gravatar image in Server mode.
>>
>> Requirments & Issues:
>> - For security reasons.
>> - For systems which do not have internet access.
>> - Hangs pgAdmin4 while loading the page if connection has no internet
>> access (as described in the ticket)
>>
>
> If I run with the Gravatar disabled, then I get the following regression
> failure:
>
> ==
> FAIL: runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> Valid_Credentials
> --
> Traceback (most recent call last):
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_login.py",
> line 93, in runTest
> self.assertTrue(self.respdata in response.data.decode('utf8'))
> AssertionError: False is not true
>
> --
>
> It's fine when Gravatar is enabled (and the rest of the patch does too).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_3037_v1.diff
Description: Binary data

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Dave Page]

Hi

On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page  wrote:
>
>> Khushboo, can you look at this ASAP please? It passed tests on my
>> machine, but Jenkins isn't happy.
>>
>> I have tried to reproduce the issue with many combination but couldn't
> reproduce it.
> With the help of logs, I have tried to fix it. Can you please check this
> fix is helpful or not?
>

On my laptop I now get:

==
ERROR: runTest
(pgadmin.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)
When query tool polling returns messages with result data-set
--
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
line 104, in runTest
response_data['data']['additional_messages'])
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 802, in assertIn
if member not in container:
TypeError: argument of type 'NoneType' is not iterable

--

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update Jasmine to v3. Fixes #3182

[Dave Page]

Update Jasmine to v3. Fixes #3182

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e7316e2181c256ee33d0958043e6cb1147949647
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
web/package.json  | 2 +-
web/regression/javascript/gettext_spec.js | 3 ++-
web/yarn.lock | 6 +++---
3 files changed, 6 insertions(+), 5 deletions(-)

Re: [pagdmin][patch] Update jasmine #3182

[Dave Page]

Thanks, applied.

On Tue, Mar 6, 2018 at 8:56 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> Attached you can find the patch that updates the version of jasmine to 3.0
>
> Thanks
> Joao
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Insert rows correctly when a table has OIDs and a Pri

[Dave Page]

Insert rows correctly when a table has OIDs and a Primary Key in uppercase. 
Fixes #3135

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae5c13188d51d6bdb023c320c2be148ddad8eb55
Author: Khushboo Vashi 

Modified Files
--
.../templates/sqleditor/sql/default/insert.sql |   2 +-
.../sqleditor/tests/test_view_data_templates.py| 217 +
2 files changed, 218 insertions(+), 1 deletion(-)

Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

[Dave Page]

Thanks - applied.

On Wed, Mar 7, 2018 at 4:30 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Tue, Mar 6, 2018 at 8:35 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Khushboo,
>>
>> All tests pass on CI, and the code looks good. The only issue that I
>> found was the line:
>>  os.path.dirname(os.path.realpath(__file__)) + "/../templates"
>>
>> that will not work on windows.
>> So I updated your patch with the change and it should be ready to merge.
>>
>> Thanks Joao.
>
> Thanks
>> Joao
>>
>> On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Joao,
>>>
>>> Thanks for reviewing.
>>>
>>> On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hello Kushboo,

 Can we add some Unit test to ensure this does not happen again?

 Please find the attached patch with the unit tests.
>>>
 Thanks
 Joao

 Thanks,
>>> Khushboo
>>>
 On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM # 3135 - [Web based] Syntax
> error displayed when user try to insert data on table where primray key is
> in captial letters and table contains OIDS
>
> Thanks,
> Khushboo
>

>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python26 #638

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update Jasmine to v3. Fixes #3182

--
[...truncated 608.92 KB...]
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

272 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.2:

265 tests passed
0 tests fa

Build failed in Jenkins: pgadmin4-master-python36 #502

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update Jasmine to v3. Fixes #3182

[Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in

--
[...truncated 611.65 KB...]
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.4:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.5:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
  

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Khushboo Vashi]

On Wed, Mar 7, 2018 at 9:23 PM, Dave Page  wrote:

> Hi
>
> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page  wrote:
>>
>>> Khushboo, can you look at this ASAP please? It passed tests on my
>>> machine, but Jenkins isn't happy.
>>>
>>> I have tried to reproduce the issue with many combination but couldn't
>> reproduce it.
>> With the help of logs, I have tried to fix it. Can you please check this
>> fix is helpful or not?
>>
>
> On my laptop I now get:
>
> ==
> ERROR: runTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool.
> TestPollQueryTool)
> When query tool polling returns messages with result data-set
> --
> Traceback (most recent call last):
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/
> tests/test_poll_query_tool.py", line 104, in runTest
> response_data['data']['additional_messages'])
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/
> lib/python2.7/unittest/case.py", line 802, in assertIn
> if member not in container:
> TypeError: argument of type 'NoneType' is not iterable
>
> --
>
> Please provide some more details. Is this failing for particular server
version?
I am not getting any error with this patch and without this patch on PY2
and PY3 with a single/multiple servers.



> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Dave Page]

On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page  wrote:
>>>
 Khushboo, can you look at this ASAP please? It passed tests on my
 machine, but Jenkins isn't happy.

 I have tried to reproduce the issue with many combination but couldn't
>>> reproduce it.
>>> With the help of logs, I have tried to fix it. Can you please check this
>>> fix is helpful or not?
>>>
>>
>> On my laptop I now get:
>>
>> ==
>> ERROR: runTest (pgadmin.tools.sqleditor.tests
>> .test_poll_query_tool.TestPollQueryTool)
>> When query tool polling returns messages with result data-set
>> --
>> Traceback (most recent call last):
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
>> line 104, in runTest
>> response_data['data']['additional_messages'])
>>   File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
>> line 802, in assertIn
>> if member not in container:
>> TypeError: argument of type 'NoneType' is not iterable
>>
>> --
>>
>> Please provide some more details. Is this failing for particular server
> version?
> I am not getting any error with this patch and without this patch on PY2
> and PY3 with a single/multiple servers.
>

Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are the
package versions in the venv:

alabaster==0.7.10
alembic==0.9.6
args==0.1.0
Babel==2.3.4
backports.csv==1.0.4
beautifulsoup4==4.4.1
blinker==1.3
chromedriver-installer==0.0.6
click==6.6
clint==0.5.1
dateutils==0.6.6
docutils==0.13.1
extras==1.0.0
fixtures==3.0.0
Flask==0.11.1
Flask-Babel==0.11.1
Flask-Gravatar==0.4.2
Flask-HTMLmin==1.2
Flask-Login==0.3.2
Flask-Mail==0.9.1
Flask-Migrate==2.0.3
Flask-Paranoid==0.1.0
Flask-Principal==0.4.0
Flask-Script==2.0.6
Flask-Security==1.7.5
Flask-SQLAlchemy==2.1
Flask-WTF==0.12
funcsigs==1.0.2
html5lib==1.0b3
htmlmin==0.1.11
imagesize==0.7.1
importlib==1.0.3
itsdangerous==0.24
Jinja2==2.7.3
linecache2==1.0.0
Mako==1.0.7
MarkupSafe==0.23
minify==0.1.4
mock==2.0.0
passlib==1.6.2
pbr==3.1.1
pkginfo==1.4.1
psycopg2==2.7.3.2
pycodestyle==2.3.1
pycrypto==2.6.1
Pygments==2.2.0
pyperclip==1.5.32
pyrsistent==0.14.0
python-dateutil==2.5.0
python-editor==1.0.3
python-mimeparse==1.6.0
pytz==2014.10
requests==2.13.0
requests-toolbelt==0.7.1
selenium==3.3.3
simplejson==3.6.5
six==1.11.0
snowballstemmer==1.2.1
speaklater==1.3
Sphinx==1.5.3
SQLAlchemy==1.0.14
sqlparse==0.1.19
testscenarios==0.5.0
testtools==2.0.0
traceback2==1.4.0
unittest2==1.1.0
Werkzeug==0.9.6
WTForms==2.0.2
yuicompressor==2.4.8

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python34 #502

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update Jasmine to v3. Fixes #3182

[Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in

--
[...truncated 611.81 KB...]
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackageGetTestCase (Fetch Package Node URL)
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table)
SynonymAddTestCase (Default Node URL)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
PackagePutTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.5:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackageGetTestCase (Fetch Package Node URL)
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table)
SynonymAddTestCase (Default Node URL)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
PackagePutTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)

EDB Postgres AS 9.3:

284 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
7 tests skipped:
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsAddTestCase (Add resource groups)
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)

Build failed in Jenkins: pgadmin4-master-python33 #508

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update Jasmine to v3. Fixes #3182

[Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in

--
[...truncated 612.37 KB...]
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
PackageAddTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)

EDB Postgres AS 9.3:

284 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
7 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
TestSSLConnection (Test for SSL connection)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsPutTestCase (Put resource groups)

EDB Postgres AS 9.2:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ViewsDeleteTestCase (Delete materialized view under schema node)
ViewsUpdateTestCase (Update materialized view under schema node)
ResourceGroupsDeleteTestCase (Delete resource groups)
ViewsAddTestCase (Add materialized view under schema node)
ViewsGetTestCase (Get materialized view under schema node)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
ResourceGroupsAddTestCase (Add resource groups)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
ResourceGroupsGetTestCase (Get resource groups)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
TestSSLConnection (Test for SSL connection)
  

Build failed in Jenkins: pgadmin4-master-python27 #511

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update Jasmine to v3. Fixes #3182

[Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in

--
[...truncated 612.44 KB...]
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch P

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

[Dave Page]

Hi

On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA updated patch.
>
>
Using your example on the ticket, I added a "character varying (32)" column
with NOT NULL to the table. When I then edit the column, and turn off NOT
NULL (making no other changes), the SQL generated is:

ALTER TABLE public.test_drop
ALTER COLUMN col2 TYPE character varying (32) COLLATE
pg_catalog."default";
ALTER TABLE public.test_drop
ALTER COLUMN col2 DROP NOT NULL;

I didn't see that when turning off NOT NULL for col1.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Allow admins to disable the use of Gravatar if they c

[Dave Page]

Allow admins to disable the use of Gravatar if they choose. Fixes #3037

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=abf0b1a7ae0b57cf08ca196adc641f66868e20e5
Author: Murtuza Zabuawala 

Modified Files
--
web/config.py  |  5 ++
web/pgadmin/browser/__init__.py| 24 
web/pgadmin/browser/static/css/browser.css |  4 ++
web/pgadmin/browser/templates/browser/index.html   | 15 -
.../templates/browser/macros/gravatar_icon.macro   |  8 +++
.../browser/macros/static_user_icon.macro  |  3 +
.../browser/tests/test_gravatar_image_display.py   | 68 ++
web/pgadmin/browser/tests/test_login.py| 16 ++---
8 files changed, 122 insertions(+), 21 deletions(-)

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

[Dave Page]

Thanks, applied.

On Wed, Mar 7, 2018 at 3:17 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Wed, Mar 7, 2018 at 7:20 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to disable Gravatar image in Server mode.
>>>
>>> Requirments & Issues:
>>> - For security reasons.
>>> - For systems which do not have internet access.
>>> - Hangs pgAdmin4 while loading the page if connection has no internet
>>> access (as described in the ticket)
>>>
>>
>> If I run with the Gravatar disabled, then I get the following regression
>> failure:
>>
>> ==
>> FAIL: runTest (pgadmin.browser.tests.test_login.LoginTestCase)
>> Valid_Credentials
>> --
>> Traceback (most recent call last):
>>   File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_login.py",
>> line 93, in runTest
>> self.assertTrue(self.respdata in response.data.decode('utf8'))
>> AssertionError: False is not true
>>
>> --
>>
>> It's fine when Gravatar is enabled (and the rest of the patch does too).
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Khushboo Vashi]

Please find the attached updated patch.
This should work.

On Wed, Mar 7, 2018 at 9:46 PM, Dave Page  wrote:

>
>
> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 On Wed, Mar 7, 2018 at 7:34 PM, Dave Page  wrote:

> Khushboo, can you look at this ASAP please? It passed tests on my
> machine, but Jenkins isn't happy.
>
> I have tried to reproduce the issue with many combination but couldn't
 reproduce it.
 With the help of logs, I have tried to fix it. Can you please check
 this fix is helpful or not?

>>>
>>> On my laptop I now get:
>>>
>>> ==
>>> ERROR: runTest (pgadmin.tools.sqleditor.tests
>>> .test_poll_query_tool.TestPollQueryTool)
>>> When query tool polling returns messages with result data-set
>>> --
>>> Traceback (most recent call last):
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
>>> line 104, in runTest
>>> response_data['data']['additional_messages'])
>>>   File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
>>> line 802, in assertIn
>>> if member not in container:
>>> TypeError: argument of type 'NoneType' is not iterable
>>>
>>> --
>>>
>>> Please provide some more details. Is this failing for particular server
>> version?
>> I am not getting any error with this patch and without this patch on PY2
>> and PY3 with a single/multiple servers.
>>
>
> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are
> the package versions in the venv:
>
> alabaster==0.7.10
> alembic==0.9.6
> args==0.1.0
> Babel==2.3.4
> backports.csv==1.0.4
> beautifulsoup4==4.4.1
> blinker==1.3
> chromedriver-installer==0.0.6
> click==6.6
> clint==0.5.1
> dateutils==0.6.6
> docutils==0.13.1
> extras==1.0.0
> fixtures==3.0.0
> Flask==0.11.1
> Flask-Babel==0.11.1
> Flask-Gravatar==0.4.2
> Flask-HTMLmin==1.2
> Flask-Login==0.3.2
> Flask-Mail==0.9.1
> Flask-Migrate==2.0.3
> Flask-Paranoid==0.1.0
> Flask-Principal==0.4.0
> Flask-Script==2.0.6
> Flask-Security==1.7.5
> Flask-SQLAlchemy==2.1
> Flask-WTF==0.12
> funcsigs==1.0.2
> html5lib==1.0b3
> htmlmin==0.1.11
> imagesize==0.7.1
> importlib==1.0.3
> itsdangerous==0.24
> Jinja2==2.7.3
> linecache2==1.0.0
> Mako==1.0.7
> MarkupSafe==0.23
> minify==0.1.4
> mock==2.0.0
> passlib==1.6.2
> pbr==3.1.1
> pkginfo==1.4.1
> psycopg2==2.7.3.2
> pycodestyle==2.3.1
> pycrypto==2.6.1
> Pygments==2.2.0
> pyperclip==1.5.32
> pyrsistent==0.14.0
> python-dateutil==2.5.0
> python-editor==1.0.3
> python-mimeparse==1.6.0
> pytz==2014.10
> requests==2.13.0
> requests-toolbelt==0.7.1
> selenium==3.3.3
> simplejson==3.6.5
> six==1.11.0
> snowballstemmer==1.2.1
> speaklater==1.3
> Sphinx==1.5.3
> SQLAlchemy==1.0.14
> sqlparse==0.1.19
> testscenarios==0.5.0
> testtools==2.0.0
> traceback2==1.4.0
> unittest2==1.1.0
> Werkzeug==0.9.6
> WTForms==2.0.2
> yuicompressor==2.4.8
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py b/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py
index 275ed9c..e0a8d38 100644
--- a/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py
+++ b/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py
@@ -99,9 +99,11 @@ NOTICE:  Hello, world!
 self.assertEquals(response.status_code, 200)
 response_data = json.loads(response.data.decode('utf-8'))
 
-# Check the returned messages
-self.assertEquals(self.expected_message[cnt],
+if self.expected_message[cnt] is not None:
+# Check the returned messages
+self.assertIn(self.expected_message[cnt],
   response_data['data']['additional_messages'])
+
 # Check the output
 self.assertEquals(self.expected_result[cnt],
   response_data['data']['result'][0][0])

Build failed in Jenkins: pgadmin4-master-python26 #639

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in

--
[...truncated 615.50 KB...]
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.2:

269 

Build failed in Jenkins: pgadmin4-master-python35 #512

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update Jasmine to v3. Fixes #3182

[Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in

--
[...truncated 611.77 KB...]
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
TestSSLConnection (Test for SSL connection)
PackageAddTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymPutTestCase (Fetch synonym Node URL)

EDB Postgres AS 9.2:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
ResourceGroupsAddTestCase (Add resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ViewsDeleteTestCase (Delete materialized view under schema node)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ViewsAddTestCase (Add materialized view under schema node)
ViewsGetTestCase (Get materialized view under schema node)
ResourceGroupsDeleteTestCase (Delete resource groups)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
ViewsUpdateTestCase (Update materialized view under schema node)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table)

EDB Postgres AS 9.3:

284 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
7 tests skipped:
ResourceGroupsAddTestCase (Add resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table)

EDB Postgres AS 9.4:

288 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
3 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.4:

pgAdmin 4 commit: Make the poll query test a little more robust.

[Dave Page]

Make the poll query test a little more robust.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1136e37cf0d96f0a9f2a08f0ea24b390dc9914b1
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python36 #503

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes 
#3037

--
[...truncated 611.66 KB...]
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.4:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.5:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing rang

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Dave Page]

Thanks, applied. Lets see what happens.

On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Please find the attached updated patch.
> This should work.
>
>
> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page  wrote:
>
>>
>>
>> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page  wrote:
>>>
 Hi

 On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page  wrote:
>
>> Khushboo, can you look at this ASAP please? It passed tests on my
>> machine, but Jenkins isn't happy.
>>
>> I have tried to reproduce the issue with many combination but
> couldn't reproduce it.
> With the help of logs, I have tried to fix it. Can you please check
> this fix is helpful or not?
>

 On my laptop I now get:

 ==
 ERROR: runTest (pgadmin.tools.sqleditor.tests
 .test_poll_query_tool.TestPollQueryTool)
 When query tool polling returns messages with result data-set
 --
 Traceback (most recent call last):
   File 
 "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
 line 104, in runTest
 response_data['data']['additional_messages'])
   File 
 "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
 line 802, in assertIn
 if member not in container:
 TypeError: argument of type 'NoneType' is not iterable

 --

 Please provide some more details. Is this failing for particular server
>>> version?
>>> I am not getting any error with this patch and without this patch on PY2
>>> and PY3 with a single/multiple servers.
>>>
>>
>> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are
>> the package versions in the venv:
>>
>> alabaster==0.7.10
>> alembic==0.9.6
>> args==0.1.0
>> Babel==2.3.4
>> backports.csv==1.0.4
>> beautifulsoup4==4.4.1
>> blinker==1.3
>> chromedriver-installer==0.0.6
>> click==6.6
>> clint==0.5.1
>> dateutils==0.6.6
>> docutils==0.13.1
>> extras==1.0.0
>> fixtures==3.0.0
>> Flask==0.11.1
>> Flask-Babel==0.11.1
>> Flask-Gravatar==0.4.2
>> Flask-HTMLmin==1.2
>> Flask-Login==0.3.2
>> Flask-Mail==0.9.1
>> Flask-Migrate==2.0.3
>> Flask-Paranoid==0.1.0
>> Flask-Principal==0.4.0
>> Flask-Script==2.0.6
>> Flask-Security==1.7.5
>> Flask-SQLAlchemy==2.1
>> Flask-WTF==0.12
>> funcsigs==1.0.2
>> html5lib==1.0b3
>> htmlmin==0.1.11
>> imagesize==0.7.1
>> importlib==1.0.3
>> itsdangerous==0.24
>> Jinja2==2.7.3
>> linecache2==1.0.0
>> Mako==1.0.7
>> MarkupSafe==0.23
>> minify==0.1.4
>> mock==2.0.0
>> passlib==1.6.2
>> pbr==3.1.1
>> pkginfo==1.4.1
>> psycopg2==2.7.3.2
>> pycodestyle==2.3.1
>> pycrypto==2.6.1
>> Pygments==2.2.0
>> pyperclip==1.5.32
>> pyrsistent==0.14.0
>> python-dateutil==2.5.0
>> python-editor==1.0.3
>> python-mimeparse==1.6.0
>> pytz==2014.10
>> requests==2.13.0
>> requests-toolbelt==0.7.1
>> selenium==3.3.3
>> simplejson==3.6.5
>> six==1.11.0
>> snowballstemmer==1.2.1
>> speaklater==1.3
>> Sphinx==1.5.3
>> SQLAlchemy==1.0.14
>> sqlparse==0.1.19
>> testscenarios==0.5.0
>> testtools==2.0.0
>> traceback2==1.4.0
>> unittest2==1.1.0
>> Werkzeug==0.9.6
>> WTForms==2.0.2
>> yuicompressor==2.4.8
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python33 #509

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes 
#3037

--
[...truncated 612.25 KB...]
288 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
3 tests skipped:
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
TestSSLConnection (Test for SSL connection)

PostgreSQL 10:

278 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
13 tests skipped:
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
SynonymAddTestCase (Default Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
TestSSLConnection (Test for SSL connection)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackageAddTestCase (Fetch Package Node URL)

EDB Postgres AS 9.2:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
ResourceGroupsAddTestCase (Add resource groups)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
ViewsGetTestCase (Get materialized view under schema node)
ViewsAddTestCase (Add materialized view under schema node)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
ResourceGroupsGetTestCase (Get resource groups)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
ViewsDeleteTestCase (Delete materialized view under schema node)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
ViewsUpdateTestCase (Update materialized view under schema node)
TestSSLConnection (Test for SSL connection)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
ResourceGroupsPutTestCase (Put resource groups)

PostgreSQL 9.3:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
SynonymAddTestCase (Default Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
TestSSLConnection (Test f

Build failed in Jenkins: pgadmin4-master-python34 #503

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes 
#3037

[Dave Page] Make the poll query test a little more robust.

--
[...truncated 610.65 KB...]
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table)
TestSSLConnection (Test for SSL connection)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)

PostgreSQL 9.4:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsAddTestCase (Add resource groups)
SynonymAddTestCase (Default Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)
SynonymGetTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)

PostgreSQL 10:

278 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
13 tests skipped:
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsAddTestCase (Add resource groups)
SynonymAddTestCase (Default Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
NOTE: Configuring authentication for DESKTOP mode.
pgAdmin 4 - Application Initialisation
==

Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 1000 NOTICES WITH DATASET
Executing and polling with: NO NOTICE WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Please check output in file: 



PostgreSQL 9.2:

269 tests passed
0 tests failed
23 tests skipped:
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsAddTestCase (Add resource groups)

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Dave Page]

It still seems to be failing :-(

https://jenkins.pgadmin.org/job/pgadmin4-master-python26/lastFailedBuild/consoleFull

On Wed, Mar 7, 2018 at 4:50 PM, Dave Page  wrote:

> Thanks, applied. Lets see what happens.
>
> On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Please find the attached updated patch.
>> This should work.
>>
>>
>> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Wed, Mar 7, 2018 at 9:23 PM, Dave Page  wrote:

> Hi
>
> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page  wrote:
>>
>>> Khushboo, can you look at this ASAP please? It passed tests on my
>>> machine, but Jenkins isn't happy.
>>>
>>> I have tried to reproduce the issue with many combination but
>> couldn't reproduce it.
>> With the help of logs, I have tried to fix it. Can you please check
>> this fix is helpful or not?
>>
>
> On my laptop I now get:
>
> ==
> ERROR: runTest (pgadmin.tools.sqleditor.tests
> .test_poll_query_tool.TestPollQueryTool)
> When query tool polling returns messages with result data-set
> --
> Traceback (most recent call last):
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
> line 104, in runTest
> response_data['data']['additional_messages'])
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
> line 802, in assertIn
> if member not in container:
> TypeError: argument of type 'NoneType' is not iterable
>
> 
> --
>
> Please provide some more details. Is this failing for particular
 server version?
 I am not getting any error with this patch and without this patch on
 PY2 and PY3 with a single/multiple servers.

>>>
>>> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are
>>> the package versions in the venv:
>>>
>>> alabaster==0.7.10
>>> alembic==0.9.6
>>> args==0.1.0
>>> Babel==2.3.4
>>> backports.csv==1.0.4
>>> beautifulsoup4==4.4.1
>>> blinker==1.3
>>> chromedriver-installer==0.0.6
>>> click==6.6
>>> clint==0.5.1
>>> dateutils==0.6.6
>>> docutils==0.13.1
>>> extras==1.0.0
>>> fixtures==3.0.0
>>> Flask==0.11.1
>>> Flask-Babel==0.11.1
>>> Flask-Gravatar==0.4.2
>>> Flask-HTMLmin==1.2
>>> Flask-Login==0.3.2
>>> Flask-Mail==0.9.1
>>> Flask-Migrate==2.0.3
>>> Flask-Paranoid==0.1.0
>>> Flask-Principal==0.4.0
>>> Flask-Script==2.0.6
>>> Flask-Security==1.7.5
>>> Flask-SQLAlchemy==2.1
>>> Flask-WTF==0.12
>>> funcsigs==1.0.2
>>> html5lib==1.0b3
>>> htmlmin==0.1.11
>>> imagesize==0.7.1
>>> importlib==1.0.3
>>> itsdangerous==0.24
>>> Jinja2==2.7.3
>>> linecache2==1.0.0
>>> Mako==1.0.7
>>> MarkupSafe==0.23
>>> minify==0.1.4
>>> mock==2.0.0
>>> passlib==1.6.2
>>> pbr==3.1.1
>>> pkginfo==1.4.1
>>> psycopg2==2.7.3.2
>>> pycodestyle==2.3.1
>>> pycrypto==2.6.1
>>> Pygments==2.2.0
>>> pyperclip==1.5.32
>>> pyrsistent==0.14.0
>>> python-dateutil==2.5.0
>>> python-editor==1.0.3
>>> python-mimeparse==1.6.0
>>> pytz==2014.10
>>> requests==2.13.0
>>> requests-toolbelt==0.7.1
>>> selenium==3.3.3
>>> simplejson==3.6.5
>>> six==1.11.0
>>> snowballstemmer==1.2.1
>>> speaklater==1.3
>>> Sphinx==1.5.3
>>> SQLAlchemy==1.0.14
>>> sqlparse==0.1.19
>>> testscenarios==0.5.0
>>> testtools==2.0.0
>>> traceback2==1.4.0
>>> unittest2==1.1.0
>>> Werkzeug==0.9.6
>>> WTForms==2.0.2
>>> yuicompressor==2.4.8
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Khushboo Vashi]

On Wed, Mar 7, 2018 at 10:33 PM, Dave Page  wrote:

> It still seems to be failing :-(
>
> :(

> https://jenkins.pgadmin.org/job/pgadmin4-master-python26/
> lastFailedBuild/consoleFull
>
> On Wed, Mar 7, 2018 at 4:50 PM, Dave Page  wrote:
>
>> Thanks, applied. Lets see what happens.
>>
>> On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Please find the attached updated patch.
>>> This should work.
>>>
>>>
>>> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page  wrote:
>>>


 On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page  wrote:
>>>
 Khushboo, can you look at this ASAP please? It passed tests on my
 machine, but Jenkins isn't happy.

 I have tried to reproduce the issue with many combination but
>>> couldn't reproduce it.
>>> With the help of logs, I have tried to fix it. Can you please check
>>> this fix is helpful or not?
>>>
>>
>> On my laptop I now get:
>>
>> 
>> ==
>> ERROR: runTest (pgadmin.tools.sqleditor.tests
>> .test_poll_query_tool.TestPollQueryTool)
>> When query tool polling returns messages with result data-set
>> 
>> --
>> Traceback (most recent call last):
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
>> line 104, in runTest
>> response_data['data']['additional_messages'])
>>   File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
>> line 802, in assertIn
>> if member not in container:
>> TypeError: argument of type 'NoneType' is not iterable
>>
>> 
>> --
>>
>> Please provide some more details. Is this failing for particular
> server version?
> I am not getting any error with this patch and without this patch on
> PY2 and PY3 with a single/multiple servers.
>

 Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here are
 the package versions in the venv:

 alabaster==0.7.10
 alembic==0.9.6
 args==0.1.0
 Babel==2.3.4
 backports.csv==1.0.4
 beautifulsoup4==4.4.1
 blinker==1.3
 chromedriver-installer==0.0.6
 click==6.6
 clint==0.5.1
 dateutils==0.6.6
 docutils==0.13.1
 extras==1.0.0
 fixtures==3.0.0
 Flask==0.11.1
 Flask-Babel==0.11.1
 Flask-Gravatar==0.4.2
 Flask-HTMLmin==1.2
 Flask-Login==0.3.2
 Flask-Mail==0.9.1
 Flask-Migrate==2.0.3
 Flask-Paranoid==0.1.0
 Flask-Principal==0.4.0
 Flask-Script==2.0.6
 Flask-Security==1.7.5
 Flask-SQLAlchemy==2.1
 Flask-WTF==0.12
 funcsigs==1.0.2
 html5lib==1.0b3
 htmlmin==0.1.11
 imagesize==0.7.1
 importlib==1.0.3
 itsdangerous==0.24
 Jinja2==2.7.3
 linecache2==1.0.0
 Mako==1.0.7
 MarkupSafe==0.23
 minify==0.1.4
 mock==2.0.0
 passlib==1.6.2
 pbr==3.1.1
 pkginfo==1.4.1
 psycopg2==2.7.3.2
 pycodestyle==2.3.1
 pycrypto==2.6.1
 Pygments==2.2.0
 pyperclip==1.5.32
 pyrsistent==0.14.0
 python-dateutil==2.5.0
 python-editor==1.0.3
 python-mimeparse==1.6.0
 pytz==2014.10
 requests==2.13.0
 requests-toolbelt==0.7.1
 selenium==3.3.3
 simplejson==3.6.5
 six==1.11.0
 snowballstemmer==1.2.1
 speaklater==1.3
 Sphinx==1.5.3
 SQLAlchemy==1.0.14
 sqlparse==0.1.19
 testscenarios==0.5.0
 testtools==2.0.0
 traceback2==1.4.0
 unittest2==1.1.0
 Werkzeug==0.9.6
 WTForms==2.0.2
 yuicompressor==2.4.8

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Build failed in Jenkins: pgadmin4-master-python35 #513

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes 
#3037

[Dave Page] Make the poll query test a little more robust.

--
[...truncated 610.75 KB...]
PackageDeleteTestCase (Fetch Package Node URL)
PackageAddTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)
ResourceGroupsPutTestCase (Put resource groups)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageGetTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)

PostgreSQL 9.5:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymGetTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageAddTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)
ResourceGroupsPutTestCase (Put resource groups)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageGetTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)

EDB Postgres AS 9.3:

284 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
7 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsPutTestCase (Put resource groups)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table)

EDB Postgres AS 9.6:

288 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
3 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Attach partiti

Build failed in Jenkins: pgadmin4-master-python26 #640

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes 
#3037

[Dave Page] Make the poll query test a little more robust.

--
[...truncated 614.93 KB...]
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
Packag

Build failed in Jenkins: pgadmin4-master-python33 #510

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Make the poll query test a little more robust.

--
[...truncated 610.86 KB...]
SynonymAddTestCase (Default Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsPutTestCase (Put resource groups)
PackageDeleteTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing range 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.6:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
PackageAddTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsPutTestCase (Put resource groups)
PackageDeleteTestCase (Fetch Package Node URL)
TestSSLConnection (Test for SSL connection)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing range 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 10:

278 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
13 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsPutTestCase (Put resource groups)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
ResourceGroupsGetTestCase (Get resource groups)
PackagePutTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)

EDB Postgres AS 9.5:

288 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
3 tests skipped:
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing range 
partitioned table)
   

ACI Tree

[Robert Eckhardt]

Hackers,

We have multiple end users who have in excess of 10 thousand of tables in a
single schema. Currently this causes pgAdmin to choke.

The major issue we are seeing is that the ACI tree is unsupported and it
seems to be the backbone of pgAdmin 4.

Is anyone else having this issue?  Is there a solution better that (for
some definition of better than) replacing the ACI Tree with something more
performant?

-- Rob

Build failed in Jenkins: pgadmin4-master-python27 #512

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes 
#3037

[Dave Page] Make the poll query test a little more robust.

--
[...truncated 611.45 KB...]
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
Packag

Build failed in Jenkins: pgadmin4-master-python36 #504

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Make the poll query test a little more robust.

--
[...truncated 610.70 KB...]
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.4:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)
NOTE: Configuring authentication for DESKTOP mode.
pgAdmin 4 - Application Initialisation
==

Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 1000 NOTICES WITH DATASET
Executing and polling with: NO NOTICE WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Executing and polling with: 2 NOTICES WITH DATASET
Please check output in file: 



PostgreSQL 9.5:

276 tests passed
1 test failed:
TestPollQueryTool (When query tool polling returns messages 
with result data-set)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCas

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Khushboo Vashi]

Hi Dave,

Please find the patch to fix this.
I have fixed this issue in the StartRunningQueryTest class, this test class
changes the behaviour of the methods through MagicMock and due to this this
test case is failing.

Thanks,
Khushboo


On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Wed, Mar 7, 2018 at 10:33 PM, Dave Page  wrote:
>
>> It still seems to be failing :-(
>>
>> :(
>
>> https://jenkins.pgadmin.org/job/pgadmin4-master-python26/las
>> tFailedBuild/consoleFull
>>
>> On Wed, Mar 7, 2018 at 4:50 PM, Dave Page  wrote:
>>
>>> Thanks, applied. Lets see what happens.
>>>
>>> On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Please find the attached updated patch.
 This should work.


 On Wed, Mar 7, 2018 at 9:46 PM, Dave Page  wrote:

>
>
> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 On Wed, Mar 7, 2018 at 7:34 PM, Dave Page 
 wrote:

> Khushboo, can you look at this ASAP please? It passed tests on my
> machine, but Jenkins isn't happy.
>
> I have tried to reproduce the issue with many combination but
 couldn't reproduce it.
 With the help of logs, I have tried to fix it. Can you please check
 this fix is helpful or not?

>>>
>>> On my laptop I now get:
>>>
>>> 
>>> ==
>>> ERROR: runTest (pgadmin.tools.sqleditor.tests
>>> .test_poll_query_tool.TestPollQueryTool)
>>> When query tool polling returns messages with result data-set
>>> 
>>> --
>>> Traceback (most recent call last):
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
>>> line 104, in runTest
>>> response_data['data']['additional_messages'])
>>>   File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
>>> line 802, in assertIn
>>> if member not in container:
>>> TypeError: argument of type 'NoneType' is not iterable
>>>
>>> 
>>> --
>>>
>>> Please provide some more details. Is this failing for particular
>> server version?
>> I am not getting any error with this patch and without this patch on
>> PY2 and PY3 with a single/multiple servers.
>>
>
> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here
> are the package versions in the venv:
>
> alabaster==0.7.10
> alembic==0.9.6
> args==0.1.0
> Babel==2.3.4
> backports.csv==1.0.4
> beautifulsoup4==4.4.1
> blinker==1.3
> chromedriver-installer==0.0.6
> click==6.6
> clint==0.5.1
> dateutils==0.6.6
> docutils==0.13.1
> extras==1.0.0
> fixtures==3.0.0
> Flask==0.11.1
> Flask-Babel==0.11.1
> Flask-Gravatar==0.4.2
> Flask-HTMLmin==1.2
> Flask-Login==0.3.2
> Flask-Mail==0.9.1
> Flask-Migrate==2.0.3
> Flask-Paranoid==0.1.0
> Flask-Principal==0.4.0
> Flask-Script==2.0.6
> Flask-Security==1.7.5
> Flask-SQLAlchemy==2.1
> Flask-WTF==0.12
> funcsigs==1.0.2
> html5lib==1.0b3
> htmlmin==0.1.11
> imagesize==0.7.1
> importlib==1.0.3
> itsdangerous==0.24
> Jinja2==2.7.3
> linecache2==1.0.0
> Mako==1.0.7
> MarkupSafe==0.23
> minify==0.1.4
> mock==2.0.0
> passlib==1.6.2
> pbr==3.1.1
> pkginfo==1.4.1
> psycopg2==2.7.3.2
> pycodestyle==2.3.1
> pycrypto==2.6.1
> Pygments==2.2.0
> pyperclip==1.5.32
> pyrsistent==0.14.0
> python-dateutil==2.5.0
> python-editor==1.0.3
> python-mimeparse==1.6.0
> pytz==2014.10
> requests==2.13.0
> requests-toolbelt==0.7.1
> selenium==3.3.3
> simplejson==3.6.5
> six==1.11.0
> snowballstemmer==1.2.1
> speaklater==1.3
> Sphinx==1.5.3
> SQLAlchemy==1.0.14
> sqlparse==0.1.19
> testscenarios==0.5.0
> testtools==2.0.0
> traceback2==1.4.0
> unittest2==1.1.0
> Werkzeug==0.9.6
> WTForms==2.0.2
> yuicompressor==2.4.8
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Ente

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

[Khushboo Vashi]

On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find the patch to fix this.
> I have fixed this issue in the StartRunningQueryTest class, this test
> class changes the behaviour of the methods through MagicMock and due to
> this this test case is failing.
>
> Revised patch with some modification.

> Thanks,
> Khushboo
>
>
> On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Wed, Mar 7, 2018 at 10:33 PM, Dave Page  wrote:
>>
>>> It still seems to be failing :-(
>>>
>>> :(
>>
>>> https://jenkins.pgadmin.org/job/pgadmin4-master-python26/las
>>> tFailedBuild/consoleFull
>>>
>>> On Wed, Mar 7, 2018 at 4:50 PM, Dave Page  wrote:
>>>
 Thanks, applied. Lets see what happens.

 On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Please find the attached updated patch.
> This should work.
>
>
> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page  wrote:
>
>>
>>
>> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page  wrote:
>>>
 Hi

 On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page 
> wrote:
>
>> Khushboo, can you look at this ASAP please? It passed tests on my
>> machine, but Jenkins isn't happy.
>>
>> I have tried to reproduce the issue with many combination but
> couldn't reproduce it.
> With the help of logs, I have tried to fix it. Can you please
> check this fix is helpful or not?
>

 On my laptop I now get:

 
 ==
 ERROR: runTest (pgadmin.tools.sqleditor.tests
 .test_poll_query_tool.TestPollQueryTool)
 When query tool polling returns messages with result data-set
 
 --
 Traceback (most recent call last):
   File 
 "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
 line 104, in runTest
 response_data['data']['additional_messages'])
   File 
 "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
 line 802, in assertIn
 if member not in container:
 TypeError: argument of type 'NoneType' is not iterable

 
 --

 Please provide some more details. Is this failing for particular
>>> server version?
>>> I am not getting any error with this patch and without this patch on
>>> PY2 and PY3 with a single/multiple servers.
>>>
>>
>> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here
>> are the package versions in the venv:
>>
>> alabaster==0.7.10
>> alembic==0.9.6
>> args==0.1.0
>> Babel==2.3.4
>> backports.csv==1.0.4
>> beautifulsoup4==4.4.1
>> blinker==1.3
>> chromedriver-installer==0.0.6
>> click==6.6
>> clint==0.5.1
>> dateutils==0.6.6
>> docutils==0.13.1
>> extras==1.0.0
>> fixtures==3.0.0
>> Flask==0.11.1
>> Flask-Babel==0.11.1
>> Flask-Gravatar==0.4.2
>> Flask-HTMLmin==1.2
>> Flask-Login==0.3.2
>> Flask-Mail==0.9.1
>> Flask-Migrate==2.0.3
>> Flask-Paranoid==0.1.0
>> Flask-Principal==0.4.0
>> Flask-Script==2.0.6
>> Flask-Security==1.7.5
>> Flask-SQLAlchemy==2.1
>> Flask-WTF==0.12
>> funcsigs==1.0.2
>> html5lib==1.0b3
>> htmlmin==0.1.11
>> imagesize==0.7.1
>> importlib==1.0.3
>> itsdangerous==0.24
>> Jinja2==2.7.3
>> linecache2==1.0.0
>> Mako==1.0.7
>> MarkupSafe==0.23
>> minify==0.1.4
>> mock==2.0.0
>> passlib==1.6.2
>> pbr==3.1.1
>> pkginfo==1.4.1
>> psycopg2==2.7.3.2
>> pycodestyle==2.3.1
>> pycrypto==2.6.1
>> Pygments==2.2.0
>> pyperclip==1.5.32
>> pyrsistent==0.14.0
>> python-dateutil==2.5.0
>> python-editor==1.0.3
>> python-mimeparse==1.6.0
>> pytz==2014.10
>> requests==2.13.0
>> requests-toolbelt==0.7.1
>> selenium==3.3.3
>> simplejson==3.6.5
>> six==1.11.0
>> snowballstemmer==1.2.1
>> speaklater==1.3
>> Sphinx==1.5.3
>> SQLAlchemy==1.0.14
>> sqlparse==0.1.19
>> testscenarios==0.5.0
>> testtools==2.0.0
>> traceback2==1.4.0
>> unittest2==1.1.0
>> Werkzeug==0.9.6
>> WTForms==2.0.2
>> yuicompressor==2.4.8
>>
>> --
>> Dave Page
>> Blog: http://

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

[Khushboo Vashi]

Hi Joao,

In the test_start_running_query.py, 2 static methods
(is_begin_required_for_sql_query
and is_rollback_statement_required)
of StartRunningQuery class were used directly without @patch. Due to this,
in all the cases, the original value of them doesn't restore.

To fix this, I have sent the patch in another thread, to restore its
original state, but I wonder if we can use these methods with @patch.

Thanks,
Khushboo


On Fri, Feb 9, 2018 at 5:24 PM, Dave Page  wrote:

> Support EXPLAIN on Greenplum. Fixes #3097
>
>  - Extract SQLEditor.execute and SQLEditor._poll into their own files and
> add test around them
>  - Extract SQLEditor backend functions that start executing query to their
> own files and add tests around it
>  - Move the Explain SQL from the front-end and now pass the Explain plan
> parameters as a JSON object in the start query call.
>  - Extract the compile_template_name into a function that can be used by
> the different places that try to select the version of the template and the
> server type
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> e16a95275336529a734bf0066889e39cc8ef0662
> Author: Joao Pedro De Almeida Pereira 
>
> Modified Files
> --
> .../databases/schemas/tables/tests/test_utils.py   |0
> web/pgadmin/static/js/sqleditor/execute_query.js   |  287 
> .../js/sqleditor/is_new_transaction_required.js|   14 +
> .../static/js/sqleditor/query_tool_actions.js  |   33 +-
> web/pgadmin/tools/sqleditor/__init__.py|  396 +
> web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  227 +--
> .../sqleditor/sql/10_plus/explain_plan.sql |   23 +
> .../sqleditor/sql/9.2_plus/explain_plan.sql|   20 +
> .../sqleditor/sql/default/explain_plan.sql |   17 +
> .../sqleditor/sql/gpdb_5.0_plus/explain_plan.sql   |5 +
> web/pgadmin/tools/sqleditor/tests/__init__.py  |8 +
> .../sqleditor/tests/test_explain_plan_templates.py |  152 ++
> .../test_extract_sql_from_network_parameters.py|   59 +
> .../tools/sqleditor/tests/test_start_query_tool.py |   38 +
> web/pgadmin/tools/sqleditor/utils/__init__.py  |   14 +
> .../sqleditor/utils/apply_explain_plan_wrapper.py  |   24 +
> .../tools/sqleditor/utils/constant_definition.py   |   32 +
> .../tools/sqleditor/utils/is_begin_required.py |  169 ++
> .../tools/sqleditor/utils/start_running_query.py   |  172 ++
> .../tools/sqleditor/utils/tests/__init__.py|8 +
> .../utils/tests/test_apply_explain_plan_wrapper.py |  121 ++
> .../utils/tests/test_start_running_query.py|  445 +
> .../utils/update_session_grid_transaction.py   |   18 +
> web/pgadmin/utils/compile_template_name.py |   17 +
> .../utils/tests/test_compile_template_name.py  |   34 +
> web/pgadmin/utils/versioned_template_loader.py |2 +-
> web/regression/javascript/fake_endpoints.js|6 +-
> .../javascript/sqleditor/execute_query_spec.js | 1702
> 
> .../sqleditor/is_new_transaction_required_spec.js  |   65 +
> .../sqleditor/query_tool_actions_spec.js   |  141 +-
> 30 files changed, 3670 insertions(+), 579 deletions(-)
>
>