Re: [pgadmin4] Explain plans

[Dave Page]

Hi

On Fri, Jan 19, 2018 at 2:09 PM, Joao De Almeida Pereira
 wrote:
> Hello Hackers,
> We are trying to find a solution for the explain plans that currently are
> not working in GP, due to the lack of support for JSON. We believe that the
> best options for this it would be to display the text in the tab instead of
> the visual version for our case.
> In order to implement this we came up with some options that we would like
> to understand what the community think about them.
>
> Move the SQL to generate explain plans to backend
> For this approach we would create a new endpoint to generate an explain plan
> and when we click the explain plan buttons instead of doing a new SQL query
> we would call the new endpoint and wait for the explain plan to be generated
>
> Pros:
>
> All SQL related code is in the backend
> Extract more code from SQLEditor into smaller and more testable/maintainable
> modules
>
> Cons:
>
> Major Revamp of SQLEditor
> If explain plan takes to long to generate we will be waiting for it in the
> foreground instead of polling
>
> Add parameters while executing SQL
> If we add parameters in the SQL query request we send to the backend,
> informing the backend that the SQL query is a Explain Plan to be
> executed(The response can have a flag saying that this is an explain plan,
> instead of assuming from the return values that it was an explain plan)
>
> Pros:
>
> All SQL related code is in the backend
> Leverage the current polling system
>
> Cons:
>
> Add more logic to an already complex SQLEditor
>
> Disable Explain plan buttons
> Disable/Enable the Explain plan buttons depending on the type of database,
> this would also include the tab in the bottom of the SQLEditor
>
> Pros:
>
> Simpler solution
>
> Cons:
>
> Not really a good implementation, because all databases support explain
> plans
> There will still be SQL in both frontend and backend
> Looks more like a temporary fix instead of a solution
>
>
> We believe that we should not keep build feature inside the SQLEditor, but
> should try to extract as many parts of it as possible, this is where the
> current option 2 fall short in our point of view. Due to this we believe
> that option 1 looks promising and that is that path that we prefer to go
> into.
> What does the community think about this?

"If explain plan takes to long to generate we will be waiting for it
in the foreground instead of polling" seems like a show stopper for
option 1 to me. Consider that the user may have chosen to do EXPLAIN
ANALYZE, which executes the actual query.

I agree that 3 isn't really an option - and I also agree that
factoring out functionality into smaller units is good. Option 2
doesn't preclude that though does it? It just doesn't require it.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

[Dave Page]

Hi

This seems to be missing documentation updates. I would also expect to see
some Jasmine unit tests for some/all of the new JS functions.

On Tue, Jan 16, 2018 at 1:29 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to add keyboard navigation in Debugger module via
> Tab/Shift-Tab key.
> RM#2897
>
> Also fixed the issue where user was not able to update values in
> variable's panel while debugging.
> RM#2981
>
> Currrently we have execution related shortcuts using accesskey,
> Shortcuts (Execution related)
> --
>  + i  = Step in
>  + o = Step over
>  + c = Continue/Restart
>  + t = Toggle breakpoint
>  + x = Clear all breakpoints
>  + s = Stop
>
> Shortcuts (Panel navigation related)
> --
> Alt + Shift + Right Arrow
> Alt + Shift + Left Arrow
>
> Edit/Enter values in Grid (Parameter & Local variables panel's)
> -
> Alt + Shift + g
>
> Please review.
>
> *Note:* As of now inner panel's are not getting focused on Tab/Shift-Tab
> keys but once RM#2895  patch
> gets committed it will start working automatically as it's inherited code
> which will add tabindex tag automatically on each newly created wcDocker
> panel.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Update ESLint to latest version

[Dave Page]

Thanks, patch applied.

On Wed, Jan 17, 2018 at 6:27 AM, Surinder Kumar
 wrote:
> Hi
>
> In the current version of ESLint the option "--fix-dry-run" not working. So,
> updating to the latest one resolve this.
>
> Please find an attached patch.
>
> Thanks,
> Surinder



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update ESLint requirement to support --fix-dry-run

[Dave Page]

Update ESLint requirement to support --fix-dry-run

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ee9f09bbde345160f7bb764ce3242e78b3c1293
Author: Surinder Kumar 

Modified Files
--
web/package.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Ensure clickable images/buttons have appropriate tool

[Dave Page]

Ensure clickable images/buttons have appropriate tooltips for screen readers. 
Fixes #2904

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca80cfa04a4b11718340196c381a1a1c85451b21
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/browser/server_groups/servers/static/js/variable.js | 2 +-
web/pgadmin/static/js/alertify.pgadmin.defaults.js  | 8 
web/pgadmin/static/js/backform.pgadmin.js   | 6 +++---
web/pgadmin/static/js/backgrid.pgadmin.js   | 6 +++---
4 files changed, 15 insertions(+), 7 deletions(-)

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

[Dave Page]

Thanks, patch applied.

On Wed, Jan 17, 2018 at 6:55 AM, Khushboo Vashi
 wrote:
>
>
> On Wed, Jan 17, 2018 at 12:23 PM, Khushboo Vashi
>  wrote:
>>
>>
>>
>> On Mon, Jan 15, 2018 at 10:39 PM, Dave Page  wrote:
>>>
>>> Hi
>>>
>>> On Mon, Jan 15, 2018 at 10:23 AM, Khushboo Vashi
>>>  wrote:

 Hi,

 Please find the attached patch for RM # 2904: As a visually impaired
 user I need all buttons in the application to have appropriate tooltips for
 my screen reader to interpret.
>>>
>>>
>>> Unfortunately I think there's been a misunderstanding with this patch,
>>> most likely my fault for not being clearer;
>>>
>>> - There is no need to add tooltips to buttons that already have text,
>>> unless we want to add additional information. For example, on the OK button,
>>> we might have a tooltip that says "Apply the changes and close the dialog".
>>> That really is optional though, as screen readers could already read the
>>> button text (but we should be consistent).
>>>
>>> - We do need to add tooltips to buttons that don't have any text. For
>>> example;
>>>  * dialogue title-bar buttons
>>>  * the "close tab" and "move tabs left"/"move tabs right" buttons
>>> that may appear in tab bars
>>>  * the add row button at the top of a subnode control (e.g. to add a
>>> column definition)
>>>  * the delete and expand row buttons in subnode grid rows
>>>
>>> Sorry for not being clearer about the requirements.
>>>
>> Thanks for the clarification.
>> Please find the attached updated patch.
>
> Missed attachment. Please find it attached.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python26 #580

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update ESLint requirement to support --fix-dry-run

--
[...truncated 406.58 KB...]
  157:1   error  Expected indentation of 6 spaces but found 8indent
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces but found

Re: [pgAdmin4][Patch#3021] Updating existing Index scan & Scan icons

[Dave Page]

Hi

On Thu, Jan 18, 2018 at 12:48 PM, Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:

> Hello Team,
>
> I am sending a patch for the ex_index and ex_scan icons where those were
> similar to each other  so I have made them easy to differentiate now.
>
> It is respective to the issue *RM# 3021*
>

They're still only distinguishable by colour, which isn't good for
accessibility.  Can you think about an alternative design for index scans?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python33 #451

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update ESLint requirement to support --fix-dry-run

[Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen

--
[...truncated 401.73 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces

Build failed in Jenkins: pgadmin4-master-python34 #440

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update ESLint requirement to support --fix-dry-run

[Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen

--
[...truncated 401.64 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces

Fwd: Build failed in Jenkins: pgadmin4-master-python34 #440

[Dave Page]

Hi Surinder,

It seems that updating ESLint exposed various issues. Can you take a
look ASAP please?

Thanks.


-- Forwarded message --
From: pgAdmin 4 Jenkins 
Date: Mon, Jan 22, 2018 at 10:53 AM
Subject: Build failed in Jenkins: pgadmin4-master-python34 #440
To: pgadmin-hack...@postgresql.org, dp...@pgadmin.org


See 


Changes:

[Dave Page] Update ESLint requirement to support --fix-dry-run

[Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen

--
[...truncated 401.64 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

[Surinder Kumar]

Yes, I will look.

Thanks,
Surinder

On Mon, Jan 22, 2018 at 4:25 PM, Dave Page  wrote:

> Hi Surinder,
>
> It seems that updating ESLint exposed various issues. Can you take a
> look ASAP please?
>
> Thanks.
>
>
> -- Forwarded message --
> From: pgAdmin 4 Jenkins 
> Date: Mon, Jan 22, 2018 at 10:53 AM
> Subject: Build failed in Jenkins: pgadmin4-master-python34 #440
> To: pgadmin-hack...@postgresql.org, dp...@pgadmin.org
>
>
> See  440/display/redirect?page=changes>
>
> Changes:
>
> [Dave Page] Update ESLint requirement to support --fix-dry-run
>
> [Dave Page] Ensure clickable images/buttons have appropriate tooltips for
> screen
>
> --
> [...truncated 401.64 KB...]
>   228:1   error  Expected indentation of 20 spaces but found 22  indent
>   229:1   error  Expected indentation of 22 spaces but found 24  indent
>   230:1   error  Expected indentation of 22 spaces but found 24  indent
>   231:1   error  Expected indentation of 22 spaces but found 24  indent
>   232:1   error  Expected indentation of 20 spaces but found 22  indent
>   233:1   error  Expected indentation of 18 spaces but found 20  indent
>   236:1   error  Expected indentation of 20 spaces but found 22  indent
>   237:1   error  Expected indentation of 22 spaces but found 24  indent
>   238:1   error  Expected indentation of 22 spaces but found 24  indent
>   239:1   error  Expected indentation of 22 spaces but found 24  indent
>   240:1   error  Expected indentation of 20 spaces but found 22  indent
>   543:1   error  Expected indentation of 14 spaces but found 12  indent
>   544:1   error  Expected indentation of 16 spaces but found 14  indent
>   546:1   error  Expected indentation of 16 spaces but found 14  indent
>   547:1   error  Expected indentation of 18 spaces but found 16  indent
>   548:1   error  Expected indentation of 18 spaces but found 16  indent
>   549:1   error  Expected indentation of 16 spaces but found 14  indent
>   551:1   error  Expected indentation of 16 spaces but found 14  indent
>   552:1   error  Expected indentation of 14 spaces but found 12  indent
>   553:1   error  Expected indentation of 14 spaces but found 12  indent
>   554:1   error  Expected indentation of 16 spaces but found 14  indent
>   556:1   error  Expected indentation of 16 spaces but found 14  indent
>   557:1   error  Expected indentation of 18 spaces but found 16  indent
>   558:1   error  Expected indentation of 18 spaces but found 16  indent
>   559:1   error  Expected indentation of 16 spaces but found 14  indent
>   561:1   error  Expected indentation of 16 spaces but found 14  indent
>   562:1   error  Expected indentation of 14 spaces but found 12  indent
>   593:1   error  Expected indentation of 14 spaces but found 12  indent
>   594:1   error  Expected indentation of 16 spaces but found 14  indent
>   596:1   error  Expected indentation of 16 spaces but found 14  indent
>   597:1   error  Expected indentation of 18 spaces but found 16  indent
>   598:1   error  Expected indentation of 18 spaces but found 16  indent
>   599:1   error  Expected indentation of 16 spaces but found 14  indent
>   601:1   error  Expected indentation of 16 spaces but found 14  indent
>   602:1   error  Expected indentation of 14 spaces but found 12  indent
>   603:1   error  Expected indentation of 14 spaces but found 12  indent
>   604:1   error  Expected indentation of 16 spaces but found 14  indent
>   606:1   error  Expected indentation of 16 spaces but found 14  indent
>   607:1   error  Expected indentation of 18 spaces but found 16  indent
>   608:1   error  Expected indentation of 18 spaces but found 16  indent
>   609:1   error  Expected indentation of 16 spaces but found 14  indent
>   611:1   error  Expected indentation of 16 spaces but found 14  indent
>   612:1   error  Expected indentation of 14 spaces but found 12  indent
>   778:43  error  Unnecessary escape character: \.
> no-useless-escape
>
>  ws/web/pgadmin/browser/static/js/error.js>
>2:1  error  Expected indentation of 2 spaces but found 4   indent
>3:1  error  Expected indentation of 2 spaces but found 0   indent
>4:1  error  Expected indentation of 4 spaces but found 2   indent
>6:1  error  Expected indentation of 4 spaces but found 2   indent
>7:1  error  Expected indentation of 6 spaces but found 4   indent
>8:1  error  Expected indentation of 8 spaces but found 6   indent
>   21:1  error  Expected indentation of 8 spaces but found 6   indent
>   22:1  error  Expected indentation of 10 spaces but found 8  indent
>   34:1  error  Expected indentation of 8 spaces but found 6   indent
>   36:1  error  Expected indentation of 8 spaces but found 6   indent
>   37:1  error  Expected indentation of 8 spaces but found 6   indent
>   38:1  error  Expected indentation of 10 spaces but found 8  

Build failed in Jenkins: pgadmin4-master-python36 #447

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update ESLint requirement to support --fix-dry-run

[Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen

--
[...truncated 401.53 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

[Ashesh Vashi]

Dave,

We need to make habit of running the following command before committing
any javascript files.

> *yarn run linter*


-- Thanks, Ashesh

On Mon, Jan 22, 2018 at 4:25 PM, Dave Page  wrote:

> Hi Surinder,
>
> It seems that updating ESLint exposed various issues. Can you take a
> look ASAP please?
>
> Thanks.
>
>
> -- Forwarded message --
> From: pgAdmin 4 Jenkins 
> Date: Mon, Jan 22, 2018 at 10:53 AM
> Subject: Build failed in Jenkins: pgadmin4-master-python34 #440
> To: pgadmin-hack...@postgresql.org, dp...@pgadmin.org
>
>
> See  440/display/redirect?page=changes>
>
> Changes:
>
> [Dave Page] Update ESLint requirement to support --fix-dry-run
>
> [Dave Page] Ensure clickable images/buttons have appropriate tooltips for
> screen
>
> --
> [...truncated 401.64 KB...]
>   228:1   error  Expected indentation of 20 spaces but found 22  indent
>   229:1   error  Expected indentation of 22 spaces but found 24  indent
>   230:1   error  Expected indentation of 22 spaces but found 24  indent
>   231:1   error  Expected indentation of 22 spaces but found 24  indent
>   232:1   error  Expected indentation of 20 spaces but found 22  indent
>   233:1   error  Expected indentation of 18 spaces but found 20  indent
>   236:1   error  Expected indentation of 20 spaces but found 22  indent
>   237:1   error  Expected indentation of 22 spaces but found 24  indent
>   238:1   error  Expected indentation of 22 spaces but found 24  indent
>   239:1   error  Expected indentation of 22 spaces but found 24  indent
>   240:1   error  Expected indentation of 20 spaces but found 22  indent
>   543:1   error  Expected indentation of 14 spaces but found 12  indent
>   544:1   error  Expected indentation of 16 spaces but found 14  indent
>   546:1   error  Expected indentation of 16 spaces but found 14  indent
>   547:1   error  Expected indentation of 18 spaces but found 16  indent
>   548:1   error  Expected indentation of 18 spaces but found 16  indent
>   549:1   error  Expected indentation of 16 spaces but found 14  indent
>   551:1   error  Expected indentation of 16 spaces but found 14  indent
>   552:1   error  Expected indentation of 14 spaces but found 12  indent
>   553:1   error  Expected indentation of 14 spaces but found 12  indent
>   554:1   error  Expected indentation of 16 spaces but found 14  indent
>   556:1   error  Expected indentation of 16 spaces but found 14  indent
>   557:1   error  Expected indentation of 18 spaces but found 16  indent
>   558:1   error  Expected indentation of 18 spaces but found 16  indent
>   559:1   error  Expected indentation of 16 spaces but found 14  indent
>   561:1   error  Expected indentation of 16 spaces but found 14  indent
>   562:1   error  Expected indentation of 14 spaces but found 12  indent
>   593:1   error  Expected indentation of 14 spaces but found 12  indent
>   594:1   error  Expected indentation of 16 spaces but found 14  indent
>   596:1   error  Expected indentation of 16 spaces but found 14  indent
>   597:1   error  Expected indentation of 18 spaces but found 16  indent
>   598:1   error  Expected indentation of 18 spaces but found 16  indent
>   599:1   error  Expected indentation of 16 spaces but found 14  indent
>   601:1   error  Expected indentation of 16 spaces but found 14  indent
>   602:1   error  Expected indentation of 14 spaces but found 12  indent
>   603:1   error  Expected indentation of 14 spaces but found 12  indent
>   604:1   error  Expected indentation of 16 spaces but found 14  indent
>   606:1   error  Expected indentation of 16 spaces but found 14  indent
>   607:1   error  Expected indentation of 18 spaces but found 16  indent
>   608:1   error  Expected indentation of 18 spaces but found 16  indent
>   609:1   error  Expected indentation of 16 spaces but found 14  indent
>   611:1   error  Expected indentation of 16 spaces but found 14  indent
>   612:1   error  Expected indentation of 14 spaces but found 12  indent
>   778:43  error  Unnecessary escape character: \.
> no-useless-escape
>
>  ws/web/pgadmin/browser/static/js/error.js>
>2:1  error  Expected indentation of 2 spaces but found 4   indent
>3:1  error  Expected indentation of 2 spaces but found 0   indent
>4:1  error  Expected indentation of 4 spaces but found 2   indent
>6:1  error  Expected indentation of 4 spaces but found 2   indent
>7:1  error  Expected indentation of 6 spaces but found 4   indent
>8:1  error  Expected indentation of 8 spaces but found 6   indent
>   21:1  error  Expected indentation of 8 spaces but found 6   indent
>   22:1  error  Expected indentation of 10 spaces but found 8  indent
>   34:1  error  Expected indentation of 8 spaces but found 6   indent
>   36:1  error  Expected indentation of 8 spaces but found 6   indent
>   37:1  error  Expected in

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

[Dave Page]

On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi
 wrote:
> Dave,
>
> We need to make habit of running the following command before committing any
> javascript files.
>>
>> yarn run linter

We do - it's called when creating the bundle, which I always do when testing.

This newer version of ESLint seems to be picking up more than the
older one though.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

[Ashesh Vashi]

On Mon, Jan 22, 2018 at 4:29 PM, Ashesh Vashi  wrote:

> Dave,
>
> We need to make habit of running the following command before committing
> any javascript files.
>
>> *yarn run linter*
>
> Surinder,

Please run the following command to fix most of the indentation issues, but
- you'll need to fix rest of the issues by yourself.

> *yarn run linter --fix*


-- Thanks, Ashesh

>
> -- Thanks, Ashesh
>
> On Mon, Jan 22, 2018 at 4:25 PM, Dave Page  wrote:
>
>> Hi Surinder,
>>
>> It seems that updating ESLint exposed various issues. Can you take a
>> look ASAP please?
>>
>> Thanks.
>>
>>
>> -- Forwarded message --
>> From: pgAdmin 4 Jenkins 
>> Date: Mon, Jan 22, 2018 at 10:53 AM
>> Subject: Build failed in Jenkins: pgadmin4-master-python34 #440
>> To: pgadmin-hack...@postgresql.org, dp...@pgadmin.org
>>
>>
>> See > 0/display/redirect?page=changes>
>>
>> Changes:
>>
>> [Dave Page] Update ESLint requirement to support --fix-dry-run
>>
>> [Dave Page] Ensure clickable images/buttons have appropriate tooltips for
>> screen
>>
>> --
>> [...truncated 401.64 KB...]
>>   228:1   error  Expected indentation of 20 spaces but found 22  indent
>>   229:1   error  Expected indentation of 22 spaces but found 24  indent
>>   230:1   error  Expected indentation of 22 spaces but found 24  indent
>>   231:1   error  Expected indentation of 22 spaces but found 24  indent
>>   232:1   error  Expected indentation of 20 spaces but found 22  indent
>>   233:1   error  Expected indentation of 18 spaces but found 20  indent
>>   236:1   error  Expected indentation of 20 spaces but found 22  indent
>>   237:1   error  Expected indentation of 22 spaces but found 24  indent
>>   238:1   error  Expected indentation of 22 spaces but found 24  indent
>>   239:1   error  Expected indentation of 22 spaces but found 24  indent
>>   240:1   error  Expected indentation of 20 spaces but found 22  indent
>>   543:1   error  Expected indentation of 14 spaces but found 12  indent
>>   544:1   error  Expected indentation of 16 spaces but found 14  indent
>>   546:1   error  Expected indentation of 16 spaces but found 14  indent
>>   547:1   error  Expected indentation of 18 spaces but found 16  indent
>>   548:1   error  Expected indentation of 18 spaces but found 16  indent
>>   549:1   error  Expected indentation of 16 spaces but found 14  indent
>>   551:1   error  Expected indentation of 16 spaces but found 14  indent
>>   552:1   error  Expected indentation of 14 spaces but found 12  indent
>>   553:1   error  Expected indentation of 14 spaces but found 12  indent
>>   554:1   error  Expected indentation of 16 spaces but found 14  indent
>>   556:1   error  Expected indentation of 16 spaces but found 14  indent
>>   557:1   error  Expected indentation of 18 spaces but found 16  indent
>>   558:1   error  Expected indentation of 18 spaces but found 16  indent
>>   559:1   error  Expected indentation of 16 spaces but found 14  indent
>>   561:1   error  Expected indentation of 16 spaces but found 14  indent
>>   562:1   error  Expected indentation of 14 spaces but found 12  indent
>>   593:1   error  Expected indentation of 14 spaces but found 12  indent
>>   594:1   error  Expected indentation of 16 spaces but found 14  indent
>>   596:1   error  Expected indentation of 16 spaces but found 14  indent
>>   597:1   error  Expected indentation of 18 spaces but found 16  indent
>>   598:1   error  Expected indentation of 18 spaces but found 16  indent
>>   599:1   error  Expected indentation of 16 spaces but found 14  indent
>>   601:1   error  Expected indentation of 16 spaces but found 14  indent
>>   602:1   error  Expected indentation of 14 spaces but found 12  indent
>>   603:1   error  Expected indentation of 14 spaces but found 12  indent
>>   604:1   error  Expected indentation of 16 spaces but found 14  indent
>>   606:1   error  Expected indentation of 16 spaces but found 14  indent
>>   607:1   error  Expected indentation of 18 spaces but found 16  indent
>>   608:1   error  Expected indentation of 18 spaces but found 16  indent
>>   609:1   error  Expected indentation of 16 spaces but found 14  indent
>>   611:1   error  Expected indentation of 16 spaces but found 14  indent
>>   612:1   error  Expected indentation of 14 spaces but found 12  indent
>>   778:43  error  Unnecessary escape character: \.
>> no-useless-escape
>>
>> > /web/pgadmin/browser/static/js/error.js>
>>2:1  error  Expected indentation of 2 spaces but found 4   indent
>>3:1  error  Expected indentation of 2 spaces but found 0   indent
>>4:1  error  Expected indentation of 4 spaces but found 2   indent
>>6:1  error  Expected indentation of 4 spaces but found 2   indent
>>7:1  error  Expected indentation of 6 spaces but found 4   indent
>>8:1  error  Expected indentation of

Build failed in Jenkins: pgadmin4-master-python35 #451

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update ESLint requirement to support --fix-dry-run

[Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen

--
[...truncated 401.67 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces

pgAdmin 4 commit: Correctly display SQL of multiple objects on the SQL

[Dave Page]

Correctly display SQL of multiple objects on the SQL tab in GPDB.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=284adbbb901b1be30d130be0e40674cfde931e41
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
.../templates/schema/gpdb_5.0_plus/sql/acl.sql | 21 --
.../templates/schema/gpdb_5.0_plus/sql/defacl.sql  | 45 +++---
.../schema/gpdb_5.0_plus/sql/properties.sql| 25 ++--
3 files changed, 28 insertions(+), 63 deletions(-)

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

[Ashesh Vashi]

On Mon, Jan 22, 2018 at 4:32 PM, Dave Page  wrote:

> On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi
>  wrote:
> > Dave,
> >
> > We need to make habit of running the following command before committing
> any
> > javascript files.
> >>
> >> yarn run linter
>
> We do - it's called when creating the bundle, which I always do when
> testing.
>
> This newer version of ESLint seems to be picking up more than the
> older one though.
>
Yeah - looks like that's the case.

I fixed all linter issues with older version of ESlint last week.

--
Thanks & Regards,

Ashesh Vashi

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Build failed in Jenkins: pgadmin4-master-python27 #452

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Update ESLint requirement to support --fix-dry-run

[Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen

--
[...truncated 402.45 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces

Build failed in Jenkins: pgadmin4-master-python35 #452

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Correctly display SQL of multiple objects on the SQL tab in GPDB.

--
[...truncated 401.59 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces but found 10   indent
  151:1  error  Expected indentation of 6 sp

Build failed in Jenkins: pgadmin4-master-python26 #581

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen

[Dave Page] Correctly display SQL of multiple objects on the SQL tab in GPDB.

--
[...truncated 406.78 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentat

pgAdmin 4 commit: Add missing comma to appease the linter

[Dave Page]

Add missing comma to appease the linter

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b1c8879452d8146924b96ba6fd1e67ba3f225fd

Modified Files
--
web/pgadmin/static/js/backform.pgadmin.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Revert "Update ESLint requirement to support --fix-dr

[Dave Page]

Revert "Update ESLint requirement to support --fix-dry-run"

This reverts commit 0ee9f09bbde345160f7bb764ce3242e78b3c1293.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=51cda9891115a58ed97807a6fa2148d9834b07f5

Modified Files
--
web/package.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Modern versions of yarn don't require -- to forward o

[Dave Page]

Modern versions of yarn don't require -- to forward options.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ec74dfa8934726685c01b86832678dceda0e2d2

Modified Files
--
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python36 #448

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Correctly display SQL of multiple objects on the SQL tab in GPDB.

--
[...truncated 401.50 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces but found 10   indent
  151:1  error  Expected indentation of 6 sp

Jenkins build is back to normal : pgadmin4-master-python33 #452

[pgAdmin 4 Jenkins]

See 

Build failed in Jenkins: pgadmin4-master-python34 #441

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Correctly display SQL of multiple objects on the SQL tab in GPDB.

--
[...truncated 401.62 KB...]
  228:1   error  Expected indentation of 20 spaces but found 22  indent
  229:1   error  Expected indentation of 22 spaces but found 24  indent
  230:1   error  Expected indentation of 22 spaces but found 24  indent
  231:1   error  Expected indentation of 22 spaces but found 24  indent
  232:1   error  Expected indentation of 20 spaces but found 22  indent
  233:1   error  Expected indentation of 18 spaces but found 20  indent
  236:1   error  Expected indentation of 20 spaces but found 22  indent
  237:1   error  Expected indentation of 22 spaces but found 24  indent
  238:1   error  Expected indentation of 22 spaces but found 24  indent
  239:1   error  Expected indentation of 22 spaces but found 24  indent
  240:1   error  Expected indentation of 20 spaces but found 22  indent
  543:1   error  Expected indentation of 14 spaces but found 12  indent
  544:1   error  Expected indentation of 16 spaces but found 14  indent
  546:1   error  Expected indentation of 16 spaces but found 14  indent
  547:1   error  Expected indentation of 18 spaces but found 16  indent
  548:1   error  Expected indentation of 18 spaces but found 16  indent
  549:1   error  Expected indentation of 16 spaces but found 14  indent
  551:1   error  Expected indentation of 16 spaces but found 14  indent
  552:1   error  Expected indentation of 14 spaces but found 12  indent
  553:1   error  Expected indentation of 14 spaces but found 12  indent
  554:1   error  Expected indentation of 16 spaces but found 14  indent
  556:1   error  Expected indentation of 16 spaces but found 14  indent
  557:1   error  Expected indentation of 18 spaces but found 16  indent
  558:1   error  Expected indentation of 18 spaces but found 16  indent
  559:1   error  Expected indentation of 16 spaces but found 14  indent
  561:1   error  Expected indentation of 16 spaces but found 14  indent
  562:1   error  Expected indentation of 14 spaces but found 12  indent
  593:1   error  Expected indentation of 14 spaces but found 12  indent
  594:1   error  Expected indentation of 16 spaces but found 14  indent
  596:1   error  Expected indentation of 16 spaces but found 14  indent
  597:1   error  Expected indentation of 18 spaces but found 16  indent
  598:1   error  Expected indentation of 18 spaces but found 16  indent
  599:1   error  Expected indentation of 16 spaces but found 14  indent
  601:1   error  Expected indentation of 16 spaces but found 14  indent
  602:1   error  Expected indentation of 14 spaces but found 12  indent
  603:1   error  Expected indentation of 14 spaces but found 12  indent
  604:1   error  Expected indentation of 16 spaces but found 14  indent
  606:1   error  Expected indentation of 16 spaces but found 14  indent
  607:1   error  Expected indentation of 18 spaces but found 16  indent
  608:1   error  Expected indentation of 18 spaces but found 16  indent
  609:1   error  Expected indentation of 16 spaces but found 14  indent
  611:1   error  Expected indentation of 16 spaces but found 14  indent
  612:1   error  Expected indentation of 14 spaces but found 12  indent
  778:43  error  Unnecessary escape character: \.
no-useless-escape


   2:1  error  Expected indentation of 2 spaces but found 4   indent
   3:1  error  Expected indentation of 2 spaces but found 0   indent
   4:1  error  Expected indentation of 4 spaces but found 2   indent
   6:1  error  Expected indentation of 4 spaces but found 2   indent
   7:1  error  Expected indentation of 6 spaces but found 4   indent
   8:1  error  Expected indentation of 8 spaces but found 6   indent
  21:1  error  Expected indentation of 8 spaces but found 6   indent
  22:1  error  Expected indentation of 10 spaces but found 8  indent
  34:1  error  Expected indentation of 8 spaces but found 6   indent
  36:1  error  Expected indentation of 8 spaces but found 6   indent
  37:1  error  Expected indentation of 8 spaces but found 6   indent
  38:1  error  Expected indentation of 10 spaces but found 8  indent
  39:1  error  Expected indentation of 10 spaces but found 8  indent
  40:1  error  Expected indentation of 8 spaces but found 6   indent
  41:1  error  Expected indentation of 6 spaces but found 4   indent
  42:1  error  Expected indentation of 4 spaces but found 2   indent
  44:1  error  Expected indentation of 4 spaces but found 2   indent
  45:1  error  Expected indentation of 2 spaces but found 0   indent


  150:1  error  Expected indentation of 8 spaces but found 10   indent
  151:1  error  Expected indentation of 6 sp

Jenkins build is back to normal : pgadmin4-master-python27 #453

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python35 #453

[pgAdmin 4 Jenkins]

See 

pgAdmin 4 commit: Complain if the default web browser cannot be opened.

[Dave Page]

Complain if the default web browser cannot be opened.

Branch
--
runtime-revamp

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9d0d1eb5fd092d501975c362947d7579daf57bd2

Modified Files
--
runtime/TrayIcon.cpp | 8 +++-
runtime/pgAdmin4.cpp | 8 +++-
2 files changed, 14 insertions(+), 2 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python26 #582

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python34 #442

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python36 #449

[pgAdmin 4 Jenkins]

See 

[pgadmin4] Feature tests

[Joao De Almeida Pereira]

Hello Hackers,
Is the latest commit in master passing the Feature tests?

Thanks
Joao

Re: [pgadmin4] Feature tests

[Murtuza Zabuawala]

No, we are looking into it.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Jan 22, 2018 at 6:56 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Hackers,
> Is the latest commit in master passing the Feature tests?
>
> Thanks
> Joao
>

Re: [pgadmin4] Explain plans

[Joao De Almeida Pereira]

Hello,
Eventually we can extract a ExecuteQuery class that will execute the query
and poll for the result this way can extract some code from SQLEditor. Then
the execute query can have parameters for the explain plan option and we
can build the query in the backend.

Thanks for the input, I will try to do some work in this extraction.

Thanks
Joao

On Mon, Jan 22, 2018 at 4:58 AM, Dave Page  wrote:

> Hi
>
> On Fri, Jan 19, 2018 at 2:09 PM, Joao De Almeida Pereira
>  wrote:
> > Hello Hackers,
> > We are trying to find a solution for the explain plans that currently are
> > not working in GP, due to the lack of support for JSON. We believe that
> the
> > best options for this it would be to display the text in the tab instead
> of
> > the visual version for our case.
> > In order to implement this we came up with some options that we would
> like
> > to understand what the community think about them.
> >
> > Move the SQL to generate explain plans to backend
> > For this approach we would create a new endpoint to generate an explain
> plan
> > and when we click the explain plan buttons instead of doing a new SQL
> query
> > we would call the new endpoint and wait for the explain plan to be
> generated
> >
> > Pros:
> >
> > All SQL related code is in the backend
> > Extract more code from SQLEditor into smaller and more
> testable/maintainable
> > modules
> >
> > Cons:
> >
> > Major Revamp of SQLEditor
> > If explain plan takes to long to generate we will be waiting for it in
> the
> > foreground instead of polling
> >
> > Add parameters while executing SQL
> > If we add parameters in the SQL query request we send to the backend,
> > informing the backend that the SQL query is a Explain Plan to be
> > executed(The response can have a flag saying that this is an explain
> plan,
> > instead of assuming from the return values that it was an explain plan)
> >
> > Pros:
> >
> > All SQL related code is in the backend
> > Leverage the current polling system
> >
> > Cons:
> >
> > Add more logic to an already complex SQLEditor
> >
> > Disable Explain plan buttons
> > Disable/Enable the Explain plan buttons depending on the type of
> database,
> > this would also include the tab in the bottom of the SQLEditor
> >
> > Pros:
> >
> > Simpler solution
> >
> > Cons:
> >
> > Not really a good implementation, because all databases support explain
> > plans
> > There will still be SQL in both frontend and backend
> > Looks more like a temporary fix instead of a solution
> >
> >
> > We believe that we should not keep build feature inside the SQLEditor,
> but
> > should try to extract as many parts of it as possible, this is where the
> > current option 2 fall short in our point of view. Due to this we believe
> > that option 1 looks promising and that is that path that we prefer to go
> > into.
> > What does the community think about this?
>
> "If explain plan takes to long to generate we will be waiting for it
> in the foreground instead of polling" seems like a show stopper for
> option 1 to me. Consider that the user may have chosen to do EXPLAIN
> ANALYZE, which executes the actual query.
>
> I agree that 3 isn't really an option - and I also agree that
> factoring out functionality into smaller units is good. Option 2
> doesn't preclude that though does it? It just doesn't require it.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin4]{Patch] Display GreenPlum partitions and correct SQL on SQL Tab

[Joao De Almeida Pereira]

Hello Hackers,
I merge the 2 commits into 1 and also corrected a problem with SQL display
of partitions in GP.
So this new patch Displays the partitions on GreenPlum database, correct
SQL that was being used in the SQL tab for Schemas and display the correct
SQL for Partitioned tables in GreenPlum.

It is now ready for Review and Merge

Thanks
Joao


On Thu, Jan 18, 2018 at 9:48 AM Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Hackers,
>
> In the attached patches we enable the display of partitions on GreenPlum
> database and also correct SQL that was being used in the SQL tab form
> Schemas
>
> Thanks
> Joao
>


display_partitions_on_greenplum.diff
Description: Binary data

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

[Joao De Almeida Pereira]

Any comments on this patch? Or is it ready to merge?

On Fri, Jan 19, 2018 at 7:56 AM Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Hackers,
> I am updating this patch as we found out that the SQL tab was not showing
> the functions properly, and we corrected that in the new update patch in
> this email
>
> Thanks
> Joao
>
> On Wed, Jan 17, 2018 at 12:25 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>>
>> @Dave I sent the new patch with correction in the previous email. Can you
>> review it and let us know if it is ok?
>>
>>
>> On Fri, Jan 12, 2018 at 12:48 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Thanks for the help Murtuza
>>>
>>> Attached you can find the revisited patch that now displayed all the
>>> information about functions in GreenPlum
>>>
>>> Thanks
>>> Joao
>>>
>>> On Fri, Jan 12, 2018 at 9:51 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 ​Hi,

 We ​create collection of existing parameters using function
 'def _format_arguments_from_db(...)' in a file
 '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py'
 @ line 454, and on client side we have backbone collection mapped with same
 id on line 304 (function.js)



 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hello,
> I changed that function to make the retrieval quicker because the
> return type of all the types in the database for GreenPlum can be quite 
> big.
>
> Nevertheless the "Data Types" in the front end do not get filled up
> with the values.
>
> Where is the Javascript code that does the mapping between the call of
> get_types and that table in the screenshot?
>
> Thanks
> Joao
>
>
> On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Joao,
>>
>> We have written common function 'def get_types(...)' in a class
>> called 'DataTypeReader' to fetch datatypes in a file
>> '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py'
>> and we have inherited from DataTypeReader in Function module's
>> 'FunctionView' class to use it check line no. 120
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello Hackers,
>>> We had some requests from GreenPlum users to display the functions
>>> node again.
>>> This patch reintroduces functions as a node underneath the Schemas.
>>>
>>>
>>> Unfortunately this patch is not final because I could not find the
>>> place where the Data Type is populated from. (See next image)[image:
>>> Screen Shot 2018-01-11 at 10.59.28 AM.png]
>>>
>>> Can anyone explain me how these types get populated?
>>>
>>>
>>>
>>> Thanks
>>> Joao
>>>
>>
>>
>

>>>
>>
>

Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

[Murtuza Zabuawala]

Hi Dave,

Please find updated patch with docs and JS tests.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Jan 22, 2018 at 4:02 PM, Dave Page  wrote:

> Hi
>
> This seems to be missing documentation updates. I would also expect to see
> some Jasmine unit tests for some/all of the new JS functions.
>
> On Tue, Jan 16, 2018 at 1:29 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to add keyboard navigation in Debugger module via
>> Tab/Shift-Tab key.
>> RM#2897
>>
>> Also fixed the issue where user was not able to update values in
>> variable's panel while debugging.
>> RM#2981
>>
>> Currrently we have execution related shortcuts using accesskey,
>> Shortcuts (Execution related)
>> --
>>  + i  = Step in
>>  + o = Step over
>>  + c = Continue/Restart
>>  + t = Toggle breakpoint
>>  + x = Clear all breakpoints
>>  + s = Stop
>>
>> Shortcuts (Panel navigation related)
>> --
>> Alt + Shift + Right Arrow
>> Alt + Shift + Left Arrow
>>
>> Edit/Enter values in Grid (Parameter & Local variables panel's)
>> -
>> Alt + Shift + g
>>
>> Please review.
>>
>> *Note:* As of now inner panel's are not getting focused on Tab/Shift-Tab
>> keys but once RM#2895  patch
>> gets committed it will start working automatically as it's inherited code
>> which will add tabindex tag automatically on each newly created wcDocker
>> panel.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/docs/en_US/keyboard_shortcuts.rst 
b/docs/en_US/keyboard_shortcuts.rst
index de67f3e..119bd79 100644
--- a/docs/en_US/keyboard_shortcuts.rst
+++ b/docs/en_US/keyboard_shortcuts.rst
@@ -89,3 +89,32 @@ When using the Query Tool, the following shortcuts are 
available:
 
+--++---+
 | Ctrl+Shift+F | Cmd+Shift+F| Replace  
 |
 
+--++---+
+
+**Debugger**
+
+When using the Debugger, the following shortcuts are available:
+
++--+---+--+
+| Shortcut (Windows/Linux) | Shortcut (Mac)| Function  
   |
++==+===+==+
+|  + i  |  + i   | Step in   
   |
++--+---+--+
+|  + o  |  + o   | Step over 
   |
++--+---+--+
+|  + c  |  + c   | Continue/Restart  
   |
++--+---+--+
+|  + t  |  + t   | Toggle breakpoint 
   |
++--+---+--+
+|  + x  |  + x   | Clear all breakpoints 
   |
++--+---+--+
+|  + s  |  + s   | Stop  
   |
++--+---+--+
+| Alt + Shift + Right Arrow| Alt + Shift + Right Arrow | Move to next inner 
panel |
++--+---+--+
+| Alt + Shift + Left Arrow | Alt + Shift + Left Arrow  | Move to previous 
inner panel |
++--+---+--+
+| Alt + Shift + g  | Alt + Shift + g   | Enter or Edit values 
in Grid |
++--+---+--+
+
+.. note::  can be browser and platform dependant please `click here 
`_
 for more information.
+
diff --git a/web/pgadmin/static/js/keyboard_shortcuts.js 
b/web/pgadmin/static/js/keyboard_shortcuts.js
new file mode 100644
index 000..780e089
--- /dev/null
+++ b/web/pgadmin/static/js/keyboard_shortcuts.js
@@ -0,0 +1,119 @@
+import $ from 'jquery';
+
+const EDIT_KEY = 71,  // Key: G -> Grid values
+  LEFT_ARROW_KEY = 37,
+  RIGHT_ARROW_KEY = 39;
+
+function isMac() {
+  return window.navigator.platform.search('Mac') != -1;
+}
+
+function isKeyCtrlAlt(event) {
+  return event.ctrlKey || event.altKey;
+}
+
+function isKeyAltShift(event) {
+  return e