date:20180115

[pgAdmin4][Patch#3013] Fixed minor UI issue on Dashboard

2018-01-15 Thread Murtuza Zabuawala

Hi,

PFA patch to fix the minor UI issue on dashboard while displaying subnode
control in Backgrid.
RM#3013

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/dashboard/static/css/dashboard.css 
b/web/pgadmin/dashboard/static/css/dashboard.css
index eb56fed..2fc7897 100644
--- a/web/pgadmin/dashboard/static/css/dashboard.css
+++ b/web/pgadmin/dashboard/static/css/dashboard.css
@@ -171,4 +171,8 @@
   font-size: 14px;
 }
 
+.dashboard-tab-container .pg-el-container[el=sm] .pg-el-sm-12 {
+margin-bottom: 0%;
+}
+
 /* CSS to make subnode control look preety in backgrid - END */

pgAdmin 4 commit: Support Properties on Greenplum databases. Fixes #301

2018-01-15 Thread Dave Page

Support Properties on Greenplum databases. Fixes #3015

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56e922f5abff35e6904d59c2173fd127ac336285
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
.../templates/databases/sql/9.1_plus/acl.sql   | 35 ++
.../templates/databases/sql/9.1_plus/defacl.sql| 34 +
.../databases/sql/9.1_plus/get_ctypes.sql  |  5 +++
.../databases/sql/9.1_plus/get_variables.sql   |  5 +++
.../databases/sql/9.1_plus/properties.sql  | 43 ++
.../templates/databases/sql/default/acl.sql| 38 +++
.../templates/databases/sql/default/defacl.sql | 39 +++-
.../templates/databases/sql/default/get_ctypes.sql |  6 +--
.../databases/sql/default/get_variables.sql|  7 +---
.../templates/databases/sql/default/properties.sql | 23 
web/pgadmin/feature_tests/query_tool_tests.py  | 27 +++---
.../feature_tests/xss_checks_roles_control_test.py |  4 ++
web/regression/python_test_utils/test_utils.py |  8 +++-
13 files changed, 201 insertions(+), 73 deletions(-)

Re: [pgadmin4][Patch] Access Database properties

2018-01-15 Thread Dave Page

Thanks - patch applied!

On Fri, Jan 12, 2018 at 5:46 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
> This patch tackles the visualization of properties on a GreenPlum
> Database. Previously when you tried to access these properties a SQL error
> was displayed.
>
> Also in the patch we made some correction to feature tests, and skipped
> other test that were failing against GreenPlum
>
> Thanks
> Joao
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-15 Thread Dave Page

Hi

Unfortunately there's variation in the spec of the images. Can you please
check with Chethana on the correct sizing and resolution etc? For example,
query_sql_editor.png was previously 755x209, but now is 2042x402.

Thanks!

On Mon, Jan 15, 2018 at 7:21 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA patch to update docs & screenshots for the new connection status
> feature.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Fri, Jan 12, 2018 at 8:08 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Sure, I'll do that.
>>
>> On Fri, Jan 12, 2018 at 8:05 PM, Dave Page  wrote:
>>
>>> Thanks - patch applied!
>>>
>>> Can you please update the docs for the new config options, and any
>>> screenshot updates that are required?
>>>
>>> On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 PFA updated patch with additional checks to prevent unnecessary
 polling added as suggested.
 Please review.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 On Thu, Jan 11, 2018 at 2:33 PM, Dave Page  wrote:

>
>
> On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> User can open Query tool in new browser window where we'll not have
>>> wcDocker panel.
>>>
>>
>> In that case we can use window onfocus and onblur events
>> .
>> In sqleditor there are cases where we've written conditional code
>> based on whether sqleditor is opened in new window or not.
>>
>
> This is a great suggestion (the idea in general). We need to make this
> happen - it'll go a long way to minimising our concerns about the amount 
> of
> polling.
>
>
>>
>>
>> On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Murtuza, I think we should only poll if sqleditor/datagrid is
 visible.
 We've *wcDocker.EVENT.VISIBILITY_CHANGED *event when panel
 visibility changes.

 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA updated patch.
>
> On Tue, Jan 9, 2018 at 7:57 PM, Dave Page 
> wrote:
>
>> Hi
>>
>> On Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find updated patch.
>>>
>>
>> I turned off the status option, but polling is still happening.
>> This should definitely stop! :-)
>>
> Fixed typo in variable.
>
> Can you also reverse the enable/disable switch and the interval
>> setting on the preferences page? I think Enable/Disable should be at 
>> the
>> top, and be followed by the interval.
>> 
>>
>  Fixed.
> 
> But just a heads up we won't be able to put '?' after 'Connection
> status'  eg: '
> Connection status
> ?'
> 
> Then string sorting again puts it after 'Connection status
> refresh rate' :)
>
>> 
>>
>> Thanks.
>>
>>
>>>
>>> On Mon, Jan 8, 2018 at 7:21 PM, Dave Page 
>>> wrote:
>>>


 On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA updated patch.
>
> On Mon, Jan 8, 2018 at 5:11 PM, Dave Page 
> wrote:
>
>> Hi
>>
>> On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> PFA updated patch,
>>>
>>>
>>> On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <
>>> dp...@pgadmin.org> wrote:
>>>
 Hi

 On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi

[pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

2018-01-15 Thread Khushboo Vashi

Hi,

Please find the attached patch for RM # 2904: As a visually impaired user I
need all buttons in the application to have appropriate tooltips for my
screen reader to interpret.

Thanks,
Khushboo
diff --git a/web/pgadmin/about/static/js/about.js b/web/pgadmin/about/static/js/about.js
index 1e72c91..1a6446a 100644
--- a/web/pgadmin/about/static/js/about.js
+++ b/web/pgadmin/about/static/js/about.js
@@ -20,7 +20,8 @@ define(
   },
   setup: function() {
 return {
-  buttons:[{ text: gettext('OK'), key: 27, className: 'btn btn-primary' }],
+  buttons:[{ text: gettext('OK'), key: 27, className: 'btn btn-primary',
+   attrs: {'title': gettext('OK')}}],
   options: {
 modal: false,
 resizable: true,
diff --git a/web/pgadmin/browser/static/js/wizard.js b/web/pgadmin/browser/static/js/wizard.js
index 56b1edf..a95f702 100644
--- a/web/pgadmin/browser/static/js/wizard.js
+++ b/web/pgadmin/browser/static/js/wizard.js
@@ -128,14 +128,18 @@ define([
   '  ' +
   '  ' +
   '' +
-  '  >' +
+  '  ' +
+  '   title = "' + gettext('Back') + '">' +
   '' + gettext('Back') + '' +
-  '  >' +
+  '  ' +
+  '   title = "' + gettext('Next') + '" >' +
   '' + gettext('Next') +
   '' +
-  '  >' +
+  '  ' +
+  '  title = "' + gettext('Cancel') + '">' +
   '' + gettext('Cancel') + '' +
-  '  >' +
+  '  ' +
+  'title = "' + gettext('Finish') + '">' +
   '' + gettext('Finish') + '' +
   '' +
   '  ' +
diff --git a/web/pgadmin/preferences/static/js/preferences.js b/web/pgadmin/preferences/static/js/preferences.js
index d025be1..dfa3b2c 100644
--- a/web/pgadmin/preferences/static/js/preferences.js
+++ b/web/pgadmin/preferences/static/js/preferences.js
@@ -401,10 +401,12 @@ define('pgadmin.preferences', [
 text: gettext('OK'),
 key: 13,
 className: 'btn btn-primary fa fa-lg fa-save pg-alertify-button',
+attrs: {'title': gettext('OK')}
   }, {
 text: gettext('Cancel'),
 key: 27,
 className: 'btn btn-danger fa fa-lg fa-times pg-alertify-button',
+attrs: {'title': gettext('Cancel')}
   }],
   focus: {
 element: 0,
diff --git a/web/pgadmin/settings/static/js/settings.js b/web/pgadmin/settings/static/js/settings.js
index 634368c..0402b5c 100644
--- a/web/pgadmin/settings/static/js/settings.js
+++ b/web/pgadmin/settings/static/js/settings.js
@@ -51,7 +51,7 @@ define('pgadmin.settings', [
 function() {
   // Do nothing as user canceled the operation.
 }
-  );
+  )
 },
   };
 
diff --git a/web/pgadmin/static/js/alertify.pgadmin.defaults.js b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
index 3129ecc..9b815f5 100644
--- a/web/pgadmin/static/js/alertify.pgadmin.defaults.js
+++ b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
@@ -369,5 +369,11 @@ define([
 },
   });
 
+  // Confirm dialogue: Set title tag
+  alertify.confirm().set({onshow:function() {
+$(this.__internal.buttons[0].element).attr('title', gettext('OK'));
+$(this.__internal.buttons[1].element).attr('title', gettext('Cancel'));
+  }});
+
   return alertify;
 });
diff --git a/web/pgadmin/tools/backup/static/js/backup.js b/web/pgadmin/tools/backup/static/js/backup.js
index 367f354..c20b98e 100644
--- a/web/pgadmin/tools/backup/static/js/backup.js
+++ b/web/pgadmin/tools/backup/static/js/backup.js
@@ -604,6 +604,7 @@ define([
 type: 'button',
 url: 'backup.html',
 label: gettext('Backup'),
+title: gettext('Backup')
   },
 }, {
   text: '',
@@ -616,17 +617,24 @@ define([
 url: url_for('help.static', {
   'filename': 'backup_dialog.html',
 }),
+title: gettext('Backup')
   },
 }, {
   text: gettext('Backup'),
   key: 13,
   className: 'btn btn-primary fa fa-lg fa-save pg-alertify-button',
   'data-btn-name': 'backup',
+  attrs: {
+title: gettext('Backup')
+  }
 }, {
   text: gettext('Cancel'),
   key: 27,
   className: 'btn btn-danger fa fa-lg fa-times pg-alertify-button',
   'data-btn-name': 'cancel',
+  attrs: {
+

pgAdmin 4 commit: Doc updates for connection status monitoring.

2018-01-15 Thread Dave Page

Doc updates for connection status monitoring.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03605bf9bed44585396541373e521619ddfb02bb
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/images/preferences_sql_display.png  | Bin 76673 -> 144736 bytes
docs/en_US/images/query_sql_editor.png | Bin 41230 -> 35079 bytes
docs/en_US/images/query_tool.png   | Bin 164023 -> 207453 bytes
docs/en_US/images/query_tool_connection_status.png | Bin 0 -> 264010 bytes
docs/en_US/preferences.rst |   4 
docs/en_US/query_tool.rst  |   8 +++-
6 files changed, 11 insertions(+), 1 deletion(-)

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-15 Thread Dave Page

Thanks, applied.

On Mon, Jan 15, 2018 at 11:35 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Mon, Jan 15, 2018 at 2:57 PM, Dave Page  wrote:
>
>> Hi
>>
>> Unfortunately there's variation in the spec of the images. Can you please
>> check with Chethana on the correct sizing and resolution etc? For example,
>> query_sql_editor.png was previously 755x209, but now is 2042x402.
>>
> Fixed.
>
> PFA updated patch.
> 
>
>
>>
>> Thanks!
>>
>> On Mon, Jan 15, 2018 at 7:21 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> PFA patch to update docs & screenshots for the new connection status
>>> feature.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Fri, Jan 12, 2018 at 8:08 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Sure, I'll do that.

 On Fri, Jan 12, 2018 at 8:05 PM, Dave Page  wrote:

> Thanks - patch applied!
>
> Can you please update the docs for the new config options, and any
> screenshot updates that are required?
>
> On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> PFA updated patch with additional checks to prevent unnecessary
>> polling added as suggested.
>> Please review.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Thu, Jan 11, 2018 at 2:33 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, Jan 11, 2018 at 7:00 AM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> User can open Query tool in new browser window where we'll not
> have wcDocker panel.
>

 In that case we can use window onfocus and onblur events
 
 .
 In sqleditor there are cases where we've written conditional code
 based on whether sqleditor is opened in new window or not.

>>>
>>> This is a great suggestion (the idea in general). We need to make
>>> this happen - it'll go a long way to minimising our concerns about the
>>> amount of polling.
>>>
>>>


 On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Murtuza, I think we should only poll if sqleditor/datagrid is
>> visible.
>> We've *wcDocker.EVENT.VISIBILITY_CHANGED *event when panel
>> visibility changes.
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, Jan 10, 2018 at 1:55 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> PFA updated patch.
>>>
>>> On Tue, Jan 9, 2018 at 7:57 PM, Dave Page 
>>> wrote:
>>>
 Hi

 On Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find updated patch.
>

 I turned off the status option, but polling is still happening.
 This should definitely stop! :-)

>>> Fixed typo in variable.
>>>
>>> Can you also reverse the enable/disable switch and the interval
 setting on the preferences page? I think Enable/Disable should be 
 at the
 top, and be followed by the interval.
 

>>>  Fixed.
>>> 
>>> But just a heads up we won't be able to put '?' after
>>> 'Connection status'  eg: '
>>> Connection status
>>> ?'
>>> 
>>> Then string sorting again puts it after 'Connection status
>>> refresh rate' :)
>>>
 

 Thanks.


>
> On Mon, Jan 8, 2018 at 7:21 PM, Dave Page 
> wrote:
>
>>
>>
>> On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> PFA updated patch.
>>>
>>> On Mon, Jan 8, 2018 at 5:11 PM, Dave Page >> > wrote:
>>>
 Hi
>>>

pgAdmin 4 commit: Fix a minor UI issue on dashboard while displaying su

2018-01-15 Thread Dave Page

Fix a minor UI issue on dashboard while displaying subnode control in Backgrid. 
Fixes #3013

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ad46d61bd3a26d6d1cef3b7e764125382b186068
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/dashboard/static/css/dashboard.css | 4 
1 file changed, 4 insertions(+)

Re: [pgAdmin4][Patch#3013] Fixed minor UI issue on Dashboard

2018-01-15 Thread Dave Page

Thanks, patch applied.

On Mon, Jan 15, 2018 at 7:59 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the minor UI issue on dashboard while displaying subnode
> control in Backgrid.
> RM#3013
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

2018-01-15 Thread Dave Page

Hi

On Mon, Jan 15, 2018 at 10:23 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for RM # 2904: As a visually impaired user
> I need all buttons in the application to have appropriate tooltips for my
> screen reader to interpret.
>

Unfortunately I think there's been a misunderstanding with this patch, most
likely my fault for not being clearer;

- There is no need to add tooltips to buttons that already have text,
unless we want to add additional information. For example, on the OK
button, we might have a tooltip that says "Apply the changes and close the
dialog". That really is optional though, as screen readers could already
read the button text (but we should be consistent).

- We do need to add tooltips to buttons that don't have any text. For
example;
 * dialogue title-bar buttons
 * the "close tab" and "move tabs left"/"move tabs right" buttons that
may appear in tab bars
 * the add row button at the top of a subnode control (e.g. to add a
column definition)
 * the delete and expand row buttons in subnode grid rows

Sorry for not being clearer about the requirements.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: pgadmin4 server error message processing

2018-01-15 Thread Ioseph Kim


This bug was not fixed still,

  File 
"/usr/lib/python2.7/site-packages/pgadmin4-web/pgadmin/utils/driver/psycopg2/__init__.py", 
line 1541, in _formatted_exception_msg

    self.decode_to_utf8(exception_obj.diag.message_primary)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xec in position 0: 
ordinal not in range(128)


This rpm is pgadmin4-v2-2.1-1.rhel7.x86_64.

Reguards, Ioseph.


2017년 12월 27일 13:41에 Murtuza Zabuawala 이(가) 쓴 글:

Hi,

Similar issue was already reported by other users,
https://redmine.postgresql.org/issues/2806
https://redmine.postgresql.org/issues/2821

We have recently fixed it and fix should be available in next pgAdmin4 
release.


Thanks,
Murtuza

On Wed, Dec 27, 2017 at 9:34 AM, Ioseph Kim > wrote:


Hi,

when server message is not english (my server is korean),

pgadmin4 make a error bellow.


  File

"/usr/lib/python2.7/site-packages/pgadmin4-web/pgadmin/utils/driver/psycopg2/__init__.py",
line 1612, in _formatted_exception_msg
    self.decode_to_utf8(exception_obj.diag.message_primary)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xec in
position 0: ordinal not in range(128)


This pgadmin4 is pgadmin4-v2-2.0-1.rhel7.x86_64.rpm package on
CentOS7.

It may be a problem utf8 encoding string processing of python 2.7.


I sugesst , if server message is non english, decoding to utf8 is
skiped.

Re: ESLINT: On pgAdmin static javascripts

2018-01-15 Thread Fahar Abbas

Hi Ashesh,

I have finished smoke verification for all the modules and no issue found
so far and currently doing testing in detail.

Kind Regards,


On Mon, Jan 15, 2018 at 10:17 AM, Fahar Abbas 
wrote:

>
>
> On Fri, Jan 12, 2018 at 12:35 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Thu, Jan 11, 2018 at 11:16 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Hi Murtuza,
>>>
>>> On Tue, Jan 9, 2018 at 4:08 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 All patches looks good to me except one issue as shown in screenshot
 which I observed while opening Preferences dialog subsequently.

>>> I was able to reproduce the issue on 'master' branch without these
>>> patches too.
>>> I have fixed the same issue on 'WEBPACK_DEVEL2' branch.
>>>
>>> Dependent libraries are using different versions of jQuery, and hence
>>> loading two differct jQuery in the webpack.
>>> And, that's causing the issue.
>>>
>>> We can take of the issue in a separate patch.
>>>
>> Committed these patches.
>>
>> Fahar,
>>
>> You may want to be on top of this as this commit has touched all the
>> modules.
>>
>> Sure.
>
>> -- Thanks, Ashesh
>>
>>>
>>> -- Thanks, Ashesh
>>>

 --
  Murtuza

 On Tue, Jan 9, 2018 at 1:19 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

>
>
> On Tue, Jan 9, 2018 at 12:28 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Please try rest of the patches...
>> They are independent of each other.
>>
>> -- Thanks, Ashesh
>>
>> On Jan 8, 2018 23:45, "Murtuza Zabuawala" <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> I'm not able to apply patch :(
>>>
>>> murtuza@debian:~/projects/pgadmin4$ git apply ~/Desktop/*.patch
>>> error: patch failed: web/pgadmin/misc/file_manager/
>>> static/js/utility.js:10
>>> error: web/pgadmin/misc/file_manager/static/js/utility.js: patch
>>> does not apply
>>>
>>>  murtuza@debain:~/projects/pgadmin4$ git status | grep '\.rej' | wc
>>> -l
>>>   55
>>>
>> Please find the updated patch for "Browser-specific javascript
> files", which was having diff for 'web/pgadmin/misc/file_manager/
> static/js/utility.js'.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Mon, Jan 8, 2018 at 9:11 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>

 On Mon, Jan 8, 2018 at 8:52 PM, Dave Page 
 wrote:

> Hi
>
> On Mon, Jan 8, 2018 at 3:18 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, Jan 8, 2018 at 8:31 PM, Dave Page 
>> wrote:
>>
>>> Hi
>>>
>>> I think these are impossibly big to properly review by hand,
>>> especially where much of them are whitespace changes.
>>>
>> I ran both jasmine test framework, and feature tests.
>> Both are running fine.
>>
>>>
>>> I think the best option is to check the regression tests all
>>> pass, do some manual testing yourself, and then commit.
>>>
>> Done some manual testing.
>> It would be helpful, If somebody can help with some more testing,
>> which I may have missed.
>>
>
> Please ask one of the team (other than me) :-)
>
 :-)

 -- Thanks, Ashesh

>
>
>>
>> -- Thanks, Ashesh
>>
>>
>>>
>>> On Mon, Jan 8, 2018 at 1:55 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 Hi Dave/Team,

 I found many problems while 'eslint' utility on all the static
 javascript files of pgAdmin 4.
 i.e. /web/node_module/.bin/eslint 

 I had fixed all errors reported by eslint for those files.

 I have created six patches for ease of maintenance, as
 possibilities of conflicting with other patches.
 * Browser nodes javascript files
 * Browser specific javascript files
 * pgAdmin common javascript files
 * SQLEditor/DataGrid javascript files
 * Tools javascript files
 * Miscellaneous modules javascript files

 All patches are independent of each other.

 Please review it,

Re: ESLINT: On pgAdmin static javascripts

2018-01-15 Thread Ashesh Vashi

On Tue, Jan 16, 2018 at 11:10 AM, Fahar Abbas 
wrote:

> Hi Ashesh,
>
> I have finished smoke verification for all the modules and no issue found
> so far and currently doing testing in detail.
>
Thanks Fahar for the update!

--
Thanks & Regards,

Ashesh Vashi

>
> Kind Regards,
>
>
> On Mon, Jan 15, 2018 at 10:17 AM, Fahar Abbas <
> fahar.ab...@enterprisedb.com> wrote:
>
>>
>>
>> On Fri, Jan 12, 2018 at 12:35 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Thu, Jan 11, 2018 at 11:16 AM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 Hi Murtuza,

 On Tue, Jan 9, 2018 at 4:08 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> All patches looks good to me except one issue as shown in screenshot
> which I observed while opening Preferences dialog subsequently.
>
 I was able to reproduce the issue on 'master' branch without these
 patches too.
 I have fixed the same issue on 'WEBPACK_DEVEL2' branch.

 Dependent libraries are using different versions of jQuery, and hence
 loading two differct jQuery in the webpack.
 And, that's causing the issue.

 We can take of the issue in a separate patch.

>>> Committed these patches.
>>>
>>> Fahar,
>>>
>>> You may want to be on top of this as this commit has touched all the
>>> modules.
>>>
>>> Sure.
>>
>>> -- Thanks, Ashesh
>>>

 -- Thanks, Ashesh

>
> --
>  Murtuza
>
> On Tue, Jan 9, 2018 at 1:19 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, Jan 9, 2018 at 12:28 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Please try rest of the patches...
>>> They are independent of each other.
>>>
>>> -- Thanks, Ashesh
>>>
>>> On Jan 8, 2018 23:45, "Murtuza Zabuawala" <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Ashesh,

 I'm not able to apply patch :(

 murtuza@debian:~/projects/pgadmin4$ git apply ~/Desktop/*.patch
 error: patch failed: web/pgadmin/misc/file_manager/
 static/js/utility.js:10
 error: web/pgadmin/misc/file_manager/static/js/utility.js: patch
 does not apply

  murtuza@debain:~/projects/pgadmin4$ git status | grep '\.rej' |
 wc -l
   55

>>> Please find the updated patch for "Browser-specific javascript
>> files", which was having diff for 'web/pgadmin/misc/file_manager/
>> static/js/utility.js'.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 On Mon, Jan 8, 2018 at 9:11 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

>
> On Mon, Jan 8, 2018 at 8:52 PM, Dave Page 
> wrote:
>
>> Hi
>>
>> On Mon, Jan 8, 2018 at 3:18 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Mon, Jan 8, 2018 at 8:31 PM, Dave Page 
>>> wrote:
>>>
 Hi

 I think these are impossibly big to properly review by hand,
 especially where much of them are whitespace changes.

>>> I ran both jasmine test framework, and feature tests.
>>> Both are running fine.
>>>

 I think the best option is to check the regression tests all
 pass, do some manual testing yourself, and then commit.

>>> Done some manual testing.
>>> It would be helpful, If somebody can help with some more
>>> testing, which I may have missed.
>>>
>>
>> Please ask one of the team (other than me) :-)
>>
> :-)
>
> -- Thanks, Ashesh
>
>>
>>
>>>
>>> -- Thanks, Ashesh
>>>
>>>

 On Mon, Jan 8, 2018 at 1:55 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> Hi Dave/Team,
>
> I found many problems while 'eslint' utility on all the static
> javascript files of pgAdmin 4.
> i.e. /web/node_module/.bin/eslint 
>
> I had fixed all errors reported by eslint for those files.
>
> I have created six patches for ease of maintenance, as
> possibilities of conflicting with other patches.
> * Browser nodes javascript files
> * Browser

[pgAdmin4][Patch#3013] Fixed minor UI issue on Dashboard

pgAdmin 4 commit: Support Properties on Greenplum databases. Fixes #301

Re: [pgadmin4][Patch] Access Database properties

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

[pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

pgAdmin 4 commit: Doc updates for connection status monitoring.

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

pgAdmin 4 commit: Fix a minor UI issue on dashboard while displaying su

Re: [pgAdmin4][Patch#3013] Fixed minor UI issue on Dashboard

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

Re: pgadmin4 server error message processing

Re: ESLINT: On pgAdmin static javascripts

Re: ESLINT: On pgAdmin static javascripts

13 matches

Site Navigation

Mail list logo

Footer information