Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key
Hi On Thursday, November 30, 2017, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Mon, Nov 27, 2017 at 5:15 PM, Dave Page > wrote: > >> Hi >> >> On Thu, Nov 23, 2017 at 1:28 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com >> > wrote: >> >>> Hi, >>> >>> Please find the attached patch for RM #2849: Allow editing of data on >>> tables with OIDs but no primary key. >>> >> >> I like that if I add a new row or rows and hit Save, the OIDs are fetched >> immediately. However; >> >> - It marks the row as read-only. We do that currently because we don't >> return the key info on Save, and thus require a Refresh before any further >> editing. However, if we have the OID, we can edit again immediately. >> >> Fixed > >> - If we can return the new OIDs on Save, can't we do the same for primary >> key values? That would be consistent with OIDs, and would remove the need >> to disable rows, leading to a much nicer use experience I think. >> >> Implemented > This looks great, however there is one small issue I spotted; it looks like we're inserting rows in a random order. For example, in the screenshot attached, the last 5 rows were added in the order seen in the key1 column, and then I hit Save and got the id values returned. Is that caused by something we're doing, or the database server? Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch]: Remove default 'Altertify JS' header from debugger related error alerts
Thanks, committed. On Friday, December 1, 2017, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to remove default 'Altertify JS' header from debugger related > error notifications. > RM#2098 > > Also fixed similar issue in other modules. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Add a note to the README on creating the bundle.
Add a note to the README on creating the bundle. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7e419d1bfe30fae4dc008c948bd51c0af877e99f Modified Files -- README | 24 1 file changed, 24 insertions(+)
pgAdmin 4 commit: Cleanup some inconsistent error dialog titles. Fixes
Cleanup some inconsistent error dialog titles. Fixes #2098 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bac9c77c4e3911fd5860312fa4da53f4eab50102 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/backup/static/js/backup.js | 22 +- web/pgadmin/tools/datagrid/static/js/datagrid.js | 1 + web/pgadmin/tools/debugger/static/js/debugger.js | 4 ++-- .../tools/debugger/static/js/debugger_ui.js| 9 ++--- web/pgadmin/tools/debugger/static/js/direct.js | 2 +- web/pgadmin/tools/restore/static/js/restore.js | 10 -- .../user_management/static/js/user_management.js | 9 +++-- 7 files changed, 42 insertions(+), 15 deletions(-)
