[pgAdmin4][runtime][patch]: Fix for RM#2679

[Neel Patel]

Hi,

Please find attached patch to fix RM#2679.

*Issue:-*
Getting started links does not open second time from "Dashboard" panel if
User close runtime tab and open any URL again.

*Analysis:-*
As in runtime Qt application, when user defined "target=_new" then
"createWindow" signal is called but when user close that new windows and
again click on link then "createWindow" signal is not getting called so
from user point view nothing will happen.

*Solution:-*
To make it work in both runtime and web application, changed "target"
attribute to "_blank" so that "createWindow" signal will be called every
time when user click on any link.

Do review it and let me know for comments.

Thanks,
Neel Patel


RM_2679.patch
Description: Binary data

pgAdmin 4 commit: Display relevant error messages when access is denied

[Dave Page]

Display relevant error messages when access is denied creating a schema. Fixes 
#2094

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fd3a7dd3da1c108b12527ec29f4577c57b00eb2
Author: Murtuza Zabuawala 

Modified Files
--
.../browser/server_groups/servers/databases/schemas/__init__.py | 3 +--
web/pgadmin/browser/static/js/node.js   | 6 ++
web/pgadmin/tools/grant_wizard/static/js/grant_wizard.js| 6 ++
3 files changed, 5 insertions(+), 10 deletions(-)

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

[Dave Page]

Thanks, applied.

On Fri, Nov 17, 2017 at 10:30 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA updated.
>
> On Thu, Nov 16, 2017 at 5:12 PM, Dave Page  wrote:
>
>>
>>
>> On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to make error message uniform for 'Create schema' in
>>> both query tool and create schema dialog.
>>> RM#2094
>>>
>>
>> The error message is definitely an improvement, but the dialogue title
>> needs work:
>>
>> Error saving properties: GONE
>>
>> Why does it have : GONE on the end? That seems unhelpful.
>>
> ​That's coming from ajax statusText
> , I
> thought it was intended.
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python26 #511

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Display relevant error messages when access is denied creating a 
schema.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 5fd3a7dd3da1c108b12527ec29f4577c57b00eb2 (origin/master)
Commit message: "Display relevant error messages when access is denied creating 
a schema. Fixes #2094"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5fd3a7dd3da1c108b12527ec29f4577c57b00eb2
 > git rev-list 2f17ecba760dcb210b6bf70b259860dd569a7888 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=2.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python26] $ /bin/sh -xe /tmp/jenkins354177208127848204.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.6 virtual environment...

New python executable in 

Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/local/python-2.6/bin/python
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Collecting wheel==0.29.0
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. You can upgrade to a newer version of Python to solve 
this. For more information, see 
https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Using cached wheel-0.29.0-py2.py3-none-any.whl
Collecting argparse; python_version == "2.6" (from wheel==0.29.0)
  Using cached argparse-1.4.0-py2.py3-none-any.whl
Installing collected packages: argparse, wheel
Successfully installed argparse-1.4.0 wheel-0.29.0
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Ignoring Flask-HTMLmin: markers 'python_version >= "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. You can upgrade to a newer version of Python to solve 
this. For more information, see 
https://urllib3.readthedocs.io/en/latest/se

pgAdmin 4 commit: Fix support for time without timezone. Fixes #2881

[Dave Page]

Fix support for time without timezone. Fixes #2881

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25794580915c1da92c4583c2833a54ca71423698
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Re: [pgAdmin4][Patch]: Add support for time without time zone

[Dave Page]

Thanks, applied.

On Fri, Nov 17, 2017 at 12:41 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to add support for time without time zone.
> RM#2881
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Allow configuration of CSV and clipboard formatting o

[Dave Page]

Allow configuration of CSV and clipboard formatting of query results. Fixes 
#2781

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c566f132e19ab4476f570664647683f97361cb0
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/images/preferences_sql_csv_output.png   | Bin 0 -> 86945 bytes
docs/en_US/images/preferences_sql_result_grid.png  | Bin 0 -> 100020 bytes
docs/en_US/preferences.rst |  16 
docs/en_US/query_tool.rst  |   6 +-
.../copy_selected_query_results_feature_test.py|  32 
.../feature_tests/query_tool_journey_test.py   |   8 +-
web/pgadmin/preferences/static/js/preferences.js   |  18 -
web/pgadmin/static/js/backform.pgadmin.js  |   2 +-
web/pgadmin/static/js/selection/copy_data.js   |   3 +-
.../js/selection/range_boundary_navigator.js   |  40 ++
.../handle_query_output_keyboard_event.js  |   3 +-
web/pgadmin/tools/sqleditor/__init__.py|  81 -
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  33 -
web/pgadmin/utils/driver/psycopg2/__init__.py  |  20 +++--
web/pgadmin/utils/preferences.py   |  15 +++-
web/regression/feature_utils/pgadmin_page.py   |   1 +
.../javascript/selection/copy_data_spec.js |  12 +--
.../selection/range_boundary_navigator_spec.js |  27 ---
.../handle_query_output_keyboard_event_spec.js |   4 +-
19 files changed, 248 insertions(+), 73 deletions(-)

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

[Dave Page]

Thanks, applied.

On Mon, Nov 20, 2017 at 5:18 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached updated patch.
>
>
> On Thu, Nov 16, 2017 at 7:42 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for RM #2781 : New option to set the
>>> quotation mark for copying to clipboard.
>>>
>>> This patch includes:
>>>
>>> - Provide options in preferences to control the CSV output which
>>> includes copy to clipboard and download as CSV features in Query Tool
>>> - Modified related jasmine tests
>>> - Modified related feature tests
>>>
>>
>> Thanks. At first glance, I see a few issues with this patch:
>>
>> - I can type into the combo boxes in the preferences, but only to search.
>> That means (for example) that the only quote character I can use is ". I
>> can't use anything else as a might want. The same applies to the field
>> separator.
>>
>
>>
> Provided provision to add user defined field separator and quote
> character.
>
> - I can click the x to clear the options in the combo boxes, but then the
>> settings can be accepted and stored. For the separator and quote char, I
>> assume they just become blank, however the quoting method makes no sense to
>> be unspecified.
>>
>> Fixed. User can not clear the combo-boxes.
>
> - There don't seem to be any documentation updates.
>>
> The documents of SQL Editor and Preferences are updated.
>
>>
>> - The CSV Quoting options appear to apply to copying from the grid, but
>> they should apply to saving results as CSV.
>>
>> - The Result Copy quoting options (which should apply to copied data) are
>> missing altogether.
>>
>> To be clear, there should be 6 new config options, 3 of which apply to
>> data when copied from the grid, and the other 3 which apply when saving
>> data as CSV. Please see the original RM case in which I detailed what the
>> settings should be and what they should do.
>>
>
> Provided 2 set of options (one set consists of 3 options);  one for CSV
> output and another for Results grid.
>
>
>>
> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
> Thanks,
> Khushboo
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

[Dave Page]

Though whilst it worked fine when I was testing, I now get the following.
Khushboo - can you investigate please?

Exception in thread Thread-96:

Traceback (most recent call last):

File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 810, in __bootstrap_inner

self.run()

File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 763, in run

self.__target(*self.__args, **self.__kwargs)

File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 602, in process_request_thread

self.handle_error(request, client_address)

File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 599, in process_request_thread

self.finish_request(request, client_address)

File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 334, in finish_request

self.RequestHandlerClass(request, client_address, self)

File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 655, in __init__

self.handle()

File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 200, in handle

rv = BaseHTTPRequestHandler.handle(self)

File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/BaseHTTPServer.py",
line 340, in handle

self.handle_one_request()

File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 235, in handle_one_request

return self.run_wsgi()

File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 177, in run_wsgi

execute(self.server.app)

File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 167, in execute

for data in application_iter:

File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wsgi.py",
line 691, in __next__

return self._next()

File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wrappers.py",
line 81, in _iter_encoded

for item in iterable:

File
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py",
line 828, in gen

quotechar=quote_char

File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
line 670, in __init__

self.writer = writer(f, dialect, *args, **kwds)

File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
line 185, in __init__

raise TypeError(*e.args)

TypeError: "delimiter" must be string, not bytes



On Mon, Nov 20, 2017 at 1:51 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Mon, Nov 20, 2017 at 5:18 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>>
>> On Thu, Nov 16, 2017 at 7:42 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch for RM #2781 : New option to set the
 quotation mark for copying to clipboard.

 This patch includes:

 - Provide options in preferences to control the CSV output which
 includes copy to clipboard and download as CSV features in Query Tool
 - Modified related jasmine tests
 - Modified related feature tests

>>>
>>> Thanks. At first glance, I see a few issues with this patch:
>>>
>>> - I can type into the combo boxes in the preferences, but only to
>>> search. That means (for example) that the only quote character I can use is
>>> ". I can't use anything else as a might want. The same applies to the field
>>> separator.
>>>
>>
>>>
>> Provided provision to add user defined field separator and quote
>> character.
>>
>> - I can click the x to clear the options in the combo boxes, but then the
>>> settings can be accepted and stored. For the separator and quote char, I
>>> assume they just become blank, however the quoting method makes no sense to
>>> be unspecified.
>>>
>>> Fixed. User can not clear the combo-boxes.
>>
>> - There don't seem to be any documentation updates.
>>>
>> The documents of SQL Editor and Preferences are updated.
>>
>>>
>>> - The CSV Quoting options appear to apply to copying from the grid, but
>>> they should apply to saving results as CSV.
>>>
>>> - The Result Copy quoting options (which should apply to copied data)
>>> are missing altogether.
>>>
>>> To be clear, there should be 6 new config options, 3 of which apply to
>>> data when copied from the grid, and the other 3 which apply when saving
>>> data as CSV. Please see the original RM case in which I detailed what the
>>> settings should be and what they should do.
>>>
>>
>> Provided 2 set of options (one set consists of 3 options);  one for CSV
>> output and another for Results grid.
>>
>>
>>>
>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

[Khushboo Vashi]

On 20 Nov 2017 19:45, "Dave Page"  wrote:

Though whilst it worked fine when I was testing, I now get the following.
Khushboo - can you investigate please?

Exception in thread Thread-96:

Traceback (most recent call last):

File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 810, in __bootstrap_inner

self.run()

File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 763, in run

self.__target(*self.__args, **self.__kwargs)

File "/System/Library/Frameworks/Python.framework/Versions/2.7/
lib/python2.7/SocketServer.py", line 602, in process_request_thread

self.handle_error(request, client_address)

File "/System/Library/Frameworks/Python.framework/Versions/2.7/
lib/python2.7/SocketServer.py", line 599, in process_request_thread

self.finish_request(request, client_address)

File "/System/Library/Frameworks/Python.framework/Versions/2.7/
lib/python2.7/SocketServer.py", line 334, in finish_request

self.RequestHandlerClass(request, client_address, self)

File "/System/Library/Frameworks/Python.framework/Versions/2.7/
lib/python2.7/SocketServer.py", line 655, in __init__

self.handle()

File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 200, in handle

rv = BaseHTTPRequestHandler.handle(self)

File "/System/Library/Frameworks/Python.framework/Versions/2.7/
lib/python2.7/BaseHTTPServer.py", line 340, in handle

self.handle_one_request()

File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 235, in handle_one_request

return self.run_wsgi()

File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 177, in run_wsgi

execute(self.server.app)

File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 167, in execute

for data in application_iter:

File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wsgi.py",
line 691, in __next__

return self._next()

File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
packages/werkzeug/wrappers.py", line 81, in _iter_encoded

for item in iterable:

File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py",
line 828, in gen

quotechar=quote_char

File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
line 670, in __init__

self.writer = writer(f, dialect, *args, **kwds)

File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
line 185, in __init__

raise TypeError(*e.args)

TypeError: "delimiter" must be string, not bytes

Please share your CSV Output settings.


On Mon, Nov 20, 2017 at 1:51 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Mon, Nov 20, 2017 at 5:18 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>>
>> On Thu, Nov 16, 2017 at 7:42 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch for RM #2781 : New option to set the
 quotation mark for copying to clipboard.

 This patch includes:

 - Provide options in preferences to control the CSV output which
 includes copy to clipboard and download as CSV features in Query Tool
 - Modified related jasmine tests
 - Modified related feature tests

>>>
>>> Thanks. At first glance, I see a few issues with this patch:
>>>
>>> - I can type into the combo boxes in the preferences, but only to
>>> search. That means (for example) that the only quote character I can use is
>>> ". I can't use anything else as a might want. The same applies to the field
>>> separator.
>>>
>>
>>>
>> Provided provision to add user defined field separator and quote
>> character.
>>
>> - I can click the x to clear the options in the combo boxes, but then the
>>> settings can be accepted and stored. For the separator and quote char, I
>>> assume they just become blank, however the quoting method makes no sense to
>>> be unspecified.
>>>
>>> Fixed. User can not clear the combo-boxes.
>>
>> - There don't seem to be any documentation updates.
>>>
>> The documents of SQL Editor and Preferences are updated.
>>
>>>
>>> - The CSV Quoting options appear to apply to copying from the grid, but
>>> they should apply to saving results as CSV.
>>>
>>> - The Result Copy quoting options (which should apply to copied data)
>>> are missing altogether.
>>>
>>> To be clear, there should be 6 new config options, 3 of which apply to
>>> data when copied from the grid, and the other 3 which apply when saving
>>> data as CSV. Please see the original RM case in which I detailed what the
>>> settings should be and what they should do.
>>>
>>
>> Provided 2 set of options (one set consists of 3 options);  one for CSV
>> output and another for Results grid.
>>
>>
>>>
>

Build failed in Jenkins: pgadmin4-master-python26 #512

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Fix support for time without timezone. Fixes #2881

[Dave Page] Allow configuration of CSV and clipboard formatting of query 
results.

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 0c566f132e19ab4476f570664647683f97361cb0 (origin/master)
Commit message: "Allow configuration of CSV and clipboard formatting of query 
results. Fixes #2781"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0c566f132e19ab4476f570664647683f97361cb0
 > git rev-list 5fd3a7dd3da1c108b12527ec29f4577c57b00eb2 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=2.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python26] $ /bin/sh -xe /tmp/jenkins9108033597715664562.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.6 virtual environment...

New python executable in 

Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/local/python-2.6/bin/python
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Collecting wheel==0.29.0
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. You can upgrade to a newer version of Python to solve 
this. For more information, see 
https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Using cached wheel-0.29.0-py2.py3-none-any.whl
Collecting argparse; python_version == "2.6" (from wheel==0.29.0)
  Using cached argparse-1.4.0-py2.py3-none-any.whl
Installing collected packages: argparse, wheel
Successfully installed argparse-1.4.0 wheel-0.29.0
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Ignoring Flask-HTMLmin: markers 'python_version >= "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
:122:
 InsecurePlatformWarni

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

[Dave Page]

Hi

On Mon, Nov 20, 2017 at 7:06 AM, Neel Patel 
wrote:

> Hi Dave,
>
> Ignore above debug patch.
>
> Can you please test this patch ? From the hang screen prospective, i have
> added how many bytes downloaded to message as browser so that user can know
> when download in progress with no total data.
>
> Let me know if you still face hang or other issue.
>

Oddly - that seems to be working. I'll commit it, but let's ensure Fahar
gives it a decent amount of testing.

Thanks!



>
> Thanks,
> Neel Patel
>
> On Fri, Nov 17, 2017 at 6:44 PM, Neel Patel 
> wrote:
>
>> Hi Dave,
>>
>> I have tried for 350K rows with query given by you but not able to
>> reproduce the hang issue.
>> I have put some debug statement in Qt Signal's handler. Can you please
>> apply this debug patch and provide me console output if possible ?
>>
>> Thanks,
>> Neel Patel
>>
>> On Fri, Nov 17, 2017 at 3:13 PM, Neel Patel 
>> wrote:
>>
>>> Hi Dave,
>>>
>>> On Fri, Nov 17, 2017 at 3:09 PM, Dave Page  wrote:
>>>


 On Fri, Nov 17, 2017 at 9:36 AM, Neel Patel <
 neel.pa...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Fri, Nov 17, 2017 at 2:42 PM, Dave Page  wrote:
>
>>
>>
>> On Fri, Nov 17, 2017 at 8:45 AM, Neel Patel <
>> neel.pa...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Thu, Nov 16, 2017 at 8:13 PM, Dave Page 
>>> wrote:
>>>
 Hi

 On Thu, Nov 16, 2017 at 1:47 PM, Neel Patel <
 neel.pa...@enterprisedb.com> wrote:

> Hi,
>
> Adding information.
>
> With this patch, RM#2715 should also be resolved.
>
> Thanks,
> Neel Patel
>
> On Thu, Nov 16, 2017 at 7:01 PM, Neel Patel <
> neel.pa...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> I am able to reproduce the crash while downloading and save data
>> in CSV file from query tool.
>>
>> Please find attached updated patch with below changes after
>> reading Qt documentation.
>>
>>- Added new signal "readyRead". As per the Qt documentation,
>>this signal will be emitted when data is ready from IO channel 
>> for large
>>amount of data transfer between server and client.
>>- Ready read and DownloadInProgress signal is very quick in
>>call so we should not do large operation inside that slot because 
>> for
>>downloading big data it may possible of frequent call of those 
>> signals
>>which may cause the crash or missing data to write inside the 
>> file so
>>removed unnecessary logic from that slot.
>>- Fixed the crash while opening IODevice with NULL handle.
>>
>> With above changes, I have tested with same data as earlier and
>> it is working as expected without crashing the application.
>>
>> Do review it and let me know for comments.
>>
>
 My first test was on Mac using Qt 5.8 with webkit, and when I
 attempted to download the results from a 300K row query, it basically 
 hung
 showing the Downloading File progress indicator. It let me cancel it 
 and
 carried on working, but hung again the next time I tried the CSV 
 download.
 Each time it seems to download some data - from the same query I've 
 seen
 2.8MB, 5.1MB and 1.5MB.

>>>
>>> We are using "*downloadProgress*"  signal to update the progress
>>> bar and here we are getting "readData" as bytes but "totalData" is 
>>> unknown
>>> so we received "totalData" as -1 because Qt doesn't know the total size 
>>> of
>>> the file we are getting from server but when we open "pgAdmin4" website 
>>> in
>>> another link and try to download some binary or source at that time we 
>>> are
>>> getting "totalData" as known size and we are displaying the progress bar
>>> correctly.
>>>
>>> Here, Qt sending the signal "downloadProgress" with unknown
>>> totalData size as -1 so we update the progress bar with 100% so from 
>>> user
>>> point of view it looks like hang but it is downloading and writing to 
>>> file
>>> at back ground. if we apply the same patch in windows then it display
>>> running progress bar so user can know something happening at back end 
>>> side.
>>>
>>> I think it is same as browser - if we download big size file from
>>> server then it keep on downloading the file without displaying total 
>>> size.
>>> What should we do here ? Should we create one custom progress bar dialog
>>> with moving cursor or something other so that user can know that 
>>> activity
>>> is doing at backend ? Thoughts ?
>>>
>>
>> It is misleading, but it *is* also hanging. 10+ minute

pgAdmin 4 commit: Ensure we can download large files and keep the user

[Dave Page]

Ensure we can download large files and keep the user informed about progress. 
Fixes #2829. Fixes #2491. Fixes #2715

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0
Author: Neel Patel 

Modified Files
--
runtime/BrowserWindow.cpp | 155 ++
runtime/BrowserWindow.h   |   3 +
2 files changed, 118 insertions(+), 40 deletions(-)

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

[Dave Page]

Hi

On Mon, Nov 20, 2017 at 1:10 PM, Neel Patel 
wrote:

> Hi,
>
> Please find attached patch to fix RM#2679.
>
> *Issue:-*
> Getting started links does not open second time from "Dashboard" panel if
> User close runtime tab and open any URL again.
>
> *Analysis:-*
> As in runtime Qt application, when user defined "target=_new" then
> "createWindow" signal is called but when user close that new windows and
> again click on link then "createWindow" signal is not getting called so
> from user point view nothing will happen.
>
> *Solution:-*
> To make it work in both runtime and web application, changed "target"
> attribute to "_blank" so that "createWindow" signal will be called every
> time when user click on any link.
>

I think this is a partial workaround for the problem. We link to external
sites such as postgresql.org - what happens if that tries to open something
with target="_new"? It should be expected to work as well. I think we need
to fix the underlying problem, not try to work around it.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python26 #513

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Ensure we can download large files and keep the user informed about

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0 (origin/master)
Commit message: "Ensure we can download large files and keep the user informed 
about progress. Fixes #2829. Fixes #2491. Fixes #2715"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0
 > git rev-list 0c566f132e19ab4476f570664647683f97361cb0 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=2.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python26] $ /bin/sh -xe /tmp/jenkins6146431656455613885.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.6 virtual environment...

New python executable in 

Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/local/python-2.6/bin/python
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Collecting wheel==0.29.0
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. You can upgrade to a newer version of Python to solve 
this. For more information, see 
https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Using cached wheel-0.29.0-py2.py3-none-any.whl
Collecting argparse; python_version == "2.6" (from wheel==0.29.0)
  Using cached argparse-1.4.0-py2.py3-none-any.whl
Installing collected packages: argparse, wheel
Successfully installed argparse-1.4.0 wheel-0.29.0
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Ignoring Flask-HTMLmin: markers 'python_version >= "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. You c

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

[Khushboo Vashi]

Hi Dave,

Please find the attached patch to fix the issue.
I have fixed the issue looking at the error you got as I can not reproduce
the issue on Python 2.7 or Python 3.5.

Thanks,
Khushboo



On Mon, Nov 20, 2017 at 8:05 PM, Dave Page  wrote:

>
>
> On Mon, Nov 20, 2017 at 2:20 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On 20 Nov 2017 19:45, "Dave Page"  wrote:
>>
>> Though whilst it worked fine when I was testing, I now get the following.
>> Khushboo - can you investigate please?
>>
>> Exception in thread Thread-96:
>>
>> Traceback (most recent call last):
>>
>> File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
>> line 810, in __bootstrap_inner
>>
>> self.run()
>>
>> File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
>> line 763, in run
>>
>> self.__target(*self.__args, **self.__kwargs)
>>
>> File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>> line 602, in process_request_thread
>>
>> self.handle_error(request, client_address)
>>
>> File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>> line 599, in process_request_thread
>>
>> self.finish_request(request, client_address)
>>
>> File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>> line 334, in finish_request
>>
>> self.RequestHandlerClass(request, client_address, self)
>>
>> File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>> line 655, in __init__
>>
>> self.handle()
>>
>> File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>> line 200, in handle
>>
>> rv = BaseHTTPRequestHandler.handle(self)
>>
>> File "/System/Library/Frameworks/Python.framework/Versions/2.7/li
>> b/python2.7/BaseHTTPServer.py", line 340, in handle
>>
>> self.handle_one_request()
>>
>> File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>> line 235, in handle_one_request
>>
>> return self.run_wsgi()
>>
>> File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>> line 177, in run_wsgi
>>
>> execute(self.server.app)
>>
>> File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>> line 167, in execute
>>
>> for data in application_iter:
>>
>> File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wsgi.py",
>> line 691, in __next__
>>
>> return self._next()
>>
>> File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wrappers.py",
>> line 81, in _iter_encoded
>>
>> for item in iterable:
>>
>> File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py",
>> line 828, in gen
>>
>> quotechar=quote_char
>>
>> File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
>> line 670, in __init__
>>
>> self.writer = writer(f, dialect, *args, **kwds)
>>
>> File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
>> line 185, in __init__
>>
>> raise TypeError(*e.args)
>>
>> TypeError: "delimiter" must be string, not bytes
>>
>> Please share your CSV Output settings.
>>
>
> Screenshot attached.
>
>
>
>>
>> On Mon, Nov 20, 2017 at 1:51 PM, Dave Page  wrote:
>>
>>> Thanks, applied.
>>>
>>> On Mon, Nov 20, 2017 at 5:18 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached updated patch.


 On Thu, Nov 16, 2017 at 7:42 PM, Dave Page  wrote:

> Hi
>
> On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch for RM #2781 : New option to set the
>> quotation mark for copying to clipboard.
>>
>> This patch includes:
>>
>> - Provide options in preferences to control the CSV output which
>> includes copy to clipboard and download as CSV features in Query Tool
>> - Modified related jasmine tests
>> - Modified related feature tests
>>
>
> Thanks. At first glance, I see a few issues with this patch:
>
> - I can type into the combo boxes in the preferences, but only to
> search. That means (for example) that the only quote character I can use 
> is
> ". I can't use anything else as a might want. The same applies to the 
> field
> separator.
>

>
 Provided provision to add user defined field separator and quote
 character.

 - I can click the x to clear the options in the combo boxes, but then
> the settings can be accepted and stored. For the separator and quote char,
> I assume they just become blank, however the quoting method makes no sense
> to be unspecified.
>
> Fixed. User can not clear the

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

[Dave Page]

Hi

Thanks, but I'm still getting the same error.

On Mon, Nov 20, 2017 at 3:23 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find the attached patch to fix the issue.
> I have fixed the issue looking at the error you got as I can not reproduce
> the issue on Python 2.7 or Python 3.5.
>
> Thanks,
> Khushboo
>
>
>
> On Mon, Nov 20, 2017 at 8:05 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 20, 2017 at 2:20 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On 20 Nov 2017 19:45, "Dave Page"  wrote:
>>>
>>> Though whilst it worked fine when I was testing, I now get the
>>> following. Khushboo - can you investigate please?
>>>
>>> Exception in thread Thread-96:
>>>
>>> Traceback (most recent call last):
>>>
>>> File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
>>> line 810, in __bootstrap_inner
>>>
>>> self.run()
>>>
>>> File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
>>> line 763, in run
>>>
>>> self.__target(*self.__args, **self.__kwargs)
>>>
>>> File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>>> line 602, in process_request_thread
>>>
>>> self.handle_error(request, client_address)
>>>
>>> File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>>> line 599, in process_request_thread
>>>
>>> self.finish_request(request, client_address)
>>>
>>> File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>>> line 334, in finish_request
>>>
>>> self.RequestHandlerClass(request, client_address, self)
>>>
>>> File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>>> line 655, in __init__
>>>
>>> self.handle()
>>>
>>> File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 200, in handle
>>>
>>> rv = BaseHTTPRequestHandler.handle(self)
>>>
>>> File "/System/Library/Frameworks/Python.framework/Versions/2.7/li
>>> b/python2.7/BaseHTTPServer.py", line 340, in handle
>>>
>>> self.handle_one_request()
>>>
>>> File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 235, in handle_one_request
>>>
>>> return self.run_wsgi()
>>>
>>> File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 177, in run_wsgi
>>>
>>> execute(self.server.app)
>>>
>>> File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 167, in execute
>>>
>>> for data in application_iter:
>>>
>>> File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wsgi.py",
>>> line 691, in __next__
>>>
>>> return self._next()
>>>
>>> File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wrappers.py",
>>> line 81, in _iter_encoded
>>>
>>> for item in iterable:
>>>
>>> File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py",
>>> line 828, in gen
>>>
>>> quotechar=quote_char
>>>
>>> File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
>>> line 670, in __init__
>>>
>>> self.writer = writer(f, dialect, *args, **kwds)
>>>
>>> File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
>>> line 185, in __init__
>>>
>>> raise TypeError(*e.args)
>>>
>>> TypeError: "delimiter" must be string, not bytes
>>>
>>> Please share your CSV Output settings.
>>>
>>
>> Screenshot attached.
>>
>>
>>
>>>
>>> On Mon, Nov 20, 2017 at 1:51 PM, Dave Page  wrote:
>>>
 Thanks, applied.

 On Mon, Nov 20, 2017 at 5:18 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached updated patch.
>
>
> On Thu, Nov 16, 2017 at 7:42 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for RM #2781 : New option to set the
>>> quotation mark for copying to clipboard.
>>>
>>> This patch includes:
>>>
>>> - Provide options in preferences to control the CSV output which
>>> includes copy to clipboard and download as CSV features in Query Tool
>>> - Modified related jasmine tests
>>> - Modified related feature tests
>>>
>>
>> Thanks. At first glance, I see a few issues with this patch:
>>
>> - I can type into the combo boxes in the preferences, but only to
>> search. That means (for example) that the only quote character I can use 
>> is
>> ". I can't use anything else as a might want. The same applies to the 
>> field
>> separator.
>>
>
>>
> Provided provision to add user defined field separator and quo

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

[Khushboo Vashi]

Hi Dave,

Please find the attached patch.

Thanks,
Khushboo

On Mon, Nov 20, 2017 at 8:59 PM, Dave Page  wrote:

> Hi
>
> Thanks, but I'm still getting the same error.
>
>
On Mon, Nov 20, 2017 at 3:23 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find the attached patch to fix the issue.
>> I have fixed the issue looking at the error you got as I can not
>> reproduce the issue on Python 2.7 or Python 3.5.
>>
>> Thanks,
>> Khushboo
>>
>>
>>
>> On Mon, Nov 20, 2017 at 8:05 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Nov 20, 2017 at 2:20 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On 20 Nov 2017 19:45, "Dave Page"  wrote:

 Though whilst it worked fine when I was testing, I now get the
 following. Khushboo - can you investigate please?

 Exception in thread Thread-96:

 Traceback (most recent call last):

 File 
 "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
 line 810, in __bootstrap_inner

 self.run()

 File 
 "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
 line 763, in run

 self.__target(*self.__args, **self.__kwargs)

 File 
 "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
 line 602, in process_request_thread

 self.handle_error(request, client_address)

 File 
 "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
 line 599, in process_request_thread

 self.finish_request(request, client_address)

 File 
 "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
 line 334, in finish_request

 self.RequestHandlerClass(request, client_address, self)

 File 
 "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
 line 655, in __init__

 self.handle()

 File 
 "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
 line 200, in handle

 rv = BaseHTTPRequestHandler.handle(self)

 File "/System/Library/Frameworks/Python.framework/Versions/2.7/li
 b/python2.7/BaseHTTPServer.py", line 340, in handle

 self.handle_one_request()

 File 
 "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
 line 235, in handle_one_request

 return self.run_wsgi()

 File 
 "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
 line 177, in run_wsgi

 execute(self.server.app)

 File 
 "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
 line 167, in execute

 for data in application_iter:

 File 
 "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wsgi.py",
 line 691, in __next__

 return self._next()

 File 
 "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wrappers.py",
 line 81, in _iter_encoded

 for item in iterable:

 File 
 "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py",
 line 828, in gen

 quotechar=quote_char

 File 
 "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
 line 670, in __init__

 self.writer = writer(f, dialect, *args, **kwds)

 File 
 "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
 line 185, in __init__

 raise TypeError(*e.args)

 TypeError: "delimiter" must be string, not bytes

 Please share your CSV Output settings.

>>>
>>> Screenshot attached.
>>>
>>>
>>>

 On Mon, Nov 20, 2017 at 1:51 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Mon, Nov 20, 2017 at 5:18 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>>
>> On Thu, Nov 16, 2017 at 7:42 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch for RM #2781 : New option to set the
 quotation mark for copying to clipboard.

 This patch includes:

 - Provide options in preferences to control the CSV output which
 includes copy to clipboard and download as CSV features in Query Tool
 - Modified related jasmine tests
 - Modified related feature tests

>>>
>>> Thanks. At first glance, I see a few issues with this patch:
>>>
>>> - I can type into the combo boxes in the preferences, but onl

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

[Dave Page]

I still see the same error I'm afraid. I played around in another system,
and if I set the delimiter to "xx", then it crashes with:

Exception in thread Thread-675:
Traceback (most recent call last):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 810, in __bootstrap_inner
self.run()
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 763, in run
self.__target(*self.__args, **self.__kwargs)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 602, in process_request_thread
self.handle_error(request, client_address)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 599, in process_request_thread
self.finish_request(request, client_address)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 334, in finish_request
self.RequestHandlerClass(request, client_address, self)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 655, in __init__
self.handle()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 200, in handle
rv = BaseHTTPRequestHandler.handle(self)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/BaseHTTPServer.py",
line 340, in handle
self.handle_one_request()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 235, in handle_one_request
return self.run_wsgi()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 177, in run_wsgi
execute(self.server.app)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 167, in execute
for data in application_iter:
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wsgi.py",
line 691, in __next__
return self._next()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wrappers.py",
line 81, in _iter_encoded
for item in iterable:
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py",
line 842, in gen
quotechar=quote_char
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
line 670, in __init__
self.writer = writer(f, dialect, *args, **kwds)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/backports/csv.py",
line 185, in __init__
raise TypeError(*e.args)
TypeError: "delimiter" must be a 1-character string


On Mon, Nov 20, 2017 at 4:09 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find the attached patch.
>
> Thanks,
> Khushboo
>
>
> On Mon, Nov 20, 2017 at 8:59 PM, Dave Page  wrote:
>
>> Hi
>>
>> Thanks, but I'm still getting the same error.
>>
>>
> On Mon, Nov 20, 2017 at 3:23 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find the attached patch to fix the issue.
>>> I have fixed the issue looking at the error you got as I can not
>>> reproduce the issue on Python 2.7 or Python 3.5.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>>
>>> On Mon, Nov 20, 2017 at 8:05 PM, Dave Page  wrote:
>>>


 On Mon, Nov 20, 2017 at 2:20 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On 20 Nov 2017 19:45, "Dave Page"  wrote:
>
> Though whilst it worked fine when I was testing, I now get the
> following. Khushboo - can you investigate please?
>
> Exception in thread Thread-96:
>
> Traceback (most recent call last):
>
> File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
> line 810, in __bootstrap_inner
>
> self.run()
>
> File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
> line 763, in run
>
> self.__target(*self.__args, **self.__kwargs)
>
> File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
> line 602, in process_request_thread
>
> self.handle_error(request, client_address)
>
> File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
> line 599, in process_request_thread
>
> self.finish_request(request, client_address)
>
> File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
> line 334, in finish_request
>
> self.RequestHandlerClass(request, client_address, self)
>
> File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
> line 655, in __init__
>
> self.handle()
>
> File 
> "/Users/dpage/.virtualenvs/pgadmin4

pgAdmin 4 commit: Decode the field separator and quote char if needed.

[Dave Page]

Decode the field separator and quote char if needed.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4568fe22f7e50cc9e782839c3ca35607d651b4b3
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 12 
1 file changed, 12 insertions(+)

pgAdmin 4 commit: Prevent the Windows installer accepting paths contain

[Dave Page]

Prevent the Windows installer accepting paths containing invalid characters. 
Fixes #1365

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ff753deb8cd49fde8fea25b9b676a45461ba7e9
Author: Paresh More 

Modified Files
--
Make-MinGW.bat |  25 +++--
pkg/win32/README.txt   |   2 +-
pkg/win32/installer.iss.in | 129 ++---
3 files changed, 122 insertions(+), 34 deletions(-)

Re: [Patch]: Installer: pgAdmin4 should not install in special character path

[Dave Page]

Thanks, applied with minor changes to the default paths (to make them match
my machine, which uses all default paths).

On Fri, Nov 17, 2017 at 12:17 PM, Paresh More 
wrote:

> Hello Team,
>
> I have made three changes for installer generation scripts.
>
> 1) Modified Make-MinGW.bat to support yarn and nodejs validation in the
> script and also QT 5.9.1 support.
>
> 2) Bug fix for RM1365.
> Currently string datatypes used in Inno tool does not support regular
> expression, so added a user function which will do path validation and it
> would be work fine for inno unicode setup.
>
> 3) Restructured  installer script so that it should support unicode inno
> and for RM1365 as well i.e Inno Setup Installer(unicode) also updated
> README file for the same.
>
>
> Please note - Installer path validation is invoked two times
>
> 1) Inno tool internally validate's path which user program do not have
> access to it , so section [MESSAGE] error string message will be used to
> show error message string.
>
> 2) From the code section, so section [CustomMessages] error message will
> be used.
>
> For both (1) and (2) common error message will be used.
>
>
> Attached is the patch
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> www.enterprisedb.com
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Build failed in Jenkins: pgadmin4-master-python26 #510

[Murtuza Zabuawala]

Hi Dave,

PFA patch to fix the issue.

We will use the newer of selenium only if python 2.7 or greater else use
the older version.
Please note that older version of selenium & web driver will not work with
latest versions (>= Chrome 61.x)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Nov 16, 2017 at 8:47 PM, pgAdmin 4 Jenkins 
wrote:

> See  510/display/redirect?page=changes>
>
> Changes:
>
> [Dave Page] Update selenium version
>
> --
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> [EnvInject] - Loading node environment variables.
> Building in workspace  job/pgadmin4-master-python26/ws/>
>  > git rev-parse --is-inside-work-tree # timeout=10
> Fetching changes from the remote Git repository
>  > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git
> # timeout=10
> Cleaning workspace
>  > git rev-parse --verify HEAD # timeout=10
> Resetting working tree
>  > git reset --hard # timeout=10
>  > git clean -fdx # timeout=10
> Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
>  > git --version # timeout=10
>  > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git
> +refs/heads/*:refs/remotes/origin/*
>  > git rev-parse origin/master^{commit} # timeout=10
> Checking out Revision 2f17ecba760dcb210b6bf70b259860dd569a7888
> (origin/master)
> Commit message: "Update selenium version"
>  > git config core.sparsecheckout # timeout=10
>  > git checkout -f 2f17ecba760dcb210b6bf70b259860dd569a7888
>  > git rev-list 051788d040049682cbde78c4bb5343f92b4eb5a2 # timeout=10
> [EnvInject] - Executing scripts and injecting environment variables after
> the SCM step.
> [EnvInject] - Injecting as environment variables the properties content
> PYTHON_VERSION=2.6
>
> [EnvInject] - Variables injected successfully.
> [pgadmin4-master-python26] $ /bin/sh -xe /tmp/
> jenkins8163038226280116557.sh
> +  ws/ci/ci_runner.sh>
> EXECUTING: Create pgAdmin config
>
> EXECUTING: Python tests
>
> Creating Python 2.6 virtual environment...
>
> New python executable in  job/pgadmin4-master-python26/ws/pgadmin-venv/bin/python>
> Installing setuptools, pip...done.
> Running virtualenv with interpreter /usr/local/python-2.6/bin/python
> DEPRECATION: Python 2.6 is no longer supported by the Python core team,
> please upgrade your Python. A future version of pip will drop support for
> Python 2.6
> Collecting wheel==0.29.0
>  ws/pgadmin-venv/lib/python2.6/site-packages/pip/_vendor/
> requests/packages/urllib3/util/ssl_.py>:318: SNIMissingWarning: An HTTPS
> request has been made, but the SNI (Subject Name Indication) extension to
> TLS is not available on this platform. This may cause the server to present
> an incorrect TLS certificate, which can cause validation failures. You can
> upgrade to a newer version of Python to solve this. For more information,
> see https://urllib3.readthedocs.io/en/latest/security.html#
> snimissingwarning.
>   SNIMissingWarning
>  ws/pgadmin-venv/lib/python2.6/site-packages/pip/_vendor/
> requests/packages/urllib3/util/ssl_.py>:122: InsecurePlatformWarning: A
> true SSLContext object is not available. This prevents urllib3 from
> configuring SSL appropriately and may cause certain SSL connections to
> fail. You can upgrade to a newer version of Python to solve this. For more
> information, see https://urllib3.readthedocs.io/en/latest/security.html#
> insecureplatformwarning.
>   InsecurePlatformWarning
>   Using cached wheel-0.29.0-py2.py3-none-any.whl
> Collecting argparse; python_version == "2.6" (from wheel==0.29.0)
>   Using cached argparse-1.4.0-py2.py3-none-any.whl
> Installing collected packages: argparse, wheel
> Successfully installed argparse-1.4.0 wheel-0.29.0
> DEPRECATION: Python 2.6 is no longer supported by the Python core team,
> please upgrade your Python. A future version of pip will drop support for
> Python 2.6
> Ignoring Flask-HTMLmin: markers 'python_version >= "2.7"' don't match your
> environment
> Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
>  ws/pgadmin-venv/lib/python2.6/site-packages/pip/_vendor/
> requests/packages/urllib3/util/ssl_.py>:318: SNIMissingWarning: An HTTPS
> request has been made, but the SNI (Subject Name Indication) extension to
> TLS is not available on this platform. This may cause the server to present
> an incorrect TL

Build failed in Jenkins: pgadmin4-master-python26 #514

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Decode the field separator and quote char if needed.

[Dave Page] Prevent the Windows installer accepting paths containing invalid

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 8ff753deb8cd49fde8fea25b9b676a45461ba7e9 (origin/master)
Commit message: "Prevent the Windows installer accepting paths containing 
invalid characters. Fixes #1365"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 8ff753deb8cd49fde8fea25b9b676a45461ba7e9
 > git rev-list 8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=2.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python26] $ /bin/sh -xe /tmp/jenkins4846113357823745762.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.6 virtual environment...

New python executable in 

Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/local/python-2.6/bin/python
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Collecting wheel==0.29.0
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. You can upgrade to a newer version of Python to solve 
this. For more information, see 
https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Using cached wheel-0.29.0-py2.py3-none-any.whl
Collecting argparse; python_version == "2.6" (from wheel==0.29.0)
  Using cached argparse-1.4.0-py2.py3-none-any.whl
Installing collected packages: argparse, wheel
Successfully installed argparse-1.4.0 wheel-0.29.0
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Ignoring Flask-HTMLmin: markers 'python_version >= "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to 

Re: Build failed in Jenkins: pgadmin4-master-python26 #510

[Dave Page]

Thanks, applied.

On Mon, Nov 20, 2017 at 4:41 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA patch to fix the issue.
>
> We will use the newer of selenium only if python 2.7 or greater else use
> the older version.
> Please note that older version of selenium & web driver will not work with
> latest versions (>= Chrome 61.x)
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Nov 16, 2017 at 8:47 PM, pgAdmin 4 Jenkins 
> wrote:
>
>> See > 0/display/redirect?page=changes>
>>
>> Changes:
>>
>> [Dave Page] Update selenium version
>>
>> --
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> [EnvInject] - Loading node environment variables.
>> Building in workspace > ob/pgadmin4-master-python26/ws/>
>>  > git rev-parse --is-inside-work-tree # timeout=10
>> Fetching changes from the remote Git repository
>>  > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git
>> # timeout=10
>> Cleaning workspace
>>  > git rev-parse --verify HEAD # timeout=10
>> Resetting working tree
>>  > git reset --hard # timeout=10
>>  > git clean -fdx # timeout=10
>> Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
>>  > git --version # timeout=10
>>  > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git
>> +refs/heads/*:refs/remotes/origin/*
>>  > git rev-parse origin/master^{commit} # timeout=10
>> Checking out Revision 2f17ecba760dcb210b6bf70b259860dd569a7888
>> (origin/master)
>> Commit message: "Update selenium version"
>>  > git config core.sparsecheckout # timeout=10
>>  > git checkout -f 2f17ecba760dcb210b6bf70b259860dd569a7888
>>  > git rev-list 051788d040049682cbde78c4bb5343f92b4eb5a2 # timeout=10
>> [EnvInject] - Executing scripts and injecting environment variables after
>> the SCM step.
>> [EnvInject] - Injecting as environment variables the properties content
>> PYTHON_VERSION=2.6
>>
>> [EnvInject] - Variables injected successfully.
>> [pgadmin4-master-python26] $ /bin/sh -xe /tmp/jenkins816303822628011655
>> 7.sh
>> + > /ci/ci_runner.sh>
>> EXECUTING: Create pgAdmin config
>>
>> EXECUTING: Python tests
>>
>> Creating Python 2.6 virtual environment...
>>
>> New python executable in > ob/pgadmin4-master-python26/ws/pgadmin-venv/bin/python>
>> Installing setuptools, pip...done.
>> Running virtualenv with interpreter /usr/local/python-2.6/bin/python
>> DEPRECATION: Python 2.6 is no longer supported by the Python core team,
>> please upgrade your Python. A future version of pip will drop support for
>> Python 2.6
>> Collecting wheel==0.29.0
>> > /pgadmin-venv/lib/python2.6/site-packages/pip/_vendor/reques
>> ts/packages/urllib3/util/ssl_.py>:318: SNIMissingWarning: An HTTPS
>> request has been made, but the SNI (Subject Name Indication) extension to
>> TLS is not available on this platform. This may cause the server to present
>> an incorrect TLS certificate, which can cause validation failures. You can
>> upgrade to a newer version of Python to solve this. For more information,
>> see https://urllib3.readthedocs.io/en/latest/security.html#snimi
>> ssingwarning.
>>   SNIMissingWarning
>> > /pgadmin-venv/lib/python2.6/site-packages/pip/_vendor/reques
>> ts/packages/urllib3/util/ssl_.py>:122: InsecurePlatformWarning: A true
>> SSLContext object is not available. This prevents urllib3 from configuring
>> SSL appropriately and may cause certain SSL connections to fail. You can
>> upgrade to a newer version of Python to solve this. For more information,
>> see https://urllib3.readthedocs.io/en/latest/security.html#insec
>> ureplatformwarning.
>>   InsecurePlatformWarning
>>   Using cached wheel-0.29.0-py2.py3-none-any.whl
>> Collecting argparse; python_version == "2.6" (from wheel==0.29.0)
>>   Using cached argparse-1.4.0-py2.py3-none-any.whl
>> Installing collected packages: argparse, wheel
>> Successfully installed argparse-1.4.0 wheel-0.29.0
>> DEPRECATION: Python 2.6 is no longer supported by the Python core team,
>> please upgrade your Python. A future version of pip will drop support for
>> Python 2.6
>> Ignoring Flask-HTMLmin: markers 'python_version >= "2.7"' don't match
>> your environment
>> Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
>> > /pgadmin-venv/lib/python2.6/site-packages/pip/_vendor/req

pgAdmin 4 commit: Stop Python 2.6 barfing on newer versions of Selenium

[Dave Page]

Stop Python 2.6 barfing on newer versions of Selenium

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce246ecce40fd97810c2120c10029ff328e66bc8
Author: Murtuza Zabuawala 

Modified Files
--
web/regression/requirements.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Fix /NOICONS switch in the windows installer. Fixes #

[Dave Page]

Fix /NOICONS switch in the windows installer. Fixes #1366

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a539147a0e8b4b8852289909b2bcb268d7908887
Author: Paresh More 

Modified Files
--
pkg/win32/installer.iss.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Re: [pgAdmin4][Patch]: RM#1366 - NOICONS switch for windows installer.

[Dave Page]

Thanks, patch applied.

On Sun, Nov 19, 2017 at 3:20 PM, Paresh More 
wrote:

> Hi,
>
> This is regarding patch for RM#1366:  Installer: pgadmin4-1.0-beta1.exe
> /NOICONS switch issue
>
> This patch includes:
> - It would work for both normal and commandline mode when NOICONS argument
> is passed.
>
> In Normal mode
> Don't create a Start Menu folder option checkbox will be uncheck by
> default. i.e Start Menu folder would be created by default.
>
> In commandline when NOICONS is passed
> Don't create a Start Menu folder option checkbox will be checked by
> default.
> i.e Start Menu folder will not be created by default.
>
> Please Note : As per documentation of Inno tool.
>
> */NOICONS*
>
> Instructs Setup to initially check the *Don't create a Start Menu folder* 
> check
> box on the *Select Start Menu Folder* wizard page.
>
> User still have a option at runtime whether he want to create or not
> create Start Menu folder on runtime. NOICONS will just uncheck the checkbox.
>
>
> Attached is the patch.
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> www.enterprisedb.com
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python34 #376

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Decode the field separator and quote char if needed.

[Dave Page] Prevent the Windows installer accepting paths containing invalid

[Dave Page] Stop Python 2.6 barfing on newer versions of Selenium

[Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887 (origin/master)
Commit message: "Fix /NOICONS switch in the windows installer. Fixes #1366"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
 > git rev-list 8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.4

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python34] $ /bin/sh -xe /tmp/jenkins5396335926824677164.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.4 virtual environment...

Using base prefix '/usr/local/python-3.4'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.4/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp34-cp34m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (f

Build failed in Jenkins: pgadmin4-master-python36 #384

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Decode the field separator and quote char if needed.

[Dave Page] Prevent the Windows installer accepting paths containing invalid

[Dave Page] Stop Python 2.6 barfing on newer versions of Selenium

[Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887 (origin/master)
Commit message: "Fix /NOICONS switch in the windows installer. Fixes #1366"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
 > git rev-list 8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python36] $ /bin/sh -xe /tmp/jenkins7804536988332687079.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.6 virtual environment...

Using base prefix '/usr/local/python-3.6'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.6/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp36-cp36m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (f

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

[Dave Page]

Hi

On Mon, Nov 20, 2017 at 4:19 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA updated patch.
>

OK, that's looking better. I just found a couple of smaller issue this time:

- Why can't I select a foreground colour unless I select a non-white
background? That seems inconvenient and unnecessary

- If I set a foreground and background colour, and then later set the
background to a new colour and the foreground to "no colour", the
background change takes effect immediately, but the foreground change
requires a refresh (changing to a different foreground colour seems to work
fine though).



>
> On Mon, Nov 20, 2017 at 6:48 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Fri, Nov 17, 2017 at 9:30 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> PFA updated patch.
>>>
>>> On Thu, Nov 16, 2017 at 6:34 PM, Dave Page  wrote:
>>>
 Hi

 Looks good. A few changes/suggestions:

 - There seem to be some debugger calls left in the code, e.g. in
 editors.js

>>> ​Fixed
>>>
 - Instead of bgcolor and font_color, lets use bgcolor and fgcolor
 (foreground).

>>> ​Fixed​
>>>
>>>
 - The docs are (technically) en_US, so we should use color not colour
 in them.

>>> ​Fixed​
>>>
>>>
 - If the colours have been set for a server, I think we should also
 colour the title bar in the query tool. The only possible problem there is
 that the current default colours are reversed in comparison to the treeview
 (e.g. the treeview defaults to black text, whilst the query tool title bar
 is white on blue. Not sure if that is really an issue or not.

>>> What do you think?

>>> ​I have added logic to set the background & foreground colour in query
>>> tool & datagrid title bar.
>>> - Default title bar colours, b
>>> ackground
>>> ​: blue
>>> foreground
>>> ​: white
>>>  [
>>> ​w​
>>> hat we have right now]
>>> - When user has custom background colour for the server​,
>>> b
>>> ackground
>>> ​: <
>>> custom background colour
>>> >
>>> foreground
>>> ​: black
>>> - When user has custom background colour as well as foreground colour
>>> for the server​,
>>> b
>>> ackground
>>> ​: <
>>> custom background colour
>>> >
>>> foreground
>>> ​:
>>> <
>>> custom
>>> ​foreground
>>>  colour
>>> >
>>>
>>
>> I think this looks good now for the most part, except:
>>
>> - The default colours for the title bar on the query tool seem to be
>> black on white. See the first screenshot.
>>
> ​Fixed​
>
>
>>
>> - If I just set the foreground colour for a connection, it only shows up
>> in the query tool title, not on the treeview (and the query tool title has
>> a white background (which does seem reasonable, as the treeview would as
>> well). See the second screenshot.
>>
> ​Fixed.​
>
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add missing semicolons.

[Dave Page]

Add missing semicolons.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be8d3604fbc3cc53bf088fd06873fdfe14fc6545

Modified Files
--
web/regression/requirements.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Re: Build failed in Jenkins: pgadmin4-master-python34 #376

[Murtuza Zabuawala]

Oops, Misplaced semi colon.

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Nov 20, 2017 at 10:32 PM, pgAdmin 4 Jenkins 
wrote:

> See  376/display/redirect?page=changes>
>
> Changes:
>
> [Dave Page] Decode the field separator and quote char if needed.
>
> [Dave Page] Prevent the Windows installer accepting paths containing
> invalid
>
> [Dave Page] Stop Python 2.6 barfing on newer versions of Selenium
>
> [Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366
>
> --
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> [EnvInject] - Loading node environment variables.
> Building in workspace  job/pgadmin4-master-python34/ws/>
>  > git rev-parse --is-inside-work-tree # timeout=10
> Fetching changes from the remote Git repository
>  > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git
> # timeout=10
> Cleaning workspace
>  > git rev-parse --verify HEAD # timeout=10
> Resetting working tree
>  > git reset --hard # timeout=10
>  > git clean -fdx # timeout=10
> Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
>  > git --version # timeout=10
>  > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git
> +refs/heads/*:refs/remotes/origin/*
>  > git rev-parse origin/master^{commit} # timeout=10
> Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887
> (origin/master)
> Commit message: "Fix /NOICONS switch in the windows installer. Fixes #1366"
>  > git config core.sparsecheckout # timeout=10
>  > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
>  > git rev-list 8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0 # timeout=10
> [EnvInject] - Executing scripts and injecting environment variables after
> the SCM step.
> [EnvInject] - Injecting as environment variables the properties content
> PYTHON_VERSION=3.4
>
> [EnvInject] - Variables injected successfully.
> [pgadmin4-master-python34] $ /bin/sh -xe /tmp/
> jenkins5396335926824677164.sh
> +  ws/ci/ci_runner.sh>
> EXECUTING: Create pgAdmin config
>
> EXECUTING: Python tests
>
> Creating Python 3.4 virtual environment...
>
> Using base prefix '/usr/local/python-3.4'
> New python executable in  job/pgadmin4-master-python34/ws/pgadmin-venv/bin/python3>
> Also creating executable in  job/pgadmin4-master-python34/ws/pgadmin-venv/bin/python>
> Installing setuptools, pip, wheel...done.
> Running virtualenv with interpreter /usr/local/python-3.4/bin/python3
> Ignoring importlib: markers 'python_version <= "2.7"' don't match your
> environment
> Ignoring ordereddict: markers 'python_version < "2.7"' don't match your
> environment
> Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your
> environment
> Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your
> environment
> Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
>   Using cached Babel-2.3.4-py2.py3-none-any.whl
> Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
>   Using cached beautifulsoup4-4.4.1-py3-none-any.whl
> Collecting blinker==1.3 (from -r requirements.txt (line 6))
> Collecting click==6.6 (from -r requirements.txt (line 7))
>   Using cached click-6.6-py2.py3-none-any.whl
> Collecting extras==0.0.3 (from -r requirements.txt (line 8))
> Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
>   Using cached fixtures-2.0.0-py2.py3-none-any.whl
> Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
>   Using cached Flask-0.11.1-py2.py3-none-any.whl
> Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
> Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
>   Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
> Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
> Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
> Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
> Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
> Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
> Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
> Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
> Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
> Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
> Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
> Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
> Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
>   Using cached linecache2-1.0.0-py2.py3-none

Re: Build failed in Jenkins: pgadmin4-master-python34 #376

[Dave Page]

Hah - committed the fix 2 minutes before I got this :-)

On Mon, Nov 20, 2017 at 5:13 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Oops, Misplaced semi colon.
>
> PFA updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Mon, Nov 20, 2017 at 10:32 PM, pgAdmin 4 Jenkins 
> wrote:
>
>> See > 6/display/redirect?page=changes>
>>
>> Changes:
>>
>> [Dave Page] Decode the field separator and quote char if needed.
>>
>> [Dave Page] Prevent the Windows installer accepting paths containing
>> invalid
>>
>> [Dave Page] Stop Python 2.6 barfing on newer versions of Selenium
>>
>> [Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366
>>
>> --
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> [EnvInject] - Loading node environment variables.
>> Building in workspace > ob/pgadmin4-master-python34/ws/>
>>  > git rev-parse --is-inside-work-tree # timeout=10
>> Fetching changes from the remote Git repository
>>  > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git
>> # timeout=10
>> Cleaning workspace
>>  > git rev-parse --verify HEAD # timeout=10
>> Resetting working tree
>>  > git reset --hard # timeout=10
>>  > git clean -fdx # timeout=10
>> Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
>>  > git --version # timeout=10
>>  > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git
>> +refs/heads/*:refs/remotes/origin/*
>>  > git rev-parse origin/master^{commit} # timeout=10
>> Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887
>> (origin/master)
>> Commit message: "Fix /NOICONS switch in the windows installer. Fixes
>> #1366"
>>  > git config core.sparsecheckout # timeout=10
>>  > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
>>  > git rev-list 8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0 # timeout=10
>> [EnvInject] - Executing scripts and injecting environment variables after
>> the SCM step.
>> [EnvInject] - Injecting as environment variables the properties content
>> PYTHON_VERSION=3.4
>>
>> [EnvInject] - Variables injected successfully.
>> [pgadmin4-master-python34] $ /bin/sh -xe /tmp/jenkins539633592682467716
>> 4.sh
>> + > /ci/ci_runner.sh>
>> EXECUTING: Create pgAdmin config
>>
>> EXECUTING: Python tests
>>
>> Creating Python 3.4 virtual environment...
>>
>> Using base prefix '/usr/local/python-3.4'
>> New python executable in > ob/pgadmin4-master-python34/ws/pgadmin-venv/bin/python3>
>> Also creating executable in > ob/pgadmin4-master-python34/ws/pgadmin-venv/bin/python>
>> Installing setuptools, pip, wheel...done.
>> Running virtualenv with interpreter /usr/local/python-3.4/bin/python3
>> Ignoring importlib: markers 'python_version <= "2.7"' don't match your
>> environment
>> Ignoring ordereddict: markers 'python_version < "2.7"' don't match your
>> environment
>> Ignoring backports.csv: markers 'python_version <= "2.7"' don't match
>> your environment
>> Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your
>> environment
>> Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
>>   Using cached Babel-2.3.4-py2.py3-none-any.whl
>> Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
>>   Using cached beautifulsoup4-4.4.1-py3-none-any.whl
>> Collecting blinker==1.3 (from -r requirements.txt (line 6))
>> Collecting click==6.6 (from -r requirements.txt (line 7))
>>   Using cached click-6.6-py2.py3-none-any.whl
>> Collecting extras==0.0.3 (from -r requirements.txt (line 8))
>> Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
>>   Using cached fixtures-2.0.0-py2.py3-none-any.whl
>> Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
>>   Using cached Flask-0.11.1-py2.py3-none-any.whl
>> Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
>> Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
>>   Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
>> Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
>> Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
>> Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
>> Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
>> Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
>> Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
>> Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
>> Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
>> Collecting html5lib==1.0b3 (from

pgAdmin 4 commit: And remove the extra semicolons. Sigh.

[Dave Page]

And remove the extra semicolons. Sigh.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=182369cbab90ab7f7fe651609afa19238e8b7d73

Modified Files
--
web/regression/requirements.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python36 #385

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Add missing semicolons.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision be8d3604fbc3cc53bf088fd06873fdfe14fc6545 (origin/master)
Commit message: "Add missing semicolons."
 > git config core.sparsecheckout # timeout=10
 > git checkout -f be8d3604fbc3cc53bf088fd06873fdfe14fc6545
 > git rev-list a539147a0e8b4b8852289909b2bcb268d7908887 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python36] $ /bin/sh -xe /tmp/jenkins1168479360705191836.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.6 virtual environment...

Using base prefix '/usr/local/python-3.6'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.6/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp36-cp36m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (from -r requirements.txt (line 31))
Collecting pyrsistent==0.11.13 (from -r requirements.txt (line 32))
Collecting python-dateutil==2.5.0 (from -r requirements.txt (line 33))
  Using cached python_dateutil-2.5.0-py2.py3-none-any.whl
Collecting python-mimeparse==1.5.1 (from -r requirements.txt (line 34))
Collecting pytz==2014.10 (from -r requirements.txt (line 35))
  Using cached pytz-2014.10-py2.py3-no

Jenkins build is back to normal : pgadmin4-master-python27 #387

[pgAdmin 4 Jenkins]

See 

Build failed in Jenkins: pgadmin4-master-python34 #377

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Add missing semicolons.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision be8d3604fbc3cc53bf088fd06873fdfe14fc6545 (origin/master)
Commit message: "Add missing semicolons."
 > git config core.sparsecheckout # timeout=10
 > git checkout -f be8d3604fbc3cc53bf088fd06873fdfe14fc6545
 > git rev-list a539147a0e8b4b8852289909b2bcb268d7908887 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.4

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python34] $ /bin/sh -xe /tmp/jenkins3023983380823269078.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.4 virtual environment...

Using base prefix '/usr/local/python-3.4'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.4/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp34-cp34m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (from -r requirements.txt (line 31))
Collecting pyrsistent==0.11.13 (from -r requirements.txt (line 32))
Collecting python-dateutil==2.5.0 (from -r requirements.txt (line 33))
  Using cached python_dateutil-2.5.0-py2.py3-none-any.whl
Collecting python-mimeparse==1.5.1 (from -r requirements.txt (line 34))
Collecting pytz==2014.10 (from -r requirements.txt (line 35))
  Using cached pytz-2014.10-py2.py3-no

Jenkins build is back to normal : pgadmin4-master-python26 #516

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python33 #387

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python36 #386

[pgAdmin 4 Jenkins]

See 

Build failed in Jenkins: pgadmin4-master-python35 #385

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Add missing semicolons.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision be8d3604fbc3cc53bf088fd06873fdfe14fc6545 (origin/master)
Commit message: "Add missing semicolons."
 > git config core.sparsecheckout # timeout=10
 > git checkout -f be8d3604fbc3cc53bf088fd06873fdfe14fc6545
 > git rev-list a539147a0e8b4b8852289909b2bcb268d7908887 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.5

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python35] $ /bin/sh -xe /tmp/jenkins4850102792464319778.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.5 virtual environment...

Using base prefix '/usr/local/python-3.5'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.5/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp35-cp35m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (from -r requirements.txt (line 31))
Collecting pyrsistent==0.11.13 (from -r requirements.txt (line 32))
Collecting python-dateutil==2.5.0 (from -r requirements.txt (line 33))
  Using cached python_dateutil-2.5.0-py2.py3-none-any.whl
Collecting python-mimeparse==1.5.1 (from -r requirements.txt (line 34))
Collecting pytz==2014.10 (from -r requirements.txt (line 35))
  Using cached pytz-2014.10-py2.py3-no

Jenkins build is back to normal : pgadmin4-master-python35 #386

[pgAdmin 4 Jenkins]

See 

Build failed in Jenkins: pgadmin4-master-python27 #386

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Prevent the Windows installer accepting paths containing invalid

[Dave Page] Stop Python 2.6 barfing on newer versions of Selenium

[Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887 (origin/master)
Commit message: "Fix /NOICONS switch in the windows installer. Fixes #1366"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
 > git rev-list 4568fe22f7e50cc9e782839c3ca35607d651b4b3 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=2.7

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python27] $ /bin/sh -xe /tmp/jenkins3809216698358619298.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.7 virtual environment...

New python executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-2.7/bin/python
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py2-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
  Using cached Flask_WTF-0.12-py2-none-any.whl
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting importlib==1.0.3 (from -r requirements.txt (line 22))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp27-cp27m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (from -r requirements.txt (line 31))
Collecting pyrsistent==0.11.13 (from -r requirements.txt (line 32))
Collecting python-dateutil==2.5.0 (from -r requirements.txt (line 33))
  Using cached python_dateutil-2.5.0-py2.py3-none-any.whl
Collecting python-mimeparse==1.5.1 (from -r requirements.txt (line 34))
Collec

Build failed in Jenkins: pgadmin4-master-python33 #384

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Stop Python 2.6 barfing on newer versions of Selenium

[Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887 (origin/master)
Commit message: "Fix /NOICONS switch in the windows installer. Fixes #1366"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
 > git rev-list 8ff753deb8cd49fde8fea25b9b676a45461ba7e9 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.3

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python33] $ /bin/sh -xe /tmp/jenkins6911027900469728936.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.3 virtual environment...

Using base prefix '/usr/local/python-3.3'
New python executable in 

Also creating executable in 

Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/local/python-3.3/bin/python3
Collecting wheel==0.29.0
  Using cached wheel-0.29.0-py2.py3-none-any.whl
Installing collected packages: wheel
Successfully installed wheel-0.29.0
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp33-cp33m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (from -r requirements.txt (line 31))
Collecting pyrsistent==0.11.13 (from -r requirements.txt (line 32))
Collecting python-dateutil

Build failed in Jenkins: pgadmin4-master-python33 #386

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Add missing semicolons.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision be8d3604fbc3cc53bf088fd06873fdfe14fc6545 (origin/master)
Commit message: "Add missing semicolons."
 > git config core.sparsecheckout # timeout=10
 > git checkout -f be8d3604fbc3cc53bf088fd06873fdfe14fc6545
 > git rev-list a539147a0e8b4b8852289909b2bcb268d7908887 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.3

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python33] $ /bin/sh -xe /tmp/jenkins1585245736006401201.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.3 virtual environment...

Using base prefix '/usr/local/python-3.3'
New python executable in 

Also creating executable in 

Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/local/python-3.3/bin/python3
Collecting wheel==0.29.0
  Using cached wheel-0.29.0-py2.py3-none-any.whl
Installing collected packages: wheel
Successfully installed wheel-0.29.0
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp33-cp33m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (from -r requirements.txt (line 31))
Collecting pyrsistent==0.11.13 (from -r requirements.txt (line 32))
Collecting python-dateutil==2.5.0 (from -r requirements.txt (line 33))
  Using cached python_dateutil-2.5.0-py2.py3-none-any.whl
Collecting python-mimeparse==1.5

Build failed in Jenkins: pgadmin4-master-python35 #384

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Stop Python 2.6 barfing on newer versions of Selenium

[Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887 (origin/master)
Commit message: "Fix /NOICONS switch in the windows installer. Fixes #1366"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
 > git rev-list 8ff753deb8cd49fde8fea25b9b676a45461ba7e9 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.5

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python35] $ /bin/sh -xe /tmp/jenkins3619158107766613468.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.5 virtual environment...

Using base prefix '/usr/local/python-3.5'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.5/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp35-cp35m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (from -r requirements.txt (line 31))
Collecting pyrsistent==0.11.13 (from -r requirements.txt (line 32))
Collecting python-dateutil==2.5.0 (from -r requirements.txt (line 33))
  Using cached python_dateutil-2.5.0-py2.py3-none-any.whl
Collecting python-mimeparse==1.5.1 (f

Jenkins build is back to normal : pgadmin4-master-python34 #378

[pgAdmin 4 Jenkins]

See 

Build failed in Jenkins: pgadmin4-master-python26 #515

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Stop Python 2.6 barfing on newer versions of Selenium

[Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366

--
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887 (origin/master)
Commit message: "Fix /NOICONS switch in the windows installer. Fixes #1366"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
 > git rev-list 8ff753deb8cd49fde8fea25b9b676a45461ba7e9 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=2.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python26] $ /bin/sh -xe /tmp/jenkins68325312947011975.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.6 virtual environment...

New python executable in 

Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/local/python-2.6/bin/python
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Collecting wheel==0.29.0
  Using cached wheel-0.29.0-py2.py3-none-any.whl
Collecting argparse; python_version == "2.6" (from wheel==0.29.0)
  Using cached argparse-1.4.0-py2.py3-none-any.whl
Installing collected packages: argparse, wheel
Successfully installed argparse-1.4.0 wheel-0.29.0
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please 
upgrade your Python. A future version of pip will drop support for Python 2.6
Ignoring Flask-HTMLmin: markers 'python_version >= "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py2-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
  Using cached Flask_WTF-0.12-py2-none-any.whl
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting importlib==1.0.3 (from -r requirements.txt (line 22))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting ordereddict (from -r requirements.txt (line 27))
:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available o

Build failed in Jenkins: pgadmin4-master-python33 #385

[pgAdmin 4 Jenkins]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision a539147a0e8b4b8852289909b2bcb268d7908887 (origin/master)
Commit message: "Fix /NOICONS switch in the windows installer. Fixes #1366"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a539147a0e8b4b8852289909b2bcb268d7908887
 > git rev-list a539147a0e8b4b8852289909b2bcb268d7908887 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.3

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python33] $ /bin/sh -xe /tmp/jenkins810289156067577580.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.3 virtual environment...

Using base prefix '/usr/local/python-3.3'
New python executable in 

Also creating executable in 

Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/local/python-3.3/bin/python3
Collecting wheel==0.29.0
  Using cached wheel-0.29.0-py2.py3-none-any.whl
Installing collected packages: wheel
Successfully installed wheel-0.29.0
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring backports.csv: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Collecting Babel==2.3.4 (from -r requirements.txt (line 4))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting beautifulsoup4==4.4.1 (from -r requirements.txt (line 5))
  Using cached beautifulsoup4-4.4.1-py3-none-any.whl
Collecting blinker==1.3 (from -r requirements.txt (line 6))
Collecting click==6.6 (from -r requirements.txt (line 7))
  Using cached click-6.6-py2.py3-none-any.whl
Collecting extras==0.0.3 (from -r requirements.txt (line 8))
Collecting fixtures==2.0.0 (from -r requirements.txt (line 9))
  Using cached fixtures-2.0.0-py2.py3-none-any.whl
Collecting Flask==0.11.1 (from -r requirements.txt (line 10))
  Using cached Flask-0.11.1-py2.py3-none-any.whl
Collecting Flask-Babel==0.11.1 (from -r requirements.txt (line 11))
Collecting Flask-Gravatar==0.4.2 (from -r requirements.txt (line 12))
  Using cached Flask_Gravatar-0.4.2-py2.py3-none-any.whl
Collecting Flask-HTMLmin==1.2 (from -r requirements.txt (line 13))
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 14))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 15))
Collecting Flask-Migrate==2.0.3 (from -r requirements.txt (line 16))
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 17))
Collecting Flask-Security==1.7.5 (from -r requirements.txt (line 18))
Collecting Flask-SQLAlchemy==2.1 (from -r requirements.txt (line 19))
Collecting Flask-WTF==0.12 (from -r requirements.txt (line 20))
Collecting html5lib==1.0b3 (from -r requirements.txt (line 21))
Collecting itsdangerous==0.24 (from -r requirements.txt (line 23))
Collecting Jinja2==2.7.3 (from -r requirements.txt (line 24))
Collecting linecache2==1.0.0 (from -r requirements.txt (line 25))
  Using cached linecache2-1.0.0-py2.py3-none-any.whl
Collecting MarkupSafe==0.23 (from -r requirements.txt (line 26))
Collecting passlib==1.6.2 (from -r requirements.txt (line 28))
Collecting pbr==1.9.1 (from -r requirements.txt (line 29))
  Using cached pbr-1.9.1-py2.py3-none-any.whl
Collecting psycopg2>=2.7.3.2 (from -r requirements.txt (line 30))
  Using cached psycopg2-2.7.3.2-cp33-cp33m-manylinux1_x86_64.whl
Collecting pycrypto==2.6.1 (from -r requirements.txt (line 31))
Collecting pyrsistent==0.11.13 (from -r requirements.txt (line 32))
Collecting python-dateutil==2.5.0 (from -r requirements.txt (line 33))
  Using cached python_dateutil-2.5.0-py2.py3-none-any.whl
Collecting python-mimeparse==1.5.1 (from -r requirements.tx

[pgAdmin4][Patch]: Remove limit of 4000 characters from Textarea

[Murtuza Zabuawala]

Hi,

PFA patch to fix the issue where we have hard coded limit of 4000
characters in Backform Textarea control, with new implementation we won't
limit input unless and until maxlength is provided in particular field.
RM#2877

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/static/js/backform.pgadmin.js 
b/web/pgadmin/static/js/backform.pgadmin.js
index 865746f..acde87b 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -273,7 +273,8 @@
   _.extend(
 Backform.TextareaControl.prototype, {
   defaults: _.extend(
-Backform.TextareaControl.prototype.defaults, {rows: 5, helpMessage: 
null}
+Backform.TextareaControl.prototype.defaults,
+{rows: 5, helpMessage: null, maxlength: null}
   ),
   events : {
 "change textarea": "onChange",
@@ -287,7 +288,10 @@
 '',
 '  ',
+'  <% if (maxlength) { %>',
+'maxlength="<%=maxlength%>"',
+'  <% } %>',
+'placeholder="<%-placeholder%>" <%=disabled ? "disabled" : ""%>',
 'rows=<%=rows ? rows : ""%>',
 '<%=required ? "required" : ""%>><%-value%>',
 '  <% if (helpMessage && helpMessage.length) { %>',

[pgAdmin4][Patch]: Properly quote owner in Type definition

[Murtuza Zabuawala]

Hi,

PFA minor patch to fix the issue where owner is not properly quoted causing
Create/Update type sql to fail.
RM#2787

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/sql/default/create.sql
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/sql/default/create.sql
index f2d6560..fdcbf0d 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/sql/default/create.sql
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/sql/default/create.sql
@@ -57,7 +57,7 @@ CREATE TYPE {% if data.schema %}{{ conn|qtIdent(data.schema, 
data.name) }}{% els
 
 ALTER TYPE {% if data.schema %}{{ conn|qtIdent(data.schema, data.name) }}{% 
else %}{{ conn|qtIdent(data.name) }}{% endif %}
 
-OWNER TO {{data.typeowner}};
+OWNER TO {{ conn|qtIdent(data.typeowner) }};
 {% endif %}
 {###  Type Comments ###}
 {% if data and data.description %}
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/sql/default/update.sql
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/sql/default/update.sql
index 3a0a336..d79cb6d 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/sql/default/update.sql
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/sql/default/update.sql
@@ -5,7 +5,7 @@
 {# Below will change object owner #}
 {% if data.typeowner and data.typeowner != o_data.typeowner %}
 ALTER TYPE {{ conn|qtIdent(o_data.schema, o_data.name) }}
-OWNER TO {{ data.typeowner }};
+OWNER TO {{ conn|qtIdent(data.typeowner) }};
 
 {% endif %}
 {#==#}
@@ -154,4 +154,4 @@ ALTER TYPE {% if data.name and data.name != o_data.name 
%}{{ conn|qtIdent(o_data
 {% else %}{{ conn|qtIdent(o_data.schema, o_data.name) }}
 {% endif %}
 SET SCHEMA {{ conn|qtIdent(data.schema) }};
-{% endif %}
\ No newline at end of file
+{% endif %}