Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

[Murtuza Zabuawala]

On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi  wrote:

> Hi Murtuza,
>
> On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA new patch.
>>
> If I have reviewed correctly, the current patch allows to select the
> colour for background color for server, and its children.
> I believe - we should allow to select text color too for better
> readability.
>
> ​Yes Ashesh, After our discussion I tried that but with all the different
colours in browser tree it looks cartoonish.
So for consistancy I kept it as it is.​

Dave - thoughts?
>
> --
> Thanks & Regards,
> Ashesh Vashi
>
>
> On Wed, Nov 15, 2017 at 10:33 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please hold on this patch, As discussed with Ashesh I need to make some
>>> changes, I'll send new patch.
>>>
>>> On Wed, Nov 15, 2017 at 10:07 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA patch which will allow user to choose background colour for the
 server.
 RM#1383

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


>>>
>>
>

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

[Ashesh Vashi]

On Wed, Nov 15, 2017 at 2:28 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>> On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA new patch.
>>>
>> If I have reviewed correctly, the current patch allows to select the
>> colour for background color for server, and its children.
>> I believe - we should allow to select text color too for better
>> readability.
>>
>> ​Yes Ashesh, After our discussion I tried that but with all the different
> colours in browser tree it looks cartoonish.
>
I am not sure - what looked like cartoonish to you (totally depend on the
color choices made by the users). :-)

If I choose any dark color as background color, text in nodes won't be
clear to the user, and that will make the tree nodes completely unusable.
If we allow to choose the foreground/text color, those dark colors will
become usable by choosing suitable light color as text colors.

I don't want to make any decision here, just asking for opinions from
others.

So - Again ball is back in Dave's courtyard :-).

--
Thanks & Regards,
Ashesh Vashi

So for consistancy I kept it as it is.​
>

> Dave - thoughts?
>>
>> --
>> Thanks & Regards,
>> Ashesh Vashi
>>
>>
>> On Wed, Nov 15, 2017 at 10:33 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 Please hold on this patch, As discussed with Ashesh I need to make some
 changes, I'll send new patch.

 On Wed, Nov 15, 2017 at 10:07 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch which will allow user to choose background colour for the
> server.
> RM#1383
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

>>>
>>
>

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

[Dave Page]

On Wed, Nov 15, 2017 at 9:26 AM, Ashesh Vashi  wrote:

> On Wed, Nov 15, 2017 at 2:28 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Hi Murtuza,
>>>
>>> On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA new patch.

>>> If I have reviewed correctly, the current patch allows to select the
>>> colour for background color for server, and its children.
>>> I believe - we should allow to select text color too for better
>>> readability.
>>>
>>> ​Yes Ashesh, After our discussion I tried that but with all the
>> different colours in browser tree it looks cartoonish.
>>
> I am not sure - what looked like cartoonish to you (totally depend on the
> color choices made by the users). :-)
>
> If I choose any dark color as background color, text in nodes won't be
> clear to the user, and that will make the tree nodes completely unusable.
> If we allow to choose the foreground/text color, those dark colors will
> become usable by choosing suitable light color as text colors.
>
> I don't want to make any decision here, just asking for opinions from
> others.
>
> So - Again ball is back in Dave's courtyard :-).
>

pgAdmin 3 didn't allow selection of the foreground colour, and I don't
recall anyone ever asking for it. It's clearly up to the user to not select
colours that won't work.

I'm fine with just setting the background colour to satisfy this
requirement, though if it's trivial to do, I have no objection to allowing
changes to the foreground colour.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgAdmin4][Patch]: Display long object name on alertify dialog header

[Murtuza Zabuawala]

Hi,

PFA minor patch to display database object names on alertify dialog header
if they are long and user have low screen resolution.
RM#2278

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss 
b/web/pgadmin/static/scss/_alertify.overrides.scss
index 95cd909..443663d 100644
--- a/web/pgadmin/static/scss/_alertify.overrides.scss
+++ b/web/pgadmin/static/scss/_alertify.overrides.scss
@@ -11,6 +11,8 @@
 font-size: 14px;
 font-weight: bold;
 border-radius: 0;
+overflow: hidden;
+white-space: nowrap;
   }
 
   /* Overrides alertify js headers hovering behaviour*/

Fix for minor issue RM2868

[Harshal Dhumal]

Hi,

Path to fix minor issue "local variable 'password' referenced before
assignment."


-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py
index 6d972ee..25ec28a 100644
--- a/web/pgadmin/browser/server_groups/servers/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/__init__.py
@@ -694,21 +694,18 @@ class ServerNode(PGChildNodeView):
 manager.update(server)
 conn = manager.connection()
 
-have_password =  False
+have_password = False
+password = None
+passfile = None
 if 'password' in data and data["password"] != '':
 # login with password
 have_password = True
-passfile = None
 password = data['password']
 password = encrypt(password, current_user.password)
 elif 'passfile' in data and data["passfile"] != '':
 passfile = data['passfile']
 setattr(server, 'passfile', passfile)
 db.session.commit()
-else:
-# Attempt password less login
-password = None
-passfile = None
 
 status, errmsg = conn.connect(
 password=password,

pgAdmin 4 commit: Check and attempt to fir the registry on Windows, if

[Dave Page]

Check and attempt to fir the registry on Windows, if the text/css type is 
misconfigured. Fixes #2716

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96df3147d632d9bc385df1c6d62b4f0242b650c6
Author: Neel Patel 

Modified Files
--
runtime/BrowserWindow.cpp | 34 ++
runtime/BrowserWindow.h   | 12 
runtime/pgAdmin4.cpp  | 24 
3 files changed, 70 insertions(+)

Re: [pgAdmin4][Patch]: RM#2716 - Automatic detect and fix value of "HKEY_CLASSES_ROOT\.css\Content Type"

[Dave Page]

Thanks, applied!

On Mon, Nov 13, 2017 at 8:43 AM, Neel Patel 
wrote:

> Hi,
>
> Please find attached patch file with the fix of RM#2716.
>
> *Issue:-*
>
> In Windows OS, if registry "HKEY_CLASSES_ROOT\.css\Content Type" value is
> not "text/css" then application get rendering issue and GUI is not
> displayed properly.
>
> *Solution:-*
>
> When pgAdmin4 application starts, it checks for registry value above and
> it differs from "text/css", application will change the value and notifies
> the user about the same.
>
> Do review it and let me know for comments.
>
> Thanks,
> Neel Patel
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Jenkins build is back to normal : pgadmin4-master-python34 #368

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python36 #375

[pgAdmin 4 Jenkins]

See