[pgAdmin4][Patch]: Set focus on Filter window when opened by user

2017-11-14 Thread Murtuza Zabuawala
Hi,

PFA minor patch to set proper cursor & focus on Filter editor window in
view data mode.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js 
b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index d50cca7..7b8dd70 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -2707,6 +2707,8 @@ define('tools.querytool', [
 self.gridView.filter_obj.setValue('');
   else
 self.gridView.filter_obj.setValue(res.data.result);
+  // Set focus on filter area
+  self.gridView.filter_obj.focus();
 } else {
   setTimeout(
 function () {


[pgAdmin4][Patch]: To make error message uniform for Create schema action

2017-11-14 Thread Murtuza Zabuawala
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both
query tool and create schema dialog.
RM#2094

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
index 04d2432..49c953c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
@@ -580,8 +580,7 @@ It may have been removed by another user.
 return make_json_response(
 status=410,
 success=0,
-errormsg=res + '\n' +
- 'Operation failed while running create statement'
+errormsg=res
 )
 
 # we need oid to to add object in tree at browser,


Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-14 Thread Murtuza Zabuawala
Hi,

Please hold on this patch, As discussed with Ashesh I need to make some
changes, I'll send new patch.

On Wed, Nov 15, 2017 at 10:07 AM, Murtuza Zabuawala  wrote:

> Hi,
>
> PFA patch which will allow user to choose background colour for the server.
> RM#1383
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-14 Thread Ashesh Vashi
Hi Murtuza,

On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA new patch.
>
If I have reviewed correctly, the current patch allows to select the colour
for background color for server, and its children.
I believe - we should allow to select text color too for better readability.

Dave - thoughts?

--
Thanks & Regards,
Ashesh Vashi


On Wed, Nov 15, 2017 at 10:33 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please hold on this patch, As discussed with Ashesh I need to make some
>> changes, I'll send new patch.
>>
>> On Wed, Nov 15, 2017 at 10:07 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch which will allow user to choose background colour for the
>>> server.
>>> RM#1383
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>