pgAdmin 4 commit: Fix RE-SQL for triggers with a single arg. Fixes #266

[Dave Page]

Fix RE-SQL for triggers with a single arg. Fixes #2668

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52840d68a891720fb266c3ac6b58b7f407fa7553
Author: Murtuza Zabuawala 

Modified Files
--
.../servers/databases/schemas/tables/triggers/__init__.py | 2 +-
.../browser/server_groups/servers/databases/schemas/tables/utils.py   | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

Re: [pgAdmin4][Patch]: Fix internal server error on Trigger module

[Dave Page]

Thanks, applied.

On Wed, Aug 30, 2017 at 12:20 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to fix the issue where it was throwing internal server
> error on SQL panel when trigger is of update event type.
>
> I have updated sample code to re-produce the issue on RM.
> RM#2668
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Improve datamodel validations for default Validator i

[Dave Page]

Improve datamodel validations for default Validator if user (developer) do not 
implement validate function in datamodel. Fixes #2670

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dbf760c6e7390cc0de5cd57e3068f009a72cdf9f
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/browser/static/js/datamodel.js | 16 
1 file changed, 8 insertions(+), 8 deletions(-)

Re: Fix for RM2670

[Dave Page]

Thanks, applied.

On Wed, Aug 30, 2017 at 2:08 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please find minor patch to improve datamodel validations for default
> Validator if user (developer) do not implement validate function in
> datamodel.
> Without this default validation error messages  were suppressing if no
> validation function was provided.
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix display of types in GPDB.

[Dave Page]

Fix display of types in GPDB.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eae6f0427c7c2e3350dd67aacc62a1053b2dd1a3
Author: Dave Cramer 

Modified Files
--
.../servers/databases/schemas/tables/utils.py  |  5 +
.../datatype/sql/gpdb_5.0_plus/get_types.sql   | 25 ++
.../servers/databases/schemas/types/__init__.py| 10 +++--
.../servers/databases/schemas/utils.py |  2 +-
4 files changed, 39 insertions(+), 3 deletions(-)

Re: fix get_types for GPDB

[Dave Page]

Thanks, applied. As with other GPDB patch, I couldn't test it fully, so
please keep an eye out for issues.

On Wed, Aug 30, 2017 at 7:29 PM, Dave Cramer  wrote:

> This patch allows create column to see available types in the dropdown
>
>
> Dave Cramer
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Define the proper NODE_ENV environment during running

[Ashesh Vashi]

Define the proper NODE_ENV environment during running the webpack.
Using the webpack.DefinePlugin during the development build too, not
just in production build.

Fixes #2596.

Also - passing option 'warning: false' for UglifyJsPlugin, which will
not show warning messages on the console during the production build.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2945b3fe93337174cd423367453621049980a0ae
Author: Surinder Kumar 

Modified Files
--
web/webpack.config.js | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

[Ashesh Vashi]

On Tue, Aug 29, 2017 at 5:55 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> Can you please review this patch please?
>
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> Thanks,
> Surinder
>
> On Wed, Aug 16, 2017 at 3:43 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Updated patch contains changes:
>>
>>- Enable definePlugin for development environment as well. Just
>>adding definePlugin in plugins array.
>>The variable process.env.NODE_ENV is useful to write conditional code
>>in pgAdmin4 JS modules.
>>
>> For example:
>>
>> if (process.env.NODE_ENV !== 'production') {
>>   // Write development environment specific code
>> } else {
>>   // Write production only code.
>> }
>>
>> Please review this patch and let me know for changes.
>>
>> Thanks,
>> Surinder
>> ​
>>
>> On Tue, Aug 1, 2017 at 11:32 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> 1. Now we are using `envType` variable in definePlugin which sets
>>> environment variable NODE_ENV globally which is used by React to create
>>> development or production build.
>>> where:
>>>  envType - determine build type is either `production` or
>>> `development`​ depending on the environment set in package.json > scripts.
>>>
>>> 2. In `UglifyJSPlugin`, i am setting compress > `warnings to false`,
>>> because here warning flag is meant to display warnings on terminal while
>>> creating build in production mode. so it is set to false.
>>>
>>> I didn't created an RM for #2 as it is minor change, if needed, i will
>>> create.
>>>
>>> ​Reference to webpack definePlugin:
>>> https://webpack.js.org/guides/production/#node-environment-variable​
>>>
>>> Please find updated patch with fixed review comments and review.
>>>
>>> Thanks,
>>> Surinder
>>>
>>> On Mon, Jul 31, 2017 at 3:31 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 On Fri, Jul 28, 2017 at 12:42 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> I inspect the react code and in call stacks, found
> `process.env.NODE_ENV` is undefined due to which 'SyntheticEvent.call' is
> not callable.
>
> So, to fix this, i add 'definePlugin' to plugins for `dev` environment
> in `webpack.config.js`. Initially it was added only for `production`
> environment. but it is needed for both, because React code is conditional
> based on environment variables set.
>

> Please find attached patch and review.
>
 As discussed, you're setting 'production', even in the 'development'
 mode.

 Please understand the code, and share the updated patch.
 Also - share the references next time, so that - committer can
 understand the reason for these changes.

 -- Thanks, Ashesh

>
> Thanks,
> Surinder
>


>>>
>>
>

Build failed in Jenkins: pgadmin4-master-python35 #303

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Improve datamodel validations for default Validator if user 
(developer)

[Dave Page] Fix display of types in GPDB.

[Ashesh Vashi] Define the proper NODE_ENV environment during running the 
webpack. Using

--
[...truncated 341.47 KB...]
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TestSSLConnection (Test for SSL connection)
PackageAddTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

EDB Postgres AS 9.5:

172 tests passed
0 tests failed
3 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TestSSLConnection (Test for SSL connection)
TableUpdateTestCase (Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)

PostgreSQL 9.4:

159 tests passed
1 test failed:
ForeignTablePutTestCase (Check foreign table Node)
15 tests skipped:
PackageDeleteTestCase (Fetch Package Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
TableUpdateTestCase (Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TestSSLConnection (Test for SSL connection)
PackageAddTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

EDB Postgres AS 9.6:

172 tests passed
0 tests failed
3 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TestSSLConnection (Test for SSL connection)
TableUpdateTestCase (Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)

EDB Postgres AS 9.3:

168 tests passed
0 tests failed
7 tests skipped:
ResourceGroupsGetTestCase (Get resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TestSSLConnection (Test for SSL connection)
ResourceGroupsAddTestCas

Array representation [pgAdmin4]

[Harshal Dhumal]

Hi Dave,

Regarding RM2641  how should we
represent array data types; With curly braces (like pgAdminIII) or without
curly braces (only comma separated)?
Currently in pgAdmin4 curly braces do not appear for text and int array
data types however they do appear for real, bigint, float, etc array data
types.

Also additional efforts will required If we plan to represent like
pgAdminIII as we'll need to update/add slickgrid cell editors/formatter for
array data types.




-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: 1) Fixed error in alertify.pgNotifier when server con

[Akshay Joshi]

1) Fixed error in alertify.pgNotifier when server connection is lost.
2) Change styling of alertify.pgNotifier as we did for success, error and info.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47cf874460dd0fcd0f39af1772e4ba3913020ee1

Modified Files
--
web/pgadmin/static/js/alertify.pgadmin.defaults.js | 59 +-
1 file changed, 34 insertions(+), 25 deletions(-)

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

[Surinder Kumar]

Hi Ashesh,

The issue is still not fixed, the reason is:

In the first patch, I was setting `production` flag in `definePlugin` like:

const definePlugin = new webpack.DefinePlugin({
  'process.env': {
'NODE_ENV': JSON.stringify('production'),
  },
});

in development mode but we had the discussion that when webpack is built in
dev mode the flag should be 'development' otherwise `production`.

But this issue is fixed only when we are setting `production` in
definePlugin, setting `development` mode doesn't fix this.

I have logged an issue in React


Thoughts?

Thanks,
Surinder

On Thu, Aug 31, 2017 at 2:29 PM, Ashesh Vashi  wrote:

> On Tue, Aug 29, 2017 at 5:55 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> Can you please review this patch please?
>>
> Thanks - committed!
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> Thanks,
>> Surinder
>>
>> On Wed, Aug 16, 2017 at 3:43 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Updated patch contains changes:
>>>
>>>- Enable definePlugin for development environment as well. Just
>>>adding definePlugin in plugins array.
>>>The variable process.env.NODE_ENV is useful to write conditional
>>>code in pgAdmin4 JS modules.
>>>
>>> For example:
>>>
>>> if (process.env.NODE_ENV !== 'production') {
>>>   // Write development environment specific code
>>> } else {
>>>   // Write production only code.
>>> }
>>>
>>> Please review this patch and let me know for changes.
>>>
>>> Thanks,
>>> Surinder
>>> ​
>>>
>>> On Tue, Aug 1, 2017 at 11:32 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Ashesh,

 1. Now we are using `envType` variable in definePlugin which sets
 environment variable NODE_ENV globally which is used by React to create
 development or production build.
 where:
  envType - determine build type is either `production` or
 `development`​ depending on the environment set in package.json > scripts.

 2. In `UglifyJSPlugin`, i am setting compress > `warnings to false`,
 because here warning flag is meant to display warnings on terminal while
 creating build in production mode. so it is set to false.

 I didn't created an RM for #2 as it is minor change, if needed, i will
 create.

 ​Reference to webpack definePlugin:
 https://webpack.js.org/guides/production/#node-environment-variable​

 Please find updated patch with fixed review comments and review.

 Thanks,
 Surinder

 On Mon, Jul 31, 2017 at 3:31 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> On Fri, Jul 28, 2017 at 12:42 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> I inspect the react code and in call stacks, found
>> `process.env.NODE_ENV` is undefined due to which 'SyntheticEvent.call' is
>> not callable.
>>
>> So, to fix this, i add 'definePlugin' to plugins for `dev`
>> environment in `webpack.config.js`. Initially it was added only for
>> `production` environment. but it is needed for both, because React code 
>> is
>> conditional based on environment variables set.
>>
>
>> Please find attached patch and review.
>>
> As discussed, you're setting 'production', even in the 'development'
> mode.
>
> Please understand the code, and share the updated patch.
> Also - share the references next time, so that - committer can
> understand the reason for these changes.
>
> -- Thanks, Ashesh
>
>>
>> Thanks,
>> Surinder
>>
>
>

>>>
>>
>

Jenkins build is back to normal : pgadmin4-master-python35 #304

[pgAdmin 4 Jenkins]

See 

pgAdmin 4 commit: Fix Copy so it still works after query results have b

[Dave Page]

Fix Copy so it still works after query results have been copied. Fixes #2637

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4393a7795eef18b311724f45b6c9c0dae01926d
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/static/js/selection/clipboard.js | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)

Re: [pgAdmin4][Patch]: RM_2637 - Copy functionality in Query Tool doesn't work after copying from Data Output

[Dave Page]

Thanks, applied.

On Thu, Aug 31, 2017 at 6:28 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> While working on webpacking pgAdmin4, I had removed
> `document.removeEventListener(...)` temporarily as it was not working in
> `strict` mode, giving type error and I forgot to include its fix,
>
> because of this copy/paste functionality didn't work properly which is now
> taken care in this patch.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Array representation [pgAdmin4]

[Dave Page]

Hi

On Thu, Aug 31, 2017 at 10:41 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi Dave,
>
> Regarding RM2641  how should
> we represent array data types; With curly braces (like pgAdminIII) or
> without curly braces (only comma separated)?
> Currently in pgAdmin4 curly braces do not appear for text and int array
> data types however they do appear for real, bigint, float, etc array data
> types.
>

With I would say, as that's how PostgreSQL will display them.



> Also additional efforts will required If we plan to represent like
> pgAdminIII as we'll need to update/add slickgrid cell editors/formatter for
> array data types.
>

It would be nice to have an array-aware editor that allows you to
add/remove from a list, and reorder it etc. But that's for another day.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Cascade styles not found 404 error

[Ladislav Jech]

Hi, I just refreshed latest git repo and getting following error on start:

INFO:pgadmin:Examining potential module: pgadmin.tools.user_management
2017-08-31 20:15:06,218: INFO pgadmin: Examining potential module:
pgadmin.tools.sqleditor.command
INFO:pgadmin:Examining potential module: pgadmin.tools.sqleditor.command
2017-08-31 20:15:06,229: INFO pgadmin: Examining potential module:
pgadmin.utils
INFO:pgadmin:Examining potential module: pgadmin.utils
2017-08-31 20:15:06,229: DEBUG pgadmin: Not running under the desktop
runtime, port: 5050
DEBUG:pgadmin:Not running under the desktop runtime, port: 5050
Starting pgAdmin 4. Please navigate to http://127.0.0.1:5050 in your
browser.
2017-08-31 20:15:06,244: INFO werkzeug: * Running on http://127.0.0.1:5050/
(Press CTRL+C to quit)
INFO:werkzeug: * Running on http://127.0.0.1:5050/ (Press CTRL+C to quit)
2017-08-31 20:15:47,082: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET / HTTP/1.1" 302 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET / HTTP/1.1" 302 -
/usr/lib64/python3.5/site-packages/flask_security/forms.py:213:
FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to
"FlaskForm" and will be removed in 1.0.
  super(LoginForm, self).__init__(*args, **kwargs)
2017-08-31 20:15:47,138: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /login?next=%2F HTTP/1.1" 200 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET /login?next=%2F
HTTP/1.1" 200 -
2017-08-31 20:15:47,168: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /browser/browser.css HTTP/1.1" 302 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/browser/browser.css HTTP/1.1" 302 -
2017-08-31 20:15:47,169: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/vendor/backgrid/backgrid.css HTTP/1.1" 200 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/vendor/backgrid/backgrid.css HTTP/1.1" 200 -
2017-08-31 20:15:47,199: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/vendor/require/require.js HTTP/1.1" 200 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/vendor/require/require.js HTTP/1.1" 200 -
2017-08-31 20:15:47,231: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/js/generated/style.css HTTP/1.1" 404 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/js/generated/style.css HTTP/1.1" 404 -
2017-08-31 20:15:47,233: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/js/generated/pgadmin_commons.js HTTP/1.1" 404 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/js/generated/pgadmin_commons.js HTTP/1.1" 404 -
2017-08-31 20:15:47,234: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/js/generated/vendor.js HTTP/1.1" 404 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/js/generated/vendor.js HTTP/1.1" 404 -
2017-08-31 20:15:47,233: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/js/generated/pgadmin.css HTTP/1.1" 404 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/js/generated/pgadmin.css HTTP/1.1" 404 -
2017-08-31 20:15:47,263: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/img/logo-right-256.png HTTP/1.1" 200 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/img/logo-right-256.png HTTP/1.1" 200 -
/usr/lib64/python3.5/site-packages/flask_security/forms.py:213:
FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to
"FlaskForm" and will be removed in 1.0.
  super(LoginForm, self).__init__(*args, **kwargs)
2017-08-31 20:15:47,384: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /login?next=%2Fbrowser%2Fbrowser.css HTTP/1.1" 200 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/login?next=%2Fbrowser%2Fbrowser.css HTTP/1.1" 200 -
2017-08-31 20:15:47,402: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/js/generated/vendor.js HTTP/1.1" 404 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/js/generated/vendor.js HTTP/1.1" 404 -
2017-08-31 20:15:47,412: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/js/generated/pgadmin_commons.js HTTP/1.1" 404 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET
/static/js/generated/pgadmin_commons.js HTTP/1.1" 404 -
2017-08-31 20:15:47,467: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /favicon.ico HTTP/1.1" 302 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET /favicon.ico
HTTP/1.1" 302 -
2017-08-31 20:15:47,485: INFO werkzeug: 127.0.0.1 - - [31/Aug/2017
20:15:47] "GET /static/favicon.ico HTTP/1.1" 200 -
INFO:werkzeug:127.0.0.1 - - [31/Aug/2017 20:15:47] "GET /static/favicon.ico
HTTP/1.1" 200 -

S pozdravem,

Ladislav Jech

Error with webpack

[Ladislav Jech]

Hi guys,

I am getting following error with latest git version:
Done in 1.75s.
yarn run v0.21.3
$ yarn run webpack -- --config webpack.config.js
yarn run v0.21.3
$ "/home/zangetsu/devel/tmp/pgadmin4/web/node_modules/.bin/webpack"
--config webpack.config.js
module.js:491
throw err;
^

Error: Cannot find module 'optimize-css-assets-webpack-plugin'
at Function.Module._resolveFilename (module.js:489:15)
at Function.Module._load (module.js:439:25)
at Module.require (module.js:517:17)
at require (internal/module.js:11:18)
at Object.
(/home/zangetsu/devel/tmp/pgadmin4/web/webpack.config.js:11:33)
at Module._compile (module.js:573:30)
at Object.Module._extensions..js (module.js:584:10)
at Module.load (module.js:507:32)
at tryModuleLoad (module.js:470:12)
at Function.Module._load (module.js:462:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.

Commit:
commit c4393a7795eef18b311724f45b6c9c0dae01926d (HEAD -> master,
origin/master, origin/HEAD)
Author: Surinder Kumar 
Date:   Thu Aug 31 14:50:22 2017 +0100

Re: Error with webpack

[Surinder Kumar]

Hi Ladislav,
​
After taking the latest pull from git HEAD:

1. Install all Python dependent packages
   `$ pip install -r requirements.txt`

2. Install all NPM packages
   $ cd web and run yarn install

3. Run pgAdmin4 server and browse to 'http://127.0.0.1:5050'
   `$ python pgAdmin4.py`

Thanks,
Surinder

On Thu, Aug 31, 2017 at 11:48 PM, Ladislav Jech 
wrote:

> Hi guys,
>
> I am getting following error with latest git version:
> Done in 1.75s.
> yarn run v0.21.3
> $ yarn run webpack -- --config webpack.config.js
> yarn run v0.21.3
> $ "/home/zangetsu/devel/tmp/pgadmin4/web/node_modules/.bin/webpack"
> --config webpack.config.js
> module.js:491
> throw err;
> ^
>
> Error: Cannot find module 'optimize-css-assets-webpack-plugin'
> at Function.Module._resolveFilename (module.js:489:15)
> at Function.Module._load (module.js:439:25)
> at Module.require (module.js:517:17)
> at require (internal/module.js:11:18)
> at Object. (/home/zangetsu/devel/tmp/pgad
> min4/web/webpack.config.js:11:33)
> at Module._compile (module.js:573:30)
> at Object.Module._extensions..js (module.js:584:10)
> at Module.load (module.js:507:32)
> at tryModuleLoad (module.js:470:12)
> at Function.Module._load (module.js:462:3)
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command.
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command.
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command.
>
> ​It seems you didn't run `$ yarn install​`

> Commit:
> commit c4393a7795eef18b311724f45b6c9c0dae01926d (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Surinder Kumar 
> Date:   Thu Aug 31 14:50:22 2017 +0100
>