date:20170830

Re: pgAdmin4: Cleanup in role dependency test cases

2017-08-30 Thread Dave Page

Hi

On Wed, Aug 30, 2017 at 6:34 AM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hi Dave,
>
> Role dependency test cases are failing due to database error *'ERROR:
> cache lookup failed for database XX'. *Test-suite throwing error on*
> "DROP ROLE ".*
> This is intermittent issue I was executing test cases on all
> servers (pg9.2-10 and ppas9.2-10)
>
> Somehow the 'DROP database' didn't drop the shared dependencies correctly
> in role dependency test cases.
> PostgreSQL still thinks that Role owns 1 table in the database which is
> dropped now .Due to that role was not able to drop.
> This could be a bug in PG. Anyway, since the database is dropped, it is
> safe to manually remove the user as it is not of any use more.
>

It's never safe to remove a user like that - plus the user would need
rolcatupdate privs for it to even work (which a superuser doesn't have by
default).

Have you run the problem past the DB Server team?

Another point to note is that support for 9.2 will end very soon, so it
might not be worth worrying about.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

2017-08-30 Thread Dave Page

Hi

On Wed, Aug 30, 2017 at 6:49 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA updated patch with new screenshots and docs accordingly.
>
> RM
> #
> 2649
>  & RM#
> 2650
>
> On Tue, Aug 29, 2017 at 7:51 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Fri, Aug 25, 2017 at 2:45 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find updated patch,
>>> - For displaying hidden files I have added preference option in Storage
>>> section.
>>>
>>
>> How painful would it be to include it on the file dialogue as well?
>>
> Done
>
>
>>
>>
>>> - Updated Docs & Screenshots.
>>> - User can use 'prefer' option to enable SSL options.
>>>
>>
>> Cool.
>>
>> A couple of other things I realised in playing with this:
>>
>> 1) The SSL tab should come before Advanced I think.
>>
> Done
>
>
>>
>> 2) The docs now mention the default SSL files. In server mode, using
>> defaults is probably a bad idea I suspect (because they would be shared).
>> Should we force the values to /dev/null (and whatever is appropriate on
>> Windows) if running in server mode? Users can always override that with
>> something from their storage area.
>>
>> Thoughts?
>>
> In my opinion we should not force users to provide certificates, we can
> let them decide how they want to configure it.
>

It's not about forcing them to provide them, it's about preventing them
from using defaults which may be owned by the user that the app runs as on
a server, but that should not be (unless explicitly allowed by the
sysadmin) accessible to every pgAdmin user.

Thoughts from others? Ashesh?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Rename the debugger XSS test function to 'a_test_func

2017-08-30 Thread Dave Page

Rename the debugger XSS test function to 'a_test_function' to ensure it appears 
near the top of the tree and not off-screen.

This should not be a permanent fix (the test should be able to scroll the 
treeview), but works for now to stop tests failing.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=048205ead5c74c8e9c3994b9f3f91d76bdf32dc4
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/feature_tests/xss_checks_pgadmin_debugger_test.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

pgAdmin 4 commit: GPDB compatibility fixes:

2017-08-30 Thread Dave Page

GPDB compatibility fixes:

When connected to a Greenplum database server
- Hide items that not work with GPDB, such as Triggers, FDW, FTS_*, etc
- Tables/Views/Catalogs/Language node can expand correctly
- Views/Languages/Catalogs can show properties dialog with correct information
- Show a greenplum icon at the server node

Teng Zhang & Hao Wang

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=821442ed8ffef696c01ac243dc4b2eb342d197a7
Author: Teng Zhang 

Modified Files
--
.../servers/databases/casts/__init__.py|   1 +
.../servers/databases/event_triggers/__init__.py   |   1 +
.../servers/databases/extensions/__init__.py   |   1 +
.../databases/foreign_data_wrappers/__init__.py|   1 +
.../servers/databases/languages/__init__.py|   4 +-
.../templates/languages/sql/gpdb_5.0_plus/acl.sql  |  34 +
.../languages/sql/gpdb_5.0_plus/properties.sql |  22 ++
.../servers/databases/schemas/__init__.py  |  19 +++--
.../databases/schemas/collations/__init__.py   |   1 +
.../servers/databases/schemas/domains/__init__.py  |   1 +
.../databases/schemas/foreign_tables/__init__.py   |   1 +
.../schemas/fts_configurations/__init__.py |   1 +
.../databases/schemas/fts_dictionaries/__init__.py |   1 +
.../databases/schemas/fts_parser/__init__.py   |   4 +
.../databases/schemas/fts_templates/__init__.py|   1 +
.../databases/schemas/functions/__init__.py|   3 +
.../databases/schemas/sequences/__init__.py|   1 +
.../schemas/tables/partitions/__init__.py  |   2 +
.../databases/schemas/tables/triggers/__init__.py  |   3 +
.../catalog/gpdb_5.0_plus/macros/catalogs.sql  |  21 ++
.../templates/catalog/gpdb_5.0_plus/sql/acl.sql|  38 ++
.../templates/catalog/gpdb_5.0_plus/sql/create.sql |  17 +
.../catalog/gpdb_5.0_plus/sql/get_name.sql |   1 +
.../catalog/gpdb_5.0_plus/sql/is_catalog.sql   |   9 +++
.../templates/catalog/gpdb_5.0_plus/sql/nodes.sql  |  16 
.../catalog/gpdb_5.0_plus/sql/properties.sql   |  24 ++
.../templates/catalog/gpdb_5.0_plus/sql/update.sql |  30 
.../schema/gpdb_5.0_plus/allowed_privs.json|  30 
.../templates/schema/gpdb_5.0_plus/sql/acl.sql |  23 ++
.../templates/schema/gpdb_5.0_plus/sql/create.sql  |  40 ++
.../templates/schema/gpdb_5.0_plus/sql/defacl.sql  |  40 ++
.../templates/schema/gpdb_5.0_plus/sql/delete.sql  |   1 +
.../schema/gpdb_5.0_plus/sql/get_name.sql  |   1 +
.../schema/gpdb_5.0_plus/sql/is_catalog.sql|   9 +++
.../templates/schema/gpdb_5.0_plus/sql/nodes.sql   |  20 +
.../templates/schema/gpdb_5.0_plus/sql/oid.sql |   1 +
.../schema/gpdb_5.0_plus/sql/properties.sql|  57 ++
.../templates/schema/gpdb_5.0_plus/sql/update.sql  |  83 +
.../servers/databases/schemas/views/__init__.py|  23 --
.../views/templates/view/gpdb_5.0_plus/sql/acl.sql |  74 ++
.../view/gpdb_5.0_plus/sql/allowed_privs.json  |   6 ++
.../templates/view/gpdb_5.0_plus/sql/create.sql|  20 +
.../templates/view/gpdb_5.0_plus/sql/delete.sql|  13 
.../templates/view/gpdb_5.0_plus/sql/get_oid.sql   |   9 +++
.../view/gpdb_5.0_plus/sql/get_schema.sql  |   7 ++
.../templates/view/gpdb_5.0_plus/sql/grant.sql |   6 ++
.../templates/view/gpdb_5.0_plus/sql/nodes.sql |  13 
.../view/gpdb_5.0_plus/sql/properties.sql  |  57 ++
.../templates/view/gpdb_5.0_plus/sql/update.sql|  67 +
.../templates/view/gpdb_5.0_plus/sql/view_id.sql   |   4 +
.../server_groups/servers/pgagent/__init__.py  |   3 +
.../server_groups/servers/static/img/gpdb.png  | Bin 0 -> 1244 bytes
web/pgadmin/browser/tests/test_version_in_range.py |  68 +
web/pgadmin/browser/utils.py   |  24 --
54 files changed, 938 insertions(+), 19 deletions(-)

Re: [pgAdmin4][Patch] ACI tree compatible with Greenplum

2017-08-30 Thread Dave Page

Thanks, I've applied the patch, but have only eyeball-reviewed and tested
for negative effects on PG servers (of which there seem to be none). Please
ensure everything looks good against GPDB as I'm unable to test that at
present.

On Wed, Aug 30, 2017 at 7:31 AM, Teng Zhang  wrote:

> Hi Hackers,
>
> Attached is a patch that makes ACI tree works better with Greenplum.
>
> When connected to a Greenplum database server
> - Hide items that not work with GPDB, such as Triggers, FDW, FTS_*, etc
> - Tables/Views/Catalogs/Language node can expand correctly
> - Views/Languages/Catalogs can show properties dialog with correct
> information
> - Show a greenplum icon at the server node
>
> Regards,
> Teng Zhang & Hao Wang
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgAdmin4][Patch]: Fix internal server error on Trigger module

2017-08-30 Thread Murtuza Zabuawala

Hi,

PFA minor patch to fix the issue where it was throwing internal server
error on SQL panel when trigger is of update event type.

I have updated sample code to re-produce the issue on RM.
RM#2668


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[image: https://community.postgresrocks.net/]

diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
index 19dcf8a..5c06d9d 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
@@ -949,7 +949,7 @@ class TriggerView(PGChildNodeView):
 # We know that trigger has more than 1 argument, let's join them
 data['tgargs'] = self._format_args(data['custom_tgargs'])
 
-if len(data['tgattr']) > 1:
+if len(data['tgattr']) >= 1:
 columns = ', '.join(data['tgattr'].split(' '))
 data['columns'] = self._column_details(tid, columns)
 
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
index 11d40dd..9444b82 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
@@ -995,7 +995,7 @@ class BaseTableView(PGChildNodeView):
 # We know that trigger has more than 1 argument, let's join 
them
 data['tgargs'] = self._format_args(data['custom_tgargs'])
 
-if len(data['tgattr']) > 1:
+if len(data['tgattr']) >= 1:
 columns = ', '.join(data['tgattr'].split(' '))
 
 SQL = render_template("/".join([self.trigger_template_path,
@@ -1009,7 +1009,7 @@ class BaseTableView(PGChildNodeView):
 columns = []
 
 for col_row in rset['rows']:
-columns.append({'column': col_row['name']})
+columns.append(col_row['name'])
 
 data['columns'] = columns

Fix for RM2670

2017-08-30 Thread Harshal Dhumal

Hi,

Please find minor patch to improve datamodel validations for default
Validator if user (developer) do not implement validate function in
datamodel.
Without this default validation error messages  were suppressing if no
validation function was provided.

-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/static/js/datamodel.js b/web/pgadmin/browser/static/js/datamodel.js
index c7c5dd6..dfc803f 100644
--- a/web/pgadmin/browser/static/js/datamodel.js
+++ b/web/pgadmin/browser/static/js/datamodel.js
@@ -358,14 +358,14 @@ function(_, S, pgAdmin, $, Backbone) {
 if (!msg) {
   msg = self.validate(_.keys(attrs));
 }
-
-/*
- * If any parent present, we will need to inform the parent - that
- * I have some issues/fixed the issue.
- *
- * If not parent found, we will raise the issue
- */
-if (_.size(self.errorModel.attributes) == 0) {
+  }
+  /*
+   * If any parent present, we will need to inform the parent - that
+   * I have some issues/fixed the issue.
+   *
+   * If not parent found, we will raise the issue
+   */
+  if (_.size(self.errorModel.attributes) == 0) {
   if (self.collection || self.handler) {
 (self.collection || self.handler).trigger(
 'pgadmin-session:model:valid', self, (self.collection || self.handler)
@@ -383,7 +383,6 @@ function(_, S, pgAdmin, $, Backbone) {
 self.trigger('pgadmin-session:invalid', msg, self);
   }
 }
-  }
 
   return res;
 }

fix get_types for GPDB

2017-08-30 Thread Dave Cramer

This patch allows create column to see available types in the dropdown


Dave Cramer
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
index 11d40dd..ef08d48 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
@@ -111,6 +111,11 @@ class BaseTableView(PGChildNodeView):
 if server_type == 'gpdb' else
 '#{0}#'.format(ver)
 )
+self.data_type_template_path='datatype/sql/'+ (
+'#{0}#{1}#'.format(server_type, ver)
+if server_type == 'gpdb' else
+'#{0}#'.format(ver)
+)
 self.partition_template_path = 'partition/sql/#{0}#'.format(ver)
 
 # Template for Column ,check constraint and exclusion
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/datatype/sql/gpdb_5.0_plus/get_types.sql
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/datatype/sql/gpdb_5.0_plus/get_types.sql
new file mode 100644
index 000..7634321
--- /dev/null
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/datatype/sql/gpdb_5.0_plus/get_types.sql
@@ -0,0 +1,25 @@
+SELECT
+*
+FROM
+(SELECT
+format_type(t.oid,NULL) AS typname,
+CASE WHEN typelem > 0 THEN typelem ELSE t.oid END as elemoid,
+typlen, typtype, t.oid, nspname,
+(SELECT COUNT(1) FROM pg_type t2 WHERE t2.typname = t.typname) > 1 AS 
isdup,
+FALSE  AS is_collatable
+FROM
+pg_type t
+JOIN
+pg_namespace nsp ON typnamespace=nsp.oid
+WHERE
+(NOT (typname = 'unknown' AND nspname = 'pg_catalog'))
+AND
+{{ condition }}
+{% if add_serials %}
+{# Here we will add serials types manually #}
+UNION SELECT 'smallserial', 0, 2, 'b', 0, 'pg_catalog', false, false
+UNION SELECT 'bigserial', 0, 8, 'b', 0, 'pg_catalog', false, false
+UNION SELECT 'serial', 0, 4, 'b', 0, 'pg_catalog', false, false
+{% endif %}
+) AS dummy
+ORDER BY nspname <> 'pg_catalog', nspname <> 'public', nspname, 1
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/__init__.py 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/__init__.py
index 085ab43..e086290 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/__init__.py
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/__init__.py
@@ -233,8 +233,14 @@ class TypeView(PGChildNodeView, DataTypeReader):
 # Declare allows acl on type
 self.acl = ['U']
 
-# we will set template path for sql scripts
-self.template_path = 'type/sql/#{0}#'.format(self.manager.version)
+ver = self.manager.version
+server_type = self.manager.server_type
+# Set the template path for the SQL scripts
+self.template_path = 'type/sql/' + (
+'#{0}#{1}#'.format(server_type, ver)
+if server_type == 'gpdb' else
+'#{0}#'.format(ver)
+)
 
 return f(*args, **kwargs)
 return wrap
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py
index 852724d..69e94b1 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py
@@ -95,7 +95,7 @@ class DataTypeReader:
 try:
 
 SQL = render_template(
-
'/datatype/sql/#{0}#/get_types.sql'.format(conn.manager.version),
+"/".join([self.data_type_template_path,'get_types.sql']),
 condition=condition,
 add_serials=add_serials)
 status, rset = conn.execute_2darray(SQL)

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Robert Eckhardt

How does this reflect actual user workflow? I have never quite understood
how a user was supposed to navigate through this, it seems like the
expectation is to continually click until they see the thing they want
rather than just going through as though it were a wizard. Is this
something that could be made into a wizard?

-- Rob

On Tue, Aug 29, 2017 at 10:57 AM, Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:

> Hi Team,
>
> I am sharing a improvised mockup in response to the below request that I
> received for '*Table properties*' where we have multiple subgrid controls
> with tabs.
>
> Please feel free to share your views on the same.
>
> Thanks and regards,
> Chethana kumar
>
>
>
> On Tue, Aug 8, 2017 at 10:22 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, Aug 7, 2017 at 9:06 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar <
>>> chethana.ku...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Could you comment on the new design update for subnode control ?

 Attached designs -

 1. subnode_current.png -  The existing view
 2. subnode_new.png - The updated view
 3. current_new.png - Existing and new design placed together for
 comparison purpose

 Below changes done -

 1. Reduced number of gray color variations
 2. Made more simplified by removing unwanted borders
 3. Merged "Arrow Down" background and the body background for more
 clarity

 Please feel free to provide your input on the same.

>>>
>>> Much nicer in my opinion! Good work.
>>>
>>> Anyone else have any comments?
>>>
>> It looks much nicer.
>> I would like to see the effect on another dialogs like 'Table
>> properties', where we have multiple level of subgrid controls with tabs.
>>
>> -- Thanks, Ashesh
>>
>>>
>>>

 Regards,
 Chethana kumar



 On Fri, Jul 28, 2017 at 4:11 PM, Dave Page  wrote:

> Hi
>
> I took a quick look at this and have a couple of thoughts:
>
> - Instead of the "edit" icon to open the subnode, we should use
> something more appropriate - a "properties" icon perhaps.
>
> - There seems to be a lot of different shades of grey on there (maybe
> a subnode design in general that just shows up with the disabled 
> controls),
> and the subnode control looks a bit messy as a result.
>
> Can you work with Chethana to improve the look and feel please?
>
> Input from others welcome of course - screenshot attached.
>
> Thanks.
>
> On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> ++ Attaching the patch
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> PFA patch to display additional information from pg_stat_activity
>>> table using subnode control.
>>> RM#2597
>>>
>>> Please review.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang 
>>> wrote:
>>>

> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page 
> wrote:
>
>>
>>
>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang 
>> wrote:
>>
>>> 2-3 days is a lot of valuable engineering time. Is this a 'drop
>>> everything now' kind of feature or can this wait for some user 
>>> validation
>>> on a mock up first?
>>>
>>
>> Most of the time will likely be on the infrastructure to change
>> the display to a subnode control. If you have some cycles to mockup
>> potential layouts for the subnode view and have them validated, 
>> please feel
>> free, however, that seems like an awful lot of work to me to display 
>> some
>> missing SQL using a standard control.
>>
> Regarding SQL display: Developing simple control to show
> codemirror in disabled state (for now) wont take that much time.
>
>
 Part of a product designer's job is to make sure there is a
 definitive need for a feature and that the interface for the feature is
 designed in such a way that the user gets all intended value from it. 
 Time
 spent validating now will decrease the time spent later on redesigning 
 /
 reimplementing.

 If everyone is aware of what that value is and confident that how
 it'll be displayed is right, there's little risk in starting to 
 develop it.
 If we're wrong, i

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Shirley Wang

+1 to Rob. By the time a user drills into seeing column properties, she'll
have gone through 5 layers of navigation. Is there another way to display
this information so that it's not nested?

If this is a visual design revamp that's a different conversation. What
kind of feedback are you looking for?

Shirley

On Tue, Aug 29, 2017 at 10:57 AM Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:

> Hi Team,
>
> I am sharing a improvised mockup in response to the below request that I
> received for '*Table properties*' where we have multiple subgrid controls
> with tabs.
>
> Please feel free to share your views on the same.
>
> Thanks and regards,
> Chethana kumar
>
>
>
> On Tue, Aug 8, 2017 at 10:22 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, Aug 7, 2017 at 9:06 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar <
>>> chethana.ku...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Could you comment on the new design update for subnode control ?

 Attached designs -

 1. subnode_current.png -  The existing view
 2. subnode_new.png - The updated view
 3. current_new.png - Existing and new design placed together for
 comparison purpose

 Below changes done -

 1. Reduced number of gray color variations
 2. Made more simplified by removing unwanted borders
 3. Merged "Arrow Down" background and the body background for more
 clarity

 Please feel free to provide your input on the same.

>>>
>>> Much nicer in my opinion! Good work.
>>>
>>> Anyone else have any comments?
>>>
>> It looks much nicer.
>> I would like to see the effect on another dialogs like 'Table
>> properties', where we have multiple level of subgrid controls with tabs.
>>
>> -- Thanks, Ashesh
>>
>>>
>>>

 Regards,
 Chethana kumar



 On Fri, Jul 28, 2017 at 4:11 PM, Dave Page  wrote:

> Hi
>
> I took a quick look at this and have a couple of thoughts:
>
> - Instead of the "edit" icon to open the subnode, we should use
> something more appropriate - a "properties" icon perhaps.
>
> - There seems to be a lot of different shades of grey on there (maybe
> a subnode design in general that just shows up with the disabled 
> controls),
> and the subnode control looks a bit messy as a result.
>
> Can you work with Chethana to improve the look and feel please?
>
> Input from others welcome of course - screenshot attached.
>
> Thanks.
>
> On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> ++ Attaching the patch
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> PFA patch to display additional information from pg_stat_activity
>>> table using subnode control.
>>> RM#2597
>>>
>>> Please review.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang 
>>> wrote:
>>>

> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page 
> wrote:
>
>>
>>
>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang 
>> wrote:
>>
>>> 2-3 days is a lot of valuable engineering time. Is this a 'drop
>>> everything now' kind of feature or can this wait for some user 
>>> validation
>>> on a mock up first?
>>>
>>
>> Most of the time will likely be on the infrastructure to change
>> the display to a subnode control. If you have some cycles to mockup
>> potential layouts for the subnode view and have them validated, 
>> please feel
>> free, however, that seems like an awful lot of work to me to display 
>> some
>> missing SQL using a standard control.
>>
> Regarding SQL display: Developing simple control to show
> codemirror in disabled state (for now) wont take that much time.
>
>
 Part of a product designer's job is to make sure there is a
 definitive need for a feature and that the interface for the feature is
 designed in such a way that the user gets all intended value from it. 
 Time
 spent validating now will decrease the time spent later on redesigning 
 /
 reimplementing.

 If everyone is aware of what that value is and confident that how
 it'll be displayed is right, there's little risk in starting to 
 develop it.
 If we're wrong, it'll add to feature bl

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Dave Page

It's a visual design update.

As for the actual dialogue; a wizard really isn't appropriate as the
typical workflow will be very inconsistent and often non-linear. I have no
idea how to improve it further, except through improving the visuals to
make it clearer. It's 100x easier to use than the pgAdmin 3 design though
:-)

On Wed, Aug 30, 2017 at 9:49 PM, Shirley Wang  wrote:

> +1 to Rob. By the time a user drills into seeing column properties, she'll
> have gone through 5 layers of navigation. Is there another way to display
> this information so that it's not nested?
>
> If this is a visual design revamp that's a different conversation. What
> kind of feedback are you looking for?
>
> Shirley
>
> On Tue, Aug 29, 2017 at 10:57 AM Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I am sharing a improvised mockup in response to the below request that I
>> received for '*Table properties*' where we have multiple subgrid
>> controls with tabs.
>>
>> Please feel free to share your views on the same.
>>
>> Thanks and regards,
>> Chethana kumar
>>
>>
>>
>> On Tue, Aug 8, 2017 at 10:22 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Mon, Aug 7, 2017 at 9:06 PM, Dave Page  wrote:
>>>


 On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar <
 chethana.ku...@enterprisedb.com> wrote:

> Hi Dave,
>
> Could you comment on the new design update for subnode control ?
>
> Attached designs -
>
> 1. subnode_current.png -  The existing view
> 2. subnode_new.png - The updated view
> 3. current_new.png - Existing and new design placed together for
> comparison purpose
>
> Below changes done -
>
> 1. Reduced number of gray color variations
> 2. Made more simplified by removing unwanted borders
> 3. Merged "Arrow Down" background and the body background for more
> clarity
>
> Please feel free to provide your input on the same.
>

 Much nicer in my opinion! Good work.

 Anyone else have any comments?

>>> It looks much nicer.
>>> I would like to see the effect on another dialogs like 'Table
>>> properties', where we have multiple level of subgrid controls with tabs.
>>>
>>> -- Thanks, Ashesh
>>>


>
> Regards,
> Chethana kumar
>
>
>
> On Fri, Jul 28, 2017 at 4:11 PM, Dave Page  wrote:
>
>> Hi
>>
>> I took a quick look at this and have a couple of thoughts:
>>
>> - Instead of the "edit" icon to open the subnode, we should use
>> something more appropriate - a "properties" icon perhaps.
>>
>> - There seems to be a lot of different shades of grey on there (maybe
>> a subnode design in general that just shows up with the disabled 
>> controls),
>> and the subnode control looks a bit messy as a result.
>>
>> Can you work with Chethana to improve the look and feel please?
>>
>> Input from others welcome of course - screenshot attached.
>>
>> Thanks.
>>
>> On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> ++ Attaching the patch
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 PFA patch to display additional information from pg_stat_activity
 table using subnode control.
 RM#2597

 Please review.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang 
 wrote:

>
>> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page 
>> wrote:
>>
>>>
>>>
>>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang 
>>> wrote:
>>>
 2-3 days is a lot of valuable engineering time. Is this a 'drop
 everything now' kind of feature or can this wait for some user 
 validation
 on a mock up first?

>>>
>>> Most of the time will likely be on the infrastructure to change
>>> the display to a subnode control. If you have some cycles to mockup
>>> potential layouts for the subnode view and have them validated, 
>>> please feel
>>> free, however, that seems like an awful lot of work to me to 
>>> display some
>>> missing SQL using a standard control.
>>>
>> Regarding SQL display: Developing simple control to show
>> codemirror in disabled state (for now) wont take that much time.
>>
>>
> Part of a product designer's job is to

[pgAdmin4][Patch]: RM_2637 - Copy functionality in Query Tool doesn't work after copying from Data Output

2017-08-30 Thread Surinder Kumar

Hi

While working on webpacking pgAdmin4, I had removed
`document.removeEventListener(...)` temporarily as it was not working in
`strict` mode, giving type error and I forgot to include its fix,

because of this copy/paste functionality didn't work properly which is now
taken care in this patch.

Please find attached patch and review.

Thanks,
Surinder


RM_2637.patch
Description: Binary data

Re: pgAdmin4: Cleanup in role dependency test cases

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

pgAdmin 4 commit: Rename the debugger XSS test function to 'a_test_func

pgAdmin 4 commit: GPDB compatibility fixes:

Re: [pgAdmin4][Patch] ACI tree compatible with Greenplum

[pgAdmin4][Patch]: Fix internal server error on Trigger module

Fix for RM2670

fix get_types for GPDB

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

[pgAdmin4][Patch]: RM_2637 - Copy functionality in Query Tool doesn't work after copying from Data Output

12 matches

Site Navigation

Mail list logo

Footer information