Re: pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD

[Akshay Joshi]

Hi Dave

Changes looks good to me, only one thing is that I also override 'DATA_DIR'
and 'TEST_SQLITE_PATH' parameter in my config_local.py, so we should
include both the parameters in 'desktop_deployment.rst' file.

On Fri, Aug 25, 2017 at 4:45 PM, Dave Page  wrote:

> Akshay, Ashesh,
>
> I've committed these doc changes to reflect the paths/SERVER_MODE changes.
> Could you both please review them and let me know if I missed anything of
> importance, or if anything isn't clear?
>
> Thanks.
>
> On Fri, Aug 25, 2017 at 12:13 PM, Dave Page  wrote:
>
>> Update docs to more accurately reflect the SERVER_MODE config
>> requirements.
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=5c016f0993fb557052cce7e11cd6ad818bd7c3a3
>>
>> Modified Files
>> --
>> docs/en_US/desktop_deployment.rst | 39 ++
>> -
>> docs/en_US/server_deployment.rst  | 18 --
>> 2 files changed, 18 insertions(+), 39 deletions(-)
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

[Murtuza Zabuawala]

Hi,

Please find a patch to fix the issue for PG9.6 in Dashboard, this is
regression of RM#2597.

*Error:*
2017-08-28 11:49:28,238: ERROR pgadmin: Failed to execute query
(execute_dict) for the server #34- DB:postgres (Query-id: 320468):
Error Message:ERROR:  column "backend_type" does not exist
LINE 14: backend_type
in dashboard
Request URL:http://127.0.0.1:5050/dashboard/activity/34


Earlier I tested changes only with PG9.4 and PG10, So I missed this issue,
as "backend_type" column only exists in PG10+.
Thanks to Surinder for reporting the issue.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[image: https://community.postgresrocks.net/]


On Fri, Aug 25, 2017 at 9:27 PM, Dave Page  wrote:

> Thanks, patch applied.
>
> On Wed, Aug 9, 2017 at 12:19 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the updated patch with new UI style in dashboard subnode
>> control based on Chethana's design suggestion.
>>
>> @Shirley,
>> Yes, DBA needs to click on the drop down to expand.
>> - If we make whole row clickable then how are we going to identify if
>> user is trying to expand the row or trying to cancel the active session? I
>> am asking this because table row  tag comes before table column tag
>>  in HTML DOM, so if we have click event listers on both of the tags
>> then how are we going to differentiate the user operation?
>> - In my opinion, another reason we can not do that on a dashboard grid
>> because it will break the subnode control consistency, If user sees that
>> grid expands on clicking the row they will expect the same behaviour in
>> other grids as well.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> 
>>
>> On Tue, Aug 8, 2017 at 7:47 PM, Shirley Wang  wrote:
>>
>>> Nice!
>>>
>>> Would a DBA need to click on the drop down to expand? I think that drop
>>> down icon might be too small. Perhaps the whole row could be a clickable
>>> area to show further details. This is a good thing to test with some people
>>>
>>>
>>> On Aug 8, 2017, at 12:52, Ashesh Vashi 
>>> wrote:
>>>
>>> On Mon, Aug 7, 2017 at 9:06 PM, Dave Page  wrote:
>>>


 On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar <
 chethana.ku...@enterprisedb.com> wrote:

> Hi Dave,
>
> Could you comment on the new design update for subnode control ?
>
> Attached designs -
>
> 1. subnode_current.png -  The existing view
> 2. subnode_new.png - The updated view
> 3. current_new.png - Existing and new design placed together for
> comparison purpose
>
> Below changes done -
>
> 1. Reduced number of gray color variations
> 2. Made more simplified by removing unwanted borders
> 3. Merged "Arrow Down" background and the body background for more
> clarity
>
> Please feel free to provide your input on the same.
>

 Much nicer in my opinion! Good work.

 Anyone else have any comments?

>>> It looks much nicer.
>>> I would like to see the effect on another dialogs like 'Table
>>> properties', where we have multiple level of subgrid controls with tabs.
>>>
>>> -- Thanks, Ashesh
>>>


>
> Regards,
> Chethana kumar
>
>
>
> On Fri, Jul 28, 2017 at 4:11 PM, Dave Page  wrote:
>
>> Hi
>>
>> I took a quick look at this and have a couple of thoughts:
>>
>> - Instead of the "edit" icon to open the subnode, we should use
>> something more appropriate - a "properties" icon perhaps.
>>
>> - There seems to be a lot of different shades of grey on there (maybe
>> a subnode design in general that just shows up with the disabled 
>> controls),
>> and the subnode control looks a bit messy as a result.
>>
>> Can you work with Chethana to improve the look and feel please?
>>
>> Input from others welcome of course - screenshot attached.
>>
>> Thanks.
>>
>> On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> ++ Attaching the patch
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 PFA patch to display additional information from pg_stat_activity
 table using subnode control.
 RM#2597

 Please review.

 --
 Regards,
 Murtuza Zabuawa