date:20170726

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-26 Thread Murtuza Zabuawala

Hi Dave,

Please find updated patch for new shortcut keys, I have tested it on all
three major platforms (macOS, Linux & Windows with Chrome, FF & IE11
Browsers).

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 21, 2017 at 9:38 PM, Robert Eckhardt 
wrote:

> Right - we lose the ability to uncomment multiple levels though, which may
>> also be useful.
>>
>
> Well yes.
>
> I would argue that simplicity trumps potential use. I'd also argue that
> attempting to maintain consistency across environments (IDEs, etc. ) is
> advantageous. This was the philosophy we were going with when enabling
> excel like behavior (also why I'm not fully happy with how it is today).
>
> -- Rob
>
diff --git a/docs/en_US/keyboard_shortcuts.rst 
b/docs/en_US/keyboard_shortcuts.rst
index cd0938d..32f06f0 100644
--- a/docs/en_US/keyboard_shortcuts.rst
+++ b/docs/en_US/keyboard_shortcuts.rst
@@ -41,11 +41,11 @@ When using the syntax-highlighting SQL editors, the 
following shortcuts are avai
 
+--+--+-+
 | Ctrl+Alt+Right   | Cmd+Option+Right | Move right one word
 |
 
+--+--+-+
-| Ctrl+Shift+, | Ctrl+Shift+, | Comment selected code (Inline) 
 |
+| Ctrl+Shift+/ | Cmd+Shift+/  | Comment selected code (Inline) 
 |
 
+--+--+-+
-| Ctrl+Shift+. | Ctrl+Shift+. | Uncomment selected code 
(Inline)|
+| Ctrl+Shift+. | Cmd+Shift+.  | Uncomment selected code 
(Inline)|
 
+--+--+-+
-| Ctrl+Shift+/ | Ctrl+Shift+/ | Comment/Uncomment code (Block) 
 |
+| Ctrl+/   | Cmd+/| Comment/Uncomment code (Block) 
 |
 
+--+--+-+
 | Ctrl+A   | Cmd+A| Select all 
 |
 
+--+--+-+
diff --git a/web/pgadmin/static/js/sqleditor/keyboard_shortcuts.js 
b/web/pgadmin/static/js/sqleditor/keyboard_shortcuts.js
index c117413..5d947d1 100644
--- a/web/pgadmin/static/js/sqleditor/keyboard_shortcuts.js
+++ b/web/pgadmin/static/js/sqleditor/keyboard_shortcuts.js
@@ -1,9 +1,9 @@
 const F5_KEY = 116,
   F7_KEY = 118,
   F8_KEY = 119,
-  COMMA_KEY = 188,
   PERIOD_KEY = 190,
-  FWD_SLASH_KEY = 191;
+  FWD_SLASH_KEY = 191,
+  IS_CMD_KEY = window.navigator.platform.search('Mac') != -1;
 
 function keyboardShortcuts(sqlEditorController, event) {
   if (sqlEditorController.isQueryRunning()) {
@@ -24,13 +24,16 @@ function keyboardShortcuts(sqlEditorController, event) {
   } else if (keyCode === F8_KEY) {
 event.preventDefault();
 sqlEditorController.download();
-  } else if (event.shiftKey && event.ctrlKey && keyCode === COMMA_KEY) {
+  } else if (((IS_CMD_KEY && event.metaKey) || (!IS_CMD_KEY && event.ctrlKey)) 
&&
+ event.shiftKey && keyCode === FWD_SLASH_KEY) {
 _stopEventPropagation();
 sqlEditorController.commentLineCode();
-  } else if (event.shiftKey && event.ctrlKey && keyCode === PERIOD_KEY) {
+  } else if (((IS_CMD_KEY && event.metaKey) || (!IS_CMD_KEY && event.ctrlKey)) 
&&
+ event.shiftKey && keyCode === PERIOD_KEY) {
 _stopEventPropagation();
 sqlEditorController.uncommentLineCode();
-  } else if (event.shiftKey && event.ctrlKey && keyCode === FWD_SLASH_KEY) {
+  } else if (((IS_CMD_KEY && event.metaKey) || (!IS_CMD_KEY && event.ctrlKey)) 
&&
+ keyCode === FWD_SLASH_KEY) {
 _stopEventPropagation();
 sqlEditorController.commentBlockCode();
   }
diff --git a/web/pgadmin/tools/datagrid/__init__.py 
b/web/pgadmin/tools/datagrid/__init__.py
index 08b01ab..d3a4a9d 100644
--- a/web/pgadmin/tools/datagrid/__init__.py
+++ b/web/pgadmin/tools/datagrid/__init__.py
@@ -15,6 +15,7 @@ import pickle
 import random
 
 from flask import Response, url_for, session, request, make_response
+from werkzeug.useragents import UserAgent
 from flask import current_app as app
 from flask_babel import gettext
 from flask_security import login_required
@@ -183,6 +184,9 @@ def panel(trans_id, is_query_tool, editor_title):
 else:
 sURL = None
 
+# We need client OS information to render correct Keyboard shortcuts
+user_agent = UserAgent(request.headers.get('User-Agent'))
+
 """
 Animations and transitions are not automatically GPU accelerated and by 
default use browser's slow rendering engine.
 We need to set 'translate3d' value of '-webkit-transform' property in 
order to use GPU.
@@ -212,7 +216,8 @@ def panel(trans_id, is_query_tool, editor_title):
 editor_title=editor_title,

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

2017-07-26 Thread Harshal Dhumal

Hi,

On Mon, Jul 24, 2017 at 4:23 PM, Dave Page  wrote:

> Hi
>
> On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch to set default layout of file listing as a
>> list in file manager.
>> Also replaced alertify with out custom alertifywrapper in file manager
>> utils.js
>>
>
> This isn't a bad idea on the face of it, but there are some things to
> fix/consider:
>
> - The HTML file seems to be missing translation markers. Can you add them
> throughout please?
> - We should save the users preference in the config database.
> - The grid view seems to underline the file size and for no apparent
> reason change the mouse cursor to ? on mouseover. Let's change the text
> style to be consistent and get rid of the mouseover.
>
Please find updated patch


>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/misc/file_manager/__init__.py b/web/pgadmin/misc/file_manager/__init__.py
index 5d7ef93..81c9041 100644
--- a/web/pgadmin/misc/file_manager/__init__.py
+++ b/web/pgadmin/misc/file_manager/__init__.py
@@ -26,6 +26,7 @@ from flask_security import login_required
 from pgadmin.utils import PgAdminModule
 from pgadmin.utils import get_storage_directory
 from pgadmin.utils.ajax import make_json_response
+from pgadmin.utils.preferences import Preferences
 
 # Checks if platform is Windows
 if _platform == "win32":
@@ -172,6 +173,13 @@ class FileManagerModule(PgAdminModule):
 gettext("Last directory visited"), 'text', '/',
 category_label=gettext('Options')
 )
+self.grid_layout_view = self.preference.register(
+'options', 'grid_layout_view',
+gettext("Grid layout view"), 'options', 'list',
+category_label=gettext('Options'),
+options=[{'label': gettext('List'), 'value': 'list'},
+ {'label': gettext('Grid'), 'value': 'grid'}]
+)
 
 
 # Initialise the module
@@ -232,9 +240,13 @@ def file_manager_config(trans_id):
 """render the required json"""
 # trans_id = Filemanager.create_new_transaction()
 data = Filemanager.get_trasaction_selection(trans_id)
+pref = Preferences.module('file_manager')
+grid_layout_view = pref.preference('grid_layout_view').get()
+
 return Response(response=render_template(
 "file_manager/js/file_manager_config.json", _=gettext,
-data=data),
+data=data,
+grid_layout_view=grid_layout_view),
 status=200,
 mimetype="application/json")
 
diff --git a/web/pgadmin/misc/file_manager/templates/file_manager/index.html b/web/pgadmin/misc/file_manager/templates/file_manager/index.html
index 1933895..e0341ee 100755
--- a/web/pgadmin/misc/file_manager/templates/file_manager/index.html
+++ b/web/pgadmin/misc/file_manager/templates/file_manager/index.html
@@ -6,9 +6,9 @@
 
 
 
-
+
 
-
 
 
@@ -17,17 +17,17 @@
 
 
 
-
-
+
+
 
-
+
 
-
+
 
-
-
-
+
+
 
 
 
@@ -39,17 +39,17 @@
 
 
 
-Are you sure you want to delete this item ?
+{{ _('Are you sure you want to delete this item ?') }}
 
-  YES
-  NO
+  {{ _('YES') }}
+  {{ _('NO') }}
 
 
 
-Are you sure you want to replace this file ?
+{{ _('Are you sure you want to replace this file?') }}
 
-  YES
-  NO
+  {{ _('YES') }}
+  {{ _('NO') }}
 
 
 
diff --git a/web/pgadmin/misc/file_manager/templates/file_manager/js/file_manager_config.json b/web/pgadmin/misc/file_manager/templates/file_manager/js/file_manager_config.json
index f74430d..ed8efcf 100644
--- a/web/pgadmin/misc/file_manager/templates/file_manager/js/file_manager_config.json
+++ b/web/pgadmin/misc/file_manager/templates/file_manager/js/file_manager_config.json
@@ -2,7 +2,7 @@
  "options": {
   "culture": "en",
   "lang": "py",
-  "defaultViewMode": "grid",
+  "defaultViewMode": "{{grid_layout_view}}",
   "autoload": true,
   "showFullPath": false,
   "dialog_type": "{{data.dialog_type}}",
diff --git a/web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js b/web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js
index fd8f25c..2d3fcdd 100755
--- a/web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js
+++ b/web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js
@@ -668,8 +668,8 @@ var getFolderInfo = function(path, file_type) {
 file_

pgAdmin 4 commit: Update keyboard shortcuts per discussion. Also, make

2017-07-26 Thread Dave Page

Update keyboard shortcuts per discussion. Also, make the labels platform 
sensitive.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fa9648a21c980c6ecdd5d87da64783b19dfab73
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/keyboard_shortcuts.rst  | 12 
.../static/js/sqleditor/keyboard_shortcuts.js  | 13 
web/pgadmin/tools/datagrid/__init__.py |  7 -
.../tools/datagrid/templates/datagrid/index.html   | 35 +-
4 files changed, 47 insertions(+), 20 deletions(-)

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-26 Thread Dave Page

Thanks, applied. I also extended the code you added to ensure the labels
for the Find/Replace options are now platform-correct.

On Wed, Jul 26, 2017 at 10:29 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find updated patch for new shortcut keys, I have tested it on all
> three major platforms (macOS, Linux & Windows with Chrome, FF & IE11
> Browsers).
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Jul 21, 2017 at 9:38 PM, Robert Eckhardt 
> wrote:
>
>> Right - we lose the ability to uncomment multiple levels though, which
>>> may also be useful.
>>>
>>
>> Well yes.
>>
>> I would argue that simplicity trumps potential use. I'd also argue that
>> attempting to maintain consistency across environments (IDEs, etc. ) is
>> advantageous. This was the philosophy we were going with when enabling
>> excel like behavior (also why I'm not fully happy with how it is today).
>>
>> -- Rob
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Handle control visibility properly in javascript stri

2017-07-26 Thread Dave Page

Handle control visibility properly in javascript strict mode.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1e7254fbd361f4e73ecfd9b0fa2fa69ad9820c5
Author: Khushboo Vashi 

Modified Files
--
.../servers/roles/templates/role/js/role.js|  4 ++--
web/pgadmin/static/js/backform.pgadmin.js  | 22 +++---
2 files changed, 13 insertions(+), 13 deletions(-)

Re: [pgAdmin4][Patch]: Backform control visibility fix

2017-07-26 Thread Dave Page

Thanks, applied.

On Tue, Jul 25, 2017 at 1:18 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to handle the control visibility even in
> the javascript strict mode.
>
> Thanks,
> Khushboo
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python26 #386

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Update keyboard shortcuts per discussion. Also, make the labels 
platform

--
[...truncated 357.97 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.953 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.958 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.964 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.969 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.974 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.979 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.988 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.993 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 
1.997 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
2.002 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 
2.007 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
2.012 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
2.017 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 
2.022 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
2.027 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.033 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.037 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.042 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.078 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.082 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.116 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.142 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.166 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.195 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.219 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.248 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.27 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.29 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.311 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.331 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.351 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.37 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 
2.414 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.435 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.456 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.476 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.492 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.508 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.531 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.546 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.587 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.607 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.624 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.644 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.663 secs)
[33m26 07 2017 11:58:03.312:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 11:58:03.326:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.68 secs)
[33m26 07 2017 11:58:03.342:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.694 secs)
[33m26 07 2017 11:58:03.361:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 106 of 254 SUCCESS (0 secs / 
2.715 secs)
[33m26 07 2017 11:58:03.377:WARN [web-se

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

2017-07-26 Thread Murtuza Zabuawala

Looking into it.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 26, 2017 at 5:28 PM, pgAdmin 4 Jenkins 
wrote:

> See  386/display/redirect?page=changes>
>
> Changes:
>
> [Dave Page] Update keyboard shortcuts per discussion. Also, make the
> labels platform
>
> --
> [...truncated 357.97 KB...]
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs
> / 1.953 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs
> / 1.958 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs
> / 1.964 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs
> / 1.969 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs
> / 1.974 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs
> / 1.979 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs
> / 1.988 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs
> / 1.993 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs
> / 1.997 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs
> / 2.002 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs
> / 2.007 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs
> / 2.012 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs
> / 2.017 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs
> / 2.022 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs
> / 2.027 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs
> / 2.033 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs
> / 2.037 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs
> / 2.042 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs
> / 2.078 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs
> / 2.082 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs
> / 2.116 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs
> / 2.142 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs
> / 2.166 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs
> / 2.195 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs
> / 2.219 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs
> / 2.248 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs
> / 2.27 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs
> / 2.29 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs
> / 2.311 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs
> / 2.331 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs
> / 2.351 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs
> / 2.37 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs
> / 2.414 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs
> / 2.435 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs
> / 2.456 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs
> / 2.476 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs
> / 2.492 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs
> / 2.508 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs
> / 2.531 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs
> / 2.546 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs
> / 2.587 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs
> / 2.607 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs
> / 2.624 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs
> / 2.644 secs)
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs
> / 2.663 secs)
>  [33m26 07 2017 11:58:03.312:WARN [web-server]:  [39m404:
> /base/pgadmin/static/img/select-all-icon.png
>  [33m26 07 2017 11:58:03.326:WARN [web-server]:  [39m404:
> /base/pgadmin/static/img/select-all-icon.png
>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs
> / 2.68 secs)
>  [33m26 07 2017 11:58:03.342:WARN [web-server]:  [39m404:
> /base/pgadmin/static/i

Build failed in Jenkins: pgadmin4-master-python34 #256

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Update keyboard shortcuts per discussion. Also, make the labels 
platform

[Dave Page] Handle control visibility properly in javascript strict mode.

--
[...truncated 354.16 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.956 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.961 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.966 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.971 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.976 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.981 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.99 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.995 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 2 
secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
2.005 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 
2.01 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
2.015 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
2.02 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 
2.024 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
2.029 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.034 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.039 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.044 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.08 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.085 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.119 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.145 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.168 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.197 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.247 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.278 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.299 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.316 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.334 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.353 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.368 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.384 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 
2.399 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.415 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.431 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.45 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.465 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.481 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.497 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.513 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.553 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.573 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.59 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.61 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.628 secs)
[33m26 07 2017 12:04:25.053:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 12:04:25.068:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.645 secs)
[33m26 07 2017 12:04:25.083:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.66 secs)
[33m26 07 2017 12:04:25.102:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 106 of 254 SUCCE

pgAdmin 4 commit: Default the file browser view to list, and make it co

2017-07-26 Thread Dave Page

Default the file browser view to list, and make it configurable. Fixes #2579

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=97cd74a3737aed12bd5d73905018752923b4bc98
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/misc/file_manager/__init__.py  | 14 +-
.../file_manager/templates/file_manager/index.html | 30 +++---
.../file_manager/js/file_manager_config.json   |  2 +-
.../templates/file_manager/js/utility.js   |  6 ++---
4 files changed, 32 insertions(+), 20 deletions(-)

Build failed in Jenkins: pgadmin4-master-python33 #265

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Update keyboard shortcuts per discussion. Also, make the labels 
platform

[Dave Page] Handle control visibility properly in javascript strict mode.

--
[...truncated 354.19 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.937 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.942 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.947 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.952 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.957 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.962 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.971 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.976 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 
1.981 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
1.986 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 
1.991 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
1.996 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
2.001 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 
2.006 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
2.012 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.018 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.022 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.026 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.062 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.067 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.101 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.127 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.151 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.18 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.203 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.231 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.253 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.273 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.294 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.313 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.333 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.352 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 
2.37 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.39 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.411 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.434 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.453 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.473 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.521 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.542 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.585 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.607 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.632 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.652 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.67 secs)
[33m26 07 2017 12:11:01.451:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 12:11:01.466:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.687 secs)
[33m26 07 2017 12:11:01.481:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.701 secs)
[33m26 07 2017 12:11:01.501:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 106 of 2

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

2017-07-26 Thread Dave Page

On Wed, Jul 26, 2017 at 11:06 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> On Mon, Jul 24, 2017 at 4:23 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch to set default layout of file listing as a
>>> list in file manager.
>>> Also replaced alertify with out custom alertifywrapper in file manager
>>> utils.js
>>>
>>
>> This isn't a bad idea on the face of it, but there are some things to
>> fix/consider:
>>
>> - The HTML file seems to be missing translation markers. Can you add them
>> throughout please?
>> - We should save the users preference in the config database.
>> - The grid view seems to underline the file size and for no apparent
>> reason change the mouse cursor to ? on mouseover. Let's change the text
>> style to be consistent and get rid of the mouseover.
>>
> Please find updated patch
>

Thanks, committed with some naming tweaks... however, I do think the
setting should be updated when the user toggles it within the file
dialogue. Can you add code to set that config option when the user toggles
the mode on the fly please?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python36 #261

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Update keyboard shortcuts per discussion. Also, make the labels 
platform

[Dave Page] Handle control visibility properly in javascript strict mode.

[Dave Page] Default the file browser view to list, and make it configurable. 
Fixes

--
[...truncated 354.08 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.948 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.953 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.958 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.963 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.967 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.972 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.981 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.986 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 
1.991 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
1.995 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 2 
secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
2.005 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
2.01 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 
2.015 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
2.02 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.026 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.03 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.035 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.071 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.076 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.111 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.137 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.161 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.19 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.213 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.242 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.264 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.309 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.331 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.351 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.368 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.385 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 2.4 
secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.421 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.437 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.456 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.471 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.487 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.504 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.519 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.559 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.579 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.596 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.616 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.634 secs)
[33m26 07 2017 12:17:18.932:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 12:17:18.946:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.651 secs)
[33m26 07 2017 12:17:18.961:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.665 secs)
[33m26 07 2017 12:17:18.981:WARN [web-server]: [39m404: 
/base/pgadmin/static/i

Build failed in Jenkins: pgadmin4-master-python35 #265

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Update keyboard shortcuts per discussion. Also, make the labels 
platform

[Dave Page] Handle control visibility properly in javascript strict mode.

[Dave Page] Default the file browser view to list, and make it configurable. 
Fixes

--
[...truncated 354.25 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.932 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.936 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.941 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.946 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.951 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.956 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.965 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.97 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 
1.975 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
1.98 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 
1.985 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
1.99 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
1.995 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 2 
secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
2.006 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.012 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.017 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.022 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.059 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.064 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.098 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.124 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.148 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.177 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.201 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.229 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.251 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.271 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.292 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.312 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.332 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.352 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 
2.371 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.391 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.412 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.462 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.483 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.503 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.52 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.536 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.584 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.604 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.62 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.641 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.659 secs)
[33m26 07 2017 12:23:33.220:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 12:23:33.234:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.677 secs)
[33m26 07 2017 12:23:33.249:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.691 secs)
[33m26 07 2017 12:23:33.269:WARN [web-server]: [39m404: 
/base/pgadmin/static/

Build failed in Jenkins: pgadmin4-master-python27 #266

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Update keyboard shortcuts per discussion. Also, make the labels 
platform

[Dave Page] Handle control visibility properly in javascript strict mode.

[Dave Page] Default the file browser view to list, and make it configurable. 
Fixes

--
[...truncated 355.04 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.925 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.93 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.935 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.94 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.945 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.95 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.959 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.964 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 
1.969 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
1.974 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 
1.979 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
1.984 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
1.989 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 
1.994 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
1.999 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.005 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.009 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.013 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.049 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.054 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.088 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.114 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.137 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.166 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.214 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.243 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.264 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.281 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.299 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.314 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.331 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.346 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 
2.36 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.375 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.392 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.411 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.426 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.442 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.458 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.473 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.513 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.533 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.549 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.569 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.587 secs)
[33m26 07 2017 12:29:47.435:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 12:29:47.451:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.605 secs)
[33m26 07 2017 12:29:47.467:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.619 secs)
[33m26 07 2017 12:29:47.486:WARN [web-server]: [39m404: 
/base/pgadmin/st

Build failed in Jenkins: pgadmin4-master-python26 #387

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Handle control visibility properly in javascript strict mode.

[Dave Page] Default the file browser view to list, and make it configurable. 
Fixes

--
[...truncated 358.11 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.959 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.964 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.97 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.975 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.98 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.985 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.994 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.999 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 
2.004 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
2.009 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 
2.014 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
2.019 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
2.024 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 
2.029 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
2.035 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.041 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.045 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.049 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.085 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.09 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.124 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.15 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.174 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.203 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.227 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.256 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.278 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.298 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.319 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.339 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.359 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.378 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 
2.396 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.415 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.436 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.46 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.48 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.527 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.549 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.569 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.61 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.64 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.657 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.678 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.696 secs)
[33m26 07 2017 12:35:40.728:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 12:35:40.743:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.713 secs)
[33m26 07 2017 12:35:40.758:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.727 secs)
[33m26 07 2017 12:35:40.778:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 106 of 254 SUC

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

2017-07-26 Thread Murtuza Zabuawala

Hi Dave,

Please find a patch to fix the JS tests.

FYI, I have removed the labels like 'Shift+CTRL+/' from test instead used '
inlineComment' because key shortcuts are different based on platform.

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 26, 2017 at 5:32 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Looking into it.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jul 26, 2017 at 5:28 PM, pgAdmin 4 Jenkins 
> wrote:
>
>> See > 6/display/redirect?page=changes>
>>
>> Changes:
>>
>> [Dave Page] Update keyboard shortcuts per discussion. Also, make the
>> labels platform
>>
>> --
>> [...truncated 357.97 KB...]
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs
>> / 1.953 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs
>> / 1.958 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs
>> / 1.964 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs
>> / 1.969 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs
>> / 1.974 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs
>> / 1.979 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs
>> / 1.988 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs
>> / 1.993 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs
>> / 1.997 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs
>> / 2.002 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs
>> / 2.007 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs
>> / 2.012 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs
>> / 2.017 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs
>> / 2.022 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs
>> / 2.027 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs
>> / 2.033 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs
>> / 2.037 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs
>> / 2.042 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs
>> / 2.078 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs
>> / 2.082 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs
>> / 2.116 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs
>> / 2.142 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs
>> / 2.166 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs
>> / 2.195 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs
>> / 2.219 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs
>> / 2.248 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs
>> / 2.27 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs
>> / 2.29 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs
>> / 2.311 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs
>> / 2.331 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs
>> / 2.351 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs
>> / 2.37 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs
>> / 2.414 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs
>> / 2.435 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs
>> / 2.456 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs
>> / 2.476 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs
>> / 2.492 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs
>> / 2.508 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs
>> / 2.531 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs
>> / 2.546 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs
>> / 2.587 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0
>> secs / 2.607 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0
>> secs / 2.624 secs)
>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0):

Build failed in Jenkins: pgadmin4-master-python34 #257

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Default the file browser view to list, and make it configurable. 
Fixes

--
[...truncated 354.25 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.93 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.935 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.94 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.945 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.95 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.955 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.964 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.969 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 
1.974 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
1.979 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 
1.984 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
1.988 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
1.993 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 
1.997 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
2.002 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.007 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.012 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.017 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.053 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.058 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.092 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.117 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.141 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.169 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.192 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.22 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.242 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.285 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.306 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.324 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.341 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.357 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 
2.372 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.393 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.41 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.429 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.444 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.46 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.476 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.491 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.532 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.552 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.568 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.589 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.607 secs)
[33m26 07 2017 12:42:03.674:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 12:42:03.689:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.625 secs)
[33m26 07 2017 12:42:03.705:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.639 secs)
[33m26 07 2017 12:42:03.724:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 106 of 254 SUCCESS (0 secs / 
2.66 secs)
[33m26 07 2017 12:42:03.740:WARN [web-server]

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

2017-07-26 Thread Dave Page

Thanks, applied.

On Wed, Jul 26, 2017 at 1:40 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find a patch to fix the JS tests.
>
> FYI, I have removed the labels like 'Shift+CTRL+/' from test instead used
> 'inlineComment' because key shortcuts are different based on platform.
>
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jul 26, 2017 at 5:32 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Looking into it.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, Jul 26, 2017 at 5:28 PM, pgAdmin 4 Jenkins 
>> wrote:
>>
>>> See >> 6/display/redirect?page=changes>
>>>
>>> Changes:
>>>
>>> [Dave Page] Update keyboard shortcuts per discussion. Also, make the
>>> labels platform
>>>
>>> --
>>> [...truncated 357.97 KB...]
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0
>>> secs / 1.953 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0
>>> secs / 1.958 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0
>>> secs / 1.964 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0
>>> secs / 1.969 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0
>>> secs / 1.974 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0
>>> secs / 1.979 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0
>>> secs / 1.988 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0
>>> secs / 1.993 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0
>>> secs / 1.997 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0
>>> secs / 2.002 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0
>>> secs / 2.007 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0
>>> secs / 2.012 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0
>>> secs / 2.017 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0
>>> secs / 2.022 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0
>>> secs / 2.027 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0
>>> secs / 2.033 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0
>>> secs / 2.037 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0
>>> secs / 2.042 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0
>>> secs / 2.078 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0
>>> secs / 2.082 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0
>>> secs / 2.116 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0
>>> secs / 2.142 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0
>>> secs / 2.166 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0
>>> secs / 2.195 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0
>>> secs / 2.219 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0
>>> secs / 2.248 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0
>>> secs / 2.27 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0
>>> secs / 2.29 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0
>>> secs / 2.311 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0
>>> secs / 2.331 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0
>>> secs / 2.351 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0
>>> secs / 2.37 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0
>>> secs / 2.414 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0
>>> secs / 2.435 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0
>>> secs / 2.456 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0
>>> secs / 2.476 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0
>>> secs / 2.492 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0
>>> secs / 2.508 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0
>>> secs / 2.531 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0
>>> secs / 2.546 secs)
>>>  [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0
>>> secs / 2.587 secs)
>>>  [

pgAdmin 4 commit: Fixup tests following label changes.

2017-07-26 Thread Dave Page

Fixup tests following label changes.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af26d983e5e20c64f0f73d22ebd998f54dff1e8a
Author: Murtuza Zabuawala 

Modified Files
--
.../sqleditor/keyboard_shortcuts_spec.js   | 37 --
1 file changed, 20 insertions(+), 17 deletions(-)

Build failed in Jenkins: pgadmin4-master-python33 #266

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Default the file browser view to list, and make it configurable. 
Fixes

--
[...truncated 354.28 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs / 
1.933 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs / 
1.938 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs / 
1.943 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs / 
1.947 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs / 
1.952 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs / 
1.957 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs / 
1.966 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs / 
1.971 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs / 
1.976 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs / 
1.981 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs / 
1.986 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs / 
1.991 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs / 
1.995 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs / 2 
secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs / 
2.005 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs / 
2.01 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs / 
2.015 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs / 
2.02 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs / 
2.056 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs / 
2.061 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs / 
2.096 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs / 
2.122 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs / 
2.145 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs / 
2.174 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs / 
2.198 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs / 
2.227 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs / 
2.249 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs / 
2.294 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs / 
2.315 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs / 
2.333 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs / 
2.35 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs / 
2.366 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs / 
2.381 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs / 
2.402 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs / 
2.419 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs / 
2.438 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs / 
2.454 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs / 
2.47 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs / 
2.487 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs / 
2.502 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs / 
2.542 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0 secs / 
2.562 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0 secs / 
2.578 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0 secs / 
2.599 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0 secs / 
2.617 secs)
[33m26 07 2017 12:48:37.962:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[33m26 07 2017 12:48:37.977:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0 secs / 
2.635 secs)
[33m26 07 2017 12:48:37.992:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0 secs / 
2.649 secs)
[33m26 07 2017 12:48:38.012:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 106 of 254 SUCCESS (0 secs / 
2.67 secs)
[33m26 07 2017 12:48:38.028:WARN [web-server]:

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

2017-07-26 Thread Harshal Dhumal

Hi Dave,

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 26, 2017 at 5:41 PM, Dave Page  wrote:

>
>
> On Wed, Jul 26, 2017 at 11:06 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Mon, Jul 24, 2017 at 4:23 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find attached patch to set default layout of file listing as a
 list in file manager.
 Also replaced alertify with out custom alertifywrapper in file manager
 utils.js

>>>
>>> This isn't a bad idea on the face of it, but there are some things to
>>> fix/consider:
>>>
>>> - The HTML file seems to be missing translation markers. Can you add
>>> them throughout please?
>>> - We should save the users preference in the config database.
>>> - The grid view seems to underline the file size and for no apparent
>>> reason change the mouse cursor to ? on mouseover. Let's change the text
>>> style to be consistent and get rid of the mouseover.
>>>
>> Please find updated patch
>>
>
> Thanks, committed with some naming tweaks... however, I do think the
> setting should be updated when the user toggles it within the file
> dialogue. Can you add code to set that config option when the user toggles
> the mode on the fly please?
>
Yes... and patch attached.


>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/misc/file_manager/__init__.py b/web/pgadmin/misc/file_manager/__init__.py
index 3d4fb53..843ec61 100644
--- a/web/pgadmin/misc/file_manager/__init__.py
+++ b/web/pgadmin/misc/file_manager/__init__.py
@@ -155,7 +155,8 @@ class FileManagerModule(PgAdminModule):
 'file_manager.index',
 'file_manager.get_trans_id',
 'file_manager.delete_trans_id',
-'file_manager.save_last_dir'
+'file_manager.save_last_dir',
+'file_manager.save_file_dialog_view'
 ]
 
 def get_file_size_preference(self):
@@ -288,6 +289,17 @@ def save_last_directory_visited(trans_id):
 data={'status': True}
 )
 
+@blueprint.route(
+"/save_file_dialog_view/", methods=["POST"],
+endpoint='save_file_dialog_view'
+)
+@login_required
+def save_file_dialog_view(trans_id):
+blueprint.file_dialog_view.set(req.json['view'])
+return make_json_response(
+data={'status': True}
+)
+
 
 class Filemanager(object):
 """FileManager Class."""
diff --git a/web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js b/web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js
index 2d3fcdd..4a2754c 100755
--- a/web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js
+++ b/web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js
@@ -60,6 +60,17 @@ var setViewButtonsFor = function(viewMode) {
   }
 };
 
+var save_file_dialog_view = function(view, trans_id) {
+  return $.ajax({
+url: url_for('file_manager.save_file_dialog_view', {'trans_id': trans_id}),
+type: 'POST',
+async: true,
+data: JSON.stringify({'view':view}),
+contentType: 'application/json'
+  });
+};
+
+
 /*
  * preg_replace
  */
@@ -1066,6 +1077,7 @@ pgAdmin.FileUtils = {
 config;
 
 this.fileConnector = fileConnector;
+this.transId = t_id;
 // load user configuration file
 if (cfg.readyState == 4) {
   this.config = config = JSON.parse(cfg.responseText);
@@ -1235,6 +1247,7 @@ pgAdmin.FileUtils = {
   $('.fileinfo').data('view', 'grid');
   enable_disable_btn();
   getFolderInfo($('.currentpath').val());
+  save_file_dialog_view('grid', pgAdmin.FileUtils.transId);
 });
 
 // Show list mode
@@ -1243,6 +1256,7 @@ pgAdmin.FileUtils = {
   $('.fileinfo').data('view', 'list');
   enable_disable_btn();
   getFolderInfo($('.currentpath').val());
+  save_file_dialog_view('list', pgAdmin.FileUtils.transId);
 });
 
 // Provide initial values for upload form, status, etc.

Jenkins build is back to normal : pgadmin4-master-python26 #388

2017-07-26 Thread pgAdmin 4 Jenkins

See

Build failed in Jenkins: pgadmin4-master-python36 #262

2017-07-26 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Fixup tests following label changes.

--
[...truncated 335.79 KB...]
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ViewsAddTestCase (Add materialized view under schema node)
ViewsDeleteTestCase (Delete materialized view under schema node)
ViewsGetTestCase (Get materialized view under schema node)
ViewsUpdateTestCase (Update materialized view under schema node)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.3:

157 tests passed
0 tests failed
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.4:

156 tests passed
1 test failed:
FtsParserGetTestCase (Fetch FTS parser Node URL)
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL

Jenkins build is back to normal : pgadmin4-master-python34 #258

2017-07-26 Thread pgAdmin 4 Jenkins

See

Jenkins build is back to normal : pgadmin4-master-python33 #267

2017-07-26 Thread pgAdmin 4 Jenkins

See

Jenkins build is back to normal : pgadmin4-master-python27 #267

2017-07-26 Thread pgAdmin 4 Jenkins

See

pgAdmin 4 commit: Store the file dialog view on toggle.

2017-07-26 Thread Dave Page

Store the file dialog view on toggle.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=831c614a60725fb5cc116ee06bdea7bb477d1f2c
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/misc/file_manager/__init__.py  | 14 +-
.../misc/file_manager/templates/file_manager/js/utility.js | 14 ++
2 files changed, 27 insertions(+), 1 deletion(-)

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

2017-07-26 Thread Dave Page

Awesome - thanks, committed.

On Wed, Jul 26, 2017 at 1:56 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi Dave,
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jul 26, 2017 at 5:41 PM, Dave Page  wrote:
>
>>
>>
>> On Wed, Jul 26, 2017 at 11:06 AM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> On Mon, Jul 24, 2017 at 4:23 PM, Dave Page  wrote:
>>>
 Hi

 On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch to set default layout of file listing as a
> list in file manager.
> Also replaced alertify with out custom alertifywrapper in file manager
> utils.js
>

 This isn't a bad idea on the face of it, but there are some things to
 fix/consider:

 - The HTML file seems to be missing translation markers. Can you add
 them throughout please?
 - We should save the users preference in the config database.
 - The grid view seems to underline the file size and for no apparent
 reason change the mouse cursor to ? on mouseover. Let's change the text
 style to be consistent and get rid of the mouseover.

>>> Please find updated patch
>>>
>>
>> Thanks, committed with some naming tweaks... however, I do think the
>> setting should be updated when the user toggles it within the file
>> dialogue. Can you add code to set that config option when the user toggles
>> the mode on the fly please?
>>
> Yes... and patch attached.
>
>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Jenkins build is back to normal : pgadmin4-master-python35 #266

2017-07-26 Thread pgAdmin 4 Jenkins

See

Jenkins build is back to normal : pgadmin4-master-python36 #263

2017-07-26 Thread pgAdmin 4 Jenkins

See

[pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-07-26 Thread Khushboo Vashi

Hi,

Please find the attached patch to fix the RM #2603: Import/Export File
issues.

Fixed Issues:
 1. Couldn't click on the File Control once gets an error
 2. The encoding is not in alphabetical order

Thanks,
Khsuhboo
diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/9.2_plus/get_encodings.sql b/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/9.2_plus/get_encodings.sql
index 7d583b0..e8e531c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/9.2_plus/get_encodings.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/9.2_plus/get_encodings.sql
@@ -6,7 +6,7 @@ SELECT *
 FROM
 (SELECT pg_encoding_to_char(s.i) AS encoding
 FROM (SELECT generate_series(0, 100, 1) as i) s) a
-WHERE encoding != '';
+WHERE encoding != '' ORDER BY encoding;
 
 {#
 -- For future use, Do not delete
diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/default/get_encodings.sql b/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/default/get_encodings.sql
index 0058423..4ef6379 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/default/get_encodings.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/default/get_encodings.sql
@@ -5,7 +5,7 @@
 SELECT * FROM
 (SELECT pg_encoding_to_char(s.i) AS encoding
 FROM (SELECT generate_series(0, 100, 1) as i) s) a
-WHERE encoding != '';
+WHERE encoding != '' ORDER BY encoding;
 
 {#
 -- For future use, Do not delete
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index e3b5b6c..bfad2b4 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -2201,6 +2201,16 @@
 
   // Set selected value into the model
   this.model.set(name, decodeURI(value));
+},
+clearInvalid: function() {
+  Backform.InputControl.prototype.clearInvalid.apply(this, arguments);
+  this.$el.removeClass("pgadmin-file-has-error");
+  return this;
+},
+updateInvalid: function() {
+  Backform.InputControl.prototype.updateInvalid.apply(this, arguments);
+  // Introduce a new class to fix the error icon placement on the control
+  this.$el.addClass("pgadmin-file-has-error");
 }
   });
 
diff --git a/web/pgadmin/static/scss/_backform.overrides.scss b/web/pgadmin/static/scss/_backform.overrides.scss
index 8527880..9c2f41c 100644
--- a/web/pgadmin/static/scss/_backform.overrides.scss
+++ b/web/pgadmin/static/scss/_backform.overrides.scss
@@ -18,4 +18,10 @@
 padding-top: 10px;
 z-index: 1;
   }
-}
\ No newline at end of file
+}
+
+.pgadmin-file-has-error {
+  .pgadmin-controls:before {
+right: 40px !important;
+  }
+}

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-26 Thread Ashesh Vashi

Hi Surinder,

'delete_template_files.patch' is applied any more.
Please send the rebased patches.

I have also noticed in the 'move_js_files_to_static_directory.patch',
couple of modules have two definitions for 'module_use_template_javascript'
method.


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Tue, Jul 25, 2017 at 3:56 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> Please find rebased patches and review.
>
> On Sat, Jul 22, 2017 at 1:03 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Following are the changes in patches attached:
>>
>> 1) Move Javascripts from Templates directory to Static for following
>> modules:
>>  - About
>>  - Browser nodes
>>  - Dashboard
>>  - FileManager
>>  - Vendor/snap.svg
>>  - Preferences
>>  - Settings
>>  - Backup
>>  - Datagrid
>>  - Debugger
>>  - Sqleditor
>>  - Grant Wizard
>>  - Import & Export
>>  - Maintenance
>>  - Restore and
>>  - User Management
>>
>> 2) Generate module JS path references dynamically/ Remove manually
>> written paths.
>> Added a new file 'module_paths.json' which will update with absolute
>> paths to module JS defined in every modules > __init__.py > 'def
>> get_own_javascripts'.
>>
>> When Flask service is started, it accesses the all module javascripts
>> using `current_app.javascripts` which is called inside an route.
>> This call to route is made using Flask's `test_client` and thus those
>> paths are written to `module_paths.json`(in javascript_bundler.py) which is
>> used by webpack.shim.js file.
>>
>> Three patches:
>> 1. Move JS files to static directory
>> 2. Deleted template JS
>> 3. Generate JS paths before app starts
>>
>> These patches needs to be committed separately as deleted files includes
>> in the commit that makes difficult to look for changes through `git log
>> `
>>
>> Please review.
>>
>> Thanks,
>> Surinder
>>
>>
>>
>> On Thu, Jul 20, 2017 at 6:08 PM, Dave Page  wrote:
>>
>>> Thanks, applied.
>>>
>>> On Thu, Jul 20, 2017 at 1:35 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Can you please review this patch please? I guess it was missed as i
 send 2 patches back to back in same email chain.
 Please find inline detailed description of issue.

 On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> The loading icon image is used in FileManager and it is still
> referenced from vendor `aciTree`(which is removed) so it gives 404 not
> found when FileManager is opened from Query tool/Backup utility.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-26 Thread Ashesh Vashi

On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> Hi Surinder,
>
> 'delete_template_files.patch' is applied any more.
> Please send the rebased patches.
>
> I have also noticed in the 'move_js_files_to_static_directory.patch',
> couple of modules have two definitions for 'module_use_template_javascript'
> method.
>
Also - 'module_paths.json' is auto generated, please don't include that in
the patch.

-- Thanks, Ashesh

>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
> On Tue, Jul 25, 2017 at 3:56 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find rebased patches and review.
>>
>> On Sat, Jul 22, 2017 at 1:03 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Following are the changes in patches attached:
>>>
>>> 1) Move Javascripts from Templates directory to Static for following
>>> modules:
>>>  - About
>>>  - Browser nodes
>>>  - Dashboard
>>>  - FileManager
>>>  - Vendor/snap.svg
>>>  - Preferences
>>>  - Settings
>>>  - Backup
>>>  - Datagrid
>>>  - Debugger
>>>  - Sqleditor
>>>  - Grant Wizard
>>>  - Import & Export
>>>  - Maintenance
>>>  - Restore and
>>>  - User Management
>>>
>>> 2) Generate module JS path references dynamically/ Remove manually
>>> written paths.
>>> Added a new file 'module_paths.json' which will update with absolute
>>> paths to module JS defined in every modules > __init__.py > 'def
>>> get_own_javascripts'.
>>>
>>> When Flask service is started, it accesses the all module javascripts
>>> using `current_app.javascripts` which is called inside an route.
>>> This call to route is made using Flask's `test_client` and thus those
>>> paths are written to `module_paths.json`(in javascript_bundler.py) which is
>>> used by webpack.shim.js file.
>>>
>>> Three patches:
>>> 1. Move JS files to static directory
>>> 2. Deleted template JS
>>> 3. Generate JS paths before app starts
>>>
>>> These patches needs to be committed separately as deleted files includes
>>> in the commit that makes difficult to look for changes through `git log
>>> `
>>>
>>> Please review.
>>>
>>> Thanks,
>>> Surinder
>>>
>>>
>>>
>>> On Thu, Jul 20, 2017 at 6:08 PM, Dave Page  wrote:
>>>
 Thanks, applied.

 On Thu, Jul 20, 2017 at 1:35 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi Dave,
>
> Can you please review this patch please? I guess it was missed as i
> send 2 patches back to back in same email chain.
> Please find inline detailed description of issue.
>
> On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> The loading icon image is used in FileManager and it is still
>> referenced from vendor `aciTree`(which is removed) so it gives 404 not
>> found when FileManager is opened from Query tool/Backup utility.
>>
>> Please find attached patch and review.
>>
>> Thanks,
>> Surinder Kumar
>>
>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-26 Thread Surinder Kumar

Ok. I will send rebased patch.

On Thu, Jul 27, 2017 at 10:32 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

>
>
> On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Surinder,
>>
>> 'delete_template_files.patch' is applied any more.
>> Please send the rebased patches.
>>
>> I have also noticed in the 'move_js_files_to_static_directory.patch',
>> couple of modules have two definitions for 'module_use_template_javascript'
>> method.
>>
> Also - 'module_paths.json' is auto generated, please don't include that in
> the patch.
>
> -- Thanks, Ashesh
>
>>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Tue, Jul 25, 2017 at 3:56 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find rebased patches and review.
>>>
>>> On Sat, Jul 22, 2017 at 1:03 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi,

 Following are the changes in patches attached:

 1) Move Javascripts from Templates directory to Static for following
 modules:
  - About
  - Browser nodes
  - Dashboard
  - FileManager
  - Vendor/snap.svg
  - Preferences
  - Settings
  - Backup
  - Datagrid
  - Debugger
  - Sqleditor
  - Grant Wizard
  - Import & Export
  - Maintenance
  - Restore and
  - User Management

 2) Generate module JS path references dynamically/ Remove manually
 written paths.
 Added a new file 'module_paths.json' which will update with absolute
 paths to module JS defined in every modules > __init__.py > 'def
 get_own_javascripts'.

 When Flask service is started, it accesses the all module javascripts
 using `current_app.javascripts` which is called inside an route.
 This call to route is made using Flask's `test_client` and thus those
 paths are written to `module_paths.json`(in javascript_bundler.py) which is
 used by webpack.shim.js file.

 Three patches:
 1. Move JS files to static directory
 2. Deleted template JS
 3. Generate JS paths before app starts

 These patches needs to be committed separately as deleted files
 includes in the commit that makes difficult to look for changes through
 `git log `

 Please review.

 Thanks,
 Surinder



 On Thu, Jul 20, 2017 at 6:08 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Thu, Jul 20, 2017 at 1:35 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Can you please review this patch please? I guess it was missed as i
>> send 2 patches back to back in same email chain.
>> Please find inline detailed description of issue.
>>
>> On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>>
>>> The loading icon image is used in FileManager and it is still
>>> referenced from vendor `aciTree`(which is removed) so it gives 404 not
>>> found when FileManager is opened from Query tool/Backup utility.
>>>
>>> Please find attached patch and review.
>>>
>>> Thanks,
>>> Surinder Kumar
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>
>

[pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

2017-07-26 Thread Khushboo Vashi

Hi,

If we close the Dashboard tab even then the requests don't stop. This is
the regression of web-packing of browser.js file.
Please find the attached patch for the same.

Thanks,
Khushboo
diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/templates/browser/js/browser.js
index c353418..c89cfb8 100644
--- a/web/pgadmin/browser/templates/browser/js/browser.js
+++ b/web/pgadmin/browser/templates/browser/js/browser.js
@@ -222,7 +222,8 @@ define(
 isCloseable: panel.isCloseable,
 isPrivate: panel.isPrivate,
 content: (panel.content) ? panel.content : '',
-events: (panel.events) ? panel.events : ''
+events: (panel.events) ? panel.events : '',
+canHide: (panel.canHide) ? panel.canHide : ''
   })
 }
   });

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

pgAdmin 4 commit: Update keyboard shortcuts per discussion. Also, make

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

pgAdmin 4 commit: Handle control visibility properly in javascript stri

Re: [pgAdmin4][Patch]: Backform control visibility fix

Build failed in Jenkins: pgadmin4-master-python26 #386

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

Build failed in Jenkins: pgadmin4-master-python34 #256

pgAdmin 4 commit: Default the file browser view to list, and make it co

Build failed in Jenkins: pgadmin4-master-python33 #265

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Build failed in Jenkins: pgadmin4-master-python36 #261

Build failed in Jenkins: pgadmin4-master-python35 #265

Build failed in Jenkins: pgadmin4-master-python27 #266

Build failed in Jenkins: pgadmin4-master-python26 #387

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

Build failed in Jenkins: pgadmin4-master-python34 #257

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

pgAdmin 4 commit: Fixup tests following label changes.

Build failed in Jenkins: pgadmin4-master-python33 #266

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Jenkins build is back to normal : pgadmin4-master-python26 #388

Build failed in Jenkins: pgadmin4-master-python36 #262

Jenkins build is back to normal : pgadmin4-master-python34 #258

Jenkins build is back to normal : pgadmin4-master-python33 #267

Jenkins build is back to normal : pgadmin4-master-python27 #267

pgAdmin 4 commit: Store the file dialog view on toggle.

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Jenkins build is back to normal : pgadmin4-master-python35 #266

Jenkins build is back to normal : pgadmin4-master-python36 #263

[pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

Re: [pgAdmin4]: Webpacking of static JS/CSS

Re: [pgAdmin4]: Webpacking of static JS/CSS

Re: [pgAdmin4]: Webpacking of static JS/CSS

[pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

36 matches

Site Navigation

Mail list logo

Footer information