Build failed in Jenkins: pgadmin4-master-python27 #225

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Added support of Declarative Partitioning (Range, List) for 
PostgreSQL

--
[...truncated 477.15 KB...]
TableUpdateTestCase (Update Table)
14 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

156 tests passed
1 test failed:
TableUpdateTestCase (Update Table)
14 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.2:

148 tests passed
1 test failed:
TableUpdateTestCase (Update Table)
22 tests skipped:
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
ViewsGetTestCase (Get materialized view under schema node)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ViewsDeleteTestCase (Delete materialized view under schema node)
SynonymAddTestCase (Default Node URL)
ViewsAddTestCase (Add materialized view under schema node)
PackageGetTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node

pgAdmin 4 commit: Fixed issue by adding extra check for 'relkind' colum

2017-07-07 Thread Akshay Joshi 
Fixed issue by adding extra check for 'relkind' column

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e793413d76a245dfcdb73e37abbf1df6f9676242

Modified Files
--
.../browser/server_groups/servers/databases/schemas/tables/utils.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Build failed in Jenkins: pgadmin4-master-python35 #220

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Added support of Declarative Partitioning (Range, List) for 
PostgreSQL

--
[...truncated 486.42 KB...]
TableUpdateTestCase (Update Table)
2 tests skipped:
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)

PostgreSQL 9.4:

156 tests passed
1 test failed:
TableUpdateTestCase (Update Table)
14 tests skipped:
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageAddTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymAddTestCase (Default Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)

EDB Postgres AS 9.6:

168 tests passed
1 test failed:
TableUpdateTestCase (Update Table)
2 tests skipped:
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)

EDB Postgres AS 9.3:

164 tests passed
1 test failed:
TableUpdateTestCase (Update Table)
6 tests skipped:
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsGetTestCase (Get resource groups)

PostgreSQL 9.5:

156 tests passed
1 test failed:
TableUpdateTestCase (Update Table)
14 tests skipped:
ResourceGroupsDeleteTestCase (Delete resource groups)
Packa

Build failed in Jenkins: pgadmin4-master-python27 #226

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Fixed issue by adding extra check for 'relkind' column

--
[...truncated 471.13 KB...]
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

157 tests passed
0 tests failed
14 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

157 tests passed
0 tests failed
14 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.2:

149 tests passed
0 tests failed
22 tests skipped:
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
ViewsGetTestCase (Get materialized view under schema node)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ViewsDeleteTestCase (Delete materialized view under schema node)
SynonymAddTestCase (Default Node URL)
ViewsAddTestCase (Add materialized view under schema node)
PackageGetTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymGetTestCase (Fetch synon

Build failed in Jenkins: pgadmin4-master-python35 #221

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Fixed issue by adding extra check for 'relkind' column

--
[...truncated 480.48 KB...]
DatabaseAddTestCase (Check Databases Node URL)
TableSpaceDeleteTestCase (Check Tablespace Node)
ViewsAddTestCase (Add view under schema node,
Add materialized view under schema node)
DatabasesUpdateTestCase (Check Databases Node)
TableSpaceAddTestCase (Check Tablespace Node)
TriggersAddTestCase (Add trigger Node URL)
ViewsGetTestCase (Get view under schema node,
Get materialized view under schema node)
LoginRoleAddTestCase (Check Role Node)
TableDeleteTestCase (Delete Table)
LoginRoleDeleteTestCase (Check Role Node)
ViewsDeleteTestCase (Delete materialized view under schema node,
Delete view under schema node)
TableGetTestCase (Fetch table Node URL)
LoginRoleGetTestCase (Check Role Node)
SchemaGetTestCase (Check Schema Node URL)
DatabasesGetTestCase (Check Databases Node URL)
ViewsUpdateTestCase (Update view under schema node,
Update materialized view under schema 
node)
TriggersGetTestCase (Fetch trigger Node URL)
TablespaceGetTestCase (Check Tablespace Node)
TypesUpdateTestCase (Update type under schema node)
SchemaDeleteTestCase (Check Schema Node URL)
TypesDeleteTestCase (Delete type under schema node)
12 tests skipped:
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
SynonymAddTestCase (Default Node URL)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)

PostgreSQL 9.2:

149 tests passed
0 tests failed
22 tests skipped:
SynonymDeleteTestCase (Fetch synonym Node URL)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
ResourceGroupsPutTestCase (Put resource groups)
PackageGetTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
ViewsDeleteTestCase (Delete materialized view under schema node)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ViewsAddTestCase (Add materialized view under schema node)
ViewsGetTestCase (Get materialized view under schema node)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
ViewsUpdateTestCase (Update materialized view under schema node)
SynonymAddTestCase (Default Node URL)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
PackagePutTestCase (Fetch Package Node URL)

EDB Postgres AS 9.6:

169 tests passed
0 tests failed
2 tests skipped:
TableUpdateTestCase (Attach partition to existing range 
partitioned t

Build failed in Jenkins: pgadmin4-master-python26 #341

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Fixed issue by adding extra check for 'relkind' column

--
[...truncated 474.61 KB...]
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

157 tests passed
0 tests failed
14 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

157 tests passed
0 tests failed
14 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.2:

149 tests passed
0 tests failed
22 tests skipped:
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
ViewsGetTestCase (Get materialized view under schema node)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ViewsDeleteTestCase (Delete materialized view under schema node)
SynonymAddTestCase (Default Node URL)
ViewsAddTestCase (Add materialized view under schema node)
PackageGetTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymGetTestCase (Fetch synon

Build failed in Jenkins: pgadmin4-master-python36 #218

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Fixed issue by adding extra check for 'relkind' column

--
[...truncated 480.39 KB...]
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)

PostgreSQL 9.4:

157 tests passed
0 tests failed
14 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)

PostgreSQL 9.5:

157 tests passed
0 tests failed
14 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)

PostgreSQL 9.6:

157 tests passed
0 tests failed
14 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,

Build failed in Jenkins: pgadmin4-master-python33 #220

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Fixed issue by adding extra check for 'relkind' column

--
[...truncated 480.33 KB...]
Create List partitioned table with 2 
partitions)
LoginRoleDeleteTestCase (Check Role Node)
DatabaseDeleteTestCase (Check Databases Node URL)
TableDeleteTestCase (Delete Table)
DatabasesGetTestCase (Check Databases Node URL)
TableSpaceDeleteTestCase (Check Tablespace Node)
SchemaDeleteTestCase (Check Schema Node URL)
TriggersUpdateTestCase (Put trigger Node URL)
LoginRoleGetTestCase (Check Role Node)
TableGetTestCase (Fetch table Node URL)
ViewsUpdateTestCase (Update view under schema node,
Update materialized view under schema 
node)
TypesGetTestCase (Get type under schema node)
TablespaceGetTestCase (Check Tablespace Node)
TriggersGetTestCase (Fetch trigger Node URL)
SchemaAddTestCase (Check Schema Node URL)
TableSpaceAddTestCase (Check Tablespace Node)
LoginRoleAddTestCase (Check Role Node)
TypesDeleteTestCase (Delete type under schema node)
ViewsDeleteTestCase (Delete materialized view under schema node,
Delete view under schema node)
TriggersDeleteTestCase (Delete trigger Node URL)
DatabaseAddTestCase (Check Databases Node URL)
SchemaPutTestCase (Check Schema Node URL)
TriggersAddTestCase (Add trigger Node URL)
ViewsGetTestCase (Get view under schema node,
Get materialized view under schema node)
DatabasesUpdateTestCase (Check Databases Node)
TypesAddTestCase (Add type under schema node)
TypesUpdateTestCase (Update type under schema node)
TableSpaceUpdateTestCase (Check Tablespace Node)
12 tests skipped:
ResourceGroupsAddTestCase (Add resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackageAddTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)

PostgreSQL 9.3:

157 tests passed
0 tests failed
14 tests skipped:
ResourceGroupsAddTestCase (Add resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
ResourceGroupsPutTestCase (Put resource groups)
PackageGetTestCase (Fetch Package Node URL)
PackageAddTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)

PostgreSQL 9.2:

149 tests passed
0 tests failed
22 tests skipped:
ViewsAddTestCase (Add materialized view under schema node)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,

Build failed in Jenkins: pgadmin4-master-python34 #211

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Fixed issue by adding extra check for 'relkind' column

--
[...truncated 480.29 KB...]
TriggersUpdateTestCase (Put trigger Node URL)
TriggersAddTestCase (Add trigger Node URL)
TableDeleteTestCase (Delete Table)
LoginRoleDeleteTestCase (Check Role Node)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Update Table,
Create partitions of existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
TableSpaceUpdateTestCase (Check Tablespace Node)
SchemaGetTestCase (Check Schema Node URL)
TriggersDeleteTestCase (Delete trigger Node URL)
LoginRoleGetTestCase (Check Role Node)
SchemaAddTestCase (Check Schema Node URL)
TypesGetTestCase (Get type under schema node)
SchemaDeleteTestCase (Check Schema Node URL)
TablespaceGetTestCase (Check Tablespace Node)
TableSpaceAddTestCase (Check Tablespace Node)
TypesAddTestCase (Add type under schema node)
TypesDeleteTestCase (Delete type under schema node)
TriggersGetTestCase (Fetch trigger Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableGetTestCase (Fetch table Node URL)
LoginRolePutTestCase (Check Role Node)
ViewsDeleteTestCase (Delete materialized view under schema node,
Delete view under schema node)
ViewsGetTestCase (Get view under schema node,
Get materialized view under schema node)
DatabasesGetTestCase (Check Databases Node URL)
LoginRoleAddTestCase (Check Role Node)
DatabasesUpdateTestCase (Check Databases Node)
TableSpaceDeleteTestCase (Check Tablespace Node)
ViewsAddTestCase (Add view under schema node,
Add materialized view under schema node)
ViewsUpdateTestCase (Update materialized view under schema node,
Update view under schema node)
12 tests skipped:
SynonymAddTestCase (Default Node URL)
PackagePutTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsAddTestCase (Add resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackageGetTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsGetTestCase (Get resource groups)
SynonymGetTestCase (Fetch synonym Node URL)

EDB Postgres AS 9.6:

169 tests passed
0 tests failed
2 tests skipped:
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)

PostgreSQL 9.3:

157 tests passed
0 tests failed
14 tests skipped:
SynonymAddTestCase (Default Node URL)
PackagePutTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,

Re: Windows testing required: Updated runtime

2017-07-07 Thread Dave Page 
Hi

On Fri, Jul 7, 2017 at 9:20 AM, Mike Surcouf  wrote:

> Hi Dave
>
>
>
> 30 second start-up so still very slow for me.
>

That's strange - I get < 12s even on my underpowered virtual machine.

What spec machine are you running? Can you try with AV disabled?


>
>
> Consistently get an exception when closing( see attachment)
>

Also strange. I do not see that. Is there any more info in the event log
etc?


>
>
> Did webpack not make it?
>
> I still get 167 requests on start up.
>

The basic infrastructure is there now, and we've made almost all the JS
code static now so it avoids the templating engine, but there's still work
to do to pack it all.

Thanks.


>
>
> Thanks
>
>
>
> Mike
>
>
>
> *From:* Dave Page [mailto:dp...@pgadmin.org]
> *Sent:* 06 July 2017 15:59
> *To:* pgadmin-hackers; pgAdmin Support
> *Subject:* Windows testing required: Updated runtime
>
>
>
> All,
>
>
>
> I've put an interim build of pgAdmin 4 at https://developer.pgadmin.
> org/~dpage/pgadmin4-1.5-x86.exe for Windows users. This build uses a work
> in progress patch to replace the slow Qt components with ActiveQt + the
> Microsoft web browser control to significantly improve performance.
>
>
>
> The version also includes close to 100 other bug fixes and changes, most
> noticeably performance improvements in the Query Tool that make it
> significantly faster than pgAdmin 3 with large result sets, and the ability
> to open the Query Tool and Debugger in new tabs that can be dragged onto
> different windows and therefore displays.
>
>
>
> If you have the ability, please give it a test and let me know how it
> performs. There are some known issues that we're working on:
>
>
>
> - The Query Tool History view isn't rendered correctly.
>
>
>
> - Closing a tab is now detected when there's a dirty query tool window in
> it, but closing the window containing the tab is not.
>
>
>
> - Inactive tabs have no visual definition between them.
>
>
>
> - When dragging a tab, the mouse icon changes to one with a stop sign in
> it.
>
>
>
> - If you close the last tab in a child window, it doesn't close the window.
>
>
>
> - Popout alerts don't display correctly.
>
>
>
> Thanks!
>
>
>
> --
>
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Windows testing required: Updated runtime

2017-07-07 Thread Dave Page 
All,

Thank you to those that have tested this build. With a couple of
exceptions, most folks seem to be reporting the improved performance we
hoped for. There is more work to do to finish up this patch which is
underway, and there is also additional optimisation work being done for
future releases.

I am interested to know if anyone has tried either with a proxy server or
over a remote desktop session. We've fixed issues in both of those areas
before, and it would be good to get confirmation that we haven't broken
anything again.

Melvin has noted that once upgraded to this test release, you cannot go
back to the "real" 1.5 (as it won't run). I believe that is due to changes
in the configuration database. The easy fix is to move
%APPDATA%\pgAdmin\pgadmin4.db out of the way and then start pgAdmin.
Unfortunately this will mean servers will need to be re-added, and config
options will have reset to default. It is possible to revert the changes to
the DB, but that's somewhat fiddly. If anyone really needs to do that, let
me know and I'll write up instructions. Apologies if that causes anyone
problems.

Thanks!

On Thu, Jul 6, 2017 at 3:59 PM, Dave Page  wrote:

> All,
>
> I've put an interim build of pgAdmin 4 at https://developer.pgadmin.
> org/~dpage/pgadmin4-1.5-x86.exe for Windows users. This build uses a work
> in progress patch to replace the slow Qt components with ActiveQt + the
> Microsoft web browser control to significantly improve performance.
>
> The version also includes close to 100 other bug fixes and changes, most
> noticeably performance improvements in the Query Tool that make it
> significantly faster than pgAdmin 3 with large result sets, and the ability
> to open the Query Tool and Debugger in new tabs that can be dragged onto
> different windows and therefore displays.
>
> If you have the ability, please give it a test and let me know how it
> performs. There are some known issues that we're working on:
>
> - The Query Tool History view isn't rendered correctly.
>
> - Closing a tab is now detected when there's a dirty query tool window in
> it, but closing the window containing the tab is not.
>
> - Inactive tabs have no visual definition between them.
>
> - When dragging a tab, the mouse icon changes to one with a stop sign in
> it.
>
> - If you close the last tab in a child window, it doesn't close the window.
>
> - Popout alerts don't display correctly.
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

RE: Windows testing required: Updated runtime

2017-07-07 Thread Mike Surcouf 
Hi Dave

30 second start-up so still very slow for me.

Consistently get an exception when closing( see attachment)

Did webpack not make it?
I still get 167 requests on start up.

Thanks

Mike

From: Dave Page [mailto:dp...@pgadmin.org]
Sent: 06 July 2017 15:59
To: pgadmin-hackers; pgAdmin Support
Subject: Windows testing required: Updated runtime

All,

I've put an interim build of pgAdmin 4 at 
https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe for Windows users. 
This build uses a work in progress patch to replace the slow Qt components with 
ActiveQt + the Microsoft web browser control to significantly improve 
performance.

The version also includes close to 100 other bug fixes and changes, most 
noticeably performance improvements in the Query Tool that make it 
significantly faster than pgAdmin 3 with large result sets, and the ability to 
open the Query Tool and Debugger in new tabs that can be dragged onto different 
windows and therefore displays.

If you have the ability, please give it a test and let me know how it performs. 
There are some known issues that we're working on:

- The Query Tool History view isn't rendered correctly.

- Closing a tab is now detected when there's a dirty query tool window in it, 
but closing the window containing the tab is not.

- Inactive tabs have no visual definition between them.

- When dragging a tab, the mouse icon changes to one with a stop sign in it.

- If you close the last tab in a child window, it doesn't close the window.

- Popout alerts don't display correctly.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

RE: Windows testing required: Updated runtime

2017-07-07 Thread Mike Surcouf 
HI Dave

Machine is

Windows 7 x64
Intel Core 6400 2.33GHz 6GB ram
SSD

I can no longer start pgAdmin the progress wheel just keeps running. and it 
never gets to dashboard.
Not much info sorry.

The Event log for exception on close is

Log Name:  Application
Source:Application Error
Date:  07/07/2017 10:05:51
Event ID:  1000
Task Category: (100)
Level: Error
Keywords:  Classic
User:  N/A
Computer:  aes15win7.surcouf.local
Description:
Faulting application name: pgAdmin4.exe, version: 1.5.0.0, time stamp: 
0x595e3603
Faulting module name: Qt5Core.dll, version: 5.8.0.0, time stamp: 0x587fd30b
Exception code: 0xc005
Fault offset: 0x0016ced8
Faulting process id: 0x1b28
Faulting application start time: 0x01d2f6fffeab9d36
Faulting application path: C:\Program Files (x86)\pgAdmin 
4\v1\runtime\pgAdmin4.exe
Faulting module path: C:\Program Files (x86)\pgAdmin 4\v1\runtime\Qt5Core.dll
Report Id: 78f82194-62f3-11e7-a69f-0019b91a41aa
Event Xml:
http://schemas.microsoft.com/win/2004/08/events/event";>
  

1000
2
100
0x80

99764
Application
aes15win7.surcouf.local

  
  
pgAdmin4.exe
1.5.0.0
595e3603
Qt5Core.dll
5.8.0.0
587fd30b
c005
0016ced8
1b28
01d2f6fffeab9d36
C:\Program Files (x86)\pgAdmin 4\v1\runtime\pgAdmin4.exe
C:\Program Files (x86)\pgAdmin 4\v1\runtime\Qt5Core.dll
78f82194-62f3-11e7-a69f-0019b91a41aa
  



Thanks

Mike

From: Dave Page [mailto:dp...@pgadmin.org]
Sent: 07 July 2017 09:39
To: Mike Surcouf
Cc: pgadmin-hackers; pgAdmin Support
Subject: Re: Windows testing required: Updated runtime

Hi

On Fri, Jul 7, 2017 at 9:20 AM, Mike Surcouf 
mailto:mi...@surcouf.co.uk>> wrote:
Hi Dave

30 second start-up so still very slow for me.

That's strange - I get < 12s even on my underpowered virtual machine.

What spec machine are you running? Can you try with AV disabled?


Consistently get an exception when closing( see attachment)

Also strange. I do not see that. Is there any more info in the event log etc?


Did webpack not make it?
I still get 167 requests on start up.

The basic infrastructure is there now, and we've made almost all the JS code 
static now so it avoids the templating engine, but there's still work to do to 
pack it all.

Thanks.


Thanks

Mike

From: Dave Page [mailto:dp...@pgadmin.org]
Sent: 06 July 2017 15:59
To: pgadmin-hackers; pgAdmin Support
Subject: Windows testing required: Updated runtime

All,

I've put an interim build of pgAdmin 4 at 
https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe for Windows users. 
This build uses a work in progress patch to replace the slow Qt components with 
ActiveQt + the Microsoft web browser control to significantly improve 
performance.

The version also includes close to 100 other bug fixes and changes, most 
noticeably performance improvements in the Query Tool that make it 
significantly faster than pgAdmin 3 with large result sets, and the ability to 
open the Query Tool and Debugger in new tabs that can be dragged onto different 
windows and therefore displays.

If you have the ability, please give it a test and let me know how it performs. 
There are some known issues that we're working on:

- The Query Tool History view isn't rendered correctly.

- Closing a tab is now detected when there's a dirty query tool window in it, 
but closing the window containing the tab is not.

- Inactive tabs have no visual definition between them.

- When dragging a tab, the mouse icon changes to one with a stop sign in it.

- If you close the last tab in a child window, it doesn't close the window.

- Popout alerts don't display correctly.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

RE: Windows testing required: Updated runtime

2017-07-07 Thread Mike Surcouf 
IN addition I uninstalled removed everything in %APPDATA%\pgadmin4 and 
programfiles and restarted reinstalled.
Also trying with AV disabled.
Unfortunately I still get the same results.

From: Mike Surcouf [mailto:mi...@surcouf.co.uk]
Sent: 07 July 2017 10:17
To: 'Dave Page'
Cc: pgadmin-hackers; pgAdmin Support
Subject: RE: Windows testing required: Updated runtime

HI Dave

Machine is

Windows 7 x64
Intel Core 6400 2.33GHz 6GB ram
SSD

I can no longer start pgAdmin the progress wheel just keeps running. and it 
never gets to dashboard.
Not much info sorry.

The Event log for exception on close is

Log Name:  Application
Source:Application Error
Date:  07/07/2017 10:05:51
Event ID:  1000
Task Category: (100)
Level: Error
Keywords:  Classic
User:  N/A
Computer:  aes15win7.surcouf.local
Description:
Faulting application name: pgAdmin4.exe, version: 1.5.0.0, time stamp: 
0x595e3603
Faulting module name: Qt5Core.dll, version: 5.8.0.0, time stamp: 0x587fd30b
Exception code: 0xc005
Fault offset: 0x0016ced8
Faulting process id: 0x1b28
Faulting application start time: 0x01d2f6fffeab9d36
Faulting application path: C:\Program Files (x86)\pgAdmin 
4\v1\runtime\pgAdmin4.exe
Faulting module path: C:\Program Files (x86)\pgAdmin 4\v1\runtime\Qt5Core.dll
Report Id: 78f82194-62f3-11e7-a69f-0019b91a41aa
Event Xml:
http://schemas.microsoft.com/win/2004/08/events/event";>
  

1000
2
100
0x80

99764
Application
aes15win7.surcouf.local

  
  
pgAdmin4.exe
1.5.0.0
595e3603
Qt5Core.dll
5.8.0.0
587fd30b
c005
0016ced8
1b28
01d2f6fffeab9d36
C:\Program Files (x86)\pgAdmin 4\v1\runtime\pgAdmin4.exe
C:\Program Files (x86)\pgAdmin 4\v1\runtime\Qt5Core.dll
78f82194-62f3-11e7-a69f-0019b91a41aa
  



Thanks

Mike

From: Dave Page [mailto:dp...@pgadmin.org]
Sent: 07 July 2017 09:39
To: Mike Surcouf
Cc: pgadmin-hackers; pgAdmin Support
Subject: Re: Windows testing required: Updated runtime

Hi

On Fri, Jul 7, 2017 at 9:20 AM, Mike Surcouf 
mailto:mi...@surcouf.co.uk>> wrote:
Hi Dave

30 second start-up so still very slow for me.

That's strange - I get < 12s even on my underpowered virtual machine.

What spec machine are you running? Can you try with AV disabled?


Consistently get an exception when closing( see attachment)

Also strange. I do not see that. Is there any more info in the event log etc?


Did webpack not make it?
I still get 167 requests on start up.

The basic infrastructure is there now, and we've made almost all the JS code 
static now so it avoids the templating engine, but there's still work to do to 
pack it all.

Thanks.


Thanks

Mike

From: Dave Page [mailto:dp...@pgadmin.org]
Sent: 06 July 2017 15:59
To: pgadmin-hackers; pgAdmin Support
Subject: Windows testing required: Updated runtime

All,

I've put an interim build of pgAdmin 4 at 
https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe for Windows users. 
This build uses a work in progress patch to replace the slow Qt components with 
ActiveQt + the Microsoft web browser control to significantly improve 
performance.

The version also includes close to 100 other bug fixes and changes, most 
noticeably performance improvements in the Query Tool that make it 
significantly faster than pgAdmin 3 with large result sets, and the ability to 
open the Query Tool and Debugger in new tabs that can be dragged onto different 
windows and therefore displays.

If you have the ability, please give it a test and let me know how it performs. 
There are some known issues that we're working on:

- The Query Tool History view isn't rendered correctly.

- Closing a tab is now detected when there's a dirty query tool window in it, 
but closing the window containing the tab is not.

- Inactive tabs have no visual definition between them.

- When dragging a tab, the mouse icon changes to one with a stop sign in it.

- If you close the last tab in a child window, it doesn't close the window.

- Popout alerts don't display correctly.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Partitioned table does not present in grant wizard. F

2017-07-07 Thread Akshay Joshi 
Partitioned table does not present in grant wizard. Fixes #2543

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fae185ff661e4c29de377446736fb798dc5b352e

Modified Files
--
.../templates/grant_wizard/pg/10_plus/sql/table.sql  | 20 
.../grant_wizard/ppas/10_plus/sql/table.sql  | 20 
2 files changed, 40 insertions(+)

Build failed in Jenkins: pgadmin4-master-python26 #342

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Partitioned table does not present in grant wizard. Fixes #2543

--
[...truncated 136.46 KB...]
Fetch synonym Node URL ... skipped 'Synonyms are not supported by PG.'
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.synonyms.tests.test_synonym_get.SynonymGetTestCase)
Fetch synonym Node URL ... skipped 'Synonyms are not supported by PG.'
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.synonyms.tests.test_synonym_put.SynonymPutTestCase)
Fetch synonym Node URL ... skipped 'Synonyms are not supported by PG.'
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_add.ColumnAddTestCase)
Add table Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_delete.ColumnDeleteTestCase)
Delete table Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_get.ColumnGetTestCase)
Fetch columns under table node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_put.ColumnPutTestCase)
Put table Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.check_constraint.tests.test_check_constraint_add.CheckConstraintAddTestCase)
Add check constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.check_constraint.tests.test_check_constraint_delete.CheckConstraintDeleteTestCase)
Delete check constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.check_constraint.tests.test_check_constraint_get.CheckConstraintGetTestCase)
Fetch check constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.check_constraint.tests.test_check_constraint_put.CheckConstraintPutTestCase)
Update check constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.foreign_key.tests.test_foreign_key_add.ForeignKeyAddTestCase)
Add foreign Key constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.foreign_key.tests.test_foreign_key_delete.ForeignKeyDeleteTestCase)
Delete foreign Key constraint. ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.foreign_key.tests.test_foreign_key_get.ForeignGetDeleteTestCase)
Fetch foreign Key constraint. ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.foreign_key.tests.test_foreign_key_put.ForeignPutDeleteTestCase)
Fetch foreign Key constraint. ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_add.IndexConstraintAddTestCase)
Add primary Key constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_add.IndexConstraintAddTestCase)
Add unique Key constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_delete.IndexConstraintDeleteTestCase)
Delete primary Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_delete.IndexConstraintDeleteTestCase)
Delete unique Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_get.IndexConstraintGetTestCase)
Fetch primary Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_get.IndexConstraintGetTestCase)
Fetch unique Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_put.IndexConstraintUpdateTestCase)
Update primary Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_put.IndexConstraintUpdateTestCase)
Update unique Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.indexes.tests.test_indexes_add.IndexesAddTestCase)
Add index Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.indexes.tests.test_indexes_delete.IndexesDeleteTestCase)
Delete index Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.indexes.tests.test_indexes_get.IndexesGetTestCase)
Fetch index N

Build failed in Jenkins: pgadmin4-master-python33 #221

2017-07-07 Thread pgAdmin 4 Jenkins 
See 


Changes:

[akshay.joshi] Partitioned table does not present in grant wizard. Fixes #2543

--
[...truncated 132.82 KB...]
Fetch synonym Node URL ... skipped 'Synonyms are not supported by PG.'
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.synonyms.tests.test_synonym_get.SynonymGetTestCase)
Fetch synonym Node URL ... skipped 'Synonyms are not supported by PG.'
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.synonyms.tests.test_synonym_put.SynonymPutTestCase)
Fetch synonym Node URL ... skipped 'Synonyms are not supported by PG.'
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_add.ColumnAddTestCase)
Add table Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_delete.ColumnDeleteTestCase)
Delete table Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_get.ColumnGetTestCase)
Fetch columns under table node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_put.ColumnPutTestCase)
Put table Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.check_constraint.tests.test_check_constraint_add.CheckConstraintAddTestCase)
Add check constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.check_constraint.tests.test_check_constraint_delete.CheckConstraintDeleteTestCase)
Delete check constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.check_constraint.tests.test_check_constraint_get.CheckConstraintGetTestCase)
Fetch check constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.check_constraint.tests.test_check_constraint_put.CheckConstraintPutTestCase)
Update check constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.foreign_key.tests.test_foreign_key_add.ForeignKeyAddTestCase)
Add foreign Key constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.foreign_key.tests.test_foreign_key_delete.ForeignKeyDeleteTestCase)
Delete foreign Key constraint. ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.foreign_key.tests.test_foreign_key_get.ForeignGetDeleteTestCase)
Fetch foreign Key constraint. ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.foreign_key.tests.test_foreign_key_put.ForeignPutDeleteTestCase)
Fetch foreign Key constraint. ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_add.IndexConstraintAddTestCase)
Add primary Key constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_add.IndexConstraintAddTestCase)
Add unique Key constraint to table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_delete.IndexConstraintDeleteTestCase)
Delete primary Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_delete.IndexConstraintDeleteTestCase)
Delete unique Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_get.IndexConstraintGetTestCase)
Fetch primary Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_get.IndexConstraintGetTestCase)
Fetch unique Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_put.IndexConstraintUpdateTestCase)
Update primary Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.constraints.index_constraint.tests.test_index_constraint_put.IndexConstraintUpdateTestCase)
Update unique Key constraint of table ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.indexes.tests.test_indexes_add.IndexesAddTestCase)
Add index Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.indexes.tests.test_indexes_delete.IndexesDeleteTestCase)
Delete index Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tables.indexes.tests.test_indexes_get.IndexesGetTestCase)
Fetch index N

Jenkins build is back to normal : pgadmin4-master-python36 #219

2017-07-07 Thread pgAdmin 4 Jenkins 
See

Jenkins build is back to normal : pgadmin4-master-python34 #212

2017-07-07 Thread pgAdmin 4 Jenkins 
See

Jenkins build is back to normal : pgadmin4-master-python27 #227

2017-07-07 Thread pgAdmin 4 Jenkins 
See

Jenkins build is back to normal : pgadmin4-master-python35 #222

2017-07-07 Thread pgAdmin 4 Jenkins 
See

Re: Windows testing required: Updated runtime

2017-07-07 Thread Dave Page 
If you've done that, then you really have removed everything except for a
handful of registry entries. To completely start over you should:

- Uninstall pgAdmin
- Ensure the original installation directory is removed entirely.
- Remove "%APPDATA%\pgAdmin" (not %APPDATA%\pgAdmin4)
- Remove "HKEY_CURRENT_USER\Software\pgadmin" from the registry
- Restart (probably not required, but...)
- Reinstall pgAdmin.


On Fri, Jul 7, 2017 at 10:29 AM, Mike Surcouf  wrote:

> IN addition I uninstalled removed everything in %APPDATA%\pgadmin4 and
> programfiles and restarted reinstalled.
>
> Also trying with AV disabled.
>
> Unfortunately I still get the same results.
>
>
>
> *From:* Mike Surcouf [mailto:mi...@surcouf.co.uk]
> *Sent:* 07 July 2017 10:17
> *To:* 'Dave Page'
> *Cc:* pgadmin-hackers; pgAdmin Support
> *Subject:* RE: Windows testing required: Updated runtime
>
>
>
> HI Dave
>
>
>
> Machine is
>
>
>
> Windows 7 x64
>
> Intel Core 6400 2.33GHz 6GB ram
>
> SSD
>
>
>
> I can no longer start pgAdmin the progress wheel just keeps running. and
> it never gets to dashboard.
>
> Not much info sorry.
>
>
>
> The Event log for exception on close is
>
>
>
> Log Name:  Application
>
> Source:Application Error
>
> Date:  07/07/2017 10:05:51
>
> Event ID:  1000
>
> Task Category: (100)
>
> Level: Error
>
> Keywords:  Classic
>
> User:  N/A
>
> Computer:  aes15win7.surcouf.local
>
> Description:
>
> Faulting application name: pgAdmin4.exe, version: 1.5.0.0, time stamp:
> 0x595e3603
>
> Faulting module name: Qt5Core.dll, version: 5.8.0.0, time stamp:
> 0x587fd30b
>
> Exception code: 0xc005
>
> Fault offset: 0x0016ced8
>
> Faulting process id: 0x1b28
>
> Faulting application start time: 0x01d2f6fffeab9d36
>
> Faulting application path: C:\Program Files (x86)\pgAdmin
> 4\v1\runtime\pgAdmin4.exe
>
> Faulting module path: C:\Program Files (x86)\pgAdmin
> 4\v1\runtime\Qt5Core.dll
>
> Report Id: 78f82194-62f3-11e7-a69f-0019b91a41aa
>
> Event Xml:
>
> http://schemas.microsoft.com/win/2004/08/events/event";>
>
>   
>
> 
>
> 1000
>
> 2
>
> 100
>
> 0x80
>
> 
>
> 99764
>
> Application
>
> aes15win7.surcouf.local
>
> 
>
>   
>
>   
>
> pgAdmin4.exe
>
> 1.5.0.0
>
> 595e3603
>
> Qt5Core.dll
>
> 5.8.0.0
>
> 587fd30b
>
> c005
>
> 0016ced8
>
> 1b28
>
> 01d2f6fffeab9d36
>
> C:\Program Files (x86)\pgAdmin 4\v1\runtime\pgAdmin4.exe
>
> C:\Program Files (x86)\pgAdmin 4\v1\runtime\Qt5Core.dll
>
> 78f82194-62f3-11e7-a69f-0019b91a41aa
>
>   
>
> 
>
>
>
>
>
> Thanks
>
>
>
> Mike
>
>
>
> *From:* Dave Page [mailto:dp...@pgadmin.org ]
> *Sent:* 07 July 2017 09:39
> *To:* Mike Surcouf
> *Cc:* pgadmin-hackers; pgAdmin Support
> *Subject:* Re: Windows testing required: Updated runtime
>
>
>
> Hi
>
>
>
> On Fri, Jul 7, 2017 at 9:20 AM, Mike Surcouf  wrote:
>
> Hi Dave
>
>
>
> 30 second start-up so still very slow for me.
>
>
>
> That's strange - I get < 12s even on my underpowered virtual machine.
>
>
>
> What spec machine are you running? Can you try with AV disabled?
>
>
>
>
>
> Consistently get an exception when closing( see attachment)
>
>
>
> Also strange. I do not see that. Is there any more info in the event log
> etc?
>
>
>
>
>
> Did webpack not make it?
>
> I still get 167 requests on start up.
>
>
>
> The basic infrastructure is there now, and we've made almost all the JS
> code static now so it avoids the templating engine, but there's still work
> to do to pack it all.
>
>
>
> Thanks.
>
>
>
>
>
> Thanks
>
>
>
> Mike
>
>
>
> *From:* Dave Page [mailto:dp...@pgadmin.org]
> *Sent:* 06 July 2017 15:59
> *To:* pgadmin-hackers; pgAdmin Support
> *Subject:* Windows testing required: Updated runtime
>
>
>
> All,
>
>
>
> I've put an interim build of pgAdmin 4 at https://developer.pgadmin.
> org/~dpage/pgadmin4-1.5-x86.exe for Windows users. This build uses a work
> in progress patch to replace the slow Qt components with ActiveQt + the
> Microsoft web browser control to significantly improve performance.
>
>
>
> The version also includes close to 100 other bug fixes and changes, most
> noticeably performance improvements in the Query Tool that make it
> significantly faster than pgAdmin 3 with large result sets, and the ability
> to open the Query Tool and Debugger in new tabs that can be dragged onto
> different windows and therefore displays.
>
>
>
> If you have the ability, please give it a test and let me know how it
> performs. There are some known issues that we're working on:
>
>
>
> - The Query Tool History view isn't rendered correctly.
>
>
>
> - Closing a tab is now detected when there's a dirty query tool window in
> it, but closing the window containing the tab is not.
>
>
>
> - Inactive tabs have no visual definition between them.
>
>
>
> - When dragging a tab, the mouse icon changes to one with a stop sign in
> it.
>
>
>
> - If you close the last tab in a child window, it doesn't clo

RE: Windows testing required: Updated runtime

2017-07-07 Thread Mike Surcouf 
Hi Dave that was a type yes I deleted pgAdmin under appdata

From: Dave Page [mailto:dp...@pgadmin.org]
Sent: 07 July 2017 12:40
To: Mike Surcouf
Cc: pgadmin-hackers; pgAdmin Support
Subject: Re: Windows testing required: Updated runtime

If you've done that, then you really have removed everything except for a 
handful of registry entries. To completely start over you should:

- Uninstall pgAdmin
- Ensure the original installation directory is removed entirely.
- Remove "%APPDATA%\pgAdmin" (not %APPDATA%\pgAdmin4)
- Remove "HKEY_CURRENT_USER\Software\pgadmin" from the registry
- Restart (probably not required, but...)
- Reinstall pgAdmin.


On Fri, Jul 7, 2017 at 10:29 AM, Mike Surcouf 
mailto:mi...@surcouf.co.uk>> wrote:
IN addition I uninstalled removed everything in %APPDATA%\pgadmin4 and 
programfiles and restarted reinstalled.
Also trying with AV disabled.
Unfortunately I still get the same results.

From: Mike Surcouf [mailto:mi...@surcouf.co.uk]
Sent: 07 July 2017 10:17
To: 'Dave Page'
Cc: pgadmin-hackers; pgAdmin Support
Subject: RE: Windows testing required: Updated runtime

HI Dave

Machine is

Windows 7 x64
Intel Core 6400 2.33GHz 6GB ram
SSD

I can no longer start pgAdmin the progress wheel just keeps running. and it 
never gets to dashboard.
Not much info sorry.

The Event log for exception on close is

Log Name:  Application
Source:Application Error
Date:  07/07/2017 10:05:51
Event ID:  1000
Task Category: (100)
Level: Error
Keywords:  Classic
User:  N/A
Computer:  aes15win7.surcouf.local
Description:
Faulting application name: pgAdmin4.exe, version: 1.5.0.0, time stamp: 
0x595e3603
Faulting module name: Qt5Core.dll, version: 5.8.0.0, time stamp: 0x587fd30b
Exception code: 0xc005
Fault offset: 0x0016ced8
Faulting process id: 0x1b28
Faulting application start time: 0x01d2f6fffeab9d36
Faulting application path: C:\Program Files (x86)\pgAdmin 
4\v1\runtime\pgAdmin4.exe
Faulting module path: C:\Program Files (x86)\pgAdmin 4\v1\runtime\Qt5Core.dll
Report Id: 78f82194-62f3-11e7-a69f-0019b91a41aa
Event Xml:
http://schemas.microsoft.com/win/2004/08/events/event";>
  

1000
2
100
0x80

99764
Application
aes15win7.surcouf.local

  
  
pgAdmin4.exe
1.5.0.0
595e3603
Qt5Core.dll
5.8.0.0
587fd30b
c005
0016ced8
1b28
01d2f6fffeab9d36
C:\Program Files (x86)\pgAdmin 4\v1\runtime\pgAdmin4.exe
C:\Program Files (x86)\pgAdmin 4\v1\runtime\Qt5Core.dll
78f82194-62f3-11e7-a69f-0019b91a41aa
  



Thanks

Mike

From: Dave Page [mailto:dp...@pgadmin.org]
Sent: 07 July 2017 09:39
To: Mike Surcouf
Cc: pgadmin-hackers; pgAdmin Support
Subject: Re: Windows testing required: Updated runtime

Hi

On Fri, Jul 7, 2017 at 9:20 AM, Mike Surcouf 
mailto:mi...@surcouf.co.uk>> wrote:
Hi Dave

30 second start-up so still very slow for me.

That's strange - I get < 12s even on my underpowered virtual machine.

What spec machine are you running? Can you try with AV disabled?


Consistently get an exception when closing( see attachment)

Also strange. I do not see that. Is there any more info in the event log etc?


Did webpack not make it?
I still get 167 requests on start up.

The basic infrastructure is there now, and we've made almost all the JS code 
static now so it avoids the templating engine, but there's still work to do to 
pack it all.

Thanks.


Thanks

Mike

From: Dave Page [mailto:dp...@pgadmin.org]
Sent: 06 July 2017 15:59
To: pgadmin-hackers; pgAdmin Support
Subject: Windows testing required: Updated runtime

All,

I've put an interim build of pgAdmin 4 at 
https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe for Windows users. 
This build uses a work in progress patch to replace the slow Qt components with 
ActiveQt + the Microsoft web browser control to significantly improve 
performance.

The version also includes close to 100 other bug fixes and changes, most 
noticeably performance improvements in the Query Tool that make it 
significantly faster than pgAdmin 3 with large result sets, and the ability to 
open the Query Tool and Debugger in new tabs that can be dragged onto different 
windows and therefore displays.

If you have the ability, please give it a test and let me know how it performs. 
There are some known issues that we're working on:

- The Query Tool History view isn't rendered correctly.

- Closing a tab is now detected when there's a dirty query tool window in it, 
but closing the window containing the tab is not.

- Inactive tabs have no visual definition between them.

- When dragging a tab, the mouse icon changes to one with a stop sign in it.

- If you close the last tab in a child window, it doesn't close the window.

- Popout alerts don't display correctly.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The

[RM2534][pgAdmin4] Fix issues related to table OF TYPE property.

2017-07-07 Thread Harshal Dhumal 
Hi,

Please find attached patch to fix issue related to table OF TYPE property.

-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.js
index 7f6aa0c..7560be4 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.js
@@ -725,19 +725,33 @@ define('pgadmin.node.table', [
   arg = undefined,
   column_collection = self.model.get('columns');
 
-if (!_.isUndefined(tbl_name) &&
+if (!_.isUndefined(tbl_name) && !_.isNull(tbl_name) &&
 tbl_name !== '' && column_collection.length !== 0) {
-  var msg = gettext('Changing of type table will clear columns collection');
-  alertify.confirm(msg, function (e) {
-if (e) {
+  var title = gettext('Remove column definitions?'),
+  msg = gettext('Changing \'Of type\' will remove column definitions.');
+
+  alertify.confirm(title, msg, function (e) {
   // User clicks Ok, lets clear columns collection
-  column_collection.reset();
-} else {
-  return this;
+  column_collection.remove(
+column_collection.filter(function(model) {
+  return true;
+  }
+)
+  );
+},
+function() {
+  setTimeout(function() {
+self.model.set('typname', null);
+  }, 10)
 }
-  });
+  );
 } else if (!_.isUndefined(tbl_name) && tbl_name === '') {
-  column_collection.reset();
+  column_collection.remove(
+column_collection.filter(function(model) {
+  return true;
+  }
+)
+  );
 }
 
 // Run Ajax now to fetch columns
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/create.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/create.sql
index 5ec8ffc..ffb6b84 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/create.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/default/create.sql
@@ -18,7 +18,7 @@
 {% endif %}
 CREATE {% if data.relpersistence %}UNLOGGED {% endif %}TABLE {{conn|qtIdent(data.schema, data.name)}}{{empty_bracket}}
 {% if data.typname %}
-OF {{ conn|qtTypeIdent(data.typname) }}
+OF {{ data.typname }}
 {% endif %}
 {% if data.like_relation or data.coll_inherits or data.columns|length > 0 or data.primary_key|length > 0 or data.unique_constraint|length > 0 or data.foreign_key|length > 0 or data.check_constraint|length > 0 or data.exclude_constraint|length > 0 %}
 (

pgAdmin 4 commit: Fix clear history.

2017-07-07 Thread Dave Page 
Fix clear history.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc782026005b85ecf6ff9cc9602422c936fba44e
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/static/js/history/history_collection.js  |  6 +-
web/pgadmin/static/jsx/history/query_history.jsx | 12 
.../tools/sqleditor/templates/sqleditor/js/sqleditor.js  |  3 +--
web/regression/javascript/history/history_collection_spec.js |  8 +---
4 files changed, 23 insertions(+), 6 deletions(-)

Re: Fix clear history option [pgAdmin4][RM2535]

2017-07-07 Thread Dave Page 
Thanks, applied.

On Thu, Jul 6, 2017 at 2:50 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch to fix clear history functionality in query
> tool.
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][pgAdmin4][Patch] Make karma test results output to browser

2017-07-07 Thread Dave Page 
Thanks, applied.

On Thu, Jul 6, 2017 at 3:09 PM, Sarah McAlear  wrote:

> Hi Hackers!
>
> Attached is a minor patch that enables pretty html output of our karma
> test results. While running yarn test:karma, visit
> localhost:9876/debug.html to see test output.
>
> Thanks,
> Matt and Sarah
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Enable pretty html output of our karma test results.

2017-07-07 Thread Dave Page 
Enable pretty html output of our karma test results. While running yarn 
test:karma, visit localhost:9876/debug.html to see test output.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8646e9e404401478342ed44e41ed9fa009fe0e63
Author: Sarah McAlear 

Modified Files
--
web/karma.conf.js |  1 +
web/package.json  |  2 +-
web/yarn.lock | 10 +-
3 files changed, 7 insertions(+), 6 deletions(-)

pgAdmin 4 commit: Fix the formatting of the ROWS option for functions e

2017-07-07 Thread Dave Page 
Fix the formatting of the ROWS option for functions etc. Fixes #2537

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=acd3568f064be65ec82d2b2e20189b7cf3df2fef
Author: Murtuza Zabuawala 

Modified Files
--
.../schemas/functions/templates/function/pg/sql/9.2_plus/update.sql| 2 +-
.../schemas/functions/templates/function/pg/sql/9.5_plus/update.sql| 2 +-
.../schemas/functions/templates/function/pg/sql/9.6_plus/create.sql| 3 +++
.../schemas/functions/templates/function/pg/sql/9.6_plus/update.sql| 2 +-
.../schemas/functions/templates/function/pg/sql/default/update.sql | 2 +-
.../schemas/functions/templates/function/ppas/sql/9.2_plus/update.sql  | 2 +-
.../schemas/functions/templates/function/ppas/sql/9.5_plus/update.sql  | 2 +-
.../schemas/functions/templates/function/ppas/sql/9.6_plus/create.sql  | 3 +++
.../schemas/functions/templates/function/ppas/sql/9.6_plus/update.sql  | 2 +-
.../schemas/functions/templates/function/ppas/sql/default/update.sql   | 2 +-
.../schemas/functions/templates/procedure/ppas/sql/9.5_plus/update.sql | 2 +-
.../schemas/functions/templates/procedure/ppas/sql/9.6_plus/update.sql | 2 +-
.../functions/templates/trigger_function/pg/sql/9.2_plus/update.sql| 2 +-
.../functions/templates/trigger_function/pg/sql/9.5_plus/update.sql| 2 +-
.../functions/templates/trigger_function/pg/sql/default/update.sql | 2 +-
.../functions/templates/trigger_function/ppas/sql/9.2_plus/update.sql  | 2 +-
.../functions/templates/trigger_function/ppas/sql/9.5_plus/update.sql  | 2 +-
.../functions/templates/trigger_function/ppas/sql/default/update.sql   | 2 +-
18 files changed, 22 insertions(+), 16 deletions(-)

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-07 Thread Dave Page 
Of course, yes you're correct. Thanks - patch applied.

On Thu, Jul 6, 2017 at 3:59 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Sorry, I think my last statement was misleading.
>
> No, It's not broken, I meant the behaviour is taken from pgAdmin3, It is
> disabled by default but once you change the value of "Returns a set?"
> (under Options tab) to Yes while creating new function it gets enabled.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jul 6, 2017 at 6:37 PM, Dave Page  wrote:
>
>> Maybe, but it's pretty clearly broken, so whilst you're fixing the
>> template for that value, it would make sense to fix the UI too :-)
>>
>> On Thu, Jul 6, 2017 at 1:42 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> This behaviour is from beginning I think and it is inherited from
>>> pgAdmin3.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Thu, Jul 6, 2017 at 5:58 PM, Dave Page  wrote:
>>>
 Hi

 On Thu, Jul 6, 2017 at 12:04 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue in Function, Procedure & Trigger Function
> modules where user was not able to update object if user changes the code
> definition.
> RM#2537
>

 This still doesn't seem quite right - the Rows field seems to be always
 greyed out, so I cannot set it to test at all.

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Jenkins build is back to normal : pgadmin4-master-python26 #343

2017-07-07 Thread pgAdmin 4 Jenkins 
See

pgAdmin 4 commit: Improve spacing around delete icons in backform table

2017-07-07 Thread Dave Page 
Improve spacing around delete icons in backform tables.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=815c4b4c452a03d46f70689dedad2a9be8261735
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
.../browser/server_groups/servers/roles/templates/role/js/role.js| 1 -
web/pgadmin/browser/server_groups/servers/static/js/server.js| 1 -
2 files changed, 2 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python33 #222

2017-07-07 Thread pgAdmin 4 Jenkins 
See

Re: [pgadmin-hackers][patch] delete icon width in security labels form

2017-07-07 Thread Dave Page 
Hi

On Thu, Jul 6, 2017 at 4:13 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Hackers,
>
> We found a discrepancy with the width of inserted columns in some backform
> tables. It is at least present in Create Table -> Security [tab] ->
> clicking [+] for new rows under each of Privileges and Security Labels. In
> this case, the cell containing the delete icon is spaced differently.
>
> After briefly investigating, it looks like width_percent_xx classes on too
> many columns is to blame. We've attached a patch that resolves the
> immediate issue by removing width_percent_50 from the last column of two
> schemas. It feels like columns are overconstrained since by themselves
> width percentages sum to 100%, but there is behavior that inserts
> additional columns beyond those specified in the schema. For instance, the
> unshifts in Backform.UniqueColCollectionControl.showGridControl in
> backform.pgadmin.js
>
> Let us know what you think of this removal of last-column constraint as an
> approach.
>

I think it's fine for a quick fix. Longer term, it may be worth coming up
with some more intelligent sizing, such as fixed space for the control
icons, then some sort of fixed unit for the rest, that can be used so that
it recalculates actual ratios on the fly.

Thanks, patch applied!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix handling of CREATE TABLE OF . Fixes #2534

2017-07-07 Thread Dave Page 
Fix handling of CREATE TABLE OF . Fixes #2534

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d151bdb4cd9b6038864dc9596d279860628cb70f
Author: Harshal Dhumal 

Modified Files
--
.../databases/schemas/tables/static/js/table.js| 32 --
.../tables/templates/table/sql/default/create.sql  |  2 +-
2 files changed, 24 insertions(+), 10 deletions(-)

Re: [RM2534][pgAdmin4] Fix issues related to table OF TYPE property.

2017-07-07 Thread Dave Page 
Thanks, applied.

On Fri, Jul 7, 2017 at 2:41 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch to fix issue related to table OF TYPE property.
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix alert animation on IE11

2017-07-07 Thread Dave Page 
Fix alert animation on IE11

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08e874a0266e56f07ec61cbeed1173c249a2311f
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/static/scss/_alert.scss  |  1 +
web/pgadmin/static/scss/_alertify.overrides.scss | 16 ++--
2 files changed, 11 insertions(+), 6 deletions(-)

pgAdmin 4 commit: Open query tool and debugger windows in new tabs by d

2017-07-07 Thread Dave Page 
Open query tool and debugger windows in new tabs by default.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a6fe946ce69736a4b9af8bcd79568f907fa383a

Modified Files
--
web/pgadmin/tools/debugger/__init__.py  | 2 +-
web/pgadmin/tools/sqleditor/__init__.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Revert "Open query tool and debugger windows in new t

2017-07-07 Thread Dave Page 
Revert "Open query tool and debugger windows in new tabs by default."

This reverts commit 1a6fe946ce69736a4b9af8bcd79568f907fa383a.

This is going to break the regression tests, so reverting it for now.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec739b3392be7c6228c782482a5e03801ee2c90d

Modified Files
--
web/pgadmin/tools/debugger/__init__.py  | 2 +-
web/pgadmin/tools/sqleditor/__init__.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

[pgadmin-hackers][patch] Update the error alerts style in dialog

2017-07-07 Thread Joao De Almeida Pereira 
Hi Hackers,

We updated the style of the error alerts in the dialogs window to match the
style guide. Below is a screenshot of how it looks:

[image: Inline image 1]


Thanks
Shruti & Joao


change-style-of-error-alerts-in-dialogs.patch
Description: Binary data

[pgadmin4][patch] fix history panel on ie11

2017-07-07 Thread Sarah McAlear 
Hi Hackers!

This patch fixes the layout issues on IE11. There is a known issue on
react-split-pane that requires a previous version of bowser in order to
render correctly on IE11. We had to downgrade the version of bowser to
1.6.1 until the relevant pull request to react-split-pane has been accepted.

Thanks!
Sarah & Rob
diff --git a/web/package.json b/web/package.json
index 0082d95e..8b2ccf5c 100644
--- a/web/package.json
+++ b/web/package.json
@@ -34,6 +34,7 @@
 "babel-polyfill": "^6.23.0",
 "babel-preset-es2015-without-strict": "~0.0.4",
 "babelify": "~7.3.0",
+"bowser": "1.6.1",
 "browserify": "~14.1.0",
 "exports-loader": "~0.6.4",
 "immutability-helper": "^2.2.0",
diff --git a/web/yarn.lock b/web/yarn.lock
index 9f091992..afe871da 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -864,9 +864,9 @@ boom@2.x.x:
   dependencies:
 hoek "2.x.x"
 
-bowser@^1.6.0:
-  version "1.7.0"
-  resolved 
"https://registry.yarnpkg.com/bowser/-/bowser-1.7.0.tgz#169de4018711f994242bff9a8009e77a1f35e003";
+bowser@1.6.1, bowser@^1.6.0:
+  version "1.6.1"
+  resolved 
"https://registry.yarnpkg.com/bowser/-/bowser-1.6.1.tgz#9157e9498f456e937173a2918f3b2161e5353eb3";
 
 brace-expansion@^1.1.7:
   version "1.1.8"