[OpenWrt-Devel] [PATCH] [routing] luci-app-bmx6: make configuration page fail less hard
When visiting the Configuration page under BMX, I get the following
error:
/usr/lib/lua/luci/dispatcher.lua:433: Failed to execute cbi dispatcher target
for entry '/admin/network/BMX6/Configuration'.
The called action terminated with an exception:
/usr/lib/lua/luci/model/cbi/bmx6/main.lua:54: bad argument #1 to 'ipairs'
(table expected, got nil)
stack traceback:
[C]: in function 'assert'
/usr/lib/lua/luci/dispatcher.lua:433: in function 'dispatch'
/usr/lib/lua/luci/dispatcher.lua:168: in function
There is a check in main.lua for nil options but it just sets a
message and continues, causing the above error later on. Adding a
return statement after setting the message causes the interface to at
least not die.
Signed-off-by: Bob Ham
---
luci-app-bmx6/files/usr/lib/lua/luci/model/cbi/bmx6/main.lua | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/luci-app-bmx6/files/usr/lib/lua/luci/model/cbi/bmx6/main.lua
b/luci-app-bmx6/files/usr/lib/lua/luci/model/cbi/bmx6/main.lua
index d4e0745..8ff3520 100644
--- a/luci-app-bmx6/files/usr/lib/lua/luci/model/cbi/bmx6/main.lua
+++ b/luci-app-bmx6/files/usr/lib/lua/luci/model/cbi/bmx6/main.lua
@@ -27,7 +27,8 @@ m = Map("bmx6", "bmx6")
-- Getting json and Checking if bmx6-json is avaiable
local options = bmx6json.get("options")
if options == nil or options.OPTIONS == nil then
-m.message = "bmx6-json plugin is not running or some mistake in
luci-bmx6 configuration, check /etc/config/luci-bmx6"
+ m.message = "bmx6-json plugin is not running or some mistake in
luci-bmx6 configuration, check /etc/config/luci-bmx6"
+ return m
else
options = options.OPTIONS
end
--
2.1.4
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] Patchwork patch state mysteriously changed to "Not applicable"
Hi there, I've received a message from patchwork saying that this patch http://patchwork.ozlabs.org/patch/576676/ now has the state of "Not applicable" but there are no comments and it doesn't say who changed the status. Is there a way for me to find out who changed the status and why? Is the responsibly party on this list and if so, could you explain? Without understanding why this patch is "Not applicable" I can't determine how to proceed with further development. Kind regards, Bob Ham ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patchwork patch state mysteriously changed to "Not applicable"
On Fri, 2016-02-12 at 11:03 +0100, Bastian Bittorf wrote: > * Bob Ham [12.02.2016 11:00]: > > now has the state of "Not applicable" but there are no comments and it > > doesn't say who changed the status. > > what I see is, that > 'luci-app-bmx6/files/usr/lib/lua/luci/model/cbi/bmx6/main.lua' is > at least does not belong to openwrt.git - you should send a pull-request > to the github/packages where luci-app-bmx6 is maintained. Are you saying that the openwrt-devel mailing list is intended to be used only for patches for openwrt.git? If so, this should be reflected in the documentation. I followed the instructions here: https://dev.openwrt.org/wiki/SubmittingPatches In particular, section 5 says: "Look in the Makefile if a MAINTAINER macro exists. If so, e-mail that person. Unless you have a reason NOT to do so, always CC openwrt-devel lists.openwrt.org. If no maintainer is listed, send your patch to the ​primary OpenWrt developer's mailing list." If the openwrt-devel mailing list is intended only for openwrt.git, where should patches for the feeds be sent? GitHub is a problem. Bob ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patchwork patch state mysteriously changed to "Not applicable"
Hi Pau, The patch I emailed is against the master branch of the openwrt-routing repository. Can you apply that? Regards, Bob On Fri, 2016-02-12 at 18:07 +0100, Pau wrote: > Hello Bob. > > I think it has been set as "Not applicable" because this package is part > of the openwrt-routing feed which is managed from another group of > volunteers. Plese, visit https://github.com/openwrt-routing > > Your contribution seems to be applicable, so it will be probably > approved. Thanks. > > Cheers. > > On 12/02/16 10:24, Bob Ham wrote: > > Hi there, > > > > I've received a message from patchwork saying that this patch > > > > http://patchwork.ozlabs.org/patch/576676/ > > > > now has the state of "Not applicable" but there are no comments and it > > doesn't say who changed the status. > > > > Is there a way for me to find out who changed the status and why? Is > > the responsibly party on this list and if so, could you explain? > > Without understanding why this patch is "Not applicable" I can't > > determine how to proceed with further development. > > > > Kind regards, > > > > Bob Ham > > > ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patchwork patch state mysteriously changed to "Not applicable"
On Fri, 2016-02-12 at 18:07 +0100, Pau wrote: > this package is part > of the openwrt-routing feed which is managed from another group of > volunteers. Plese, visit https://github.com/openwrt-routing PS, I note that this "OpenWrt Routing Organisation" lists openwrt-devel@lists.openwrt.org as its email address. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] GitHub and openwrt.org mailing lists (was: Patchwork patch state mysteriously changed to "Not applicable")
On Fri, 2016-02-12 at 20:52 +0100, Pau wrote: > Please, fork the project in github and send a pull request. This is the > way we normally work in openwrt-routing. GitHub is a problem because it's proprietary. Are you refusing to apply patches unless they come from GitHub pull requests? Because if so, that's a real big problem. By requiring that contributors use proprietary development tools, it undermines our freedom. There is a good essay about this by Benjamin Mako Hill: https://mako.cc/writing/hill-free_tools.html The openwrt.org organisers have infrastructure for mailing lists and I imagine they would be open to hosting lists for feed projects. Would the routing group be willing to make use of a development mailing list if openwrt.org offered to host one for them? That way you could accept contributions for the routing feed without requiring the use of GitHub but also without having to monitor the main, high-volume openwrt-devel mailing list. I've CC'd the openwrt-devel list again in this email as I would expect the administrators of openwrt.org will be present and I hope they might be willing to chime in. Kind regards, Bob Ham ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] GitHub and openwrt.org mailing lists (was: Patchwork patch state mysteriously changed to "Not applicable")
OK, cool. In future then, should I email yourself with patches and CC openwrt-devel as well? On Sat, 2016-02-13 at 02:48 +0100, pau wrote: > Hey I just said this is how we normally work. If you don't want to use > github, I (or other people from openwrt-routing) can apply your patch. I > never refused this option, the pull request is just more confortable. > > On 13 febrer de 2016 1:09:38 CET, Bob Ham wrote: > >On Fri, 2016-02-12 at 20:52 +0100, Pau wrote: > >> Please, fork the project in github and send a pull request. This is > >the > >> way we normally work in openwrt-routing. > > > >GitHub is a problem because it's proprietary. Are you refusing to > >apply > >patches unless they come from GitHub pull requests? Because if so, > >that's a real big problem. By requiring that contributors use > >proprietary development tools, it undermines our freedom. There is a > >good essay about this by Benjamin Mako Hill: > > > > https://mako.cc/writing/hill-free_tools.html > > > > > >The openwrt.org organisers have infrastructure for mailing lists and I > >imagine they would be open to hosting lists for feed projects. Would > >the routing group be willing to make use of a development mailing list > >if openwrt.org offered to host one for them? That way you could accept > >contributions for the routing feed without requiring the use of GitHub > >but also without having to monitor the main, high-volume openwrt-devel > >mailing list. > > > >I've CC'd the openwrt-devel list again in this email as I would expect > >the administrators of openwrt.org will be present and I hope they might > >be willing to chime in. > > > >Kind regards, > > > >Bob Ham > signature.asc Description: This is a digitally signed message part ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
