Re: [PATCH v2 0/12] add ubus support to ltq-[v|a]dsl-app
1/13/21 3:00 PM, Martin Schiller: On 2021-01-09 09:40, Andre Heider wrote: Hi, (cc'ed some recent commiters for lantiq) On 15/12/2020 10:35, Andre Heider wrote: v2: - drop 0002-ltq-vdsl-app-fix-Wundef-warnings.patch - use "/dev/dsl_cpe_api" without the "0" suffix for the adsl daemon: package/kernel/lantiq/ltq-adsl/patches/100-dsl_compat.patch:+ device_create(dsl_class, NULL, MKDEV(DRV_DSL_CPE_API_DEV_MAJOR, 0), NULL, "dsl_cpe_api"); package/kernel/lantiq/ltq-vdsl/patches/100-compat.patch:+ device_create(dsl_class, NULL, dsl_devt, NULL, "dsl_cpe_api0"); - use callDSLMetrics() for luci, per jo - add Tested-by tags This is to significantly speed up the generation of the metrics. The motivation comes from the fact that ~2.6s is just way too ineffcient for interval based metric collectors like prometheus or collectd. The luci status page also loads/refreshes alot faster. $ time /etc/init.d/dsl_control dslstat real 0m 2.66s user 0m 0.90s sys 0m 1.76s $ time ubus call dsl metrics real 0m 0.02s user 0m 0.00s sys 0m 0.01s The ltq-adsl-app changes are only compile time tested. who do I need to convince to review this? ;) I would also like this great work to be merged. Martin Sending a reviewed-by and/or tested-by (with devices it was tested on) might help to push this forward. best regards Mathias ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
RE: [PATCH 1/2] libnl: add libnl-cli library
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Pavel Šimerda > Sent: Donnerstag, 14. Januar 2021 03:39 > To: openwrt-devel@lists.openwrt.org > Cc: Pavel Šimerda > Subject: [PATCH 1/2] libnl: add libnl-cli library Hi, this has formal issues (like entirely missing commit message, missing SoB, ...). Please have another look at https://openwrt.org/submitting-patches Apart from that, do we need this in the main repo or could it also go into packages? Best Adrian > > --- > package/libs/libnl/Makefile | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/package/libs/libnl/Makefile b/package/libs/libnl/Makefile index > db0c65c7a7..3b9bad4533 100644 > --- a/package/libs/libnl/Makefile > +++ b/package/libs/libnl/Makefile > @@ -52,16 +52,26 @@ $(call Package/libnl/default) >DEPENDS:=+libnl-route > endef > > +define Package/libnl-cli > +$(call Package/libnl/default) > + TITLE:=Netlink Library CLI > + DEPENDS:=+libnl-genl +libnl-route +libnl-nf endef > + > define Package/libnl > $(call Package/libnl/default) >TITLE:=Full Netlink Library > - DEPENDS:=+libnl-genl +libnl-route +libnl-nf > + DEPENDS:=+libnl-genl +libnl-route +libnl-nf +libnl-cli > endef > > define Package/libnl-core/description > Common code for all netlink libraries > endef > > +define Package/libnl-cli/description > + CLI Netlink Library Functions > +endef > + > define Package/libnl-genl/description > Generic Netlink Library Functions > endef > @@ -92,6 +102,7 @@ define Build/InstallDev > > # Copy symlinks > $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnl-3.so $(1)/usr/lib/libnl.so > + $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnl-cli-3.so $(1)/usr/lib/libnl.so > $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnl-genl-3.so $(1)/usr/lib/libnl- > genl.so > $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnl-nf-3.so $(1)/usr/lib/libnl- > nf.so > $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnl-route-3.so $(1)/usr/lib/libnl- > route.so @@ -102,6 +113,11 @@ define Package/libnl-core/install > $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnl-3.so.* $(1)/usr/lib/ endef > > +define Package/libnl-cli/install > + $(INSTALL_DIR) $(1)/usr/lib > + $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnl-cli-3.so.* $(1)/usr/lib/ endef > + > define Package/libnl-genl/install > $(INSTALL_DIR) $(1)/usr/lib > $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnl-genl-3.so.* $(1)/usr/lib/ @@ > -122,6 +138,7 @@ define Package/libnl/install endef > > $(eval $(call BuildPackage,libnl-core)) > +$(eval $(call BuildPackage,libnl-cli)) > $(eval $(call BuildPackage,libnl-genl)) $(eval $(call > BuildPackage,libnl-route)) > $(eval $(call BuildPackage,libnl-nf)) > -- > 2.29.2 > > > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel openpgp-digital-signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2 0/12] add ubus support to ltq-[v|a]dsl-app
On 2021-01-14 12:55, Mathias Kresin wrote: 1/13/21 3:00 PM, Martin Schiller: On 2021-01-09 09:40, Andre Heider wrote: Hi, (cc'ed some recent commiters for lantiq) On 15/12/2020 10:35, Andre Heider wrote: v2: - drop 0002-ltq-vdsl-app-fix-Wundef-warnings.patch - use "/dev/dsl_cpe_api" without the "0" suffix for the adsl daemon: package/kernel/lantiq/ltq-adsl/patches/100-dsl_compat.patch:+ device_create(dsl_class, NULL, MKDEV(DRV_DSL_CPE_API_DEV_MAJOR, 0), NULL, "dsl_cpe_api"); package/kernel/lantiq/ltq-vdsl/patches/100-compat.patch:+ device_create(dsl_class, NULL, dsl_devt, NULL, "dsl_cpe_api0"); - use callDSLMetrics() for luci, per jo - add Tested-by tags This is to significantly speed up the generation of the metrics. The motivation comes from the fact that ~2.6s is just way too ineffcient for interval based metric collectors like prometheus or collectd. The luci status page also loads/refreshes alot faster. $ time /etc/init.d/dsl_control dslstat real 0m 2.66s user 0m 0.90s sys 0m 1.76s $ time ubus call dsl metrics real 0m 0.02s user 0m 0.00s sys 0m 0.01s The ltq-adsl-app changes are only compile time tested. who do I need to convince to review this? ;) I would also like this great work to be merged. Martin Sending a reviewed-by and/or tested-by (with devices it was tested on) might help to push this forward. OK. I've successfully tested the following parts of this patchset (v2) on our (TDT) xrx200 based systems: [01/13] ltq-vdsl-app: shutdown upon sigterm [02/12] ltq-vdsl-app: add ubus support to get metrics [04/12] luci-mod-status: use the new ubus dsl metrics [05/12] rpcd-mod-luci: get rid of now unused getDSLStatus ubus rpc [07/12] ltq-vdsl-app: use ubus to provide metrics [09/12] ltq-dsl-base: remove usused lantiq_dsl.sh [10/12] ltq-dsl-base: bump PKG_RELEASE [11/12] ltq-vdsl-app: bump PKG_RELEASE I am not able to test the ltq-adsl (Danube etc.) stuff. Tested-by: Martin Schiller It is also important to note that the output of dslstat has changed completely and lucistat no longer exists. If someone has processed the output directly, it must be reworked. Regards, Martin ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[no subject]
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.
To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
This adds a config option to allow compiling with HKDF algorithm support
to support applications that require this feature.
Backport from master.
Signed-off-by: Etan Kissling
---
package/libs/mbedtls/Makefile | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/package/libs/mbedtls/Makefile b/package/libs/mbedtls/Makefile
index 04033b1e47..ea8df0783c 100644
--- a/package/libs/mbedtls/Makefile
+++ b/package/libs/mbedtls/Makefile
@@ -20,7 +20,9 @@ PKG_BUILD_PARALLEL:=1
PKG_LICENSE:=GPL-2.0+
PKG_CPE_ID:=cpe:/a:arm:mbed_tls
-PKG_CONFIG_DEPENDS:=CONFIG_LIBMBEDTLS_DEBUG_C
+PKG_CONFIG_DEPENDS := \
+ CONFIG_LIBMBEDTLS_DEBUG_C \
+ CONFIG_LIBMBEDTLS_HKDF_C
include $(INCLUDE_DIR)/package.mk
include $(INCLUDE_DIR)/cmake.mk
@@ -56,6 +58,14 @@ config LIBMBEDTLS_DEBUG_C
by around 60 KiB (for an ARMv5 platform).
Usually, you don't need this, so don't select this if you're unsure.
+
+config LIBMBEDTLS_HKDF_C
+ depends on PACKAGE_libmbedtls
+ bool "Enable the HKDF algorithm (RFC 5869)"
+ default n
+ help
+This option adds support for the Hashed Message Authentication Code
+(HMAC)-based key derivation function (HKDF).
endef
define Package/mbedtls-util
@@ -96,6 +106,13 @@ define Build/Configure
END { exit(rc) }' $(PKG_BUILD_DIR)/include/mbedtls/config.h \
>$(PKG_BUILD_DIR)/include/mbedtls/config.h.new && \
mv $(PKG_BUILD_DIR)/include/mbedtls/config.h.new
$(PKG_BUILD_DIR)/include/mbedtls/config.h
+
+ awk 'BEGIN { rc = 1 } \
+/#define MBEDTLS_HKDF_C/ { 0 = "$(if
$(CONFIG_LIBMBEDTLS_HKDF_C),,// )#define MBEDTLS_HKDF_C"; rc = 0 } \
+{ print } \
+END { exit(rc) }' $(PKG_BUILD_DIR)/include/mbedtls/config.h \
+>$(PKG_BUILD_DIR)/include/mbedtls/config.h.new && \
+ mv $(PKG_BUILD_DIR)/include/mbedtls/config.h.new
$(PKG_BUILD_DIR)/include/mbedtls/config.h
endef
define Build/InstallDev
--
2.21.1 (Apple Git-122.3)
--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[no subject]
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.
To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
This allows configuration of multicast_to_unicast and per_sta_vif options.
- multicast_to_unicast requests multicast-to-unicast conversion.
- per_sta_vif assigns each station its own AP_VLAN interface.
Backport from master.
Signed-off-by: Etan Kissling
---
package/network/services/hostapd/files/hostapd.sh | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/package/network/services/hostapd/files/hostapd.sh
b/package/network/services/hostapd/files/hostapd.sh
index 79e71616dc..603b5a0c80 100644
--- a/package/network/services/hostapd/files/hostapd.sh
+++ b/package/network/services/hostapd/files/hostapd.sh
@@ -245,6 +245,8 @@ hostapd_common_add_bss_config() {
config_add_boolean sae_require_mfp
config_add_string 'owe_transition_bssid:macaddr'
'owe_transition_ssid:string'
+
+ config_add_boolean multicast_to_unicast per_sta_vif
}
hostapd_set_bss_options() {
@@ -267,7 +269,8 @@ hostapd_set_bss_options() {
iapp_interface eapol_version dynamic_vlan ieee80211w nasid \
acct_server acct_secret acct_port acct_interval \
bss_load_update_period chan_util_avg_period sae_require_mfp \
- multi_ap multi_ap_backhaul_ssid multi_ap_backhaul_key
+ multi_ap multi_ap_backhaul_ssid multi_ap_backhaul_key \
+ multicast_to_unicast per_sta_vif
set_default isolate 0
set_default maxassoc 0
@@ -627,6 +630,16 @@ hostapd_set_bss_options() {
}
}
+ set_default multicast_to_unicast 0
+ if [ "$multicast_to_unicast" -gt 0 ]; then
+ append bss_conf "multicast_to_unicast=$multicast_to_unicast"
"$N"
+ fi
+
+ set_default per_sta_vif 0
+ if [ "$per_sta_vif" -gt 0 ]; then
+ append bss_conf "per_sta_vif=$per_sta_vif" "$N"
+ fi
+
append "$var" "$bss_conf" "$N"
return 0
}
--
2.21.1 (Apple Git-122.3)
--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[no subject]
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- This enables the CTRL_IFACE_MIB symbol for wpad-full and hostapd-full. If it is not enabled, statistic outputs such as "hostapd_cli all_sta" are empty. Signed-off-by: David Bauer [etan_kissl...@apple.com: Backport from master.] Signed-off-by: Etan Kissling --- package/network/services/hostapd/files/hostapd-basic.config | 5 + package/network/services/hostapd/files/hostapd-full.config | 5 + package/network/services/hostapd/files/hostapd-mini.config | 5 + .../services/hostapd/files/wpa_supplicant-basic.config | 5 + .../services/hostapd/files/wpa_supplicant-full.config| 5 + .../services/hostapd/files/wpa_supplicant-mini.config| 5 + .../network/services/hostapd/files/wpa_supplicant-p2p.config | 5 + 7 files changed, 35 insertions(+) diff --git a/package/network/services/hostapd/files/hostapd-basic.config b/package/network/services/hostapd/files/hostapd-basic.config index 461b178433..19ea850f6b 100644 --- a/package/network/services/hostapd/files/hostapd-basic.config +++ b/package/network/services/hostapd/files/hostapd-basic.config @@ -394,3 +394,8 @@ CONFIG_TLS=internal # Services can connect to the bus and provide methods # that can be called by other services or clients. CONFIG_UBUS=y + +# OpenWrt patch 380-disable-ctrl-iface-mib.patch +# leads to the MIB only being compiled in if +# CONFIG_CTRL_IFACE_MIB is enabled. +#CONFIG_CTRL_IFACE_MIB=y diff --git a/package/network/services/hostapd/files/hostapd-full.config b/package/network/services/hostapd/files/hostapd-full.config index 5c9fbed2e4..0ecce423e7 100644 --- a/package/network/services/hostapd/files/hostapd-full.config +++ b/package/network/services/hostapd/files/hostapd-full.config @@ -394,3 +394,8 @@ CONFIG_TAXONOMY=y # Services can connect to the bus and provide methods # that can be called by other services or clients. CONFIG_UBUS=y + +# OpenWrt patch 380-disable-ctrl-iface-mib.patch +# leads to the MIB only being compiled in if +# CONFIG_CTRL_IFACE_MIB is enabled. +CONFIG_CTRL_IFACE_MIB=y diff --git a/package/network/services/hostapd/files/hostapd-mini.config b/package/network/services/hostapd/files/hostapd-mini.config index f31e6467b0..d9511441e6 100644 --- a/package/network/services/hostapd/files/hostapd-mini.config +++ b/package/network/services/hostapd/files/hostapd-mini.config @@ -394,3 +394,8 @@ CONFIG_TLS=internal # Services can connect to the bus and provide methods # that can be called by other services or clients. CONFIG_UBUS=y + +# OpenWrt patch 380-disable-ctrl-iface-mib.patch +# leads to the MIB only being compiled in if +# CONFIG_CTRL_IFACE_MIB is enabled. +#CONFIG_CTRL_IFACE_MIB=y diff --git a/package/network/services/hostapd/files/wpa_supplicant-basic.config b/package/network/services/hostapd/files/wpa_supplicant-basic.config index e2bd1866c4..a9da65deed 100644 --- a/package/network/services/hostapd/files/wpa_supplicant-basic.config +++ b/package/network/services/hostapd/files/wpa_supplicant-basic.config @@ -618,3 +618,8 @@ CONFIG_GETRANDOM=y # Services can connect to the bus and provide methods # that can be called by other services or clients. CONFIG_UBUS=y + +# OpenWrt patch 380-disable-ctrl-iface-mib.patch +# leads to the MIB only being compiled in if +# CONFIG_CTRL_IFACE_MIB is enabled. +#CONFIG_CTRL_IFACE_MIB=y diff --git a/package/network/services/hostapd/files/wpa_supplicant-full.config b/package/network/services/hostapd/files/wpa_supplicant-full.config index e5a6752a8e..982f4d5534 100644 --- a/package/network/services/hostapd/files/wpa_supplicant-full.config +++ b/package/network/services/hostapd/files/wpa_supplicant-full.config @@ -618,3 +618,8 @@ CONFIG_IBSS_RSN=y # Services can connect to the bus and provide methods # that can be called by other services or clients. CONFIG_UBUS=y + +# OpenWrt patch 380-disable-ctrl-iface-mib.patch +# leads to the MIB only being compiled in if +# CONFIG_CTRL_IFACE_MIB is enabled. +CONFIG_CTRL_IFACE_MIB=y diff --git a/package/network/services/hostapd/files/wpa_supplicant-mini.config b/package/network/services/hostapd/files/wpa_supplicant-mini.config index 6af4693c53..850d22febc 100644 --- a/package/network/services/hostapd/files/wpa_supplicant-mini.config +++ b/package/network/services/hostapd/files/wpa_supplicant-mini.config @@ -618,3 +618,8 @@ CONFIG_GETRANDOM=y # Services can connect to the bus and provide methods # that can be called by other services or clients. CONFIG_UBUS=y + +# OpenWrt patch 380-disable-ctrl-iface-mib.patch +# leads to the MIB only being compiled in if +# CONFIG_CTRL_IFACE_MIB is enabled. +#CONFIG_CTRL_IFACE_MIB=y diff --git a/package/network/services/hostapd/files/wpa_supplicant-p2p.config b/package/network/services/ho
[PATCH] kernel: make lwtunnel support optional
Not everyone will want to bloat their kernel by 24 kiB for such a niche feature. Fixes: a1a7f3274e0ed27511d45f62ee20281d8d57c7af "kernel: enable SRv6 support by enabling lwtunnel" Signed-off-by: Rui Salvaterra --- config/Config-kernel.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/config/Config-kernel.in b/config/Config-kernel.in index d99ce44c0d..8a78e297cb 100644 --- a/config/Config-kernel.in +++ b/config/Config-kernel.in @@ -975,9 +975,10 @@ if KERNEL_IPV6 def_bool n config KERNEL_IPV6_SEG6_LWTUNNEL - def_bool y if !SMALL_FLASH + bool "Enable support for lightweight tunnels" + default y if !SMALL_FLASH help - Using lwtunnel requires full-ip package. + Using lwtunnel (needed for IPv6 segment routing) requires ip-full package. config KERNEL_LWTUNNEL_BPF def_bool n -- 2.30.0 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: ath10k-ct all hash values are different?
On 1/13/21 4:58 PM, Sven Roederer wrote: Ben, seems to me, that at least "firmware-5-ct-full-community-12.bin-lede.013" is still not recovered. File is there, but contains only 0x00. This seems to cause my fresh build of 19.07.5 to fail. Yes, I verified that 9980 firmware is not recovered. I'm not sure we have any local copy of that old file. Maybe someone else that has compiled this in the past has a working copy they could send me to repopulate my web server? Thanks, Ben + curl -f --connect-timeout 20 --retry 5 --location --insecure https:// www.candelatech.com/downloads/ath10k-10-4b/firmware-5-ct-full- community-12.bin-lede.013 % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 548k 100 548k0 0 985k 0 --:--:-- --:--:-- --:--:-- 985k Hash of the downloaded file does not match (file: 6a95c4323e008499af8d3549513c8a128c69b97296888a4c4b642e6c14a65508, requested: 6fa74a3fc87cba97dbc4a7213b760f8d997cd9c5f11900d47d387b23764cf20a) - deleting download. Can you check please? Sven ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel -- Ben Greear Candela Technologies Inc http://www.candelatech.com ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: ath10k-ct all hash values are different?
On 1/14/21 10:05 AM, Ben Greear wrote: On 1/13/21 4:58 PM, Sven Roederer wrote: Ben, seems to me, that at least "firmware-5-ct-full-community-12.bin-lede.013" is still not recovered. File is there, but contains only 0x00. This seems to cause my fresh build of 19.07.5 to fail. Yes, I verified that 9980 firmware is not recovered. I'm not sure we have any local copy of that old file. Maybe someone else that has compiled this in the past has a working copy they could send me to repopulate my web server? If my grep is correct, these files are also corrupted, so if someone has these cached somewhere, please send these to me I'll get them re-populated as well. [greearb@ww2 downloads]$ find . -name "firmware-*lede*" -print|xargs grep -L ATH10 ./firmware-2-ct-full-htt-mgt-community-22.bin.lede.020 ./firmware-2-ct-full-community-22.bin.lede.003 ./ath10k-9984-10-4b/firmware-5-ct-full-community-12.bin-lede.016 ./ath10k-9984-10-4b/firmware-5-ct-full-community-12.bin-lede.020 ./ath10k-9984-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.020 ./ath10k-9984-10-4b/firmware-5-ct-htt-mgt-community-qcache-12.bin-lede.020 ./ath10k-9984-10-4b/firmware-5-ct-htt-mgt-community-12.bin-lede.020 ./ath10k-9984-10-4b/firmware-5-ct-htt-mgt-community-qcache-12.bin-lede.021 ./ath10k-9984-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.016 ./ath10k-9984-10-4/firmware-5-ct-full-community-7.bin-lede.001 ./ath10k-9984-10-4/firmware-5-ct-full-community-8.bin-lede.006 ./ath10k-9984-10-4/firmware-5-ct-full-community-7.bin-lede.004 ./ath10k-9984-10-4/firmware-5-ct-full-community-9.bin-lede.003 ./firmware-2-ct-full-htt-mgt-community-22.bin.lede.003 ./firmware-2-ct-full-community-22.bin.lede.016 ./ath10k-9887/firmware-2-ct-full-htt-mgt-community-22.bin.lede.020 ./ath10k-9887/firmware-2-ct-full-community-22.bin.lede.020 ./ath10k-9887/firmware-2-ct-full-htt-mgt-community-22.bin.lede.004 ./ath10k-9887/firmware-2-ct-full-community-22.bin.lede.004 ./firmware-2-ct-full-community-22.bin.lede.020 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.006 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.012 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.007 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.016 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.020 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.008 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.001 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.020 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.003 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.018 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.002 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.005 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.003 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.013 ./ath10k-10-4b/firmware-5-ct-htt-mgt-community-qcache-12.bin-lede.020 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.009 ./ath10k-10-4b/firmware-5-ct-htt-mgt-community-12.bin-lede.020 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.010 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.015 ./ath10k-10-4b/firmware-5-ct-htt-mgt-community-qcache-12.bin-lede.021 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.017 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.016 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.014 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.007 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.004 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.018 ./ath10k-10-4b/firmware-5-ct-htt-mgt-community-12.bin-lede.018 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.005 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.002 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.014 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.004 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.011 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.011 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.012 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.017 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.013 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.006 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.001 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.010 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.008 ./ath10k-10-4b/firmware-5-ct-full-community-12.bin-lede.009 ./ath10k-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.015 ./firmware-2-ct-full-community.bin-18.rc1-lede ./ath10k-9888-10-4b/firmware-5-ct-full-community-12.bin-lede.016 ./ath10k-9888-10-4b/firmware-5-ct-full-community-12.bin-lede.020 ./ath10k-9888-10-4b/firmware-5-ct-full-htt-mgt-community-12.bin-lede.020 ./ath10k-9888-10-4b/firmware-5-ct-htt-mgt-c
Re: [PATCH v3] ath79: Add support for Ubiquiti Bullet AC
Checking if there is an obstacle to merging this.
--
Russell Senior
russ...@personaltelco.net
On Tue, Dec 22, 2020 at 6:39 PM Russell Senior
wrote:
>
>
> CPU: Atheros AR9342 rev 3 SoC
> RAM: 64 MB DDR2
> Flash: 16 MB NOR SPI
> WLAN 2.4GHz: Atheros AR9342 v3 (ath9k)
> WLAN 5.0GHz: QCA988X
> Ports: 1x GbE
>
> Flashing procedure is identical to other ubnt devices.
> https://openwrt.org/toh/ubiquiti/common
>
> Flashing through factory firmware
> 1. Ensure firmware version v8.7.0 is installed.
>Up/downgrade to this exact version.
> 2. Patch fwupdate.real binary using
>`hexdump -Cv /bin/ubntbox | sed 's/14 40 fe 27/00 00 00 00/g' | \
> hexdump -R > /tmp/fwupdate.real`
> 3. Make the patched fwupdate.real binary executable using
>`chmod +x /tmp/fwupdate.real`
> 4. Copy the squashfs factory image to /tmp on the device
> 5. Flash OpenWrt using `/tmp/fwupdate.real -m `
> 6. Wait for the device to reboot
> (copied from Ubiquiti NanoBeam AC and modified)
>
> Flashing from serial console
> 1. Connect serial console (115200 baud)
> 2. Connect ethernet to a network with a TFTP server, through a
>passive PoE injector.
> 3. Press a key to obtain a u-boot prompt
> 4. Set your TFTP server's ip address, with:
>setenv serverip
> 5. Set the Bullet AC's ip address, with:
>setenv ipaddr
> 6. Set the boot file, with:
>setenv bootfile
> 7. Fetch the binary with tftp:
>tftpboot
> 8. Boot the initramfs binary:
>bootm
> 9. From the initramfs, fetch the sysupgrade binary, and flash it with
>sysupgrade.
>
> The Bullet AC is identified as a 2WA board by Ubiquiti. As such, the UBNT_TYPE
> must match from the "Flashing through factory firmware" install instructions
> to work.
>
> Phy0 is QCA988X which can tune either band (2.4 or 5GHz). Phy1 is AR9342,
> on which 5GHz is disabled. It isn't currently known whether phy1 is
> routed to the N connector at all.
>
> Signed-off-by: Russell Senior
> ---
> v2:
> - Make "Flashing through factory firmware" instructions actually work by
> changing UBNT_TYPE to 2WA
> v3:
> - Added a note to the commit message about 2WA boards
> - reordered section in 01_leds to preserve ordering as requested
> ---
> .../linux/ath79/dts/ar9342_ubnt_bullet-ac.dts | 38 +++
> .../generic/base-files/etc/board.d/01_leds| 21 +-
> .../generic/base-files/etc/board.d/02_network | 1 +
> .../etc/hotplug.d/firmware/11-ath10k-caldata | 1 +
> target/linux/ath79/image/generic-ubnt.mk | 17 +
> 5 files changed, 68 insertions(+), 10 deletions(-)
> create mode 100644 target/linux/ath79/dts/ar9342_ubnt_bullet-ac.dts
>
> diff --git a/target/linux/ath79/dts/ar9342_ubnt_bullet-ac.dts
> b/target/linux/ath79/dts/ar9342_ubnt_bullet-ac.dts
> new file mode 100644
> index 00..be0b0792bb
> --- /dev/null
> +++ b/target/linux/ath79/dts/ar9342_ubnt_bullet-ac.dts
> @@ -0,0 +1,38 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +#include "ar9342_ubnt_wa_1port.dtsi"
> +
> +/ {
> + compatible = "ubnt,bullet-ac", "ubnt,wa", "qca,ar9342";
> + model = "Ubiquiti Bullet AC (2WA)";
> +
> + aliases {
> + led-boot = &led_rssi3;
> + led-failsafe = &led_rssi3;
> + led-upgrade = &led_rssi3;
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + rssi0 {
> + label = "blue:rssi0";
> + gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
> + };
> +
> + rssi1 {
> + label = "blue:rssi1";
> + gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> + };
> +
> + rssi2 {
> + label = "blue:rssi2";
> + gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
> + };
> +
> + led_rssi3: rssi3 {
> + label = "blue:rssi3";
> + gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
> + };
> + };
> +};
> diff --git a/target/linux/ath79/generic/base-files/etc/board.d/01_leds
> b/target/linux/ath79/generic/base-files/etc/board.d/01_leds
> index 443e81..9bbdc39204 100755
> --- a/target/linux/ath79/generic/base-files/etc/board.d/01_leds
> +++ b/target/linux/ath79/generic/base-files/etc/board.d/01_leds
> @@ -349,6 +349,17 @@ tplink,tl-wr842n-v2)
> trendnet,tew-823dru)
> ucidef_set_led_netdev "wan" "WAN" "green:planet" "eth0"
> ;;
> +ubnt,bullet-ac|\
> +ubnt,nanobeam-ac|\
> +ubnt,nanobeam-ac-gen2|\
> +ubnt,nanostation-ac|\
> +ubnt,powerbeam-5ac-gen2)
> + ucidef_set_rssimon "wlan0" "20" "1"
> + ucidef_set_led_rssi "rssilow" "RSSILOW" "blue:rssi0" "wlan0" "1" "100"
> + ucidef_set_led_rssi "rssimediumlow" "RSSIMEDIUMLOW" "blue:rssi1"
> "wlan0" "26" "100"
> + ucidef_set_led_rssi "rssimediumhigh" "RSSIMEDIUMHIGH" "blue:rssi2"
> "wlan0" "51" "100"
> + ucidef_set_led_rssi "rssihigh" "RSSIHIGH" "b
Re: [PATCH v2 0/12] add ubus support to ltq-[v|a]dsl-app
Hi, On 14/01/2021 13:34, Martin Schiller wrote: On 2021-01-14 12:55, Mathias Kresin wrote: 1/13/21 3:00 PM, Martin Schiller: On 2021-01-09 09:40, Andre Heider wrote: Hi, (cc'ed some recent commiters for lantiq) On 15/12/2020 10:35, Andre Heider wrote: v2: - drop 0002-ltq-vdsl-app-fix-Wundef-warnings.patch - use "/dev/dsl_cpe_api" without the "0" suffix for the adsl daemon: package/kernel/lantiq/ltq-adsl/patches/100-dsl_compat.patch:+ device_create(dsl_class, NULL, MKDEV(DRV_DSL_CPE_API_DEV_MAJOR, 0), NULL, "dsl_cpe_api"); package/kernel/lantiq/ltq-vdsl/patches/100-compat.patch:+ device_create(dsl_class, NULL, dsl_devt, NULL, "dsl_cpe_api0"); - use callDSLMetrics() for luci, per jo - add Tested-by tags This is to significantly speed up the generation of the metrics. The motivation comes from the fact that ~2.6s is just way too ineffcient for interval based metric collectors like prometheus or collectd. The luci status page also loads/refreshes alot faster. $ time /etc/init.d/dsl_control dslstat real 0m 2.66s user 0m 0.90s sys 0m 1.76s $ time ubus call dsl metrics real 0m 0.02s user 0m 0.00s sys 0m 0.01s The ltq-adsl-app changes are only compile time tested. who do I need to convince to review this? ;) I would also like this great work to be merged. Martin Sending a reviewed-by and/or tested-by (with devices it was tested on) might help to push this forward. OK. I've successfully tested the following parts of this patchset (v2) on our (TDT) xrx200 based systems: [01/13] ltq-vdsl-app: shutdown upon sigterm [02/12] ltq-vdsl-app: add ubus support to get metrics [04/12] luci-mod-status: use the new ubus dsl metrics [05/12] rpcd-mod-luci: get rid of now unused getDSLStatus ubus rpc [07/12] ltq-vdsl-app: use ubus to provide metrics [09/12] ltq-dsl-base: remove usused lantiq_dsl.sh [10/12] ltq-dsl-base: bump PKG_RELEASE [11/12] ltq-vdsl-app: bump PKG_RELEASE I am not able to test the ltq-adsl (Danube etc.) stuff. Tested-by: Martin Schiller thanks again, your tags are already part of v2 based on v1 feedback. Well except on 11/12, but if there isn't another reason to respin this series I'll refrain from sending a v3 for just the tag on a version bump ;) It is also important to note that the output of dslstat has changed completely and lucistat no longer exists. If someone has processed the output directly, it must be reworked. Indeed, which is why I adapted all in-tree users. I'm only aware of one downstream usage, a collectd plugin using the old dslstats. There is a PR on the package repo [0] about it, which is already waiting for this set to go in. [0] https://github.com/openwrt/packages/pull/12175 Thanks, Andre ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
