Re: [OpenWrt-Devel] [PATCH 1/1] netifd: add pre-up/down post-up/down callback handling
I know this is done wit the uci option auto for this interface. But if I disable this flag, then on the next boot this interface does not start on boot anymore. I have to start this manual. So I think this is not an option. No, I'm talking about the internal per-interface 'autostart' variable, which gets set to false if the user does a manual ifdown of an interface (but not if it just failed to start up). That doesn't help me. If I do an manual ifup (CLI) or an ubus call the value does change. I could not difference if this is a manual command by CLI or a direct ubus call. In my case a connection has been established by the protocol handler successfully by netif. But in the course of the established connection there is an error. To track this I am using the mwan3. The error can have different reasons. The problem I have especially with wireless cellular interfaces. * Layer 3 problem by the provider or in his backend * Bug in the Modem firmware Netifd can't detect this, because the operstate does not change on radio devices the firmware of the modem does not support this. Or it is an other problem that does not have to do with the modem. The only thing that helps me is to reestablish the connection with an ifup (CLI) or an ubus call. The Problem is now i can not stop the connection because it is for now not possible to distinguish if the stop is a user interaction or a script interaction. So If I only use ubus call on my script and user interaction uses ifup/ifdown CLI command and if I set a flag by ifup/ifdown I could solve my issue. So that if a user uses ifup/ifdown set the flag and so could proper stop the connection. The restart code could does test the flag an so does not restart on user interaction by the ifup/ifdown CLI command. I can also imagine that we extend the netifd so that we add a flag to the ubus call if it is a user interaction via the script ifup/ifdown. This way I can distinguish if the connection is coming from a script or the command ifup/ifdown. This is a very precise solution. The other one is more a general solution with which other things are possible. @felix thanks for reply :-) - Florian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] x86/geode: add missing include after rebase
The x86 image generation was refacted via cb007a7bf6 and accidently not included `geode.mk` when selected as subtarget. Now the file is included and image compilation for x86/geode works again. Thanks to Russell Senior for reporting the problem and suggesting a patch! Signed-off-by: Paul Spooren --- target/linux/x86/image/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/target/linux/x86/image/Makefile b/target/linux/x86/image/Makefile index c01065f8e6..c2961e5b9c 100644 --- a/target/linux/x86/image/Makefile +++ b/target/linux/x86/image/Makefile @@ -128,6 +128,10 @@ ifeq ($(SUBTARGET),generic) include generic.mk endif +ifeq ($(SUBTARGET),geode) + include geode.mk +endif + ifeq ($(SUBTARGET),legacy) include legacy.mk endif -- 2.25.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] x86/geode: add missing include after rebase
> Paul Spooren writes: Comments below. > The x86 image generation was refacted via cb007a7bf6 and accidently > not included `geode.mk` when selected as subtarget. > Now the file is included and image compilation for x86/geode works > again. > Thanks to Russell Senior for reporting the > problem and suggesting a patch! The patch is due to Tomasz Maciej Nowak (tmn505). Also, we need the FEATURES modified in target/linux/x86/geode/target.mk, as it is missing needed features, minimally boot-part rootfs-part squashfs ext4 and perhaps others. And, when building for alix, I get prompted for kernel config variables: SCSI_FDOMAIN_ISA, I2C_AMD_MP2, PCENGINES_APU2. I notice that there is a kernel config CONFIG_ALIX disabled in target/linux/x86/config-5.4, seems like it would be useful for an alix build? -- Russell Senior, President russ...@personaltelco.net ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 2/6] x86: switch image generation to new code
On Fri, Mar 20, 2020 at 6:37 PM Paul Spooren wrote: > This commit introduces few related changes which need to be done in > single commit to keep images buildable between git revisions. In result > it retains all previous image creation possibilities with slight name > change of generated images. Brief summary of the commit: > Would it be possible to restore the building of a separate kernel and rootfs? It's much easier to resize a rootfs than a disk image. (Or alternatively, an easy way to enlarge disk images would be welcome.) Thanks, Jeff ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ath79: fix NAND driver compilation for kernel 5.4
On Sun, 22 Mar 2020 20:01:57 +0100 David Bauer wrote: > Hi Michal > > > I'm not that deep into the mtd-concat hack (expecially on NAND > flash). We might also run into issues when migrating to the new NAND > interface. If you you've found a fix for this, it would be great to > have it up for discussion on ML or GitHub. Especially as this is more > or less target independant and not directly associated with the ath79 > driver. > > Best wishes > David > Hello David, Yes, I'm going to have a deeper look at mtdconcat driver and try to modify its behaviour to be consistent with what is now required by mtdcore. Concat is a virtual device, address translation layer mainly, so understanding how it works should not require any deep flash hacking knowledge. Cheers Michal ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ath79: fix NAND driver compilation for kernel 5.4
Hello!! A little bit off-topic question: I encountered an issue due to a patch causing issues on ramips: ... so my Zbtlink ZBT-WG3526 (32M) behaved like SPI flash was damaged. After reverting the patch, anything was OK and the device is still running fine. So, my question is: are there chances of damaing the flash chip when running on those situations where bugs happen? and, what if things like those would happen in NAND flash devices? What if, for example, we mark as bad a block that wasn't bad after all? thanks!! Enrico On Mon, 23 Mar 2020, Michal Cieslakiewicz wrote: Date: Mon, 23 Mar 2020 17:20:42 From: Michal Cieslakiewicz To: David Bauer Cc: openwrt-devel@lists.openwrt.org Subject: Re: [OpenWrt-Devel] [PATCH] ath79: fix NAND driver compilation for kernel 5.4 On Sun, 22 Mar 2020 20:01:57 +0100 David Bauer wrote: Hi Michal I'm not that deep into the mtd-concat hack (expecially on NAND flash). We might also run into issues when migrating to the new NAND interface. If you you've found a fix for this, it would be great to have it up for discussion on ML or GitHub. Especially as this is more or less target independant and not directly associated with the ath79 driver. Best wishes David Hello David, Yes, I'm going to have a deeper look at mtdconcat driver and try to modify its behaviour to be consistent with what is now required by mtdcore. Concat is a virtual device, address translation layer mainly, so understanding how it works should not require any deep flash hacking knowledge. Cheers Michal ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel Enrico Mioso Personal Phone Number: +39 3807096934 Tox ID is: 7C593F402A3C8632D87AB4B948D492294C39A6A614464ECF843CA3429FB023284180472C7475 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ath79: fix NAND driver compilation for kernel 5.4
sorry, I forgot to mention the commit... In my case I am referring to an issue with commit 15a0701cdde8eeae2a54880b813cdb8cdc09a384. fixed with commit fdfca33350150644481096f1c7a80db2b670cdec from David. Thanks! On Mon, 23 Mar 2020, Michal Cieslakiewicz wrote: Date: Mon, 23 Mar 2020 17:20:42 From: Michal Cieslakiewicz To: David Bauer Cc: openwrt-devel@lists.openwrt.org Subject: Re: [OpenWrt-Devel] [PATCH] ath79: fix NAND driver compilation for kernel 5.4 On Sun, 22 Mar 2020 20:01:57 +0100 David Bauer wrote: Hi Michal I'm not that deep into the mtd-concat hack (expecially on NAND flash). We might also run into issues when migrating to the new NAND interface. If you you've found a fix for this, it would be great to have it up for discussion on ML or GitHub. Especially as this is more or less target independant and not directly associated with the ath79 driver. Best wishes David Hello David, Yes, I'm going to have a deeper look at mtdconcat driver and try to modify its behaviour to be consistent with what is now required by mtdcore. Concat is a virtual device, address translation layer mainly, so understanding how it works should not require any deep flash hacking knowledge. Cheers Michal ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel Enrico Mioso Personal Phone Number: +39 3807096934 Tox ID is: 7C593F402A3C8632D87AB4B948D492294C39A6A614464ECF843CA3429FB023284180472C7475 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] x86/geode: fixup FEATURE inheritance
In the geode subtarget all default x86 features were overwritten via := instead of extending them via +=. This patch fixes the inheritance and thereby the compilation of x86/geode target. Compile tested x86/geode. Signed-off-by: Paul Spooren --- target/linux/x86/geode/target.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/x86/geode/target.mk b/target/linux/x86/geode/target.mk index f4c7b9564e..f69e8cada5 100644 --- a/target/linux/x86/geode/target.mk +++ b/target/linux/x86/geode/target.mk @@ -1,5 +1,5 @@ BOARDNAME:=AMD Geode based systems -FEATURES:=pci usb gpio +FEATURES += pci usb gpio DEFAULT_PACKAGES += \ kmod-crypto-hw-geode kmod-crypto-cbc \ kmod-ath5k kmod-ath9k \ -- 2.25.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [RFC] Support for ZyXEL LTE3301-Plus / Image format known?
Hi! I have written support for the LTE3301-Plus device for OpenWRT. But my main problem is that Zyxel only gave me an binary imagebuilder. If anybody is interested I can provide the needed OpenWRT patch and the binary. Perhaps someone is able to decompile it and back or even better, the format is known :-) _SPECS:_ 4 Cores (HT) MT7621 128MB Flash, ~60MB usable 256MB RAM 4x switched ethernet ports 1x MT7615E Wifi 1x USB3 1x Quectel LTE modem _Dump of image head_ 30 52 44 48 00 00 01 7c 00 40 00 00 ab 7d 80 2e |0RDH...|.@...}..| 0010 35 2e 30 2e 30 2e 30 0a 00 00 00 00 00 00 00 00 |5.0.0.0.| 0020 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 || 0030 0a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 || 0040 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 || 0050 00 3f fe 84 00 00 00 00 00 00 00 00 00 00 00 00 |.?..| 0060 33 20 36 30 33 35 20 31 32 32 20 30 0a 00 00 00 |3 6035 122 0| 0070 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 || * 0100 00 00 00 00 4d 54 37 36 32 31 41 00 4c 54 45 33 |MT7621A.LTE3| 0110 33 30 31 2d 50 4c 55 53 00 00 00 00 03 03 00 01 |301-PLUS| 0120 00 00 00 00 00 00 00 00 31 2e 30 30 28 41 42 51 |1.00(ABQ| 0130 55 2e 31 29 43 30 00 00 00 00 00 00 00 00 00 00 |U.1)C0..| 0140 00 00 00 00 00 00 00 00 31 2e 30 30 28 41 42 51 |1.00(ABQ| 0150 55 2e 31 29 43 30 00 00 00 00 00 00 00 00 00 00 |U.1)C0..| 0160 00 00 00 00 00 00 00 00 00 00 00 00 72 11 ad 2f |r../| 0170 00 00 00 00 9d 11 5b c6 00 00 00 00 27 05 19 56 |..[.'..V| Kind regards, André smime.p7s Description: S/MIME Cryptographic Signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH 2/3] busybox: backport stime() removal fix for glibc 2.31
glibc 2.31 does not provide stime() any more, backport a fix from
current busybox master to avoid using this function.
Signed-off-by: Hauke Mehrtens
---
.../001-remove-stime-function-calls.patch | 84 +++
1 file changed, 84 insertions(+)
create mode 100644
package/utils/busybox/patches/001-remove-stime-function-calls.patch
diff --git
a/package/utils/busybox/patches/001-remove-stime-function-calls.patch
b/package/utils/busybox/patches/001-remove-stime-function-calls.patch
new file mode 100644
index ..ccf9bef35657
--- /dev/null
+++ b/package/utils/busybox/patches/001-remove-stime-function-calls.patch
@@ -0,0 +1,84 @@
+From d3539be8f27b8cbfdfee460fe08299158f08bcd9 Mon Sep 17 00:00:00 2001
+From: Alistair Francis
+Date: Tue, 19 Nov 2019 13:06:40 +0100
+Subject: Remove stime() function calls
+
+stime() has been deprecated in glibc 2.31 and replaced with
+clock_settime(). Let's replace the stime() function calls with
+clock_settime() in preperation.
+
+function old new delta
+rdate_main 197 224 +27
+clock_settime - 27 +27
+date_main926 941 +15
+stime 37 - -37
+--
+(add/remove: 2/2 grow/shrink: 2/0 up/down: 69/-37) Total: 32 bytes
+
+Signed-off-by: Alistair Francis
+Signed-off-by: Denys Vlasenko
+---
+ coreutils/date.c | 6 +-
+ libbb/missing_syscalls.c | 8
+ util-linux/rdate.c | 8 ++--
+ 3 files changed, 11 insertions(+), 11 deletions(-)
+
+--- a/coreutils/date.c
b/coreutils/date.c
+@@ -279,6 +279,9 @@ int date_main(int argc UNUSED_PARAM, cha
+ time(&ts.tv_sec);
+ #endif
+ }
++#if !ENABLE_FEATURE_DATE_NANO
++ ts.tv_nsec = 0;
++#endif
+ localtime_r(&ts.tv_sec, &tm_time);
+
+ /* If date string is given, update tm_time, and maybe set date */
+@@ -301,9 +304,10 @@ int date_main(int argc UNUSED_PARAM, cha
+ if (date_str[0] != '@')
+ tm_time.tm_isdst = -1;
+ ts.tv_sec = validate_tm_time(date_str, &tm_time);
++ ts.tv_nsec = 0;
+
+ /* if setting time, set it */
+- if ((opt & OPT_SET) && stime(&ts.tv_sec) < 0) {
++ if ((opt & OPT_SET) && clock_settime(CLOCK_REALTIME, &ts) < 0) {
+ bb_perror_msg("can't set date");
+ }
+ }
+--- a/libbb/missing_syscalls.c
b/libbb/missing_syscalls.c
+@@ -15,14 +15,6 @@ pid_t getsid(pid_t pid)
+ return syscall(__NR_getsid, pid);
+ }
+
+-int stime(const time_t *t)
+-{
+- struct timeval tv;
+- tv.tv_sec = *t;
+- tv.tv_usec = 0;
+- return settimeofday(&tv, NULL);
+-}
+-
+ int sethostname(const char *name, size_t len)
+ {
+ return syscall(__NR_sethostname, name, len);
+--- a/util-linux/rdate.c
b/util-linux/rdate.c
+@@ -95,9 +95,13 @@ int rdate_main(int argc UNUSED_PARAM, ch
+ if (!(flags & 2)) { /* no -p (-s may be present) */
+ if (time(NULL) == remote_time)
+ bb_error_msg("current time matches remote time");
+- else
+- if (stime(&remote_time) < 0)
++ else {
++ struct timespec ts;
++ ts.tv_sec = remote_time;
++ ts.tv_nsec = 0;
++ if (clock_settime(CLOCK_REALTIME, &ts) < 0)
+ bb_perror_msg_and_die("can't set time of day");
++ }
+ }
+
+ if (flags != 1) /* not lone -s */
--
2.20.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH 1/3] linux-atm: Fix build with glibc
Without this change linux-atm does not build any more with glibc and
kernel 5.4, because SIOCGSTAMP is missing. This patch adds a missing
include to fix this compile problem.
Signed-off-by: Hauke Mehrtens
---
.../patches/410-missing-SIOCGSTAMP.patch | 20 +++
1 file changed, 20 insertions(+)
create mode 100644
package/network/utils/linux-atm/patches/410-missing-SIOCGSTAMP.patch
diff --git
a/package/network/utils/linux-atm/patches/410-missing-SIOCGSTAMP.patch
b/package/network/utils/linux-atm/patches/410-missing-SIOCGSTAMP.patch
new file mode 100644
index ..3288466e3405
--- /dev/null
+++ b/package/network/utils/linux-atm/patches/410-missing-SIOCGSTAMP.patch
@@ -0,0 +1,20 @@
+--- a/src/maint/atmdump.c
b/src/maint/atmdump.c
+@@ -16,6 +16,7 @@
+ #include
+ #include /* for htonl and ntohl */
+ #include
++#include
+
+
+ static const char *pti[] = { "Data SDU 0","Data SDU 1","Data SDU 0, CE",
+--- a/src/maint/saaldump.c
b/src/maint/saaldump.c
+@@ -16,6 +16,7 @@
+ #include
+ #include
+ #include
++#include
+
+ #include "pdu.h"
+ #define DUMP_MODE
--
2.20.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH 3/3] toolchain: Update glibc to version 2.31
This updates glibc to the most recent version 2.31.
001-regex-read-overrun.patch was a backport from a more recent version
and is integrated in glibc 2.31.
050-Revert-Disallow-use-of-DES-encryption-functions-in-n.patch is needed
to add the DES crypto functions back again. They were removed in glibc
2.28, but we still use them in ppp.
musl lib also provides these DES crypto functions. Without them we would
have to link ppp against openssl or an other crypto library.
Signed-off-by: Hauke Mehrtens
---
toolchain/glibc/common.mk | 6 +-
.../patches/001-regex-read-overrun.patch | 26 -
...use-of-DES-encryption-functions-in-n.patch | 686 ++
.../patches/200-add-dl-search-paths.patch | 2 +-
4 files changed, 690 insertions(+), 30 deletions(-)
delete mode 100644 toolchain/glibc/patches/001-regex-read-overrun.patch
create mode 100644
toolchain/glibc/patches/050-Revert-Disallow-use-of-DES-encryption-functions-in-n.patch
diff --git a/toolchain/glibc/common.mk b/toolchain/glibc/common.mk
index 41ee989b14d3..ec00b95bf37a 100644
--- a/toolchain/glibc/common.mk
+++ b/toolchain/glibc/common.mk
@@ -7,12 +7,12 @@
include $(TOPDIR)/rules.mk
PKG_NAME:=glibc
-PKG_VERSION:=2.27
+PKG_VERSION:=2.31
PKG_SOURCE_PROTO:=git
PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION)
-PKG_SOURCE_VERSION:=bef0b1cb31bed76a355776154af9191ed1758222
-PKG_MIRROR_HASH:=24a137758acdc0d8c5254891204ba38d759838123bab09a64ec0bdb94289aafd
+PKG_SOURCE_VERSION:=3937f6806d9de4bbd25ff6e6dc4df8f47ad47573
+PKG_MIRROR_HASH:=8ae05d6fe3841009b0bfe373319fbbfd49e8ee0915054799fa7dd7331617457d
PKG_SOURCE_URL:=https://sourceware.org/git/glibc.git
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION)-$(PKG_SOURCE_VERSION).tar.xz
diff --git a/toolchain/glibc/patches/001-regex-read-overrun.patch
b/toolchain/glibc/patches/001-regex-read-overrun.patch
deleted file mode 100644
index c4e4307aa6d4..
--- a/toolchain/glibc/patches/001-regex-read-overrun.patch
+++ /dev/null
@@ -1,26 +0,0 @@
-commit 583dd860d5b833037175247230a328f0050dbfe9
-Author: Paul Eggert
-Date: Mon Jan 21 11:08:13 2019 -0800
-
-regex: fix read overrun [BZ #24114]
-
-Problem found by AddressSanitizer, reported by Hongxu Chen in:
-https://debbugs.gnu.org/34140
-* posix/regexec.c (proceed_next_node):
-Do not read past end of input buffer.
-
a/posix/regexec.c
-+++ b/posix/regexec.c
-@@ -1293,8 +1293,10 @@ proceed_next_node (const re_match_context_t *mctx, Idx
nregs, regmatch_t *regs,
- else if (naccepted)
- {
- char *buf = (char *) re_string_get_buffer (&mctx->input);
--if (memcmp (buf + regs[subexp_idx].rm_so, buf + *pidx,
--naccepted) != 0)
-+if (mctx->input.valid_len - *pidx < naccepted
-+|| (memcmp (buf + regs[subexp_idx].rm_so, buf + *pidx,
-+naccepted)
-+!= 0))
- return -1;
- }
- }
diff --git
a/toolchain/glibc/patches/050-Revert-Disallow-use-of-DES-encryption-functions-in-n.patch
b/toolchain/glibc/patches/050-Revert-Disallow-use-of-DES-encryption-functions-in-n.patch
new file mode 100644
index ..4e3e2eebb21f
--- /dev/null
+++
b/toolchain/glibc/patches/050-Revert-Disallow-use-of-DES-encryption-functions-in-n.patch
@@ -0,0 +1,686 @@
+From cfc93329e00cd23c226f34b3ffd5552a93c35bd7 Mon Sep 17 00:00:00 2001
+From: Hauke Mehrtens
+Date: Mon, 23 Mar 2020 22:33:46 +0100
+Subject: Revert "Disallow use of DES encryption functions in new programs."
+
+This reverts commit b10a0accee709a5efff2fadf0b0bbb79ff0ad759.
+
+ppp still uses the encrypt functions from the libc. musl libc also
+provides them.
+---
+ conform/data/stdlib.h-data | 3 +
+ conform/data/unistd.h-data | 6 ++
+ crypt/cert.c | 26 -
+ crypt/crypt-entry.c| 15 ++-
+ crypt/crypt.h | 16 +++
+ crypt/crypt_util.c | 9 --
+ manual/conf.texi | 2 -
+ manual/crypt.texi | 201 +
+ manual/string.texi | 82 +++
+ posix/unistd.h | 22 ++--
+ stdlib/stdlib.h| 6 ++
+ sunrpc/Makefile| 2 +-
+ sunrpc/des_crypt.c | 7 +-
+ sunrpc/des_soft.c | 2 +-
+ 14 files changed, 303 insertions(+), 96 deletions(-)
+
+--- a/conform/data/stdlib.h-data
b/conform/data/stdlib.h-data
+@@ -149,6 +149,9 @@ function {unsigned short int*} seed48 (u
+ #if !defined ISO && !defined ISO99 && !defined ISO11 && !defined POSIX &&
!defined XPG4 && !defined XPG42 && !defined UNIX98
+ function int setenv (const char*, const char*, int)
+ #endif
++#if !defined ISO && !defined ISO99 && !defined ISO11 && !defined POSIX &&
!defined POSIX2008
++function void setkey (const char*)
++#endif
+ #if !defined ISO && !defined ISO99 && !defined ISO11 && !defined XPG4 &&
!defined POSIX && !defined POSIX2
