Re: [Openvpn-devel] [PATCH 1/1] console_systemd: remove the timeout when using `systemd-ask-password`
On Wed, Jan 08, 2025 at 15:59:42 +0100, David Sommerseth wrote: > Given that the oldest Linux distro with systemd which supports the > --timeout argument in systemd-ask-password, this can get my ACK. Thanks. I thought to look at when it was introduced. It has been there (manpage documentation was added in commit f3bc7fdc7bf47193a9f8618a7d22a6ceec2df6f7) since 2011, released with systemd v25. I think we can assume anything using a modern openvpn is also using something newer than this as well. --Ben ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH applied] Re: console_systemd: remove the timeout when using 'systemd-ask-password'
On Tue, Jan 14, 2025 at 18:17:30 +0100, Gert Doering wrote: > I have taken this from the mailing list, as it has a thread hanging off > it with an ACK in it - which is easier than making the gerrit submission > a mail again, so it has a message-id to link to. Thanks! > Not much to test here - it's a trivial addition of an argv argument, and > if David says "this is good" then it is :-) (gerrit build tests also > agree that it does not break anything). > > Your patch has been applied to the master and release/2.6 branch > (it could be argued whether it's a bugfix or a feature). Looking forward to it :) . --Ben ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH 1/1] console_systemd: remove the timeout when using `systemd-ask-password`
Without this, the password request will expire after 90 seconds leaving no way to provide the password without OpenVPN asking for it again. Given that interactive use will wait for input without a timeout, it makes sense to have non-interactive usage also wait until the user is ready instead of forcing users to race against the timeout. --- src/openvpn/console_systemd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c index cc91cd10..b208a614 100644 --- a/src/openvpn/console_systemd.c +++ b/src/openvpn/console_systemd.c @@ -71,6 +71,7 @@ get_console_input_systemd(const char *prompt, const bool echo, char *input, cons } #endif argv_printf_cat(&argv, "--icon network-vpn"); +argv_printf_cat(&argv, "--timeout=0"); argv_printf_cat(&argv, "%s", prompt); if ((std_out = openvpn_popen(&argv, NULL)) < 0) -- 2.47.1 ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH 0/1] Remove system password timeout
PR: https://github.com/OpenVPN/openvpn/pull/649 Thanks, --Ben Ben Boeckel (1): console_systemd: remove the timeout when using `systemd-ask-password` src/openvpn/console_systemd.c | 1 + 1 file changed, 1 insertion(+) base-commit: cb878882388bfe9dc49b116190c5c6ae8918322d -- 2.47.1 ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
