Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues
Hi Ilya, my 2-meta-cents here: when sending multiple versions of the same patch to the mailing list, I'd recommend to change the subject to "[PATCHvX]" where X is the patch version. This way it is easier to identify which patch comes before and which after. Not sure what the maintainers think about this, but I stumbled on the wrong version a couple of times today before realizing that the newer was another one. Git can do this for you by specifying "-v X" (i.e. -v 2" to the git format-patch command. Cheers! -- Antonio Quartulli signature.asc Description: Digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues
On Sun, Jan 29, 2017 at 1:58 AM, Ilya Shipitsin wrote: > MBEDTLS_VERSION, OPENSSL_VERSION were defined twice - in both > .travis.yml and .travis/build-deps.sh files, the last one > defined OPENSSL_VERSION via nonexistent OPENSSL_VERION > variable, which lead us to use openssl-1.0.1 instead of > openssl-1.0.2, I removed variable definition from build-deps.sh > > "cache: [ apt: true ]" is not a travis supported option, it was > introduced by mistake, I removed it > > LD_LIBRARY_PATH was defined for the entire test run, it includes > custom openssl build, which was picked by "wget", so "wget" > could not verify SSL cert at https://www.openssl.org sometimes. > We do not want wget to pick our custom LD_LIBRARY_PATH, so I moved > that variable to "script" section > > LD_LIBRARY_PATH was defined for both linux and osx environments, > for the second DYLD_LIBRARY_PATH must be defined instead > > v2: Upgrade openssl, mbedtls to the most recent versions > > v3: DYLD_LIBRARY_PATH was defined via LD_LIBRARY_PATH by mistake This should take care of travis builds so ACK from me. For completeness I will copy what I wrote before: While this patch is good enough for travis builds, there is a more general issue here. I think its the job of libtool to set -rpath properly (and/or use a wrapper) so that uninstalled test programs pick up the library it was linked with. Selva -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues
Hi, On Sun, Jan 29, 2017 at 11:43:04PM +0800, Antonio Quartulli wrote: > Not sure what the maintainers think about this, but I stumbled on the wrong > version a couple of times today before realizing that the newer was another > one. Either "[PATCH v2]" or at least mention "v2: " in the commit message. > Git can do this for you by specifying "-v X" (i.e. -v 2" to the git > format-patch > command. I've learned something new today :-) (but I shouldn't be surprised: git is known to do everything to ease lazy committers' work :-) ) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc Description: PGP signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues
On 29/01/17 19:13, Gert Doering wrote: > >> Git can do this for you by specifying "-v X" (i.e. -v 2" to the git >> format-patch >> command. > > I've learned something new today :-) (but I shouldn't be surprised: git > is known to do everything to ease lazy committers' work :-) ) Weee! I realize I will need to read the man pages again ... I was neither aware of -v :) Thanks for the hint, Antonio! Recently updated to git-2.11 (from v1.8) ... and discover new things the whole time now ... -- kind regards, David Sommerseth OpenVPN Technologies, Inc signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH applied] Resolve several travis-ci issues
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the following branches commit 208c03ea145ed89083c43267733487c99a805069 (master) commit 31af45abfad7e3f0fbafc82b2daef3400a93359c (release/2.4) Author: Ilya Shipitsin Date: Sun Jan 29 11:58:11 2017 +0500 Resolve several travis-ci issues Acked-by: Selva Nair Message-Id: <1485673091-7600-1-git-send-email-chipits...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13983.html Signed-off-by: David Sommerseth - -- kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJYjkfQAAoJEIbPlEyWcf3yQ1oQALphWU4R8fzs/Nwy5YjUQVhL 8wlpQxvaBnYh1z3j5Iow1OSxgqNh9ee1oNio/v2gBCHLIu5WxbmwcbiDFy7sB3F4 vX19BpqgHSxf7P+RFvET5wQFdE+cV0FoTG/XoaqH8+fPmDqR6xROUh4HeQzdHBEi k/+VxnefMrLCPZckFcVOd862jgtVwFumE5B8EscfsliPgn8ylEoBPoS1e+akNP/u Bs1qp3jqDAAKOOuchA6hTlPudCMI+LLI3a7rGuYjgy/GhFATQTBQPJ1gsKdnjXKe JzOMhhVsjiN56dFVRQNw22NRyg/MoklwNzxwGu081B1Awy55ruVjvb8II9SIcNNJ 0B3Co0FQWTITpYDNuJnM/RT46zWTfn3zoDEfI5587792ta/Esu00etXn/jeud928 D/08bqW3reIs/AsOTHX5QtlucWOY1zTptk/vpzs9I6Rwi2VKOKqqiVXUBl4vrUtt wys/11OJsOcm2unovEHboNQ2eGRHFdEz9Yma9jpEtCQhi0gk5wyd2FNC/21one4a lfPzITmQv2bdoF+HHY0V7N+kFxsITELpV/Mrx0jrHAc9G2JOZyUoMGTsULd18r8F bhd73BuDWoqSBzFmMtZAtFL15Nan9rvWQrfif4Ieqyk0DlP7xMcY7Zs4D7eVbXzN jwhd9k6NtNNVUFId6VeL =fLaR -END PGP SIGNATURE- -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/
can we merge it ? @mattock ? 2017-01-21 13:47 GMT+05:00 Илья Шипицин : > > > 2017-01-21 0:24 GMT+05:00 David Sommerseth topphemmelig.net>: > >> On 13/01/17 10:05, Samuli Seppänen wrote: >> > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto: >> >> --- >> >> .github/PULL_REQUEST_TEMPLATE.md | 8 >> >> 1 file changed, 8 insertions(+) >> >> create mode 100644 .github/PULL_REQUEST_TEMPLATE.md >> >> >> >> diff --git a/.github/PULL_REQUEST_TEMPLATE.md >> b/.github/PULL_REQUEST_TEMPLATE.md >> >> new file mode 100644 >> >> index 000..d0cfd7f >> >> --- /dev/null >> >> +++ b/.github/PULL_REQUEST_TEMPLATE.md >> >> @@ -0,0 +1,8 @@ >> >> +# Thank you for your contribution >> >> + >> >> +You are welcome to open PR, but they are used for discussion only. All >> >> +patches must eventually go to the openvpn-devel mailing list for >> review. >> >> +For details, see these Wiki articles: >> >> + >> >> +* https://community.openvpn.net/openvpn/wiki/Contributing >> >> +* https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation >> >> >> > >> > Based on testing in the travis-openssl-test repository the template >> > works as intended, so ACK on that part. >> > >> > Any comments on the text itself? >> >> How does this work with branches? Do we need to say that new patches >> should go into the master branch primarily, unless it is fixing a bug or >> another issue which is only relevant for specific release branches? >> > > > we can put such information to > > https://community.openvpn.net/openvpn/wiki/Contributing > https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation > > > I would leave PR template skinny > > >> >> >> -- >> kind regards, >> >> David Sommerseth >> OpenVPN Technologies, Inc >> >> >> > -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
