[opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-02-19 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/153/
---

Review request for Viewer.


Summary
---

https://jira.secondlife.com/browse/VWR-24917
I have been finding the redundent display of functionally equivalent names in 
nearby chat history and IM history quite tiresome.
Simple proposal: If the resident's Display Name is at the default then do not 
display their user.name.
https://bitbucket.org/ArdyLay/viewer-development-vwr-24917

Change is to: LLAvatarName::getCompleteName

I find the following Callers:
LLAvatarActions::requestFriendshipDialog
LLAvatarActions::startIM
LLAvatarActions::startCall
LLIMModel::LLIMSession
LLIMModel::logToFile
LLPostponedNotification::onAvatarNameCache
LLUrlEntryAgent::onAvatarNameCache
LLUrlEntryAgent::getLabel
LLUrlEntryAgentCompleteName::getName

// Callback for name resolution of a god/estate message
llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName();
llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + 
message;

static void on_avatar_name_cache_toast ...
llimview.cpp(108): args["FROM"] = av_name.getCompleteName();

Some of these make me wonder if this change will cause some defects and should 
be implimented as a seperate function.


This addresses bug VWR-24917.
http://jira.secondlife.com/browse/VWR-24917


Diffs
-

  doc/contributions.txt c10d5e37db1e 
  indra/llcommon/llavatarname.cpp c10d5e37db1e 

Diff: http://codereview.secondlife.com/r/153/diff


Testing
---

I have been using this trivial change and have shared it with a friend, via 
bitbucket.  We have both built the viewer on Windows 7 and find the resulting 
reduction in redundent text in chat and IM history on screen to be very helpful.


Thanks,

ardy.lay

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-03 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/153/
---

(Updated March 3, 2011, 9:25 p.m.)


Review request for Viewer.


Summary
---

https://jira.secondlife.com/browse/VWR-24917
I have been finding the redundent display of functionally equivalent names in 
nearby chat history and IM history quite tiresome.
Simple proposal: If the resident's Display Name is at the default then do not 
display their user.name.
https://bitbucket.org/ArdyLay/viewer-development-vwr-24917

Change is to: LLAvatarName::getCompleteName

I find the following Callers:
LLAvatarActions::requestFriendshipDialog
LLAvatarActions::startIM
LLAvatarActions::startCall
LLIMModel::LLIMSession
LLIMModel::logToFile
LLPostponedNotification::onAvatarNameCache
LLUrlEntryAgent::onAvatarNameCache
LLUrlEntryAgent::getLabel
LLUrlEntryAgentCompleteName::getName

// Callback for name resolution of a god/estate message
llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName();
llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + 
message;

static void on_avatar_name_cache_toast ...
llimview.cpp(108): args["FROM"] = av_name.getCompleteName();

Some of these make me wonder if this change will cause some defects and should 
be implimented as a seperate function.


This addresses bug VWR-24917.
http://jira.secondlife.com/browse/VWR-24917


Diffs (updated)
-

  doc/contributions.txt c10d5e37db1e 
  indra/llcommon/llavatarname.cpp c10d5e37db1e 

Diff: http://codereview.secondlife.com/r/153/diff


Testing
---

I have been using this trivial change and have shared it with a friend, via 
bitbucket.  We have both built the viewer on Windows 7 and find the resulting 
reduction in redundent text in chat and IM history on screen to be very helpful.


Thanks,

ardy.lay

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread ardylay 


> On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote:
> > indra/llcommon/llavatarname.cpp, lines 93-108
> > <http://codereview.secondlife.com/r/153/diff/1/?file=981#file981line93>
> >
> > This could be shortened to
> > 
> > if (!mUsername.empty() && !mIsDisplayNameDefault)
> > {
> > name = mDisplayName + " (" + mUsername + ")";
> > }
> > else
> > {
> > // Display names are off, so legacy name is in 
> > mDisplayName,
> > // or Display Name is not changed from (user name based)
> > // default, so also showing the user name would be 
> > redundant.
> > name = mDisplayName;
> > }
> > 
> > but I guess the nested ifs make the intention more clear, so go for it.
> 
> Aleric Inglewood wrote:
> Or even more readable(?):
> 
>   if (mIsDisplayNameDefault || mUsername.empty())
>   {
>   // Showing the user name when Display Names are off
> // is redundant, since in that case it's the same string.
>   name = mDisplayName;
>   }
>   else
>   {
>   name = mDisplayName + " (" + mUsername + ")";
>   }
>

I think this is better to read.  Thanks Aleric.


- ardy.lay


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/153/#review392
---


On March 3, 2011, 9:25 p.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/153/
> ---
> 
> (Updated March 3, 2011, 9:25 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> https://jira.secondlife.com/browse/VWR-24917
> I have been finding the redundent display of functionally equivalent names in 
> nearby chat history and IM history quite tiresome.
> Simple proposal: If the resident's Display Name is at the default then do not 
> display their user.name.
> https://bitbucket.org/ArdyLay/viewer-development-vwr-24917
> 
> Change is to: LLAvatarName::getCompleteName
> 
> I find the following Callers:
> LLAvatarActions::requestFriendshipDialog
> LLAvatarActions::startIM
> LLAvatarActions::startCall
> LLIMModel::LLIMSession
> LLIMModel::logToFile
> LLPostponedNotification::onAvatarNameCache
> LLUrlEntryAgent::onAvatarNameCache
> LLUrlEntryAgent::getLabel
> LLUrlEntryAgentCompleteName::getName
> 
> // Callback for name resolution of a god/estate message
> llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName();
> llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + 
> message;
> 
> static void on_avatar_name_cache_toast ...
> llimview.cpp(108): args["FROM"] = av_name.getCompleteName();
> 
> Some of these make me wonder if this change will cause some defects and 
> should be implimented as a seperate function.
> 
> 
> This addresses bug VWR-24917.
> http://jira.secondlife.com/browse/VWR-24917
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt c10d5e37db1e 
>   indra/llcommon/llavatarname.cpp c10d5e37db1e 
> 
> Diff: http://codereview.secondlife.com/r/153/diff
> 
> 
> Testing
> ---
> 
> I have been using this trivial change and have shared it with a friend, via 
> bitbucket.  We have both built the viewer on Windows 7 and find the resulting 
> reduction in redundent text in chat and IM history on screen to be very 
> helpful.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread ardylay 


> On March 4, 2011, 3:05 a.m., Boroondas Gupte wrote:
> > indra/llcommon/llavatarname.cpp, lines 93-95
> > <http://codereview.secondlife.com/r/153/diff/2/?file=1051#file1051line93>
> >
> > Nitpicking now, but it should be "i.e.", not "ie". Also, the defaulted 
> > display name is NOT the same as the user name. (Mine would be "Boroondas 
> > Gupte" and "boroondas.gupte".) Actually, while one can derive the user name 
> > from the default display name, one cannot derive the default display name 
> > from the user name (because the casing is unknown). So maybe make the 
> > comment
> > 
> > // If the display name feature is off
> > // OR this particular display name is defaulted (i.e. based on 
> > user name),
> > // then display only the easier to read instance of the 
> > person's name.
> > 
> > (I know "based on" is a bit fuzzy, so if someone can think of a more 
> > specific formulation that is still technically correct and not too 
> > compicated, go for it.)

I prefer your version of the comment, Boroondas.  It does better describe what 
we are doing.  Thanks.


- ardy.lay


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/153/#review418
---


On March 3, 2011, 9:25 p.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/153/
> ---
> 
> (Updated March 3, 2011, 9:25 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> https://jira.secondlife.com/browse/VWR-24917
> I have been finding the redundent display of functionally equivalent names in 
> nearby chat history and IM history quite tiresome.
> Simple proposal: If the resident's Display Name is at the default then do not 
> display their user.name.
> https://bitbucket.org/ArdyLay/viewer-development-vwr-24917
> 
> Change is to: LLAvatarName::getCompleteName
> 
> I find the following Callers:
> LLAvatarActions::requestFriendshipDialog
> LLAvatarActions::startIM
> LLAvatarActions::startCall
> LLIMModel::LLIMSession
> LLIMModel::logToFile
> LLPostponedNotification::onAvatarNameCache
> LLUrlEntryAgent::onAvatarNameCache
> LLUrlEntryAgent::getLabel
> LLUrlEntryAgentCompleteName::getName
> 
> // Callback for name resolution of a god/estate message
> llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName();
> llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + 
> message;
> 
> static void on_avatar_name_cache_toast ...
> llimview.cpp(108): args["FROM"] = av_name.getCompleteName();
> 
> Some of these make me wonder if this change will cause some defects and 
> should be implimented as a seperate function.
> 
> 
> This addresses bug VWR-24917.
> http://jira.secondlife.com/browse/VWR-24917
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt c10d5e37db1e 
>   indra/llcommon/llavatarname.cpp c10d5e37db1e 
> 
> Diff: http://codereview.secondlife.com/r/153/diff
> 
> 
> Testing
> ---
> 
> I have been using this trivial change and have shared it with a friend, via 
> bitbucket.  We have both built the viewer on Windows 7 and find the resulting 
> reduction in redundent text in chat and IM history on screen to be very 
> helpful.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/153/
---

(Updated March 4, 2011, 5:11 a.m.)


Review request for Viewer.


Changes
---

I edited my proposed change after considering the feedback provided by 
reviewers.  Thanks.
Diff updated.  Repository synced with viewer-development and diff applied.


Summary
---

https://jira.secondlife.com/browse/VWR-24917
I have been finding the redundent display of functionally equivalent names in 
nearby chat history and IM history quite tiresome.
Simple proposal: If the resident's Display Name is at the default then do not 
display their user.name.
https://bitbucket.org/ArdyLay/viewer-development-vwr-24917

Change is to: LLAvatarName::getCompleteName

I find the following Callers:
LLAvatarActions::requestFriendshipDialog
LLAvatarActions::startIM
LLAvatarActions::startCall
LLIMModel::LLIMSession
LLIMModel::logToFile
LLPostponedNotification::onAvatarNameCache
LLUrlEntryAgent::onAvatarNameCache
LLUrlEntryAgent::getLabel
LLUrlEntryAgentCompleteName::getName

// Callback for name resolution of a god/estate message
llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName();
llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + 
message;

static void on_avatar_name_cache_toast ...
llimview.cpp(108): args["FROM"] = av_name.getCompleteName();

Some of these make me wonder if this change will cause some defects and should 
be implimented as a seperate function.


This addresses bug VWR-24917.
http://jira.secondlife.com/browse/VWR-24917


Diffs (updated)
-

  doc/contributions.txt ef2df52563bb 
  indra/llcommon/llavatarname.cpp ef2df52563bb 

Diff: http://codereview.secondlife.com/r/153/diff


Testing
---

I have been using this trivial change and have shared it with a friend, via 
bitbucket.  We have both built the viewer on Windows 7 and find the resulting 
reduction in redundent text in chat and IM history on screen to be very helpful.


Thanks,

ardy.lay

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: fix for ECC-49 / storm-1147: Other avatar's loose clothing\ flared cuffs look like they are tight\got no flare in v.2.4.0 and higher

2011-04-08 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/260/#review581
---

Ship it!


I started using this daily about a week ago.  It does the trick and I have 
noticed NO adverse affects.

- ardy.lay


On April 8, 2011, 2:22 p.m., Xiaohong Bao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/260/
> ---
> 
> (Updated April 8, 2011, 2:22 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This patch is a resident posted for ECC-49. It is correct and works fine. So 
> please merge it into viewer-development and viewer-release.
> 
> 
> This addresses bugs /, ECC-49 and storm-1147.
> http://jira.secondlife.com/browse//
> http://jira.secondlife.com/browse/ECC-49
> http://jira.secondlife.com/browse/storm-1147
> 
> 
> Diffs
> -
> 
>   indra/newview/llviewertexture.cpp c1559a7da393 
> 
> Diff: http://codereview.secondlife.com/r/260/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Xiaohong
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.

2011-04-21 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/259/#review644
---

Ship it!


Seems to have worked for me on Windows 7 64-bit.  Thanks!

- ardy.lay


On April 21, 2011, 2:18 p.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/259/
> ---
> 
> (Updated April 21, 2011, 2:18 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The VC redistributable package installs its files (msvcr100.dll, 
> msvcp100.dll, msvcr100d.dll, msvcp100d.dll, etc.) to the WINDOWS\System32 
> directory (and WINDOWS\SysWOW64, if it is a 64-bit version). Adding these 
> locations to the list of places to look when attempting to copy the files to 
> build-vc100\sharedlibs.
> 
> On 64 bit windows the 32-bit file versions go to SySWOW64, so this is listed 
> first to prevent the 64-bit versions being used.
> 
> If any one knows how it could use %systemroot% instead of the environment 
> variable WINDIR I'd appreciate the info ;-) 
> 
> 
> This addresses bug OPEN-61.
> http://jira.secondlife.com/browse/OPEN-61
> 
> 
> Diffs
> -
> 
>   indra/cmake/Copy3rdPartyLibs.cmake 33ca961b0870 
> 
> Diff: http://codereview.secondlife.com/r/259/diff
> 
> 
> Testing
> ---
> 
> Ran 'autobuild build' without manually copying the redistributable files or 
> adding the configure switch to point at their location.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

2011-05-16 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/304/#review700
---

Ship it!


I think I can approve of that.  It's essentially what we decided on at a 
meeting.  I think my point was to put the #define in with the rest of them 
instead of out in left field and this looks good to me now.

- ardy.lay


On May 16, 2011, 4:16 a.m., Wolfpup Lowenhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/304/
> ---
> 
> (Updated May 16, 2011, 4:16 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is for switching from using winres.h to windows.h so that the viewer can 
> be build no matter whether your using and Express or Professional version of 
> Visual Studio.
> 
> 
> This addresses bug STORM-859.
> http://jira.secondlife.com/browse/STORM-859
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e9d656e4620e 
>   indra/newview/res/resource.h e9d656e4620e 
>   indra/newview/res/viewerRes.rc e9d656e4620e 
> 
> Diff: http://codereview.secondlife.com/r/304/diff
> 
> 
> Testing
> ---
> 
> I have built viewer-development locally with this modification using Visual 
> Studio 2010 Ultimate and have seen no ill affects as yet to the built viewer. 
> It logs in to SL just fine.
> I have done the following with the built viewer:
> 1. edited or created objects with no ill affects.
> 2. carried on conversations in Near By, Group and P2P with no ill affects.
> 3. Teleported to various sims and levels in those sims with no ill affect.
> 4. carried on Voice conversations with no ill affect.
> 5. moved things around in my inventory as well as rezed and taken objects 
> from and to my inventory with no ill affects.
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-27 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/
---

Review request for Viewer.


Summary
---

As a resident of Second Life I find the displaying an emoter's name twice in 
nearby chat history rather unnecessary.  Please lay eyes on this proposed code 
change and let me know what you think.

I took care to remove the unlinked sender name instead of the linked one.


This addresses bug VWR-26393.
http://jira.secondlife.com/browse/VWR-26393


Diffs
-

  indra/newview/llchathistory.cpp 2f9a87538ca1 

Diff: http://codereview.secondlife.com/r/419/diff


Testing
---

Tell a crowd what you are testing and many will start talking to you prefixed 
with /me, if they are good sports.  I have been using this change for 3 days 
now and have not noticed any ill effects.  Please note: This changest is not 
intended to affect nearby chat toasts, nearby chat log files, IM history, IM 
toasts or IM log files.


Thanks,

ardy.lay

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-28 Thread ardylay 


> On July 28, 2011, 2:58 a.m., Boroondas Gupte wrote:
> > indra/newview/llchathistory.cpp, line 929
> > 
> >
> > As you cut away a substring of the length of chat.mFrontName, I assume 
> > chat.mText contains the content of chat.mFrontName at the beginning, not 
> > "/me " or "/me'"? chat.mText doesn't seem to have been modified since (old) 
> > line 747, so I guess the comparison you removed there was nonsense, anyway?
> > 
> > Btw., where does mFromName get added to the beginning of mText? 
> > Wouldn't it be better to not add it in the first place rather than cutting 
> > it away again here?

llviewermessage.cpp line2 3300 - 3368 is where you can find chat.mChatStyle = 
CHAT_STYLE_IRC;  The test I removed was occuring AFTER the /me "emote" was 
stripped from the message from the simulator so was ineffective.  See changeset 
at https://bitbucket.org/lindenlab/viewer-development/changeset/741e44af9f02 
line 493.  It prepends sender name, if it exists, then removes the leading 3 
characters "/me" from the message.  I did not see that display context was 
available at the time the name was prepended so was removed the name after 
context was available.  Perhaps there is a better way?


- ardy.lay


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review934
---


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> ---
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> As a resident of Second Life I find the displaying an emoter's name twice in 
> nearby chat history rather unnecessary.  Please lay eyes on this proposed 
> code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
> http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> ---
> 
> Tell a crowd what you are testing and many will start talking to you prefixed 
> with /me, if they are good sports.  I have been using this change for 3 days 
> now and have not noticed any ill effects.  Please note: This changest is not 
> intended to affect nearby chat toasts, nearby chat log files, IM history, IM 
> toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

2011-07-28 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/405/#review939
---

Ship it!


I am using it without noticing any functional issues.  Does this return 
floating text and nametags to a previous behavior I haven't seen for a long 
time?  I think it does.  It feels comfortable to me and really decluters the 
display.

- ardy.lay


On July 21, 2011, 2:55 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/405/
> ---
> 
> (Updated July 21, 2011, 2:55 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Set the z (depth) coordinate of hovertext such that the hovertext gets 
> occluded by stuff in front of it.
> 
> 
> This addresses bugs SH-489, VWR-24017 and VWR-25588.
> http://jira.secondlife.com/browse/SH-489
> http://jira.secondlife.com/browse/VWR-24017
> http://jira.secondlife.com/browse/VWR-25588
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 46c7b36793c9 
>   indra/llrender/llfontgl.cpp 46c7b36793c9 
> 
> Diff: http://codereview.secondlife.com/r/405/diff
> 
> 
> Testing
> ---
> 
> Merged this change with e67da2c6e312 (as I still cannot build 
> viewer-development tip) and rebuilt. Verified that my nametag and an objects 
> llSetText hovertext were correctly occluded by another object in front of 
> them.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-08-13 Thread ardylay 


> On Aug. 11, 2011, 11:47 a.m., Vadim ProductEngine wrote:
> > indra/newview/llchathistory.cpp, line 929
> > 
> >
> > Agree with Boroondas that replacing /me with the sender name and then 
> > stripping it looks weird.

I don't know how I missed that problem in IMs.  All I was trying to do was fix 
it in nearby chat history without breaking anything else.  I find that 
reverting one changeset gets me pretty close so I think I shall probably close 
and discard my own attempt here and ask for eyes on:
 (741e44af9f02) ER-949:  Chat using '/me' style text displayed incorrectly.  
Reviewed by Kelly
I backed that out and now I only see the local chat toasts displaying /me 
emotes incorrectly. What do you see?


- ardy.lay


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review962
---


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> ---
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> As a resident of Second Life I find the displaying an emoter's name twice in 
> nearby chat history rather unnecessary.  Please lay eyes on this proposed 
> code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
> http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> ---
> 
> Tell a crowd what you are testing and many will start talking to you prefixed 
> with /me, if they are good sports.  I have been using this change for 3 days 
> now and have not noticed any ill effects.  Please note: This changest is not 
> intended to affect nearby chat toasts, nearby chat log files, IM history, IM 
> toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Mouse pointer flickers when hovering over any active/clickable UI item

2011-11-12 Thread ardylay 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/513/#review1074
---


Mouse cursor behavior is much better with this patch applied.

- ardy.lay


On Nov. 12, 2011, 4:07 a.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/513/
> ---
> 
> (Updated Nov. 12, 2011, 4:07 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Mouse pointer flickers when hovering over any active/clickable UI item, for 
> example the links on the login screen or in search.
> 
> 
> This addresses bug VWR-27477.
> http://jira.secondlife.com/browse/VWR-27477
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt ae5236b6f788 
>   indra/llui/llview.cpp ae5236b6f788 
> 
> Diff: http://codereview.secondlife.com/r/513/diff
> 
> 
> Testing
> ---
> 
> built on linux, tested, works as expected
> 
> 
> Thanks,
> 
> Lance
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges