Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup
On Mon, 22 Aug 2011 16:43:22 -, Jonathan Yap wrote:
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/449/
> ---
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> Add a block button to popups from llDialog calls. Clicking on the Block
> button adds the object to the block list. The type of block is Object.
There is an issue with the way this is implemented: existing scripts
using a "Mute" button in their own menu get this button interpreted
as a viewer-side block action request from the user.
Note that this is also an issue with llDialog()s using "Ignore" as a
button, but the latter has been documented like forever on the LSL
portal, thus not being a real issue, while this new blocking feature
breaks *existing* contents.
The reason why client side buttons and script side llDialog() buttons
get mixed up is that the buttons in the script menus got the same
internal "name" as the "text" they are set for, and since UI dialogs
are all referred by their "name" field in the viewer UI, the first
matching "name" in a list of buttons is used to trigger the
corresponding action (here, block by object UUID for any "Mute"
button in the dialog).
The fix is simple (and also fixes the "Ignore" button issue): you
just have to use a "name" field for the client side buttons ("Ignore"
and "Block") that scripts are unlikely to ever use.
For the Cool VL Viewer (v1.26.0.19 and v1.26.1.6, to be released
this week), I use "client_side_mute" and "client_side_ignore" as
the "Block" and "Ignore" button names in the notification menu
definition (in notifications.xml). For v3, this would read as:
[NAME]'s '[TITLE] '
[MESSAGE]
group
[GROUPNAME]'s '[TITLE] '
[MESSAGE]
"client_side_mute" and client_side_ignore" are unlikely to be ever used
in llDialog() calls, but you could use even more obscure names if you want.
There is no other code to change for making this work properly, and you can
test it with this simple script:
default {
state_entry() {
llListen(-1, "", NULL_KEY, "");
}
touch_start(integer total_number) {
llDialog(llDetectedKey(0), "Test", [ "Ignore", "Mute", "OK" ], -1);
}
listen(integer chan, string name, key id, string message) {
llSetText(message, <1.0, 1.0, 1.0>, 1.0);
}
}
Henri.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] building the viewer3 on linux (update deps on wiki)
Hi guys! I'm compiling viewer 3 on ubuntu linux 64bit and I've installed every package described in the wiki http://wiki.secondlife.com/wiki/Compiling_the_viewer_%28Linux%29 but when i try to compile it with autobuild, i got "-- Could NOT find Threads (missing: Threads_FOUND)". I have installed every package (in ubuntu) named *thread* so... please, do you know what package is missing? BTW, I've built successfully snowglobe2, taken from http://omvviewer.byteme.org.uk/ Of course it's too old to use... however, it could be useful to you in order to understand what dependency is missing to me, because i can compile snowglobe2 but not viewer3. Many thanks in advance, Paolo autobuild build -c ReleaseOS --debug --verbose executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -DINSTALL_PROPRIETARY=FALSE -G 'Unix Makefiles' ../indra -- Building with OpenAL audio support -- Found Google BreakPad: /usr/local/lib/libbreakpad_client.a CMake Error at cmake/Copy3rdPartyLibs.cmake:335 (copy_if_different): COPY_IF_DIFFERENT Macro invoked with incorrect arguments for macro named: COPY_IF_DIFFERENT Call Stack (most recent call first): llcommon/CMakeLists.txt:13 (include) -- Could NOT find Threads (missing: Threads_FOUND) -- Could NOT find Threads (missing: Threads_FOUND) -- Could NOT find Threads (missing: Threads_FOUND) -- Could NOT find Threads (missing: Threads_FOUND) -- Could NOT find Threads (missing: Threads_FOUND) -- Could NOT find Threads (missing: Threads_FOUND) -- Could NOT find Threads (missing: Threads_FOUND) -- Could NOT find Threads (missing: Threads_FOUND) -- Building with OpenAL audio support -- Could NOT find Threads (missing: Threads_FOUND) -- Found NDOF: Library in '/usr/lib/libndofdev.so' and header in '/usr/include' -- Version of viewer is 3.0.0.0 -- Could NOT find Threads (missing: Threads_FOUND) -- Skip llimage_libtest -- Configuring incomplete, errors occurred! ERROR: configuring default configuration returned 1 For more information: try re-running your command with --verbose or --debug ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services (take 2)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/466/ --- Review request for Viewer and Seth ProductEngine. Summary --- Replaced deprecated Google Translate v1 API with Google Translate v2 and Bing Translate APIs. Changes after https://codereview.secondlife.com/r/464/: * New translation preferences floater layout that supports API key verification. * Unit tests. This addresses bug STORM-1577. http://jira.secondlife.com/browse/STORM-1577 Diffs - indra/newview/CMakeLists.txt 8da01486a36a indra/newview/app_settings/settings.xml 8da01486a36a indra/newview/llfloaterpreference.h 8da01486a36a indra/newview/llfloaterpreference.cpp 8da01486a36a indra/newview/llfloatertranslationsettings.h PRE-CREATION indra/newview/llfloatertranslationsettings.cpp PRE-CREATION indra/newview/lltranslate.h 8da01486a36a indra/newview/lltranslate.cpp 8da01486a36a indra/newview/llviewerfloaterreg.cpp 8da01486a36a indra/newview/llviewermessage.cpp 8da01486a36a indra/newview/skins/default/xui/en/floater_translation_settings.xml PRE-CREATION indra/newview/skins/default/xui/en/panel_preferences_chat.xml 8da01486a36a indra/newview/skins/default/xui/en/strings.xml 8da01486a36a indra/newview/tests/lltranslate_test.cpp PRE-CREATION Diff: http://codereview.secondlife.com/r/466/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1585 Duplicated XUI ID: floater_preferences_proxy.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/467/ --- Review request for Viewer and Log Linden. Summary --- Fixed duplicated/missing XUI IDs in floater_preferences_proxy.xml. This addresses bug STORM-1585. http://jira.secondlife.com/browse/STORM-1585 Diffs - indra/newview/skins/default/xui/en/floater_preferences_proxy.xml 25b876619ca6 Diff: http://codereview.secondlife.com/r/467/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
