Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/ --- (Updated Aug. 27, 2011, 3:01 a.m.) Review request for Viewer and Seth ProductEngine. Changes --- Fixed a silly pointer usage mistake. Summary --- Reason: Showing the confirmation dialog resets object selection, thus there is nothing to derez. Fix: Save selection until user answers in the confirmation dialog. I didn't investigate why the bug occurred only for distant object (must be some internal LLSelectMgr magic). This addresses bug STORM-638. http://jira.secondlife.com/browse/STORM-638 Diffs (updated) - indra/newview/llviewermenu.cpp 00b00b942134 Diff: http://codereview.secondlife.com/r/451/diff Testing --- See acceptance criteria in the JIRA ticket. Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/#review1000 --- Ship it! - Vadim On Aug. 26, 2011, 9:37 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/449/ > --- > > (Updated Aug. 26, 2011, 9:37 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Add a block button to popups from llDialog calls. Clicking on the Block > button adds the object to the block list. The type of block is Object. > Changing the object's name does not defeat this block as the block entry is > stored as a UUID. > > Note: The object's name in the block list does not change if the object is > renamed, though the block does work. This may need to be addressed in a > separate SVC jira once this change is incorporated into viewer-development. > > > This addresses bug STORM-1567. > http://jira.secondlife.com/browse/STORM-1567 > > > Diffs > - > > doc/contributions.txt 4ebbd04efd93 > indra/newview/lltoastnotifypanel.cpp 4ebbd04efd93 > indra/newview/llviewermessage.cpp 4ebbd04efd93 > indra/newview/skins/default/xui/en/notifications.xml 4ebbd04efd93 > > Diff: http://codereview.secondlife.com/r/449/diff > > > Testing > --- > > Tested per Test Plan jira entry. > > > Thanks, > > Jonathan > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review1001 --- Ship it! work on debian/sid 32bit, imho "ship it" - Altair On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > --- > > (Updated Feb. 26, 2011, 6:56 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Oz: please merge into your repository. > > > This addresses bug OPEN-38. > http://jira.secondlife.com/browse/OPEN-38 > > > Diffs > - > > indra/cmake/FindGLH.cmake PRE-CREATION > indra/cmake/GLH.cmake PRE-CREATION > indra/cmake/LLRender.cmake 5f0ab9443ece > indra/cmake/LLSharedLibs.cmake 5f0ab9443ece > indra/cmake/Linking.cmake 5f0ab9443ece > indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece > > Diff: http://codereview.secondlife.com/r/167/diff > > > Testing > --- > > configures, compiles, runs. > > > Thanks, > > Aleric > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] JIRA Search
Just charge 10L$ for creating a new issue, but not for comments. That would make people look before making a duplicate. It's amazing what SL people will do for a small financial incentive :-) > 1. Re: [JIRA] Proposal - Default Search settings on >jira.secondlife.com >> I think that this would lead to a better use of JIRA for >> SL users willing to give feedback. More specifically, >> the number of duplicate issues may be reduced because >> the search for existing issues would be more efficient. >> > > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] JIRA Search
LOL!! Better make that 5L$, though, huh? Since L$ seem to wobble around 250L$/US$, 5L$ = 2 US cents! Like, you can get your two cents in for two cents!! Hahahahaha P.S.s.s.t.: Since L$ only come in 10-paks, give 'em "two4one" purchase Jiras! With a little marketing, Jira could pay for itself!! ROTFL!!! Sorry about the unprofessional interruption. You can return to your regularly scheduled geeking now. - Just charge 10L$ for creating a new issue, but not for comments. That would make people look before making a duplicate. It's amazing what SL people will do for a small financial incentive > 1. Re: [JIRA] Proposal - Default Search settings on >jira.secondlife.com >> I think that this would lead to a better use of JIRA for >> SL users willing to give feedback. More specifically, >> the number of duplicate issues may be reduced because >> the search for existing issues would be more efficient. >> > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/#review1002 --- Ship it! thanks - Richard On Aug. 27, 2011, 3:01 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/451/ > --- > > (Updated Aug. 27, 2011, 3:01 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > --- > > Reason: Showing the confirmation dialog resets object selection, > thus there is nothing to derez. > > Fix: Save selection until user answers in the confirmation dialog. > > I didn't investigate why the bug occurred only for distant object > (must be some internal LLSelectMgr magic). > > > This addresses bug STORM-638. > http://jira.secondlife.com/browse/STORM-638 > > > Diffs > - > > indra/newview/llviewermenu.cpp 00b00b942134 > > Diff: http://codereview.secondlife.com/r/451/diff > > > Testing > --- > > See acceptance criteria in the JIRA ticket. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
