Re: [opensource-dev] Review Request: Windows debug build fails at run time because of an absent openjpeg.dll.

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/445/#review984
---


> Note: In code comments are for code review only and will be removed.
As the comments indicate that this is a temporary hack, they should go in with 
the code, if the code is to go in. That is crucial information to anyone 
editing that code.

Though, is there a reason why we can't just fix this the right way right away 
instead of working around the problem first?


indra/cmake/Copy3rdPartyLibs.cmake


Don't add trailing whitespace.



indra/cmake/Copy3rdPartyLibs.cmake


Removing the '[' here leaves the ']' unbalanced, so I doubt that's right.


- Boroondas


On Aug. 20, 2011, 4:48 p.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/445/
> ---
> 
> (Updated Aug. 20, 2011, 4:48 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Note: In code comments are for code review only and will be removed.
> Debug builds have openjpegd.dll and it is a dependency for some of the unit 
> tests. However, the viewer (secondlife-bin.exe) has openjpeg.dll dependency. 
> It is the same debug library but, without the 'd' in its name. So, there are 
> two or more dependencies of the same library with different names. This can 
> be tested by building a debug configuration and invoking the viewer and then, 
> the error appears about the missing openjpeg.dll. Then, change the name of 
> openjpegd.dll to openjpeg.dll and invoke the viewer again. This time it 
> should run correctly and present the log in page. Modifications are need to 
> add a copy instruction so that both named versions of the debug library are 
> present in the openjpeg archive. Additional modifications to the viewer are 
> needed to place openjpeg.dll properly; while leaving openjpegd.dll in place 
> for unit tests.
> 
> 
> This addresses bug https://jira.secondlife.com/browse/OPEN-112.
> 
> http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/OPEN-112
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a95b822cf2c2 
>   indra/cmake/Copy3rdPartyLibs.cmake a95b822cf2c2 
>   indra/newview/CMakeLists.txt a95b822cf2c2 
>   indra/newview/viewer_manifest.py a95b822cf2c2 
> 
> Diff: http://codereview.secondlife.com/r/445/diff
> 
> 
> Testing
> ---
> 
> Built Debug configuration with revised local library. Copy of revised library 
> is here: 
> http://bitbucket.org/NickyP/viewer-development-open-112/downloads/openjpeg-1.4-windows-20110819.tar.bz2
>  
> MD5 hash is 271a8e9253efaef9884181cd58984dd9.
> Logged in to aditi mesh city and walked around. No problems noted.
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Windows debug build fails at run time because of an absent openjpeg.dll.

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/445/
---

(Updated Aug. 21, 2011, 5:34 a.m.)


Review request for Viewer.


Changes
---

>From Boroondas review.
Removed trailing white space. Corrected an editing error for a removed bracket 
caused by trying to align text.

In code comments can be left in if appropriate. 


Summary
---

Note: In code comments are for code review only and will be removed.
Debug builds have openjpegd.dll and it is a dependency for some of the unit 
tests. However, the viewer (secondlife-bin.exe) has openjpeg.dll dependency. It 
is the same debug library but, without the 'd' in its name. So, there are two 
or more dependencies of the same library with different names. This can be 
tested by building a debug configuration and invoking the viewer and then, the 
error appears about the missing openjpeg.dll. Then, change the name of 
openjpegd.dll to openjpeg.dll and invoke the viewer again. This time it should 
run correctly and present the log in page. Modifications are need to add a copy 
instruction so that both named versions of the debug library are present in the 
openjpeg archive. Additional modifications to the viewer are needed to place 
openjpeg.dll properly; while leaving openjpegd.dll in place for unit tests.


This addresses bug https://jira.secondlife.com/browse/OPEN-112.

http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/OPEN-112


Diffs (updated)
-

  doc/contributions.txt a95b822cf2c2 
  indra/cmake/Copy3rdPartyLibs.cmake a95b822cf2c2 
  indra/newview/CMakeLists.txt a95b822cf2c2 
  indra/newview/viewer_manifest.py a95b822cf2c2 

Diff: http://codereview.secondlife.com/r/445/diff


Testing
---

Built Debug configuration with revised local library. Copy of revised library 
is here: 
http://bitbucket.org/NickyP/viewer-development-open-112/downloads/openjpeg-1.4-windows-20110819.tar.bz2
 
MD5 hash is 271a8e9253efaef9884181cd58984dd9.
Logged in to aditi mesh city and walked around. No problems noted.


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges