[opensource-dev] Review Request: STORM-1268 Viewer update resets some viewer settings
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/443/ --- Review request for Viewer and Richard Nelson. Summary --- Bug: Settings for ignorable dialogs were reset during deferred auto-upgrade. Reason: In case of deferred upgrade (i.e. when you select "Later...") the defaults for notifications settings are not loaded, so when the viewer exits after launching the updater, it incorrectly re-saves notifications settings. Fix: Initialize settings earlier, so that viewer picks them up in update mode. This addresses bug STORM-1268. http://jira.secondlife.com/browse/STORM-1268 Diffs - indra/newview/llappviewer.cpp 478aabd2813b Diff: http://codereview.secondlife.com/r/443/diff Testing --- See acceptance criteria in the JIRA ticket. Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] [JIRA] some questions about VWR-26648 (Early Beta Test Issues - v3.0.0)
https://jira.secondlife.com/browse/VWR-26648 was created to collect issues discovered while using v3.0.0 (238157). 1. should we keep using VWR-26648 now that a newer Beta is out ? 2. I reorganized linked items and now they're all "children of" VWR-26648. It seems easier to read this way. Is this OK? 3. Is it OK to add issues that pre-date 3.0 beta viewers release? example: https://jira.secondlife.com/browse/VWR-26383 Opensource Obscure -- http://twitter.com/oobscure - http://opensourceobscure.com/lol discuss Second Life Viewer 2: http://j.mp/slv2group ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] [JIRA] some questions about VWR-26648 (Early Beta Test Issues - v3.0.0)
On 2011-08-19 7:48, opensourceobscure wrote: > https://jira.secondlife.com/browse/VWR-26648 was created to > collect issues discovered while using v3.0.0 (238157). > > 1. should we keep using VWR-26648 now that a newer Beta is out ? No need - issues can just be filed in VWR as usual. > 2. I reorganized linked items and now they're all "children of" VWR-26648. > It seems easier to read this way. Is this OK? Yes, thank you. > 3. Is it OK to add issues that pre-date 3.0 beta viewers release? > example:https://jira.secondlife.com/browse/VWR-26383 No. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Mercurial hook checking for well-formed XML
On 2011-08-16 11:06, Oz Linden (Scott Lawrence) wrote: I have updated his script to work with current versions of Mercurial (there was one minor api change), and added a feature of two of my own. I've gotten approval to push this out to the public bitbucket, and have documented it at: https://wiki.secondlife.com/wiki/Mercurial_Tools I'll be using that version now, and encourage you to do the same. Not everything in the viewer-development tree passes these checks yet, but that won't bite you unless you modify something that already fails (the hook only checks modified files that are present in the new tip). I'll either clean up the problems that have accumulated in viewer-development or modify the tests to allow them over the next week or two. Effective this morning, all of viewer-development passes these tests and*all future merge requests are subject to them*. I strongly urge anyone working on code that might be going to viewer-development to install the hooks immediately (they do not subject repositories other than those from LL to the tests, so they won't interfere with anything else you're doing). ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Mercurial hook checking for well-formed XML
On 2011-08-19 9:37, Oz Linden (Scott Lawrence) wrote: Effective this morning, all of viewer-development passes these tests and*all future merge requests are subject to them*. I strongly urge anyone working on code that might be going to viewer-development to install the hooks immediately (they do not subject repositories other than those from LL to the tests, so they won't interfere with anything else you're doing). Do update to the tip of the hg-tools repository ... a number of changes were needed to get things working for all of the code. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/444/ --- Review request for Viewer and Richard Nelson. Summary --- In busy mode offered inventory items are now moved to trash. There were two bugs: 1. When auto-discarding inventory offers we looked up missing Busy button (i.e. a button having index=3) in the inventory offer notification dialog template. Failure to find the button resulted in ignoring inventory offers. Fixed that by "auto-clicking" the existing Discard button. 2. It turned out impossible to properly remove an inventory item from within LLDiscardAgentOffer::done(), because that would lead to nested LLInventoryModel::notifyObservers() calls. Fixed that by deferring removal until the next LLAppViewer::idle() iteration. This addresses bug STORM-1543. http://jira.secondlife.com/browse/STORM-1543 Diffs - indra/newview/llappviewer.h 478aabd2813b indra/newview/llappviewer.cpp 478aabd2813b indra/newview/llviewermessage.cpp 478aabd2813b Diff: http://codereview.secondlife.com/r/444/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1268 Viewer update resets some viewer settings
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/443/#review983 --- Ship it! good catch! - Richard On Aug. 19, 2011, 3:55 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/443/ > --- > > (Updated Aug. 19, 2011, 3:55 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Bug: > Settings for ignorable dialogs were reset during deferred auto-upgrade. > > Reason: > In case of deferred upgrade (i.e. when you select "Later...") the defaults > for notifications settings are not loaded, > so when the viewer exits after launching the updater, it incorrectly re-saves > notifications settings. > > Fix: > Initialize settings earlier, so that viewer picks them up in update mode. > > > This addresses bug STORM-1268. > http://jira.secondlife.com/browse/STORM-1268 > > > Diffs > - > > indra/newview/llappviewer.cpp 478aabd2813b > > Diff: http://codereview.secondlife.com/r/443/diff > > > Testing > --- > > See acceptance criteria in the JIRA ticket. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
