Re: [opensource-dev] Review Request: STORM-793 Offered URL-like named object is displayed as a HTTP URL in the llGiveInventory

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/442/
---

(Updated Aug. 17, 2011, 3:21 a.m.)


Review request for Viewer.


Changes
---

Applied the fix to translations and to the minimal (basic viewer) skin.


Summary
---

Disallowed parsing HTTP URLs in llGiveInventory notifications (one more case).

The fix may look weird because we seem to wrap a SLURL with 
... tags.
But actually there is no SLURL, there's just an object name.
Investigating that goes beyond the bug scope.


This addresses bug STORM-793.
http://jira.secondlife.com/browse/STORM-793


Diffs (updated)
-

  indra/newview/skins/default/xui/da/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/de/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/en/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/es/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/fr/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/it/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/ja/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/nl/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/pl/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/pt/notifications.xml UNKNOWN 
  indra/newview/skins/default/xui/zh/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/da/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/de/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/en/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/es/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/fr/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/it/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/ja/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/pl/notifications.xml UNKNOWN 
  indra/newview/skins/minimal/xui/pt/notifications.xml UNKNOWN 

Diff: http://codereview.secondlife.com/r/442/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1041 Removed clothes come back to haunt me

[Nyx Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/441/#review981
---

Ship it!


I was skeptical, but after reviewing some of the code from those systems (that 
I hadn't touched in months), the proposed code appears to be correct. Also 
tested the build and it appears functional. Ship it!

- Nyx


On Aug. 15, 2011, 12:26 p.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/441/
> ---
> 
> (Updated Aug. 15, 2011, 12:26 p.m.)
> 
> 
> Review request for Viewer and Nyx Linden.
> 
> 
> Summary
> ---
> 
> The "Remove all clothes" item of the avatar menu didn't actually remove all 
> clothes.
> 
> I haven't investigated what the problem was, I've just rewritten the 
> (ancient?) removal code
> in the way we take off items in other places, i.e. by removing them from the 
> Current Outfit forder.
> 
> What I'm not sure about is whether we need to call updateAppearanceFromCOF() 
> afterwards. Nyx?
> 
> 
> This addresses bug STORM-1041.
> http://jira.secondlife.com/browse/STORM-1041
> 
> 
> Diffs
> -
> 
>   indra/newview/llagentwearables.h 87fe21031c46 
>   indra/newview/llagentwearables.cpp 87fe21031c46 
>   indra/newview/llinventorybridge.cpp 87fe21031c46 
> 
> Diff: http://codereview.secondlife.com/r/441/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Please Edit Subject Line and referenced message

[Daniel]

A reminder:

Please edit your replies so it has a pertinent subject besides 
"Opensource-dev Digest", and so it does not include the *entire* digest 
(which is very long)

On the subject of ban-happy staff, that seems to be popular this 
summer.  Google+ is banning people for having "funny looking names", 
even when those names are the ones on the user's driver's licence.  That 
would not be such a problem if it were restricted to just Google+, but 
in come cases it has resulted on losing access to all your other Google 
services, including ones you have paid for.  I hope Linden Lab gets 
their internal policy distributed to everyone on staff, and the people 
re-instated who need it.  As somone who typically has 7 viewer versions 
installed for testing, I would be gun-shy of logging in with any of them 
if it means losing my accounts.

Dani


On 8/16/2011 5:10 PM, opensource-dev-requ...@lists.secondlife.com wrote:

  Today's Topics: 1. Re: opensource-dev Digest, Vol 19, Issue 41 (John 
Jackson)
2. Re: opensource-dev Digest, Vol 19, Issue 41 (mala...@tamzap.com)
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-793 Offered URL-like named object is displayed as a HTTP URL in the llGiveInventory

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/442/#review982
---

Ship it!


Looks good now.

- Boroondas


On Aug. 17, 2011, 3:21 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/442/
> ---
> 
> (Updated Aug. 17, 2011, 3:21 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Disallowed parsing HTTP URLs in llGiveInventory notifications (one more case).
> 
> The fix may look weird because we seem to wrap a SLURL with 
> ... tags.
> But actually there is no SLURL, there's just an object name.
> Investigating that goes beyond the bug scope.
> 
> 
> This addresses bug STORM-793.
> http://jira.secondlife.com/browse/STORM-793
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/da/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/de/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/en/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/es/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/fr/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/it/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/ja/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/nl/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/pl/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/pt/notifications.xml UNKNOWN 
>   indra/newview/skins/default/xui/zh/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/da/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/de/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/en/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/es/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/fr/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/it/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/ja/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pl/notifications.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pt/notifications.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/442/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Please Edit Subject Line and referenced message

[Mimika Oh]

On 2011-08-17, at 17:42, Daniel wrote:

> ... As somone who typically has 7 viewer versions 
> installed for testing, I would be gun-shy of logging in with any of them 
> if it means losing my accounts.

+1

(or maybe +7?)

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Please Edit Subject Line and referenced message

[Robert Martin]

On Wed, Aug 17, 2011 at 5:42 PM, Mimika Oh  wrote:
> On 2011-08-17, at 17:42, Daniel wrote:
>
>> ... As somone who typically has 7 viewer versions
>> installed for testing, I would be gun-shy of logging in with any of them
>> if it means losing my accounts.
>
> +1
>
> (or maybe +7?)
If it is found out that a buncha folks have had accounts nuked due to
using a TPV that is unlisted (but is otherwise compliant) then the
person most responsible should have to personally refund every single
linden "confiscated" and personally pay for replacements of any
inventory items lost (say 110% of losses or 600K lindens whichever is
greater).




-- 
Robert L Martin
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Snowstorm team review viewer

[Oz Linden (Scott Lawrence)]

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/238740/index.html

STORM-632 
   URL-like resident display name is shown as clickable HTTP URL in
   various places 
STORM-782 

   Unnecessary 'Compress snapshots to disk' menu item is presented in
   Advanced menu 
STORM-793 

   Offered URL-like named object is displayed as a HTTP URL in the
   llGiveInventory 
STORM-1041 
   removed clothes come back to haunt me 
STORM-1427 

   Crash in world map when region name search is empty (Assert fails in
   LLWorldMapMessage::processMapBlockReply) 
STORM-1534 
   Derive Credits in "About Second Life" from doc/ contents 
STORM-1546 
   [crashhunters] Crash in LLSecAPIBasicHandler::getCertificateStore 
STORM-1554 
   Untranslatable gesture: /bow1 
STORM-1561 

   Some existing viewer-development sources do not pass automated
   coding standard checks. 
STORM-1562 
   Multi-threaded curl crash 




___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] [JIRA] Commented: (STORM-1559) Preferences window is transparent, and hard to read.

[Lee ponzu]

yeah, that was it.  I don't remember ever seeing that before...

On Wed, Aug 17, 2011 at 7:32 PM, Opensource Obscure (JIRA) <
no-re...@secondlife.com> wrote:

>
>[
> https://jira.secondlife.com/browse/STORM-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=278558#comment-278558]
>
> Opensource Obscure commented on STORM-1559:
> ---
>
> Preferences > Colors > Floater Opacity ?
>
> > Preferences window is transparent, and hard to read.
> > 
> >
> > Key: STORM-1559
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges