date:20110728

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-28 Thread Boroondas Gupte


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review934
---



indra/newview/llchathistory.cpp


Yay for removing redundant code!

Was irc_me even set correctly before your change, or did this only work due 
to the
 || chat.mChatStyle == CHAT_STYLE_IRC
part?



indra/newview/llchathistory.cpp


As you cut away a substring of the length of chat.mFrontName, I assume 
chat.mText contains the content of chat.mFrontName at the beginning, not "/me " 
or "/me'"? chat.mText doesn't seem to have been modified since (old) line 747, 
so I guess the comparison you removed there was nonsense, anyway?

Btw., where does mFromName get added to the beginning of mText? Wouldn't it 
be better to not add it in the first place rather than cutting it away again 
here?


- Boroondas


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> ---
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> As a resident of Second Life I find the displaying an emoter's name twice in 
> nearby chat history rather unnecessary.  Please lay eyes on this proposed 
> code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
> http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> ---
> 
> Tell a crowd what you are testing and many will start talking to you prefixed 
> with /me, if they are good sports.  I have been using this change for 3 days 
> now and have not noticed any ill effects.  Please note: This changest is not 
> intended to affect nearby chat toasts, nearby chat log files, IM history, IM 
> toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Snowstorm Product Owner Review build

2011-07-28 Thread Oz Linden (Scott Lawrence)


http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/237151/index.html

a couple of these may be spurious - they were mentioned in commit 
comments for other issues and so show up in the list.   I'm going to be 
lazy and not attempt to filter them out.


STORM-320 
   Script Editor in Viewer 2.0+ "tabs" incorrectly 
STORM-519 

   "Delete" is enabled in the context menu for folders which contain
   worn items 
STORM-565 
   llGiveInventory window is suppressed if avatar in Busy mode 
STORM-1220 

   Region / Estate > Covenant - Type of region is in EN: "Estate / Full
   Region" 
STORM-1233 

   [TRANSLATED BUT IN EN] "Profile" button and tooltip appear
   untranslated at the bottom of the "Places" sidepanel pages (French
   viewer) 
STORM-1234 

   In Nearby Chat, Group Chat and IM Chat, URL selection frequently
   fails to grab last character 
STORM-1291 
   (Spanish) [STRING IN ENG] Gestos button. Many gestures. 
STORM-1311 

   Place Profile only shows 2 lines and users have to click More link
   to see full description 
STORM-1404 

   ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button
   labels and tooltips in People pane 
STORM-1405 

   [HARDCODED] Light Viewer - Untranslated items in Sound Devices
   drop-down list 
STORM-1408 
   [DE] Text truncation in Edit outfit floater 
STORM-1451 
   [DA] "Login failed" message is empty in Danish 
STORM-1458 

   [crashhunters] crash at
   LLParticipantList::LLParticipantListMenu::isGroupModerator()
   [secondlife-bin llparticipantlist.cpp] 
STORM-1474 
   Implement Show Last Search in viewer chrome 
STORM-1529 
   Sound Devices floater is too narrow for its widgets 



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2)

2011-07-28 Thread Log Linden


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/374/
---

(Updated July 28, 2011, 11:06 a.m.)


Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden.


Changes
---

More cleanup to address Monty's comments. More fixes to come. 


Summary
---

This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in 
https://codereview.secondlife.com/r/232/ .  I have tried to address all of the 
comments on that code review and do as much cleanup as possible. The diff 
includes everything that was submitted by Robin, as well as my work.
Major changes since I started working:
* Changed SOCKS 5 proxy control channel to use the existing LLSocket class, 
which is a thin wrapper around APR sockets.
* Worked with the Linden Lab UX team to revamp the proxy controls.
* Proxy credentials are now stored in the LLSecAPI password storage, which is 
the same that is used for users' Second Life Credentials instead of as being 
stored in the clear as a preference.


This addresses bug STORM-1112.
http://jira.secondlife.com/browse/STORM-1112


Diffs (updated)
-

  indra/llcommon/llsingleton.h 2f9a87538ca1 
  indra/llmessage/CMakeLists.txt 2f9a87538ca1 
  indra/llmessage/llcurl.h 2f9a87538ca1 
  indra/llmessage/llcurl.cpp 2f9a87538ca1 
  indra/llmessage/llhttpassetstorage.cpp 2f9a87538ca1 
  indra/llmessage/llhttpclient.cpp 2f9a87538ca1 
  indra/llmessage/lliosocket.h 2f9a87538ca1 
  indra/llmessage/lliosocket.cpp 2f9a87538ca1 
  indra/llmessage/llpacketring.h 2f9a87538ca1 
  indra/llmessage/llpacketring.cpp 2f9a87538ca1 
  indra/llmessage/llproxy.h PRE-CREATION 
  indra/llmessage/llproxy.cpp PRE-CREATION 
  indra/llmessage/llurlrequest.cpp 2f9a87538ca1 
  indra/llmessage/net.h 2f9a87538ca1 
  indra/llmessage/net.cpp 2f9a87538ca1 
  indra/llui/llfunctorregistry.h 2f9a87538ca1 
  indra/newview/app_settings/settings.xml 2f9a87538ca1 
  indra/newview/llappviewer.cpp 2f9a87538ca1 
  indra/newview/llfloaterpreference.h 2f9a87538ca1 
  indra/newview/llfloaterpreference.cpp 2f9a87538ca1 
  indra/newview/llloginhandler.cpp 2f9a87538ca1 
  indra/newview/llpanellogin.h 2f9a87538ca1 
  indra/newview/llsecapi.h 2f9a87538ca1 
  indra/newview/llstartup.h 2f9a87538ca1 
  indra/newview/llstartup.cpp 2f9a87538ca1 
  indra/newview/llviewerfloaterreg.cpp 2f9a87538ca1 
  indra/newview/llxmlrpctransaction.cpp 2f9a87538ca1 
  indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/notifications.xml 2f9a87538ca1 
  indra/newview/skins/default/xui/en/panel_cof_wearables.xml 2f9a87538ca1 
  indra/newview/skins/default/xui/en/panel_preferences_privacy.xml 2f9a87538ca1 
  indra/newview/skins/default/xui/en/panel_preferences_setup.xml 2f9a87538ca1 

Diff: http://codereview.secondlife.com/r/374/diff


Testing
---

I've tested exclusively on Linux so far.  I'm working on a more extensive test 
plan that includes setting up a gateway with a restrictive firewall to verify 
that all traffic is going through the proxy. 

Test builds and screenshots of the changed UI elements are available from the 
project page, located here:
https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer


Thanks,

Log

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets

2011-07-28 Thread Seth ProductEngine


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/418/#review935
---

Ship it!


The code looks perfect. No remarks, no objections.

- Seth


On July 26, 2011, 2:43 p.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/418/
> ---
> 
> (Updated July 26, 2011, 2:43 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Made the Sound Devices floater wider.
> It still doesn't look very nice (probably needs redesign), but the widgets 
> fit and work.
> 
> 
> This addresses bug STORM-1529.
> http://jira.secondlife.com/browse/STORM-1529
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/en/floater_sound_devices.xml 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/418/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1405 Untranslated items in Sound Devices drop-down list

2011-07-28 Thread Seth ProductEngine


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/417/#review936
---

Ship it!


Looks good to me.

- Seth


On July 26, 2011, 2:02 p.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/417/
> ---
> 
> (Updated July 26, 2011, 2:02 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Localized the "No Device" and "Default System Device" strings in the sound 
> devices panel.
> 
> By the way:
> * Fixed improper localization of the "Default" device name which caused 
> saving a localized string in settings.
> * Eliminated redundant getChild() calls.
> 
> 
> This addresses bug STORM-1405.
> http://jira.secondlife.com/browse/STORM-1405
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelvoicedevicesettings.h 2f9a87538ca1 
>   indra/newview/llpanelvoicedevicesettings.cpp 2f9a87538ca1 
>   indra/newview/skins/default/xui/en/panel_sound_devices.xml 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/417/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Problem to download libkdu and fmod

2011-07-28 Thread Laurent Bechir


Hello,

I'm trying to build the viewer on my Mac and I can't go further the autobuild 
step, since I always get a time out for fmod and libkdu. I've found a solution 
for fmod putting an archive I have in my Dropbox, but I can't do that for 
libkdu. Anyone knows what can cause these time out ? I've noticed that when I 
try traceroute on s3-proxy-lindenlab.com, it stops at my router and doesn't go 
beyond. It's not the case for automated-builds-secondlife-com.s3.amazonaws.com, 
or any other destination. Any clue to solve that ?

Thank you
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-28 Thread ardylay



> On July 28, 2011, 2:58 a.m., Boroondas Gupte wrote:
> > indra/newview/llchathistory.cpp, line 929
> > 
> >
> > As you cut away a substring of the length of chat.mFrontName, I assume 
> > chat.mText contains the content of chat.mFrontName at the beginning, not 
> > "/me " or "/me'"? chat.mText doesn't seem to have been modified since (old) 
> > line 747, so I guess the comparison you removed there was nonsense, anyway?
> > 
> > Btw., where does mFromName get added to the beginning of mText? 
> > Wouldn't it be better to not add it in the first place rather than cutting 
> > it away again here?

llviewermessage.cpp line2 3300 - 3368 is where you can find chat.mChatStyle = 
CHAT_STYLE_IRC;  The test I removed was occuring AFTER the /me "emote" was 
stripped from the message from the simulator so was ineffective.  See changeset 
at https://bitbucket.org/lindenlab/viewer-development/changeset/741e44af9f02 
line 493.  It prepends sender name, if it exists, then removes the leading 3 
characters "/me" from the message.  I did not see that display context was 
available at the time the name was prepended so was removed the name after 
context was available.  Perhaps there is a better way?


- ardy.lay


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review934
---


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> ---
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> As a resident of Second Life I find the displaying an emoter's name twice in 
> nearby chat history rather unnecessary.  Please lay eyes on this proposed 
> code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
> http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> ---
> 
> Tell a crowd what you are testing and many will start talking to you prefixed 
> with /me, if they are good sports.  I have been using this change for 3 days 
> now and have not noticed any ill effects.  Please note: This changest is not 
> intended to affect nearby chat toasts, nearby chat log files, IM history, IM 
> toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Problem to download libkdu and fmod

2011-07-28 Thread WolfPup Lowenhar

First is sounds like you using something besides the configurations that end
in OS as those are for the Open Source Developers to use so that you do not
have the problem of DLing the private libs that those of us on the outside
do not have access to.
Second there is an autobuild 3p-fmod that you can build locally and then
place the information generated during the packaging in the autobuild.xml
file and set fmod=on in the settings for OS builds in the autobuild.xml and
then fmod wil 'dl' and install to the build tree.

> -Original Message-
> From: opensource-dev-boun...@lists.secondlife.com [mailto:opensource-dev-
> boun...@lists.secondlife.com] On Behalf Of Laurent Bechir
> Sent: Thursday, July 28, 2011 6:15 PM
> To: Viewer
> Subject: [opensource-dev] Problem to download libkdu and fmod
> 
> 
> Hello,
> 
> I'm trying to build the viewer on my Mac and I can't go further the
autobuild
> step, since I always get a time out for fmod and libkdu. I've found a
solution
> for fmod putting an archive I have in my Dropbox, but I can't do that for
> libkdu. Anyone knows what can cause these time out ? I've noticed that
when I
> try traceroute on s3-proxy-lindenlab.com, it stops at my router and
doesn't go
> beyond. It's not the case for automated-builds-secondlife-
> com.s3.amazonaws.com, or any other destination. Any clue to solve that ?
> 
> Thank you
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
> -
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1390 / Virus Database: 1518/3793 - Release Date: 07/28/11

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Snowstorm Product Owner Review build

2011-07-28 Thread Anya Kanevsky

Awesomeness, all approved. Except for the ones that were already integrated
and got in by accident.

thank you!

2011/7/28 Oz Linden (Scott Lawrence) 

>
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/237151/index.html
>
> a couple of these may be spurious - they were mentioned in commit comments
> for other issues and so show up in the list.   I'm going to be lazy and not
> attempt to filter them out.
>
>  STORM-320  Script Editor in
> Viewer 2.0+ "tabs" incorrectly 
> STORM-519 "Delete"
> is enabled in the context menu for folders which contain worn items
> STORM-565  llGiveInventory
> window is suppressed if avatar in Busy mode 
> STORM-1220 Region
> / Estate > Covenant - Type of region is in EN: "Estate / Full Region"
> STORM-1233  [TRANSLATED BUT
> IN EN] "Profile" button and tooltip appear untranslated at the bottom of the
> "Places" sidepanel pages (French viewer) 
> STORM-1234 In
> Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab
> last character STORM-1291  
> (Spanish)
> [STRING IN ENG] Gestos button. Many gestures. 
> STORM-1311 Place
> Profile only shows 2 lines and users have to click More link to see full
> description STORM-1404  ALL
> LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button labels and
> tooltips in People pane 
> STORM-1405 [HARDCODED]
> Light Viewer - Untranslated items in Sound Devices drop-down list
> STORM-1408  [DE] Text
> truncation in Edit outfit floater 
> STORM-1451 [DA]
> "Login failed" message is empty in Danish 
> STORM-1458 [crashhunters]
> crash at LLParticipantList::LLParticipantListMenu::isGroupModerator()
> [secondlife-bin llparticipantlist.cpp] 
> STORM-1474 Implement
> Show Last Search in viewer chrome 
> STORM-1529 Sound
> Devices floater is too narrow for its widgets
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Problem to download libkdu and fmod

2011-07-28 Thread Laurent Bechir


Thank you for all your answers :) I've put an archive of fmod on my server, and 
the link and md5sum in autobuild.xml. I've used -c ReleaseOS, and it worked.

Le 29 juil. 2011 à 01:23, WolfPup Lowenhar a écrit :

> First is sounds like you using something besides the configurations that end
> in OS as those are for the Open Source Developers to use so that you do not
> have the problem of DLing the private libs that those of us on the outside
> do not have access to.
> Second there is an autobuild 3p-fmod that you can build locally and then
> place the information generated during the packaging in the autobuild.xml
> file and set fmod=on in the settings for OS builds in the autobuild.xml and
> then fmod wil 'dl' and install to the build tree.
> 
>> -Original Message-
>> From: opensource-dev-boun...@lists.secondlife.com [mailto:opensource-dev-
>> boun...@lists.secondlife.com] On Behalf Of Laurent Bechir
>> Sent: Thursday, July 28, 2011 6:15 PM
>> To: Viewer
>> Subject: [opensource-dev] Problem to download libkdu and fmod
>> 
>> 
>> Hello,
>> 
>> I'm trying to build the viewer on my Mac and I can't go further the
> autobuild
>> step, since I always get a time out for fmod and libkdu. I've found a
> solution
>> for fmod putting an archive I have in my Dropbox, but I can't do that for
>> libkdu. Anyone knows what can cause these time out ? I've noticed that
> when I
>> try traceroute on s3-proxy-lindenlab.com, it stops at my router and
> doesn't go
>> beyond. It's not the case for automated-builds-secondlife-
>> com.s3.amazonaws.com, or any other destination. Any clue to solve that ?
>> 
>> Thank you
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting
>> privileges
>> -
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 10.0.1390 / Virus Database: 1518/3793 - Release Date: 07/28/11
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

2011-07-28 Thread Richard Nelson


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/405/#review938
---

Ship it!


Looks good

- Richard


On July 21, 2011, 2:55 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/405/
> ---
> 
> (Updated July 21, 2011, 2:55 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Set the z (depth) coordinate of hovertext such that the hovertext gets 
> occluded by stuff in front of it.
> 
> 
> This addresses bugs SH-489, VWR-24017 and VWR-25588.
> http://jira.secondlife.com/browse/SH-489
> http://jira.secondlife.com/browse/VWR-24017
> http://jira.secondlife.com/browse/VWR-25588
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 46c7b36793c9 
>   indra/llrender/llfontgl.cpp 46c7b36793c9 
> 
> Diff: http://codereview.secondlife.com/r/405/diff
> 
> 
> Testing
> ---
> 
> Merged this change with e67da2c6e312 (as I still cannot build 
> viewer-development tip) and rebuilt. Verified that my nametag and an objects 
> llSetText hovertext were correctly occluded by another object in front of 
> them.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

2011-07-28 Thread ardylay


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/405/#review939
---

Ship it!


I am using it without noticing any functional issues.  Does this return 
floating text and nametags to a previous behavior I haven't seen for a long 
time?  I think it does.  It feels comfortable to me and really decluters the 
display.

- ardy.lay


On July 21, 2011, 2:55 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/405/
> ---
> 
> (Updated July 21, 2011, 2:55 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Set the z (depth) coordinate of hovertext such that the hovertext gets 
> occluded by stuff in front of it.
> 
> 
> This addresses bugs SH-489, VWR-24017 and VWR-25588.
> http://jira.secondlife.com/browse/SH-489
> http://jira.secondlife.com/browse/VWR-24017
> http://jira.secondlife.com/browse/VWR-25588
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 46c7b36793c9 
>   indra/llrender/llfontgl.cpp 46c7b36793c9 
> 
> Diff: http://codereview.secondlife.com/r/405/diff
> 
> 
> Testing
> ---
> 
> Merged this change with e67da2c6e312 (as I still cannot build 
> viewer-development tip) and rebuilt. Verified that my nametag and an objects 
> llSetText hovertext were correctly occluded by another object in front of 
> them.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1436 [JP]"Contents" and "New Script" folder text are missing in "Content" tab for "Build" floater

2011-07-28 Thread Vadim ProductEngine


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/420/
---

Review request for Viewer and Richard Nelson.


Summary
---

Fixed broken localization of "Contents" and "New Script" items in the Contents 
tab of Build Tools.
The bug happened when the translations contained non-ASCII characters.

Reason: Names of inventory items are limited to ASCII characters.
Fix: Leave names in English, localize them when displaying (on the fly).

The fix only affects object's inventory (i.e. not agent inventory).


This addresses bug STORM-1436.
http://jira.secondlife.com/browse/STORM-1436


Diffs
-

  indra/newview/llpanelcontents.cpp 2f9a87538ca1 
  indra/newview/llpanelobjectinventory.cpp 2f9a87538ca1 
  indra/newview/llviewerobject.cpp 2f9a87538ca1 

Diff: http://codereview.secondlife.com/r/420/diff


Testing
---

Tested Japanese and Polish translations. The "Contents", "New Script", ""New 
Script 1", "New Script 2", etc names were correctly localized.


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

[opensource-dev] Snowstorm Product Owner Review build

Re: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2)

Re: [opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets

Re: [opensource-dev] Review Request: STORM-1405 Untranslated items in Sound Devices drop-down list

[opensource-dev] Problem to download libkdu and fmod

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

Re: [opensource-dev] Problem to download libkdu and fmod

Re: [opensource-dev] Snowstorm Product Owner Review build

Re: [opensource-dev] Problem to download libkdu and fmod

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

[opensource-dev] Review Request: STORM-1436 [JP]"Contents" and "New Script" folder text are missing in "Content" tab for "Build" floater

13 matches

Site Navigation

Mail list logo

Footer information