Re: [opensource-dev] Review Request: STORM-565 llGiveInventory window is suppressed if avatar in Busy mode

2011-07-26 Thread Seth ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/413/#review930
---

Ship it!


Looks good.

- Seth


On July 25, 2011, 6:29 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/413/
> ---
> 
> (Updated July 25, 2011, 6:29 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Allow inventory offers from objects in Busy mode.
> 
> 
> This addresses bug STORM-565.
> http://jira.secondlife.com/browse/STORM-565
> 
> 
> Diffs
> -
> 
>   indra/newview/llviewermessage.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/413/diff
> 
> 
> Testing
> ---
> 
> Tried inventory offers from objects and avatars in normal and busy modes.
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] mesh upload?

2011-07-26 Thread Lance Corrimal
Hi gang,


is there any news about mesh upload in OS-viewers?

The last that I've found with google was a bit of discussion to the effect that 
"we need to
find out what license bullet and that other lib are under", with no result...

... took me about 5 minutes with the websites and source code to see that 
bullet is under its
own open source license which basically says "free to use for anyone for any 
purpose including
alering it as long as you mention where it came from", and that other one by 
john ratcliffe is
under MIT license which is basically the same... to my understanding.

is anyone working on anything?

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


[opensource-dev] Review Request: STORM-1291 [STRING IN ENG] Gestos button. Many gestures.

2011-07-26 Thread Vadim ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/416/
---

Review request for Viewer and Richard Nelson.


Summary
---

Localize names of inventory items fetched via HTTP POST requests.

These were not localized, unlike ones fetched via the message system.


This addresses bug STORM-1291.
http://jira.secondlife.com/browse/STORM-1291


Diffs
-

  indra/newview/llviewerinventory.cpp 2f9a87538ca1 

Diff: http://codereview.secondlife.com/r/416/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1291 [STRING IN ENG] Gestos button. Many gestures.

2011-07-26 Thread Boroondas Gupte

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/416/#review931
---

Ship it!


- Boroondas


On July 26, 2011, 8:32 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/416/
> ---
> 
> (Updated July 26, 2011, 8:32 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> ---
> 
> Localize names of inventory items fetched via HTTP POST requests.
> 
> These were not localized, unlike ones fetched via the message system.
> 
> 
> This addresses bug STORM-1291.
> http://jira.secondlife.com/browse/STORM-1291
> 
> 
> Diffs
> -
> 
>   indra/newview/llviewerinventory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/416/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] mesh upload?

2011-07-26 Thread WolfPup Lowenhar
Yes see https://jira.secondlife.com/browse/OPEN-105 that is tracking the
work being done.

> -Original Message-
> From: opensource-dev-boun...@lists.secondlife.com [mailto:opensource-dev-
> boun...@lists.secondlife.com] On Behalf Of Lance Corrimal
> Sent: Tuesday, July 26, 2011 9:34 AM
> To: opensource-dev@lists.secondlife.com
> Subject: [opensource-dev] mesh upload?
> 
> Hi gang,
> 
> 
> is there any news about mesh upload in OS-viewers?
> 
> The last that I've found with google was a bit of discussion to the effect
that
> "we need to
> find out what license bullet and that other lib are under", with no
result...
> 
> ... took me about 5 minutes with the websites and source code to see that
> bullet is under its
> own open source license which basically says "free to use for anyone for
any
> purpose including
> alering it as long as you mention where it came from", and that other one
by
> john ratcliffe is
> under MIT license which is basically the same... to my understanding.
> 
> is anyone working on anything?
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
> -
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1390 / Virus Database: 1518/3789 - Release Date: 07/26/11

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2)

2011-07-26 Thread Log Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/374/
---

(Updated July 26, 2011, 10:20 a.m.)


Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden.


Changes
---

Added proxy support to other places libcurl is used in the viewer.  This is 
still a WIP, but I wanted to update to match what is available on bitbucket.


Summary
---

This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in 
https://codereview.secondlife.com/r/232/ .  I have tried to address all of the 
comments on that code review and do as much cleanup as possible. The diff 
includes everything that was submitted by Robin, as well as my work.
Major changes since I started working:
* Changed SOCKS 5 proxy control channel to use the existing LLSocket class, 
which is a thin wrapper around APR sockets.
* Worked with the Linden Lab UX team to revamp the proxy controls.
* Proxy credentials are now stored in the LLSecAPI password storage, which is 
the same that is used for users' Second Life Credentials instead of as being 
stored in the clear as a preference.


This addresses bug STORM-1112.
http://jira.secondlife.com/browse/STORM-1112


Diffs (updated)
-

  indra/llcommon/llsingleton.h 216ebc0442d2 
  indra/llmessage/CMakeLists.txt 216ebc0442d2 
  indra/llmessage/llcurl.h 216ebc0442d2 
  indra/llmessage/llcurl.cpp 216ebc0442d2 
  indra/llmessage/llhttpassetstorage.cpp 216ebc0442d2 
  indra/llmessage/llhttpclient.cpp 216ebc0442d2 
  indra/llmessage/lliosocket.h 216ebc0442d2 
  indra/llmessage/lliosocket.cpp 216ebc0442d2 
  indra/llmessage/llpacketring.h 216ebc0442d2 
  indra/llmessage/llpacketring.cpp 216ebc0442d2 
  indra/llmessage/llproxy.h PRE-CREATION 
  indra/llmessage/llproxy.cpp PRE-CREATION 
  indra/llmessage/llurlrequest.cpp 216ebc0442d2 
  indra/llmessage/net.h 216ebc0442d2 
  indra/llmessage/net.cpp 216ebc0442d2 
  indra/llui/llfunctorregistry.h 216ebc0442d2 
  indra/newview/app_settings/settings.xml 216ebc0442d2 
  indra/newview/llappviewer.cpp 216ebc0442d2 
  indra/newview/llfloaterpreference.h 216ebc0442d2 
  indra/newview/llfloaterpreference.cpp 216ebc0442d2 
  indra/newview/llloginhandler.cpp 216ebc0442d2 
  indra/newview/llpanellogin.h 216ebc0442d2 
  indra/newview/llsecapi.h 216ebc0442d2 
  indra/newview/llstartup.h 216ebc0442d2 
  indra/newview/llstartup.cpp 216ebc0442d2 
  indra/newview/llviewerfloaterreg.cpp 216ebc0442d2 
  indra/newview/llxmlrpctransaction.cpp 216ebc0442d2 
  indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/notifications.xml 216ebc0442d2 
  indra/newview/skins/default/xui/en/panel_cof_wearables.xml 216ebc0442d2 
  indra/newview/skins/default/xui/en/panel_preferences_privacy.xml 216ebc0442d2 
  indra/newview/skins/default/xui/en/panel_preferences_setup.xml 216ebc0442d2 

Diff: http://codereview.secondlife.com/r/374/diff


Testing
---

I've tested exclusively on Linux so far.  I'm working on a more extensive test 
plan that includes setting up a gateway with a restrictive firewall to verify 
that all traffic is going through the proxy. 

Test builds and screenshots of the changed UI elements are available from the 
project page, located here:
https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer


Thanks,

Log

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Return drawable/object at mouse point

2011-07-26 Thread Lockwood, Nick
I'm writing some code for a research project to log the object at a
particular point on the screen (using mouse coordinates). So far I've
made use of the LLViewerWindow::cursorIntersect function which seems to
work pretty well. However, I can't seem to capture certain things like
the sky, clouds, water, etc. 

 

Is there a way that I can capture everything being rendered in the
scene? I was hoping it is possible to capture a particular drawable
being displayed at a given point. Then, I should be able to get the
object associated with that drawable as well as the render type. I just
haven't figured out an easy way to do that yet. Are there any functions
I'm missing, or does anyone have a suggestion as to how I can capture
these data? 

 

Thanks!

Nick

 

 

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1405 Untranslated items in Sound Devices drop-down list

2011-07-26 Thread Vadim ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/417/
---

Review request for Viewer.


Summary
---

Localized the "No Device" and "Default System Device" strings in the sound 
devices panel.

By the way:
* Fixed improper localization of the "Default" device name which caused saving 
a localized string in settings.
* Eliminated redundant getChild() calls.


This addresses bug STORM-1405.
http://jira.secondlife.com/browse/STORM-1405


Diffs
-

  indra/newview/llpanelvoicedevicesettings.h 2f9a87538ca1 
  indra/newview/llpanelvoicedevicesettings.cpp 2f9a87538ca1 
  indra/newview/skins/default/xui/en/panel_sound_devices.xml 2f9a87538ca1 

Diff: http://codereview.secondlife.com/r/417/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-26 Thread Vadim ProductEngine


> On July 25, 2011, 10:04 a.m., Boroondas Gupte wrote:
> > > It's up to the translation team to remove obsolete translations.
> > 
> > In that case, no further concerns. Should we file a jira issue to make the 
> > translation team aware of the obsolete elements?
> 
> Vadim ProductEngine wrote:
> Not sure whether it makes sense. I'll find out.

So, their localization tool does detect obsolete translations, but only when 
the "en" file changes.
If you want to get rid of them earlier, please feel free to file a jira.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/412/#review923
---


On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/412/
> ---
> 
> (Updated July 22, 2011, 10:51 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Bug reason: incorrect reuse of an xml element name.
> Fix: provided unique names for the buttons.
> 
> 
> This addresses bug STORM-1404.
> http://jira.secondlife.com/browse/STORM-1404
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/412/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets

2011-07-26 Thread Vadim ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/418/
---

Review request for Viewer.


Summary
---

Made the Sound Devices floater wider.
It still doesn't look very nice (probable needs redesign), but the widgets fit 
and work.


This addresses bug STORM-1529.
http://jira.secondlife.com/browse/STORM-1529


Diffs
-

  indra/newview/skins/default/xui/en/floater_sound_devices.xml 2f9a87538ca1 

Diff: http://codereview.secondlife.com/r/418/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets

2011-07-26 Thread Vadim ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/418/
---

(Updated July 26, 2011, 2:43 p.m.)


Review request for Viewer.


Changes
---

typo


Summary (updated)
---

Made the Sound Devices floater wider.
It still doesn't look very nice (probably needs redesign), but the widgets fit 
and work.


This addresses bug STORM-1529.
http://jira.secondlife.com/browse/STORM-1529


Diffs
-

  indra/newview/skins/default/xui/en/floater_sound_devices.xml 2f9a87538ca1 

Diff: http://codereview.secondlife.com/r/418/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Quick test of open-38 integration

2011-07-26 Thread Boroondas Gupte
On 07/22/2011 04:02 PM, Oz Linden (Scott Lawrence) wrote:
> I'm planning to integrate the changes from
>
> https://codereview.secondlife.com/r/167/
>
> to better support standalone builds.
>
> I've done a test (non-standalone) build in our build farm, which appears 
> to have completed successfully.  I'd appreciate it if a few users would 
> run the resulting viewers:
>
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-1/rev/236387/index.html
>
> and let me know if anything is broken (that is not broken in a beta or 
> development build).

I have used this build for a while now and haven't notice any problems
except some that I could also repro in
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/23638*8*/index.html
(which is a regular viewer-dev build without the OPEN-38 changes)

Cheers,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges