Re: [opensource-dev] Review Request: VWR-26458: fixing a simple typo in German translation
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/408/#review914 --- Ship it! - Vadim On July 21, 2011, 3:42 p.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/408/ > --- > > (Updated July 21, 2011, 3:42 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Found this coincidentally when looking through recent changesets. Thought I'd > fix it right away. > > > This addresses bug VWR-26458. > http://jira.secondlife.com/browse/VWR-26458 > > > Diffs > - > > doc/contributions.txt 06874d04d57e > indra/newview/skins/default/xui/de/floater_delete_env_preset.xml > 06874d04d57e > > Diff: http://codereview.secondlife.com/r/408/diff > > > Testing > --- > > none > > > Thanks, > > Boroondas > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1523: fixing a simple typo in German translation
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/408/ --- (Updated July 23, 2011, 6:49 a.m.) Review request for Viewer. Changes --- Updated JIRA ticket number. Summary (updated) --- Found this coincidentally when looking through recent changesets. Thought I'd fix it right away. This addresses bug STORM-1523. http://jira.secondlife.com/browse/STORM-1523 Diffs - doc/contributions.txt 06874d04d57e indra/newview/skins/default/xui/de/floater_delete_env_preset.xml 06874d04d57e Diff: http://codereview.secondlife.com/r/408/diff Testing --- none Thanks, Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review915 --- https://bitbucket.org/lindenlab/viewer-development/changeset/a0b400b5ff0e/ The comments in this changeset describe the windows build / link issues for this CR. - Nicky On July 21, 2011, 8:43 a.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/313/ > --- > > (Updated July 21, 2011, 8:43 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Context: We are currently using Boost 1.45, which already comes with the new > Boost Filesystem Library API (Version 3) but still defaults to the old one > (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will > be the last one to come with V2. The Boost Filesystem Library documentation > recommends "Existing code should be moved to Version 3 as soon as convenient. > New code should be written for Version 3. Version 2 is deprecated, and will > not be included in Boost releases 1.48 and later." > > This change overrides the default, so that the V3 API is used, and makes the > necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever > we feel like it.) > > Note: I only changed stuff that the compiler complained about. If the new API > also changes semantic of still-compiling library usage, more changes might be > necessary. > > > This addresses bug OPEN-67. > http://jira.secondlife.com/browse/OPEN-67 > > > Diffs > - > > doc/contributions.txt 959f9340da92 > indra/llvfs/lldiriterator.cpp 959f9340da92 > > Diff: http://codereview.secondlife.com/r/313/diff > > > Testing > --- > > * Compiled Viewer (standalone) with Boost 1.45 > * Started Viewer > * Logged in > > * Compiled Viewer (standalone) with Boost 1.46 > * Started Viewer > * Logged in > > Not tested: > * non-standalone > > > Thanks, > > Boroondas > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
