[opensource-dev] Snowstorm PO review viewer

[Oz Linden (Scott Lawrence)]

Review viewer for checking whether or not issues are properly resolved:

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/236138/index.html

STORM-1221 
   [HARD CODED] ALL LANGS Several strings are untranslated under Group
   Profile Land/Assets (French viewer) 
STORM-1476 
   [crashhunters] Crash loading local chat log 
STORM-1487 
   Gestures -> Get more leads to wrong URL 
STORM-1502 
   Disable "Delete Water/Sky/Day Preset" dialogs if no user presets exist 
STORM-1503 
   Find floater doesn't set focus to its browser. 
VWR-26066 

   [#STORM-1397] [VWR-26066] Opening the map floater consistently
   produces a warning on stdout and debug console. 



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome

[Paul ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/402/
---

Review request for Viewer.


Summary
---

- Removed hiding floater on teleport


This addresses bug storm-1474.
http://jira.secondlife.com/browse/storm-1474


Diffs
-

  indra/newview/llagent.cpp d8c37b383028 

Diff: http://codereview.secondlife.com/r/402/diff


Testing
---


Thanks,

Paul

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/402/#review894
---

Ship it!


- Boroondas


On July 20, 2011, 9:09 a.m., Paul ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/402/
> ---
> 
> (Updated July 20, 2011, 9:09 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> - Removed hiding floater on teleport
> 
> 
> This addresses bug storm-1474.
> http://jira.secondlife.com/browse/storm-1474
> 
> 
> Diffs
> -
> 
>   indra/newview/llagent.cpp d8c37b383028 
> 
> Diff: http://codereview.secondlife.com/r/402/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Paul
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp])

[Paul ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/404/
---

Review request for Viewer.


Summary
---

- Added null checking


This addresses bug storm-1458.
http://jira.secondlife.com/browse/storm-1458


Diffs
-

  indra/newview/llparticipantlist.cpp d8c37b383028 

Diff: http://codereview.secondlife.com/r/404/diff


Testing
---


Thanks,

Paul

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp])

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/404/#review896
---



indra/newview/llparticipantlist.cpp


Either this comment should be moved inside the if-block or it should be 
formulated as a question:
// Is agent in group call?

Otherwise it might give the wrong impression that it is already known that 
the agent is in a group call at the point where the comment appears.

Also, is this really about group calls (i.e. voice) or rather/also group 
chat (i.e. text).



indra/newview/llparticipantlist.cpp


I think if the speaker manager is missing (pointer is null), at least a 
warning in the log would be warranted.

I'm not sure whether the same applies for missing (i.e. null) speaker. 
(Could the agent have left the group call/chat meanwhile thus not be in the 
speaker list anymore?)



indra/newview/llparticipantlist.cpp


This comment should read
// Is agent a moderator?
or similar.


- Boroondas


On July 20, 2011, 11:16 a.m., Paul ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/404/
> ---
> 
> (Updated July 20, 2011, 11:16 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> - Added null checking
> 
> 
> This addresses bug storm-1458.
> http://jira.secondlife.com/browse/storm-1458
> 
> 
> Diffs
> -
> 
>   indra/newview/llparticipantlist.cpp d8c37b383028 
> 
> Diff: http://codereview.secondlife.com/r/404/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Paul
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges