Re: [opensource-dev] Review Request: Support SOCKS 5 proxy in the viewer.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/#review855 --- It looks like you have the name= the same for the "Proxy Settings:" text as for "Software updates:" in the panel_preferences_setup.xml file. These need to be different for translations to work. - Tankmaster On July 8, 2011, 11:55 a.m., Log Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/374/ > --- > > (Updated July 8, 2011, 11:55 a.m.) > > > Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. > > > Summary > --- > > This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in > https://codereview.secondlife.com/r/232/ . I have tried to address all of > the comments on that code review and do as much cleanup as possible. The diff > includes everything that was submitted by Robin, as well as my work. > Major changes since I started working: > * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, > which is a thin wrapper around APR sockets. > * Worked with the Linden Lab UX team to revamp the proxy controls. > * Proxy credentials are now stored in the LLSecAPI password storage, which is > the same that is used for users' Second Life Credentials instead of as being > stored in the clear as a preference. > > > This addresses bug STORM-1112. > http://jira.secondlife.com/browse/STORM-1112 > > > Diffs > - > > indra/llmessage/CMakeLists.txt c7a4b7a24e05 > indra/llmessage/llcurl.cpp c7a4b7a24e05 > indra/llmessage/lliosocket.h c7a4b7a24e05 > indra/llmessage/lliosocket.cpp c7a4b7a24e05 > indra/llmessage/llpacketring.h c7a4b7a24e05 > indra/llmessage/llpacketring.cpp c7a4b7a24e05 > indra/llmessage/llproxy.h PRE-CREATION > indra/llmessage/llproxy.cpp PRE-CREATION > indra/llmessage/net.h c7a4b7a24e05 > indra/llmessage/net.cpp c7a4b7a24e05 > indra/llui/llfunctorregistry.h c7a4b7a24e05 > indra/newview/app_settings/settings.xml c7a4b7a24e05 > indra/newview/llappviewer.cpp c7a4b7a24e05 > indra/newview/llfloaterpreference.h c7a4b7a24e05 > indra/newview/llfloaterpreference.cpp c7a4b7a24e05 > indra/newview/llloginhandler.cpp c7a4b7a24e05 > indra/newview/llpanellogin.h c7a4b7a24e05 > indra/newview/llsecapi.h c7a4b7a24e05 > indra/newview/llstartup.h c7a4b7a24e05 > indra/newview/llstartup.cpp c7a4b7a24e05 > indra/newview/llviewerfloaterreg.cpp c7a4b7a24e05 > indra/newview/llxmlrpctransaction.cpp c7a4b7a24e05 > indra/newview/skins/default/xui/en/floater_preferences_proxy.xml > PRE-CREATION > indra/newview/skins/default/xui/en/notifications.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_cof_wearables.xml c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_preferences_privacy.xml > c7a4b7a24e05 > indra/newview/skins/default/xui/en/panel_preferences_setup.xml c7a4b7a24e05 > > Diff: http://codereview.secondlife.com/r/374/diff > > > Testing > --- > > I've tested exclusively on Linux so far. I'm working on a more extensive > test plan that includes setting up a gateway with a restrictive firewall to > verify that all traffic is going through the proxy. > > Test builds and screenshots of the changed UI elements are available from the > project page, located here: > https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer > > > Thanks, > > Log > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Autobuild errors
On 7/8/2011 3:30 PM, Oz Linden (Scott Lawrence) wrote: > On 2011-07-08 13:27, Lee ponzu wrote: >> Still getting an error... >> >> mbpro:viewer-beta lee$ autobuild build --verbose -c ReleaseOS >> executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release >> -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife >> -DINSTALL_PROPRIETARY=FALSE -G 'Xcode' ../indra >> checking package fmod >> installing fmod from archive > You need to re-run the 'autobuild configure' with the *OS configuration. > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges I am getting this same error on a clean VM with autobuild executed with "autobuild configure ReleaseOS --". ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Autobuild errors
On 7/10/2011 9:10 AM, feedkatze wrote: > On 7/8/2011 3:30 PM, Oz Linden (Scott Lawrence) wrote: >> On 2011-07-08 13:27, Lee ponzu wrote: >>> Still getting an error... >>> >>> mbpro:viewer-beta lee$ autobuild build --verbose -c ReleaseOS >>> executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=Release >>> -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife >>> -DINSTALL_PROPRIETARY=FALSE -G 'Xcode' ../indra >>> checking package fmod >>> installing fmod from archive >> You need to re-run the 'autobuild configure' with the *OS configuration. >> ___ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges > I am getting this same error on a clean VM with autobuild executed > with "autobuild configure ReleaseOS --". Disregard, forgot the " -c " between configure and ReleaseOS. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/351/
---
(Updated July 10, 2011, 12:28 p.m.)
Review request for Viewer.
Changes
---
added duplicate issues to 'Bugs'
Summary
---
These flags prevent building for 64-bit (both standalone or non-standalone), so
only use them for 32-bit builds.
This addresses bugs CTS-315, OPEN-79 and OPEN-99.
http://jira.secondlife.com/browse/CTS-315
http://jira.secondlife.com/browse/OPEN-79
http://jira.secondlife.com/browse/OPEN-99
Diffs
-
doc/contributions.txt e8f2a53c3d6e
indra/cmake/00-Common.cmake e8f2a53c3d6e
Diff: http://codereview.secondlife.com/r/351/diff
Testing
---
Tried a non-standalone 64-bit build (without using 64-bit prebuilts, though):
Fails with
[ 11%] Building CXX object
llcommon/CMakeFiles/llcommon.dir/u64.o
Linking CXX shared library libllcommon.so
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
skipping incompatible
${SRC_DIR}/build-linux-i686/packages/lib/release/libbreakpad_client.so when
searching for -lbreakpad_client
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
skipping incompatible
${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.so when searching
for -laprutil-1
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
skipping incompatible
${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.a when searching
for -laprutil-1
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
skipping incompatible
${SRC_DIR}/build-linux-i686/packages/lib/release/libdb-5.1.so when searching
for -ldb-5.1
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
cannot find -ldb-5.1
collect2: ld returned 1 exit status
make[2]: *** [llcommon/libllcommon.so] Error 1
make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2
make: *** [all] Error 2
ERROR: building default configuration returned 2
For more information: try re-running your command with
--verbose or --debug
(This is, off course, expected. Will have to produce my own 64bit
prebuilts for local use.)
Tried a standalone 64-bit build (after merging OPEN-38 changes):
Fails by hitting https://jira.secondlife.com/browse/OPEN-100
(Both errors occur much later in the build process than the one that'd occur
without this change.)
Tried a non-standalone 32-bit build:
Fails on https://jira.secondlife.com/browse/OPEN-23 , just as without
this change.
Thanks,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/351/
---
(Updated July 10, 2011, 12:59 p.m.)
Review request for Viewer and Nyx Linden.
Changes
---
Added Nyx Linden to reviewers, as OPEN-79 is assigned to him.
Summary
---
These flags prevent building for 64-bit (both standalone or non-standalone), so
only use them for 32-bit builds.
This addresses bugs CTS-315, OPEN-79 and OPEN-99.
http://jira.secondlife.com/browse/CTS-315
http://jira.secondlife.com/browse/OPEN-79
http://jira.secondlife.com/browse/OPEN-99
Diffs
-
doc/contributions.txt e8f2a53c3d6e
indra/cmake/00-Common.cmake e8f2a53c3d6e
Diff: http://codereview.secondlife.com/r/351/diff
Testing
---
Tried a non-standalone 64-bit build (without using 64-bit prebuilts, though):
Fails with
[ 11%] Building CXX object
llcommon/CMakeFiles/llcommon.dir/u64.o
Linking CXX shared library libllcommon.so
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
skipping incompatible
${SRC_DIR}/build-linux-i686/packages/lib/release/libbreakpad_client.so when
searching for -lbreakpad_client
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
skipping incompatible
${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.so when searching
for -laprutil-1
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
skipping incompatible
${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.a when searching
for -laprutil-1
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
skipping incompatible
${SRC_DIR}/build-linux-i686/packages/lib/release/libdb-5.1.so when searching
for -ldb-5.1
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld:
cannot find -ldb-5.1
collect2: ld returned 1 exit status
make[2]: *** [llcommon/libllcommon.so] Error 1
make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2
make: *** [all] Error 2
ERROR: building default configuration returned 2
For more information: try re-running your command with
--verbose or --debug
(This is, off course, expected. Will have to produce my own 64bit
prebuilts for local use.)
Tried a standalone 64-bit build (after merging OPEN-38 changes):
Fails by hitting https://jira.secondlife.com/browse/OPEN-100
(Both errors occur much later in the build process than the one that'd occur
without this change.)
Tried a non-standalone 32-bit build:
Fails on https://jira.secondlife.com/browse/OPEN-23 , just as without
this change.
Thanks,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/ --- Review request for Viewer. Summary --- The layout_panels containing the buttons didn't have unique names. Renamed them so that their names are now unique within their parent element. Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version. The English file mixed tabs and spaces. Converted tabs to spaces for that file. Stripped trailing whitespace from the English file. This addresses bug STORM-1403. http://jira.secondlife.com/browse/STORM-1403 Diffs - doc/contributions.txt 2204db549295 indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 Diff: http://codereview.secondlife.com/r/387/diff Testing --- Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.) Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French. Not tested: * Funktionality of the buttons. * Languages other than French. Thanks, Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
