Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/370/
---

(Updated June 30, 2011, 1:27 a.m.)


Review request for Viewer.


Changes
---

Updated comment per Nicky's suggestion


Summary
---

Add a feature on the "Wearing TAB" where users could copy to the clipboard 
everything you see in the "Wearing TAB". This would make the blogging 
communities life soo much easier instead of having to type out all that 
information.

The label on this button needs input from someone on the XD team.

I would like to know if my code for adding a CR to the end of every line but 
the last one could be done in a more elegant way.


This addresses bug STORM-1459.
http://jira.secondlife.com/browse/STORM-1459


Diffs (updated)
-

  doc/contributions.txt f9864a43ddf0 
  indra/newview/llpanelwearing.h f9864a43ddf0 
  indra/newview/llpanelwearing.cpp f9864a43ddf0 
  indra/newview/skins/default/xui/en/menu_wearing_gear.xml f9864a43ddf0 

Diff: http://codereview.secondlife.com/r/370/diff


Testing
---

Clicked on Send to Clipboard button and was able to paste results into an 
editor.


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] focus to Inventory Search

[Opensource Obscure]

Please enable back focus to Inventory Search.

See https://jira.secondlife.com/browse/VWR-19700
https://jira.secondlife.com/browse/VWR-18496
https://jira.secondlife.com/browse/VWR-19967

Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
discuss Second Life Viewer 2: http://j.mp/slv2group
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review831
---

Ship it!


Fine with me.
Although, if you correct the cosmetic issues below, that will be great.


indra/newview/llpanelpermissions.cpp


Please separate comments from "//" with a space, i.e. write "// Check if..."



indra/newview/llpanelpermissions.cpp


CS: check_purchase or better check_purchase_cb



indra/newview/llpanelpermissions.cpp


dead code



indra/newview/llpanelpermissions.cpp


ditto


- Vadim


On June 29, 2011, 4:54 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 29, 2011, 4:54 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/de/floater_tools.xml b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Vadim Savchuk]

On 06/30/2011 09:57 AM, Kadah Coba wrote:
This is an automatically generated e-mail. To reply, visit: 
http://codereview.secondlife.com/r/377/



Review request for Viewer.
By Kadah Coba.


  Description

This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. 
Adjustments were made where needed to make it work with the newer boost and llui code. Some changes 
were made to the variable names it uses on build; ie "PX" for x position instead of just 
"X".

Patch allows for imputing simple math equations in to the spinner controls. On the build 
floater a series of variable names are available for using the objects current values in 
equations, like "sx+3" will take the current X scale and add 3.

I get an error when try to view the diff on Review Board. Please refresh 
it or create a new review request (not sure how to fix).


--
Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 1027
> > 
> >
> > CS: check_purchase or better check_purchase_cb

Same name is used else where in the legacy code, should I change both while I'm 
at it?


> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 1118
> > 
> >
> > dead code

Mistake while merging, will clean


> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 443
> > 
> >
> > Please separate comments from "//" with a space, i.e. write "// Check 
> > if..."

I don't think that was in the CS wiki doc. Will fix comments


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review831
---


On June 29, 2011, 4:54 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 29, 2011, 4:54 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/de/floater_tools.xml b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] focus to Inventory Search

[Lance Corrimal]

Am Donnerstag, 30. Juni 2011 schrieb Opensource Obscure:
> Please enable back focus to Inventory Search.
> 
> See https://jira.secondlife.com/browse/VWR-19700
> https://jira.secondlife.com/browse/VWR-18496
> https://jira.secondlife.com/browse/VWR-19967

https://jira.secondlife.com/browse/VWR-26169 as well.

LC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/
---

(Updated June 30, 2011, 10:33 a.m.)


Review request for Viewer.


Changes
---

Requested CS changes.
Would you like a clean fork with this as one changeset? The current fork got 
too messy for my standards.


Summary
---

This change makes it so setting an object for sale or modifying the price or 
sale type requires explicitly applying the changes. Default behavior before 
this patch is all sale info is committed to sim on change. After this patch the 
sale info will only get set or modified after hitting a "mark for sale" button. 
There is no change to removing an object from sale, unchecking "For sale" will 
be committed to sim without further user interation.

https://bitbucket.org/Kadah_Coba/vwr-21522
Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
German translation: 
https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588


This addresses bug VWR-21522.
http://jira.secondlife.com/browse/VWR-21522


Diffs (updated)
-

  doc/contributions.txt UNKNOWN 
  indra/newview/llpanelpermissions.h UNKNOWN 
  indra/newview/llpanelpermissions.cpp UNKNOWN 
  indra/newview/skins/default/xui/de/floater_tools.xml UNKNOWN 
  indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN 

Diff: http://codereview.secondlife.com/r/365/diff


Testing
---

(I had stuff here but Review Board kept deleting it every time I tried to save.)


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/370/#review834
---

Ship it!


No major objections.


indra/newview/llpanelwearing.cpp


Looks a bit confusing.


- Vadim


On June 30, 2011, 1:27 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/370/
> ---
> 
> (Updated June 30, 2011, 1:27 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add a feature on the "Wearing TAB" where users could copy to the clipboard 
> everything you see in the "Wearing TAB". This would make the blogging 
> communities life soo much easier instead of having to type out all that 
> information.
> 
> The label on this button needs input from someone on the XD team.
> 
> I would like to know if my code for adding a CR to the end of every line but 
> the last one could be done in a more elegant way.
> 
> 
> This addresses bug STORM-1459.
> http://jira.secondlife.com/browse/STORM-1459
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt f9864a43ddf0 
>   indra/newview/llpanelwearing.h f9864a43ddf0 
>   indra/newview/llpanelwearing.cpp f9864a43ddf0 
>   indra/newview/skins/default/xui/en/menu_wearing_gear.xml f9864a43ddf0 
> 
> Diff: http://codereview.secondlife.com/r/370/diff
> 
> 
> Testing
> ---
> 
> Clicked on Send to Clipboard button and was able to paste results into an 
> editor.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Vadim ProductEngine]

> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 1027
> > 
> >
> > CS: check_purchase or better check_purchase_cb
> 
> Kadah Coba wrote:
> Same name is used else where in the legacy code, should I change both 
> while I'm at it?

Well, you generally don't have to fix CS in code that you didn't modify.
But in this case the change seems to be small and related to your work, so 
please do.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review831
---


On June 30, 2011, 10:33 a.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 30, 2011, 10:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt UNKNOWN 
>   indra/newview/llpanelpermissions.h UNKNOWN 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
>   indra/newview/skins/default/xui/de/floater_tools.xml UNKNOWN 
>   indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated June 30, 2011, 11:56 a.m.)


Review request for Viewer.


Changes
---

Lets see if this diff wants to work.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  doc/contributions.txt UNKNOWN 
  indra/llmath/CMakeLists.txt UNKNOWN 
  indra/llmath/llcalc.h UNKNOWN 
  indra/llmath/llcalc.cpp UNKNOWN 
  indra/llmath/llcalcparser.h UNKNOWN 
  indra/llmath/llcalcparser.cpp UNKNOWN 
  indra/llui/lllineeditor.h UNKNOWN 
  indra/llui/lllineeditor.cpp UNKNOWN 
  indra/llui/llspinctrl.cpp UNKNOWN 
  indra/newview/llappviewer.cpp UNKNOWN 
  indra/newview/llpanelface.cpp UNKNOWN 
  indra/newview/llpanelobject.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated June 30, 2011, 11:59 a.m.)


Review request for Viewer.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  doc/contributions.txt 353807ed6a69 
  indra/llmath/CMakeLists.txt 353807ed6a69 
  indra/llmath/llcalc.h PRE-CREATION 
  indra/llmath/llcalc.cpp PRE-CREATION 
  indra/llmath/llcalcparser.h PRE-CREATION 
  indra/llmath/llcalcparser.cpp PRE-CREATION 
  indra/llui/lllineeditor.h 353807ed6a69 
  indra/llui/lllineeditor.cpp 353807ed6a69 
  indra/llui/llspinctrl.cpp 353807ed6a69 
  indra/newview/llappviewer.cpp 353807ed6a69 
  indra/newview/llpanelface.cpp 353807ed6a69 
  indra/newview/llpanelobject.cpp 353807ed6a69 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Fixed. Not sure why that didn't want to work the first two times.

On 6/30/2011 10:00 AM, Vadim Savchuk wrote:
> On 06/30/2011 09:57 AM, Kadah Coba wrote:
>> This is an automatically generated e-mail. To reply, visit:
>> http://codereview.secondlife.com/r/377/
>>
>>
>> Review request for Viewer.
>> By Kadah Coba.
>>
>>
>>   Description
>>
>> This is a direct adaptation of Aimee Trescothick's contributed patch from 
>> STORM-1315 for v-d. Adjustments were made where needed to make it work with 
>> the newer boost and llui code. Some changes were made to the variable names 
>> it uses on build; ie "PX" for x position instead of just "X".
>>
>> Patch allows for imputing simple math equations in to the spinner controls. 
>> On the build floater a series of variable names are available for using the 
>> objects current values in equations, like "sx+3" will take the current X 
>> scale and add 3.
>>
> I get an error when try to view the diff on Review Board. Please refresh
> it or create a new review request (not sure how to fix).
> 
> -- 
> Vadim
> 
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJODMfOAAoJEIdLfPRu7qE2QQMH/2FDPqJ2EdLIytCHUckc8xtt
9ihAlZTK53U7E+IGoi0tET8C5NexWZ7CXiTIRDkaCltAaS4WhNN8eFvKfAoUqD5M
8MVwc0gyYJ7xpTKSMmAnWICuiO38bQsT2Tj1fssk4H1xmt4crKv2LiSF80aBVAMD
jETiqD8zbsqmHJkMSp3G7LO2K4AD29Vq1983YV+JruYb9dmaBPg0oQgkcGYrjXbw
eT0j1RtmAK/MqcuSMC+5M2vfosyqMkUOZpOlIjUVIv23JdqvT7ViTX3btBBOXdmN
UGlff1SBRTd1+Bo4+Z4c5PL7D/nyhlyESgxafKDDNAL1of2FvdEPqHY9h3I4NAs=
=c9eC
-END PGP SIGNATURE-
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated June 30, 2011, 1:49 p.m.)


Review request for Viewer.


Changes
---

Support for floor, ceil, modulo.
Fixed ABS.
Added more constants, SQRT_TWO_PI and SQRT3.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  doc/contributions.txt UNKNOWN 
  indra/llmath/CMakeLists.txt UNKNOWN 
  indra/llmath/llcalc.h UNKNOWN 
  indra/llmath/llcalc.cpp UNKNOWN 
  indra/llmath/llcalcparser.h UNKNOWN 
  indra/llmath/llcalcparser.cpp UNKNOWN 
  indra/llui/lllineeditor.h UNKNOWN 
  indra/llui/lllineeditor.cpp UNKNOWN 
  indra/llui/llspinctrl.cpp UNKNOWN 
  indra/newview/llappviewer.cpp UNKNOWN 
  indra/newview/llpanelface.cpp UNKNOWN 
  indra/newview/llpanelobject.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated June 30, 2011, 1:50 p.m.)


Review request for Viewer.


Changes
---

I have no idea why review board keeps breaking my diffs. Trying again.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  doc/contributions.txt 353807ed6a69 
  indra/llmath/CMakeLists.txt 353807ed6a69 
  indra/llmath/llcalc.h PRE-CREATION 
  indra/llmath/llcalc.cpp PRE-CREATION 
  indra/llmath/llcalcparser.h PRE-CREATION 
  indra/llmath/llcalcparser.cpp PRE-CREATION 
  indra/llui/lllineeditor.h 353807ed6a69 
  indra/llui/lllineeditor.cpp 353807ed6a69 
  indra/llui/llspinctrl.cpp 353807ed6a69 
  indra/newview/llappviewer.cpp 353807ed6a69 
  indra/newview/llpanelface.cpp 353807ed6a69 
  indra/newview/llpanelobject.cpp 353807ed6a69 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges