Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Vadim ProductEngine]

> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote:
> > When I applied this latest patch to firestorm, which is based off of LL 
> > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of 
> > 256 to other regions.  I tried multiple times TPing from the area around 
> > help island public to magnum sandbox 4 or to help people island.  In every 
> > case I timed and was logged off after the TP was completed, as the viewer 
> > was cleaning up and closing connections to the old regions.  I don't have 
> > this problem with the first iteration of this patch.  I feel this scenario 
> > needs to be tested with this latest patch on v-dev tip to make sure this 
> > doesn't happen there as well.
> > 
> > The account I used only has 4 friends, and around 24 items in the inventory 
> > in addition to the library.  It also only has 2 attachments (a hud and the 
> > firestorm bridge) and is one of the noob outfits.  I also am running on an 
> > i7 2600k, 16GB ram, ATI 6970, and 20/5mbit FIOS connection.
> 
> Vadim ProductEngine wrote:
> Could you please provide exact steps to reproduce the issue?
> Have you tried reverting the patch and repeating the teleport attempt?
> 
> Tankmaster Finesmith wrote:
> I TPed to Help Island Public, which is on maind land, while running from 
> Visual Studio.  Draw distance set to 256.  Flew over orentation island and 
> proceeded onto another neighboring sim.  My viewer is now connected to 
> several different regions do to normal viewer behavior.  I then TP to magnum 
> sandbox 4 by tyeping that into the nav bar up top and pressing enter.  
> 
> First tried with the first patch, which we have had for several weeks now 
> in our repository:
> -TP was successful, then the viewer became rather unresponsive and the 
> logs say things related to "(ip address) time out exceeded, disconnecting" 
> but eventually recovers
> -repeated 3 times, last time I TPed to Help People Island instead and all 
> times got the same result
> 
> Second I tried with the updated patch:
> -TP was successful, then the viewer was completely unresponsive, and I 
> eventually got the ding from getting logged off and in the loges I see a mass 
> of "invalid packet from (IP address)"
> -repeated 3 times like and to the same regions (twice to magnum, once to 
> HPI) every time I got logged off
> 
> Third I reverted back to the first patch:
> Same experience as the first:
> -TP was successful, then the viewer became rather unresponsive and the 
> logs say things related to "(ip address) time out exceeded, disconnecting" 
> but eventually recovers
> -repeated 3 times, last time I TPed to HPI as I have in the other tests, 
> and all times got the same result 
> 
> 
> In talking with armin, he got similer results but thinks its the magnum 
> sandbox region that may be having problems.  I am not as sure on that as I 
> get it when TPing to HPI as well which is release server channle and not a RC 
> channle.

Thanks, Tankmaster. I tend to think that these errors are not related to the 
patch.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review819
---


On June 24, 2011, 4:45 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> ---
> 
> (Updated June 24, 2011, 4:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed 
> this fix along in the system.
> 
> 
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and 
> Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
> capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
> boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that 
> rezzes in, but the avatar, so do the request for the capability not earlier 
> than the agents region signals capabilitiesReceived() true. After that you 
> are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not 
> much data transmitted, though its a pretty big number of people doing it over 
> and over per second (no matter if they have voice on or off).
> 
> 
> 
> 
> going once again through llviewerregion I see its fortunately not each time a 
> HTTP GET, just once when the agent connects to the re

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review825
---


Looking good overall. Please fix the minor issues.


indra/newview/llpanelpermissions.cpp


What is the "KC" label for?



indra/newview/llpanelpermissions.cpp


Coding standard: rewrite as btn_mark_for_sale.



indra/newview/llpanelpermissions.cpp


ditto



indra/newview/llpanelpermissions.cpp


What does the comment mean?



indra/newview/llpanelpermissions.cpp


Please consider moving the duplicated code to a separate method like
enableMarkForSale(bool enabled);



indra/newview/llpanelpermissions.cpp


Follow the CS when naming local variables.


- Vadim


On June 27, 2011, 6:44 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 27, 2011, 6:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Avatar Scale and Camera Placement

[Lee ponzu]

There is a thought provoking discussion of avatar scale here...
http://www.sluniverse.com/php/vb/content-creation/61046-matter-scale-how-scale-affects.html
You've probably seen it, but if not, it is a worthwhile read.

One of the issues is default camera placement.  In brief, the default is too
far back and too high.  Of course, this is a matter of individual needs and
taste, but it suggested to me a useful "feature" for the viewer.

How about a few pre-packaged optional camera placement configurations in
preferences?  (Yes, experts can keep using the legacy sliders.)

Traditional:  Camera behavior as at present
Closer:  Camera is lower, closer, and more level, as suggested in the
thread.
Close:Maybe something half way between Traditional and Closest.
Crowd:   Farther than traditional

Then, make it easy to switch from one to another.  Funner/Faster/Easier!!!
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review824
---


Just a couple of minor items to address and this looks good.


remove the 'KC:' from your comments ... mercurial will tell us who to blame if 
we need to know :-)
I don't really think that the issue ids are needed either, but don't object to 
them.


indra/newview/llpanelpermissions.h


it would be clearer to spell that 'mLastSelectedObject' (transpose 'j' and 
'e')



indra/newview/llpanelpermissions.cpp


There's nothing else inside this 'else if' - why not add the check of 
update_sale_info to this statement rather than adding the nested if ?


- Oz


On June 27, 2011, 6:44 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 27, 2011, 6:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Basic Shaders and FPS

[Lee ponzu]

This is something I just discovered that I suppose most of you have always
known.

I was messing with my oldish iMac (ATI 2600 Pro) and I discovered that the
main thing that makes all the difference to FPS is the shaders.

Basic Shaders off:  FPS == 30 to 50.
Basic Shaders on:  FPS == 13 to 15

Similar effect for just Atmospheric or Shadows.

So, this made me crave a custom button for turning shaders on and off (yeah,
CMD-P/Graphics/Basic Shader is easy.  Just thinking of all the people who
don't even know that preferences exists  8-)  Need FPS?  <>.
 Want things to look better?  <>  Easy peasy.

BTW, I also briefly tested on my slightly newer Macbook Pro (nvidia 9400M).
Same ting, but the FPS difference is much less dramatic.

ponzu
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/370/
---

Review request for Viewer.


Summary
---

Add a feature on the "Wearing TAB" where users could copy to the clipboard 
everything you see in the "Wearing TAB". This would make the blogging 
communities life soo much easier instead of having to type out all that 
information.

The label on this button needs input from someone on the XD team.

I would like to know if my code for adding a CR to the end of every line but 
the last one could be done in a more elegant way.


This addresses bug STORM-1459.
http://jira.secondlife.com/browse/STORM-1459


Diffs
-

  doc/contributions.txt f9864a43ddf0 
  indra/newview/llpanelwearing.h f9864a43ddf0 
  indra/newview/llpanelwearing.cpp f9864a43ddf0 
  indra/newview/skins/default/xui/en/panel_outfits_wearing.xml f9864a43ddf0 

Diff: http://codereview.secondlife.com/r/370/diff


Testing
---

Clicked on Send to Clipboard button and was able to paste results into an 
editor.


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/370/#review826
---


Looks good apart from missing NULL check.


indra/newview/llpanelwearing.cpp


I'd use const_iterator instead.



indra/newview/llpanelwearing.cpp


A bit of code duplication.
I'd rewrite it like this:

/
if (!need_cr)
{
 need_cr = true;
}
else
{
 text += "\n";
}

text += item->getName();
/

Please also make sure the item is not NULL to prevent a crash.


- Vadim


On June 29, 2011, 7:32 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/370/
> ---
> 
> (Updated June 29, 2011, 7:32 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add a feature on the "Wearing TAB" where users could copy to the clipboard 
> everything you see in the "Wearing TAB". This would make the blogging 
> communities life soo much easier instead of having to type out all that 
> information.
> 
> The label on this button needs input from someone on the XD team.
> 
> I would like to know if my code for adding a CR to the end of every line but 
> the last one could be done in a more elegant way.
> 
> 
> This addresses bug STORM-1459.
> http://jira.secondlife.com/browse/STORM-1459
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt f9864a43ddf0 
>   indra/newview/llpanelwearing.h f9864a43ddf0 
>   indra/newview/llpanelwearing.cpp f9864a43ddf0 
>   indra/newview/skins/default/xui/en/panel_outfits_wearing.xml f9864a43ddf0 
> 
> Diff: http://codereview.secondlife.com/r/370/diff
> 
> 
> Testing
> ---
> 
> Clicked on Send to Clipboard button and was able to paste results into an 
> editor.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

> On June 29, 2011, 6:41 a.m., Oz Linden wrote:
> > indra/newview/llpanelpermissions.cpp, lines 477-480
> > 
> >
> > There's nothing else inside this 'else if' - why not add the check of 
> > update_sale_info to this statement rather than adding the nested if ?

The parent if ends with an 'else' that disables the inputs controls; a lot of 
the logic would need reworking. I'll poke it to see if can work the logic to 
handle this.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review824
---


On June 27, 2011, 6:44 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 27, 2011, 6:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

> On June 29, 2011, 6:37 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 245
> > 
> >
> > Coding standard: rewrite as btn_mark_for_sale.

Will do. As far as the XUI names, is there a standard for those? I've noted 
several different styles used and floater_tools uses one of the oldest I've 
seen.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review825
---


On June 27, 2011, 6:44 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 27, 2011, 6:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Basic Shaders and FPS

[Hitomi Tiponi]

That is why there are the Low-Medium-High-Ultra settings - so that people don't 
need to know about shaders, just that sliding the slider right makes things 
look 
better but slower.  The individual settings for each standard setting (e.g. 
Low) 
could be debated, but the approach seems to work pretty well. And it is not 
just 
shaders that make a big difference - LOD and Draw Distance also have  a big 
effect.

>I was messing with my oldish iMac (ATI 2600 Pro) and I discovered that the
> main thing that makes all the difference to FPS is the shaders.
...
>So, this made me crave a custom button for turning shaders on and off (yeah,
>CMD-P/Graphics/Basic Shader is easy.  Just thinking of all the people who
>don't even know that preferences exists  8-)  Need FPS?  <>.
>Want things to look better?  <>  Easy peasy.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/370/
---

(Updated June 29, 2011, 12:14 p.m.)


Review request for Viewer.


Changes
---

Made changes requested by Oz and Vadim and with help from Alexandrea Fride.


Summary
---

Add a feature on the "Wearing TAB" where users could copy to the clipboard 
everything you see in the "Wearing TAB". This would make the blogging 
communities life soo much easier instead of having to type out all that 
information.

The label on this button needs input from someone on the XD team.

I would like to know if my code for adding a CR to the end of every line but 
the last one could be done in a more elegant way.


This addresses bug STORM-1459.
http://jira.secondlife.com/browse/STORM-1459


Diffs (updated)
-

  doc/contributions.txt f9864a43ddf0 
  indra/newview/llpanelwearing.h f9864a43ddf0 
  indra/newview/llpanelwearing.cpp f9864a43ddf0 
  indra/newview/skins/default/xui/en/menu_wearing_gear.xml f9864a43ddf0 

Diff: http://codereview.secondlife.com/r/370/diff


Testing
---

Clicked on Send to Clipboard button and was able to paste results into an 
editor.


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/
---

(Updated June 29, 2011, 4:54 p.m.)


Review request for Viewer.


Changes
---

Added requested changes (I think I got them all)
Fixed issue where objects that are being actively changed by scripts would get 
prevented from being marked for sale


Summary
---

This change makes it so setting an object for sale or modifying the price or 
sale type requires explicitly applying the changes. Default behavior before 
this patch is all sale info is committed to sim on change. After this patch the 
sale info will only get set or modified after hitting a "mark for sale" button. 
There is no change to removing an object from sale, unchecking "For sale" will 
be committed to sim without further user interation.

https://bitbucket.org/Kadah_Coba/vwr-21522
Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
German translation: 
https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588


This addresses bug VWR-21522.
http://jira.secondlife.com/browse/VWR-21522


Diffs (updated)
-

  indra/newview/skins/default/xui/de/floater_tools.xml b245a988d038 
  indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
  indra/newview/llpanelpermissions.h b245a988d038 
  indra/newview/llpanelpermissions.cpp b245a988d038 

Diff: http://codereview.secondlife.com/r/365/diff


Testing
---

(I had stuff here but Review Board kept deleting it every time I tried to save.)


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/370/#review829
---


\n is a new line character(line-feed) \r is a carriage return. maybe change the 
comment to new line. 

- Nicky


On June 29, 2011, 12:14 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/370/
> ---
> 
> (Updated June 29, 2011, 12:14 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add a feature on the "Wearing TAB" where users could copy to the clipboard 
> everything you see in the "Wearing TAB". This would make the blogging 
> communities life soo much easier instead of having to type out all that 
> information.
> 
> The label on this button needs input from someone on the XD team.
> 
> I would like to know if my code for adding a CR to the end of every line but 
> the last one could be done in a more elegant way.
> 
> 
> This addresses bug STORM-1459.
> http://jira.secondlife.com/browse/STORM-1459
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt f9864a43ddf0 
>   indra/newview/llpanelwearing.h f9864a43ddf0 
>   indra/newview/llpanelwearing.cpp f9864a43ddf0 
>   indra/newview/skins/default/xui/en/menu_wearing_gear.xml f9864a43ddf0 
> 
> Diff: http://codereview.secondlife.com/r/370/diff
> 
> 
> Testing
> ---
> 
> Clicked on Send to Clipboard button and was able to paste results into an 
> editor.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

Review request for Viewer.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs
-

  doc/contributions.txt UNKNOWN 
  indra/llmath/CMakeLists.txt UNKNOWN 
  indra/llmath/llcalc.h UNKNOWN 
  indra/llmath/llcalc.cpp UNKNOWN 
  indra/llmath/llcalcparser.h UNKNOWN 
  indra/llmath/llcalcparser.cpp UNKNOWN 
  indra/llui/lllineeditor.h UNKNOWN 
  indra/llui/lllineeditor.cpp UNKNOWN 
  indra/llui/llspinctrl.cpp UNKNOWN 
  indra/newview/llappviewer.cpp UNKNOWN 
  indra/newview/llpanelface.cpp UNKNOWN 
  indra/newview/llpanelobject.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges