Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Vadim ProductEngine]

> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote:
> > When I applied this latest patch to firestorm, which is based off of LL 
> > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of 
> > 256 to other regions.  I tried multiple times TPing from the area around 
> > help island public to magnum sandbox 4 or to help people island.  In every 
> > case I timed and was logged off after the TP was completed, as the viewer 
> > was cleaning up and closing connections to the old regions.  I don't have 
> > this problem with the first iteration of this patch.  I feel this scenario 
> > needs to be tested with this latest patch on v-dev tip to make sure this 
> > doesn't happen there as well.
> > 
> > The account I used only has 4 friends, and around 24 items in the inventory 
> > in addition to the library.  It also only has 2 attachments (a hud and the 
> > firestorm bridge) and is one of the noob outfits.  I also am running on an 
> > i7 2600k, 16GB ram, ATI 6970, and 20/5mbit FIOS connection.

Could you please provide exact steps to reproduce the issue?
Have you tried reverting the patch and repeating the teleport attempt?


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review819
---


On June 24, 2011, 4:45 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> ---
> 
> (Updated June 24, 2011, 4:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed 
> this fix along in the system.
> 
> 
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and 
> Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
> capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
> boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that 
> rezzes in, but the avatar, so do the request for the capability not earlier 
> than the agents region signals capabilitiesReceived() true. After that you 
> are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not 
> much data transmitted, though its a pretty big number of people doing it over 
> and over per second (no matter if they have voice on or off).
> 
> 
> 
> 
> going once again through llviewerregion I see its fortunately not each time a 
> HTTP GET, just once when the agent connects to the region. Though the patch 
> still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
> http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 04e2a3ddca51 
>   indra/newview/llviewerregion.h 04e2a3ddca51 
>   indra/newview/llviewerregion.cpp 04e2a3ddca51 
>   indra/newview/llvoicevivox.h 04e2a3ddca51 
>   indra/newview/llvoicevivox.cpp 04e2a3ddca51 
> 
> Diff: http://codereview.secondlife.com/r/333/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Tankmaster Finesmith]

> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote:
> > When I applied this latest patch to firestorm, which is based off of LL 
> > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of 
> > 256 to other regions.  I tried multiple times TPing from the area around 
> > help island public to magnum sandbox 4 or to help people island.  In every 
> > case I timed and was logged off after the TP was completed, as the viewer 
> > was cleaning up and closing connections to the old regions.  I don't have 
> > this problem with the first iteration of this patch.  I feel this scenario 
> > needs to be tested with this latest patch on v-dev tip to make sure this 
> > doesn't happen there as well.
> > 
> > The account I used only has 4 friends, and around 24 items in the inventory 
> > in addition to the library.  It also only has 2 attachments (a hud and the 
> > firestorm bridge) and is one of the noob outfits.  I also am running on an 
> > i7 2600k, 16GB ram, ATI 6970, and 20/5mbit FIOS connection.
> 
> Vadim ProductEngine wrote:
> Could you please provide exact steps to reproduce the issue?
> Have you tried reverting the patch and repeating the teleport attempt?

I TPed to Help Island Public, which is on maind land, while running from Visual 
Studio.  Draw distance set to 256.  Flew over orentation island and proceeded 
onto another neighboring sim.  My viewer is now connected to several different 
regions do to normal viewer behavior.  I then TP to magnum sandbox 4 by tyeping 
that into the nav bar up top and pressing enter.  

First tried with the first patch, which we have had for several weeks now in 
our repository:
-TP was successful, then the viewer became rather unresponsive and the logs say 
things related to "(ip address) time out exceeded, disconnecting" but 
eventually recovers
-repeated 3 times, last time I TPed to Help People Island instead and all times 
got the same result

Second I tried with the updated patch:
-TP was successful, then the viewer was completely unresponsive, and I 
eventually got the ding from getting logged off and in the loges I see a mass 
of "invalid packet from (IP address)"
-repeated 3 times like and to the same regions (twice to magnum, once to HPI) 
every time I got logged off

Third I reverted back to the first patch:
Same experience as the first:
-TP was successful, then the viewer became rather unresponsive and the logs say 
things related to "(ip address) time out exceeded, disconnecting" but 
eventually recovers
-repeated 3 times, last time I TPed to HPI as I have in the other tests, and 
all times got the same result 


In talking with armin, he got similer results but thinks its the magnum sandbox 
region that may be having problems.  I am not as sure on that as I get it when 
TPing to HPI as well which is release server channle and not a RC channle.


- Tankmaster


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review819
---


On June 24, 2011, 4:45 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> ---
> 
> (Updated June 24, 2011, 4:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed 
> this fix along in the system.
> 
> 
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and 
> Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
> capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
> boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that 
> rezzes in, but the avatar, so do the request for the capability not earlier 
> than the agents region signals capabilitiesReceived() true. After that you 
> are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not 
> much data transmitted, though its a pretty big number of people doing it over 
> and over per second (no matter if they have voice on or off).
> 
> 
> 
> 
> going once again through llviewerregion I see its fortunately not each time a 
> HTTP GET, just once when the agent connects to the region. Though the patch 
> still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
> http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 04e2a3ddca

Re: [opensource-dev] Snowstorm PO review build

[Kadah]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

STORM-787
There is an unclosed (likely also truncated) check_box entry at
panel_preferences_sound.xml@346. This is preventing the rest of the
panel from being displayed. Looks like a bad merge.

On 6/26/2011 8:12 PM, Twisted Laws wrote:
> STORM-787   - setting not
> displayed in preferences media
> Mute Gestures Button 
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOCh40AAoJEIdLfPRu7qE2WJEIALN9FOKjlAsnjN2MZsndOJiZ
WQdGynreisLaLTh9ztmwlQQNSOdlX8KNQFbHjmx4EU2L1E43n05QSD4pZR3fKK4Q
MQJ0BaA7vvAOIG5oLMrEbZ1jiVBJnl+509WS1RldGVV6qP8gl0Uib8GN3oVTLbsQ
q41Jk1tGLOgqHa1fvf7sO682uMsdzk7IwOlfzYYX5prjnZomCdrhcerLHXhR7gjV
VqZ2wrjadwRutovvuW2bwZhHBEeS2O3uYVp0MA5Z5CAOWJkyy2dqX+sYPQ507R9C
RWMu8N2FYFjm0ClJBClJkpvzAxFjv3mjpG/T1O/Ak1Vi+YStrkMh4v4SakXW2kU=
=JTsF
-END PGP SIGNATURE-
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Shader typo

[Sythos]

SecondLife-i686-2.7.6.233972/app_settings/shaders/class2/deferred/sunlightSSAOMSF.glsl

should be sunLightSSAOMSF.glsl

renaming turn ON again shadows
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Revised review build

[Oz Linden (Scott Lawrence)]

This adds an issue or two, fixes a merge problem in the sound 
preferences panel that messed up a couple of the issues in the previous 
build, and omits some issues that have been approved and merged to 
viewer-development.


http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/234235/index.html

EXP-825 
   [#STORM-1439] [crashhunters] crash in LLToolPie::handleMouseUp 
STORM-457 

   There is no space char after [AGENT_NAME] in
   'conference-title-incoming' for Japanese language 
STORM-787 
   Mute Gestures Button 
STORM-1325 

   The viewer doesn't retry to upload baked textures if the initial
   upload failed 
STORM-1327 

   MULTIPLE LANGS (Spanish/German) [FORMATTING] Overlapped text in
   About Land Window when the land is for sell: "Los objetos se
   incluyen en la venta" 
STORM-1372 

   [crashhunters] crash at [1] LLTemplateMessageBuilder::nextBlock(char
   const *) [secondlife-bin lltemplatemessagebuilder.cpp] 
STORM-1392 
   Add Nearby Voice to the Communicate menu 
STORM-1396 
   Storm-787 (mute gestures) also mutes sounds from objects 
STORM-1406 

   [ENG LAYOUT] Viewer - Overlapping text in Input/Output devices
   preference 
STORM-1452 

   Debug settings -- TRUE/FALSE name (not label) translated in foreign
   languages 
VWR-21522 
   [#STORM-1453] Prevent unintended 10L sale 
VWR-24099 

   [#STORM-1372] [crashhunters] crash at [1]
   LLTemplateMessageBuilder::nextBlock(char const *) [secondlife-bin
   lltemplatemessagebuilder.cpp] 
VWR-25062 

   [#STORM-1346] Add the ability to allow or deny domains that parcel
   owners want to play in the viewer's media and audio players 




___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges